[INFO] cloning repository https://github.com/Vinz2008/media_renamer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Vinz2008/media_renamer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVinz2008%2Fmedia_renamer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVinz2008%2Fmedia_renamer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f94c1b12a759365fe3198baca2ffc36c28b10d59 [INFO] linting Vinz2008/media_renamer against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVinz2008%2Fmedia_renamer" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Vinz2008/media_renamer [INFO] finished tweaking git repo https://github.com/Vinz2008/media_renamer [INFO] tweaked toml for git repo https://github.com/Vinz2008/media_renamer written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Vinz2008/media_renamer on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Vinz2008/media_renamer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7809ca6318c27290df72991da4884bb50339818c222b0f4baa5bc3129edc135e [INFO] running `Command { std: "docker" "start" "-a" "7809ca6318c27290df72991da4884bb50339818c222b0f4baa5bc3129edc135e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7809ca6318c27290df72991da4884bb50339818c222b0f4baa5bc3129edc135e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7809ca6318c27290df72991da4884bb50339818c222b0f4baa5bc3129edc135e", kill_on_drop: false }` [INFO] [stdout] 7809ca6318c27290df72991da4884bb50339818c222b0f4baa5bc3129edc135e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3e7d0c8714d6766d26e8bdb3775cbe7356ee6400ab95fa0b62fb526cd84c91a0 [INFO] running `Command { std: "docker" "start" "-a" "3e7d0c8714d6766d26e8bdb3775cbe7356ee6400ab95fa0b62fb526cd84c91a0", kill_on_drop: false }` [INFO] [stderr] Checking media_renamer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/args.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 67 | Args { folder_path: folder_path, mode : mode, is_help_mode: is_help_mode} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `folder_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/args.rs:67:38 [INFO] [stdout] | [INFO] [stdout] 67 | Args { folder_path: folder_path, mode : mode, is_help_mode: is_help_mode} [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `mode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/args.rs:67:51 [INFO] [stdout] | [INFO] [stdout] 67 | Args { folder_path: folder_path, mode : mode, is_help_mode: is_help_mode} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_help_mode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/args.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 67 | Args { folder_path: folder_path, mode : mode, is_help_mode: is_help_mode} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `folder_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/args.rs:67:38 [INFO] [stdout] | [INFO] [stdout] 67 | Args { folder_path: folder_path, mode : mode, is_help_mode: is_help_mode} [INFO] [stdout] | ^^^^^^^^^^^ help: replace it with: `mode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/args.rs:67:51 [INFO] [stdout] | [INFO] [stdout] 67 | Args { folder_path: folder_path, mode : mode, is_help_mode: is_help_mode} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_help_mode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/args.rs:42:16 [INFO] [stdout] | [INFO] [stdout] 42 | if !arg.parse::().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `arg.parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/args.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | pos = pos + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/args.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | pos = pos + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/args.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | pos = pos + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/parser.rs:13:17 [INFO] [stdout] | [INFO] [stdout] 13 | number_pos = number_pos+1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `number_pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/parser.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | pos = pos + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/parser.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | pos = pos + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/parser.rs:64:32 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn dash_remover(filename : &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 64 ~ pub fn dash_remover(filename : &str) -> String { [INFO] [stdout] 65 ~ let mut new_filename = filename.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/parser.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | pos = pos + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/parser.rs:78:17 [INFO] [stdout] | [INFO] [stdout] 78 | pos = pos + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/parser.rs:84:17 [INFO] [stdout] | [INFO] [stdout] 84 | pos = pos + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/parser.rs:90:37 [INFO] [stdout] | [INFO] [stdout] 90 | new_filename.remove(pos_start as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `pos_start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/parser.rs:91:17 [INFO] [stdout] | [INFO] [stdout] 91 | pos_removing = pos_removing+1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pos_removing += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/parser.rs:99:13 [INFO] [stdout] | [INFO] [stdout] 99 | pos = pos + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/parser.rs:105:34 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn remove_pattern(filename : &String, pattern : &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 105 - pub fn remove_pattern(filename : &String, pattern : &String) -> String { [INFO] [stdout] 105 + pub fn remove_pattern(filename : &str, pattern : &String) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/help.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 3 - print!("\n"); [INFO] [stdout] 3 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/args.rs:42:16 [INFO] [stdout] | [INFO] [stdout] 42 | if !arg.parse::().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `arg.parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/args.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | pos = pos + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/args.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | pos = pos + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/args.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 65 | pos = pos + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/parser.rs:13:17 [INFO] [stdout] | [INFO] [stdout] 13 | number_pos = number_pos+1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `number_pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/parser.rs:19:17 [INFO] [stdout] | [INFO] [stdout] 19 | pos = pos + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/parser.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | pos = pos + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/parser.rs:64:32 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn dash_remover(filename : &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 64 ~ pub fn dash_remover(filename : &str) -> String { [INFO] [stdout] 65 ~ let mut new_filename = filename.to_owned(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/parser.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | pos = pos + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/parser.rs:78:17 [INFO] [stdout] | [INFO] [stdout] 78 | pos = pos + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/parser.rs:84:17 [INFO] [stdout] | [INFO] [stdout] 84 | pos = pos + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/parser.rs:90:37 [INFO] [stdout] | [INFO] [stdout] 90 | new_filename.remove(pos_start as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `pos_start` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/parser.rs:91:17 [INFO] [stdout] | [INFO] [stdout] 91 | pos_removing = pos_removing+1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pos_removing += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/parser.rs:99:13 [INFO] [stdout] | [INFO] [stdout] 99 | pos = pos + 1; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `pos += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/parser.rs:105:34 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn remove_pattern(filename : &String, pattern : &String) -> String { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 105 - pub fn remove_pattern(filename : &String, pattern : &String) -> String { [INFO] [stdout] 105 + pub fn remove_pattern(filename : &str, pattern : &String) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/help.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 3 - print!("\n"); [INFO] [stdout] 3 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/tests.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | / mod tests { [INFO] [stdout] 3 | | #[test] [INFO] [stdout] 4 | | fn season_append_one_number() { [INFO] [stdout] 5 | | let filename = "series - 1 - [BDrip] - (2022)".to_string(); [INFO] [stdout] ... | [INFO] [stdout] 66 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.21s [INFO] running `Command { std: "docker" "inspect" "3e7d0c8714d6766d26e8bdb3775cbe7356ee6400ab95fa0b62fb526cd84c91a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e7d0c8714d6766d26e8bdb3775cbe7356ee6400ab95fa0b62fb526cd84c91a0", kill_on_drop: false }` [INFO] [stdout] 3e7d0c8714d6766d26e8bdb3775cbe7356ee6400ab95fa0b62fb526cd84c91a0