[INFO] cloning repository https://github.com/VikingOwl91/polyscribe [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/VikingOwl91/polyscribe" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVikingOwl91%2Fpolyscribe", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVikingOwl91%2Fpolyscribe'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 49513d5099d64deaddc0d11d2e7e182452e08bd9 [INFO] linting VikingOwl91/polyscribe against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVikingOwl91%2Fpolyscribe" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/VikingOwl91/polyscribe [INFO] finished tweaking git repo https://github.com/VikingOwl91/polyscribe [INFO] tweaked toml for git repo https://github.com/VikingOwl91/polyscribe written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/VikingOwl91/polyscribe on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/VikingOwl91/polyscribe already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://github.com/tazz4843/whisper-rs` [INFO] [stderr] Updating git submodule `https://github.com/ggerganov/whisper.cpp` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded fs_extra v1.3.0 [INFO] [stderr] Downloaded toml_write v0.1.2 [INFO] [stderr] Downloaded toml v0.8.23 [INFO] [stderr] Downloaded windows-registry v0.5.3 [INFO] [stderr] Downloaded windows-targets v0.53.3 [INFO] [stderr] Downloaded libloading v0.8.8 [INFO] [stderr] Downloaded once_cell_polyfill v1.70.1 [INFO] [stderr] Downloaded anstyle-wincon v3.0.10 [INFO] [stderr] Downloaded roff v0.2.2 [INFO] [stderr] Downloaded anstyle v1.0.11 [INFO] [stderr] Downloaded clap_lex v0.7.5 [INFO] [stderr] Downloaded anstyle-query v1.1.4 [INFO] [stderr] Downloaded anstream v0.6.20 [INFO] [stderr] Downloaded clap_mangen v0.2.29 [INFO] [stderr] Downloaded rustc-demangle v0.1.26 [INFO] [stderr] Downloaded clap_derive v4.5.41 [INFO] [stderr] Downloaded anyhow v1.0.98 [INFO] [stderr] Downloaded clap v4.5.43 [INFO] [stderr] Downloaded rustls-pki-types v1.12.0 [INFO] [stderr] Downloaded hyper-util v0.1.16 [INFO] [stderr] Downloaded tower-http v0.6.6 [INFO] [stderr] Downloaded tokio-util v0.7.16 [INFO] [stderr] Downloaded h2 v0.4.12 [INFO] [stderr] Downloaded zerovec v0.11.4 [INFO] [stderr] Downloaded clap_builder v4.5.43 [INFO] [stderr] Downloaded reqwest v0.12.22 [INFO] [stderr] Downloaded serde_json v1.0.142 [INFO] [stderr] Downloaded cc v1.2.31 [INFO] [stderr] Downloaded rustls-webpki v0.103.4 [INFO] [stderr] Downloaded socket2 v0.6.0 [INFO] [stderr] Downloaded clap_complete v4.5.56 [INFO] [stderr] Downloaded prettyplease v0.2.36 [INFO] [stderr] Downloaded rustls v0.23.31 [INFO] [stderr] Downloaded cmake v0.1.54 [INFO] [stderr] Downloaded tokio v1.47.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d88b806143a1db093808758a674cac4fcac1c94c7a4661e3d44009736a69c8d7 [INFO] running `Command { std: "docker" "start" "-a" "d88b806143a1db093808758a674cac4fcac1c94c7a4661e3d44009736a69c8d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d88b806143a1db093808758a674cac4fcac1c94c7a4661e3d44009736a69c8d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d88b806143a1db093808758a674cac4fcac1c94c7a4661e3d44009736a69c8d7", kill_on_drop: false }` [INFO] [stdout] d88b806143a1db093808758a674cac4fcac1c94c7a4661e3d44009736a69c8d7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 38785f35fdbc86dc8ee73a001c60a621313b330d40ec1710dfdda3d23e25636f [INFO] running `Command { std: "docker" "start" "-a" "38785f35fdbc86dc8ee73a001c60a621313b330d40ec1710dfdda3d23e25636f", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Compiling cc v1.2.31 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Compiling glob v0.3.2 [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Compiling prettyplease v0.2.36 [INFO] [stderr] Checking http v1.3.1 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling memchr v2.7.5 [INFO] [stderr] Compiling cfg-if v1.0.1 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Compiling regex-syntax v0.8.5 [INFO] [stderr] Compiling minimal-lexical v0.2.1 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Compiling libloading v0.8.8 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Compiling bindgen v0.71.1 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking indexmap v2.10.0 [INFO] [stderr] Compiling typenum v1.18.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Compiling regex-automata v0.4.9 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling rustc-hash v2.1.1 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling log v0.4.27 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Compiling openssl v0.10.73 [INFO] [stderr] Compiling cmake v0.1.54 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling regex v1.11.1 [INFO] [stderr] Checking anstyle-query v1.1.4 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Checking anstream v0.6.20 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Compiling clap_derive v4.5.41 [INFO] [stderr] Checking clap_builder v4.5.43 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Compiling serde_json v1.0.142 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking iri-string v0.7.8 [INFO] [stderr] Compiling anyhow v1.0.98 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking winnow v0.7.12 [INFO] [stderr] Compiling whisper-rs v0.14.3 (https://github.com/tazz4843/whisper-rs#135b60b8) [INFO] [stderr] Checking toml_write v0.1.2 [INFO] [stderr] Checking rustls-pki-types v1.12.0 [INFO] [stderr] Checking clap v4.5.43 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking roff v0.2.2 [INFO] [stderr] Checking cpufeatures v0.2.17 [INFO] [stderr] Compiling rustix v1.0.8 [INFO] [stderr] Checking iana-time-zone v0.1.63 [INFO] [stderr] Compiling polyscribe v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking clap_mangen v0.2.29 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking clap_complete v4.5.56 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking linux-raw-sys v0.9.4 [INFO] [stderr] Checking fastrand v2.3.0 [INFO] [stderr] Checking hyper-util v0.1.16 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking tempfile v3.20.0 [INFO] [stderr] Compiling whisper-rs-sys v0.13.0 (https://github.com/tazz4843/whisper-rs#135b60b8) [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.22 [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/backend.rs:312:5 [INFO] [stdout] | [INFO] [stdout] 312 | / if let Some(lang) = lang_opt { [INFO] [stdout] 313 | | if is_en_only && lang != "en" { [INFO] [stdout] 314 | | return Err(anyhow!( [INFO] [stdout] 315 | | "Selected model is English-only ({}), but a non-English language hint '{}' was provided. Please use a multilingua... [INFO] [stdout] ... | [INFO] [stdout] 320 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | #![warn(clippy::all)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 312 ~ if let Some(lang) = lang_opt [INFO] [stdout] 313 ~ && is_en_only && lang != "en" { [INFO] [stdout] 314 | return Err(anyhow!( [INFO] [stdout] ... [INFO] [stdout] 318 | )); [INFO] [stdout] 319 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/backend.rs:312:5 [INFO] [stdout] | [INFO] [stdout] 312 | / if let Some(lang) = lang_opt { [INFO] [stdout] 313 | | if is_en_only && lang != "en" { [INFO] [stdout] 314 | | return Err(anyhow!( [INFO] [stdout] 315 | | "Selected model is English-only ({}), but a non-English language hint '{}' was provided. Please use a multilingua... [INFO] [stdout] ... | [INFO] [stdout] 320 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | #![warn(clippy::all)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 312 ~ if let Some(lang) = lang_opt [INFO] [stdout] 313 ~ && is_en_only && lang != "en" { [INFO] [stdout] 314 | return Err(anyhow!( [INFO] [stdout] ... [INFO] [stdout] 318 | )); [INFO] [stdout] 319 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/models.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | / if let Some(oid) = &lfs.oid { [INFO] [stdout] 136 | | if let Some(rest) = oid.strip_prefix("sha256:") { [INFO] [stdout] 137 | | return Some(rest.to_lowercase().to_string()); [INFO] [stdout] 138 | | } [INFO] [stdout] 139 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 135 ~ if let Some(oid) = &lfs.oid [INFO] [stdout] 136 ~ && let Some(rest) = oid.strip_prefix("sha256:") { [INFO] [stdout] 137 | return Some(rest.to_lowercase().to_string()); [INFO] [stdout] 138 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/models.rs:297:13 [INFO] [stdout] | [INFO] [stdout] 297 | / if m.size == 0 { [INFO] [stdout] 298 | | if let Some(s) = sz { [INFO] [stdout] 299 | | m.size = s; [INFO] [stdout] 300 | | } [INFO] [stdout] 301 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 297 ~ if m.size == 0 [INFO] [stdout] 298 ~ && let Some(s) = sz { [INFO] [stdout] 299 | m.size = s; [INFO] [stdout] 300 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `idx` is used as a loop counter [INFO] [stdout] --> src/models.rs:371:5 [INFO] [stdout] | [INFO] [stdout] 371 | for m in models.iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (idx, m) in (1usize..).zip(models.iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/models.rs:489:29 [INFO] [stdout] | [INFO] [stdout] 489 | / ... if let (Ok(ia), Ok(ib)) = (a.parse::(), b.parse::()) { [INFO] [stdout] 490 | | ... if ia >= 1 && ib < idx && ia <= ib { [INFO] [stdout] 491 | | ... selected.extend(ia..=ib); [INFO] [stdout] 492 | | ... } [INFO] [stdout] 493 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 489 ~ if let (Ok(ia), Ok(ib)) = (a.parse::(), b.parse::()) [INFO] [stdout] 490 ~ && ia >= 1 && ib < idx && ia <= ib { [INFO] [stdout] 491 | selected.extend(ia..=ib); [INFO] [stdout] 492 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/models.rs:494:32 [INFO] [stdout] | [INFO] [stdout] 494 | } else if let Ok(i) = part.parse::() { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 495 | | if i >= 1 && i < idx { [INFO] [stdout] 496 | | selected.push(i); [INFO] [stdout] 497 | | } [INFO] [stdout] 498 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 494 ~ } else if let Ok(i) = part.parse::() [INFO] [stdout] 495 ~ && i >= 1 && i < idx { [INFO] [stdout] 496 | selected.push(i); [INFO] [stdout] 497 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/models.rs:135:9 [INFO] [stdout] | [INFO] [stdout] 135 | / if let Some(oid) = &lfs.oid { [INFO] [stdout] 136 | | if let Some(rest) = oid.strip_prefix("sha256:") { [INFO] [stdout] 137 | | return Some(rest.to_lowercase().to_string()); [INFO] [stdout] 138 | | } [INFO] [stdout] 139 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 135 ~ if let Some(oid) = &lfs.oid [INFO] [stdout] 136 ~ && let Some(rest) = oid.strip_prefix("sha256:") { [INFO] [stdout] 137 | return Some(rest.to_lowercase().to_string()); [INFO] [stdout] 138 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/models.rs:297:13 [INFO] [stdout] | [INFO] [stdout] 297 | / if m.size == 0 { [INFO] [stdout] 298 | | if let Some(s) = sz { [INFO] [stdout] 299 | | m.size = s; [INFO] [stdout] 300 | | } [INFO] [stdout] 301 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 297 ~ if m.size == 0 [INFO] [stdout] 298 ~ && let Some(s) = sz { [INFO] [stdout] 299 | m.size = s; [INFO] [stdout] 300 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `idx` is used as a loop counter [INFO] [stdout] --> src/models.rs:371:5 [INFO] [stdout] | [INFO] [stdout] 371 | for m in models.iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (idx, m) in (1usize..).zip(models.iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/models.rs:489:29 [INFO] [stdout] | [INFO] [stdout] 489 | / ... if let (Ok(ia), Ok(ib)) = (a.parse::(), b.parse::()) { [INFO] [stdout] 490 | | ... if ia >= 1 && ib < idx && ia <= ib { [INFO] [stdout] 491 | | ... selected.extend(ia..=ib); [INFO] [stdout] 492 | | ... } [INFO] [stdout] 493 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 489 ~ if let (Ok(ia), Ok(ib)) = (a.parse::(), b.parse::()) [INFO] [stdout] 490 ~ && ia >= 1 && ib < idx && ia <= ib { [INFO] [stdout] 491 | selected.extend(ia..=ib); [INFO] [stdout] 492 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/models.rs:494:32 [INFO] [stdout] | [INFO] [stdout] 494 | } else if let Ok(i) = part.parse::() { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 495 | | if i >= 1 && i < idx { [INFO] [stdout] 496 | | selected.push(i); [INFO] [stdout] 497 | | } [INFO] [stdout] 498 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 494 ~ } else if let Ok(i) = part.parse::() [INFO] [stdout] 495 ~ && i >= 1 && i < idx { [INFO] [stdout] 496 | selected.push(i); [INFO] [stdout] 497 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:308:5 [INFO] [stdout] | [INFO] [stdout] 308 | / if let Ok(xdg) = env::var("XDG_DATA_HOME") { [INFO] [stdout] 309 | | if !xdg.is_empty() { [INFO] [stdout] 310 | | return PathBuf::from(xdg).join("polyscribe").join("models"); [INFO] [stdout] 311 | | } [INFO] [stdout] 312 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 308 ~ if let Ok(xdg) = env::var("XDG_DATA_HOME") [INFO] [stdout] 309 ~ && !xdg.is_empty() { [INFO] [stdout] 310 | return PathBuf::from(xdg).join("polyscribe").join("models"); [INFO] [stdout] 311 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:313:5 [INFO] [stdout] | [INFO] [stdout] 313 | / if let Ok(home) = env::var("HOME") { [INFO] [stdout] 314 | | if !home.is_empty() { [INFO] [stdout] 315 | | return PathBuf::from(home) [INFO] [stdout] 316 | | .join(".local") [INFO] [stdout] ... | [INFO] [stdout] 321 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 313 ~ if let Ok(home) = env::var("HOME") [INFO] [stdout] 314 ~ && !home.is_empty() { [INFO] [stdout] 315 | return PathBuf::from(home) [INFO] [stdout] ... [INFO] [stdout] 319 | .join("models"); [INFO] [stdout] 320 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:438:9 [INFO] [stdout] | [INFO] [stdout] 438 | / if path.is_file() { [INFO] [stdout] 439 | | if let Some(ext) = path [INFO] [stdout] 440 | | .extension() [INFO] [stdout] 441 | | .and_then(|s| s.to_str()) [INFO] [stdout] ... | [INFO] [stdout] 448 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 438 ~ if path.is_file() [INFO] [stdout] 439 ~ && let Some(ext) = path [INFO] [stdout] 440 | .extension() [INFO] [stdout] ... [INFO] [stdout] 446 | } [INFO] [stdout] 447 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:439:13 [INFO] [stdout] | [INFO] [stdout] 439 | / if let Some(ext) = path [INFO] [stdout] 440 | | .extension() [INFO] [stdout] 441 | | .and_then(|s| s.to_str()) [INFO] [stdout] 442 | | .map(|s| s.to_lowercase()) [INFO] [stdout] ... | [INFO] [stdout] 447 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 442 ~ .map(|s| s.to_lowercase()) [INFO] [stdout] 443 ~ && ext == "bin" { [INFO] [stdout] 444 | candidates.push(path); [INFO] [stdout] 445 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:481:17 [INFO] [stdout] | [INFO] [stdout] 481 | / if path.is_file() { [INFO] [stdout] 482 | | if let Some(ext) = path [INFO] [stdout] 483 | | .extension() [INFO] [stdout] 484 | | .and_then(|s| s.to_str()) [INFO] [stdout] ... | [INFO] [stdout] 491 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 481 ~ if path.is_file() [INFO] [stdout] 482 ~ && let Some(ext) = path [INFO] [stdout] 483 | .extension() [INFO] [stdout] ... [INFO] [stdout] 489 | } [INFO] [stdout] 490 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:482:21 [INFO] [stdout] | [INFO] [stdout] 482 | / if let Some(ext) = path [INFO] [stdout] 483 | | .extension() [INFO] [stdout] 484 | | .and_then(|s| s.to_str()) [INFO] [stdout] 485 | | .map(|s| s.to_lowercase()) [INFO] [stdout] ... | [INFO] [stdout] 490 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 485 ~ .map(|s| s.to_lowercase()) [INFO] [stdout] 486 ~ && ext == "bin" { [INFO] [stdout] 487 | candidates.push(path); [INFO] [stdout] 488 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:308:5 [INFO] [stdout] | [INFO] [stdout] 308 | / if let Ok(xdg) = env::var("XDG_DATA_HOME") { [INFO] [stdout] 309 | | if !xdg.is_empty() { [INFO] [stdout] 310 | | return PathBuf::from(xdg).join("polyscribe").join("models"); [INFO] [stdout] 311 | | } [INFO] [stdout] 312 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 308 ~ if let Ok(xdg) = env::var("XDG_DATA_HOME") [INFO] [stdout] 309 ~ && !xdg.is_empty() { [INFO] [stdout] 310 | return PathBuf::from(xdg).join("polyscribe").join("models"); [INFO] [stdout] 311 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:313:5 [INFO] [stdout] | [INFO] [stdout] 313 | / if let Ok(home) = env::var("HOME") { [INFO] [stdout] 314 | | if !home.is_empty() { [INFO] [stdout] 315 | | return PathBuf::from(home) [INFO] [stdout] 316 | | .join(".local") [INFO] [stdout] ... | [INFO] [stdout] 321 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 313 ~ if let Ok(home) = env::var("HOME") [INFO] [stdout] 314 ~ && !home.is_empty() { [INFO] [stdout] 315 | return PathBuf::from(home) [INFO] [stdout] ... [INFO] [stdout] 319 | .join("models"); [INFO] [stdout] 320 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:438:9 [INFO] [stdout] | [INFO] [stdout] 438 | / if path.is_file() { [INFO] [stdout] 439 | | if let Some(ext) = path [INFO] [stdout] 440 | | .extension() [INFO] [stdout] 441 | | .and_then(|s| s.to_str()) [INFO] [stdout] ... | [INFO] [stdout] 448 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 438 ~ if path.is_file() [INFO] [stdout] 439 ~ && let Some(ext) = path [INFO] [stdout] 440 | .extension() [INFO] [stdout] ... [INFO] [stdout] 446 | } [INFO] [stdout] 447 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:439:13 [INFO] [stdout] | [INFO] [stdout] 439 | / if let Some(ext) = path [INFO] [stdout] 440 | | .extension() [INFO] [stdout] 441 | | .and_then(|s| s.to_str()) [INFO] [stdout] 442 | | .map(|s| s.to_lowercase()) [INFO] [stdout] ... | [INFO] [stdout] 447 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 442 ~ .map(|s| s.to_lowercase()) [INFO] [stdout] 443 ~ && ext == "bin" { [INFO] [stdout] 444 | candidates.push(path); [INFO] [stdout] 445 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:481:17 [INFO] [stdout] | [INFO] [stdout] 481 | / if path.is_file() { [INFO] [stdout] 482 | | if let Some(ext) = path [INFO] [stdout] 483 | | .extension() [INFO] [stdout] 484 | | .and_then(|s| s.to_str()) [INFO] [stdout] ... | [INFO] [stdout] 491 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 481 ~ if path.is_file() [INFO] [stdout] 482 ~ && let Some(ext) = path [INFO] [stdout] 483 | .extension() [INFO] [stdout] ... [INFO] [stdout] 489 | } [INFO] [stdout] 490 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:482:21 [INFO] [stdout] | [INFO] [stdout] 482 | / if let Some(ext) = path [INFO] [stdout] 483 | | .extension() [INFO] [stdout] 484 | | .and_then(|s| s.to_str()) [INFO] [stdout] 485 | | .map(|s| s.to_lowercase()) [INFO] [stdout] ... | [INFO] [stdout] 490 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 485 ~ .map(|s| s.to_lowercase()) [INFO] [stdout] 486 ~ && ext == "bin" { [INFO] [stdout] 487 | candidates.push(path); [INFO] [stdout] 488 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> tests/integration_cli.rs:447:9 [INFO] [stdout] | [INFO] [stdout] 447 | / if let Some(name) = p.file_name().and_then(|s| s.to_str()) { [INFO] [stdout] 448 | | if name.ends_with(".json") { [INFO] [stdout] 449 | | json_paths.push(p.clone()); [INFO] [stdout] 450 | | } [INFO] [stdout] 451 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 447 ~ if let Some(name) = p.file_name().and_then(|s| s.to_str()) [INFO] [stdout] 448 ~ && name.ends_with(".json") { [INFO] [stdout] 449 | json_paths.push(p.clone()); [INFO] [stdout] 450 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | / if let Some((prefix, rest)) = raw.split_once('-') { [INFO] [stdout] 125 | | if !prefix.is_empty() && prefix.chars().all(|c| c.is_ascii_digit()) { [INFO] [stdout] 126 | | return rest.to_string(); [INFO] [stdout] 127 | | } [INFO] [stdout] 128 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 124 ~ if let Some((prefix, rest)) = raw.split_once('-') [INFO] [stdout] 125 ~ && !prefix.is_empty() && prefix.chars().all(|c| c.is_ascii_digit()) { [INFO] [stdout] 126 | return rest.to_string(); [INFO] [stdout] 127 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:514:28 [INFO] [stdout] | [INFO] [stdout] 514 | if !(polyscribe::is_no_interaction() || !polyscribe::stdin_is_tty()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!polyscribe::is_no_interaction() && polyscribe::stdin_is_tty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:294:5 [INFO] [stdout] | [INFO] [stdout] 294 | / if output_path.is_none() && inputs.len() >= 2 { [INFO] [stdout] 295 | | if let Some(last) = inputs.last().cloned() { [INFO] [stdout] 296 | | if !Path::new(&last).exists() { [INFO] [stdout] 297 | | inputs.pop(); [INFO] [stdout] ... | [INFO] [stdout] 301 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 294 ~ if output_path.is_none() && inputs.len() >= 2 [INFO] [stdout] 295 ~ && let Some(last) = inputs.last().cloned() { [INFO] [stdout] 296 | if !Path::new(&last).exists() { [INFO] [stdout] ... [INFO] [stdout] 299 | } [INFO] [stdout] 300 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:295:9 [INFO] [stdout] | [INFO] [stdout] 295 | / if let Some(last) = inputs.last().cloned() { [INFO] [stdout] 296 | | if !Path::new(&last).exists() { [INFO] [stdout] 297 | | inputs.pop(); [INFO] [stdout] 298 | | output_path = Some(last); [INFO] [stdout] 299 | | } [INFO] [stdout] 300 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 295 ~ if let Some(last) = inputs.last().cloned() [INFO] [stdout] 296 ~ && !Path::new(&last).exists() { [INFO] [stdout] 297 | inputs.pop(); [INFO] [stdout] 298 | output_path = Some(last); [INFO] [stdout] 299 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:357:40 [INFO] [stdout] | [INFO] [stdout] 357 | entries.extend(items.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 357 - entries.extend(items.into_iter()); [INFO] [stdout] 357 + entries.extend(items); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:440:35 [INFO] [stdout] | [INFO] [stdout] 440 | merged_entries.extend(out.items.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 440 - merged_entries.extend(out.items.into_iter()); [INFO] [stdout] 440 + merged_entries.extend(out.items); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:564:13 [INFO] [stdout] | [INFO] [stdout] 564 | / if let Some(parent) = parent_opt { [INFO] [stdout] 565 | | if !parent.as_os_str().is_empty() { [INFO] [stdout] 566 | | create_dir_all(parent).with_context(|| { [INFO] [stdout] 567 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 573 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 564 ~ if let Some(parent) = parent_opt [INFO] [stdout] 565 ~ && !parent.as_os_str().is_empty() { [INFO] [stdout] 566 | create_dir_all(parent).with_context(|| { [INFO] [stdout] ... [INFO] [stdout] 571 | })?; [INFO] [stdout] 572 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:622:9 [INFO] [stdout] | [INFO] [stdout] 622 | / if let Some(dir) = &out_dir { [INFO] [stdout] 623 | | if !dir.as_os_str().is_empty() { [INFO] [stdout] 624 | | create_dir_all(dir).with_context(|| { [INFO] [stdout] 625 | | format!("Failed to create output directory: {}", dir.display()) [INFO] [stdout] ... | [INFO] [stdout] 628 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 622 ~ if let Some(dir) = &out_dir [INFO] [stdout] 623 ~ && !dir.as_os_str().is_empty() { [INFO] [stdout] 624 | create_dir_all(dir).with_context(|| { [INFO] [stdout] 625 | format!("Failed to create output directory: {}", dir.display()) [INFO] [stdout] 626 | })?; [INFO] [stdout] 627 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:124:5 [INFO] [stdout] | [INFO] [stdout] 124 | / if let Some((prefix, rest)) = raw.split_once('-') { [INFO] [stdout] 125 | | if !prefix.is_empty() && prefix.chars().all(|c| c.is_ascii_digit()) { [INFO] [stdout] 126 | | return rest.to_string(); [INFO] [stdout] 127 | | } [INFO] [stdout] 128 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 124 ~ if let Some((prefix, rest)) = raw.split_once('-') [INFO] [stdout] 125 ~ && !prefix.is_empty() && prefix.chars().all(|c| c.is_ascii_digit()) { [INFO] [stdout] 126 | return rest.to_string(); [INFO] [stdout] 127 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:514:28 [INFO] [stdout] | [INFO] [stdout] 514 | if !(polyscribe::is_no_interaction() || !polyscribe::stdin_is_tty()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!polyscribe::is_no_interaction() && polyscribe::stdin_is_tty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:294:5 [INFO] [stdout] | [INFO] [stdout] 294 | / if output_path.is_none() && inputs.len() >= 2 { [INFO] [stdout] 295 | | if let Some(last) = inputs.last().cloned() { [INFO] [stdout] 296 | | if !Path::new(&last).exists() { [INFO] [stdout] 297 | | inputs.pop(); [INFO] [stdout] ... | [INFO] [stdout] 301 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 294 ~ if output_path.is_none() && inputs.len() >= 2 [INFO] [stdout] 295 ~ && let Some(last) = inputs.last().cloned() { [INFO] [stdout] 296 | if !Path::new(&last).exists() { [INFO] [stdout] ... [INFO] [stdout] 299 | } [INFO] [stdout] 300 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:295:9 [INFO] [stdout] | [INFO] [stdout] 295 | / if let Some(last) = inputs.last().cloned() { [INFO] [stdout] 296 | | if !Path::new(&last).exists() { [INFO] [stdout] 297 | | inputs.pop(); [INFO] [stdout] 298 | | output_path = Some(last); [INFO] [stdout] 299 | | } [INFO] [stdout] 300 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 295 ~ if let Some(last) = inputs.last().cloned() [INFO] [stdout] 296 ~ && !Path::new(&last).exists() { [INFO] [stdout] 297 | inputs.pop(); [INFO] [stdout] 298 | output_path = Some(last); [INFO] [stdout] 299 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:357:40 [INFO] [stdout] | [INFO] [stdout] 357 | entries.extend(items.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 357 - entries.extend(items.into_iter()); [INFO] [stdout] 357 + entries.extend(items); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/main.rs:440:35 [INFO] [stdout] | [INFO] [stdout] 440 | merged_entries.extend(out.items.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/3645249d79dfb136b5d8de3ce153d19d6698d92d/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 440 - merged_entries.extend(out.items.into_iter()); [INFO] [stdout] 440 + merged_entries.extend(out.items); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:564:13 [INFO] [stdout] | [INFO] [stdout] 564 | / if let Some(parent) = parent_opt { [INFO] [stdout] 565 | | if !parent.as_os_str().is_empty() { [INFO] [stdout] 566 | | create_dir_all(parent).with_context(|| { [INFO] [stdout] 567 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 573 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 564 ~ if let Some(parent) = parent_opt [INFO] [stdout] 565 ~ && !parent.as_os_str().is_empty() { [INFO] [stdout] 566 | create_dir_all(parent).with_context(|| { [INFO] [stdout] ... [INFO] [stdout] 571 | })?; [INFO] [stdout] 572 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:622:9 [INFO] [stdout] | [INFO] [stdout] 622 | / if let Some(dir) = &out_dir { [INFO] [stdout] 623 | | if !dir.as_os_str().is_empty() { [INFO] [stdout] 624 | | create_dir_all(dir).with_context(|| { [INFO] [stdout] 625 | | format!("Failed to create output directory: {}", dir.display()) [INFO] [stdout] ... | [INFO] [stdout] 628 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 622 ~ if let Some(dir) = &out_dir [INFO] [stdout] 623 ~ && !dir.as_os_str().is_empty() { [INFO] [stdout] 624 | create_dir_all(dir).with_context(|| { [INFO] [stdout] 625 | format!("Failed to create output directory: {}", dir.display()) [INFO] [stdout] 626 | })?; [INFO] [stdout] 627 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 21s [INFO] running `Command { std: "docker" "inspect" "38785f35fdbc86dc8ee73a001c60a621313b330d40ec1710dfdda3d23e25636f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "38785f35fdbc86dc8ee73a001c60a621313b330d40ec1710dfdda3d23e25636f", kill_on_drop: false }` [INFO] [stdout] 38785f35fdbc86dc8ee73a001c60a621313b330d40ec1710dfdda3d23e25636f