[INFO] cloning repository https://github.com/VictorRibeiroLima/boot-dev-learn-the-http-protocol [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/VictorRibeiroLima/boot-dev-learn-the-http-protocol" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVictorRibeiroLima%2Fboot-dev-learn-the-http-protocol", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVictorRibeiroLima%2Fboot-dev-learn-the-http-protocol'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1007455521d4478da1a1e0610e432f4d1a66250d [INFO] linting VictorRibeiroLima/boot-dev-learn-the-http-protocol against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVictorRibeiroLima%2Fboot-dev-learn-the-http-protocol" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/VictorRibeiroLima/boot-dev-learn-the-http-protocol [INFO] finished tweaking git repo https://github.com/VictorRibeiroLima/boot-dev-learn-the-http-protocol [INFO] tweaked toml for git repo https://github.com/VictorRibeiroLima/boot-dev-learn-the-http-protocol written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/VictorRibeiroLima/boot-dev-learn-the-http-protocol on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/VictorRibeiroLima/boot-dev-learn-the-http-protocol already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7bb9ecab290af57e4c6ed7eb856e5797e4430fca65a5cb83ee2a9d97853b3599 [INFO] running `Command { std: "docker" "start" "-a" "7bb9ecab290af57e4c6ed7eb856e5797e4430fca65a5cb83ee2a9d97853b3599", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7bb9ecab290af57e4c6ed7eb856e5797e4430fca65a5cb83ee2a9d97853b3599", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7bb9ecab290af57e4c6ed7eb856e5797e4430fca65a5cb83ee2a9d97853b3599", kill_on_drop: false }` [INFO] [stdout] 7bb9ecab290af57e4c6ed7eb856e5797e4430fca65a5cb83ee2a9d97853b3599 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 58c07047c83d87a45fd841c7565299d91e3245234b350a8008c5748d5801f30d [INFO] running `Command { std: "docker" "start" "-a" "58c07047c83d87a45fd841c7565299d91e3245234b350a8008c5748d5801f30d", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking bitflags v2.9.3 [INFO] [stderr] Compiling openssl v0.10.73 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper v1.7.0 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.3 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking hyper-util v0.1.16 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking reqwest v0.12.23 [INFO] [stderr] Checking http_from_scratch v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `ServerResponse` is never constructed [INFO] [stdout] --> src/server/response.rs:6:12 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct ServerResponse { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/error.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | ReaderError(std::io::Error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/header/mod.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return result; [INFO] [stdout] 58 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless call to `as_bytes` [INFO] [stdout] --> src/header/mod.rs:53:23 [INFO] [stdout] | [INFO] [stdout] 53 | result += key.as_bytes().len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `key.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes [INFO] [stdout] = note: `#[warn(clippy::needless_as_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless call to `as_bytes` [INFO] [stdout] --> src/header/mod.rs:54:23 [INFO] [stdout] | [INFO] [stdout] 54 | result += value.as_bytes().len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `value.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/header/mod.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | / return ( [INFO] [stdout] 156 | | total_read, [INFO] [stdout] 157 | | Ok(Some(Self { [INFO] [stdout] 158 | | key: key.to_lowercase(), [INFO] [stdout] 159 | | value: value.to_string(), [INFO] [stdout] 160 | | })), [INFO] [stdout] 161 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 155 ~ ( [INFO] [stdout] 156 + total_read, [INFO] [stdout] 157 + Ok(Some(Self { [INFO] [stdout] 158 + key: key.to_lowercase(), [INFO] [stdout] 159 + value: value.to_string(), [INFO] [stdout] 160 + })), [INFO] [stdout] 161 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/header/mod.rs:140:12 [INFO] [stdout] | [INFO] [stdout] 140 | if value.len() < 1 || key.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/header/mod.rs:140:31 [INFO] [stdout] | [INFO] [stdout] 140 | if value.len() < 1 || key.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `key.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should use the `ends_with` method [INFO] [stdout] --> src/header/mod.rs:143:12 [INFO] [stdout] | [INFO] [stdout] 143 | if key.chars().last() == Some(' ') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `key.ends_with(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stdout] = note: `#[warn(clippy::chars_last_cmp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ServerResponse` is never constructed [INFO] [stdout] --> src/server/response.rs:6:12 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct ServerResponse { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> src/error.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | ReaderError(std::io::Error), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/header/mod.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return result; [INFO] [stdout] 58 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless call to `as_bytes` [INFO] [stdout] --> src/header/mod.rs:53:23 [INFO] [stdout] | [INFO] [stdout] 53 | result += key.as_bytes().len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `key.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes [INFO] [stdout] = note: `#[warn(clippy::needless_as_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needless call to `as_bytes` [INFO] [stdout] --> src/header/mod.rs:54:23 [INFO] [stdout] | [INFO] [stdout] 54 | result += value.as_bytes().len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: `len()` can be called directly on strings: `value.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_as_bytes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:167:16 [INFO] [stdout] | [INFO] [stdout] 167 | && !(c == '!') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '!')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:168:16 [INFO] [stdout] | [INFO] [stdout] 168 | && !(c == '#') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '#')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:169:16 [INFO] [stdout] | [INFO] [stdout] 169 | && !(c == '$') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '$')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:170:16 [INFO] [stdout] | [INFO] [stdout] 170 | && !(c == '%') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '%')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:171:16 [INFO] [stdout] | [INFO] [stdout] 171 | && !(c == '&') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '&')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:172:16 [INFO] [stdout] | [INFO] [stdout] 172 | && !(c == '\'') [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `(c != '\'')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:173:16 [INFO] [stdout] | [INFO] [stdout] 173 | && !(c == '*') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '*')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:174:16 [INFO] [stdout] | [INFO] [stdout] 174 | && !(c == '+') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '+')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:175:16 [INFO] [stdout] | [INFO] [stdout] 175 | && !(c == '-') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/header/mod.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | / return ( [INFO] [stdout] 156 | | total_read, [INFO] [stdout] 157 | | Ok(Some(Self { [INFO] [stdout] 158 | | key: key.to_lowercase(), [INFO] [stdout] 159 | | value: value.to_string(), [INFO] [stdout] 160 | | })), [INFO] [stdout] 161 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 155 ~ ( [INFO] [stdout] 156 + total_read, [INFO] [stdout] 157 + Ok(Some(Self { [INFO] [stdout] 158 + key: key.to_lowercase(), [INFO] [stdout] 159 + value: value.to_string(), [INFO] [stdout] 160 + })), [INFO] [stdout] 161 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:176:16 [INFO] [stdout] | [INFO] [stdout] 176 | && !(c == '.') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:177:16 [INFO] [stdout] | [INFO] [stdout] 177 | && !(c == '^') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '^')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:178:16 [INFO] [stdout] | [INFO] [stdout] 178 | && !(c == '_') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '_')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:179:16 [INFO] [stdout] | [INFO] [stdout] 179 | && !(c == '`') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '`')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:180:16 [INFO] [stdout] | [INFO] [stdout] 180 | && !(c == '|') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '|')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:181:16 [INFO] [stdout] | [INFO] [stdout] 181 | && !(c == '~') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '~')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/header/mod.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - return true; [INFO] [stdout] 185 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `GET` contains a capitalized acronym [INFO] [stdout] --> src/method.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | GET, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Get` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `POST` contains a capitalized acronym [INFO] [stdout] --> src/method.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | POST, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Post` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PUT` contains a capitalized acronym [INFO] [stdout] --> src/method.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | PUT, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Put` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HEAD` contains a capitalized acronym [INFO] [stdout] --> src/method.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | HEAD, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DELETE` contains a capitalized acronym [INFO] [stdout] --> src/method.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | DELETE, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Delete` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PATCH` contains a capitalized acronym [INFO] [stdout] --> src/method.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | PATCH, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Patch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OPTIONS` contains a capitalized acronym [INFO] [stdout] --> src/method.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | OPTIONS, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Options` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CONNECT` contains a capitalized acronym [INFO] [stdout] --> src/method.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | CONNECT, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Connect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TRACE` contains a capitalized acronym [INFO] [stdout] --> src/method.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | TRACE, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Trace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/header/mod.rs:140:12 [INFO] [stdout] | [INFO] [stdout] 140 | if value.len() < 1 || key.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/header/mod.rs:140:31 [INFO] [stdout] | [INFO] [stdout] 140 | if value.len() < 1 || key.len() < 1 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `key.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should use the `ends_with` method [INFO] [stdout] --> src/header/mod.rs:143:12 [INFO] [stdout] | [INFO] [stdout] 143 | if key.chars().last() == Some(' ') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `key.ends_with(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stdout] = note: `#[warn(clippy::chars_last_cmp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/path/mod.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 71 | if segment != "" { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!segment.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/path/mod.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 138 - return true; [INFO] [stdout] 138 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/path/mod.rs:129:16 [INFO] [stdout] | [INFO] [stdout] 129 | if rest != "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!rest.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/requests/line.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | / return ( [INFO] [stdout] 57 | | total_read, [INFO] [stdout] 58 | | Ok(Some(Self { [INFO] [stdout] 59 | | method, [INFO] [stdout] ... | [INFO] [stdout] 62 | | })), [INFO] [stdout] 63 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 ~ ( [INFO] [stdout] 57 + total_read, [INFO] [stdout] 58 + Ok(Some(Self { [INFO] [stdout] 59 + method, [INFO] [stdout] 60 + request_target, [INFO] [stdout] 61 + http_version: "1.1".to_string(), [INFO] [stdout] 62 + })), [INFO] [stdout] 63 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/requests/parser.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | return Ok(content_length); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return Ok(content_length); [INFO] [stdout] 57 + Ok(content_length) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/requests/parser.rs:89:22 [INFO] [stdout] | [INFO] [stdout] 89 | let result = match result { [INFO] [stdout] | ______________________^ [INFO] [stdout] 90 | | Ok(result) => result, [INFO] [stdout] 91 | | Err(e) => return Err(e), [INFO] [stdout] 92 | | }; [INFO] [stdout] | |_________^ help: try instead: `result?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/requests/parser.rs:111:26 [INFO] [stdout] | [INFO] [stdout] 111 | let result = match result { [INFO] [stdout] | __________________________^ [INFO] [stdout] 112 | | Ok(result) => result, [INFO] [stdout] 113 | | Err(e) => return Err(e), [INFO] [stdout] 114 | | }; [INFO] [stdout] | |_____________^ help: try instead: `result?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/requests/parser.rs:164:9 [INFO] [stdout] | [INFO] [stdout] 164 | return Ok(read_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 164 - return Ok(read_data); [INFO] [stdout] 164 + Ok(read_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/requests/mod.rs:52:26 [INFO] [stdout] | [INFO] [stdout] 52 | .map_err(|e| Error::ReaderError(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Error::ReaderError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/requests/mod.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | buff_idx = buff_idx + n_read; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buff_idx += n_read` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/requests/mod.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | buff_idx = buff_idx - p_read; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buff_idx -= p_read` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:167:16 [INFO] [stdout] | [INFO] [stdout] 167 | && !(c == '!') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '!')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:168:16 [INFO] [stdout] | [INFO] [stdout] 168 | && !(c == '#') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '#')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:169:16 [INFO] [stdout] | [INFO] [stdout] 169 | && !(c == '$') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '$')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:170:16 [INFO] [stdout] | [INFO] [stdout] 170 | && !(c == '%') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '%')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:171:16 [INFO] [stdout] | [INFO] [stdout] 171 | && !(c == '&') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '&')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:172:16 [INFO] [stdout] | [INFO] [stdout] 172 | && !(c == '\'') [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `(c != '\'')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:173:16 [INFO] [stdout] | [INFO] [stdout] 173 | && !(c == '*') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '*')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:174:16 [INFO] [stdout] | [INFO] [stdout] 174 | && !(c == '+') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '+')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:175:16 [INFO] [stdout] | [INFO] [stdout] 175 | && !(c == '-') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '-')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:176:16 [INFO] [stdout] | [INFO] [stdout] 176 | && !(c == '.') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '.')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:177:16 [INFO] [stdout] | [INFO] [stdout] 177 | && !(c == '^') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '^')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:178:16 [INFO] [stdout] | [INFO] [stdout] 178 | && !(c == '_') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '_')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:179:16 [INFO] [stdout] | [INFO] [stdout] 179 | && !(c == '`') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '`')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:180:16 [INFO] [stdout] | [INFO] [stdout] 180 | && !(c == '|') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '|')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/header/mod.rs:181:16 [INFO] [stdout] | [INFO] [stdout] 181 | && !(c == '~') [INFO] [stdout] | ^^^^^^^^^^^ help: try: `(c != '~')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/header/mod.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - return true; [INFO] [stdout] 185 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/requests/mod.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | return Some(value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - return Some(value); [INFO] [stdout] 118 + Some(value) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/response/line.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 24 | w.write_all(&self.code.bytes())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `self.code.bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/line.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return 8 + self.code.byte_len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return 8 + self.code.byte_len(); [INFO] [stdout] 29 + 8 + self.code.byte_len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `GET` contains a capitalized acronym [INFO] [stdout] --> src/method.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | GET, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Get` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `POST` contains a capitalized acronym [INFO] [stdout] --> src/method.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | POST, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Post` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PUT` contains a capitalized acronym [INFO] [stdout] --> src/method.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | PUT, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Put` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `HEAD` contains a capitalized acronym [INFO] [stdout] --> src/method.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | HEAD, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Head` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DELETE` contains a capitalized acronym [INFO] [stdout] --> src/method.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | DELETE, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Delete` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PATCH` contains a capitalized acronym [INFO] [stdout] --> src/method.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | PATCH, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Patch` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `OPTIONS` contains a capitalized acronym [INFO] [stdout] --> src/method.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | OPTIONS, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Options` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `CONNECT` contains a capitalized acronym [INFO] [stdout] --> src/method.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | CONNECT, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Connect` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `TRACE` contains a capitalized acronym [INFO] [stdout] --> src/method.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | TRACE, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Trace` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/writer.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | / return ChunkedResponseWriter { [INFO] [stdout] 53 | | line: self.line, [INFO] [stdout] 54 | | headers_flushed: false, [INFO] [stdout] 55 | | closed: false, [INFO] [stdout] ... | [INFO] [stdout] 59 | | stream: self.stream, [INFO] [stdout] 60 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 ~ ChunkedResponseWriter { [INFO] [stdout] 53 + line: self.line, [INFO] [stdout] 54 + headers_flushed: false, [INFO] [stdout] 55 + closed: false, [INFO] [stdout] 56 + headers, [INFO] [stdout] 57 + trailers: Default::default(), [INFO] [stdout] 58 + [INFO] [stdout] 59 + stream: self.stream, [INFO] [stdout] 60 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/path/mod.rs:71:12 [INFO] [stdout] | [INFO] [stdout] 71 | if segment != "" { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!segment.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/path/mod.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 138 - return true; [INFO] [stdout] 138 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/response/writer.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | let conn: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `conn` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 93 ~ [INFO] [stdout] 94 | [INFO] [stdout] 95 ~ let conn: String = if self.connection { [INFO] [stdout] 96 ~ "open".to_string() [INFO] [stdout] 97 | } else { [INFO] [stdout] 98 ~ "close".to_string() [INFO] [stdout] 99 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/path/mod.rs:129:16 [INFO] [stdout] | [INFO] [stdout] 129 | if rest != "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!rest.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/response/writer.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | / match self.flush() { [INFO] [stdout] 131 | | Err(e) => { [INFO] [stdout] 132 | | eprintln!("error flushing response writer on drop: {}", e) [INFO] [stdout] ... | [INFO] [stdout] 135 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 130 ~ if let Err(e) = self.flush() { [INFO] [stdout] 131 + eprintln!("error flushing response writer on drop: {}", e) [INFO] [stdout] 132 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/writer.rs:193:9 [INFO] [stdout] | [INFO] [stdout] 193 | return Ok(line_bytes + header_bytes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 193 - return Ok(line_bytes + header_bytes); [INFO] [stdout] 193 + Ok(line_bytes + header_bytes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/response/writer.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | / match self.close() { [INFO] [stdout] 242 | | Err(e) => { [INFO] [stdout] 243 | | eprintln!("error flushing chunked response writer on drop: {}", e) [INFO] [stdout] ... | [INFO] [stdout] 246 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 241 ~ if let Err(e) = self.close() { [INFO] [stdout] 242 + eprintln!("error flushing chunked response writer on drop: {}", e) [INFO] [stdout] 243 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/response/mod.rs:19:21 [INFO] [stdout] | [INFO] [stdout] 19 | w.write_all(&self.body) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/response/mod.rs:23:21 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn to_bytes(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | return resp; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return resp; [INFO] [stdout] 30 + resp [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/requests/line.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | / return ( [INFO] [stdout] 57 | | total_read, [INFO] [stdout] 58 | | Ok(Some(Self { [INFO] [stdout] 59 | | method, [INFO] [stdout] ... | [INFO] [stdout] 62 | | })), [INFO] [stdout] 63 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 ~ ( [INFO] [stdout] 57 + total_read, [INFO] [stdout] 58 + Ok(Some(Self { [INFO] [stdout] 59 + method, [INFO] [stdout] 60 + request_target, [INFO] [stdout] 61 + http_version: "1.1".to_string(), [INFO] [stdout] 62 + })), [INFO] [stdout] 63 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/requests/parser.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | return Ok(content_length); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return Ok(content_length); [INFO] [stdout] 57 + Ok(content_length) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/requests/parser.rs:89:22 [INFO] [stdout] | [INFO] [stdout] 89 | let result = match result { [INFO] [stdout] | ______________________^ [INFO] [stdout] 90 | | Ok(result) => result, [INFO] [stdout] 91 | | Err(e) => return Err(e), [INFO] [stdout] 92 | | }; [INFO] [stdout] | |_________^ help: try instead: `result?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` expression can be replaced with `?` [INFO] [stdout] --> src/requests/parser.rs:111:26 [INFO] [stdout] | [INFO] [stdout] 111 | let result = match result { [INFO] [stdout] | __________________________^ [INFO] [stdout] 112 | | Ok(result) => result, [INFO] [stdout] 113 | | Err(e) => return Err(e), [INFO] [stdout] 114 | | }; [INFO] [stdout] | |_____________^ help: try instead: `result?` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/requests/parser.rs:164:9 [INFO] [stdout] | [INFO] [stdout] 164 | return Ok(read_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 164 - return Ok(read_data); [INFO] [stdout] 164 + Ok(read_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/requests/mod.rs:52:26 [INFO] [stdout] | [INFO] [stdout] 52 | .map_err(|e| Error::ReaderError(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Error::ReaderError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/requests/mod.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | buff_idx = buff_idx + n_read; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buff_idx += n_read` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/requests/mod.rs:74:17 [INFO] [stdout] | [INFO] [stdout] 74 | buff_idx = buff_idx - p_read; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buff_idx -= p_read` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/requests/mod.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | return Some(value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - return Some(value); [INFO] [stdout] 118 + Some(value) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/response/line.rs:24:21 [INFO] [stdout] | [INFO] [stdout] 24 | w.write_all(&self.code.bytes())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `self.code.bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/line.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return 8 + self.code.byte_len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return 8 + self.code.byte_len(); [INFO] [stdout] 29 + 8 + self.code.byte_len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/writer.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | / return ChunkedResponseWriter { [INFO] [stdout] 53 | | line: self.line, [INFO] [stdout] 54 | | headers_flushed: false, [INFO] [stdout] 55 | | closed: false, [INFO] [stdout] ... | [INFO] [stdout] 59 | | stream: self.stream, [INFO] [stdout] 60 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 ~ ChunkedResponseWriter { [INFO] [stdout] 53 + line: self.line, [INFO] [stdout] 54 + headers_flushed: false, [INFO] [stdout] 55 + closed: false, [INFO] [stdout] 56 + headers, [INFO] [stdout] 57 + trailers: Default::default(), [INFO] [stdout] 58 + [INFO] [stdout] 59 + stream: self.stream, [INFO] [stdout] 60 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/response/writer.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 93 | let conn: String; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `conn` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 93 ~ [INFO] [stdout] 94 | [INFO] [stdout] 95 ~ let conn: String = if self.connection { [INFO] [stdout] 96 ~ "open".to_string() [INFO] [stdout] 97 | } else { [INFO] [stdout] 98 ~ "close".to_string() [INFO] [stdout] 99 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/response/writer.rs:130:9 [INFO] [stdout] | [INFO] [stdout] 130 | / match self.flush() { [INFO] [stdout] 131 | | Err(e) => { [INFO] [stdout] 132 | | eprintln!("error flushing response writer on drop: {}", e) [INFO] [stdout] ... | [INFO] [stdout] 135 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 130 ~ if let Err(e) = self.flush() { [INFO] [stdout] 131 + eprintln!("error flushing response writer on drop: {}", e) [INFO] [stdout] 132 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/writer.rs:193:9 [INFO] [stdout] | [INFO] [stdout] 193 | return Ok(line_bytes + header_bytes); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 193 - return Ok(line_bytes + header_bytes); [INFO] [stdout] 193 + Ok(line_bytes + header_bytes) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/response/writer.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | / match self.close() { [INFO] [stdout] 242 | | Err(e) => { [INFO] [stdout] 243 | | eprintln!("error flushing chunked response writer on drop: {}", e) [INFO] [stdout] ... | [INFO] [stdout] 246 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 241 ~ if let Err(e) = self.close() { [INFO] [stdout] 242 + eprintln!("error flushing chunked response writer on drop: {}", e) [INFO] [stdout] 243 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/response/mod.rs:19:21 [INFO] [stdout] | [INFO] [stdout] 19 | w.write_all(&self.body) [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `self.body` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference [INFO] [stdout] --> src/response/mod.rs:23:21 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn to_bytes(self) -> Vec { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/response/mod.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | return resp; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return resp; [INFO] [stdout] 30 + resp [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 21.38s [INFO] running `Command { std: "docker" "inspect" "58c07047c83d87a45fd841c7565299d91e3245234b350a8008c5748d5801f30d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "58c07047c83d87a45fd841c7565299d91e3245234b350a8008c5748d5801f30d", kill_on_drop: false }` [INFO] [stdout] 58c07047c83d87a45fd841c7565299d91e3245234b350a8008c5748d5801f30d