[INFO] cloning repository https://github.com/Viacheslav-ua/file_finder_rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Viacheslav-ua/file_finder_rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FViacheslav-ua%2Ffile_finder_rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FViacheslav-ua%2Ffile_finder_rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f46a6a5202177b553045910abcdb8de8cfd3b77b [INFO] linting Viacheslav-ua/file_finder_rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FViacheslav-ua%2Ffile_finder_rust" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Viacheslav-ua/file_finder_rust [INFO] finished tweaking git repo https://github.com/Viacheslav-ua/file_finder_rust [INFO] tweaked toml for git repo https://github.com/Viacheslav-ua/file_finder_rust written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Viacheslav-ua/file_finder_rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Viacheslav-ua/file_finder_rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0e6f55ac7181a4b5d193591031c9c40422c6ae438ab841d894e4a87027cf9aba [INFO] running `Command { std: "docker" "start" "-a" "0e6f55ac7181a4b5d193591031c9c40422c6ae438ab841d894e4a87027cf9aba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0e6f55ac7181a4b5d193591031c9c40422c6ae438ab841d894e4a87027cf9aba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e6f55ac7181a4b5d193591031c9c40422c6ae438ab841d894e4a87027cf9aba", kill_on_drop: false }` [INFO] [stdout] 0e6f55ac7181a4b5d193591031c9c40422c6ae438ab841d894e4a87027cf9aba [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d4a79ed349815cacf7c6d11c2c8eee2b7a3bab0ce563cf4e7a0c3e478f766cbf [INFO] running `Command { std: "docker" "start" "-a" "d4a79ed349815cacf7c6d11c2c8eee2b7a3bab0ce563cf4e7a0c3e478f766cbf", kill_on_drop: false }` [INFO] [stderr] Checking file_finder_rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:98:20 [INFO] [stdout] | [INFO] [stdout] 98 | if !is_no_extension && extensions.contains(&file_extension) || is_no_extension { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 98 - if !is_no_extension && extensions.contains(&file_extension) || is_no_extension { [INFO] [stdout] 98 + if !(!is_no_extension && !extensions.contains(&file_extension)) { [INFO] [stdout] | [INFO] [stdout] 98 - if !is_no_extension && extensions.contains(&file_extension) || is_no_extension { [INFO] [stdout] 98 + if is_no_extension || extensions.contains(&file_extension) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | / for entry in files { [INFO] [stdout] 78 | | if let Ok(entry) = entry { [INFO] [stdout] 79 | | let path = entry.path(); [INFO] [stdout] 80 | | let file_name = convert_os_string(path.file_stem()); [INFO] [stdout] ... | [INFO] [stdout] 103 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | / if let Ok(entry) = entry { [INFO] [stdout] 79 | | let path = entry.path(); [INFO] [stdout] 80 | | let file_name = convert_os_string(path.file_stem()); [INFO] [stdout] 81 | | let file_extension = convert_os_string(path.extension()); [INFO] [stdout] ... | [INFO] [stdout] 102 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 77 ~ for entry in files.flatten() { [INFO] [stdout] 78 + let path = entry.path(); [INFO] [stdout] 79 + let file_name = convert_os_string(path.file_stem()); [INFO] [stdout] 80 + let file_extension = convert_os_string(path.extension()); [INFO] [stdout] 81 + [INFO] [stdout] 82 + if path.is_dir() { [INFO] [stdout] 83 + if is_no_extension && file_name.contains(filename) { [INFO] [stdout] 84 + file_found(&path, now, result_count); [INFO] [stdout] 85 + } [INFO] [stdout] 86 + [INFO] [stdout] 87 + search_files( [INFO] [stdout] 88 + path.to_str().unwrap_or_default(), [INFO] [stdout] 89 + filename, [INFO] [stdout] 90 + extensions, [INFO] [stdout] 91 + now, [INFO] [stdout] 92 + result_count, [INFO] [stdout] 93 + ); [INFO] [stdout] 94 + } else if is_empty_filename && extensions.contains(&file_extension) { [INFO] [stdout] 95 + file_found(&path, now, result_count); [INFO] [stdout] 96 + } else if path.is_file() && file_name.contains(filename) { [INFO] [stdout] 97 + if !is_no_extension && extensions.contains(&file_extension) || is_no_extension { [INFO] [stdout] 98 + file_found(&path, now, result_count); [INFO] [stdout] 99 + } [INFO] [stdout] 100 + } [INFO] [stdout] 101 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:97:20 [INFO] [stdout] | [INFO] [stdout] 97 | } else if path.is_file() && file_name.contains(filename) { [INFO] [stdout] | ____________________^ [INFO] [stdout] 98 | | if !is_no_extension && extensions.contains(&file_extension) || is_no_extension { [INFO] [stdout] 99 | | file_found(&path, now, result_count); [INFO] [stdout] 100 | | } [INFO] [stdout] 101 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 97 ~ } else if path.is_file() && file_name.contains(filename) [INFO] [stdout] 98 ~ && (!is_no_extension && extensions.contains(&file_extension) || is_no_extension) { [INFO] [stdout] 99 | file_found(&path, now, result_count); [INFO] [stdout] 100 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:116:21 [INFO] [stdout] | [INFO] [stdout] 116 | print_path_info(&path, now); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/main.rs:128:13 [INFO] [stdout] | [INFO] [stdout] 128 | print!(" {} MB\n", metadata.len() as u64 / FILE_SIZE_BASE); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 128 - print!(" {} MB\n", metadata.len() as u64 / FILE_SIZE_BASE); [INFO] [stdout] 128 + println!(" {} MB", metadata.len() as u64 / FILE_SIZE_BASE); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/main.rs:128:32 [INFO] [stdout] | [INFO] [stdout] 128 | print!(" {} MB\n", metadata.len() as u64 / FILE_SIZE_BASE); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:98:20 [INFO] [stdout] | [INFO] [stdout] 98 | if !is_no_extension && extensions.contains(&file_extension) || is_no_extension { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 98 - if !is_no_extension && extensions.contains(&file_extension) || is_no_extension { [INFO] [stdout] 98 + if !(!is_no_extension && !extensions.contains(&file_extension)) { [INFO] [stdout] | [INFO] [stdout] 98 - if !is_no_extension && extensions.contains(&file_extension) || is_no_extension { [INFO] [stdout] 98 + if is_no_extension || extensions.contains(&file_extension) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used [INFO] [stdout] --> src/main.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | / for entry in files { [INFO] [stdout] 78 | | if let Ok(entry) = entry { [INFO] [stdout] 79 | | let path = entry.path(); [INFO] [stdout] 80 | | let file_name = convert_os_string(path.file_stem()); [INFO] [stdout] ... | [INFO] [stdout] 103 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/main.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | / if let Ok(entry) = entry { [INFO] [stdout] 79 | | let path = entry.path(); [INFO] [stdout] 80 | | let file_name = convert_os_string(path.file_stem()); [INFO] [stdout] 81 | | let file_extension = convert_os_string(path.extension()); [INFO] [stdout] ... | [INFO] [stdout] 102 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 77 ~ for entry in files.flatten() { [INFO] [stdout] 78 + let path = entry.path(); [INFO] [stdout] 79 + let file_name = convert_os_string(path.file_stem()); [INFO] [stdout] 80 + let file_extension = convert_os_string(path.extension()); [INFO] [stdout] 81 + [INFO] [stdout] 82 + if path.is_dir() { [INFO] [stdout] 83 + if is_no_extension && file_name.contains(filename) { [INFO] [stdout] 84 + file_found(&path, now, result_count); [INFO] [stdout] 85 + } [INFO] [stdout] 86 + [INFO] [stdout] 87 + search_files( [INFO] [stdout] 88 + path.to_str().unwrap_or_default(), [INFO] [stdout] 89 + filename, [INFO] [stdout] 90 + extensions, [INFO] [stdout] 91 + now, [INFO] [stdout] 92 + result_count, [INFO] [stdout] 93 + ); [INFO] [stdout] 94 + } else if is_empty_filename && extensions.contains(&file_extension) { [INFO] [stdout] 95 + file_found(&path, now, result_count); [INFO] [stdout] 96 + } else if path.is_file() && file_name.contains(filename) { [INFO] [stdout] 97 + if !is_no_extension && extensions.contains(&file_extension) || is_no_extension { [INFO] [stdout] 98 + file_found(&path, now, result_count); [INFO] [stdout] 99 + } [INFO] [stdout] 100 + } [INFO] [stdout] 101 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:97:20 [INFO] [stdout] | [INFO] [stdout] 97 | } else if path.is_file() && file_name.contains(filename) { [INFO] [stdout] | ____________________^ [INFO] [stdout] 98 | | if !is_no_extension && extensions.contains(&file_extension) || is_no_extension { [INFO] [stdout] 99 | | file_found(&path, now, result_count); [INFO] [stdout] 100 | | } [INFO] [stdout] 101 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 97 ~ } else if path.is_file() && file_name.contains(filename) [INFO] [stdout] 98 ~ && (!is_no_extension && extensions.contains(&file_extension) || is_no_extension) { [INFO] [stdout] 99 | file_found(&path, now, result_count); [INFO] [stdout] 100 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:116:21 [INFO] [stdout] | [INFO] [stdout] 116 | print_path_info(&path, now); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/main.rs:128:13 [INFO] [stdout] | [INFO] [stdout] 128 | print!(" {} MB\n", metadata.len() as u64 / FILE_SIZE_BASE); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 128 - print!(" {} MB\n", metadata.len() as u64 / FILE_SIZE_BASE); [INFO] [stdout] 128 + println!(" {} MB", metadata.len() as u64 / FILE_SIZE_BASE); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/main.rs:128:32 [INFO] [stdout] | [INFO] [stdout] 128 | print!(" {} MB\n", metadata.len() as u64 / FILE_SIZE_BASE); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `metadata.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.17s [INFO] running `Command { std: "docker" "inspect" "d4a79ed349815cacf7c6d11c2c8eee2b7a3bab0ce563cf4e7a0c3e478f766cbf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d4a79ed349815cacf7c6d11c2c8eee2b7a3bab0ce563cf4e7a0c3e478f766cbf", kill_on_drop: false }` [INFO] [stdout] d4a79ed349815cacf7c6d11c2c8eee2b7a3bab0ce563cf4e7a0c3e478f766cbf