[INFO] cloning repository https://github.com/VayuDev/red-peg [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/VayuDev/red-peg" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVayuDev%2Fred-peg", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVayuDev%2Fred-peg'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4dc7990c3ef1e30d8f250ff2d4d68db0cc2559b9 [INFO] linting VayuDev/red-peg against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVayuDev%2Fred-peg" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/VayuDev/red-peg [INFO] finished tweaking git repo https://github.com/VayuDev/red-peg [INFO] tweaked toml for git repo https://github.com/VayuDev/red-peg written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/VayuDev/red-peg on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/VayuDev/red-peg already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 943b7de505849410d851f4a06275075faaef66fafb4b02131843ed9e8d6ea707 [INFO] running `Command { std: "docker" "start" "-a" "943b7de505849410d851f4a06275075faaef66fafb4b02131843ed9e8d6ea707", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "943b7de505849410d851f4a06275075faaef66fafb4b02131843ed9e8d6ea707", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "943b7de505849410d851f4a06275075faaef66fafb4b02131843ed9e8d6ea707", kill_on_drop: false }` [INFO] [stdout] 943b7de505849410d851f4a06275075faaef66fafb4b02131843ed9e8d6ea707 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c7add89dc2476a23f8fadd5ca36c528164f4a56522a33a8ec5e1324284eaf2c2 [INFO] running `Command { std: "docker" "start" "-a" "c7add89dc2476a23f8fadd5ca36c528164f4a56522a33a8ec5e1324284eaf2c2", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.21 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking regex v1.4.2 [INFO] [stderr] Checking red-peg v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/code_tokenizer.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | / return CodeTokenizer { [INFO] [stdout] 13 | | code: String::from(code), [INFO] [stdout] 14 | | states: vec![0], [INFO] [stdout] 15 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ CodeTokenizer { [INFO] [stdout] 13 + code: String::from(code), [INFO] [stdout] 14 + states: vec![0], [INFO] [stdout] 15 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/code_tokenizer.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return true; [INFO] [stdout] 33 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/code_tokenizer.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return false; [INFO] [stdout] 35 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/code_tokenizer.rs:67:19 [INFO] [stdout] | [INFO] [stdout] 67 | .push(self.states.last().expect("No current state!").clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.states.last().expect("No current state!")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/expression_tokenizer.rs:39:20 [INFO] [stdout] | [INFO] [stdout] 39 | if c == terminal_char && (last != '\\' || (last == last_last && last == '\\')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 39 - if c == terminal_char && (last != '\\' || (last == last_last && last == '\\')) { [INFO] [stdout] 39 + if !(c != terminal_char || last == '\\' && last != last_last) { [INFO] [stdout] | [INFO] [stdout] 39 - if c == terminal_char && (last != '\\' || (last == last_last && last == '\\')) { [INFO] [stdout] 39 + if (last == last_last || last != '\\') && c == terminal_char { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/expression_tokenizer.rs:39:42 [INFO] [stdout] | [INFO] [stdout] 39 | if c == terminal_char && (last != '\\' || (last == last_last && last == '\\')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 39 - if c == terminal_char && (last != '\\' || (last == last_last && last == '\\')) { [INFO] [stdout] 39 + if c == terminal_char && !(last == '\\' && last != last_last) { [INFO] [stdout] | [INFO] [stdout] 39 - if c == terminal_char && (last != '\\' || (last == last_last && last == '\\')) { [INFO] [stdout] 39 + if c == terminal_char && last != '\\' || last == last_last { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_tokenizer.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | return tokenizer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - return tokenizer; [INFO] [stdout] 80 + tokenizer [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>` [INFO] [stdout] --> src/expression_tokenizer.rs:30:20 [INFO] [stdout] | [INFO] [stdout] 30 | let iter = tokenstring.chars().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `tokenstring.chars()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/expression_tokenizer.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 84 | if last_string.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!last_string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_tokenizer.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | return self.tokens.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - return self.tokens.len(); [INFO] [stdout] 103 + self.tokens.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_tokenizer.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 111 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 - return None; [INFO] [stdout] 111 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_tokenizer.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - return None; [INFO] [stdout] 118 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_tokenizer.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 126 - return false; [INFO] [stdout] 126 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_tokenizer.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | return first == '['; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 - return first == '['; [INFO] [stdout] 131 + first == '[' [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | return v; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return v; [INFO] [stdout] 22 + v [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 26 | if self.sub_results.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.sub_results.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | &self.sub_results.get(index).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.sub_results.get(index).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | return String::from("ParsingExpression"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - return String::from("ParsingExpression"); [INFO] [stdout] 61 + String::from("ParsingExpression") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/parser.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | / pub fn new(p_name: &str) -> Box> { [INFO] [stdout] 78 | | Box::new(TerminalParsingExpression { [INFO] [stdout] 79 | | content: TerminalType::SIMPLE(String::from(p_name)), [INFO] [stdout] 80 | | _marker: Default::default(), [INFO] [stdout] 81 | | }) [INFO] [stdout] 82 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/parser.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 131 | / pub fn new(p_name: &str) -> Box> { [INFO] [stdout] 132 | | Box::new(NonTerminalParsingExpression { [INFO] [stdout] 133 | | name: String::from(p_name), [INFO] [stdout] 134 | | _marker: Default::default(), [INFO] [stdout] 135 | | }) [INFO] [stdout] 136 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 141 | return String::from(format!("{}", self.name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 141 - return String::from(format!("{}", self.name)); [INFO] [stdout] 141 + String::from(format!("{}", self.name)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/parser.rs:141:16 [INFO] [stdout] | [INFO] [stdout] 141 | return String::from(format!("{}", self.name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}", self.name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/parser.rs:141:29 [INFO] [stdout] | [INFO] [stdout] 141 | return String::from(format!("{}", self.name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `self.name.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:148:39 [INFO] [stdout] | [INFO] [stdout] 148 | match rule.expression.matches(&mut info) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:158:62 [INFO] [stdout] | [INFO] [stdout] 158 | res_cpy.rule_result = Some(callback(res, &info.tokenizer)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `info.tokenizer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/parser.rs:173:5 [INFO] [stdout] | [INFO] [stdout] 173 | / pub fn new(p_children: Vec>>) -> Box> { [INFO] [stdout] 174 | | Box::new(SequenceParsingExpression { [INFO] [stdout] 175 | | children: p_children, [INFO] [stdout] 176 | | _marker: Default::default(), [INFO] [stdout] 177 | | }) [INFO] [stdout] 178 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:192:9 [INFO] [stdout] | [INFO] [stdout] 192 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 192 - return ret; [INFO] [stdout] 192 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/parser.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | for child in &self.children { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, child) in self.children.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/parser.rs:188:17 [INFO] [stdout] | [INFO] [stdout] 188 | ret.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `ret.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:212:9 [INFO] [stdout] | [INFO] [stdout] 212 | return Some(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 212 - return Some(result); [INFO] [stdout] 212 + Some(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/parser.rs:222:5 [INFO] [stdout] | [INFO] [stdout] 222 | / pub fn new(p_children: Vec>>) -> Box> { [INFO] [stdout] 223 | | Box::new(ChoiceParsingExpression { [INFO] [stdout] 224 | | children: p_children, [INFO] [stdout] 225 | | _marker: Default::default(), [INFO] [stdout] 226 | | }) [INFO] [stdout] 227 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:242:9 [INFO] [stdout] | [INFO] [stdout] 242 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 242 - return ret; [INFO] [stdout] 242 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/parser.rs:234:9 [INFO] [stdout] | [INFO] [stdout] 234 | for child in &self.children { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, child) in self.children.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/parser.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | ret.push_str(")"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `ret.push(')')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:263:9 [INFO] [stdout] | [INFO] [stdout] 263 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 263 - return None; [INFO] [stdout] 263 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/parser.rs:246:9 [INFO] [stdout] | [INFO] [stdout] 246 | for child in &self.children { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, child) in self.children.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:249:33 [INFO] [stdout] | [INFO] [stdout] 249 | match child.matches(&mut info) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/parser.rs:272:5 [INFO] [stdout] | [INFO] [stdout] 272 | / pub fn new(child: Box>) -> Box> { [INFO] [stdout] 273 | | Box::new(OneOrMoreParsingExpression { child }) [INFO] [stdout] 274 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:280:9 [INFO] [stdout] | [INFO] [stdout] 280 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 280 - return ret; [INFO] [stdout] 280 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:290:34 [INFO] [stdout] | [INFO] [stdout] 290 | match self.child.matches(&mut info) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:299:38 [INFO] [stdout] | [INFO] [stdout] 299 | match self.child.matches(&mut info) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/parser.rs:319:5 [INFO] [stdout] | [INFO] [stdout] 319 | / pub fn new(child: Box>) -> Box> { [INFO] [stdout] 320 | | Box::new(ZeroOrMoreParsingExpression { child }) [INFO] [stdout] 321 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:327:9 [INFO] [stdout] | [INFO] [stdout] 327 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 327 - return ret; [INFO] [stdout] 327 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:342:38 [INFO] [stdout] | [INFO] [stdout] 342 | match self.child.matches(&mut info) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/parser.rs:362:5 [INFO] [stdout] | [INFO] [stdout] 362 | / pub fn new(child: Box>) -> Box> { [INFO] [stdout] 363 | | Box::new(OptionalParsingExpression { child }) [INFO] [stdout] 364 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:370:9 [INFO] [stdout] | [INFO] [stdout] 370 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 370 - return ret; [INFO] [stdout] 370 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:373:34 [INFO] [stdout] | [INFO] [stdout] 373 | match self.child.matches(&mut info) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/parser.rs:391:5 [INFO] [stdout] | [INFO] [stdout] 391 | / pub fn new(child: Box>) -> Box> { [INFO] [stdout] 392 | | Box::new(AndPredicateParsingExpression { child }) [INFO] [stdout] 393 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:399:9 [INFO] [stdout] | [INFO] [stdout] 399 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 399 - return ret; [INFO] [stdout] 399 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:403:34 [INFO] [stdout] | [INFO] [stdout] 403 | match self.child.matches(&mut info) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/parser.rs:421:5 [INFO] [stdout] | [INFO] [stdout] 421 | / pub fn new(child: Box>) -> Box> { [INFO] [stdout] 422 | | Box::new(NotPredicateParsingExpression { child }) [INFO] [stdout] 423 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:429:9 [INFO] [stdout] | [INFO] [stdout] 429 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 429 - return ret; [INFO] [stdout] 429 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:433:34 [INFO] [stdout] | [INFO] [stdout] 433 | match self.child.matches(&mut info) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Parser` [INFO] [stdout] --> src/parser.rs:457:5 [INFO] [stdout] | [INFO] [stdout] 457 | / pub fn new() -> Parser { [INFO] [stdout] 458 | | Parser { [INFO] [stdout] 459 | | rules: HashMap::new(), [INFO] [stdout] 460 | | } [INFO] [stdout] 461 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 456 + impl Default for Parser { [INFO] [stdout] 457 + fn default() -> Self { [INFO] [stdout] 458 + Self::new() [INFO] [stdout] 459 + } [INFO] [stdout] 460 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:604:9 [INFO] [stdout] | [INFO] [stdout] 604 | / return if choices.len() >= 1 { [INFO] [stdout] 605 | | choices.push(Self::vec_to_expression(sequence).expect("Invalid PEG grammar")); [INFO] [stdout] 606 | | ChoiceParsingExpression::new(choices) [INFO] [stdout] 607 | | } else { [INFO] [stdout] 608 | | Self::vec_to_expression(sequence).expect("Invalid PEG grammar") [INFO] [stdout] 609 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 604 ~ if choices.len() >= 1 { [INFO] [stdout] 605 + choices.push(Self::vec_to_expression(sequence).expect("Invalid PEG grammar")); [INFO] [stdout] 606 + ChoiceParsingExpression::new(choices) [INFO] [stdout] 607 + } else { [INFO] [stdout] 608 + Self::vec_to_expression(sequence).expect("Invalid PEG grammar") [INFO] [stdout] 609 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/parser.rs:533:9 [INFO] [stdout] | [INFO] [stdout] 533 | / loop { [INFO] [stdout] 534 | | if let Some(token) = tokenizer.next_token() { [INFO] [stdout] 535 | | let expr = match token { [INFO] [stdout] 536 | | ExpressionToken::GroupBegin => Some(Self::parse_rule(tokenizer)), [INFO] [stdout] ... | [INFO] [stdout] 602 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(token) = tokenizer.next_token() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:538:28 [INFO] [stdout] | [INFO] [stdout] 538 | if choices.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!choices.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/parser.rs:604:19 [INFO] [stdout] | [INFO] [stdout] 604 | return if choices.len() >= 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!choices.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:622:9 [INFO] [stdout] | [INFO] [stdout] 622 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 622 - return None; [INFO] [stdout] 622 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/code_tokenizer.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | / return CodeTokenizer { [INFO] [stdout] 13 | | code: String::from(code), [INFO] [stdout] 14 | | states: vec![0], [INFO] [stdout] 15 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 ~ CodeTokenizer { [INFO] [stdout] 13 + code: String::from(code), [INFO] [stdout] 14 + states: vec![0], [INFO] [stdout] 15 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/code_tokenizer.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return true; [INFO] [stdout] 33 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/code_tokenizer.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 35 - return false; [INFO] [stdout] 35 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/code_tokenizer.rs:67:19 [INFO] [stdout] | [INFO] [stdout] 67 | .push(self.states.last().expect("No current state!").clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*self.states.last().expect("No current state!")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/expression_tokenizer.rs:39:20 [INFO] [stdout] | [INFO] [stdout] 39 | if c == terminal_char && (last != '\\' || (last == last_last && last == '\\')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 39 - if c == terminal_char && (last != '\\' || (last == last_last && last == '\\')) { [INFO] [stdout] 39 + if !(c != terminal_char || last == '\\' && last != last_last) { [INFO] [stdout] | [INFO] [stdout] 39 - if c == terminal_char && (last != '\\' || (last == last_last && last == '\\')) { [INFO] [stdout] 39 + if (last == last_last || last != '\\') && c == terminal_char { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/expression_tokenizer.rs:39:42 [INFO] [stdout] | [INFO] [stdout] 39 | if c == terminal_char && (last != '\\' || (last == last_last && last == '\\')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 39 - if c == terminal_char && (last != '\\' || (last == last_last && last == '\\')) { [INFO] [stdout] 39 + if c == terminal_char && !(last == '\\' && last != last_last) { [INFO] [stdout] | [INFO] [stdout] 39 - if c == terminal_char && (last != '\\' || (last == last_last && last == '\\')) { [INFO] [stdout] 39 + if c == terminal_char && last != '\\' || last == last_last { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_tokenizer.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | return tokenizer; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - return tokenizer; [INFO] [stdout] 80 + tokenizer [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>` [INFO] [stdout] --> src/expression_tokenizer.rs:30:20 [INFO] [stdout] | [INFO] [stdout] 30 | let iter = tokenstring.chars().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `tokenstring.chars()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/expression_tokenizer.rs:84:12 [INFO] [stdout] | [INFO] [stdout] 84 | if last_string.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!last_string.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_tokenizer.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | return self.tokens.len(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - return self.tokens.len(); [INFO] [stdout] 103 + self.tokens.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_tokenizer.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 111 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 - return None; [INFO] [stdout] 111 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_tokenizer.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 118 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - return None; [INFO] [stdout] 118 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_tokenizer.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 126 - return false; [INFO] [stdout] 126 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/expression_tokenizer.rs:131:9 [INFO] [stdout] | [INFO] [stdout] 131 | return first == '['; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 131 - return first == '['; [INFO] [stdout] 131 + first == '[' [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | return v; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return v; [INFO] [stdout] 22 + v [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 26 | if self.sub_results.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.sub_results.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | &self.sub_results.get(index).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.sub_results.get(index).unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:61:9 [INFO] [stdout] | [INFO] [stdout] 61 | return String::from("ParsingExpression"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - return String::from("ParsingExpression"); [INFO] [stdout] 61 + String::from("ParsingExpression") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/parser.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | / pub fn new(p_name: &str) -> Box> { [INFO] [stdout] 78 | | Box::new(TerminalParsingExpression { [INFO] [stdout] 79 | | content: TerminalType::SIMPLE(String::from(p_name)), [INFO] [stdout] 80 | | _marker: Default::default(), [INFO] [stdout] 81 | | }) [INFO] [stdout] 82 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/parser.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 131 | / pub fn new(p_name: &str) -> Box> { [INFO] [stdout] 132 | | Box::new(NonTerminalParsingExpression { [INFO] [stdout] 133 | | name: String::from(p_name), [INFO] [stdout] 134 | | _marker: Default::default(), [INFO] [stdout] 135 | | }) [INFO] [stdout] 136 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:141:9 [INFO] [stdout] | [INFO] [stdout] 141 | return String::from(format!("{}", self.name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 141 - return String::from(format!("{}", self.name)); [INFO] [stdout] 141 + String::from(format!("{}", self.name)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/parser.rs:141:16 [INFO] [stdout] | [INFO] [stdout] 141 | return String::from(format!("{}", self.name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{}", self.name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/parser.rs:141:29 [INFO] [stdout] | [INFO] [stdout] 141 | return String::from(format!("{}", self.name)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `self.name.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:148:39 [INFO] [stdout] | [INFO] [stdout] 148 | match rule.expression.matches(&mut info) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:158:62 [INFO] [stdout] | [INFO] [stdout] 158 | res_cpy.rule_result = Some(callback(res, &info.tokenizer)); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `info.tokenizer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/parser.rs:173:5 [INFO] [stdout] | [INFO] [stdout] 173 | / pub fn new(p_children: Vec>>) -> Box> { [INFO] [stdout] 174 | | Box::new(SequenceParsingExpression { [INFO] [stdout] 175 | | children: p_children, [INFO] [stdout] 176 | | _marker: Default::default(), [INFO] [stdout] 177 | | }) [INFO] [stdout] 178 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:192:9 [INFO] [stdout] | [INFO] [stdout] 192 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 192 - return ret; [INFO] [stdout] 192 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/parser.rs:185:9 [INFO] [stdout] | [INFO] [stdout] 185 | for child in &self.children { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, child) in self.children.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/parser.rs:188:17 [INFO] [stdout] | [INFO] [stdout] 188 | ret.push_str(" "); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `ret.push(' ')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:212:9 [INFO] [stdout] | [INFO] [stdout] 212 | return Some(result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 212 - return Some(result); [INFO] [stdout] 212 + Some(result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/parser.rs:222:5 [INFO] [stdout] | [INFO] [stdout] 222 | / pub fn new(p_children: Vec>>) -> Box> { [INFO] [stdout] 223 | | Box::new(ChoiceParsingExpression { [INFO] [stdout] 224 | | children: p_children, [INFO] [stdout] 225 | | _marker: Default::default(), [INFO] [stdout] 226 | | }) [INFO] [stdout] 227 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:242:9 [INFO] [stdout] | [INFO] [stdout] 242 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 242 - return ret; [INFO] [stdout] 242 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/parser.rs:234:9 [INFO] [stdout] | [INFO] [stdout] 234 | for child in &self.children { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, child) in self.children.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/parser.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | ret.push_str(")"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `ret.push(')')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:263:9 [INFO] [stdout] | [INFO] [stdout] 263 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 263 - return None; [INFO] [stdout] 263 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/parser.rs:246:9 [INFO] [stdout] | [INFO] [stdout] 246 | for child in &self.children { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, child) in self.children.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:249:33 [INFO] [stdout] | [INFO] [stdout] 249 | match child.matches(&mut info) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/parser.rs:272:5 [INFO] [stdout] | [INFO] [stdout] 272 | / pub fn new(child: Box>) -> Box> { [INFO] [stdout] 273 | | Box::new(OneOrMoreParsingExpression { child }) [INFO] [stdout] 274 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:280:9 [INFO] [stdout] | [INFO] [stdout] 280 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 280 - return ret; [INFO] [stdout] 280 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:290:34 [INFO] [stdout] | [INFO] [stdout] 290 | match self.child.matches(&mut info) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:299:38 [INFO] [stdout] | [INFO] [stdout] 299 | match self.child.matches(&mut info) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/parser.rs:319:5 [INFO] [stdout] | [INFO] [stdout] 319 | / pub fn new(child: Box>) -> Box> { [INFO] [stdout] 320 | | Box::new(ZeroOrMoreParsingExpression { child }) [INFO] [stdout] 321 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:327:9 [INFO] [stdout] | [INFO] [stdout] 327 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 327 - return ret; [INFO] [stdout] 327 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:342:38 [INFO] [stdout] | [INFO] [stdout] 342 | match self.child.matches(&mut info) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/parser.rs:362:5 [INFO] [stdout] | [INFO] [stdout] 362 | / pub fn new(child: Box>) -> Box> { [INFO] [stdout] 363 | | Box::new(OptionalParsingExpression { child }) [INFO] [stdout] 364 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:370:9 [INFO] [stdout] | [INFO] [stdout] 370 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 370 - return ret; [INFO] [stdout] 370 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:373:34 [INFO] [stdout] | [INFO] [stdout] 373 | match self.child.matches(&mut info) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/parser.rs:391:5 [INFO] [stdout] | [INFO] [stdout] 391 | / pub fn new(child: Box>) -> Box> { [INFO] [stdout] 392 | | Box::new(AndPredicateParsingExpression { child }) [INFO] [stdout] 393 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:399:9 [INFO] [stdout] | [INFO] [stdout] 399 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 399 - return ret; [INFO] [stdout] 399 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:403:34 [INFO] [stdout] | [INFO] [stdout] 403 | match self.child.matches(&mut info) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/parser.rs:421:5 [INFO] [stdout] | [INFO] [stdout] 421 | / pub fn new(child: Box>) -> Box> { [INFO] [stdout] 422 | | Box::new(NotPredicateParsingExpression { child }) [INFO] [stdout] 423 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:429:9 [INFO] [stdout] | [INFO] [stdout] 429 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 429 - return ret; [INFO] [stdout] 429 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parser.rs:433:34 [INFO] [stdout] | [INFO] [stdout] 433 | match self.child.matches(&mut info) { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Parser` [INFO] [stdout] --> src/parser.rs:457:5 [INFO] [stdout] | [INFO] [stdout] 457 | / pub fn new() -> Parser { [INFO] [stdout] 458 | | Parser { [INFO] [stdout] 459 | | rules: HashMap::new(), [INFO] [stdout] 460 | | } [INFO] [stdout] 461 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 456 + impl Default for Parser { [INFO] [stdout] 457 + fn default() -> Self { [INFO] [stdout] 458 + Self::new() [INFO] [stdout] 459 + } [INFO] [stdout] 460 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:604:9 [INFO] [stdout] | [INFO] [stdout] 604 | / return if choices.len() >= 1 { [INFO] [stdout] 605 | | choices.push(Self::vec_to_expression(sequence).expect("Invalid PEG grammar")); [INFO] [stdout] 606 | | ChoiceParsingExpression::new(choices) [INFO] [stdout] 607 | | } else { [INFO] [stdout] 608 | | Self::vec_to_expression(sequence).expect("Invalid PEG grammar") [INFO] [stdout] 609 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 604 ~ if choices.len() >= 1 { [INFO] [stdout] 605 + choices.push(Self::vec_to_expression(sequence).expect("Invalid PEG grammar")); [INFO] [stdout] 606 + ChoiceParsingExpression::new(choices) [INFO] [stdout] 607 + } else { [INFO] [stdout] 608 + Self::vec_to_expression(sequence).expect("Invalid PEG grammar") [INFO] [stdout] 609 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/parser.rs:533:9 [INFO] [stdout] | [INFO] [stdout] 533 | / loop { [INFO] [stdout] 534 | | if let Some(token) = tokenizer.next_token() { [INFO] [stdout] 535 | | let expr = match token { [INFO] [stdout] 536 | | ExpressionToken::GroupBegin => Some(Self::parse_rule(tokenizer)), [INFO] [stdout] ... | [INFO] [stdout] 602 | | } [INFO] [stdout] | |_________^ help: try: `while let Some(token) = tokenizer.next_token() { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parser.rs:538:28 [INFO] [stdout] | [INFO] [stdout] 538 | if choices.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!choices.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/parser.rs:604:19 [INFO] [stdout] | [INFO] [stdout] 604 | return if choices.len() >= 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!choices.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parser.rs:622:9 [INFO] [stdout] | [INFO] [stdout] 622 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 622 - return None; [INFO] [stdout] 622 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/test_parser.rs:230:17 [INFO] [stdout] | [INFO] [stdout] 230 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 230 - return sum; [INFO] [stdout] 230 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/test_parser.rs:246:17 [INFO] [stdout] | [INFO] [stdout] 246 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 246 - return sum; [INFO] [stdout] 246 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/test_parser.rs:260:25 [INFO] [stdout] | [INFO] [stdout] 260 | return i; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 260 - return i; [INFO] [stdout] 260 + i [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> tests/test_parser.rs:263:25 [INFO] [stdout] | [INFO] [stdout] 263 | return r[0][1].rule_result.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 263 - return r[0][1].rule_result.unwrap(); [INFO] [stdout] 263 + r[0][1].rule_result.unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.74s [INFO] running `Command { std: "docker" "inspect" "c7add89dc2476a23f8fadd5ca36c528164f4a56522a33a8ec5e1324284eaf2c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c7add89dc2476a23f8fadd5ca36c528164f4a56522a33a8ec5e1324284eaf2c2", kill_on_drop: false }` [INFO] [stdout] c7add89dc2476a23f8fadd5ca36c528164f4a56522a33a8ec5e1324284eaf2c2