[INFO] cloning repository https://github.com/Valentine-Mario/register-vm [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Valentine-Mario/register-vm" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FValentine-Mario%2Fregister-vm", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FValentine-Mario%2Fregister-vm'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 09ca1e3d4a91b02a62fc4103e34d4771c32d09dd [INFO] linting Valentine-Mario/register-vm against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FValentine-Mario%2Fregister-vm" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Valentine-Mario/register-vm [INFO] finished tweaking git repo https://github.com/Valentine-Mario/register-vm [INFO] tweaked toml for git repo https://github.com/Valentine-Mario/register-vm written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Valentine-Mario/register-vm on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Valentine-Mario/register-vm already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded hermit-abi v0.1.15 [INFO] [stderr] Downloaded yaml-rust v0.3.5 [INFO] [stderr] Downloaded nom v4.2.3 [INFO] [stderr] Downloaded clap v2.33.1 [INFO] [stderr] Downloaded libc v0.2.71 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c5751e3868391512cddaf55449de653c46dbdaa345af5ea0f1332bfddf31a0e1 [INFO] running `Command { std: "docker" "start" "-a" "c5751e3868391512cddaf55449de653c46dbdaa345af5ea0f1332bfddf31a0e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c5751e3868391512cddaf55449de653c46dbdaa345af5ea0f1332bfddf31a0e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5751e3868391512cddaf55449de653c46dbdaa345af5ea0f1332bfddf31a0e1", kill_on_drop: false }` [INFO] [stdout] c5751e3868391512cddaf55449de653c46dbdaa345af5ea0f1332bfddf31a0e1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 20c15d8c8e23def179c74d81a8a3c021f44b21ceff4ca1536589e0f608bc3cd1 [INFO] running `Command { std: "docker" "start" "-a" "20c15d8c8e23def179c74d81a8a3c021f44b21ceff4ca1536589e0f608bc3cd1", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.71 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling nom v4.2.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Checking vm v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/instruction.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | opcode:opcode [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/instruction.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | opcode:opcode [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::assembler::register_parser` [INFO] [stdout] --> src/assembler/opcode_parser.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::assembler::register_parser; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::assembler::register_parser` [INFO] [stdout] --> src/assembler/opcode_parser.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::assembler::register_parser; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/assembler/opcode_parser.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/assembler/program_parser.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | instructions: instructions [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instructions` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom::digit` [INFO] [stdout] --> src/assembler/operand_parser.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use nom::digit; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/assembler/program_parser.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | instructions: instructions [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instructions` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::vm` [INFO] [stdout] --> src/assembler/mod.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use crate::vm; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `nom::digit` [INFO] [stdout] --> src/assembler/operand_parser.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use nom::digit; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Arg` and `SubCommand` [INFO] [stdout] --> src/main.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 12 | use clap::{Arg, App, SubCommand}; [INFO] [stdout] | ^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Arg` and `SubCommand` [INFO] [stdout] --> src/main.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 12 | use clap::{Arg, App, SubCommand}; [INFO] [stdout] | ^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `remainder` [INFO] [stdout] --> src/repl/mod.rs:78:29 [INFO] [stdout] | [INFO] [stdout] 78 | Ok((remainder, program)) => { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_remainder` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `symbol_type` is never read [INFO] [stdout] --> src/assembler/mod.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 125 | pub struct Symbol { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 128 | symbol_type: SymbolType, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Symbol` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `VM` [INFO] [stdout] --> src/vm.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / pub fn new()->VM{ [INFO] [stdout] 22 | | VM{ [INFO] [stdout] 23 | | registers:[0;32], [INFO] [stdout] 24 | | pc:0, [INFO] [stdout] ... | [INFO] [stdout] 30 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 20 + impl Default for VM { [INFO] [stdout] 21 + fn default() -> Self { [INFO] [stdout] 22 + Self::new() [INFO] [stdout] 23 + } [INFO] [stdout] 24 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/vm.rs:77:34 [INFO] [stdout] | [INFO] [stdout] 77 | let number = self.next_16_bits() as u16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.next_16_bits()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 191 | return opcode; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 191 - return opcode; [INFO] [stdout] 191 + opcode [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 196 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 196 - return result; [INFO] [stdout] 196 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:202:9 [INFO] [stdout] | [INFO] [stdout] 202 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 202 - return result; [INFO] [stdout] 202 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/vm.rs:209:29 [INFO] [stdout] | [INFO] [stdout] 209 | prepension.push(byte.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `REPL` [INFO] [stdout] --> src/repl/mod.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / pub fn new()->REPL{ [INFO] [stdout] 20 | | REPL{ [INFO] [stdout] 21 | | vm:VM::new(), [INFO] [stdout] 22 | | command_buffer:vec![] [INFO] [stdout] 23 | | } [INFO] [stdout] 24 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 18 + impl Default for REPL { [INFO] [stdout] 19 + fn default() -> Self { [INFO] [stdout] 20 + Self::new() [INFO] [stdout] 21 + } [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/repl/mod.rs:92:20 [INFO] [stdout] | [INFO] [stdout] 92 | if !parsed_program.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parsed_program.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/repl/mod.rs:86:21 [INFO] [stdout] | [INFO] [stdout] 86 | let bytecode= self.vm.program.append(&mut program.to_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 86 ~ self.vm.program.append(&mut program.to_bytes()); [INFO] [stdout] 87 ~ println!("{:?}", ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assembler/instruction_parsers.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | return results; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return results; [INFO] [stdout] 79 + results [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> src/assembler/instruction_parsers.rs:56:39 [INFO] [stdout] | [INFO] [stdout] 56 | Token::Op { code } => match code { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 57 | | _ => { [INFO] [stdout] 58 | | let b: u8 = (*code).into(); [INFO] [stdout] 59 | | results.push(b); [INFO] [stdout] ... | [INFO] [stdout] 62 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 56 ~ Token::Op { code } => { [INFO] [stdout] 57 + let b: u8 = (*code).into(); [INFO] [stdout] 58 + results.push(b); [INFO] [stdout] 59 + [INFO] [stdout] 60 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Some` variant of the iterator element is used [INFO] [stdout] --> src/assembler/instruction_parsers.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 69 | / for operand in &[&self.operand1, &self.operand2, &self.operand3] { [INFO] [stdout] 70 | | if let Some(token) = operand { [INFO] [stdout] 71 | | AssemblerInstruction::extract_operand(token, &mut results) [INFO] [stdout] 72 | | } [INFO] [stdout] 73 | | } [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/assembler/instruction_parsers.rs:70:17 [INFO] [stdout] | [INFO] [stdout] 70 | / if let Some(token) = operand { [INFO] [stdout] 71 | | AssemblerInstruction::extract_operand(token, &mut results) [INFO] [stdout] 72 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 69 ~ for token in [&self.operand1, &self.operand2, &self.operand3].iter().copied().flatten() { [INFO] [stdout] 70 + AssemblerInstruction::extract_operand(token, &mut results) [INFO] [stdout] 71 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:87:24 [INFO] [stdout] | [INFO] [stdout] 87 | Some(l) => match l { [INFO] [stdout] | ________________________^ [INFO] [stdout] 88 | | Token::LabelDeclaration { name } => Some(name.clone()), [INFO] [stdout] 89 | | _ => None, [INFO] [stdout] 90 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/assembler/instruction_parsers.rs:87:18 [INFO] [stdout] | [INFO] [stdout] 87 | Some(l) => match l { [INFO] [stdout] | ^ replace this binding [INFO] [stdout] 88 | Token::LabelDeclaration { name } => Some(name.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Assembler` [INFO] [stdout] --> src/assembler/mod.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | / pub fn new() -> Assembler { [INFO] [stdout] 37 | | Assembler { [INFO] [stdout] 38 | | phase: AssemblerPhase::First, [INFO] [stdout] 39 | | symbols: SymbolTable::new() [INFO] [stdout] 40 | | } [INFO] [stdout] 41 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 35 + impl Default for Assembler { [INFO] [stdout] 36 + fn default() -> Self { [INFO] [stdout] 37 + Self::new() [INFO] [stdout] 38 + } [INFO] [stdout] 39 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/assembler/mod.rs:99:17 [INFO] [stdout] | [INFO] [stdout] 99 | / match i.get_label_name() { [INFO] [stdout] 100 | | Some(name) => { [INFO] [stdout] 101 | | let symbol = Symbol::new(name, SymbolType::Label, c); [INFO] [stdout] 102 | | self.symbols.add_symbol(symbol); [INFO] [stdout] 103 | | }, [INFO] [stdout] 104 | | None => {} [INFO] [stdout] 105 | | }; [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 99 ~ if let Some(name) = i.get_label_name() { [INFO] [stdout] 100 + let symbol = Symbol::new(name, SymbolType::Label, c); [INFO] [stdout] 101 + self.symbols.add_symbol(symbol); [INFO] [stdout] 102 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/assembler/mod.rs:115:25 [INFO] [stdout] | [INFO] [stdout] 115 | header.push(byte.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/assembler/mod.rs:118:25 [INFO] [stdout] | [INFO] [stdout] 118 | header.push(0 as u8); [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `SymbolTable` [INFO] [stdout] --> src/assembler/mod.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 152 | / pub fn new() -> SymbolTable { [INFO] [stdout] 153 | | SymbolTable{ [INFO] [stdout] 154 | | symbols: vec![] [INFO] [stdout] 155 | | } [INFO] [stdout] 156 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 151 + impl Default for SymbolTable { [INFO] [stdout] 152 + fn default() -> Self { [INFO] [stdout] 153 + Self::new() [INFO] [stdout] 154 + } [INFO] [stdout] 155 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | / match program { [INFO] [stdout] 31 | | Some(p) => { [INFO] [stdout] 32 | | vm.add_bytes(p); [INFO] [stdout] 33 | | vm.run(); [INFO] [stdout] ... | [INFO] [stdout] 36 | | None => {} [INFO] [stdout] 37 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 30 ~ if let Some(p) = program { [INFO] [stdout] 31 + vm.add_bytes(p); [INFO] [stdout] 32 + vm.run(); [INFO] [stdout] 33 + std::process::exit(0); [INFO] [stdout] 34 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | return contents; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return contents; [INFO] [stdout] 58 + contents [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `remainder` [INFO] [stdout] --> src/repl/mod.rs:78:29 [INFO] [stdout] | [INFO] [stdout] 78 | Ok((remainder, program)) => { [INFO] [stdout] | ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_remainder` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `symbol_type` is never read [INFO] [stdout] --> src/assembler/mod.rs:128:5 [INFO] [stdout] | [INFO] [stdout] 125 | pub struct Symbol { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 128 | symbol_type: SymbolType, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Symbol` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `VM` [INFO] [stdout] --> src/vm.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | / pub fn new()->VM{ [INFO] [stdout] 22 | | VM{ [INFO] [stdout] 23 | | registers:[0;32], [INFO] [stdout] 24 | | pc:0, [INFO] [stdout] ... | [INFO] [stdout] 30 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 20 + impl Default for VM { [INFO] [stdout] 21 + fn default() -> Self { [INFO] [stdout] 22 + Self::new() [INFO] [stdout] 23 + } [INFO] [stdout] 24 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/vm.rs:77:34 [INFO] [stdout] | [INFO] [stdout] 77 | let number = self.next_16_bits() as u16; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.next_16_bits()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 191 | return opcode; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 191 - return opcode; [INFO] [stdout] 191 + opcode [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 196 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 196 - return result; [INFO] [stdout] 196 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/vm.rs:202:9 [INFO] [stdout] | [INFO] [stdout] 202 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 202 - return result; [INFO] [stdout] 202 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/vm.rs:209:29 [INFO] [stdout] | [INFO] [stdout] 209 | prepension.push(byte.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:234:5 [INFO] [stdout] | [INFO] [stdout] 234 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 234 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 234 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:237:5 [INFO] [stdout] | [INFO] [stdout] 237 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 237 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 237 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:302:9 [INFO] [stdout] | [INFO] [stdout] 302 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 302 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 302 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:305:9 [INFO] [stdout] | [INFO] [stdout] 305 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 305 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 305 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:308:9 [INFO] [stdout] | [INFO] [stdout] 308 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 308 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 308 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:318:9 [INFO] [stdout] | [INFO] [stdout] 318 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 318 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 318 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:321:9 [INFO] [stdout] | [INFO] [stdout] 321 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 321 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 321 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:331:9 [INFO] [stdout] | [INFO] [stdout] 331 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 331 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 331 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:334:9 [INFO] [stdout] | [INFO] [stdout] 334 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 334 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 334 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:337:9 [INFO] [stdout] | [INFO] [stdout] 337 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 337 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 337 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:347:9 [INFO] [stdout] | [INFO] [stdout] 347 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 347 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 347 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:350:9 [INFO] [stdout] | [INFO] [stdout] 350 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 350 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 350 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:353:9 [INFO] [stdout] | [INFO] [stdout] 353 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 353 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 353 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:363:9 [INFO] [stdout] | [INFO] [stdout] 363 | assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 363 - assert_eq!(test_vm.equal_flag, true); [INFO] [stdout] 363 + assert!(test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:366:9 [INFO] [stdout] | [INFO] [stdout] 366 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 366 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 366 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/vm.rs:369:9 [INFO] [stdout] | [INFO] [stdout] 369 | assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 369 - assert_eq!(test_vm.equal_flag, false); [INFO] [stdout] 369 + assert!(!test_vm.equal_flag); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `REPL` [INFO] [stdout] --> src/repl/mod.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | / pub fn new()->REPL{ [INFO] [stdout] 20 | | REPL{ [INFO] [stdout] 21 | | vm:VM::new(), [INFO] [stdout] 22 | | command_buffer:vec![] [INFO] [stdout] 23 | | } [INFO] [stdout] 24 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 18 + impl Default for REPL { [INFO] [stdout] 19 + fn default() -> Self { [INFO] [stdout] 20 + Self::new() [INFO] [stdout] 21 + } [INFO] [stdout] 22 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/repl/mod.rs:92:20 [INFO] [stdout] | [INFO] [stdout] 92 | if !parsed_program.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `parsed_program.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/repl/mod.rs:86:21 [INFO] [stdout] | [INFO] [stdout] 86 | let bytecode= self.vm.program.append(&mut program.to_bytes()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding and replace variable usages with `()` [INFO] [stdout] | [INFO] [stdout] 86 ~ self.vm.program.append(&mut program.to_bytes()); [INFO] [stdout] 87 ~ println!("{:?}", ()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/opcode_parser.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 42 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 42 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/opcode_parser.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 49 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 49 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/opcode_parser.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 58 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 58 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/opcode_parser.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | assert_eq!(result.is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 65 - assert_eq!(result.is_ok(), false); [INFO] [stdout] 65 + assert!(!result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/opcode_parser.rs:71:5 [INFO] [stdout] | [INFO] [stdout] 71 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 71 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 71 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/assembler/instruction_parsers.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | return results; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return results; [INFO] [stdout] 79 + results [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this match could be replaced by its body itself [INFO] [stdout] --> src/assembler/instruction_parsers.rs:56:39 [INFO] [stdout] | [INFO] [stdout] 56 | Token::Op { code } => match code { [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 57 | | _ => { [INFO] [stdout] 58 | | let b: u8 = (*code).into(); [INFO] [stdout] 59 | | results.push(b); [INFO] [stdout] ... | [INFO] [stdout] 62 | | }, [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding [INFO] [stdout] = note: `#[warn(clippy::match_single_binding)]` on by default [INFO] [stdout] help: consider using the match body instead [INFO] [stdout] | [INFO] [stdout] 56 ~ Token::Op { code } => { [INFO] [stdout] 57 + let b: u8 = (*code).into(); [INFO] [stdout] 58 + results.push(b); [INFO] [stdout] 59 + [INFO] [stdout] 60 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary `if let` since only the `Some` variant of the iterator element is used [INFO] [stdout] --> src/assembler/instruction_parsers.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 69 | / for operand in &[&self.operand1, &self.operand2, &self.operand3] { [INFO] [stdout] 70 | | if let Some(token) = operand { [INFO] [stdout] 71 | | AssemblerInstruction::extract_operand(token, &mut results) [INFO] [stdout] 72 | | } [INFO] [stdout] 73 | | } [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop [INFO] [stdout] --> src/assembler/instruction_parsers.rs:70:17 [INFO] [stdout] | [INFO] [stdout] 70 | / if let Some(token) = operand { [INFO] [stdout] 71 | | AssemblerInstruction::extract_operand(token, &mut results) [INFO] [stdout] 72 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten [INFO] [stdout] = note: `#[warn(clippy::manual_flatten)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 69 ~ for token in [&self.operand1, &self.operand2, &self.operand3].iter().copied().flatten() { [INFO] [stdout] 70 + AssemblerInstruction::extract_operand(token, &mut results) [INFO] [stdout] 71 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `match` [INFO] [stdout] --> src/assembler/instruction_parsers.rs:87:24 [INFO] [stdout] | [INFO] [stdout] 87 | Some(l) => match l { [INFO] [stdout] | ________________________^ [INFO] [stdout] 88 | | Token::LabelDeclaration { name } => Some(name.clone()), [INFO] [stdout] 89 | | _ => None, [INFO] [stdout] 90 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/assembler/instruction_parsers.rs:87:18 [INFO] [stdout] | [INFO] [stdout] 87 | Some(l) => match l { [INFO] [stdout] | ^ replace this binding [INFO] [stdout] 88 | Token::LabelDeclaration { name } => Some(name.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/program_parser.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 34 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 34 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/program_parser.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 46 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 46 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/register_parser.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 28 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 28 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 28 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/register_parser.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | assert_eq!(result.is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 30 - assert_eq!(result.is_ok(), false); [INFO] [stdout] 30 + assert!(!result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/register_parser.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | assert_eq!(result.is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 32 - assert_eq!(result.is_ok(), false); [INFO] [stdout] 32 + assert!(!result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/label_parser.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 40 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 40 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/label_parser.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | assert_eq!(result.is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 44 - assert_eq!(result.is_ok(), false); [INFO] [stdout] 44 + assert!(!result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/label_parser.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 50 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 50 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/label_parser.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | assert_eq!(result.is_ok(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 54 - assert_eq!(result.is_ok(), false); [INFO] [stdout] 54 + assert!(!result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/directive_parser.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | assert_eq!(result.is_ok(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 63 - assert_eq!(result.is_ok(), true); [INFO] [stdout] 63 + assert!(result.is_ok()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Assembler` [INFO] [stdout] --> src/assembler/mod.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | / pub fn new() -> Assembler { [INFO] [stdout] 37 | | Assembler { [INFO] [stdout] 38 | | phase: AssemblerPhase::First, [INFO] [stdout] 39 | | symbols: SymbolTable::new() [INFO] [stdout] 40 | | } [INFO] [stdout] 41 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 35 + impl Default for Assembler { [INFO] [stdout] 36 + fn default() -> Self { [INFO] [stdout] 37 + Self::new() [INFO] [stdout] 38 + } [INFO] [stdout] 39 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/assembler/mod.rs:99:17 [INFO] [stdout] | [INFO] [stdout] 99 | / match i.get_label_name() { [INFO] [stdout] 100 | | Some(name) => { [INFO] [stdout] 101 | | let symbol = Symbol::new(name, SymbolType::Label, c); [INFO] [stdout] 102 | | self.symbols.add_symbol(symbol); [INFO] [stdout] 103 | | }, [INFO] [stdout] 104 | | None => {} [INFO] [stdout] 105 | | }; [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 99 ~ if let Some(name) = i.get_label_name() { [INFO] [stdout] 100 + let symbol = Symbol::new(name, SymbolType::Label, c); [INFO] [stdout] 101 + self.symbols.add_symbol(symbol); [INFO] [stdout] 102 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/assembler/mod.rs:115:25 [INFO] [stdout] | [INFO] [stdout] 115 | header.push(byte.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*byte` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/assembler/mod.rs:118:25 [INFO] [stdout] | [INFO] [stdout] 118 | header.push(0 as u8); [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `SymbolTable` [INFO] [stdout] --> src/assembler/mod.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 152 | / pub fn new() -> SymbolTable { [INFO] [stdout] 153 | | SymbolTable{ [INFO] [stdout] 154 | | symbols: vec![] [INFO] [stdout] 155 | | } [INFO] [stdout] 156 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 151 + impl Default for SymbolTable { [INFO] [stdout] 152 + fn default() -> Self { [INFO] [stdout] 153 + Self::new() [INFO] [stdout] 154 + } [INFO] [stdout] 155 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/mod.rs:185:5 [INFO] [stdout] | [INFO] [stdout] 185 | assert_eq!(true, v.is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 185 - assert_eq!(true, v.is_some()); [INFO] [stdout] 185 + assert!(v.is_some()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/assembler/mod.rs:189:5 [INFO] [stdout] | [INFO] [stdout] 189 | assert_eq!(v.is_some(), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 189 - assert_eq!(v.is_some(), false); [INFO] [stdout] 189 + assert!(!v.is_some()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | / match program { [INFO] [stdout] 31 | | Some(p) => { [INFO] [stdout] 32 | | vm.add_bytes(p); [INFO] [stdout] 33 | | vm.run(); [INFO] [stdout] ... | [INFO] [stdout] 36 | | None => {} [INFO] [stdout] 37 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 30 ~ if let Some(p) = program { [INFO] [stdout] 31 + vm.add_bytes(p); [INFO] [stdout] 32 + vm.run(); [INFO] [stdout] 33 + std::process::exit(0); [INFO] [stdout] 34 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | return contents; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return contents; [INFO] [stdout] 58 + contents [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.91s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: nom v4.2.3 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "20c15d8c8e23def179c74d81a8a3c021f44b21ceff4ca1536589e0f608bc3cd1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "20c15d8c8e23def179c74d81a8a3c021f44b21ceff4ca1536589e0f608bc3cd1", kill_on_drop: false }` [INFO] [stdout] 20c15d8c8e23def179c74d81a8a3c021f44b21ceff4ca1536589e0f608bc3cd1