[INFO] cloning repository https://github.com/VIRUXE/gtasa-dl [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/VIRUXE/gtasa-dl" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVIRUXE%2Fgtasa-dl", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVIRUXE%2Fgtasa-dl'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5c502096356bd28a2ac388906105b06f6b5fb2d7 [INFO] linting VIRUXE/gtasa-dl against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FVIRUXE%2Fgtasa-dl" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/VIRUXE/gtasa-dl [INFO] finished tweaking git repo https://github.com/VIRUXE/gtasa-dl [INFO] tweaked toml for git repo https://github.com/VIRUXE/gtasa-dl written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/VIRUXE/gtasa-dl on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/VIRUXE/gtasa-dl already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded check_elevation v0.2.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bf747285a75da5470ff93d07eb3f5f1eeaf46978d82ab5b0f0cd31af872d5638 [INFO] running `Command { std: "docker" "start" "-a" "bf747285a75da5470ff93d07eb3f5f1eeaf46978d82ab5b0f0cd31af872d5638", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bf747285a75da5470ff93d07eb3f5f1eeaf46978d82ab5b0f0cd31af872d5638", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bf747285a75da5470ff93d07eb3f5f1eeaf46978d82ab5b0f0cd31af872d5638", kill_on_drop: false }` [INFO] [stdout] bf747285a75da5470ff93d07eb3f5f1eeaf46978d82ab5b0f0cd31af872d5638 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d60f063c8115feae42086c905b9046507372426a2f16be32e0d6b43a7e6684b8 [INFO] running `Command { std: "docker" "start" "-a" "d60f063c8115feae42086c905b9046507372426a2f16be32e0d6b43a7e6684b8", kill_on_drop: false }` [INFO] [stderr] Compiling windows_x86_64_gnu v0.48.5 [INFO] [stderr] Checking windows-targets v0.48.5 [INFO] [stderr] Checking windows-core v0.51.1 [INFO] [stderr] Checking windows v0.51.1 [INFO] [stderr] Checking check_elevation v0.2.4 [INFO] [stderr] Checking gtasa-downloader v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> src/os.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | / Command::new("powershell") [INFO] [stdout] 48 | | .arg("-c") [INFO] [stdout] 49 | | .arg(format!("Add-MpPreference -ExclusionPath '{}\\sampcac_client.asi'", std::env::current_dir().unwrap().join(&install_di... [INFO] [stdout] 50 | | .spawn() [INFO] [stdout] 51 | | .expect("Failed to execute powershell"); [INFO] [stdout] | | ^- help: try: `.wait()` [INFO] [stdout] | |_______________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] = note: `#[warn(clippy::zombie_processes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | if !std::fs::metadata("gtasa.7z").is_ok() { return false; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata("gtasa.7z").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return true; [INFO] [stdout] 15 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:103:8 [INFO] [stdout] | [INFO] [stdout] 103 | if !std::fs::metadata(&install_dir).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&install_dir).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> src/main.rs:124:13 [INFO] [stdout] | [INFO] [stdout] 124 | let _ = io::stdin().bytes().next(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] = note: `#[warn(clippy::unbuffered_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: spawned process is never `wait()`ed on [INFO] [stdout] --> src/os.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | / Command::new("powershell") [INFO] [stdout] 48 | | .arg("-c") [INFO] [stdout] 49 | | .arg(format!("Add-MpPreference -ExclusionPath '{}\\sampcac_client.asi'", std::env::current_dir().unwrap().join(&install_di... [INFO] [stdout] 50 | | .spawn() [INFO] [stdout] 51 | | .expect("Failed to execute powershell"); [INFO] [stdout] | | ^- help: try: `.wait()` [INFO] [stdout] | |_______________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = note: not doing so might leave behind zombie processes [INFO] [stdout] = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes [INFO] [stdout] = note: `#[warn(clippy::zombie_processes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/game.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | if !std::fs::metadata("gtasa.7z").is_ok() { return false; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata("gtasa.7z").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/game.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 15 - return true; [INFO] [stdout] 15 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:103:8 [INFO] [stdout] | [INFO] [stdout] 103 | if !std::fs::metadata(&install_dir).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&install_dir).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling .bytes() is very inefficient when data is not in memory [INFO] [stdout] --> src/main.rs:124:13 [INFO] [stdout] | [INFO] [stdout] 124 | let _ = io::stdin().bytes().next(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `BufReader` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unbuffered_bytes [INFO] [stdout] = note: `#[warn(clippy::unbuffered_bytes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.87s [INFO] running `Command { std: "docker" "inspect" "d60f063c8115feae42086c905b9046507372426a2f16be32e0d6b43a7e6684b8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d60f063c8115feae42086c905b9046507372426a2f16be32e0d6b43a7e6684b8", kill_on_drop: false }` [INFO] [stdout] d60f063c8115feae42086c905b9046507372426a2f16be32e0d6b43a7e6684b8