[INFO] cloning repository https://github.com/UnmappedStack/vodka
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/UnmappedStack/vodka" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FUnmappedStack%2Fvodka", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FUnmappedStack%2Fvodka'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 111e29df0858797bf68c4c23d926899463348016
[INFO] linting UnmappedStack/vodka against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FUnmappedStack%2Fvodka" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/UnmappedStack/vodka
[INFO] finished tweaking git repo https://github.com/UnmappedStack/vodka
[INFO] tweaked toml for git repo https://github.com/UnmappedStack/vodka written to /workspace/builds/worker-3-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/UnmappedStack/vodka on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/UnmappedStack/vodka already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 29a5c1d9de146e675ec41258f958da2b1d8c0b9f654922f594a2cb922ef56dea
[INFO] running `Command { std: "docker" "start" "-a" "29a5c1d9de146e675ec41258f958da2b1d8c0b9f654922f594a2cb922ef56dea", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "29a5c1d9de146e675ec41258f958da2b1d8c0b9f654922f594a2cb922ef56dea", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "29a5c1d9de146e675ec41258f958da2b1d8c0b9f654922f594a2cb922ef56dea", kill_on_drop: false }`
[INFO] [stdout] 29a5c1d9de146e675ec41258f958da2b1d8c0b9f654922f594a2cb922ef56dea
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 8eb6f4e5d01fb2ab9a30a58cc0253257a35dd568cefd5113aa2b9a675408f2fa
[INFO] running `Command { std: "docker" "start" "-a" "8eb6f4e5d01fb2ab9a30a58cc0253257a35dd568cefd5113aa2b9a675408f2fa", kill_on_drop: false }`
[INFO] [stderr]     Checking vodka v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: this `impl` can be derived
[INFO] [stdout]   --> src/parser.rs:27:1
[INFO] [stdout]    |
[INFO] [stdout] 27 | / impl Default for AddrOffset {
[INFO] [stdout] 28 | |     fn default() -> Self {
[INFO] [stdout] 29 | |         AddrOffset::Dflt
[INFO] [stdout] 30 | |     }
[INFO] [stdout] 31 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
[INFO] [stdout]    = note: `#[warn(clippy::derivable_impls)]` on by default
[INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant
[INFO] [stdout]    |
[INFO] [stdout] 20 + #[derive(Default)]
[INFO] [stdout] 21 | pub enum AddrOffset {
[INFO] [stdout] 22 |     Register(String),
[INFO] [stdout] 23 |     Number(isize),
[INFO] [stdout] 24 |     Label(String),
[INFO] [stdout] 25 ~     #[default]
[INFO] [stdout] 26 ~     Dflt // default
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/parser.rs:140:20
[INFO] [stdout]     |
[INFO] [stdout] 140 |                 if !n.is_ok() {
[INFO] [stdout]     |                    ^^^^^^^^^^ help: try: `n.is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `n` after checking its variant with `is_ok`
[INFO] [stdout]    --> src/parser.rs:105:55
[INFO] [stdout]     |
[INFO] [stdout] 103 |         if n.is_ok() {
[INFO] [stdout]     |         ------------ help: try: `if let Ok(<item>) = n`
[INFO] [stdout] 104 |             if instr.oper1 == None {
[INFO] [stdout] 105 |                 instr.oper1 = Some(Operand::Immediate(n.unwrap()));
[INFO] [stdout]     |                                                       ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `n` after checking its variant with `is_ok`
[INFO] [stdout]    --> src/parser.rs:107:55
[INFO] [stdout]     |
[INFO] [stdout] 103 |         if n.is_ok() {
[INFO] [stdout]     |         ------------ help: try: `if let Ok(<item>) = n`
[INFO] [stdout] ...
[INFO] [stdout] 107 |                 instr.oper0 = Some(Operand::Immediate(n.unwrap()));
[INFO] [stdout]     |                                                       ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parser.rs:165:5
[INFO] [stdout]     |
[INFO] [stdout] 165 |     return Some(instr);
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 165 -     return Some(instr);
[INFO] [stdout] 165 +     Some(instr)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/parser.rs:75:8
[INFO] [stdout]    |
[INFO] [stdout] 75 |     if instruction.len() == 0 {return None}
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `instruction.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should use the `ends_with` method
[INFO] [stdout]   --> src/parser.rs:77:8
[INFO] [stdout]    |
[INFO] [stdout] 77 |     if instruction.chars().last() == Some(':') {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `instruction.ends_with(':')`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp
[INFO] [stdout]    = note: `#[warn(clippy::chars_last_cmp)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow
[INFO] [stdout]   --> src/parser.rs:78:28
[INFO] [stdout]    |
[INFO] [stdout] 78 |         instr.label = Some((&instruction[..instruction.len() - 1]).to_string());
[INFO] [stdout]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction[..instruction.len() - 1]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]    --> src/parser.rs:104:16
[INFO] [stdout]     |
[INFO] [stdout] 104 |             if instr.oper1 == None {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `instr.oper1.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout]     = note: `#[warn(clippy::partialeq_to_none)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]    --> src/parser.rs:113:16
[INFO] [stdout]     |
[INFO] [stdout] 113 |             if instr.oper1 == None {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `instr.oper1.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow
[INFO] [stdout]    --> src/parser.rs:132:23
[INFO] [stdout]     |
[INFO] [stdout] 132 |             arg.reg = (&token[lbracket_idx + 1..tok_len - 1]).to_string();
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `token[lbracket_idx + 1..tok_len - 1]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]    --> src/parser.rs:145:16
[INFO] [stdout]     |
[INFO] [stdout] 145 |             if instr.oper1 == None {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `instr.oper1.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]    --> src/parser.rs:152:16
[INFO] [stdout]     |
[INFO] [stdout] 152 |             if instr.oper1 == None {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `instr.oper1.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]    --> src/parser.rs:161:8
[INFO] [stdout]     |
[INFO] [stdout] 161 |     if instr.oper1 != None && instr.oper0 == None {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `instr.oper1.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]    --> src/parser.rs:161:31
[INFO] [stdout]     |
[INFO] [stdout] 161 |     if instr.oper1 != None && instr.oper0 == None {
[INFO] [stdout]     |                               ^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `instr.oper0.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/parser.rs:173:9
[INFO] [stdout]     |
[INFO] [stdout] 173 | /         match instr {
[INFO] [stdout] 174 | |             Some(i) => ret.push(i),
[INFO] [stdout] 175 | |             _ => {},
[INFO] [stdout] 176 | |         };
[INFO] [stdout]     | |_________^ help: try: `if let Some(i) = instr { ret.push(i) }`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]     = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/codegen.rs:12:5
[INFO] [stdout]    |
[INFO] [stdout] 12 |     return false;
[INFO] [stdout]    |     ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 12 -     return false;
[INFO] [stdout] 12 +     false
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]  --> src/codegen.rs:8:24
[INFO] [stdout]   |
[INFO] [stdout] 8 |             Some(l) => if l == label {return true},
[INFO] [stdout]   |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout]   = note: `#[warn(clippy::collapsible_match)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]   |
[INFO] [stdout] 8 -             Some(l) => if l == label {return true},
[INFO] [stdout] 8 +             Some(l)f l == label => {return true,
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]   --> src/codegen.rs:7:9
[INFO] [stdout]    |
[INFO] [stdout]  7 | /         match &instr.label {
[INFO] [stdout]  8 | |             Some(l) => if l == label {return true},
[INFO] [stdout]  9 | |             _ => {},
[INFO] [stdout] 10 | |         };
[INFO] [stdout]    | |_________^ help: try: `if let Some(l) = &instr.label { if l == label {return true} }`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]    --> src/codegen.rs:138:8
[INFO] [stdout]     |
[INFO] [stdout] 138 |     if instr.label != None {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `instr.label.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
[INFO] [stdout]    --> src/codegen.rs:170:39
[INFO] [stdout]     |
[INFO] [stdout] 170 |     for (i, instruction) in (&parsed).into_iter().enumerate() {
[INFO] [stdout]     |                                       ^^^^^^^^^ help: call directly: `iter`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stdout]     = note: `#[warn(clippy::into_iter_on_ref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `impl` can be derived
[INFO] [stdout]   --> src/parser.rs:27:1
[INFO] [stdout]    |
[INFO] [stdout] 27 | / impl Default for AddrOffset {
[INFO] [stdout] 28 | |     fn default() -> Self {
[INFO] [stdout] 29 | |         AddrOffset::Dflt
[INFO] [stdout] 30 | |     }
[INFO] [stdout] 31 | | }
[INFO] [stdout]    | |_^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
[INFO] [stdout]    = note: `#[warn(clippy::derivable_impls)]` on by default
[INFO] [stdout] help: replace the manual implementation with a derive attribute and mark the default variant
[INFO] [stdout]    |
[INFO] [stdout] 20 + #[derive(Default)]
[INFO] [stdout] 21 | pub enum AddrOffset {
[INFO] [stdout] 22 |     Register(String),
[INFO] [stdout] 23 |     Number(isize),
[INFO] [stdout] 24 |     Label(String),
[INFO] [stdout] 25 ~     #[default]
[INFO] [stdout] 26 ~     Dflt // default
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/parser.rs:140:20
[INFO] [stdout]     |
[INFO] [stdout] 140 |                 if !n.is_ok() {
[INFO] [stdout]     |                    ^^^^^^^^^^ help: try: `n.is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `n` after checking its variant with `is_ok`
[INFO] [stdout]    --> src/parser.rs:105:55
[INFO] [stdout]     |
[INFO] [stdout] 103 |         if n.is_ok() {
[INFO] [stdout]     |         ------------ help: try: `if let Ok(<item>) = n`
[INFO] [stdout] 104 |             if instr.oper1 == None {
[INFO] [stdout] 105 |                 instr.oper1 = Some(Operand::Immediate(n.unwrap()));
[INFO] [stdout]     |                                                       ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `n` after checking its variant with `is_ok`
[INFO] [stdout]    --> src/parser.rs:107:55
[INFO] [stdout]     |
[INFO] [stdout] 103 |         if n.is_ok() {
[INFO] [stdout]     |         ------------ help: try: `if let Ok(<item>) = n`
[INFO] [stdout] ...
[INFO] [stdout] 107 |                 instr.oper0 = Some(Operand::Immediate(n.unwrap()));
[INFO] [stdout]     |                                                       ^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/parser.rs:165:5
[INFO] [stdout]     |
[INFO] [stdout] 165 |     return Some(instr);
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 165 -     return Some(instr);
[INFO] [stdout] 165 +     Some(instr)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/parser.rs:75:8
[INFO] [stdout]    |
[INFO] [stdout] 75 |     if instruction.len() == 0 {return None}
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `instruction.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should use the `ends_with` method
[INFO] [stdout]   --> src/parser.rs:77:8
[INFO] [stdout]    |
[INFO] [stdout] 77 |     if instruction.chars().last() == Some(':') {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `instruction.ends_with(':')`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp
[INFO] [stdout]    = note: `#[warn(clippy::chars_last_cmp)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow
[INFO] [stdout]   --> src/parser.rs:78:28
[INFO] [stdout]    |
[INFO] [stdout] 78 |         instr.label = Some((&instruction[..instruction.len() - 1]).to_string());
[INFO] [stdout]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `instruction[..instruction.len() - 1]`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]    --> src/parser.rs:104:16
[INFO] [stdout]     |
[INFO] [stdout] 104 |             if instr.oper1 == None {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `instr.oper1.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout]     = note: `#[warn(clippy::partialeq_to_none)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]    --> src/parser.rs:113:16
[INFO] [stdout]     |
[INFO] [stdout] 113 |             if instr.oper1 == None {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `instr.oper1.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow
[INFO] [stdout]    --> src/parser.rs:132:23
[INFO] [stdout]     |
[INFO] [stdout] 132 |             arg.reg = (&token[lbracket_idx + 1..tok_len - 1]).to_string();
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `token[lbracket_idx + 1..tok_len - 1]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]    --> src/parser.rs:145:16
[INFO] [stdout]     |
[INFO] [stdout] 145 |             if instr.oper1 == None {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `instr.oper1.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]    --> src/parser.rs:152:16
[INFO] [stdout]     |
[INFO] [stdout] 152 |             if instr.oper1 == None {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `instr.oper1.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]    --> src/parser.rs:161:8
[INFO] [stdout]     |
[INFO] [stdout] 161 |     if instr.oper1 != None && instr.oper0 == None {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `instr.oper1.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]    --> src/parser.rs:161:31
[INFO] [stdout]     |
[INFO] [stdout] 161 |     if instr.oper1 != None && instr.oper0 == None {
[INFO] [stdout]     |                               ^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `instr.oper0.is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/parser.rs:173:9
[INFO] [stdout]     |
[INFO] [stdout] 173 | /         match instr {
[INFO] [stdout] 174 | |             Some(i) => ret.push(i),
[INFO] [stdout] 175 | |             _ => {},
[INFO] [stdout] 176 | |         };
[INFO] [stdout]     | |_________^ help: try: `if let Some(i) = instr { ret.push(i) }`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]     = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/codegen.rs:12:5
[INFO] [stdout]    |
[INFO] [stdout] 12 |     return false;
[INFO] [stdout]    |     ^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 12 -     return false;
[INFO] [stdout] 12 +     false
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` can be collapsed into the outer `match`
[INFO] [stdout]  --> src/codegen.rs:8:24
[INFO] [stdout]   |
[INFO] [stdout] 8 |             Some(l) => if l == label {return true},
[INFO] [stdout]   |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match
[INFO] [stdout]   = note: `#[warn(clippy::collapsible_match)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]   |
[INFO] [stdout] 8 -             Some(l) => if l == label {return true},
[INFO] [stdout] 8 +             Some(l)f l == label => {return true,
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]   --> src/codegen.rs:7:9
[INFO] [stdout]    |
[INFO] [stdout]  7 | /         match &instr.label {
[INFO] [stdout]  8 | |             Some(l) => if l == label {return true},
[INFO] [stdout]  9 | |             _ => {},
[INFO] [stdout] 10 | |         };
[INFO] [stdout]    | |_________^ help: try: `if let Some(l) = &instr.label { if l == label {return true} }`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]    --> src/codegen.rs:138:8
[INFO] [stdout]     |
[INFO] [stdout] 138 |     if instr.label != None {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `instr.label.is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
[INFO] [stdout]    --> src/codegen.rs:170:39
[INFO] [stdout]     |
[INFO] [stdout] 170 |     for (i, instruction) in (&parsed).into_iter().enumerate() {
[INFO] [stdout]     |                                       ^^^^^^^^^ help: call directly: `iter`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stdout]     = note: `#[warn(clippy::into_iter_on_ref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.39s
[INFO] running `Command { std: "docker" "inspect" "8eb6f4e5d01fb2ab9a30a58cc0253257a35dd568cefd5113aa2b9a675408f2fa", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "8eb6f4e5d01fb2ab9a30a58cc0253257a35dd568cefd5113aa2b9a675408f2fa", kill_on_drop: false }`
[INFO] [stdout] 8eb6f4e5d01fb2ab9a30a58cc0253257a35dd568cefd5113aa2b9a675408f2fa