[INFO] cloning repository https://github.com/UnePatate5010/Rust-Daily-Programmer [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/UnePatate5010/Rust-Daily-Programmer" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FUnePatate5010%2FRust-Daily-Programmer", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FUnePatate5010%2FRust-Daily-Programmer'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0219124bfffba6619539a1db4ef68fe94af5a0e4 [INFO] linting UnePatate5010/Rust-Daily-Programmer against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FUnePatate5010%2FRust-Daily-Programmer" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/UnePatate5010/Rust-Daily-Programmer [INFO] finished tweaking git repo https://github.com/UnePatate5010/Rust-Daily-Programmer [INFO] tweaked toml for git repo https://github.com/UnePatate5010/Rust-Daily-Programmer written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/UnePatate5010/Rust-Daily-Programmer on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/UnePatate5010/Rust-Daily-Programmer already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2dfc566fb08cbeffec18c8aa0bb4c000689da313591ff0cf7b8914c98cf92dc4 [INFO] running `Command { std: "docker" "start" "-a" "2dfc566fb08cbeffec18c8aa0bb4c000689da313591ff0cf7b8914c98cf92dc4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2dfc566fb08cbeffec18c8aa0bb4c000689da313591ff0cf7b8914c98cf92dc4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2dfc566fb08cbeffec18c8aa0bb4c000689da313591ff0cf7b8914c98cf92dc4", kill_on_drop: false }` [INFO] [stdout] 2dfc566fb08cbeffec18c8aa0bb4c000689da313591ff0cf7b8914c98cf92dc4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 82c6e00b6dff381233978317dd00646c19c8edaaaf6a53a8b7d69b3941ad2ee5 [INFO] running `Command { std: "docker" "start" "-a" "82c6e00b6dff381233978317dd00646c19c8edaaaf6a53a8b7d69b3941ad2ee5", kill_on_drop: false }` [INFO] [stderr] Checking dailyprogrammer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/t_roman_numeral_comparison.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | assert_eq!(roman_numeral_comparison::numcompare("XVI", "VIII"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5 - assert_eq!(roman_numeral_comparison::numcompare("XVI", "VIII"), false); [INFO] [stdout] 5 + assert!(!roman_numeral_comparison::numcompare("XVI", "VIII")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/t_roman_numeral_comparison.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | assert_eq!(roman_numeral_comparison::numcompare("V", "IIIII"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6 - assert_eq!(roman_numeral_comparison::numcompare("V", "IIIII"), false); [INFO] [stdout] 6 + assert!(!roman_numeral_comparison::numcompare("V", "IIIII")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/t_roman_numeral_comparison.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | assert_eq!(roman_numeral_comparison::numcompare("CCLXV", "MMDII"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 7 - assert_eq!(roman_numeral_comparison::numcompare("CCLXV", "MMDII"), true); [INFO] [stdout] 7 + assert!(roman_numeral_comparison::numcompare("CCLXV", "MMDII")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/t_reverse_factorial.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | assert_eq!(reverse_factorial::reverse_factorial(150), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5 - assert_eq!(reverse_factorial::reverse_factorial(150), false); [INFO] [stdout] 5 + assert!(!reverse_factorial::reverse_factorial(150)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/t_reverse_factorial.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | assert_eq!(reverse_factorial::reverse_factorial(120), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6 - assert_eq!(reverse_factorial::reverse_factorial(120), true); [INFO] [stdout] 6 + assert!(reverse_factorial::reverse_factorial(120)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/t_iec_rule.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | assert_eq!(iec_rule::iec_rule("a"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5 - assert_eq!(iec_rule::iec_rule("a"), true); [INFO] [stdout] 5 + assert!(iec_rule::iec_rule("a")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/t_iec_rule.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | assert_eq!(iec_rule::iec_rule("zombie"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6 - assert_eq!(iec_rule::iec_rule("zombie"), true); [INFO] [stdout] 6 + assert!(iec_rule::iec_rule("zombie")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/t_iec_rule.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | assert_eq!(iec_rule::iec_rule("transceiver"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 7 - assert_eq!(iec_rule::iec_rule("transceiver"), true); [INFO] [stdout] 7 + assert!(iec_rule::iec_rule("transceiver")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/t_iec_rule.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | assert_eq!(iec_rule::iec_rule("veil"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 8 - assert_eq!(iec_rule::iec_rule("veil"), false); [INFO] [stdout] 8 + assert!(!iec_rule::iec_rule("veil")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/t_iec_rule.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | assert_eq!(iec_rule::iec_rule("icier"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 9 - assert_eq!(iec_rule::iec_rule("icier"), false); [INFO] [stdout] 9 + assert!(!iec_rule::iec_rule("icier")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/roman_numeral_comparison.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return sum; [INFO] [stdout] 17 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/caesar_cypher.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | return new_letter; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return new_letter; [INFO] [stdout] 14 + new_letter [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/exercises/caesar_cypher.rs:10:21 [INFO] [stdout] | [INFO] [stdout] 10 | if new_number > 'z' as u8 { [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'z'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/t_roman_numeral_comparison.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | assert_eq!(roman_numeral_comparison::numcompare("XVI", "VIII"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5 - assert_eq!(roman_numeral_comparison::numcompare("XVI", "VIII"), false); [INFO] [stdout] 5 + assert!(!roman_numeral_comparison::numcompare("XVI", "VIII")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/caesar_cypher.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return code_sentence; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return code_sentence; [INFO] [stdout] 23 + code_sentence [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/t_roman_numeral_comparison.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | assert_eq!(roman_numeral_comparison::numcompare("V", "IIIII"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6 - assert_eq!(roman_numeral_comparison::numcompare("V", "IIIII"), false); [INFO] [stdout] 6 + assert!(!roman_numeral_comparison::numcompare("V", "IIIII")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/caesar_cypher.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | return caesar_cypher(sentence, shifting); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return caesar_cypher(sentence, shifting); [INFO] [stdout] 27 + caesar_cypher(sentence, shifting) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/t_roman_numeral_comparison.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | assert_eq!(roman_numeral_comparison::numcompare("CCLXV", "MMDII"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 7 - assert_eq!(roman_numeral_comparison::numcompare("CCLXV", "MMDII"), true); [INFO] [stdout] 7 + assert!(roman_numeral_comparison::numcompare("CCLXV", "MMDII")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/t_reverse_factorial.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | assert_eq!(reverse_factorial::reverse_factorial(150), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5 - assert_eq!(reverse_factorial::reverse_factorial(150), false); [INFO] [stdout] 5 + assert!(!reverse_factorial::reverse_factorial(150)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/reverse_factorial.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return true; [INFO] [stdout] 11 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/reverse_factorial.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return false; [INFO] [stdout] 14 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/exercises/reverse_factorial.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 6 | while n_x % i == 0 { [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `n_x.is_multiple_of(i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/exercises/reverse_factorial.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | n_x = n_x / i; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `n_x /= i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/t_reverse_factorial.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | assert_eq!(reverse_factorial::reverse_factorial(120), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6 - assert_eq!(reverse_factorial::reverse_factorial(120), true); [INFO] [stdout] 6 + assert!(reverse_factorial::reverse_factorial(120)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/exercises/reverse_factorial.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | / if n_x == 1 { [INFO] [stdout] 11 | | return true; [INFO] [stdout] 12 | | } [INFO] [stdout] 13 | | else { [INFO] [stdout] 14 | | return false; [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____^ help: you can reduce it to: `return n_x == 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/next_palindrome.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return true; [INFO] [stdout] 10 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/next_palindrome.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return n_x; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return n_x; [INFO] [stdout] 18 + n_x [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/fibonacci_ish_sequence.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 5 - return 0; [INFO] [stdout] 5 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/fibonacci_ish_sequence.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | return start; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 - return start; [INFO] [stdout] 7 + start [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/fibonacci_ish_sequence.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | return fibo(x - 1, start) + fibo(x - 2, start); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 - return fibo(x - 1, start) + fibo(x - 2, start); [INFO] [stdout] 9 + fibo(x - 1, start) + fibo(x - 2, start) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/fibonacci_ish_sequence.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | return target / div; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return target / div; [INFO] [stdout] 40 + target / div [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/exercises/fibonacci_ish_sequence.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 34 | if target % f == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace with: `target.is_multiple_of(f)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/letter_sum_value.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | return (letter as u32) - ('a' as u32) + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 5 - return (letter as u32) - ('a' as u32) + 1; [INFO] [stdout] 5 + (letter as u32) - ('a' as u32) + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/letter_sum_value.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return sum; [INFO] [stdout] 13 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/pancake_sort.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | return a [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return a [INFO] [stdout] 11 + a [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/exercises/pancake_sort.rs:3:27 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn pancake_sort(arr : &Vec, n: usize) -> Vec { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - pub fn pancake_sort(arr : &Vec, n: usize) -> Vec { [INFO] [stdout] 3 + pub fn pancake_sort(arr : &[i32], n: usize) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `arr` [INFO] [stdout] --> src/exercises/pancake_sort.rs:8:14 [INFO] [stdout] | [INFO] [stdout] 8 | for i in n..arr.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 8 - for i in n..arr.len() { [INFO] [stdout] 8 + for in arr.iter().skip(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/abacaba_sequence.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | return word; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return word; [INFO] [stdout] 10 + word [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/yahtzee_scoring.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return bsf; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return bsf; [INFO] [stdout] 17 + bsf [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/yahtzee_scoring.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | return bsf; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return bsf; [INFO] [stdout] 38 + bsf [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/progressive_taxation.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return t as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return t as u32; [INFO] [stdout] 16 + t as u32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/exercises/julian_calendar.rs:6:27 [INFO] [stdout] | [INFO] [stdout] 6 | if i % 4 == 0 && (!(i % 100 == 0) || (i % 900 == 200) || (i % 900 == 600)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(i % 100 != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/julian_calendar.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | return count; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return count; [INFO] [stdout] 10 + count [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/word_ladder.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return nb_char - count - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return nb_char - count - 1; [INFO] [stdout] 18 + nb_char - count - 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/word_ladder.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return sum; [INFO] [stdout] 29 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/exercises/word_ladder.rs:21:29 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn total_spacing(words: &Vec<&str>) -> i32 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 21 - pub fn total_spacing(words: &Vec<&str>) -> i32 { [INFO] [stdout] 21 + pub fn total_spacing(words: &[&str]) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/exercises/word_ladder.rs:32:29 [INFO] [stdout] | [INFO] [stdout] 32 | fn power_set(vec: &Vec) -> Vec> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 - fn power_set(vec: &Vec) -> Vec> { [INFO] [stdout] 32 + fn power_set(vec: &[T]) -> Vec> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `vec` [INFO] [stdout] --> src/exercises/word_ladder.rs:39:18 [INFO] [stdout] | [INFO] [stdout] 39 | for j in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 39 - for j in 0..n { [INFO] [stdout] 39 + for (j, ) in vec.iter().enumerate().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/word_ladder.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | return (bsf_vec, bsf_spacing); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - return (bsf_vec, bsf_spacing); [INFO] [stdout] 61 + (bsf_vec, bsf_spacing) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/exercises/word_ladder.rs:54:29 [INFO] [stdout] | [INFO] [stdout] 54 | for subset in power_set(&words) { [INFO] [stdout] | ^^^^^^ help: change this to: `words` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/exercises/iec_rule.rs:6:57 [INFO] [stdout] | [INFO] [stdout] 6 | if w[i] == 'e' && w[i + 1] == 'i' && (i == 0 || !(w[i - 1] == 'c')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(w[i - 1] != 'c')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/iec_rule.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return true; [INFO] [stdout] 13 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/t_iec_rule.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | assert_eq!(iec_rule::iec_rule("a"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 5 - assert_eq!(iec_rule::iec_rule("a"), true); [INFO] [stdout] 5 + assert!(iec_rule::iec_rule("a")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/t_iec_rule.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | assert_eq!(iec_rule::iec_rule("zombie"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 6 - assert_eq!(iec_rule::iec_rule("zombie"), true); [INFO] [stdout] 6 + assert!(iec_rule::iec_rule("zombie")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/t_iec_rule.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | assert_eq!(iec_rule::iec_rule("transceiver"), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 7 - assert_eq!(iec_rule::iec_rule("transceiver"), true); [INFO] [stdout] 7 + assert!(iec_rule::iec_rule("transceiver")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/t_iec_rule.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | assert_eq!(iec_rule::iec_rule("veil"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 8 - assert_eq!(iec_rule::iec_rule("veil"), false); [INFO] [stdout] 8 + assert!(!iec_rule::iec_rule("veil")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/tests/t_iec_rule.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | assert_eq!(iec_rule::iec_rule("icier"), false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 9 - assert_eq!(iec_rule::iec_rule("icier"), false); [INFO] [stdout] 9 + assert!(!iec_rule::iec_rule("icier")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/roman_numeral_comparison.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return sum; [INFO] [stdout] 17 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/caesar_cypher.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | return new_letter; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return new_letter; [INFO] [stdout] 14 + new_letter [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/exercises/caesar_cypher.rs:10:21 [INFO] [stdout] | [INFO] [stdout] 10 | if new_number > 'z' as u8 { [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'z'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/caesar_cypher.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | return code_sentence; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 23 - return code_sentence; [INFO] [stdout] 23 + code_sentence [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/caesar_cypher.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | return caesar_cypher(sentence, shifting); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return caesar_cypher(sentence, shifting); [INFO] [stdout] 27 + caesar_cypher(sentence, shifting) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/reverse_factorial.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return true; [INFO] [stdout] 11 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/reverse_factorial.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 - return false; [INFO] [stdout] 14 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/exercises/reverse_factorial.rs:6:11 [INFO] [stdout] | [INFO] [stdout] 6 | while n_x % i == 0 { [INFO] [stdout] | ^^^^^^^^^^^^ help: replace with: `n_x.is_multiple_of(i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/exercises/reverse_factorial.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | n_x = n_x / i; [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace it with: `n_x /= i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/exercises/reverse_factorial.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | / if n_x == 1 { [INFO] [stdout] 11 | | return true; [INFO] [stdout] 12 | | } [INFO] [stdout] 13 | | else { [INFO] [stdout] 14 | | return false; [INFO] [stdout] 15 | | } [INFO] [stdout] | |_____^ help: you can reduce it to: `return n_x == 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/next_palindrome.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return true; [INFO] [stdout] 10 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/next_palindrome.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return n_x; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return n_x; [INFO] [stdout] 18 + n_x [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/fibonacci_ish_sequence.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 5 - return 0; [INFO] [stdout] 5 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/fibonacci_ish_sequence.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | return start; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 7 - return start; [INFO] [stdout] 7 + start [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/fibonacci_ish_sequence.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | return fibo(x - 1, start) + fibo(x - 2, start); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 - return fibo(x - 1, start) + fibo(x - 2, start); [INFO] [stdout] 9 + fibo(x - 1, start) + fibo(x - 2, start) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/fibonacci_ish_sequence.rs:40:5 [INFO] [stdout] | [INFO] [stdout] 40 | return target / div; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - return target / div; [INFO] [stdout] 40 + target / div [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/exercises/fibonacci_ish_sequence.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 34 | if target % f == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: replace with: `target.is_multiple_of(f)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/letter_sum_value.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | return (letter as u32) - ('a' as u32) + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 5 - return (letter as u32) - ('a' as u32) + 1; [INFO] [stdout] 5 + (letter as u32) - ('a' as u32) + 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/letter_sum_value.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return sum; [INFO] [stdout] 13 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/pancake_sort.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | return a [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 11 - return a [INFO] [stdout] 11 + a [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/exercises/pancake_sort.rs:3:27 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn pancake_sort(arr : &Vec, n: usize) -> Vec { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - pub fn pancake_sort(arr : &Vec, n: usize) -> Vec { [INFO] [stdout] 3 + pub fn pancake_sort(arr : &[i32], n: usize) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `arr` [INFO] [stdout] --> src/exercises/pancake_sort.rs:8:14 [INFO] [stdout] | [INFO] [stdout] 8 | for i in n..arr.len() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 8 - for i in n..arr.len() { [INFO] [stdout] 8 + for in arr.iter().skip(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/abacaba_sequence.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | return word; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return word; [INFO] [stdout] 10 + word [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/yahtzee_scoring.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | return bsf; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - return bsf; [INFO] [stdout] 17 + bsf [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/yahtzee_scoring.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | return bsf; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 - return bsf; [INFO] [stdout] 38 + bsf [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/progressive_taxation.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | return t as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return t as u32; [INFO] [stdout] 16 + t as u32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/exercises/julian_calendar.rs:6:27 [INFO] [stdout] | [INFO] [stdout] 6 | if i % 4 == 0 && (!(i % 100 == 0) || (i % 900 == 200) || (i % 900 == 600)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `(i % 100 != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/julian_calendar.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | return count; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return count; [INFO] [stdout] 10 + count [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/word_ladder.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return nb_char - count - 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return nb_char - count - 1; [INFO] [stdout] 18 + nb_char - count - 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/word_ladder.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return sum; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return sum; [INFO] [stdout] 29 + sum [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/exercises/word_ladder.rs:21:29 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn total_spacing(words: &Vec<&str>) -> i32 { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 21 - pub fn total_spacing(words: &Vec<&str>) -> i32 { [INFO] [stdout] 21 + pub fn total_spacing(words: &[&str]) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/exercises/word_ladder.rs:32:29 [INFO] [stdout] | [INFO] [stdout] 32 | fn power_set(vec: &Vec) -> Vec> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 - fn power_set(vec: &Vec) -> Vec> { [INFO] [stdout] 32 + fn power_set(vec: &[T]) -> Vec> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `vec` [INFO] [stdout] --> src/exercises/word_ladder.rs:39:18 [INFO] [stdout] | [INFO] [stdout] 39 | for j in 0..n { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 39 - for j in 0..n { [INFO] [stdout] 39 + for (j, ) in vec.iter().enumerate().take(n) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/word_ladder.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | return (bsf_vec, bsf_spacing); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - return (bsf_vec, bsf_spacing); [INFO] [stdout] 61 + (bsf_vec, bsf_spacing) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/exercises/word_ladder.rs:54:29 [INFO] [stdout] | [INFO] [stdout] 54 | for subset in power_set(&words) { [INFO] [stdout] | ^^^^^^ help: change this to: `words` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/exercises/iec_rule.rs:6:57 [INFO] [stdout] | [INFO] [stdout] 6 | if w[i] == 'e' && w[i + 1] == 'i' && (i == 0 || !(w[i - 1] == 'c')) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(w[i - 1] != 'c')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/exercises/iec_rule.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return true; [INFO] [stdout] 13 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.32s [INFO] running `Command { std: "docker" "inspect" "82c6e00b6dff381233978317dd00646c19c8edaaaf6a53a8b7d69b3941ad2ee5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "82c6e00b6dff381233978317dd00646c19c8edaaaf6a53a8b7d69b3941ad2ee5", kill_on_drop: false }` [INFO] [stdout] 82c6e00b6dff381233978317dd00646c19c8edaaaf6a53a8b7d69b3941ad2ee5