[INFO] cloning repository https://github.com/TunaMaestro/aoc-utils [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TunaMaestro/aoc-utils" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTunaMaestro%2Faoc-utils", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTunaMaestro%2Faoc-utils'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 94b7fe99f95ef0d112265eab256db6ebbecf1acf [INFO] linting TunaMaestro/aoc-utils against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTunaMaestro%2Faoc-utils" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/TunaMaestro/aoc-utils [INFO] finished tweaking git repo https://github.com/TunaMaestro/aoc-utils [INFO] tweaked toml for git repo https://github.com/TunaMaestro/aoc-utils written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/TunaMaestro/aoc-utils on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/TunaMaestro/aoc-utils already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded lina v0.2.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b7d919f3e440ed6a5157020b1780f99e04e99e2b165abb0f4089d58b7b00a791 [INFO] running `Command { std: "docker" "start" "-a" "b7d919f3e440ed6a5157020b1780f99e04e99e2b165abb0f4089d58b7b00a791", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b7d919f3e440ed6a5157020b1780f99e04e99e2b165abb0f4089d58b7b00a791", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b7d919f3e440ed6a5157020b1780f99e04e99e2b165abb0f4089d58b7b00a791", kill_on_drop: false }` [INFO] [stdout] b7d919f3e440ed6a5157020b1780f99e04e99e2b165abb0f4089d58b7b00a791 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ba975d99831dd88ec97ff8bc1e045abcac4c551c2c16a74170efc47776b0a71c [INFO] running `Command { std: "docker" "start" "-a" "ba975d99831dd88ec97ff8bc1e045abcac4c551c2c16a74170efc47776b0a71c", kill_on_drop: false }` [INFO] [stderr] Checking bytemuck v1.21.0 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking atoi v2.0.0 [INFO] [stderr] Checking lina v0.2.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking aoc-utils v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/bucket.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | inner: inner, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/bucket.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | inner: inner, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/bucket.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 30 | / let new = BucketQueue { [INFO] [stdout] 31 | | inner: inner, [INFO] [stdout] 32 | | priorities: init, [INFO] [stdout] 33 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 34 | [INFO] [stdout] 35 | new [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 30 ~ [INFO] [stdout] 31 | [INFO] [stdout] 32 ~ BucketQueue { [INFO] [stdout] 33 + inner: inner, [INFO] [stdout] 34 + priorities: init, [INFO] [stdout] 35 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/debug.rs:8:33 [INFO] [stdout] | [INFO] [stdout] 8 | String::from_utf8_lossy(&self).to_string() [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/grid/sparse.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | &self.inner.get(&index).unwrap_or(&self.default) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.inner.get(&index).unwrap_or(&self.default)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | return y * self.width + x; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return y * self.width + x; [INFO] [stdout] 19 + y * self.width + x [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/grid.rs:130:14 [INFO] [stdout] | [INFO] [stdout] 130 | .map(|ln| ln.chars().into_iter().map(cell)) [INFO] [stdout] | ______________^ [INFO] [stdout] 131 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|ln| ln.chars().into_iter().map(cell))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>` [INFO] [stdout] --> src/grid.rs:130:23 [INFO] [stdout] | [INFO] [stdout] 130 | .map(|ln| ln.chars().into_iter().map(cell)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `ln.chars()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/grid.rs:137:16 [INFO] [stdout] | [INFO] [stdout] 137 | if line_lens.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!line_lens.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/grid.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | self.iter_coordinates().filter(|x| test(&self[*x])).next() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.iter_coordinates().find(|x| test(&self[*x]))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] = note: `#[warn(clippy::filter_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/grid.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 169 | if self.inner.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.inner.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | / return Grid { [INFO] [stdout] 178 | | inner: self.inner.iter().map(|x| f(x)).collect(), [INFO] [stdout] 179 | | width: self.width, [INFO] [stdout] 180 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 177 ~ Grid { [INFO] [stdout] 178 + inner: self.inner.iter().map(|x| f(x)).collect(), [INFO] [stdout] 179 + width: self.width, [INFO] [stdout] 180 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/grid.rs:178:42 [INFO] [stdout] | [INFO] [stdout] 178 | inner: self.inner.iter().map(|x| f(x)).collect(), [INFO] [stdout] | ^^^^^^^^ help: replace the closure with the function itself: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/grid.rs:306:8 [INFO] [stdout] | [INFO] [stdout] 306 | if !((x.abs() == 1) != (y.abs() == 1)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((x.abs() == 1) == (y.abs() == 1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/grid.rs:319:13 [INFO] [stdout] | [INFO] [stdout] 319 | assert!(0 <= i && i < 4); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `(0..4).contains(&i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/grid.rs:346:5 [INFO] [stdout] | [INFO] [stdout] 345 | let positive_positive_idx = offset + transformed_idx; [INFO] [stdout] | ----------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 346 | positive_positive_idx [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 345 ~ [INFO] [stdout] 346 ~ offset + transformed_idx [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `x.get(0)` [INFO] [stdout] --> src/parse.rs:7:21 [INFO] [stdout] | [INFO] [stdout] 7 | .filter(|x| x.get(0).map(|&x| numerical(x)).unwrap_or(false)) [INFO] [stdout] | ^^^^^^^^ help: try: `x.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/union_find.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | return self.inner[x].parent; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return self.inner[x].parent; [INFO] [stdout] 37 + self.inner[x].parent [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/bucket.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 30 | / let new = BucketQueue { [INFO] [stdout] 31 | | inner: inner, [INFO] [stdout] 32 | | priorities: init, [INFO] [stdout] 33 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 34 | [INFO] [stdout] 35 | new [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 30 ~ [INFO] [stdout] 31 | [INFO] [stdout] 32 ~ BucketQueue { [INFO] [stdout] 33 + inner: inner, [INFO] [stdout] 34 + priorities: init, [INFO] [stdout] 35 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/debug.rs:8:33 [INFO] [stdout] | [INFO] [stdout] 8 | String::from_utf8_lossy(&self).to_string() [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/grid/sparse.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | &self.inner.get(&index).unwrap_or(&self.default) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.inner.get(&index).unwrap_or(&self.default)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | return y * self.width + x; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return y * self.width + x; [INFO] [stdout] 19 + y * self.width + x [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/grid.rs:130:14 [INFO] [stdout] | [INFO] [stdout] 130 | .map(|ln| ln.chars().into_iter().map(cell)) [INFO] [stdout] | ______________^ [INFO] [stdout] 131 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `flat_map` and remove the `.flatten()`: `flat_map(|ln| ln.chars().into_iter().map(cell))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::Chars<'_>` [INFO] [stdout] --> src/grid.rs:130:23 [INFO] [stdout] | [INFO] [stdout] 130 | .map(|ln| ln.chars().into_iter().map(cell)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `ln.chars()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/grid.rs:137:16 [INFO] [stdout] | [INFO] [stdout] 137 | if line_lens.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!line_lens.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/grid.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | self.iter_coordinates().filter(|x| test(&self[*x])).next() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.iter_coordinates().find(|x| test(&self[*x]))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] = note: `#[warn(clippy::filter_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/grid.rs:169:12 [INFO] [stdout] | [INFO] [stdout] 169 | if self.inner.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.inner.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/grid.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 177 | / return Grid { [INFO] [stdout] 178 | | inner: self.inner.iter().map(|x| f(x)).collect(), [INFO] [stdout] 179 | | width: self.width, [INFO] [stdout] 180 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 177 ~ Grid { [INFO] [stdout] 178 + inner: self.inner.iter().map(|x| f(x)).collect(), [INFO] [stdout] 179 + width: self.width, [INFO] [stdout] 180 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/grid.rs:178:42 [INFO] [stdout] | [INFO] [stdout] 178 | inner: self.inner.iter().map(|x| f(x)).collect(), [INFO] [stdout] | ^^^^^^^^ help: replace the closure with the function itself: `f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/grid.rs:306:8 [INFO] [stdout] | [INFO] [stdout] 306 | if !((x.abs() == 1) != (y.abs() == 1)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((x.abs() == 1) == (y.abs() == 1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `Range::contains` implementation [INFO] [stdout] --> src/grid.rs:319:13 [INFO] [stdout] | [INFO] [stdout] 319 | assert!(0 <= i && i < 4); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use: `(0..4).contains(&i)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/grid.rs:346:5 [INFO] [stdout] | [INFO] [stdout] 345 | let positive_positive_idx = offset + transformed_idx; [INFO] [stdout] | ----------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 346 | positive_positive_idx [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 345 ~ [INFO] [stdout] 346 ~ offset + transformed_idx [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/grid.rs:517:13 [INFO] [stdout] | [INFO] [stdout] 517 | / &"\ [INFO] [stdout] 518 | | ........... [INFO] [stdout] 519 | | ...#...#... [INFO] [stdout] 520 | | ....#.#.... [INFO] [stdout] ... | [INFO] [stdout] 524 | | ........... [INFO] [stdout] 525 | | ", [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 517 ~ "\ [INFO] [stdout] 518 + ........... [INFO] [stdout] 519 + ...#...#... [INFO] [stdout] 520 + ....#.#.... [INFO] [stdout] 521 + .....#..... [INFO] [stdout] 522 + ....O...... [INFO] [stdout] 523 + ...O....... [INFO] [stdout] 524 + ........... [INFO] [stdout] 525 ~ ", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `x.get(0)` [INFO] [stdout] --> src/parse.rs:7:21 [INFO] [stdout] | [INFO] [stdout] 7 | .filter(|x| x.get(0).map(|&x| numerical(x)).unwrap_or(false)) [INFO] [stdout] | ^^^^^^^^ help: try: `x.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/parse.rs:35:43 [INFO] [stdout] | [INFO] [stdout] 35 | assert_eq!(nums_positive::(&s), [117440, 0, 0, 0, 3, 5, 4, 3, 0]) [INFO] [stdout] | ^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/union_find.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | return self.inner[x].parent; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 37 - return self.inner[x].parent; [INFO] [stdout] 37 + self.inner[x].parent [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.15s [INFO] running `Command { std: "docker" "inspect" "ba975d99831dd88ec97ff8bc1e045abcac4c551c2c16a74170efc47776b0a71c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ba975d99831dd88ec97ff8bc1e045abcac4c551c2c16a74170efc47776b0a71c", kill_on_drop: false }` [INFO] [stdout] ba975d99831dd88ec97ff8bc1e045abcac4c551c2c16a74170efc47776b0a71c