[INFO] cloning repository https://github.com/TrevorBrage/rift
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TrevorBrage/rift" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTrevorBrage%2Frift", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTrevorBrage%2Frift'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] e79a1b13a8a217f0ae7a0a6a4809948b605ccaa0
[INFO] linting TrevorBrage/rift against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTrevorBrage%2Frift" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/TrevorBrage/rift
[INFO] finished tweaking git repo https://github.com/TrevorBrage/rift
[INFO] tweaked toml for git repo https://github.com/TrevorBrage/rift written to /workspace/builds/worker-1-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/TrevorBrage/rift on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/TrevorBrage/rift already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] ed3907b66b03558863acaa06acdd3b97904e914f92d0dffa753494005817bf08
[INFO] running `Command { std: "docker" "start" "-a" "ed3907b66b03558863acaa06acdd3b97904e914f92d0dffa753494005817bf08", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "ed3907b66b03558863acaa06acdd3b97904e914f92d0dffa753494005817bf08", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "ed3907b66b03558863acaa06acdd3b97904e914f92d0dffa753494005817bf08", kill_on_drop: false }`
[INFO] [stdout] ed3907b66b03558863acaa06acdd3b97904e914f92d0dffa753494005817bf08
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 7ca3167d029292b5a0c33f586c463abb9b31d05bdde37df7124955c8975c18d0
[INFO] running `Command { std: "docker" "start" "-a" "7ca3167d029292b5a0c33f586c463abb9b31d05bdde37df7124955c8975c18d0", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.144
[INFO] [stderr]     Checking getrandom v0.2.9
[INFO] [stderr]     Checking rand_core v0.6.4
[INFO] [stderr]     Checking rand_chacha v0.3.1
[INFO] [stderr]     Checking rand v0.8.5
[INFO] [stderr]     Checking rift v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: fields `path`, `index`, and `data` are never read
[INFO] [stdout]   --> src/main.rs:32:5
[INFO] [stdout]    |
[INFO] [stdout] 31 | struct Packet {
[INFO] [stdout]    |        ------ fields in this struct
[INFO] [stdout] 32 |     path: String,
[INFO] [stdout]    |     ^^^^
[INFO] [stdout] 33 |     index: u32,
[INFO] [stdout]    |     ^^^^^
[INFO] [stdout] 34 |     data: Vec<u8>
[INFO] [stdout]    |     ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the variable `index` is used as a loop counter
[INFO] [stdout]   --> src/main.rs:42:5
[INFO] [stdout]    |
[INFO] [stdout] 42 |     for chunk in bytes.chunks(CHUNK_SIZE) {
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (index, chunk) in bytes.chunks(CHUNK_SIZE).enumerate()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stdout]    = note: `#[warn(clippy::explicit_counter_loop)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:68:24
[INFO] [stdout]    |
[INFO] [stdout] 68 |                     if !fs::metadata(&p).is_ok() { continue };
[INFO] [stdout]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&p).is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]   --> src/main.rs:58:5
[INFO] [stdout]    |
[INFO] [stdout] 58 | /     match args.get(1) {
[INFO] [stdout] 59 | |         Some(arg) => match arg.as_str() {
[INFO] [stdout] 60 | |             // Serve file to another client 
[INFO] [stdout] 61 | |             "serve" => {
[INFO] [stdout] ...  |
[INFO] [stdout] 98 | |         _ => {}
[INFO] [stdout] 99 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]    = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 58 ~     if let Some(arg) = args.get(1) { match arg.as_str() {
[INFO] [stdout] 59 +         // Serve file to another client 
[INFO] [stdout] 60 +         "serve" => {
[INFO] [stdout] 61 +             println!("Serving...");
[INFO] [stdout] 62 + 
[INFO] [stdout] 63 +             // Get dir / file paths
[INFO] [stdout] 64 +             let path = args.split_at(2).1;
[INFO] [stdout] 65 +             
[INFO] [stdout] 66 +             for p in path {
[INFO] [stdout] 67 +                 if !fs::metadata(&p).is_ok() { continue };
[INFO] [stdout] 68 +                 if fs::metadata(&p).unwrap().is_dir() {
[INFO] [stdout] 69 +                     let dir_contents = get_dir_contents(p);
[INFO] [stdout] 70 +                     //println!("{}", dir_contents.join("\n"));
[INFO] [stdout] 71 +                     for f in dir_contents {
[INFO] [stdout] 72 +                         for packet in create_packets(&f) {
[INFO] [stdout] 73 +                             packet_map.insert(gen_id(16), packet);
[INFO] [stdout] 74 +                         }
[INFO] [stdout] 75 +                     }
[INFO] [stdout] 76 +                 } else if fs::metadata(&p).unwrap().is_file() {
[INFO] [stdout] 77 +                     for packet in create_packets(p) {
[INFO] [stdout] 78 +                         packet_map.insert(gen_id(16), packet);
[INFO] [stdout] 79 +                     }
[INFO] [stdout] 80 +                 }
[INFO] [stdout] 81 +             }
[INFO] [stdout] 82 + 
[INFO] [stdout] 83 +             for packet in packet_map.iter() {
[INFO] [stdout] 84 +                 println!("{}", packet.0);
[INFO] [stdout] 85 +             }
[INFO] [stdout] 86 + 
[INFO] [stdout] 87 +             //fs::read()
[INFO] [stdout] 88 +         }
[INFO] [stdout] 89 +         // Listen for incoming packets
[INFO] [stdout] 90 +         "listen" => {
[INFO] [stdout] 91 +             println!("Listening...");
[INFO] [stdout] 92 +         }
[INFO] [stdout] 93 +         _ => {
[INFO] [stdout] 94 + 
[INFO] [stdout] 95 +         }
[INFO] [stdout] 96 +     } }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/main.rs:68:38
[INFO] [stdout]    |
[INFO] [stdout] 68 |                     if !fs::metadata(&p).is_ok() { continue };
[INFO] [stdout]    |                                      ^^ help: change this to: `p`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/main.rs:69:37
[INFO] [stdout]    |
[INFO] [stdout] 69 |                     if fs::metadata(&p).unwrap().is_dir() {
[INFO] [stdout]    |                                     ^^ help: change this to: `p`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/main.rs:77:44
[INFO] [stdout]    |
[INFO] [stdout] 77 |                     } else if fs::metadata(&p).unwrap().is_file() {
[INFO] [stdout]    |                                            ^^ help: change this to: `p`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: fields `path`, `index`, and `data` are never read
[INFO] [stdout]   --> src/main.rs:32:5
[INFO] [stdout]    |
[INFO] [stdout] 31 | struct Packet {
[INFO] [stdout]    |        ------ fields in this struct
[INFO] [stdout] 32 |     path: String,
[INFO] [stdout]    |     ^^^^
[INFO] [stdout] 33 |     index: u32,
[INFO] [stdout]    |     ^^^^^
[INFO] [stdout] 34 |     data: Vec<u8>
[INFO] [stdout]    |     ^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the variable `index` is used as a loop counter
[INFO] [stdout]   --> src/main.rs:42:5
[INFO] [stdout]    |
[INFO] [stdout] 42 |     for chunk in bytes.chunks(CHUNK_SIZE) {
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (index, chunk) in bytes.chunks(CHUNK_SIZE).enumerate()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stdout]    = note: `#[warn(clippy::explicit_counter_loop)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:68:24
[INFO] [stdout]    |
[INFO] [stdout] 68 |                     if !fs::metadata(&p).is_ok() { continue };
[INFO] [stdout]    |                        ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&p).is_err()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]   --> src/main.rs:58:5
[INFO] [stdout]    |
[INFO] [stdout] 58 | /     match args.get(1) {
[INFO] [stdout] 59 | |         Some(arg) => match arg.as_str() {
[INFO] [stdout] 60 | |             // Serve file to another client 
[INFO] [stdout] 61 | |             "serve" => {
[INFO] [stdout] ...  |
[INFO] [stdout] 98 | |         _ => {}
[INFO] [stdout] 99 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]    = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 58 ~     if let Some(arg) = args.get(1) { match arg.as_str() {
[INFO] [stdout] 59 +         // Serve file to another client 
[INFO] [stdout] 60 +         "serve" => {
[INFO] [stdout] 61 +             println!("Serving...");
[INFO] [stdout] 62 + 
[INFO] [stdout] 63 +             // Get dir / file paths
[INFO] [stdout] 64 +             let path = args.split_at(2).1;
[INFO] [stdout] 65 +             
[INFO] [stdout] 66 +             for p in path {
[INFO] [stdout] 67 +                 if !fs::metadata(&p).is_ok() { continue };
[INFO] [stdout] 68 +                 if fs::metadata(&p).unwrap().is_dir() {
[INFO] [stdout] 69 +                     let dir_contents = get_dir_contents(p);
[INFO] [stdout] 70 +                     //println!("{}", dir_contents.join("\n"));
[INFO] [stdout] 71 +                     for f in dir_contents {
[INFO] [stdout] 72 +                         for packet in create_packets(&f) {
[INFO] [stdout] 73 +                             packet_map.insert(gen_id(16), packet);
[INFO] [stdout] 74 +                         }
[INFO] [stdout] 75 +                     }
[INFO] [stdout] 76 +                 } else if fs::metadata(&p).unwrap().is_file() {
[INFO] [stdout] 77 +                     for packet in create_packets(p) {
[INFO] [stdout] 78 +                         packet_map.insert(gen_id(16), packet);
[INFO] [stdout] 79 +                     }
[INFO] [stdout] 80 +                 }
[INFO] [stdout] 81 +             }
[INFO] [stdout] 82 + 
[INFO] [stdout] 83 +             for packet in packet_map.iter() {
[INFO] [stdout] 84 +                 println!("{}", packet.0);
[INFO] [stdout] 85 +             }
[INFO] [stdout] 86 + 
[INFO] [stdout] 87 +             //fs::read()
[INFO] [stdout] 88 +         }
[INFO] [stdout] 89 +         // Listen for incoming packets
[INFO] [stdout] 90 +         "listen" => {
[INFO] [stdout] 91 +             println!("Listening...");
[INFO] [stdout] 92 +         }
[INFO] [stdout] 93 +         _ => {
[INFO] [stdout] 94 + 
[INFO] [stdout] 95 +         }
[INFO] [stdout] 96 +     } }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/main.rs:68:38
[INFO] [stdout]    |
[INFO] [stdout] 68 |                     if !fs::metadata(&p).is_ok() { continue };
[INFO] [stdout]    |                                      ^^ help: change this to: `p`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/main.rs:69:37
[INFO] [stdout]    |
[INFO] [stdout] 69 |                     if fs::metadata(&p).unwrap().is_dir() {
[INFO] [stdout]    |                                     ^^ help: change this to: `p`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/main.rs:77:44
[INFO] [stdout]    |
[INFO] [stdout] 77 |                     } else if fs::metadata(&p).unwrap().is_file() {
[INFO] [stdout]    |                                            ^^ help: change this to: `p`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.56s
[INFO] running `Command { std: "docker" "inspect" "7ca3167d029292b5a0c33f586c463abb9b31d05bdde37df7124955c8975c18d0", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "7ca3167d029292b5a0c33f586c463abb9b31d05bdde37df7124955c8975c18d0", kill_on_drop: false }`
[INFO] [stdout] 7ca3167d029292b5a0c33f586c463abb9b31d05bdde37df7124955c8975c18d0