[INFO] cloning repository https://github.com/Travispersson/codecrafters-interpreter-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Travispersson/codecrafters-interpreter-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTravispersson%2Fcodecrafters-interpreter-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTravispersson%2Fcodecrafters-interpreter-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bc3c6efae2b46481ef62537974bb614cd821aa9f [INFO] linting Travispersson/codecrafters-interpreter-rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTravispersson%2Fcodecrafters-interpreter-rust" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Travispersson/codecrafters-interpreter-rust [INFO] finished tweaking git repo https://github.com/Travispersson/codecrafters-interpreter-rust [INFO] tweaked toml for git repo https://github.com/Travispersson/codecrafters-interpreter-rust written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Travispersson/codecrafters-interpreter-rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Travispersson/codecrafters-interpreter-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded thiserror v1.0.38 [INFO] [stderr] Downloaded quote v1.0.7 [INFO] [stderr] Downloaded proc-macro2 v1.0.24 [INFO] [stderr] Downloaded bytes v1.3.0 [INFO] [stderr] Downloaded anyhow v1.0.68 [INFO] [stderr] Downloaded thiserror-impl v1.0.38 [INFO] [stderr] Downloaded unicode-xid v0.2.1 [INFO] [stderr] Downloaded syn v1.0.48 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 53653eb9347a0203bb685f72e8a2bab576f7b7eee09d9600caddd74ec64b57a1 [INFO] running `Command { std: "docker" "start" "-a" "53653eb9347a0203bb685f72e8a2bab576f7b7eee09d9600caddd74ec64b57a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "53653eb9347a0203bb685f72e8a2bab576f7b7eee09d9600caddd74ec64b57a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "53653eb9347a0203bb685f72e8a2bab576f7b7eee09d9600caddd74ec64b57a1", kill_on_drop: false }` [INFO] [stdout] 53653eb9347a0203bb685f72e8a2bab576f7b7eee09d9600caddd74ec64b57a1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 30b7095c38460f0afe5a94ce93b0c921f081a1e29176d3ba13dfe3fe1ca8695c [INFO] running `Command { std: "docker" "start" "-a" "30b7095c38460f0afe5a94ce93b0c921f081a1e29176d3ba13dfe3fe1ca8695c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.48 [INFO] [stderr] Compiling thiserror v1.0.38 [INFO] [stderr] Compiling anyhow v1.0.68 [INFO] [stderr] Checking bytes v1.3.0 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Compiling thiserror-impl v1.0.38 [INFO] [stderr] Checking interpreter-starter-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `c` [INFO] [stdout] --> src/syntax/scanner.rs:135:34 [INFO] [stdout] | [INFO] [stdout] 135 | fn add_identifier(&mut self, c: char) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_c` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/syntax/scanner.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | / self.c_iter.next().and_then(|v| { [INFO] [stdout] 36 | | self.current += v.len_utf8(); [INFO] [stdout] 37 | | Some(v) [INFO] [stdout] 38 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: use `map` instead [INFO] [stdout] | [INFO] [stdout] 35 ~ self.c_iter.next().map(|v| { [INFO] [stdout] 36 | self.current += v.len_utf8(); [INFO] [stdout] 37 ~ v [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/syntax/scanner.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | / let Some(c) = self.peek() else { [INFO] [stdout] 43 | | return None; [INFO] [stdout] 44 | | }; [INFO] [stdout] | |__________^ help: replace it with: `let c = self.peek()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/syntax/scanner.rs:123:41 [INFO] [stdout] | [INFO] [stdout] 123 | if self.peek() == Some(&'.') && self.peek_next().map_or(false, |c| c.is_ascii_digit()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 123 - if self.peek() == Some(&'.') && self.peek_next().map_or(false, |c| c.is_ascii_digit()) { [INFO] [stdout] 123 + if self.peek() == Some(&'.') && self.peek_next().is_some_and(|c| c.is_ascii_digit()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/syntax/scanner.rs:237:15 [INFO] [stdout] | [INFO] [stdout] 237 | while !self.c_iter.peek().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.c_iter.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `c` [INFO] [stdout] --> src/syntax/scanner.rs:135:34 [INFO] [stdout] | [INFO] [stdout] 135 | fn add_identifier(&mut self, c: char) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_c` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - writeln!(io::stderr(), "Unknown command: {}", command).unwrap(); [INFO] [stdout] 44 - return; [INFO] [stdout] 43 + writeln!(io::stderr(), "Unknown command: {}", command).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `writeln!(stderr(), ...).unwrap()` [INFO] [stdout] --> src/main.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | writeln!(io::stderr(), "Usage: {} tokenize ", args[0]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `eprintln!("Usage: {} tokenize ", args[0])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stdout] = note: `#[warn(clippy::explicit_write)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `writeln!(stderr(), ...).unwrap()` [INFO] [stdout] --> src/main.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | writeln!(io::stderr(), "Logs from your program will appear here!").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `eprintln!("Logs from your program will appear here!")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `writeln!(stderr(), ...).unwrap()` [INFO] [stdout] --> src/main.rs:24:17 [INFO] [stdout] | [INFO] [stdout] 24 | writeln!(io::stderr(), "Failed to read file {}", filename).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `eprintln!("Failed to read file {}", filename)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `writeln!(stderr(), ...).unwrap()` [INFO] [stdout] --> src/main.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | writeln!(io::stderr(), "Unknown command: {}", command).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `eprintln!("Unknown command: {}", command)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 43 - writeln!(io::stderr(), "Unknown command: {}", command).unwrap(); [INFO] [stdout] 44 - return; [INFO] [stdout] 43 + writeln!(io::stderr(), "Unknown command: {}", command).unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `writeln!(stderr(), ...).unwrap()` [INFO] [stdout] --> src/main.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | writeln!(io::stderr(), "Usage: {} tokenize ", args[0]).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `eprintln!("Usage: {} tokenize ", args[0])` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stdout] = note: `#[warn(clippy::explicit_write)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `writeln!(stderr(), ...).unwrap()` [INFO] [stdout] --> src/main.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | writeln!(io::stderr(), "Logs from your program will appear here!").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `eprintln!("Logs from your program will appear here!")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `writeln!(stderr(), ...).unwrap()` [INFO] [stdout] --> src/main.rs:24:17 [INFO] [stdout] | [INFO] [stdout] 24 | writeln!(io::stderr(), "Failed to read file {}", filename).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `eprintln!("Failed to read file {}", filename)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `writeln!(stderr(), ...).unwrap()` [INFO] [stdout] --> src/main.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | writeln!(io::stderr(), "Unknown command: {}", command).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `eprintln!("Unknown command: {}", command)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> src/syntax/scanner.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | / self.c_iter.next().and_then(|v| { [INFO] [stdout] 36 | | self.current += v.len_utf8(); [INFO] [stdout] 37 | | Some(v) [INFO] [stdout] 38 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: use `map` instead [INFO] [stdout] | [INFO] [stdout] 35 ~ self.c_iter.next().map(|v| { [INFO] [stdout] 36 | self.current += v.len_utf8(); [INFO] [stdout] 37 ~ v [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/syntax/scanner.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | / let Some(c) = self.peek() else { [INFO] [stdout] 43 | | return None; [INFO] [stdout] 44 | | }; [INFO] [stdout] | |__________^ help: replace it with: `let c = self.peek()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/syntax/scanner.rs:123:41 [INFO] [stdout] | [INFO] [stdout] 123 | if self.peek() == Some(&'.') && self.peek_next().map_or(false, |c| c.is_ascii_digit()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 123 - if self.peek() == Some(&'.') && self.peek_next().map_or(false, |c| c.is_ascii_digit()) { [INFO] [stdout] 123 + if self.peek() == Some(&'.') && self.peek_next().is_some_and(|c| c.is_ascii_digit()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/syntax/scanner.rs:237:15 [INFO] [stdout] | [INFO] [stdout] 237 | while !self.c_iter.peek().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.c_iter.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.39s [INFO] running `Command { std: "docker" "inspect" "30b7095c38460f0afe5a94ce93b0c921f081a1e29176d3ba13dfe3fe1ca8695c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "30b7095c38460f0afe5a94ce93b0c921f081a1e29176d3ba13dfe3fe1ca8695c", kill_on_drop: false }` [INFO] [stdout] 30b7095c38460f0afe5a94ce93b0c921f081a1e29176d3ba13dfe3fe1ca8695c