[INFO] cloning repository https://github.com/Tortus-exe/ultralist_reader
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Tortus-exe/ultralist_reader" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTortus-exe%2Fultralist_reader", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTortus-exe%2Fultralist_reader'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] df7d65721558d99316200db3d88800e50e6b52b3
[INFO] linting Tortus-exe/ultralist_reader against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTortus-exe%2Fultralist_reader" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/Tortus-exe/ultralist_reader
[INFO] finished tweaking git repo https://github.com/Tortus-exe/ultralist_reader
[INFO] tweaked toml for git repo https://github.com/Tortus-exe/ultralist_reader written to /workspace/builds/worker-3-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/Tortus-exe/ultralist_reader on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/Tortus-exe/ultralist_reader already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded wasm-bindgen-shared v0.2.105
[INFO] [stderr]   Downloaded wasm-bindgen v0.2.105
[INFO] [stderr]   Downloaded wasm-bindgen-macro v0.2.105
[INFO] [stderr]   Downloaded wasm-bindgen-macro-support v0.2.105
[INFO] [stderr]   Downloaded clap_lex v0.7.6
[INFO] [stderr]   Downloaded tabled_derive v0.11.0
[INFO] [stderr]   Downloaded xdir v0.1.0
[INFO] [stderr]   Downloaded testing_table v0.3.0
[INFO] [stderr]   Downloaded uuid v1.18.1
[INFO] [stderr]   Downloaded find-msvc-tools v0.1.4
[INFO] [stderr]   Downloaded arrayvec v0.7.6
[INFO] [stderr]   Downloaded clap v4.5.51
[INFO] [stderr]   Downloaded cc v1.2.45
[INFO] [stderr]   Downloaded indexmap v2.10.0
[INFO] [stderr]   Downloaded vte v0.14.1
[INFO] [stderr]   Downloaded papergrid v0.17.0
[INFO] [stderr]   Downloaded js-sys v0.3.82
[INFO] [stderr]   Downloaded clap_builder v4.5.51
[INFO] [stderr]   Downloaded clap_derive v4.5.49
[INFO] [stderr]   Downloaded ansi-str v0.9.0
[INFO] [stderr]   Downloaded bytecount v0.6.9
[INFO] [stderr]   Downloaded tabled v0.20.0
[INFO] [stderr]   Downloaded syn v2.0.110
[INFO] [stderr]   Downloaded ansitok v0.3.0
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] dce48919114f375bc97cdffb4436d22990319dccf7ff63e0bb90695886aa57b2
[INFO] running `Command { std: "docker" "start" "-a" "dce48919114f375bc97cdffb4436d22990319dccf7ff63e0bb90695886aa57b2", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "dce48919114f375bc97cdffb4436d22990319dccf7ff63e0bb90695886aa57b2", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "dce48919114f375bc97cdffb4436d22990319dccf7ff63e0bb90695886aa57b2", kill_on_drop: false }`
[INFO] [stdout] dce48919114f375bc97cdffb4436d22990319dccf7ff63e0bb90695886aa57b2
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 1ff393374ea3236ee80b55e9aed532218498e085dbe3c051b8d892ee880cbcde
[INFO] running `Command { std: "docker" "start" "-a" "1ff393374ea3236ee80b55e9aed532218498e085dbe3c051b8d892ee880cbcde", kill_on_drop: false }`
[INFO] [stderr]    Compiling proc-macro2 v1.0.103
[INFO] [stderr]    Compiling unicode-ident v1.0.22
[INFO] [stderr]    Compiling quote v1.0.42
[INFO] [stderr]     Checking memchr v2.7.6
[INFO] [stderr]     Checking minimal-lexical v0.2.1
[INFO] [stderr]     Checking arrayvec v0.7.6
[INFO] [stderr]    Compiling libc v0.2.177
[INFO] [stderr]     Checking utf8parse v0.2.2
[INFO] [stderr]    Compiling heck v0.5.0
[INFO] [stderr]    Compiling serde_core v1.0.228
[INFO] [stderr]    Compiling autocfg v1.5.0
[INFO] [stderr]     Checking colorchoice v1.0.4
[INFO] [stderr]     Checking is_terminal_polyfill v1.70.2
[INFO] [stderr]     Checking anstyle-query v1.1.5
[INFO] [stderr]     Checking unicode-width v0.2.2
[INFO] [stderr]    Compiling getrandom v0.3.4
[INFO] [stderr]     Checking anstyle v1.0.13
[INFO] [stderr]    Compiling serde v1.0.228
[INFO] [stderr]     Checking cfg-if v1.0.4
[INFO] [stderr]     Checking bytecount v0.6.9
[INFO] [stderr]     Checking anstyle-parse v0.2.7
[INFO] [stderr]     Checking hashbrown v0.15.5
[INFO] [stderr]    Compiling serde_json v1.0.145
[INFO] [stderr]     Checking equivalent v1.0.2
[INFO] [stderr]     Checking anstream v0.6.21
[INFO] [stderr]     Checking strsim v0.11.1
[INFO] [stderr]     Checking clap_lex v0.7.6
[INFO] [stderr]     Checking fnv v1.0.7
[INFO] [stderr]     Checking either v1.15.0
[INFO] [stderr]     Checking ryu v1.0.20
[INFO] [stderr]     Checking iana-time-zone v0.1.64
[INFO] [stderr]     Checking nom v7.1.3
[INFO] [stderr]     Checking vte v0.14.1
[INFO] [stderr]     Checking itoa v1.0.15
[INFO] [stderr]     Checking home v0.5.11
[INFO] [stderr]     Checking xdir v0.1.0
[INFO] [stderr]     Checking colored v3.0.0
[INFO] [stderr]    Compiling num-traits v0.2.19
[INFO] [stderr]     Checking itertools v0.14.0
[INFO] [stderr]     Checking clap_builder v4.5.51
[INFO] [stderr]    Compiling syn v2.0.110
[INFO] [stderr]    Compiling proc-macro-error-attr2 v2.0.0
[INFO] [stderr]     Checking indexmap v2.10.0
[INFO] [stderr]     Checking chrono v0.4.42
[INFO] [stderr]     Checking uuid v1.18.1
[INFO] [stderr]     Checking ansitok v0.3.0
[INFO] [stderr]     Checking ansi-str v0.9.0
[INFO] [stderr]     Checking testing_table v0.3.0
[INFO] [stderr]     Checking papergrid v0.17.0
[INFO] [stderr]    Compiling proc-macro-error2 v2.0.1
[INFO] [stderr]    Compiling clap_derive v4.5.49
[INFO] [stderr]    Compiling tabled_derive v0.11.0
[INFO] [stderr]    Compiling serde_derive v1.0.228
[INFO] [stderr]     Checking tabled v0.20.0
[INFO] [stderr]     Checking clap v4.5.51
[INFO] [stderr]     Checking ul_todo_reader v0.1.3 (/opt/rustwide/workdir)
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/modify.rs:50:9
[INFO] [stdout]    |
[INFO] [stdout] 50 |         id: id,
[INFO] [stdout]    |         ^^^^^^ help: replace it with: `id`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/modify.rs:55:9
[INFO] [stdout]    |
[INFO] [stdout] 55 |         due: due,
[INFO] [stdout]    |         ^^^^^^^^ help: replace it with: `due`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/modify.rs:50:9
[INFO] [stdout]    |
[INFO] [stdout] 50 |         id: id,
[INFO] [stdout]    |         ^^^^^^ help: replace it with: `id`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/modify.rs:55:9
[INFO] [stdout]    |
[INFO] [stdout] 55 |         due: due,
[INFO] [stdout]    |         ^^^^^^^^ help: replace it with: `due`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]   --> src/serde_date_time.rs:31:12
[INFO] [stdout]    |
[INFO] [stdout] 31 |         if s == "" {
[INFO] [stdout]    |            ^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout]    = note: `#[warn(clippy::comparison_to_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]   --> src/serde_date.rs:32:12
[INFO] [stdout]    |
[INFO] [stdout] 32 |         if s == "" {
[INFO] [stdout]    |            ^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]   --> src/serde_date.rs:57:37
[INFO] [stdout]    |
[INFO] [stdout] 57 |             None => write!(f, "{}", ""),
[INFO] [stdout]    |                                     ^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal
[INFO] [stdout]    = note: `#[warn(clippy::write_literal)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 57 -             None => write!(f, "{}", ""),
[INFO] [stdout] 57 +             None => write!(f, ""),
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args
[INFO] [stdout]   --> src/serde_date.rs:58:60
[INFO] [stdout]    |
[INFO] [stdout] 58 |             Some(d) => write!(f, "{}", d.format("%a %b %d").to_string()),
[INFO] [stdout]    |                                                            ^^^^^^^^^^^^ help: remove this
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
[INFO] [stdout]    = note: `#[warn(clippy::to_string_in_format_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `cmp` can be confused for the standard trait method `std::cmp::Ord::cmp`
[INFO] [stdout]    --> src/serde_date.rs:114:5
[INFO] [stdout]     |
[INFO] [stdout] 114 | /     pub fn cmp(&self, other: &SerdeDate) -> Ordering {
[INFO] [stdout] 115 | |         if let (Some(this_date_i), Some(other_date_i)) = (self.date, other.date) {
[INFO] [stdout] 116 | |             return this_date_i.cmp(&other_date_i);
[INFO] [stdout] 117 | |         } else {
[INFO] [stdout] ...   |
[INFO] [stdout] 123 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: consider implementing the trait `std::cmp::Ord` or choosing a less ambiguous method name
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stdout]     = note: `#[warn(clippy::should_implement_trait)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/serde_date.rs:116:13
[INFO] [stdout]     |
[INFO] [stdout] 116 |             return this_date_i.cmp(&other_date_i);
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 116 -             return this_date_i.cmp(&other_date_i);
[INFO] [stdout] 116 +             this_date_i.cmp(&other_date_i)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]   --> src/list.rs:22:15
[INFO] [stdout]    |
[INFO] [stdout] 22 |         match word.chars().nth(0) {
[INFO] [stdout]    |               ^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `word.chars().next()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout]    = note: `#[warn(clippy::iter_nth_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/list.rs:42:25
[INFO] [stdout]    |
[INFO] [stdout] 42 | fn todo_grouping(todos: &Vec<Todo>, grouping: Option<GroupOption>) -> HashMap<&str, Vec<&Todo>> {
[INFO] [stdout]    |                         ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 42 - fn todo_grouping(todos: &Vec<Todo>, grouping: Option<GroupOption>) -> HashMap<&str, Vec<&Todo>> {
[INFO] [stdout] 42 + fn todo_grouping(todos: &[Todo], grouping: Option<GroupOption>) -> HashMap<&str, Vec<&Todo>> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/list.rs:113:17
[INFO] [stdout]     |
[INFO] [stdout] 113 | /                 if show_notes {
[INFO] [stdout] 114 | |                     if let Some(notes) = &item.notes {
[INFO] [stdout] 115 | |                         notes.iter().enumerate().for_each(|(i, note)| {
[INFO] [stdout] 116 | |                             note_rows.push((builder.count_records(), 2));
[INFO] [stdout] ...   |
[INFO] [stdout] 120 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 113 ~                 if show_notes
[INFO] [stdout] 114 ~                     && let Some(notes) = &item.notes {
[INFO] [stdout] 115 |                         notes.iter().enumerate().for_each(|(i, note)| {
[INFO] [stdout] ...
[INFO] [stdout] 118 |                         });
[INFO] [stdout] 119 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/list.rs:144:80
[INFO] [stdout]     |
[INFO] [stdout] 144 | pub fn list(todos: &Vec<Todo>, grouping: Option<GroupOption>, show_notes: bool) -> () {
[INFO] [stdout]     |                                                                                ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout]     = note: `#[warn(clippy::unused_unit)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]   --> src/modify.rs:11:15
[INFO] [stdout]    |
[INFO] [stdout] 11 |         match word.chars().nth(0) {
[INFO] [stdout]    |               ^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `word.chars().next()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
[INFO] [stdout]   --> src/modify.rs:32:11
[INFO] [stdout]    |
[INFO] [stdout] 32 |     todos.into_iter().for_each(|td| {
[INFO] [stdout]    |           ^^^^^^^^^ help: call directly: `iter`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stdout]    = note: `#[warn(clippy::into_iter_on_ref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/modify.rs:70:31
[INFO] [stdout]    |
[INFO] [stdout] 70 | pub fn find_todo_index(todos: &Vec<Todo>, id: u64) -> Result<usize, AppError> {
[INFO] [stdout]    |                               ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 70 - pub fn find_todo_index(todos: &Vec<Todo>, id: u64) -> Result<usize, AppError> {
[INFO] [stdout] 70 + pub fn find_todo_index(todos: &[Todo], id: u64) -> Result<usize, AppError> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/modify.rs:77:29
[INFO] [stdout]    |
[INFO] [stdout] 77 | pub fn find_todo_mut(todos: &mut Vec<Todo>, id: u64) -> Result<&mut Todo, AppError> {
[INFO] [stdout]    |                             ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 77 - pub fn find_todo_mut(todos: &mut Vec<Todo>, id: u64) -> Result<&mut Todo, AppError> {
[INFO] [stdout] 77 + pub fn find_todo_mut(todos: &mut [Todo], id: u64) -> Result<&mut Todo, AppError> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/modify.rs:99:5
[INFO] [stdout]    |
[INFO] [stdout] 99 |     return Ok(());
[INFO] [stdout]    |     ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 99 -     return Ok(());
[INFO] [stdout] 99 +     Ok(())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/modify.rs:105:5
[INFO] [stdout]     |
[INFO] [stdout] 105 |     return Ok(());
[INFO] [stdout]     |     ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 105 -     return Ok(());
[INFO] [stdout] 105 +     Ok(())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/modify.rs:128:48
[INFO] [stdout]     |
[INFO] [stdout] 128 | pub fn archive_completed(todos: &mut Vec<Todo>) -> () {
[INFO] [stdout]     |                                                ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/modify.rs:128:33
[INFO] [stdout]     |
[INFO] [stdout] 128 | pub fn archive_completed(todos: &mut Vec<Todo>) -> () {
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 128 - pub fn archive_completed(todos: &mut Vec<Todo>) -> () {
[INFO] [stdout] 128 + pub fn archive_completed(todos: &mut [Todo]) -> () {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/modify.rs:136:46
[INFO] [stdout]     |
[INFO] [stdout] 136 | pub fn delete_archived(todos: &mut Vec<Todo>) -> () {
[INFO] [stdout]     |                                              ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against false can be replaced by a negation
[INFO] [stdout]    --> src/modify.rs:137:26
[INFO] [stdout]     |
[INFO] [stdout] 137 |     todos.retain(|todo| {todo.archived == false})
[INFO] [stdout]     |                          ^^^^^^^^^^^^^^^^^^^^^^ help: try: `!todo.archived`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout]     = note: `#[warn(clippy::bool_comparison)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/notes.rs:31:12
[INFO] [stdout]    |
[INFO] [stdout] 31 |         if notes.len() == 0 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `notes.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/todo_files.rs:22:16
[INFO] [stdout]    |
[INFO] [stdout] 22 |     create_dir(&confdir.join("todolists"))?;
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `confdir.join("todolists")`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]   --> src/serde_date_time.rs:31:12
[INFO] [stdout]    |
[INFO] [stdout] 31 |         if s == "" {
[INFO] [stdout]    |            ^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout]    = note: `#[warn(clippy::comparison_to_empty)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: comparison to empty slice
[INFO] [stdout]   --> src/serde_date.rs:32:12
[INFO] [stdout]    |
[INFO] [stdout] 32 |         if s == "" {
[INFO] [stdout]    |            ^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]   --> src/serde_date.rs:57:37
[INFO] [stdout]    |
[INFO] [stdout] 57 |             None => write!(f, "{}", ""),
[INFO] [stdout]    |                                     ^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal
[INFO] [stdout]    = note: `#[warn(clippy::write_literal)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 57 -             None => write!(f, "{}", ""),
[INFO] [stdout] 57 +             None => write!(f, ""),
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `write!` args
[INFO] [stdout]   --> src/serde_date.rs:58:60
[INFO] [stdout]    |
[INFO] [stdout] 58 |             Some(d) => write!(f, "{}", d.format("%a %b %d").to_string()),
[INFO] [stdout]    |                                                            ^^^^^^^^^^^^ help: remove this
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args
[INFO] [stdout]    = note: `#[warn(clippy::to_string_in_format_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: method `cmp` can be confused for the standard trait method `std::cmp::Ord::cmp`
[INFO] [stdout]    --> src/serde_date.rs:114:5
[INFO] [stdout]     |
[INFO] [stdout] 114 | /     pub fn cmp(&self, other: &SerdeDate) -> Ordering {
[INFO] [stdout] 115 | |         if let (Some(this_date_i), Some(other_date_i)) = (self.date, other.date) {
[INFO] [stdout] 116 | |             return this_date_i.cmp(&other_date_i);
[INFO] [stdout] 117 | |         } else {
[INFO] [stdout] ...   |
[INFO] [stdout] 123 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: consider implementing the trait `std::cmp::Ord` or choosing a less ambiguous method name
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait
[INFO] [stdout]     = note: `#[warn(clippy::should_implement_trait)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/serde_date.rs:116:13
[INFO] [stdout]     |
[INFO] [stdout] 116 |             return this_date_i.cmp(&other_date_i);
[INFO] [stdout]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 116 -             return this_date_i.cmp(&other_date_i);
[INFO] [stdout] 116 +             this_date_i.cmp(&other_date_i)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]   --> src/list.rs:22:15
[INFO] [stdout]    |
[INFO] [stdout] 22 |         match word.chars().nth(0) {
[INFO] [stdout]    |               ^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `word.chars().next()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout]    = note: `#[warn(clippy::iter_nth_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/list.rs:42:25
[INFO] [stdout]    |
[INFO] [stdout] 42 | fn todo_grouping(todos: &Vec<Todo>, grouping: Option<GroupOption>) -> HashMap<&str, Vec<&Todo>> {
[INFO] [stdout]    |                         ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 42 - fn todo_grouping(todos: &Vec<Todo>, grouping: Option<GroupOption>) -> HashMap<&str, Vec<&Todo>> {
[INFO] [stdout] 42 + fn todo_grouping(todos: &[Todo], grouping: Option<GroupOption>) -> HashMap<&str, Vec<&Todo>> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/list.rs:113:17
[INFO] [stdout]     |
[INFO] [stdout] 113 | /                 if show_notes {
[INFO] [stdout] 114 | |                     if let Some(notes) = &item.notes {
[INFO] [stdout] 115 | |                         notes.iter().enumerate().for_each(|(i, note)| {
[INFO] [stdout] 116 | |                             note_rows.push((builder.count_records(), 2));
[INFO] [stdout] ...   |
[INFO] [stdout] 120 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 113 ~                 if show_notes
[INFO] [stdout] 114 ~                     && let Some(notes) = &item.notes {
[INFO] [stdout] 115 |                         notes.iter().enumerate().for_each(|(i, note)| {
[INFO] [stdout] ...
[INFO] [stdout] 118 |                         });
[INFO] [stdout] 119 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/list.rs:144:80
[INFO] [stdout]     |
[INFO] [stdout] 144 | pub fn list(todos: &Vec<Todo>, grouping: Option<GroupOption>, show_notes: bool) -> () {
[INFO] [stdout]     |                                                                                ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout]     = note: `#[warn(clippy::unused_unit)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]   --> src/modify.rs:11:15
[INFO] [stdout]    |
[INFO] [stdout] 11 |         match word.chars().nth(0) {
[INFO] [stdout]    |               ^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `word.chars().next()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`
[INFO] [stdout]   --> src/modify.rs:32:11
[INFO] [stdout]    |
[INFO] [stdout] 32 |     todos.into_iter().for_each(|td| {
[INFO] [stdout]    |           ^^^^^^^^^ help: call directly: `iter`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stdout]    = note: `#[warn(clippy::into_iter_on_ref)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/modify.rs:70:31
[INFO] [stdout]    |
[INFO] [stdout] 70 | pub fn find_todo_index(todos: &Vec<Todo>, id: u64) -> Result<usize, AppError> {
[INFO] [stdout]    |                               ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 70 - pub fn find_todo_index(todos: &Vec<Todo>, id: u64) -> Result<usize, AppError> {
[INFO] [stdout] 70 + pub fn find_todo_index(todos: &[Todo], id: u64) -> Result<usize, AppError> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/modify.rs:77:29
[INFO] [stdout]    |
[INFO] [stdout] 77 | pub fn find_todo_mut(todos: &mut Vec<Todo>, id: u64) -> Result<&mut Todo, AppError> {
[INFO] [stdout]    |                             ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 77 - pub fn find_todo_mut(todos: &mut Vec<Todo>, id: u64) -> Result<&mut Todo, AppError> {
[INFO] [stdout] 77 + pub fn find_todo_mut(todos: &mut [Todo], id: u64) -> Result<&mut Todo, AppError> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/modify.rs:99:5
[INFO] [stdout]    |
[INFO] [stdout] 99 |     return Ok(());
[INFO] [stdout]    |     ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 99 -     return Ok(());
[INFO] [stdout] 99 +     Ok(())
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/modify.rs:105:5
[INFO] [stdout]     |
[INFO] [stdout] 105 |     return Ok(());
[INFO] [stdout]     |     ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 105 -     return Ok(());
[INFO] [stdout] 105 +     Ok(())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/modify.rs:128:48
[INFO] [stdout]     |
[INFO] [stdout] 128 | pub fn archive_completed(todos: &mut Vec<Todo>) -> () {
[INFO] [stdout]     |                                                ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/modify.rs:128:33
[INFO] [stdout]     |
[INFO] [stdout] 128 | pub fn archive_completed(todos: &mut Vec<Todo>) -> () {
[INFO] [stdout]     |                                 ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 128 - pub fn archive_completed(todos: &mut Vec<Todo>) -> () {
[INFO] [stdout] 128 + pub fn archive_completed(todos: &mut [Todo]) -> () {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded unit return type
[INFO] [stdout]    --> src/modify.rs:136:46
[INFO] [stdout]     |
[INFO] [stdout] 136 | pub fn delete_archived(todos: &mut Vec<Todo>) -> () {
[INFO] [stdout]     |                                              ^^^^^^ help: remove the `-> ()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: equality checks against false can be replaced by a negation
[INFO] [stdout]    --> src/modify.rs:137:26
[INFO] [stdout]     |
[INFO] [stdout] 137 |     todos.retain(|todo| {todo.archived == false})
[INFO] [stdout]     |                          ^^^^^^^^^^^^^^^^^^^^^^ help: try: `!todo.archived`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stdout]     = note: `#[warn(clippy::bool_comparison)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/modify.rs:216:9
[INFO] [stdout]     |
[INFO] [stdout] 216 |         assert_eq!(todo[0].completed, true);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout]     = note: `#[warn(clippy::bool_assert_comparison)]` on by default
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 216 -         assert_eq!(todo[0].completed, true);
[INFO] [stdout] 216 +         assert!(todo[0].completed);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/modify.rs:242:9
[INFO] [stdout]     |
[INFO] [stdout] 242 |         assert_eq!(todo[0].completed, true);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 242 -         assert_eq!(todo[0].completed, true);
[INFO] [stdout] 242 +         assert!(todo[0].completed);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/modify.rs:258:9
[INFO] [stdout]     |
[INFO] [stdout] 258 |         assert_eq!(todo[0].completed, false);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 258 -         assert_eq!(todo[0].completed, false);
[INFO] [stdout] 258 +         assert!(!todo[0].completed);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/modify.rs:289:9
[INFO] [stdout]     |
[INFO] [stdout] 289 |         assert_eq!(todo[0].is_priority, true);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 289 -         assert_eq!(todo[0].is_priority, true);
[INFO] [stdout] 289 +         assert!(todo[0].is_priority);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/modify.rs:339:9
[INFO] [stdout]     |
[INFO] [stdout] 339 |         assert_eq!(todo[0].completed, true);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 339 -         assert_eq!(todo[0].completed, true);
[INFO] [stdout] 339 +         assert!(todo[0].completed);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: used `assert_eq!` with a literal bool
[INFO] [stdout]    --> src/modify.rs:340:9
[INFO] [stdout]     |
[INFO] [stdout] 340 |         assert_eq!(todo[0].archived, true);
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
[INFO] [stdout] help: replace it with `assert!(..)`
[INFO] [stdout]     |
[INFO] [stdout] 340 -         assert_eq!(todo[0].archived, true);
[INFO] [stdout] 340 +         assert!(todo[0].archived);
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/notes.rs:31:12
[INFO] [stdout]    |
[INFO] [stdout] 31 |         if notes.len() == 0 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `notes.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/todo_files.rs:22:16
[INFO] [stdout]    |
[INFO] [stdout] 22 |     create_dir(&confdir.join("todolists"))?;
[INFO] [stdout]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `confdir.join("todolists")`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/main.rs:165:25
[INFO] [stdout]     |
[INFO] [stdout] 165 | fn sort_todo_list(list: &mut Vec<Todo>) {
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 165 - fn sort_todo_list(list: &mut Vec<Todo>) {
[INFO] [stdout] 165 + fn sort_todo_list(list: &mut [Todo]) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:167:12
[INFO] [stdout]     |
[INFO] [stdout] 167 |         if !((!a.is_priority).cmp(&(!b.is_priority)) == Ordering::Equal) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((!a.is_priority).cmp(&(!b.is_priority)) != Ordering::Equal)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]    --> src/main.rs:187:5
[INFO] [stdout]     |
[INFO] [stdout] 187 |     Ok(get_active_todo()?)
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout]     = note: `#[warn(clippy::needless_question_mark)]` on by default
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]     |
[INFO] [stdout] 187 -     Ok(get_active_todo()?)
[INFO] [stdout] 187 +     get_active_todo()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/main.rs:165:25
[INFO] [stdout]     |
[INFO] [stdout] 165 | fn sort_todo_list(list: &mut Vec<Todo>) {
[INFO] [stdout]     |                         ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 165 - fn sort_todo_list(list: &mut Vec<Todo>) {
[INFO] [stdout] 165 + fn sort_todo_list(list: &mut [Todo]) {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:167:12
[INFO] [stdout]     |
[INFO] [stdout] 167 |         if !((!a.is_priority).cmp(&(!b.is_priority)) == Ordering::Equal) {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((!a.is_priority).cmp(&(!b.is_priority)) != Ordering::Equal)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded
[INFO] [stdout]    --> src/main.rs:187:5
[INFO] [stdout]     |
[INFO] [stdout] 187 |     Ok(get_active_todo()?)
[INFO] [stdout]     |     ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark
[INFO] [stdout]     = note: `#[warn(clippy::needless_question_mark)]` on by default
[INFO] [stdout] help: remove the enclosing `Ok` and `?` operator
[INFO] [stdout]     |
[INFO] [stdout] 187 -     Ok(get_active_todo()?)
[INFO] [stdout] 187 +     get_active_todo()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 18.70s
[INFO] running `Command { std: "docker" "inspect" "1ff393374ea3236ee80b55e9aed532218498e085dbe3c051b8d892ee880cbcde", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "1ff393374ea3236ee80b55e9aed532218498e085dbe3c051b8d892ee880cbcde", kill_on_drop: false }`
[INFO] [stdout] 1ff393374ea3236ee80b55e9aed532218498e085dbe3c051b8d892ee880cbcde