[INFO] cloning repository https://github.com/Torrencem/dynamics-search [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Torrencem/dynamics-search" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTorrencem%2Fdynamics-search", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTorrencem%2Fdynamics-search'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b7511fcc5e1c20231e996e5f153aa0e0394bea5f [INFO] linting Torrencem/dynamics-search against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTorrencem%2Fdynamics-search" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Torrencem/dynamics-search [INFO] finished tweaking git repo https://github.com/Torrencem/dynamics-search [INFO] tweaked toml for git repo https://github.com/Torrencem/dynamics-search written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Torrencem/dynamics-search on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Torrencem/dynamics-search already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded num-bigint v0.2.2 [INFO] [stderr] Downloaded rayon v1.1.0 [INFO] [stderr] Downloaded libc v0.2.59 [INFO] [stderr] Downloaded rayon-core v1.5.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c1501304cccb11cdadc71dd3bef2a001576d9d3da32c8ce4277a8cc919feaf01 [INFO] running `Command { std: "docker" "start" "-a" "c1501304cccb11cdadc71dd3bef2a001576d9d3da32c8ce4277a8cc919feaf01", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c1501304cccb11cdadc71dd3bef2a001576d9d3da32c8ce4277a8cc919feaf01", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c1501304cccb11cdadc71dd3bef2a001576d9d3da32c8ce4277a8cc919feaf01", kill_on_drop: false }` [INFO] [stdout] c1501304cccb11cdadc71dd3bef2a001576d9d3da32c8ce4277a8cc919feaf01 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 971410efd30373fd2c7a32345f4d2d74ddb6aa499c6481914fc7dc5231ee167e [INFO] running `Command { std: "docker" "start" "-a" "971410efd30373fd2c7a32345f4d2d74ddb6aa499c6481914fc7dc5231ee167e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.59 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling arrayvec v0.4.11 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Compiling num-bigint v0.2.2 [INFO] [stderr] Compiling rayon-core v1.5.0 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Compiling num-complex v0.2.3 [INFO] [stderr] Compiling num-rational v0.2.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking either v1.5.2 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Checking crossbeam-epoch v0.7.1 [INFO] [stderr] Checking crossbeam-deque v0.6.3 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking rayon v1.1.0 [INFO] [stderr] Checking computing_project v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/util.rs:18:33 [INFO] [stdout] | [INFO] [stdout] 18 | Polynomial { coeffs: v, p_mod: p_mod } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `p_mod` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/util.rs:156:24 [INFO] [stdout] | [INFO] [stdout] 156 | PolynomialInQ {coeffs: coeffs} [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `coeffs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BTreeMap` [INFO] [stdout] --> src/ds_helper.rs:3:33 [INFO] [stdout] | [INFO] [stdout] 3 | use std::collections::{HashSet, BTreeMap}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `arrayvec::ArrayVec` [INFO] [stdout] --> src/ds_helper.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use arrayvec::ArrayVec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `math::*` [INFO] [stdout] --> src/main.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use math::*; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/util.rs:18:33 [INFO] [stdout] | [INFO] [stdout] 18 | Polynomial { coeffs: v, p_mod: p_mod } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `p_mod` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/util.rs:156:24 [INFO] [stdout] | [INFO] [stdout] 156 | PolynomialInQ {coeffs: coeffs} [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `coeffs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `euclidean_division` has been stable since 1.38.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(euclidean_division, test)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BTreeMap` [INFO] [stdout] --> src/ds_helper.rs:3:33 [INFO] [stdout] | [INFO] [stdout] 3 | use std::collections::{HashSet, BTreeMap}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `arrayvec::ArrayVec` [INFO] [stdout] --> src/ds_helper.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use arrayvec::ArrayVec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `euclidean_division` has been stable since 1.38.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(euclidean_division, test)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `zero` and `one` are never used [INFO] [stdout] --> src/util.rs:127:12 [INFO] [stdout] | [INFO] [stdout] 122 | impl Rational { [INFO] [stdout] | ------------- associated functions in this implementation [INFO] [stdout] ... [INFO] [stdout] 127 | pub fn zero() -> Rational { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 131 | pub fn one() -> Rational { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `from` is never used [INFO] [stdout] --> src/util.rs:155:12 [INFO] [stdout] | [INFO] [stdout] 154 | impl PolynomialInQ { [INFO] [stdout] | ------------------ associated function in this implementation [INFO] [stdout] 155 | pub fn from(coeffs: Vec) -> PolynomialInQ { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `one`, `zero`, `approx_coords`, and `phase_angle` are never used [INFO] [stdout] --> src/util.rs:355:12 [INFO] [stdout] | [INFO] [stdout] 325 | impl QwElement { [INFO] [stdout] | -------------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 355 | pub fn one() -> QwElement { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 359 | pub fn zero() -> QwElement { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 363 | pub fn approx_coords(&self) -> Complex32 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 367 | pub fn phase_angle(&self) -> f32 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PolynomialInQw` is never constructed [INFO] [stdout] --> src/util.rs:393:12 [INFO] [stdout] | [INFO] [stdout] 393 | pub struct PolynomialInQw { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `from` and `reductions` are never used [INFO] [stdout] --> src/util.rs:398:12 [INFO] [stdout] | [INFO] [stdout] 397 | impl PolynomialInQw { [INFO] [stdout] | ------------------- associated items in this implementation [INFO] [stdout] 398 | pub fn from(coeffs: Vec) -> PolynomialInQw { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 402 | pub fn reductions(&self, p: i64) -> (Option, Option) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `possible_periods_search_qw` is never used [INFO] [stdout] --> src/ds_helper.rs:50:8 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn possible_periods_search_qw(f: PolynomialInQw, goal: usize) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `p` [INFO] [stdout] --> src/math.rs:41:18 [INFO] [stdout] | [INFO] [stdout] 41 | for i in 0..301 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 41 - for i in 0..301 { [INFO] [stdout] 41 + for (i, ) in p.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/math.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return true; [INFO] [stdout] 59 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/math.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 55 | if n % x == 0 { [INFO] [stdout] | ^^^^^^^^^^ help: replace with: `n.is_multiple_of(x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 165 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return true; [INFO] [stdout] 165 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/util.rs:230:45 [INFO] [stdout] | [INFO] [stdout] 230 | if self.a.abs() == 1 && self.b == 0 { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 231 | | true [INFO] [stdout] 232 | | } else if self.b.abs() == 1 && self.a == 0 { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/util.rs:232:52 [INFO] [stdout] | [INFO] [stdout] 232 | } else if self.b.abs() == 1 && self.a == 0 { [INFO] [stdout] | ____________________________________________________^ [INFO] [stdout] 233 | | true [INFO] [stdout] 234 | | } else if self.a == -1 && self.b == -1 { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/util.rs:232:52 [INFO] [stdout] | [INFO] [stdout] 232 | } else if self.b.abs() == 1 && self.a == 0 { [INFO] [stdout] | ____________________________________________________^ [INFO] [stdout] 233 | | true [INFO] [stdout] 234 | | } else if self.a == -1 && self.b == -1 { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/util.rs:234:48 [INFO] [stdout] | [INFO] [stdout] 234 | } else if self.a == -1 && self.b == -1 { [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 235 | | true [INFO] [stdout] 236 | | } else { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/util.rs:234:16 [INFO] [stdout] | [INFO] [stdout] 234 | } else if self.a == -1 && self.b == -1 { [INFO] [stdout] | ________________^ [INFO] [stdout] 235 | | true [INFO] [stdout] 236 | | } else { [INFO] [stdout] 237 | | false [INFO] [stdout] 238 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `{ self.a == -1 && self.b == -1 }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `one`, `zero`, `approx_coords`, and `phase_angle` are never used [INFO] [stdout] --> src/util.rs:355:12 [INFO] [stdout] | [INFO] [stdout] 325 | impl QwElement { [INFO] [stdout] | -------------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 355 | pub fn one() -> QwElement { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 359 | pub fn zero() -> QwElement { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 363 | pub fn approx_coords(&self) -> Complex32 { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 367 | pub fn phase_angle(&self) -> f32 { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `PolynomialInQw` is never constructed [INFO] [stdout] --> src/util.rs:393:12 [INFO] [stdout] | [INFO] [stdout] 393 | pub struct PolynomialInQw { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `from` and `reductions` are never used [INFO] [stdout] --> src/util.rs:398:12 [INFO] [stdout] | [INFO] [stdout] 397 | impl PolynomialInQw { [INFO] [stdout] | ------------------- associated items in this implementation [INFO] [stdout] 398 | pub fn from(coeffs: Vec) -> PolynomialInQw { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 402 | pub fn reductions(&self, p: i64) -> (Option, Option) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `possible_periods_search_qw` is never used [INFO] [stdout] --> src/ds_helper.rs:50:8 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn possible_periods_search_qw(f: PolynomialInQw, goal: usize) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `p` [INFO] [stdout] --> src/math.rs:41:18 [INFO] [stdout] | [INFO] [stdout] 41 | for i in 0..301 { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 41 - for i in 0..301 { [INFO] [stdout] 41 + for (i, ) in p.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/math.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return true; [INFO] [stdout] 59 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/math.rs:55:12 [INFO] [stdout] | [INFO] [stdout] 55 | if n % x == 0 { [INFO] [stdout] | ^^^^^^^^^^ help: replace with: `n.is_multiple_of(x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/ds_helper.rs:24:23 [INFO] [stdout] | [INFO] [stdout] 24 | res = res.intersection(&pers).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.intersection(&pers).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/ds_helper.rs:43:11 [INFO] [stdout] | [INFO] [stdout] 43 | res = res.difference(¬_interesting).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.difference(¬_interesting).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/ds_helper.rs:63:31 [INFO] [stdout] | [INFO] [stdout] 63 | res = res.intersection(&fast_possible_periods(r2)).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.intersection(&fast_possible_periods(r2)).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/ds_helper.rs:70:27 [INFO] [stdout] | [INFO] [stdout] 70 | res = res.intersection(&fast_possible_periods(r1)).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.intersection(&fast_possible_periods(r1)).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/ds_helper.rs:73:27 [INFO] [stdout] | [INFO] [stdout] 73 | res = res.intersection(&fast_possible_periods(r2)).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.intersection(&fast_possible_periods(r2)).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/ds_helper.rs:93:11 [INFO] [stdout] | [INFO] [stdout] 93 | res = res.difference(¬_interesting).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.difference(¬_interesting).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/ds_helper.rs:155:23 [INFO] [stdout] | [INFO] [stdout] 155 | res = res.intersection(&pers).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.intersection(&pers).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ds_helper.rs:155:40 [INFO] [stdout] | [INFO] [stdout] 155 | res = res.intersection(&pers).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^ help: change this to: `pers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/ds_helper.rs:174:11 [INFO] [stdout] | [INFO] [stdout] 174 | res = res.difference(¬_interesting).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.difference(¬_interesting).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/ds_helper.rs:192:31 [INFO] [stdout] | [INFO] [stdout] 192 | res = res.intersection(&z3_table_possible_periods(p, r2 as usize)).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.intersection(&z3_table_possible_periods(p, r2 as usize)).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ds_helper.rs:192:48 [INFO] [stdout] | [INFO] [stdout] 192 | res = res.intersection(&z3_table_possible_periods(p, r2 as usize)).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `z3_table_possible_periods(p, r2 as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/ds_helper.rs:199:27 [INFO] [stdout] | [INFO] [stdout] 199 | res = res.intersection(&z3_table_possible_periods(p, r1 as usize)).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.intersection(&z3_table_possible_periods(p, r1 as usize)).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ds_helper.rs:199:44 [INFO] [stdout] | [INFO] [stdout] 199 | res = res.intersection(&z3_table_possible_periods(p, r1 as usize)).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `z3_table_possible_periods(p, r1 as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/ds_helper.rs:202:27 [INFO] [stdout] | [INFO] [stdout] 202 | res = res.intersection(&z3_table_possible_periods(p, r2 as usize)).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.intersection(&z3_table_possible_periods(p, r2 as usize)).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ds_helper.rs:202:44 [INFO] [stdout] | [INFO] [stdout] 202 | res = res.intersection(&z3_table_possible_periods(p, r2 as usize)).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `z3_table_possible_periods(p, r2 as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/ds_helper.rs:222:11 [INFO] [stdout] | [INFO] [stdout] 222 | res = res.difference(¬_interesting).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.difference(¬_interesting).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 165 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 165 - return true; [INFO] [stdout] 165 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/util.rs:230:45 [INFO] [stdout] | [INFO] [stdout] 230 | if self.a.abs() == 1 && self.b == 0 { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 231 | | true [INFO] [stdout] 232 | | } else if self.b.abs() == 1 && self.a == 0 { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/util.rs:232:52 [INFO] [stdout] | [INFO] [stdout] 232 | } else if self.b.abs() == 1 && self.a == 0 { [INFO] [stdout] | ____________________________________________________^ [INFO] [stdout] 233 | | true [INFO] [stdout] 234 | | } else if self.a == -1 && self.b == -1 { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/util.rs:232:52 [INFO] [stdout] | [INFO] [stdout] 232 | } else if self.b.abs() == 1 && self.a == 0 { [INFO] [stdout] | ____________________________________________________^ [INFO] [stdout] 233 | | true [INFO] [stdout] 234 | | } else if self.a == -1 && self.b == -1 { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/util.rs:234:48 [INFO] [stdout] | [INFO] [stdout] 234 | } else if self.a == -1 && self.b == -1 { [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 235 | | true [INFO] [stdout] 236 | | } else { [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/util.rs:234:16 [INFO] [stdout] | [INFO] [stdout] 234 | } else if self.a == -1 && self.b == -1 { [INFO] [stdout] | ________________^ [INFO] [stdout] 235 | | true [INFO] [stdout] 236 | | } else { [INFO] [stdout] 237 | | false [INFO] [stdout] 238 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `{ self.a == -1 && self.b == -1 }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/ds_helper.rs:24:23 [INFO] [stdout] | [INFO] [stdout] 24 | res = res.intersection(&pers).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.intersection(&pers).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/ds_helper.rs:43:11 [INFO] [stdout] | [INFO] [stdout] 43 | res = res.difference(¬_interesting).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.difference(¬_interesting).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/ds_helper.rs:63:31 [INFO] [stdout] | [INFO] [stdout] 63 | res = res.intersection(&fast_possible_periods(r2)).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.intersection(&fast_possible_periods(r2)).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/ds_helper.rs:70:27 [INFO] [stdout] | [INFO] [stdout] 70 | res = res.intersection(&fast_possible_periods(r1)).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.intersection(&fast_possible_periods(r1)).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/ds_helper.rs:73:27 [INFO] [stdout] | [INFO] [stdout] 73 | res = res.intersection(&fast_possible_periods(r2)).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.intersection(&fast_possible_periods(r2)).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/ds_helper.rs:93:11 [INFO] [stdout] | [INFO] [stdout] 93 | res = res.difference(¬_interesting).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.difference(¬_interesting).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/ds_helper.rs:155:23 [INFO] [stdout] | [INFO] [stdout] 155 | res = res.intersection(&pers).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.intersection(&pers).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ds_helper.rs:155:40 [INFO] [stdout] | [INFO] [stdout] 155 | res = res.intersection(&pers).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^ help: change this to: `pers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/ds_helper.rs:174:11 [INFO] [stdout] | [INFO] [stdout] 174 | res = res.difference(¬_interesting).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.difference(¬_interesting).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/ds_helper.rs:192:31 [INFO] [stdout] | [INFO] [stdout] 192 | res = res.intersection(&z3_table_possible_periods(p, r2 as usize)).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.intersection(&z3_table_possible_periods(p, r2 as usize)).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ds_helper.rs:192:48 [INFO] [stdout] | [INFO] [stdout] 192 | res = res.intersection(&z3_table_possible_periods(p, r2 as usize)).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `z3_table_possible_periods(p, r2 as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/ds_helper.rs:199:27 [INFO] [stdout] | [INFO] [stdout] 199 | res = res.intersection(&z3_table_possible_periods(p, r1 as usize)).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.intersection(&z3_table_possible_periods(p, r1 as usize)).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ds_helper.rs:199:44 [INFO] [stdout] | [INFO] [stdout] 199 | res = res.intersection(&z3_table_possible_periods(p, r1 as usize)).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `z3_table_possible_periods(p, r1 as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/ds_helper.rs:202:27 [INFO] [stdout] | [INFO] [stdout] 202 | res = res.intersection(&z3_table_possible_periods(p, r2 as usize)).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.intersection(&z3_table_possible_periods(p, r2 as usize)).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ds_helper.rs:202:44 [INFO] [stdout] | [INFO] [stdout] 202 | res = res.intersection(&z3_table_possible_periods(p, r2 as usize)).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `z3_table_possible_periods(p, r2 as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/ds_helper.rs:222:11 [INFO] [stdout] | [INFO] [stdout] 222 | res = res.difference(¬_interesting).map(|&x| x).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `res.difference(¬_interesting).copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeInclusive` [INFO] [stdout] --> src/main.rs:165:9 [INFO] [stdout] | [INFO] [stdout] 165 | (-100_000..=100_000i64).into_iter().for_each(|a| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(-100_000..=100_000i64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:262:21 [INFO] [stdout] | [INFO] [stdout] 262 | assert!(!res.is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `res.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeInclusive` [INFO] [stdout] --> src/main.rs:335:13 [INFO] [stdout] | [INFO] [stdout] 335 | (-3_000..=3_000i64).into_iter().for_each(|a| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(-3_000..=3_000i64)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.73s [INFO] running `Command { std: "docker" "inspect" "971410efd30373fd2c7a32345f4d2d74ddb6aa499c6481914fc7dc5231ee167e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "971410efd30373fd2c7a32345f4d2d74ddb6aa499c6481914fc7dc5231ee167e", kill_on_drop: false }` [INFO] [stdout] 971410efd30373fd2c7a32345f4d2d74ddb6aa499c6481914fc7dc5231ee167e