[INFO] cloning repository https://github.com/TorBorge/simple-blockchain [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TorBorge/simple-blockchain" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTorBorge%2Fsimple-blockchain", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTorBorge%2Fsimple-blockchain'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 112083aa54826188ff8b743bead389de437077b3 [INFO] linting TorBorge/simple-blockchain against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTorBorge%2Fsimple-blockchain" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/TorBorge/simple-blockchain [INFO] finished tweaking git repo https://github.com/TorBorge/simple-blockchain [INFO] tweaked toml for git repo https://github.com/TorBorge/simple-blockchain written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/TorBorge/simple-blockchain on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/TorBorge/simple-blockchain already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded base64ct v1.8.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 17afeffba3b33dab955f52ff18fe19d1101ec4b4111b9e983625b894ccdb7f1a [INFO] running `Command { std: "docker" "start" "-a" "17afeffba3b33dab955f52ff18fe19d1101ec4b4111b9e983625b894ccdb7f1a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "17afeffba3b33dab955f52ff18fe19d1101ec4b4111b9e983625b894ccdb7f1a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "17afeffba3b33dab955f52ff18fe19d1101ec4b4111b9e983625b894ccdb7f1a", kill_on_drop: false }` [INFO] [stdout] 17afeffba3b33dab955f52ff18fe19d1101ec4b4111b9e983625b894ccdb7f1a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4e4bc964aa29d84e86ae52f5a056f90ffcf8c82c1681798aae763b6f42d2a1ca [INFO] running `Command { std: "docker" "start" "-a" "4e4bc964aa29d84e86ae52f5a056f90ffcf8c82c1681798aae763b6f42d2a1ca", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling semver v1.0.27 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Compiling curve25519-dalek v4.1.3 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking serde_bytes v0.11.19 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling curve25519-dalek-derive v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking ed25519 v2.2.3 [INFO] [stderr] Checking bcs v0.1.6 [INFO] [stderr] Checking ed25519-dalek v2.2.0 [INFO] [stderr] Checking simple_blockchain v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/node/mempool.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | txn: txn, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `txn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cur_block` [INFO] [stdout] --> src/chain/block.rs:43:17 [INFO] [stdout] | [INFO] [stdout] 43 | cur_block, [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `cur_block: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `prev_block` [INFO] [stdout] --> src/chain/block.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | prev_block, [INFO] [stdout] | ^^^^^^^^^^ help: try ignoring the field: `prev_block: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cur_block` [INFO] [stdout] --> src/chain/block.rs:47:17 [INFO] [stdout] | [INFO] [stdout] 47 | cur_block, [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `cur_block: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `prev_block` [INFO] [stdout] --> src/chain/block.rs:48:17 [INFO] [stdout] | [INFO] [stdout] 48 | prev_block, [INFO] [stdout] | ^^^^^^^^^^ help: try ignoring the field: `prev_block: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/chain/block.rs:72:25 [INFO] [stdout] | [INFO] [stdout] 72 | let timestamp = SystemTime::now() [INFO] [stdout] | _________________________^ [INFO] [stdout] 73 | | .duration_since(UNIX_EPOCH) [INFO] [stdout] 74 | | .unwrap() [INFO] [stdout] 75 | | .as_secs() as u64; [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 72 ~ let timestamp = SystemTime::now() [INFO] [stdout] 73 + .duration_since(UNIX_EPOCH) [INFO] [stdout] 74 + .unwrap() [INFO] [stdout] 75 ~ .as_secs(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/chain/block.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | / if let Some(ref prev_block) = self.prev_block { [INFO] [stdout] 177 | | if self.timestamp() < prev_block.timestamp() { [INFO] [stdout] 178 | | return Err(ValidationError::TimeDescrepency { [INFO] [stdout] 179 | | cur_block: UNIX_EPOCH [INFO] [stdout] ... | [INFO] [stdout] 187 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 176 ~ if let Some(ref prev_block) = self.prev_block [INFO] [stdout] 177 ~ && self.timestamp() < prev_block.timestamp() { [INFO] [stdout] 178 | return Err(ValidationError::TimeDescrepency { [INFO] [stdout] ... [INFO] [stdout] 185 | }); [INFO] [stdout] 186 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/chain/block.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 191 | / if let Some(ref prev_block) = self.prev_block { [INFO] [stdout] 192 | | if self.headers.prev_hash != prev_block.block_hash { [INFO] [stdout] 193 | | return Err(ValidationError::PrevBlockHash { [INFO] [stdout] 194 | | cur_block: self.headers.prev_hash.clone(), [INFO] [stdout] ... | [INFO] [stdout] 198 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 191 ~ if let Some(ref prev_block) = self.prev_block [INFO] [stdout] 192 ~ && self.headers.prev_hash != prev_block.block_hash { [INFO] [stdout] 193 | return Err(ValidationError::PrevBlockHash { [INFO] [stdout] ... [INFO] [stdout] 196 | }); [INFO] [stdout] 197 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/chain/block.rs:202:25 [INFO] [stdout] | [INFO] [stdout] 202 | let validators: [fn(&Block) -> Result<(), ValidationError>; 4] = [ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `map` over `inspect` [INFO] [stdout] --> src/chain/block.rs:230:19 [INFO] [stdout] | [INFO] [stdout] 230 | self.next.map(|block| { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect [INFO] [stdout] = note: `#[warn(clippy::manual_inspect)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 230 ~ self.next.inspect(|block| { [INFO] [stdout] 231 ~ self.next = block.prev_block.as_deref(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/chain/mod.rs:30:16 [INFO] [stdout] | [INFO] [stdout] 30 | if !block.validate_block().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `block.validate_block().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/util/hash.rs:21:35 [INFO] [stdout] | [INFO] [stdout] 21 | let hash = Sha256::digest(&bytes); [INFO] [stdout] | ^^^^^^ help: change this to: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/util/transaction.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | / pub fn new( [INFO] [stdout] 42 | | sender_pub_key: VerifyingKey, [INFO] [stdout] 43 | | recipient: Address, [INFO] [stdout] 44 | | data: Payload, [INFO] [stdout] ... | [INFO] [stdout] 49 | | fee: std::num::NonZeroU64, [INFO] [stdout] 50 | | ) -> Self { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/wallet/mod.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / pub fn create_transaction( [INFO] [stdout] 24 | | &self, [INFO] [stdout] 25 | | recipient: Address, [INFO] [stdout] 26 | | data: Payload, [INFO] [stdout] ... | [INFO] [stdout] 31 | | fee: std::num::NonZeroU64, [INFO] [stdout] 32 | | ) -> Transaction { [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/node/mempool.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | txn: txn, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `txn` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cur_block` [INFO] [stdout] --> src/chain/block.rs:43:17 [INFO] [stdout] | [INFO] [stdout] 43 | cur_block, [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `cur_block: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `prev_block` [INFO] [stdout] --> src/chain/block.rs:44:17 [INFO] [stdout] | [INFO] [stdout] 44 | prev_block, [INFO] [stdout] | ^^^^^^^^^^ help: try ignoring the field: `prev_block: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cur_block` [INFO] [stdout] --> src/chain/block.rs:47:17 [INFO] [stdout] | [INFO] [stdout] 47 | cur_block, [INFO] [stdout] | ^^^^^^^^^ help: try ignoring the field: `cur_block: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `prev_block` [INFO] [stdout] --> src/chain/block.rs:48:17 [INFO] [stdout] | [INFO] [stdout] 48 | prev_block, [INFO] [stdout] | ^^^^^^^^^^ help: try ignoring the field: `prev_block: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u64` -> `u64`) [INFO] [stdout] --> src/chain/block.rs:72:25 [INFO] [stdout] | [INFO] [stdout] 72 | let timestamp = SystemTime::now() [INFO] [stdout] | _________________________^ [INFO] [stdout] 73 | | .duration_since(UNIX_EPOCH) [INFO] [stdout] 74 | | .unwrap() [INFO] [stdout] 75 | | .as_secs() as u64; [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 72 ~ let timestamp = SystemTime::now() [INFO] [stdout] 73 + .duration_since(UNIX_EPOCH) [INFO] [stdout] 74 + .unwrap() [INFO] [stdout] 75 ~ .as_secs(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/chain/block.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | / if let Some(ref prev_block) = self.prev_block { [INFO] [stdout] 177 | | if self.timestamp() < prev_block.timestamp() { [INFO] [stdout] 178 | | return Err(ValidationError::TimeDescrepency { [INFO] [stdout] 179 | | cur_block: UNIX_EPOCH [INFO] [stdout] ... | [INFO] [stdout] 187 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 176 ~ if let Some(ref prev_block) = self.prev_block [INFO] [stdout] 177 ~ && self.timestamp() < prev_block.timestamp() { [INFO] [stdout] 178 | return Err(ValidationError::TimeDescrepency { [INFO] [stdout] ... [INFO] [stdout] 185 | }); [INFO] [stdout] 186 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/chain/block.rs:191:9 [INFO] [stdout] | [INFO] [stdout] 191 | / if let Some(ref prev_block) = self.prev_block { [INFO] [stdout] 192 | | if self.headers.prev_hash != prev_block.block_hash { [INFO] [stdout] 193 | | return Err(ValidationError::PrevBlockHash { [INFO] [stdout] 194 | | cur_block: self.headers.prev_hash.clone(), [INFO] [stdout] ... | [INFO] [stdout] 198 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 191 ~ if let Some(ref prev_block) = self.prev_block [INFO] [stdout] 192 ~ && self.headers.prev_hash != prev_block.block_hash { [INFO] [stdout] 193 | return Err(ValidationError::PrevBlockHash { [INFO] [stdout] ... [INFO] [stdout] 196 | }); [INFO] [stdout] 197 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/chain/block.rs:202:25 [INFO] [stdout] | [INFO] [stdout] 202 | let validators: [fn(&Block) -> Result<(), ValidationError>; 4] = [ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `map` over `inspect` [INFO] [stdout] --> src/chain/block.rs:230:19 [INFO] [stdout] | [INFO] [stdout] 230 | self.next.map(|block| { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_inspect [INFO] [stdout] = note: `#[warn(clippy::manual_inspect)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 230 ~ self.next.inspect(|block| { [INFO] [stdout] 231 ~ self.next = block.prev_block.as_deref(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/chain/mod.rs:30:16 [INFO] [stdout] | [INFO] [stdout] 30 | if !block.validate_block().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `block.validate_block().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/util/hash.rs:21:35 [INFO] [stdout] | [INFO] [stdout] 21 | let hash = Sha256::digest(&bytes); [INFO] [stdout] | ^^^^^^ help: change this to: `bytes` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/util/transaction.rs:41:5 [INFO] [stdout] | [INFO] [stdout] 41 | / pub fn new( [INFO] [stdout] 42 | | sender_pub_key: VerifyingKey, [INFO] [stdout] 43 | | recipient: Address, [INFO] [stdout] 44 | | data: Payload, [INFO] [stdout] ... | [INFO] [stdout] 49 | | fee: std::num::NonZeroU64, [INFO] [stdout] 50 | | ) -> Self { [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/wallet/mod.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | / pub fn create_transaction( [INFO] [stdout] 24 | | &self, [INFO] [stdout] 25 | | recipient: Address, [INFO] [stdout] 26 | | data: Payload, [INFO] [stdout] ... | [INFO] [stdout] 31 | | fee: std::num::NonZeroU64, [INFO] [stdout] 32 | | ) -> Transaction { [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 20.17s [INFO] running `Command { std: "docker" "inspect" "4e4bc964aa29d84e86ae52f5a056f90ffcf8c82c1681798aae763b6f42d2a1ca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4e4bc964aa29d84e86ae52f5a056f90ffcf8c82c1681798aae763b6f42d2a1ca", kill_on_drop: false }` [INFO] [stdout] 4e4bc964aa29d84e86ae52f5a056f90ffcf8c82c1681798aae763b6f42d2a1ca