[INFO] cloning repository https://github.com/ToposInstitute/oneml [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ToposInstitute/oneml" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FToposInstitute%2Foneml", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FToposInstitute%2Foneml'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 02c33fa38327c0711e3dc6d00aeeb790e0c496e9 [INFO] linting ToposInstitute/oneml against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FToposInstitute%2Foneml" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ToposInstitute/oneml [INFO] finished tweaking git repo https://github.com/ToposInstitute/oneml [INFO] tweaked toml for git repo https://github.com/ToposInstitute/oneml written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ToposInstitute/oneml on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ToposInstitute/oneml already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded notify-types v2.1.0 [INFO] [stderr] Downloaded bwd v0.2.1 [INFO] [stderr] Downloaded fnotation v0.8.1 [INFO] [stderr] Downloaded indoc v2.0.7 [INFO] [stderr] Downloaded zerocopy-derive v0.8.39 [INFO] [stderr] Downloaded clap v4.5.60 [INFO] [stderr] Downloaded notify v8.2.0 [INFO] [stderr] Downloaded bitflags v2.11.0 [INFO] [stderr] Downloaded kqueue v1.1.1 [INFO] [stderr] Downloaded file-id v0.2.3 [INFO] [stderr] Downloaded tattle v0.4.3 [INFO] [stderr] Downloaded notify-debouncer-full v0.6.0 [INFO] [stderr] Downloaded pretty v0.12.5 [INFO] [stderr] Downloaded bumpalo v3.20.2 [INFO] [stderr] Downloaded zerocopy v0.8.39 [INFO] [stderr] Downloaded ustr v1.1.0 [INFO] [stderr] Downloaded clap_builder v4.5.60 [INFO] [stderr] Downloaded libc v0.2.182 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9ce2b7ca3ce72a981b6217d66e7d1b06bc67220149a624041dcb5efcb93b5800 [INFO] running `Command { std: "docker" "start" "-a" "9ce2b7ca3ce72a981b6217d66e7d1b06bc67220149a624041dcb5efcb93b5800", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9ce2b7ca3ce72a981b6217d66e7d1b06bc67220149a624041dcb5efcb93b5800", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9ce2b7ca3ce72a981b6217d66e7d1b06bc67220149a624041dcb5efcb93b5800", kill_on_drop: false }` [INFO] [stdout] 9ce2b7ca3ce72a981b6217d66e7d1b06bc67220149a624041dcb5efcb93b5800 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 424061ffe43cd481329a96324d9f6f90e6c0a808734bb19ee3bb79a51ee93f84 [INFO] running `Command { std: "docker" "start" "-a" "424061ffe43cd481329a96324d9f6f90e6c0a808734bb19ee3bb79a51ee93f84", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling unicode-ident v1.0.24 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Compiling zerocopy v0.8.39 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Checking is_terminal_polyfill v1.70.2 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Checking clap_lex v1.0.0 [INFO] [stderr] Checking pretty v0.12.5 [INFO] [stderr] Checking lock_api v0.4.14 [INFO] [stderr] Compiling indoc v2.0.7 [INFO] [stderr] Checking bumpalo v3.20.2 [INFO] [stderr] Checking file-id v0.2.3 [INFO] [stderr] Checking notify-types v2.1.0 [INFO] [stderr] Checking bwd v0.2.1 [INFO] [stderr] Checking tattle v0.4.3 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking clap_builder v4.5.60 [INFO] [stderr] Checking fnotation v0.8.1 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking inotify v0.11.0 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking notify v8.2.0 [INFO] [stderr] Checking notify-debouncer-full v0.6.0 [INFO] [stderr] Checking ustr v1.1.0 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Checking oneml v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: useless conversion to the same type: `usize` [INFO] [stdout] --> src/elab.rs:158:13 [INFO] [stdout] | [INFO] [stdout] 158 | self.ctx.scope.len().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.ctx.scope.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `idx::FwdIdx` [INFO] [stdout] --> src/elab.rs:225:61 [INFO] [stdout] | [INFO] [stdout] 225 | TopDecl::Type(_, ty_v) => Some((TyS::TopVar(i.into(), name), *ty_v)), [INFO] [stdout] | ^^^^^^^^ help: consider removing `.into()`: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `idx::FwdIdx` [INFO] [stdout] --> src/elab.rs:227:53 [INFO] [stdout] | [INFO] [stdout] 227 | TyS::Elt(self.alloc(TmS::TopVar(i.into(), name))), [INFO] [stdout] | ^^^^^^^^ help: consider removing `.into()`: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/elab.rs:517:25 [INFO] [stdout] | [INFO] [stdout] 517 | return elab.error("can only apply element of pi or arrow type"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 517 - return elab.error("can only apply element of pi or arrow type"); [INFO] [stdout] 517 + elab.error("can only apply element of pi or arrow type") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/elab.rs:560:20 [INFO] [stdout] | [INFO] [stdout] 560 | if !(fields.len() == r.fields1.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(fields.len() != r.fields1.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/elab.rs:623:22 [INFO] [stdout] | [INFO] [stdout] 623 | _ => return elab.error("can only check lambda against pi or arrow type"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 623 - _ => return elab.error("can only check lambda against pi or arrow type"), [INFO] [stdout] 623 + _ => elab.error("can only check lambda against pi or arrow type"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/elab.rs:590:75 [INFO] [stdout] | [INFO] [stdout] 590 | let (field_val_s, field_val_v) = elab.chk(field_ty_v, *field_val_n)?; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `field_val_n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `usize` [INFO] [stdout] --> src/elab.rs:158:13 [INFO] [stdout] | [INFO] [stdout] 158 | self.ctx.scope.len().into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `self.ctx.scope.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `idx::FwdIdx` [INFO] [stdout] --> src/elab.rs:225:61 [INFO] [stdout] | [INFO] [stdout] 225 | TopDecl::Type(_, ty_v) => Some((TyS::TopVar(i.into(), name), *ty_v)), [INFO] [stdout] | ^^^^^^^^ help: consider removing `.into()`: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `idx::FwdIdx` [INFO] [stdout] --> src/elab.rs:227:53 [INFO] [stdout] | [INFO] [stdout] 227 | TyS::Elt(self.alloc(TmS::TopVar(i.into(), name))), [INFO] [stdout] | ^^^^^^^^ help: consider removing `.into()`: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/elab.rs:517:25 [INFO] [stdout] | [INFO] [stdout] 517 | return elab.error("can only apply element of pi or arrow type"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 517 - return elab.error("can only apply element of pi or arrow type"); [INFO] [stdout] 517 + elab.error("can only apply element of pi or arrow type") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/idx.rs:25:19 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn to_bwd(&self, scope_length: usize) -> BwdIdx { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/elab.rs:560:20 [INFO] [stdout] | [INFO] [stdout] 560 | if !(fields.len() == r.fields1.len()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(fields.len() != r.fields1.len())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/elab.rs:623:22 [INFO] [stdout] | [INFO] [stdout] 623 | _ => return elab.error("can only check lambda against pi or arrow type"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 623 - _ => return elab.error("can only check lambda against pi or arrow type"), [INFO] [stdout] 623 + _ => elab.error("can only check lambda against pi or arrow type"), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/elab.rs:590:75 [INFO] [stdout] | [INFO] [stdout] 590 | let (field_val_s, field_val_v) = elab.chk(field_ty_v, *field_val_n)?; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `field_val_n` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/stx.rs:67:15 [INFO] [stdout] | [INFO] [stdout] 67 | fn to_doc(&self) -> D<'a> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/stx.rs:117:15 [INFO] [stdout] | [INFO] [stdout] 117 | fn to_doc(&self) -> D<'a> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/stx.rs:145:25 [INFO] [stdout] | [INFO] [stdout] 145 | + tuple([then.to_doc(), else_.to_doc()].into_iter())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/pretty.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn tuple<'a, I: IntoIterator>>(i: I) -> D<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 145 - + tuple([then.to_doc(), else_.to_doc()].into_iter())) [INFO] [stdout] 145 + + tuple([then.to_doc(), else_.to_doc()])) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/stx.rs:151:25 [INFO] [stdout] | [INFO] [stdout] 151 | + tuple([some.to_doc(), none.to_doc()].into_iter())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/pretty.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn tuple<'a, I: IntoIterator>>(i: I) -> D<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 151 - + tuple([some.to_doc(), none.to_doc()].into_iter())) [INFO] [stdout] 151 + + tuple([some.to_doc(), none.to_doc()])) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:62:40 [INFO] [stdout] | [INFO] [stdout] 62 | let src = match fs::read_to_string(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:87:17 [INFO] [stdout] | [INFO] [stdout] 87 | / match annot.ast0() { [INFO] [stdout] 88 | | fnotation::Var("should_fail") => { [INFO] [stdout] 89 | | should_fail = true; [INFO] [stdout] ... | [INFO] [stdout] 92 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 87 ~ if let fnotation::Var("should_fail") = annot.ast0() { [INFO] [stdout] 88 + should_fail = true; [INFO] [stdout] 89 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/idx.rs:25:19 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn to_bwd(&self, scope_length: usize) -> BwdIdx { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:166:25 [INFO] [stdout] | [INFO] [stdout] 166 | / match e.kind { [INFO] [stdout] 167 | | notify::EventKind::Modify(_modify_kind) => { [INFO] [stdout] 168 | | modified = true; [INFO] [stdout] ... | [INFO] [stdout] 171 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 166 ~ if let notify::EventKind::Modify(_modify_kind) = e.kind { [INFO] [stdout] 167 + modified = true; [INFO] [stdout] 168 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/stx.rs:67:15 [INFO] [stdout] | [INFO] [stdout] 67 | fn to_doc(&self) -> D<'a> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/stx.rs:117:15 [INFO] [stdout] | [INFO] [stdout] 117 | fn to_doc(&self) -> D<'a> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/stx.rs:145:25 [INFO] [stdout] | [INFO] [stdout] 145 | + tuple([then.to_doc(), else_.to_doc()].into_iter())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/pretty.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn tuple<'a, I: IntoIterator>>(i: I) -> D<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 145 - + tuple([then.to_doc(), else_.to_doc()].into_iter())) [INFO] [stdout] 145 + + tuple([then.to_doc(), else_.to_doc()])) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/stx.rs:151:25 [INFO] [stdout] | [INFO] [stdout] 151 | + tuple([some.to_doc(), none.to_doc()].into_iter())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> src/pretty.rs:27:21 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn tuple<'a, I: IntoIterator>>(i: I) -> D<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 151 - + tuple([some.to_doc(), none.to_doc()].into_iter())) [INFO] [stdout] 151 + + tuple([some.to_doc(), none.to_doc()])) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:62:40 [INFO] [stdout] | [INFO] [stdout] 62 | let src = match fs::read_to_string(&path) { [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:87:17 [INFO] [stdout] | [INFO] [stdout] 87 | / match annot.ast0() { [INFO] [stdout] 88 | | fnotation::Var("should_fail") => { [INFO] [stdout] 89 | | should_fail = true; [INFO] [stdout] ... | [INFO] [stdout] 92 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 87 ~ if let fnotation::Var("should_fail") = annot.ast0() { [INFO] [stdout] 88 + should_fail = true; [INFO] [stdout] 89 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:166:25 [INFO] [stdout] | [INFO] [stdout] 166 | / match e.kind { [INFO] [stdout] 167 | | notify::EventKind::Modify(_modify_kind) => { [INFO] [stdout] 168 | | modified = true; [INFO] [stdout] ... | [INFO] [stdout] 171 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 166 ~ if let notify::EventKind::Modify(_modify_kind) = e.kind { [INFO] [stdout] 167 + modified = true; [INFO] [stdout] 168 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.76s [INFO] running `Command { std: "docker" "inspect" "424061ffe43cd481329a96324d9f6f90e6c0a808734bb19ee3bb79a51ee93f84", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "424061ffe43cd481329a96324d9f6f90e6c0a808734bb19ee3bb79a51ee93f84", kill_on_drop: false }` [INFO] [stdout] 424061ffe43cd481329a96324d9f6f90e6c0a808734bb19ee3bb79a51ee93f84