[INFO] cloning repository https://github.com/Tomyyy-1337/snake [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Tomyyy-1337/snake" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTomyyy-1337%2Fsnake", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTomyyy-1337%2Fsnake'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 74fe46e58603e29dbde4b6f385cc7db83b57dd20 [INFO] linting Tomyyy-1337/snake against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTomyyy-1337%2Fsnake" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Tomyyy-1337/snake [INFO] finished tweaking git repo https://github.com/Tomyyy-1337/snake [INFO] tweaked toml for git repo https://github.com/Tomyyy-1337/snake written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Tomyyy-1337/snake on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Tomyyy-1337/snake already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded nannou_wgpu v0.19.0 [INFO] [stderr] Downloaded lyon v0.17.10 [INFO] [stderr] Downloaded pennereq v0.3.1 [INFO] [stderr] Downloaded find_folder v0.3.0 [INFO] [stderr] Downloaded palette_derive v0.5.0 [INFO] [stderr] Downloaded float_next_after v0.1.5 [INFO] [stderr] Downloaded lyon_path v0.17.7 [INFO] [stderr] Downloaded nannou_core v0.19.0 [INFO] [stderr] Downloaded lyon_algorithms v0.17.7 [INFO] [stderr] Downloaded lyon_geom v0.17.7 [INFO] [stderr] Downloaded palette v0.5.0 [INFO] [stderr] Downloaded nannou_mesh v0.19.0 [INFO] [stderr] Downloaded euclid v0.22.10 [INFO] [stderr] Downloaded nannou v0.19.0 [INFO] [stderr] Downloaded lyon_tessellation v0.17.10 [INFO] [stderr] Downloaded notosans v0.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b933dd4a9c630fdf69a608c721f06a88087f92afb2e8755007d3dbfeef87a4fc [INFO] running `Command { std: "docker" "start" "-a" "b933dd4a9c630fdf69a608c721f06a88087f92afb2e8755007d3dbfeef87a4fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b933dd4a9c630fdf69a608c721f06a88087f92afb2e8755007d3dbfeef87a4fc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b933dd4a9c630fdf69a608c721f06a88087f92afb2e8755007d3dbfeef87a4fc", kill_on_drop: false }` [INFO] [stdout] b933dd4a9c630fdf69a608c721f06a88087f92afb2e8755007d3dbfeef87a4fc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 072fd5db9b1d95887b30cb53f241ba9343c1f80818706b71fb91126a9cd63b6c [INFO] running `Command { std: "docker" "start" "-a" "072fd5db9b1d95887b30cb53f241ba9343c1f80818706b71fb91126a9cd63b6c", kill_on_drop: false }` [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling zerocopy-derive v0.6.6 [INFO] [stderr] Compiling wayland-sys v0.29.5 [INFO] [stderr] Compiling wayland-scanner v0.29.5 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking bytemuck v1.16.3 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Checking gpu-alloc-types v0.3.0 [INFO] [stderr] Checking gpu-descriptor-types v0.1.2 [INFO] [stderr] Checking spirv v0.2.0+1.5.4 [INFO] [stderr] Checking euclid v0.22.10 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking gpu-alloc v0.6.0 [INFO] [stderr] Checking ash v0.37.3+1.3.251 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking naga v0.13.0 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking khronos-egl v4.1.0 [INFO] [stderr] Checking wgpu-types v0.17.0 [INFO] [stderr] Compiling smithay-client-toolkit v0.16.1 [INFO] [stderr] Checking zerocopy v0.6.6 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling palette v0.5.0 [INFO] [stderr] Checking profiling v1.0.15 [INFO] [stderr] Checking tiny-skia-path v0.8.4 [INFO] [stderr] Checking gif v0.11.4 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking ppv-lite86 v0.2.18 [INFO] [stderr] Checking gpu-descriptor v0.2.4 [INFO] [stderr] Checking lyon_geom v0.17.7 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking float_next_after v0.1.5 [INFO] [stderr] Compiling wayland-client v0.29.5 [INFO] [stderr] Compiling wayland-protocols v0.29.5 [INFO] [stderr] Compiling winit v0.28.7 [INFO] [stderr] Checking tiny-skia v0.8.4 [INFO] [stderr] Checking sid v0.6.1 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking lyon_path v0.17.7 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking calloop v0.10.6 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking wayland-commons v0.29.5 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling portable-atomic v1.7.0 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking crossbeam-deque v0.7.4 [INFO] [stderr] Checking lyon_tessellation v0.17.10 [INFO] [stderr] Checking lyon_algorithms v0.17.7 [INFO] [stderr] Checking rand_xorshift v0.2.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking ordered-float v1.1.1 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking rusttype v0.8.3 [INFO] [stderr] Checking pennereq v0.3.1 [INFO] [stderr] Checking lyon v0.17.10 [INFO] [stderr] Checking find_folder v0.3.0 [INFO] [stderr] Checking notosans v0.1.0 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Compiling palette_derive v0.5.0 [INFO] [stderr] Checking serde v1.0.204 [INFO] [stderr] Checking wayland-cursor v0.29.5 [INFO] [stderr] Checking noise v0.7.0 [INFO] [stderr] Checking glam v0.17.3 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking serde_json v1.0.122 [INFO] [stderr] Checking nannou_core v0.19.0 [INFO] [stderr] Checking nannou_mesh v0.19.0 [INFO] [stderr] Checking wgpu-hal v0.17.2 [INFO] [stderr] Checking wgpu-core v0.17.1 [INFO] [stderr] Checking wgpu v0.17.2 [INFO] [stderr] Checking nannou_wgpu v0.19.0 [INFO] [stderr] Checking sctk-adwaita v0.5.4 [INFO] [stderr] Checking nannou v0.19.0 [INFO] [stderr] Checking snake v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/main.rs:3:48 [INFO] [stdout] | [INFO] [stdout] 3 | use nannou::{event::Update, glam::Vec2, rand::{self, thread_rng, Rng}, time::DurationF64, App, Frame}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/main.rs:3:48 [INFO] [stdout] | [INFO] [stdout] 3 | use nannou::{event::Update, glam::Vec2, rand::{self, thread_rng, Rng}, time::DurationF64, App, Frame}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f32` is unnecessary [INFO] [stdout] --> src/main.rs:53:31 [INFO] [stdout] | [INFO] [stdout] 53 | let step_time = 1.0 / 90 as f32 / model.speed; [INFO] [stdout] | ^^^^^^^^^ help: try: `90_f32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | / if model.speed < 1.0 { [INFO] [stdout] 57 | | if model.timer < step_time { [INFO] [stdout] 58 | | return; [INFO] [stdout] 59 | | } [INFO] [stdout] 60 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 56 ~ if model.speed < 1.0 [INFO] [stdout] 57 ~ && model.timer < step_time { [INFO] [stdout] 58 | return; [INFO] [stdout] 59 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 62 | if model.snake.body.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `model.snake.body.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/main.rs:147:25 [INFO] [stdout] | [INFO] [stdout] 147 | let size_mult = (model.snake.body.len() as f32 / 200.0).max(0.6).min(0.87); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `(model.snake.body.len() as f32 / 200.0).clamp(0.6, 0.87)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/main.rs:148:21 [INFO] [stdout] | [INFO] [stdout] 148 | for i in 0..model.snake.body.len() as usize - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `model.snake.body.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:331:25 [INFO] [stdout] | [INFO] [stdout] 331 | return Direction::Right; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 331 - return Direction::Right; [INFO] [stdout] 331 + Direction::Right [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:333:25 [INFO] [stdout] | [INFO] [stdout] 333 | return Direction::Down; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 333 - return Direction::Down; [INFO] [stdout] 333 + Direction::Down [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:337:25 [INFO] [stdout] | [INFO] [stdout] 337 | return Direction::Right; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 337 - return Direction::Right; [INFO] [stdout] 337 + Direction::Right [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:339:25 [INFO] [stdout] | [INFO] [stdout] 339 | return Direction::Up; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 339 - return Direction::Up; [INFO] [stdout] 339 + Direction::Up [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:466:20 [INFO] [stdout] | [INFO] [stdout] 466 | if !self.body.contains(&(random_x, random_y)) && !(random_x == x && random_y == y) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(self.body.contains(&(random_x, random_y)) || random_x == x && random_y == y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:452:12 [INFO] [stdout] | [INFO] [stdout] 452 | ... if self.body.len() == 0 || self.body.len() as i32 == (self.borders.2 - self.borders.0 - 2) * (self.borders.3 - self.borders.1... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.body.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `f32` is unnecessary [INFO] [stdout] --> src/main.rs:53:31 [INFO] [stdout] | [INFO] [stdout] 53 | let step_time = 1.0 / 90 as f32 / model.speed; [INFO] [stdout] | ^^^^^^^^^ help: try: `90_f32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | / if model.speed < 1.0 { [INFO] [stdout] 57 | | if model.timer < step_time { [INFO] [stdout] 58 | | return; [INFO] [stdout] 59 | | } [INFO] [stdout] 60 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 56 ~ if model.speed < 1.0 [INFO] [stdout] 57 ~ && model.timer < step_time { [INFO] [stdout] 58 | return; [INFO] [stdout] 59 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 62 | if model.snake.body.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `model.snake.body.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/main.rs:147:25 [INFO] [stdout] | [INFO] [stdout] 147 | let size_mult = (model.snake.body.len() as f32 / 200.0).max(0.6).min(0.87); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `(model.snake.body.len() as f32 / 200.0).clamp(0.6, 0.87)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/main.rs:148:21 [INFO] [stdout] | [INFO] [stdout] 148 | for i in 0..model.snake.body.len() as usize - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `model.snake.body.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:331:25 [INFO] [stdout] | [INFO] [stdout] 331 | return Direction::Right; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 331 - return Direction::Right; [INFO] [stdout] 331 + Direction::Right [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:333:25 [INFO] [stdout] | [INFO] [stdout] 333 | return Direction::Down; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 333 - return Direction::Down; [INFO] [stdout] 333 + Direction::Down [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:337:25 [INFO] [stdout] | [INFO] [stdout] 337 | return Direction::Right; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 337 - return Direction::Right; [INFO] [stdout] 337 + Direction::Right [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:339:25 [INFO] [stdout] | [INFO] [stdout] 339 | return Direction::Up; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 339 - return Direction::Up; [INFO] [stdout] 339 + Direction::Up [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:466:20 [INFO] [stdout] | [INFO] [stdout] 466 | if !self.body.contains(&(random_x, random_y)) && !(random_x == x && random_y == y) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(self.body.contains(&(random_x, random_y)) || random_x == x && random_y == y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:452:12 [INFO] [stdout] | [INFO] [stdout] 452 | ... if self.body.len() == 0 || self.body.len() as i32 == (self.borders.2 - self.borders.0 - 2) * (self.borders.3 - self.borders.1... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.body.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 54.86s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: noise v0.7.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "072fd5db9b1d95887b30cb53f241ba9343c1f80818706b71fb91126a9cd63b6c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "072fd5db9b1d95887b30cb53f241ba9343c1f80818706b71fb91126a9cd63b6c", kill_on_drop: false }` [INFO] [stdout] 072fd5db9b1d95887b30cb53f241ba9343c1f80818706b71fb91126a9cd63b6c