[INFO] cloning repository https://github.com/TobisMa/AOC2024 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TobisMa/AOC2024" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTobisMa%2FAOC2024", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTobisMa%2FAOC2024'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ee450fb9a7692c49611a4e9ea8dbbc9189aadf5e [INFO] linting TobisMa/AOC2024 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTobisMa%2FAOC2024" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/TobisMa/AOC2024 [INFO] finished tweaking git repo https://github.com/TobisMa/AOC2024 [INFO] tweaked toml for git repo https://github.com/TobisMa/AOC2024 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/TobisMa/AOC2024 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/TobisMa/AOC2024 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 41dc932baa20684882b0b6b0032a4b37c100a900a2db7006ed17fcce8b5aa940 [INFO] running `Command { std: "docker" "start" "-a" "41dc932baa20684882b0b6b0032a4b37c100a900a2db7006ed17fcce8b5aa940", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "41dc932baa20684882b0b6b0032a4b37c100a900a2db7006ed17fcce8b5aa940", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "41dc932baa20684882b0b6b0032a4b37c100a900a2db7006ed17fcce8b5aa940", kill_on_drop: false }` [INFO] [stdout] 41dc932baa20684882b0b6b0032a4b37c100a900a2db7006ed17fcce8b5aa940 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e76de57630d9dbd9695fb79724f48159adf478e716db8308dfa4253b27dd63c2 [INFO] running `Command { std: "docker" "start" "-a" "e76de57630d9dbd9695fb79724f48159adf478e716db8308dfa4253b27dd63c2", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking AOC2024 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::env` [INFO] [stdout] --> src/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::env; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env` [INFO] [stdout] --> src/utility/mod.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::env; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/day01/day01_part1.rs:1:22 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::utility::{self, read_data_file}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/day01/day01_part1.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | if (x.len() == 2) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 10 - if (x.len() == 2) { [INFO] [stdout] 10 + if x.len() == 2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::num` [INFO] [stdout] --> src/day01/day01_part2.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use core::num; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/day01/day01_part2.rs:4:22 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::utility::{self, read_data_file}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/day02/day02_part1.rs:6:12 [INFO] [stdout] | [INFO] [stdout] 6 | if (line.len() <= 2) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 6 - if (line.len() <= 2) { [INFO] [stdout] 6 + if line.len() <= 2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/day02/day02_part2.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | if (line.len() <= 2) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 5 - if (line.len() <= 2) { [INFO] [stdout] 5 + if line.len() <= 2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/day02/day02_part2.rs:15:20 [INFO] [stdout] | [INFO] [stdout] 15 | if (i != j) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 15 - if (i != j) { [INFO] [stdout] 15 + if i != j { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env` [INFO] [stdout] --> src/main.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::env; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::env` [INFO] [stdout] --> src/utility/mod.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::env; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/day01/day01_part1.rs:1:22 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::utility::{self, read_data_file}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/day01/day01_part1.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | if (x.len() == 2) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 10 - if (x.len() == 2) { [INFO] [stdout] 10 + if x.len() == 2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `core::num` [INFO] [stdout] --> src/day01/day01_part2.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use core::num; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/day01/day01_part2.rs:4:22 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::utility::{self, read_data_file}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/day02/day02_part1.rs:6:12 [INFO] [stdout] | [INFO] [stdout] 6 | if (line.len() <= 2) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 6 - if (line.len() <= 2) { [INFO] [stdout] 6 + if line.len() <= 2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/day02/day02_part2.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | if (line.len() <= 2) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 5 - if (line.len() <= 2) { [INFO] [stdout] 5 + if line.len() <= 2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/day02/day02_part2.rs:15:20 [INFO] [stdout] | [INFO] [stdout] 15 | if (i != j) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 15 - if (i != j) { [INFO] [stdout] 15 + if i != j { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `day1` is never used [INFO] [stdout] --> src/main.rs:27:4 [INFO] [stdout] | [INFO] [stdout] 27 | fn day1() { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> src/day01/mod.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn part1() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part2` is never used [INFO] [stdout] --> src/day01/mod.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn part2() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> src/day01/day01_part1.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn part1() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part2` is never used [INFO] [stdout] --> src/day01/day01_part2.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn part2() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> src/day02/mod.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn part1(data: String) -> String { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part2` is never used [INFO] [stdout] --> src/day02/mod.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn part2(data: String) -> String { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> src/day02/day02_part1.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn part1(data: String) -> String { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part2` is never used [INFO] [stdout] --> src/day02/day02_part2.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn part2(data: String) -> String { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `day1` is never used [INFO] [stdout] --> src/main.rs:27:4 [INFO] [stdout] | [INFO] [stdout] 27 | fn day1() { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> src/day01/mod.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn part1() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part2` is never used [INFO] [stdout] --> src/day01/mod.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn part2() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> src/day01/day01_part1.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 3 | pub fn part1() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part2` is never used [INFO] [stdout] --> src/day01/day01_part2.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | pub fn part2() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> src/day02/mod.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | pub fn part1(data: String) -> String { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part2` is never used [INFO] [stdout] --> src/day02/mod.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn part2(data: String) -> String { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part1` is never used [INFO] [stdout] --> src/day02/day02_part1.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn part1(data: String) -> String { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `part2` is never used [INFO] [stdout] --> src/day02/day02_part2.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn part2(data: String) -> String { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/day01/day01_part2.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / if !num_count.contains_key(&x) { [INFO] [stdout] 22 | | num_count.insert(x, 0); [INFO] [stdout] 23 | | } [INFO] [stdout] | |_________^ help: try: `num_count.entry(x).or_insert(0);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day01/mod.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | return day01_part1::part1(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 5 - return day01_part1::part1(); [INFO] [stdout] 5 + day01_part1::part1() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day01/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | return day01_part2::part2(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 - return day01_part2::part2(); [INFO] [stdout] 9 + day01_part2::part2() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day02/day02_part1.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 20 | else if !increase && !(ints[i-1] - ints[i] >= 1 && ints[i-1] - ints[i] <= 3) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(increase || ints[i-1] - ints[i] >= 1 && ints[i-1] - ints[i] <= 3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day02/day02_part1.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | return safe.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return safe.to_string(); [INFO] [stdout] 30 + safe.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day02/day02_part2.rs:27:25 [INFO] [stdout] | [INFO] [stdout] 27 | else if !increase && !(cints[i-1] - cints[i] >= 1 && cints[i-1] - cints[i] <= 3) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(increase || cints[i-1] - cints[i] >= 1 && cints[i-1] - cints[i] <= 3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/day01/day01_part2.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / if !num_count.contains_key(&x) { [INFO] [stdout] 22 | | num_count.insert(x, 0); [INFO] [stdout] 23 | | } [INFO] [stdout] | |_________^ help: try: `num_count.entry(x).or_insert(0);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day01/mod.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | return day01_part1::part1(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 5 - return day01_part1::part1(); [INFO] [stdout] 5 + day01_part1::part1() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day01/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | return day01_part2::part2(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 - return day01_part2::part2(); [INFO] [stdout] 9 + day01_part2::part2() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day02/day02_part1.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 20 | else if !increase && !(ints[i-1] - ints[i] >= 1 && ints[i-1] - ints[i] <= 3) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(increase || ints[i-1] - ints[i] >= 1 && ints[i-1] - ints[i] <= 3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day02/day02_part2.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return safe.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return safe.to_string(); [INFO] [stdout] 39 + safe.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `ints` [INFO] [stdout] --> src/day02/day02_part2.rs:14:22 [INFO] [stdout] | [INFO] [stdout] 14 | for i in 0..ints.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 14 - for i in 0..ints.len() { [INFO] [stdout] 14 + for (i, ) in ints.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day02/day02_part1.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | return safe.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return safe.to_string(); [INFO] [stdout] 30 + safe.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day02/mod.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | return day02_part1::part1(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 5 - return day02_part1::part1(data); [INFO] [stdout] 5 + day02_part1::part1(data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day02/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | return day02_part2::part2(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 - return day02_part2::part2(data); [INFO] [stdout] 9 + day02_part2::part2(data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day03/day03_part1.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return sum.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return sum.to_string(); [INFO] [stdout] 12 + sum.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day02/day02_part2.rs:27:25 [INFO] [stdout] | [INFO] [stdout] 27 | else if !increase && !(cints[i-1] - cints[i] >= 1 && cints[i-1] - cints[i] <= 3) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(increase || cints[i-1] - cints[i] >= 1 && cints[i-1] - cints[i] <= 3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day02/day02_part2.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | return safe.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return safe.to_string(); [INFO] [stdout] 39 + safe.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day03/day03_part2.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | return sum.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return sum.to_string(); [INFO] [stdout] 26 + sum.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `ints` [INFO] [stdout] --> src/day02/day02_part2.rs:14:22 [INFO] [stdout] | [INFO] [stdout] 14 | for i in 0..ints.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 14 - for i in 0..ints.len() { [INFO] [stdout] 14 + for (i, ) in ints.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day03/mod.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | return day03_part1::part1(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 5 - return day03_part1::part1(data); [INFO] [stdout] 5 + day03_part1::part1(data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day03/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | return day03_part2::part2(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 - return day03_part2::part2(data); [INFO] [stdout] 9 + day03_part2::part2(data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day02/mod.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | return day02_part1::part1(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 5 - return day02_part1::part1(data); [INFO] [stdout] 5 + day02_part1::part1(data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day02/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | return day02_part2::part2(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 - return day02_part2::part2(data); [INFO] [stdout] 9 + day02_part2::part2(data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day03/day03_part1.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | return sum.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 12 - return sum.to_string(); [INFO] [stdout] 12 + sum.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day03/day03_part2.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | return sum.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 26 - return sum.to_string(); [INFO] [stdout] 26 + sum.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day03/mod.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | return day03_part1::part1(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 5 - return day03_part1::part1(data); [INFO] [stdout] 5 + day03_part1::part1(data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day03/mod.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | return day03_part2::part2(data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 9 - return day03_part2::part2(data); [INFO] [stdout] 9 + day03_part2::part2(data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `intsS` should have a snake case name [INFO] [stdout] --> src/day02/day02_part1.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | let intsS = line.split_whitespace(); [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `ints_s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `safeB` should have a snake case name [INFO] [stdout] --> src/day02/day02_part1.rs:13:17 [INFO] [stdout] | [INFO] [stdout] 13 | let mut safeB = true; [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `safe_b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `intsS` should have a snake case name [INFO] [stdout] --> src/day02/day02_part2.rs:8:13 [INFO] [stdout] | [INFO] [stdout] 8 | let intsS = line.split_whitespace(); [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `ints_s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `intsS` should have a snake case name [INFO] [stdout] --> src/day02/day02_part1.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | let intsS = line.split_whitespace(); [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `ints_s` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `safeB` should have a snake case name [INFO] [stdout] --> src/day02/day02_part2.rs:10:17 [INFO] [stdout] | [INFO] [stdout] 10 | let mut safeB = true; [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `safe_b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `safeB` should have a snake case name [INFO] [stdout] --> src/day02/day02_part1.rs:13:17 [INFO] [stdout] | [INFO] [stdout] 13 | let mut safeB = true; [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `safe_b` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `intsS` should have a snake case name [INFO] [stdout] --> src/day02/day02_part2.rs:8:13 [INFO] [stdout] | [INFO] [stdout] 8 | let intsS = line.split_whitespace(); [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `ints_s` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `safeB` should have a snake case name [INFO] [stdout] --> src/day02/day02_part2.rs:10:17 [INFO] [stdout] | [INFO] [stdout] 10 | let mut safeB = true; [INFO] [stdout] | ^^^^^ help: convert the identifier to snake case: `safe_b` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.28s [INFO] running `Command { std: "docker" "inspect" "e76de57630d9dbd9695fb79724f48159adf478e716db8308dfa4253b27dd63c2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e76de57630d9dbd9695fb79724f48159adf478e716db8308dfa4253b27dd63c2", kill_on_drop: false }` [INFO] [stdout] e76de57630d9dbd9695fb79724f48159adf478e716db8308dfa4253b27dd63c2