[INFO] cloning repository https://github.com/TobiasFella/Raft [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TobiasFella/Raft" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTobiasFella%2FRaft", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTobiasFella%2FRaft'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1eaa38c930b5824ab521719ff9210eaed88899ef [INFO] linting TobiasFella/Raft against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTobiasFella%2FRaft" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/TobiasFella/Raft [INFO] finished tweaking git repo https://github.com/TobiasFella/Raft [INFO] tweaked toml for git repo https://github.com/TobiasFella/Raft written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/TobiasFella/Raft on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/TobiasFella/Raft already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded cmake v0.1.53 [INFO] [stderr] Downloaded takeable-option v0.5.0 [INFO] [stderr] Downloaded cc v1.2.12 [INFO] [stderr] Downloaded glium v0.32.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6d9010e60522c53c0f0840eee9520a0881c29a2ad01216e9789968a0d9435856 [INFO] running `Command { std: "docker" "start" "-a" "6d9010e60522c53c0f0840eee9520a0881c29a2ad01216e9789968a0d9435856", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6d9010e60522c53c0f0840eee9520a0881c29a2ad01216e9789968a0d9435856", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d9010e60522c53c0f0840eee9520a0881c29a2ad01216e9789968a0d9435856", kill_on_drop: false }` [INFO] [stdout] 6d9010e60522c53c0f0840eee9520a0881c29a2ad01216e9789968a0d9435856 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e90df8278fa9656c12b97a48cab4c66ab3803acb856361b8f8ed88e91eb13409 [INFO] running `Command { std: "docker" "start" "-a" "e90df8278fa9656c12b97a48cab4c66ab3803acb856361b8f8ed88e91eb13409", kill_on_drop: false }` [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Compiling libc v0.2.169 [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Compiling xml-rs v0.8.25 [INFO] [stderr] Compiling unicode-ident v1.0.16 [INFO] [stderr] Checking once_cell v1.20.3 [INFO] [stderr] Compiling log v0.4.25 [INFO] [stderr] Compiling cc v1.2.12 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking libloading v0.8.6 [INFO] [stderr] Checking miniz_oxide v0.8.3 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking bytemuck v1.21.0 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking xcursor v0.3.8 [INFO] [stderr] Checking foreign-types-shared v0.3.1 [INFO] [stderr] Checking arrayref v0.3.9 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Compiling object v0.36.7 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking gimli v0.31.1 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Compiling wayland-sys v0.29.5 [INFO] [stderr] Compiling servo-fontconfig-sys v5.1.0 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Compiling smithay-client-toolkit v0.16.1 [INFO] [stderr] Compiling crossfont v0.5.2 [INFO] [stderr] Checking safe_arch v0.5.2 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Checking tiny-skia-path v0.7.0 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking flate2 v1.0.35 [INFO] [stderr] Checking exr v1.73.0 [INFO] [stderr] Checking gif v0.13.1 [INFO] [stderr] Checking takeable-option v0.5.0 [INFO] [stderr] Compiling cmake v0.1.53 [INFO] [stderr] Compiling syn v2.0.98 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Compiling wayland-scanner v0.29.5 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling freetype-sys v0.13.1 [INFO] [stderr] Compiling expat-sys v2.1.6 [INFO] [stderr] Checking tiny-skia v0.7.0 [INFO] [stderr] Compiling glutin_egl_sys v0.1.6 [INFO] [stderr] Compiling glutin_glx_sys v0.1.8 [INFO] [stderr] Compiling glium v0.32.1 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling wayland-client v0.29.5 [INFO] [stderr] Compiling wayland-protocols v0.29.5 [INFO] [stderr] Checking freetype-rs v0.26.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking servo-fontconfig v0.5.1 [INFO] [stderr] Checking shared_library v0.1.9 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking addr2line v0.24.2 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking wayland-commons v0.29.5 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking wayland-cursor v0.29.5 [INFO] [stderr] Checking wayland-egl v0.29.5 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling foreign-types-macros v0.2.3 [INFO] [stderr] Checking foreign-types v0.5.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking calloop v0.10.6 [INFO] [stderr] Checking backtrace v0.3.74 [INFO] [stderr] Checking sctk-adwaita v0.4.3 [INFO] [stderr] Checking winit v0.27.5 [INFO] [stderr] Checking glutin v0.29.1 [INFO] [stderr] Checking raft v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/world_gen.rs:7:13 [INFO] [stdout] | [INFO] [stdout] 7 | let mut chunk = Chunk::new(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `button` [INFO] [stdout] --> src/main.rs:185:58 [INFO] [stdout] | [INFO] [stdout] 185 | glutin::event::WindowEvent::MouseInput { button, state, .. } => { [INFO] [stdout] | ^^^^^^ help: try ignoring the field: `button: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `state` [INFO] [stdout] --> src/main.rs:185:66 [INFO] [stdout] | [INFO] [stdout] 185 | glutin::event::WindowEvent::MouseInput { button, state, .. } => { [INFO] [stdout] | ^^^^^ help: try ignoring the field: `state: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `block` [INFO] [stdout] --> src/main.rs:192:37 [INFO] [stdout] | [INFO] [stdout] 192 | if let Some(block) = world.block_at(vec.0 as i32, vec.1 as i32, vec.2 as i32) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_block` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `chunk_at_pos_create` and `chunk_at_pos` are never used [INFO] [stdout] --> src/world.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl World { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] 12 | /// Returns a reference to the chunk at position (x, _, z) in world coordinates. Creates it if it doesn't exist yet [INFO] [stdout] 13 | pub fn chunk_at_pos_create(&mut self, x: i32, z: i32) -> &mut Chunk { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn chunk_at_pos(&self, x: i32, z: i32) -> Option<&Chunk> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/camera.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | / if x_angle < -1.5 { [INFO] [stdout] 43 | | x_angle = -1.5; [INFO] [stdout] 44 | | } else if x_angle > 1.5 { [INFO] [stdout] 45 | | x_angle = 1.5; [INFO] [stdout] 46 | | } [INFO] [stdout] | |_________^ help: replace with clamp: `x_angle = x_angle.clamp(-1.5, 1.5);` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/camera.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 79 | if !world.block_at(x, y, z).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `world.block_at(x, y, z).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` branch is empty [INFO] [stdout] --> src/camera.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | if pressed_keys.contains(&VirtualKeyCode::LShift) {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can remove it: `pressed_keys.contains(&VirtualKeyCode::LShift);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_ifs [INFO] [stdout] = note: `#[warn(clippy::needless_ifs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/world_gen.rs:7:13 [INFO] [stdout] | [INFO] [stdout] 7 | let mut chunk = Chunk::new(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/world_gen.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 7 | let mut chunk = Chunk::new(); [INFO] [stdout] | ----------------------------- unnecessary `let` binding [INFO] [stdout] 8 | [INFO] [stdout] 9 | chunk [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 7 ~ [INFO] [stdout] 8 | [INFO] [stdout] 9 ~ Chunk::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `button` [INFO] [stdout] --> src/main.rs:185:58 [INFO] [stdout] | [INFO] [stdout] 185 | glutin::event::WindowEvent::MouseInput { button, state, .. } => { [INFO] [stdout] | ^^^^^^ help: try ignoring the field: `button: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `state` [INFO] [stdout] --> src/main.rs:185:66 [INFO] [stdout] | [INFO] [stdout] 185 | glutin::event::WindowEvent::MouseInput { button, state, .. } => { [INFO] [stdout] | ^^^^^ help: try ignoring the field: `state: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `block` [INFO] [stdout] --> src/main.rs:192:37 [INFO] [stdout] | [INFO] [stdout] 192 | if let Some(block) = world.block_at(vec.0 as i32, vec.1 as i32, vec.2 as i32) { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_block` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `chunk_at_pos_create` and `chunk_at_pos` are never used [INFO] [stdout] --> src/world.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 11 | impl World { [INFO] [stdout] | ---------- methods in this implementation [INFO] [stdout] 12 | /// Returns a reference to the chunk at position (x, _, z) in world coordinates. Creates it if it doesn't exist yet [INFO] [stdout] 13 | pub fn chunk_at_pos_create(&mut self, x: i32, z: i32) -> &mut Chunk { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | pub fn chunk_at_pos(&self, x: i32, z: i32) -> Option<&Chunk> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/camera.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | / if x_angle < -1.5 { [INFO] [stdout] 43 | | x_angle = -1.5; [INFO] [stdout] 44 | | } else if x_angle > 1.5 { [INFO] [stdout] 45 | | x_angle = 1.5; [INFO] [stdout] 46 | | } [INFO] [stdout] | |_________^ help: replace with clamp: `x_angle = x_angle.clamp(-1.5, 1.5);` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/camera.rs:79:12 [INFO] [stdout] | [INFO] [stdout] 79 | if !world.block_at(x, y, z).is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `world.block_at(x, y, z).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` branch is empty [INFO] [stdout] --> src/camera.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | if pressed_keys.contains(&VirtualKeyCode::LShift) {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can remove it: `pressed_keys.contains(&VirtualKeyCode::LShift);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_ifs [INFO] [stdout] = note: `#[warn(clippy::needless_ifs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/world_gen.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 7 | let mut chunk = Chunk::new(); [INFO] [stdout] | ----------------------------- unnecessary `let` binding [INFO] [stdout] 8 | [INFO] [stdout] 9 | chunk [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 7 ~ [INFO] [stdout] 8 | [INFO] [stdout] 9 ~ Chunk::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 56.03s [INFO] running `Command { std: "docker" "inspect" "e90df8278fa9656c12b97a48cab4c66ab3803acb856361b8f8ed88e91eb13409", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e90df8278fa9656c12b97a48cab4c66ab3803acb856361b8f8ed88e91eb13409", kill_on_drop: false }` [INFO] [stdout] e90df8278fa9656c12b97a48cab4c66ab3803acb856361b8f8ed88e91eb13409