[INFO] cloning repository https://github.com/TilBlechschmidt/gpcache [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TilBlechschmidt/gpcache" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTilBlechschmidt%2Fgpcache", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTilBlechschmidt%2Fgpcache'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9657754b50f4c5f34a2c6fccd8d0fe90c7b71044 [INFO] linting TilBlechschmidt/gpcache/9657754b50f4c5f34a2c6fccd8d0fe90c7b71044 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTilBlechschmidt%2Fgpcache" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/TilBlechschmidt/gpcache [INFO] finished tweaking git repo https://github.com/TilBlechschmidt/gpcache [INFO] tweaked toml for git repo https://github.com/TilBlechschmidt/gpcache written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/TilBlechschmidt/gpcache on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/TilBlechschmidt/gpcache already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded cookie_store v0.20.0 [INFO] [stderr] Downloaded poem-derive v1.3.59 [INFO] [stderr] Downloaded wildmatch v2.4.0 [INFO] [stderr] Downloaded rfc7239 v0.1.3 [INFO] [stderr] Downloaded sublime_fuzzy v0.7.0 [INFO] [stderr] Downloaded cc v1.2.9 [INFO] [stderr] Downloaded poem v1.3.59 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3c572e8361ae2f0139af62ac9b01e3afeb20458704ec4717ccbd06e9fd907897 [INFO] running `Command { std: "docker" "start" "-a" "3c572e8361ae2f0139af62ac9b01e3afeb20458704ec4717ccbd06e9fd907897", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3c572e8361ae2f0139af62ac9b01e3afeb20458704ec4717ccbd06e9fd907897", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3c572e8361ae2f0139af62ac9b01e3afeb20458704ec4717ccbd06e9fd907897", kill_on_drop: false }` [INFO] [stdout] 3c572e8361ae2f0139af62ac9b01e3afeb20458704ec4717ccbd06e9fd907897 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1b09c1d0c6c367c433d68f1161f076b2519347a053887dc1d5645b14d6274be4 [INFO] running `Command { std: "docker" "start" "-a" "1b09c1d0c6c367c433d68f1161f076b2519347a053887dc1d5645b14d6274be4", kill_on_drop: false }` [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking bytes v1.9.0 [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Compiling cc v1.2.9 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Compiling serde v1.0.217 [INFO] [stderr] Checking indexmap v2.7.0 [INFO] [stderr] Compiling serde_json v1.0.135 [INFO] [stderr] Compiling time-macros v0.2.19 [INFO] [stderr] Compiling uncased v0.9.10 [INFO] [stderr] Compiling cookie v0.17.0 [INFO] [stderr] Compiling toml_datetime v0.6.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking psl-types v2.0.11 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking idna v0.3.0 [INFO] [stderr] Checking bitflags v2.7.0 [INFO] [stderr] Checking wildmatch v2.4.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking ipnet v2.10.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking sublime_fuzzy v0.7.0 [INFO] [stderr] Checking rfc7239 v0.1.3 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling syn v2.0.96 [INFO] [stderr] Compiling toml_edit v0.20.2 [INFO] [stderr] Checking time v0.3.37 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking headers v0.3.9 [INFO] [stderr] Compiling proc-macro-crate v2.0.2 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling zerofrom-derive v0.1.5 [INFO] [stderr] Compiling yoke-derive v0.7.5 [INFO] [stderr] Compiling zerovec-derive v0.10.3 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling tracing-attributes v0.1.28 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling serde_derive v1.0.217 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling poem-derive v1.3.59 [INFO] [stderr] Compiling async-trait v0.1.85 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tokio v1.43.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking zerofrom v0.1.5 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking yoke v0.7.5 [INFO] [stderr] Checking zerovec v0.10.4 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking icu_properties v1.5.1 [INFO] [stderr] Checking tokio-util v0.7.13 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna_adapter v1.2.0 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking publicsuffix v2.3.0 [INFO] [stderr] Checking cookie_store v0.20.0 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking poem v1.3.59 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking gpcache v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/satellites.rs:86:52 [INFO] [stdout] | [INFO] [stdout] 86 | *entries = satellites.into_iter().map(|s| (s.id.clone(), s)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `s.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/satellites.rs:105:14 [INFO] [stdout] | [INFO] [stdout] 105 | .map(|id| entries.get(&id)) [INFO] [stdout] | ______________^ [INFO] [stdout] 106 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|id| entries.get(&id))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/satellites.rs:86:52 [INFO] [stdout] | [INFO] [stdout] 86 | *entries = satellites.into_iter().map(|s| (s.id.clone(), s)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `s.id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Option` [INFO] [stdout] --> src/satellites.rs:105:14 [INFO] [stdout] | [INFO] [stdout] 105 | .map(|id| entries.get(&id)) [INFO] [stdout] | ______________^ [INFO] [stdout] 106 | | .flatten() [INFO] [stdout] | |______________________^ help: try replacing `map` with `and_then` and remove the `.flatten()`: `and_then(|id| entries.get(&id))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 36.24s [INFO] running `Command { std: "docker" "inspect" "1b09c1d0c6c367c433d68f1161f076b2519347a053887dc1d5645b14d6274be4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b09c1d0c6c367c433d68f1161f076b2519347a053887dc1d5645b14d6274be4", kill_on_drop: false }` [INFO] [stdout] 1b09c1d0c6c367c433d68f1161f076b2519347a053887dc1d5645b14d6274be4