[INFO] cloning repository https://github.com/Tiefseetauchner/TiefDownConverter [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Tiefseetauchner/TiefDownConverter" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTiefseetauchner%2FTiefDownConverter", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTiefseetauchner%2FTiefDownConverter'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1a193618b487df5aa97e243ac539e9741fafc637 [INFO] linting Tiefseetauchner/TiefDownConverter against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTiefseetauchner%2FTiefDownConverter" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Tiefseetauchner/TiefDownConverter [INFO] finished tweaking git repo https://github.com/Tiefseetauchner/TiefDownConverter [INFO] tweaked toml for git repo https://github.com/Tiefseetauchner/TiefDownConverter written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Tiefseetauchner/TiefDownConverter on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Tiefseetauchner/TiefDownConverter already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded fast-glob v1.0.0 [INFO] [stderr] Downloaded windows-registry v0.5.2 [INFO] [stderr] Downloaded rstest v0.25.0 [INFO] [stderr] Downloaded colog v1.3.0 [INFO] [stderr] Downloaded relative-path v1.9.3 [INFO] [stderr] Downloaded assert_cmd v2.0.17 [INFO] [stderr] Downloaded rstest_macros v0.25.0 [INFO] [stderr] Downloaded float-cmp v0.10.0 [INFO] [stderr] Downloaded reqwest v0.12.19 [INFO] [stderr] Downloaded h2 v0.4.10 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 74e0a07809b56d37cce44edd86df8ca362c238f27e75448d7f80e2d8fc4883d1 [INFO] running `Command { std: "docker" "start" "-a" "74e0a07809b56d37cce44edd86df8ca362c238f27e75448d7f80e2d8fc4883d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "74e0a07809b56d37cce44edd86df8ca362c238f27e75448d7f80e2d8fc4883d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "74e0a07809b56d37cce44edd86df8ca362c238f27e75448d7f80e2d8fc4883d1", kill_on_drop: false }` [INFO] [stdout] 74e0a07809b56d37cce44edd86df8ca362c238f27e75448d7f80e2d8fc4883d1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4610c097951f8a321cfdd81e0db9bdc29d17ced5ebec0271d866d37aefcdeb1e [INFO] running `Command { std: "docker" "start" "-a" "4610c097951f8a321cfdd81e0db9bdc29d17ced5ebec0271d866d37aefcdeb1e", kill_on_drop: false }` [INFO] [stderr] Compiling cc v1.2.26 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking tokio v1.45.1 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling semver v1.0.26 [INFO] [stderr] Compiling object v0.36.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking gimli v0.31.1 [INFO] [stderr] Compiling owo-colors v4.2.1 [INFO] [stderr] Compiling iana-time-zone v0.1.63 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking miniz_oxide v0.8.8 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking indexmap v2.9.0 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Checking colored v2.2.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking predicates-core v1.0.9 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking fast-glob v1.0.0 [INFO] [stderr] Compiling regex v1.11.1 [INFO] [stderr] Compiling rstest_macros v0.25.0 [INFO] [stderr] Checking float-cmp v0.10.0 [INFO] [stderr] Checking fs_extra v1.3.0 [INFO] [stderr] Compiling assert_cmd v2.0.17 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking termtree v0.5.1 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking clap_builder v4.5.39 [INFO] [stderr] Compiling clap_derive v4.5.32 [INFO] [stderr] Checking predicates-tree v1.0.12 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking wait-timeout v0.2.1 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Checking bstr v1.12.0 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking predicates v3.1.3 [INFO] [stderr] Checking addr2line v0.24.2 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Checking colog v1.3.0 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking tokio-util v0.7.15 [INFO] [stderr] Compiling openssl v0.10.73 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking h2 v0.4.10 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Compiling tiefdownlib v0.11.0-ALPHA.1 (/opt/rustwide/workdir/core) [INFO] [stderr] Compiling proc-macro-crate v3.3.0 [INFO] [stderr] Checking clap v4.5.39 [INFO] [stderr] Checking backtrace v0.3.75 [INFO] [stderr] Checking color-eyre v0.6.5 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking hyper-util v0.1.14 [INFO] [stderr] Checking rstest v0.25.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.19 [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> core/src/markdown_project_management.rs:305:1 [INFO] [stdout] | [INFO] [stdout] 305 | / /// A Result containing either an error or a Vec of MarkdownProject. [INFO] [stdout] 306 | | [INFO] [stdout] | |_^ [INFO] [stdout] 307 | pub fn get_markdown_projects(project: Option) -> Result> { [INFO] [stdout] | ---------------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> core/src/markdown_project_management.rs:305:1 [INFO] [stdout] | [INFO] [stdout] 305 | / /// A Result containing either an error or a Vec of MarkdownProject. [INFO] [stdout] 306 | | [INFO] [stdout] | |_^ [INFO] [stdout] 307 | pub fn get_markdown_projects(project: Option) -> Result> { [INFO] [stdout] | ---------------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/conversion.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 219 | &conversion_input_dir, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `conversion_input_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/conversion.rs:227:13 [INFO] [stdout] | [INFO] [stdout] 227 | &conversion_input_dir, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `conversion_input_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> core/src/conversion.rs:242:19 [INFO] [stdout] | [INFO] [stdout] 242 | markdown_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 242 - markdown_dir: &PathBuf, [INFO] [stdout] 242 + markdown_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> core/src/conversion.rs:267:17 [INFO] [stdout] | [INFO] [stdout] 267 | / &markdown_project_compiled_directory_path [INFO] [stdout] 268 | | .join(resource.file_name().unwrap_or(std::ffi::OsStr::new("."))), [INFO] [stdout] | |____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 267 ~ markdown_project_compiled_directory_path [INFO] [stdout] 268 ~ .join(resource.file_name().unwrap_or(std::ffi::OsStr::new("."))), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> core/src/conversion.rs:301:45 [INFO] [stdout] | [INFO] [stdout] 301 | let resolved: Vec = available_profiles[profile_pos] [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 302 | | .templates [INFO] [stdout] 303 | | .iter() [INFO] [stdout] 304 | | .map(|t| t.clone()) [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `cloned` method [INFO] [stdout] | [INFO] [stdout] 301 ~ let resolved: Vec = available_profiles[profile_pos] [INFO] [stdout] 302 + .templates [INFO] [stdout] 303 + .iter().cloned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> core/src/conversion.rs:389:1 [INFO] [stdout] | [INFO] [stdout] 389 | / fn convert_template( [INFO] [stdout] 390 | | compiled_directory_path: &Path, [INFO] [stdout] 391 | | template: &Template, [INFO] [stdout] 392 | | project_path: &Path, [INFO] [stdout] ... | [INFO] [stdout] 398 | | injections: &Vec, [INFO] [stdout] 399 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> core/src/converters/common.rs:29:27 [INFO] [stdout] | [INFO] [stdout] 29 | custom_preprocessors: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 29 - custom_preprocessors: &Vec, [INFO] [stdout] 29 + custom_preprocessors: &[PreProcessor], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> core/src/converters/common.rs:31:20 [INFO] [stdout] | [INFO] [stdout] 31 | let selected = preprocessors [INFO] [stdout] | ____________________^ [INFO] [stdout] 32 | | .clone() [INFO] [stdout] 33 | | .and_then(|p| Some(p.preprocessors.clone())) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 31 ~ let selected = preprocessors [INFO] [stdout] 32 + .clone().map(|p| p.preprocessors.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> core/src/converters/common.rs:166:1 [INFO] [stdout] | [INFO] [stdout] 166 | / pub(crate) fn run_preprocessors_on_injections( [INFO] [stdout] 167 | | template: &Template, [INFO] [stdout] 168 | | compiled_directory_path: &Path, [INFO] [stdout] 169 | | metadata_fields: &Table, [INFO] [stdout] ... | [INFO] [stdout] 174 | | input_files: &Vec, [INFO] [stdout] 175 | | ) -> Result> { [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> core/src/converters/common.rs:174:18 [INFO] [stdout] | [INFO] [stdout] 174 | input_files: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 174 - input_files: &Vec, [INFO] [stdout] 174 + input_files: &[PathBuf], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> core/src/converters/common.rs:177:8 [INFO] [stdout] | [INFO] [stdout] 177 | if input_files.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!input_files.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/converters/common.rs:185:13 [INFO] [stdout] | [INFO] [stdout] 185 | &preprocessors, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `preprocessors` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> core/src/converters/common.rs:199:1 [INFO] [stdout] | [INFO] [stdout] 199 | / pub(crate) fn run_preprocessors_on_inputs( [INFO] [stdout] 200 | | template: &Template, [INFO] [stdout] 201 | | compiled_directory_path: &Path, [INFO] [stdout] 202 | | metadata_fields: &Table, [INFO] [stdout] ... | [INFO] [stdout] 207 | | input_files: &Vec, [INFO] [stdout] 208 | | ) -> Result> { [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/converters/common.rs:210:34 [INFO] [stdout] | [INFO] [stdout] 210 | get_preprocessing_chunks(&input_files, template.multi_file_output.unwrap_or(false))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `input_files` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> core/src/converters/common.rs:235:39 [INFO] [stdout] | [INFO] [stdout] 235 | fn choose_preprocessor(preprocessors: &Vec, extension: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 235 - fn choose_preprocessor(preprocessors: &Vec, extension: &str) -> Result { [INFO] [stdout] 235 + fn choose_preprocessor(preprocessors: &[PreProcessor], extension: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> core/src/converters/common.rs:256:12 [INFO] [stdout] | [INFO] [stdout] 256 | files: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 256 ~ files: &[PathBuf], [INFO] [stdout] 257 | ) -> std::result::Result { [INFO] [stdout] ... [INFO] [stdout] 282 | } [INFO] [stdout] 283 ~ cli.args(files.to_owned()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/converters/common.rs:265:64 [INFO] [stdout] | [INFO] [stdout] 265 | let cli_args = preprocess_cli_args(&preprocessor.cli_args, &metadata_fields); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `metadata_fields` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::process::CommandArgs<'_>` [INFO] [stdout] --> core/src/converters/common.rs:287:9 [INFO] [stdout] | [INFO] [stdout] 287 | / cli.get_args() [INFO] [stdout] 288 | | .into_iter() [INFO] [stdout] | |________________________^ help: consider removing `.into_iter()`: `cli.get_args()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> core/src/converters/common.rs:308:21 [INFO] [stdout] | [INFO] [stdout] 308 | / f.extension() [INFO] [stdout] 309 | | .and_then(|e| Some(e.to_string_lossy().to_string())) [INFO] [stdout] | |____________________________________________________________________________^ help: try: `f.extension().map(|e| e.to_string_lossy().to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> core/src/converters/common.rs:348:5 [INFO] [stdout] | [INFO] [stdout] 348 | / if !current_chunk.is_empty() { [INFO] [stdout] 349 | | if let Some(ext) = &chunk_extension { [INFO] [stdout] 350 | | chunks.push((current_chunk, ext.to_string_lossy().to_string())); [INFO] [stdout] 351 | | } [INFO] [stdout] 352 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 348 ~ if !current_chunk.is_empty() [INFO] [stdout] 349 ~ && let Some(ext) = &chunk_extension { [INFO] [stdout] 350 | chunks.push((current_chunk, ext.to_string_lossy().to_string())); [INFO] [stdout] 351 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/converters/common.rs:435:49 [INFO] [stdout] | [INFO] [stdout] 435 | get_relative_path_from_compiled_dir(&nav_meta_path, compiled_directory_path) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `nav_meta_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/converters/common.rs:471:45 [INFO] [stdout] | [INFO] [stdout] 471 | get_relative_path_from_compiled_dir(&metadata_file, compiled_directory_path) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `metadata_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> core/src/converters/common.rs:481:14 [INFO] [stdout] | [INFO] [stdout] 481 | results: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 481 - results: &Vec, [INFO] [stdout] 481 + results: &[String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> core/src/converters/common.rs:489:38 [INFO] [stdout] | [INFO] [stdout] 489 | compiled_directory_path.join(&combined_output), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `combined_output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (13/7) [INFO] [stdout] --> core/src/converters/common.rs:495:1 [INFO] [stdout] | [INFO] [stdout] 495 | / pub(crate) fn write_multi_file_outputs( [INFO] [stdout] 496 | | template: &Template, [INFO] [stdout] 497 | | compiled_directory_path: &Path, [INFO] [stdout] 498 | | conversion_input_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 508 | | results: &Vec, [INFO] [stdout] 509 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> core/src/converters/common.rs:508:14 [INFO] [stdout] | [INFO] [stdout] 508 | results: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 508 - results: &Vec, [INFO] [stdout] 508 + results: &[String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/converters/common.rs:544:17 [INFO] [stdout] | [INFO] [stdout] 544 | &preprocessors, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `preprocessors` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/converters/common.rs:554:17 [INFO] [stdout] | [INFO] [stdout] 554 | &preprocessors, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `preprocessors` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> core/src/converters/common.rs:589:5 [INFO] [stdout] | [INFO] [stdout] 589 | / return Ok(if let Some((nav_meta, nav_meta_path)) = nav_meta_data { [INFO] [stdout] 590 | | debug!( [INFO] [stdout] 591 | | "Populating current navigation metadata node: {}.", [INFO] [stdout] 592 | | path.display() [INFO] [stdout] ... | [INFO] [stdout] 608 | | None [INFO] [stdout] 609 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 589 ~ Ok(if let Some((nav_meta, nav_meta_path)) = nav_meta_data { [INFO] [stdout] 590 + debug!( [INFO] [stdout] 591 + "Populating current navigation metadata node: {}.", [INFO] [stdout] 592 + path.display() [INFO] [stdout] 593 + ); [INFO] [stdout] 594 + let nodes = nav_meta.nodes.clone().unwrap_or(vec![]); [INFO] [stdout] 595 + let current = nodes.iter().find(|n| { [INFO] [stdout] 596 + path.with_extension("") [INFO] [stdout] 597 + .ends_with(&n.path.with_extension("")) [INFO] [stdout] 598 + }); [INFO] [stdout] 599 + [INFO] [stdout] 600 + Some(( [INFO] [stdout] 601 + NavMeta { [INFO] [stdout] 602 + nodes: None, [INFO] [stdout] 603 + current: current.cloned(), [INFO] [stdout] 604 + }, [INFO] [stdout] 605 + nav_meta_path.clone(), [INFO] [stdout] 606 + )) [INFO] [stdout] 607 + } else { [INFO] [stdout] 608 + None [INFO] [stdout] 609 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> core/src/converters/common.rs:587:11 [INFO] [stdout] | [INFO] [stdout] 587 | path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 587 - path: &PathBuf, [INFO] [stdout] 587 + path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> core/src/converters/common.rs:597:28 [INFO] [stdout] | [INFO] [stdout] 597 | .ends_with(&n.path.with_extension("")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `n.path.with_extension("")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> core/src/converters/common.rs:635:49 [INFO] [stdout] | [INFO] [stdout] 635 | std::fs::write(compiled_directory_path.join(&combined_output), content)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `combined_output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> core/src/converters/common.rs:688:9 [INFO] [stdout] | [INFO] [stdout] 688 | return content; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 688 - return content; [INFO] [stdout] 688 + content [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> core/src/converters/custom_preprocessor_converter.rs:21:1 [INFO] [stdout] | [INFO] [stdout] 21 | / pub(crate) fn convert_custom_preprocessors( [INFO] [stdout] 22 | | project_directory_path: &Path, [INFO] [stdout] 23 | | compiled_directory_path: &Path, [INFO] [stdout] 24 | | conversion_input_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 29 | | injections: &Vec, [INFO] [stdout] 30 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> core/src/converters/custom_preprocessor_converter.rs:35:8 [INFO] [stdout] | [INFO] [stdout] 35 | if template.processor != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `template.processor.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> core/src/converters/custom_processor_converter.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / pub(crate) fn convert_custom_processor( [INFO] [stdout] 24 | | project_directory_path: &Path, [INFO] [stdout] 25 | | compiled_directory_path: &Path, [INFO] [stdout] 26 | | conversion_input_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 31 | | injections: &Vec, [INFO] [stdout] 32 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> core/src/converters/epub_converter.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | / pub(crate) fn convert_epub( [INFO] [stdout] 27 | | project_directory_path: &Path, [INFO] [stdout] 28 | | compiled_directory_path: &Path, [INFO] [stdout] 29 | | conversion_input_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 34 | | injections: &Vec, [INFO] [stdout] 35 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TemplateType` which implements the `Copy` trait [INFO] [stdout] --> core/src/converters/epub_converter.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | template.template_type.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `template.template_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> core/src/converters/tex_converter.rs:27:1 [INFO] [stdout] | [INFO] [stdout] 27 | / pub(crate) fn convert_latex( [INFO] [stdout] 28 | | project_directory_path: &Path, [INFO] [stdout] 29 | | compiled_directory_path: &Path, [INFO] [stdout] 30 | | conversion_input_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 35 | | injections: &Vec, [INFO] [stdout] 36 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TemplateType` which implements the `Copy` trait [INFO] [stdout] --> core/src/converters/tex_converter.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | template.template_type.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `template.template_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> core/src/converters/typst_converter.rs:27:1 [INFO] [stdout] | [INFO] [stdout] 27 | / pub(crate) fn convert_typst( [INFO] [stdout] 28 | | project_directory_path: &Path, [INFO] [stdout] 29 | | compiled_directory_path: &Path, [INFO] [stdout] 30 | | conversion_input_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 35 | | injections: &Vec, [INFO] [stdout] 36 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TemplateType` which implements the `Copy` trait [INFO] [stdout] --> core/src/converters/typst_converter.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | template.template_type.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `template.template_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> core/src/converters/typst_converter.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 204 | metadata_file_content.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `metadata_file_content.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> core/src/converters/typst_converter.rs:209:13 [INFO] [stdout] | [INFO] [stdout] 209 | metadata_file_content.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `metadata_file_content.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> core/src/converters/typst_converter.rs:218:5 [INFO] [stdout] | [INFO] [stdout] 218 | metadata_file_content.push_str(")"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `metadata_file_content.push(')')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> core/src/file_retrieval.rs:59:17 [INFO] [stdout] | [INFO] [stdout] 59 | return Ok(vec![f.clone()]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return Ok(vec![f.clone()]); [INFO] [stdout] 59 + Ok(vec![f.clone()]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> core/src/file_retrieval.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | project_directory_path: &Path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_project_directory_path` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> core/src/file_retrieval.rs:63:21 [INFO] [stdout] | [INFO] [stdout] 63 | project_directory_path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> core/src/file_retrieval.rs:107:23 [INFO] [stdout] | [INFO] [stdout] 107 | .and_then(|n| match n.parse::() { [INFO] [stdout] | _______________________^ [INFO] [stdout] 108 | | Result::Ok(n) => Some(n), [INFO] [stdout] 109 | | Err(_e) => None, [INFO] [stdout] 110 | | }) [INFO] [stdout] | |_________^ help: replace with: `n.parse::().ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/conversion.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 219 | &conversion_input_dir, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `conversion_input_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/conversion.rs:227:13 [INFO] [stdout] | [INFO] [stdout] 227 | &conversion_input_dir, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `conversion_input_dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> core/src/conversion.rs:242:19 [INFO] [stdout] | [INFO] [stdout] 242 | markdown_dir: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 242 - markdown_dir: &PathBuf, [INFO] [stdout] 242 + markdown_dir: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> core/src/conversion.rs:267:17 [INFO] [stdout] | [INFO] [stdout] 267 | / &markdown_project_compiled_directory_path [INFO] [stdout] 268 | | .join(resource.file_name().unwrap_or(std::ffi::OsStr::new("."))), [INFO] [stdout] | |____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 267 ~ markdown_project_compiled_directory_path [INFO] [stdout] 268 ~ .join(resource.file_name().unwrap_or(std::ffi::OsStr::new("."))), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> core/src/conversion.rs:301:45 [INFO] [stdout] | [INFO] [stdout] 301 | let resolved: Vec = available_profiles[profile_pos] [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 302 | | .templates [INFO] [stdout] 303 | | .iter() [INFO] [stdout] 304 | | .map(|t| t.clone()) [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] help: consider calling the dedicated `cloned` method [INFO] [stdout] | [INFO] [stdout] 301 ~ let resolved: Vec = available_profiles[profile_pos] [INFO] [stdout] 302 + .templates [INFO] [stdout] 303 + .iter().cloned() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/injections.rs:168:9 [INFO] [stdout] | [INFO] [stdout] 168 | &injections, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `injections` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/injections.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | &injections, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `injections` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/injections.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | &injections, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `injections` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> core/src/injections.rs:194:17 [INFO] [stdout] | [INFO] [stdout] 194 | injections: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 194 - injections: &Vec, [INFO] [stdout] 194 + injections: &[Injection], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> core/src/conversion.rs:389:1 [INFO] [stdout] | [INFO] [stdout] 389 | / fn convert_template( [INFO] [stdout] 390 | | compiled_directory_path: &Path, [INFO] [stdout] 391 | | template: &Template, [INFO] [stdout] 392 | | project_path: &Path, [INFO] [stdout] ... | [INFO] [stdout] 398 | | injections: &Vec, [INFO] [stdout] 399 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> core/src/injections.rs:207:13 [INFO] [stdout] | [INFO] [stdout] 207 | / injections [INFO] [stdout] 208 | | .iter() [INFO] [stdout] 209 | | .find(|i| i.name == *n) [INFO] [stdout] 210 | | .ok_or(eyre!( [INFO] [stdout] ... | [INFO] [stdout] 214 | | )) [INFO] [stdout] 215 | | .and_then(|i| Ok(i.files.clone())) [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 207 ~ injections [INFO] [stdout] 208 + .iter() [INFO] [stdout] 209 + .find(|i| i.name == *n) [INFO] [stdout] 210 + .ok_or(eyre!( [INFO] [stdout] 211 + "Injection '{}' referenced in template '{}' was not found in manifest.", [INFO] [stdout] 212 + n, [INFO] [stdout] 213 + template_name [INFO] [stdout] 214 + )).map(|i| i.files.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> core/src/converters/common.rs:29:27 [INFO] [stdout] | [INFO] [stdout] 29 | custom_preprocessors: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 29 - custom_preprocessors: &Vec, [INFO] [stdout] 29 + custom_preprocessors: &[PreProcessor], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> core/src/converters/common.rs:31:20 [INFO] [stdout] | [INFO] [stdout] 31 | let selected = preprocessors [INFO] [stdout] | ____________________^ [INFO] [stdout] 32 | | .clone() [INFO] [stdout] 33 | | .and_then(|p| Some(p.preprocessors.clone())) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] = note: `#[warn(clippy::bind_instead_of_map)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 31 ~ let selected = preprocessors [INFO] [stdout] 32 + .clone().map(|p| p.preprocessors.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> core/src/converters/common.rs:166:1 [INFO] [stdout] | [INFO] [stdout] 166 | / pub(crate) fn run_preprocessors_on_injections( [INFO] [stdout] 167 | | template: &Template, [INFO] [stdout] 168 | | compiled_directory_path: &Path, [INFO] [stdout] 169 | | metadata_fields: &Table, [INFO] [stdout] ... | [INFO] [stdout] 174 | | input_files: &Vec, [INFO] [stdout] 175 | | ) -> Result> { [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> core/src/converters/common.rs:174:18 [INFO] [stdout] | [INFO] [stdout] 174 | input_files: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 174 - input_files: &Vec, [INFO] [stdout] 174 + input_files: &[PathBuf], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> core/src/converters/common.rs:177:8 [INFO] [stdout] | [INFO] [stdout] 177 | if input_files.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!input_files.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/converters/common.rs:185:13 [INFO] [stdout] | [INFO] [stdout] 185 | &preprocessors, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `preprocessors` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> core/src/converters/common.rs:199:1 [INFO] [stdout] | [INFO] [stdout] 199 | / pub(crate) fn run_preprocessors_on_inputs( [INFO] [stdout] 200 | | template: &Template, [INFO] [stdout] 201 | | compiled_directory_path: &Path, [INFO] [stdout] 202 | | metadata_fields: &Table, [INFO] [stdout] ... | [INFO] [stdout] 207 | | input_files: &Vec, [INFO] [stdout] 208 | | ) -> Result> { [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/converters/common.rs:210:34 [INFO] [stdout] | [INFO] [stdout] 210 | get_preprocessing_chunks(&input_files, template.multi_file_output.unwrap_or(false))?; [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `input_files` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> core/src/converters/common.rs:235:39 [INFO] [stdout] | [INFO] [stdout] 235 | fn choose_preprocessor(preprocessors: &Vec, extension: &str) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 235 - fn choose_preprocessor(preprocessors: &Vec, extension: &str) -> Result { [INFO] [stdout] 235 + fn choose_preprocessor(preprocessors: &[PreProcessor], extension: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> core/src/converters/common.rs:256:12 [INFO] [stdout] | [INFO] [stdout] 256 | files: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 256 ~ files: &[PathBuf], [INFO] [stdout] 257 | ) -> std::result::Result { [INFO] [stdout] ... [INFO] [stdout] 282 | } [INFO] [stdout] 283 ~ cli.args(files.to_owned()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/converters/common.rs:265:64 [INFO] [stdout] | [INFO] [stdout] 265 | let cli_args = preprocess_cli_args(&preprocessor.cli_args, &metadata_fields); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `metadata_fields` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::process::CommandArgs<'_>` [INFO] [stdout] --> core/src/converters/common.rs:287:9 [INFO] [stdout] | [INFO] [stdout] 287 | / cli.get_args() [INFO] [stdout] 288 | | .into_iter() [INFO] [stdout] | |________________________^ help: consider removing `.into_iter()`: `cli.get_args()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Option.and_then(|x| Some(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> core/src/converters/common.rs:308:21 [INFO] [stdout] | [INFO] [stdout] 308 | / f.extension() [INFO] [stdout] 309 | | .and_then(|e| Some(e.to_string_lossy().to_string())) [INFO] [stdout] | |____________________________________________________________________________^ help: try: `f.extension().map(|e| e.to_string_lossy().to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> core/src/converters/common.rs:348:5 [INFO] [stdout] | [INFO] [stdout] 348 | / if !current_chunk.is_empty() { [INFO] [stdout] 349 | | if let Some(ext) = &chunk_extension { [INFO] [stdout] 350 | | chunks.push((current_chunk, ext.to_string_lossy().to_string())); [INFO] [stdout] 351 | | } [INFO] [stdout] 352 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 348 ~ if !current_chunk.is_empty() [INFO] [stdout] 349 ~ && let Some(ext) = &chunk_extension { [INFO] [stdout] 350 | chunks.push((current_chunk, ext.to_string_lossy().to_string())); [INFO] [stdout] 351 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/converters/common.rs:435:49 [INFO] [stdout] | [INFO] [stdout] 435 | get_relative_path_from_compiled_dir(&nav_meta_path, compiled_directory_path) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `nav_meta_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/converters/common.rs:471:45 [INFO] [stdout] | [INFO] [stdout] 471 | get_relative_path_from_compiled_dir(&metadata_file, compiled_directory_path) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `metadata_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> core/src/converters/common.rs:481:14 [INFO] [stdout] | [INFO] [stdout] 481 | results: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 481 - results: &Vec, [INFO] [stdout] 481 + results: &[String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> core/src/converters/common.rs:489:38 [INFO] [stdout] | [INFO] [stdout] 489 | compiled_directory_path.join(&combined_output), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `combined_output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (13/7) [INFO] [stdout] --> core/src/converters/common.rs:495:1 [INFO] [stdout] | [INFO] [stdout] 495 | / pub(crate) fn write_multi_file_outputs( [INFO] [stdout] 496 | | template: &Template, [INFO] [stdout] 497 | | compiled_directory_path: &Path, [INFO] [stdout] 498 | | conversion_input_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 508 | | results: &Vec, [INFO] [stdout] 509 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> core/src/converters/common.rs:508:14 [INFO] [stdout] | [INFO] [stdout] 508 | results: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 508 - results: &Vec, [INFO] [stdout] 508 + results: &[String], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/converters/common.rs:544:17 [INFO] [stdout] | [INFO] [stdout] 544 | &preprocessors, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `preprocessors` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/converters/common.rs:554:17 [INFO] [stdout] | [INFO] [stdout] 554 | &preprocessors, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `preprocessors` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> core/src/converters/common.rs:589:5 [INFO] [stdout] | [INFO] [stdout] 589 | / return Ok(if let Some((nav_meta, nav_meta_path)) = nav_meta_data { [INFO] [stdout] 590 | | debug!( [INFO] [stdout] 591 | | "Populating current navigation metadata node: {}.", [INFO] [stdout] 592 | | path.display() [INFO] [stdout] ... | [INFO] [stdout] 608 | | None [INFO] [stdout] 609 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 589 ~ Ok(if let Some((nav_meta, nav_meta_path)) = nav_meta_data { [INFO] [stdout] 590 + debug!( [INFO] [stdout] 591 + "Populating current navigation metadata node: {}.", [INFO] [stdout] 592 + path.display() [INFO] [stdout] 593 + ); [INFO] [stdout] 594 + let nodes = nav_meta.nodes.clone().unwrap_or(vec![]); [INFO] [stdout] 595 + let current = nodes.iter().find(|n| { [INFO] [stdout] 596 + path.with_extension("") [INFO] [stdout] 597 + .ends_with(&n.path.with_extension("")) [INFO] [stdout] 598 + }); [INFO] [stdout] 599 + [INFO] [stdout] 600 + Some(( [INFO] [stdout] 601 + NavMeta { [INFO] [stdout] 602 + nodes: None, [INFO] [stdout] 603 + current: current.cloned(), [INFO] [stdout] 604 + }, [INFO] [stdout] 605 + nav_meta_path.clone(), [INFO] [stdout] 606 + )) [INFO] [stdout] 607 + } else { [INFO] [stdout] 608 + None [INFO] [stdout] 609 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> core/src/converters/common.rs:587:11 [INFO] [stdout] | [INFO] [stdout] 587 | path: &PathBuf, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 587 - path: &PathBuf, [INFO] [stdout] 587 + path: &Path, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `default` can be confused for the standard trait method `std::default::Default::default` [INFO] [stdout] --> core/src/manifest_model.rs:227:5 [INFO] [stdout] | [INFO] [stdout] 227 | / pub fn default() -> Self { [INFO] [stdout] 228 | | Self { [INFO] [stdout] 229 | | metadata_prefix: None, [INFO] [stdout] 230 | | } [INFO] [stdout] 231 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::default::Default` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> core/src/converters/common.rs:597:28 [INFO] [stdout] | [INFO] [stdout] 597 | .ends_with(&n.path.with_extension("")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `n.path.with_extension("")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> core/src/converters/common.rs:635:49 [INFO] [stdout] | [INFO] [stdout] 635 | std::fs::write(compiled_directory_path.join(&combined_output), content)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `combined_output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> core/src/converters/common.rs:688:9 [INFO] [stdout] | [INFO] [stdout] 688 | return content; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 688 - return content; [INFO] [stdout] 688 + content [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> core/src/converters/custom_preprocessor_converter.rs:21:1 [INFO] [stdout] | [INFO] [stdout] 21 | / pub(crate) fn convert_custom_preprocessors( [INFO] [stdout] 22 | | project_directory_path: &Path, [INFO] [stdout] 23 | | compiled_directory_path: &Path, [INFO] [stdout] 24 | | conversion_input_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 29 | | injections: &Vec, [INFO] [stdout] 30 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> core/src/converters/custom_preprocessor_converter.rs:35:8 [INFO] [stdout] | [INFO] [stdout] 35 | if template.processor != None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_some()` instead: `template.processor.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> core/src/converters/custom_processor_converter.rs:23:1 [INFO] [stdout] | [INFO] [stdout] 23 | / pub(crate) fn convert_custom_processor( [INFO] [stdout] 24 | | project_directory_path: &Path, [INFO] [stdout] 25 | | compiled_directory_path: &Path, [INFO] [stdout] 26 | | conversion_input_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 31 | | injections: &Vec, [INFO] [stdout] 32 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> core/src/converters/epub_converter.rs:26:1 [INFO] [stdout] | [INFO] [stdout] 26 | / pub(crate) fn convert_epub( [INFO] [stdout] 27 | | project_directory_path: &Path, [INFO] [stdout] 28 | | compiled_directory_path: &Path, [INFO] [stdout] 29 | | conversion_input_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 34 | | injections: &Vec, [INFO] [stdout] 35 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TemplateType` which implements the `Copy` trait [INFO] [stdout] --> core/src/converters/epub_converter.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | template.template_type.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `template.template_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> core/src/converters/tex_converter.rs:27:1 [INFO] [stdout] | [INFO] [stdout] 27 | / pub(crate) fn convert_latex( [INFO] [stdout] 28 | | project_directory_path: &Path, [INFO] [stdout] 29 | | compiled_directory_path: &Path, [INFO] [stdout] 30 | | conversion_input_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 35 | | injections: &Vec, [INFO] [stdout] 36 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TemplateType` which implements the `Copy` trait [INFO] [stdout] --> core/src/converters/tex_converter.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | template.template_type.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `template.template_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> core/src/manifest_model.rs:427:38 [INFO] [stdout] | [INFO] [stdout] 427 | if metadata_fields.is_table() && metadata_fields.as_table().unwrap().len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!metadata_fields.as_table().unwrap().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> core/src/manifest_model.rs:463:5 [INFO] [stdout] | [INFO] [stdout] 463 | / if let Some(toml::Value::Table(custom)) = manifest.get_mut("custom_processors") { [INFO] [stdout] 464 | | if let Some(toml::Value::Array(preprocessors)) = custom.get_mut("preprocessors") { [INFO] [stdout] 465 | | for preproc in preprocessors { [INFO] [stdout] 466 | | if let toml::Value::Table(tbl) = preproc { [INFO] [stdout] ... | [INFO] [stdout] 505 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 463 ~ if let Some(toml::Value::Table(custom)) = manifest.get_mut("custom_processors") [INFO] [stdout] 464 ~ && let Some(toml::Value::Array(preprocessors)) = custom.get_mut("preprocessors") { [INFO] [stdout] 465 | for preproc in preprocessors { [INFO] [stdout] ... [INFO] [stdout] 503 | } [INFO] [stdout] 504 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> core/src/manifest_model.rs:510:17 [INFO] [stdout] | [INFO] [stdout] 510 | / if let Some(toml::Value::String(template_type)) = tbl.get_mut("template_type") { [INFO] [stdout] 511 | | if template_type == "CustomPandoc" { [INFO] [stdout] 512 | | *template_type = "CustomPreprocessors".to_string(); [INFO] [stdout] 513 | | } [INFO] [stdout] 514 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 510 ~ if let Some(toml::Value::String(template_type)) = tbl.get_mut("template_type") [INFO] [stdout] 511 ~ && template_type == "CustomPandoc" { [INFO] [stdout] 512 | *template_type = "CustomPreprocessors".to_string(); [INFO] [stdout] 513 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> core/src/converters/typst_converter.rs:27:1 [INFO] [stdout] | [INFO] [stdout] 27 | / pub(crate) fn convert_typst( [INFO] [stdout] 28 | | project_directory_path: &Path, [INFO] [stdout] 29 | | compiled_directory_path: &Path, [INFO] [stdout] 30 | | conversion_input_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 35 | | injections: &Vec, [INFO] [stdout] 36 | | ) -> Result { [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TemplateType` which implements the `Copy` trait [INFO] [stdout] --> core/src/converters/typst_converter.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | template.template_type.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `template.template_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> core/src/converters/typst_converter.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 204 | metadata_file_content.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `metadata_file_content.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> core/src/converters/typst_converter.rs:209:13 [INFO] [stdout] | [INFO] [stdout] 209 | metadata_file_content.push_str("\n"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `metadata_file_content.push('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> core/src/converters/typst_converter.rs:218:5 [INFO] [stdout] | [INFO] [stdout] 218 | metadata_file_content.push_str(")"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `metadata_file_content.push(')')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> core/src/file_retrieval.rs:59:17 [INFO] [stdout] | [INFO] [stdout] 59 | return Ok(vec![f.clone()]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return Ok(vec![f.clone()]); [INFO] [stdout] 59 + Ok(vec![f.clone()]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> core/src/file_retrieval.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | project_directory_path: &Path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_project_directory_path` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> core/src/file_retrieval.rs:63:21 [INFO] [stdout] | [INFO] [stdout] 63 | project_directory_path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> core/src/file_retrieval.rs:107:23 [INFO] [stdout] | [INFO] [stdout] 107 | .and_then(|n| match n.parse::() { [INFO] [stdout] | _______________________^ [INFO] [stdout] 108 | | Result::Ok(n) => Some(n), [INFO] [stdout] 109 | | Err(_e) => None, [INFO] [stdout] 110 | | }) [INFO] [stdout] | |_________^ help: replace with: `n.parse::().ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/injections.rs:168:9 [INFO] [stdout] | [INFO] [stdout] 168 | &injections, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `injections` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/injections.rs:174:9 [INFO] [stdout] | [INFO] [stdout] 174 | &injections, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `injections` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/injections.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | &injections, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `injections` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> core/src/injections.rs:194:17 [INFO] [stdout] | [INFO] [stdout] 194 | injections: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 194 - injections: &Vec, [INFO] [stdout] 194 + injections: &[Injection], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `Result.and_then(|x| Ok(y))`, which is more succinctly expressed as `map(|x| y)` [INFO] [stdout] --> core/src/injections.rs:207:13 [INFO] [stdout] | [INFO] [stdout] 207 | / injections [INFO] [stdout] 208 | | .iter() [INFO] [stdout] 209 | | .find(|i| i.name == *n) [INFO] [stdout] 210 | | .ok_or(eyre!( [INFO] [stdout] ... | [INFO] [stdout] 214 | | )) [INFO] [stdout] 215 | | .and_then(|i| Ok(i.files.clone())) [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bind_instead_of_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 207 ~ injections [INFO] [stdout] 208 + .iter() [INFO] [stdout] 209 + .find(|i| i.name == *n) [INFO] [stdout] 210 + .ok_or(eyre!( [INFO] [stdout] 211 + "Injection '{}' referenced in template '{}' was not found in manifest.", [INFO] [stdout] 212 + n, [INFO] [stdout] 213 + template_name [INFO] [stdout] 214 + )).map(|i| i.files.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> core/src/nav_meta_generation.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 44 | input_files: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 44 - input_files: &Vec, [INFO] [stdout] 44 + input_files: &[PathBuf], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (18/7) [INFO] [stdout] --> core/src/project_management.rs:182:1 [INFO] [stdout] | [INFO] [stdout] 182 | / pub fn add_template( [INFO] [stdout] 183 | | project: Option, [INFO] [stdout] 184 | | template_name: String, [INFO] [stdout] 185 | | template_type: Option, [INFO] [stdout] ... | [INFO] [stdout] 200 | | meta_gen_format: Option, [INFO] [stdout] 201 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> core/src/project_management.rs:250:22 [INFO] [stdout] | [INFO] [stdout] 250 | Some(PathBuf::from(preprocessor_output.unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `preprocessor_output.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (22/7) [INFO] [stdout] --> core/src/project_management.rs:380:1 [INFO] [stdout] | [INFO] [stdout] 380 | / pub fn update_template( [INFO] [stdout] 381 | | project: Option, [INFO] [stdout] 382 | | template_name: String, [INFO] [stdout] 383 | | template_type: Option, [INFO] [stdout] ... | [INFO] [stdout] 402 | | meta_gen_format: Option, [INFO] [stdout] 403 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TemplateType` which implements the `Copy` trait [INFO] [stdout] --> core/src/project_management.rs:420:58 [INFO] [stdout] | [INFO] [stdout] 420 | template.template_type = template_type.unwrap_or(template.template_type.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `template.template_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> core/src/project_management.rs:459:54 [INFO] [stdout] | [INFO] [stdout] 459 | preprocessors.combined_output = Some(PathBuf::from(preprocessor_output)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `preprocessor_output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> core/src/project_management.rs:463:43 [INFO] [stdout] | [INFO] [stdout] 463 | combined_output: Some(PathBuf::from(preprocessor_output)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `preprocessor_output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> core/src/project_management.rs:563:54 [INFO] [stdout] | [INFO] [stdout] 563 | meta_gen.format = meta_gen_format.or(meta_gen.format.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `meta_gen.format` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `default` can be confused for the standard trait method `std::default::Default::default` [INFO] [stdout] --> core/src/manifest_model.rs:227:5 [INFO] [stdout] | [INFO] [stdout] 227 | / pub fn default() -> Self { [INFO] [stdout] 228 | | Self { [INFO] [stdout] 229 | | metadata_prefix: None, [INFO] [stdout] 230 | | } [INFO] [stdout] 231 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::default::Default` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> core/src/project_management.rs:967:20 [INFO] [stdout] | [INFO] [stdout] 967 | && path [INFO] [stdout] | ____________________^ [INFO] [stdout] 968 | | .file_name() [INFO] [stdout] 969 | | .and_then(|name| name.to_str()) [INFO] [stdout] 970 | | .map_or(false, |name| regex.is_match(name)) [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 970 - .map_or(false, |name| regex.is_match(name)) [INFO] [stdout] 970 + .is_some_and(|name| regex.is_match(name)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort` [INFO] [stdout] --> core/src/project_management.rs:974:5 [INFO] [stdout] | [INFO] [stdout] 974 | dirs_to_delete.sort_by(|a, b| a.cmp(b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 974 - dirs_to_delete.sort_by(|a, b| a.cmp(b)); [INFO] [stdout] 974 + dirs_to_delete.sort(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> core/src/project_management.rs:1021:12 [INFO] [stdout] | [INFO] [stdout] 1021 | if !output.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `output.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `output` after checking its variant with `is_ok` [INFO] [stdout] --> core/src/project_management.rs:1025:17 [INFO] [stdout] | [INFO] [stdout] 1021 | if !output.is_ok() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 1025 | output.unwrap_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/template_management.rs:87:34 [INFO] [stdout] | [INFO] [stdout] 87 | create_lix_luafilter(&project_path)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> core/src/template_management.rs:155:24 [INFO] [stdout] | [INFO] [stdout] 155 | let filename = file_url.split('/').last().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 155 - let filename = file_url.split('/').last().unwrap(); [INFO] [stdout] 155 + let filename = file_url.split('/').next_back().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> core/src/template_management.rs:180:24 [INFO] [stdout] | [INFO] [stdout] 180 | let filename = file_url.split('/').last().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 180 - let filename = file_url.split('/').last().unwrap(); [INFO] [stdout] 180 + let filename = file_url.split('/').next_back().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> core/src/manifest_model.rs:427:38 [INFO] [stdout] | [INFO] [stdout] 427 | if metadata_fields.is_table() && metadata_fields.as_table().unwrap().len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!metadata_fields.as_table().unwrap().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> core/src/converters/common.rs:570:17 [INFO] [stdout] | [INFO] [stdout] 570 | / vec![ [INFO] [stdout] 571 | | header_injections.join("\n\n"), [INFO] [stdout] 572 | | res.clone(), [INFO] [stdout] 573 | | footer_injections.join("\n\n"), [INFO] [stdout] 574 | | ] [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 570 ~ [header_injections.join("\n\n"), [INFO] [stdout] 571 + res.clone(), [INFO] [stdout] 572 + footer_injections.join("\n\n")] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> core/src/converters/epub_converter.rs:151:30 [INFO] [stdout] | [INFO] [stdout] 151 | let mut processor_args = vec!["-t", "epub3", "-f", "native"] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["-t", "epub3", "-f", "native"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> core/src/manifest_model.rs:156:31 [INFO] [stdout] | [INFO] [stdout] 156 | cli_args: vec!["-t", "latex"].iter().map(|s| s.to_string()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["-t", "latex"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> core/src/manifest_model.rs:185:31 [INFO] [stdout] | [INFO] [stdout] 185 | cli_args: vec!["-t", "typst"].iter().map(|s| s.to_string()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["-t", "typst"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> core/src/manifest_model.rs:210:27 [INFO] [stdout] | [INFO] [stdout] 210 | cli_args: vec!["-t", "native"].iter().map(|s| s.to_string()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["-t", "native"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> core/src/manifest_model.rs:463:5 [INFO] [stdout] | [INFO] [stdout] 463 | / if let Some(toml::Value::Table(custom)) = manifest.get_mut("custom_processors") { [INFO] [stdout] 464 | | if let Some(toml::Value::Array(preprocessors)) = custom.get_mut("preprocessors") { [INFO] [stdout] 465 | | for preproc in preprocessors { [INFO] [stdout] 466 | | if let toml::Value::Table(tbl) = preproc { [INFO] [stdout] ... | [INFO] [stdout] 505 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 463 ~ if let Some(toml::Value::Table(custom)) = manifest.get_mut("custom_processors") [INFO] [stdout] 464 ~ && let Some(toml::Value::Array(preprocessors)) = custom.get_mut("preprocessors") { [INFO] [stdout] 465 | for preproc in preprocessors { [INFO] [stdout] ... [INFO] [stdout] 503 | } [INFO] [stdout] 504 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> core/src/manifest_model.rs:510:17 [INFO] [stdout] | [INFO] [stdout] 510 | / if let Some(toml::Value::String(template_type)) = tbl.get_mut("template_type") { [INFO] [stdout] 511 | | if template_type == "CustomPandoc" { [INFO] [stdout] 512 | | *template_type = "CustomPreprocessors".to_string(); [INFO] [stdout] 513 | | } [INFO] [stdout] 514 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 510 ~ if let Some(toml::Value::String(template_type)) = tbl.get_mut("template_type") [INFO] [stdout] 511 ~ && template_type == "CustomPandoc" { [INFO] [stdout] 512 | *template_type = "CustomPreprocessors".to_string(); [INFO] [stdout] 513 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> core/src/nav_meta_generation.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 44 | input_files: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 44 - input_files: &Vec, [INFO] [stdout] 44 + input_files: &[PathBuf], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (18/7) [INFO] [stdout] --> core/src/project_management.rs:182:1 [INFO] [stdout] | [INFO] [stdout] 182 | / pub fn add_template( [INFO] [stdout] 183 | | project: Option, [INFO] [stdout] 184 | | template_name: String, [INFO] [stdout] 185 | | template_type: Option, [INFO] [stdout] ... | [INFO] [stdout] 200 | | meta_gen_format: Option, [INFO] [stdout] 201 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> core/src/project_management.rs:250:22 [INFO] [stdout] | [INFO] [stdout] 250 | Some(PathBuf::from(preprocessor_output.unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `preprocessor_output.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking tiefdownconverter v0.11.0-ALPHA.1 (/opt/rustwide/workdir/cli) [INFO] [stdout] warning: this function has too many arguments (22/7) [INFO] [stdout] --> core/src/project_management.rs:380:1 [INFO] [stdout] | [INFO] [stdout] 380 | / pub fn update_template( [INFO] [stdout] 381 | | project: Option, [INFO] [stdout] 382 | | template_name: String, [INFO] [stdout] 383 | | template_type: Option, [INFO] [stdout] ... | [INFO] [stdout] 402 | | meta_gen_format: Option, [INFO] [stdout] 403 | | ) -> Result<()> { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `TemplateType` which implements the `Copy` trait [INFO] [stdout] --> core/src/project_management.rs:420:58 [INFO] [stdout] | [INFO] [stdout] 420 | template.template_type = template_type.unwrap_or(template.template_type.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `template.template_type` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> core/src/project_management.rs:459:54 [INFO] [stdout] | [INFO] [stdout] 459 | preprocessors.combined_output = Some(PathBuf::from(preprocessor_output)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `preprocessor_output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> core/src/project_management.rs:463:43 [INFO] [stdout] | [INFO] [stdout] 463 | combined_output: Some(PathBuf::from(preprocessor_output)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `preprocessor_output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> core/src/project_management.rs:563:54 [INFO] [stdout] | [INFO] [stdout] 563 | meta_gen.format = meta_gen_format.or(meta_gen.format.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `meta_gen.format` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> core/src/project_management.rs:967:20 [INFO] [stdout] | [INFO] [stdout] 967 | && path [INFO] [stdout] | ____________________^ [INFO] [stdout] 968 | | .file_name() [INFO] [stdout] 969 | | .and_then(|name| name.to_str()) [INFO] [stdout] 970 | | .map_or(false, |name| regex.is_match(name)) [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 970 - .map_or(false, |name| regex.is_match(name)) [INFO] [stdout] 970 + .is_some_and(|name| regex.is_match(name)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort` [INFO] [stdout] --> core/src/project_management.rs:974:5 [INFO] [stdout] | [INFO] [stdout] 974 | dirs_to_delete.sort_by(|a, b| a.cmp(b)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 974 - dirs_to_delete.sort_by(|a, b| a.cmp(b)); [INFO] [stdout] 974 + dirs_to_delete.sort(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> core/src/project_management.rs:1021:12 [INFO] [stdout] | [INFO] [stdout] 1021 | if !output.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `output.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `output` after checking its variant with `is_ok` [INFO] [stdout] --> core/src/project_management.rs:1025:17 [INFO] [stdout] | [INFO] [stdout] 1021 | if !output.is_ok() { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 1025 | output.unwrap_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> core/src/template_management.rs:87:34 [INFO] [stdout] | [INFO] [stdout] 87 | create_lix_luafilter(&project_path)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> core/src/template_management.rs:155:24 [INFO] [stdout] | [INFO] [stdout] 155 | let filename = file_url.split('/').last().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 155 - let filename = file_url.split('/').last().unwrap(); [INFO] [stdout] 155 + let filename = file_url.split('/').next_back().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> core/src/template_management.rs:180:24 [INFO] [stdout] | [INFO] [stdout] 180 | let filename = file_url.split('/').last().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 180 - let filename = file_url.split('/').last().unwrap(); [INFO] [stdout] 180 + let filename = file_url.split('/').next_back().unwrap(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> core/src/converters/common.rs:570:17 [INFO] [stdout] | [INFO] [stdout] 570 | / vec![ [INFO] [stdout] 571 | | header_injections.join("\n\n"), [INFO] [stdout] 572 | | res.clone(), [INFO] [stdout] 573 | | footer_injections.join("\n\n"), [INFO] [stdout] 574 | | ] [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 570 ~ [header_injections.join("\n\n"), [INFO] [stdout] 571 + res.clone(), [INFO] [stdout] 572 + footer_injections.join("\n\n")] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> core/src/converters/epub_converter.rs:151:30 [INFO] [stdout] | [INFO] [stdout] 151 | let mut processor_args = vec!["-t", "epub3", "-f", "native"] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["-t", "epub3", "-f", "native"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> core/src/manifest_model.rs:156:31 [INFO] [stdout] | [INFO] [stdout] 156 | cli_args: vec!["-t", "latex"].iter().map(|s| s.to_string()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["-t", "latex"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> core/src/manifest_model.rs:185:31 [INFO] [stdout] | [INFO] [stdout] 185 | cli_args: vec!["-t", "typst"].iter().map(|s| s.to_string()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["-t", "typst"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> core/src/manifest_model.rs:210:27 [INFO] [stdout] | [INFO] [stdout] 210 | cli_args: vec!["-t", "native"].iter().map(|s| s.to_string()).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `["-t", "native"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_markdown_meta_list_integration_test.rs:59:45 [INFO] [stdout] | [INFO] [stdout] 59 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_markdown_meta_list_integration_test.rs:84:45 [INFO] [stdout] | [INFO] [stdout] 84 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_preprocessors_add_integration_test.rs:30:45 [INFO] [stdout] | [INFO] [stdout] 30 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_preprocessors_add_integration_test.rs:59:45 [INFO] [stdout] | [INFO] [stdout] 59 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_preprocessors_add_integration_test.rs:89:45 [INFO] [stdout] | [INFO] [stdout] 89 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_markdown_meta_remove_integration_test.rs:59:45 [INFO] [stdout] | [INFO] [stdout] 59 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_markdown_meta_remove_integration_test.rs:99:45 [INFO] [stdout] | [INFO] [stdout] 99 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_markdown_meta_remove_integration_test.rs:119:45 [INFO] [stdout] | [INFO] [stdout] 119 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cli/tests/project_shared_meta_list_integration_test.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 31 | cmd.current_dir(&project_path) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_shared_meta_list_integration_test.rs:44:45 [INFO] [stdout] | [INFO] [stdout] 44 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_shared_meta_list_integration_test.rs:71:45 [INFO] [stdout] | [INFO] [stdout] 71 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_shared_meta_set_integration_test.rs:31:45 [INFO] [stdout] | [INFO] [stdout] 31 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_shared_meta_set_integration_test.rs:53:45 [INFO] [stdout] | [INFO] [stdout] 53 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cli/tests/project_smart_clean_integration_test.rs:34:21 [INFO] [stdout] | [INFO] [stdout] 34 | cmd.current_dir(&project_path) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cli/tests/project_smart_clean_integration_test.rs:43:21 [INFO] [stdout] | [INFO] [stdout] 43 | cmd.current_dir(&project_path) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cli/tests/project_smart_clean_integration_test.rs:68:21 [INFO] [stdout] | [INFO] [stdout] 68 | cmd.current_dir(&project_path) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_smart_clean_integration_test.rs:107:45 [INFO] [stdout] | [INFO] [stdout] 107 | let project_path = create_empty_project(&temp_dir.path(), Some(2)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_smart_clean_integration_test.rs:133:45 [INFO] [stdout] | [INFO] [stdout] 133 | let project_path = create_empty_project(&temp_dir.path(), Some(1000)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_smart_clean_integration_test.rs:159:45 [INFO] [stdout] | [INFO] [stdout] 159 | let project_path = create_empty_project(&temp_dir.path(), Some(2)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_smart_clean_integration_test.rs:181:45 [INFO] [stdout] | [INFO] [stdout] 181 | let project_path = create_empty_project(&temp_dir.path(), None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cli/tests/project_injections_list_tests.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 31 | cmd.current_dir(&project_path) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_injections_list_tests.rs:48:45 [INFO] [stdout] | [INFO] [stdout] 48 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_update_settings_integration_test.rs:32:45 [INFO] [stdout] | [INFO] [stdout] 32 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_update_settings_integration_test.rs:54:45 [INFO] [stdout] | [INFO] [stdout] 54 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_update_settings_integration_test.rs:83:45 [INFO] [stdout] | [INFO] [stdout] 83 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cli/tests/project_list_templates_integration_test.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 31 | cmd.current_dir(&project_path) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_list_templates_integration_test.rs:51:45 [INFO] [stdout] | [INFO] [stdout] 51 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_list_templates_integration_test.rs:85:45 [INFO] [stdout] | [INFO] [stdout] 85 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `command` [INFO] [stdout] --> cli/src/cli.rs:1:63 [INFO] [stdout] | [INFO] [stdout] 1 | use clap::{Parser, Subcommand, builder::PossibleValuesParser, command}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `command` [INFO] [stdout] --> cli/src/cli.rs:1:63 [INFO] [stdout] | [INFO] [stdout] 1 | use clap::{Parser, Subcommand, builder::PossibleValuesParser, command}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_profiles_remove_integration_test.rs:30:45 [INFO] [stdout] | [INFO] [stdout] 30 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_profiles_remove_integration_test.rs:76:45 [INFO] [stdout] | [INFO] [stdout] 76 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cli/tests/project_profiles_remove_integration_test.rs:94:21 [INFO] [stdout] | [INFO] [stdout] 94 | cmd.current_dir(&project_path) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_profiles_add_integration_test.rs:29:45 [INFO] [stdout] | [INFO] [stdout] 29 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_profiles_add_integration_test.rs:58:45 [INFO] [stdout] | [INFO] [stdout] 58 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cli/tests/project_preprocessors_remove_integration_test.rs:29:21 [INFO] [stdout] | [INFO] [stdout] 29 | cmd.current_dir(&project_path) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_preprocessors_remove_integration_test.rs:44:45 [INFO] [stdout] | [INFO] [stdout] 44 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_preprocessors_remove_integration_test.rs:72:45 [INFO] [stdout] | [INFO] [stdout] 72 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_preprocessors_remove_integration_test.rs:115:45 [INFO] [stdout] | [INFO] [stdout] 115 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_markdown_remove_integration_test.rs:32:45 [INFO] [stdout] | [INFO] [stdout] 32 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_templates_add_integration_test.rs:30:45 [INFO] [stdout] | [INFO] [stdout] 30 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_templates_add_integration_test.rs:60:45 [INFO] [stdout] | [INFO] [stdout] 60 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_templates_add_integration_test.rs:99:45 [INFO] [stdout] | [INFO] [stdout] 99 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_templates_add_integration_test.rs:139:45 [INFO] [stdout] | [INFO] [stdout] 139 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_templates_add_integration_test.rs:184:45 [INFO] [stdout] | [INFO] [stdout] 184 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_templates_add_integration_test.rs:224:45 [INFO] [stdout] | [INFO] [stdout] 224 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_templates_add_integration_test.rs:258:45 [INFO] [stdout] | [INFO] [stdout] 258 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_markdown_remove_integration_test.rs:76:45 [INFO] [stdout] | [INFO] [stdout] 76 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cli/tests/project_templates_remove_integration_test.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 31 | cmd.current_dir(&project_path) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_templates_remove_integration_test.rs:53:45 [INFO] [stdout] | [INFO] [stdout] 53 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_templates_remove_integration_test.rs:85:45 [INFO] [stdout] | [INFO] [stdout] 85 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_shared_meta_remove_integration_test.rs:32:45 [INFO] [stdout] | [INFO] [stdout] 32 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_templates_remove_integration_test.rs:105:45 [INFO] [stdout] | [INFO] [stdout] 105 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_shared_meta_remove_integration_test.rs:64:45 [INFO] [stdout] | [INFO] [stdout] 64 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_processors_remove_integration_test.rs:30:45 [INFO] [stdout] | [INFO] [stdout] 30 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_processors_remove_integration_test.rs:63:45 [INFO] [stdout] | [INFO] [stdout] 63 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cli/tests/project_processors_remove_integration_test.rs:80:21 [INFO] [stdout] | [INFO] [stdout] 80 | cmd.current_dir(&project_path) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cli/tests/project_templates_update_integration_test.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 37 | cmd.current_dir(&project_path) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_templates_update_integration_test.rs:63:45 [INFO] [stdout] | [INFO] [stdout] 63 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_templates_update_integration_test.rs:102:45 [INFO] [stdout] | [INFO] [stdout] 102 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_templates_update_integration_test.rs:141:45 [INFO] [stdout] | [INFO] [stdout] 141 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_templates_update_integration_test.rs:180:45 [INFO] [stdout] | [INFO] [stdout] 180 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_templates_update_integration_test.rs:221:45 [INFO] [stdout] | [INFO] [stdout] 221 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_templates_update_integration_test.rs:271:45 [INFO] [stdout] | [INFO] [stdout] 271 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_templates_update_integration_test.rs:299:45 [INFO] [stdout] | [INFO] [stdout] 299 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_templates_update_integration_test.rs:339:45 [INFO] [stdout] | [INFO] [stdout] 339 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_templates_update_integration_test.rs:381:45 [INFO] [stdout] | [INFO] [stdout] 381 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_injections_add_tests.rs:36:45 [INFO] [stdout] | [INFO] [stdout] 36 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_injections_add_tests.rs:69:45 [INFO] [stdout] | [INFO] [stdout] 69 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_templates_update_integration_test.rs:409:45 [INFO] [stdout] | [INFO] [stdout] 409 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_templates_update_integration_test.rs:454:45 [INFO] [stdout] | [INFO] [stdout] 454 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cli/tests/project_injections_remove_tests.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 30 | cmd.current_dir(&project_path) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_injections_remove_tests.rs:47:45 [INFO] [stdout] | [INFO] [stdout] 47 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_markdown_meta_set_integration_test.rs:59:45 [INFO] [stdout] | [INFO] [stdout] 59 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_markdown_meta_set_integration_test.rs:94:45 [INFO] [stdout] | [INFO] [stdout] 94 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_markdown_meta_set_integration_test.rs:139:45 [INFO] [stdout] | [INFO] [stdout] 139 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_markdown_add_integration_test.rs:32:45 [INFO] [stdout] | [INFO] [stdout] 32 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_markdown_add_integration_test.rs:61:45 [INFO] [stdout] | [INFO] [stdout] 61 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_markdown_add_integration_test.rs:106:45 [INFO] [stdout] | [INFO] [stdout] 106 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_processors_add_integration_test.rs:29:45 [INFO] [stdout] | [INFO] [stdout] 29 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/project_processors_add_integration_test.rs:59:45 [INFO] [stdout] | [INFO] [stdout] 59 | let project_path = create_empty_project(&temp_dir.path()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cli/tests/convert_integration_test.rs:117:21 [INFO] [stdout] | [INFO] [stdout] 117 | cmd.current_dir(&project_path) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cli/tests/convert_integration_test.rs:146:21 [INFO] [stdout] | [INFO] [stdout] 146 | cmd.current_dir(&project_path) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cli/tests/convert_integration_test.rs:163:21 [INFO] [stdout] | [INFO] [stdout] 163 | cmd.current_dir(&project_path) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/convert_integration_test.rs:185:45 [INFO] [stdout] | [INFO] [stdout] 185 | let project_path = create_empty_project(&temp_dir.path(), vec![]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/convert_integration_test.rs:205:45 [INFO] [stdout] | [INFO] [stdout] 205 | let project_path = create_empty_project(&temp_dir.path(), vec![]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/convert_integration_test.rs:266:45 [INFO] [stdout] | [INFO] [stdout] 266 | let project_path = create_empty_project(&temp_dir.path(), vec![]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/convert_integration_test.rs:309:45 [INFO] [stdout] | [INFO] [stdout] 309 | let project_path = create_empty_project(&temp_dir.path(), vec![]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/convert_integration_test.rs:365:45 [INFO] [stdout] | [INFO] [stdout] 365 | let project_path = create_empty_project(&temp_dir.path(), vec![]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/convert_integration_test.rs:385:45 [INFO] [stdout] | [INFO] [stdout] 385 | let project_path = create_empty_project(&temp_dir.path(), vec![]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/convert_integration_test.rs:408:45 [INFO] [stdout] | [INFO] [stdout] 408 | let project_path = create_empty_project(&temp_dir.path(), vec![]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/convert_integration_test.rs:434:45 [INFO] [stdout] | [INFO] [stdout] 434 | let project_path = create_empty_project(&temp_dir.path(), vec![]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cli/tests/convert_integration_test.rs:449:21 [INFO] [stdout] | [INFO] [stdout] 449 | cmd.current_dir(&project_path) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/convert_integration_test.rs:462:45 [INFO] [stdout] | [INFO] [stdout] 462 | let project_path = create_empty_project(&temp_dir.path(), vec![]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/convert_integration_test.rs:488:45 [INFO] [stdout] | [INFO] [stdout] 488 | let project_path = create_empty_project(&temp_dir.path(), vec![]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/convert_integration_test.rs:508:45 [INFO] [stdout] | [INFO] [stdout] 508 | let project_path = create_empty_project(&temp_dir.path(), vec![]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/convert_integration_test.rs:561:9 [INFO] [stdout] | [INFO] [stdout] 561 | &temp_dir.path(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/convert_integration_test.rs:590:45 [INFO] [stdout] | [INFO] [stdout] 590 | let project_path = create_empty_project(&temp_dir.path(), vec![]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cli/tests/convert_integration_test.rs:621:21 [INFO] [stdout] | [INFO] [stdout] 621 | cmd.current_dir(&project_path) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/convert_integration_test.rs:634:45 [INFO] [stdout] | [INFO] [stdout] 634 | let project_path = create_empty_project(&temp_dir.path(), vec![]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> cli/tests/convert_integration_test.rs:680:21 [INFO] [stdout] | [INFO] [stdout] 680 | cmd.current_dir(&project_path) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `project_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> cli/tests/convert_integration_test.rs:695:45 [INFO] [stdout] | [INFO] [stdout] 695 | let project_path = create_empty_project(&temp_dir.path(), vec![]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `temp_dir.path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> cli/src/cli.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 | / pub(crate) enum Commands { [INFO] [stdout] 30 | | #[command( [INFO] [stdout] 31 | | about = "Convert a TiefDown project. By default, it will convert the current directory." [INFO] [stdout] 32 | | )] [INFO] [stdout] 33 | | / Convert { [INFO] [stdout] 34 | | | #[arg( [INFO] [stdout] 35 | | | short, [INFO] [stdout] 36 | | | long, [INFO] [stdout] ... | | [INFO] [stdout] 63 | | | markdown_projects: Option>, [INFO] [stdout] 64 | | | }, [INFO] [stdout] | | |_____- the second-largest variant contains at least 96 bytes [INFO] [stdout] ... | [INFO] [stdout] 115 | | / Project { [INFO] [stdout] 116 | | | #[arg(help = "The project to edit. If not provided, the current directory will be used.")] [INFO] [stdout] 117 | | | project: Option, [INFO] [stdout] 118 | | | #[command(subcommand)] [INFO] [stdout] 119 | | | command: ProjectCommands, [INFO] [stdout] 120 | | | }, [INFO] [stdout] | | |_____- the largest variant contains at least 440 bytes [INFO] [stdout] 121 | | #[command(about = "Validate dependencies are installed.")] [INFO] [stdout] 122 | | CheckDependencies, [INFO] [stdout] 123 | | } [INFO] [stdout] | |___^ the entire enum is at least 440 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 119 - command: ProjectCommands, [INFO] [stdout] 119 + command: Box, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> cli/src/cli.rs:126:1 [INFO] [stdout] | [INFO] [stdout] 126 | / pub(crate) enum ProjectCommands { [INFO] [stdout] 127 | | #[command(about = "Add or modify templates in the project.")] [INFO] [stdout] 128 | | / Templates { [INFO] [stdout] 129 | | | #[arg(help = "The template name to edit or add.")] [INFO] [stdout] 130 | | | template: String, [INFO] [stdout] 131 | | | #[command(subcommand)] [INFO] [stdout] 132 | | | command: TemplatesCommands, [INFO] [stdout] 133 | | | }, [INFO] [stdout] | | |_____- the largest variant contains at least 416 bytes [INFO] [stdout] ... | [INFO] [stdout] 207 | | / Markdown { [INFO] [stdout] 208 | | | #[command(subcommand)] [INFO] [stdout] 209 | | | command: ManageMarkdownProjectsCommand, [INFO] [stdout] 210 | | | }, [INFO] [stdout] | | |_____- the second-largest variant contains at least 104 bytes [INFO] [stdout] ... | [INFO] [stdout] 235 | | SmartClean, [INFO] [stdout] 236 | | } [INFO] [stdout] | |___^ the entire enum is at least 416 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 132 - command: TemplatesCommands, [INFO] [stdout] 132 + command: Box, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> cli/src/cli.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 | / pub(crate) enum Commands { [INFO] [stdout] 30 | | #[command( [INFO] [stdout] 31 | | about = "Convert a TiefDown project. By default, it will convert the current directory." [INFO] [stdout] 32 | | )] [INFO] [stdout] 33 | | / Convert { [INFO] [stdout] 34 | | | #[arg( [INFO] [stdout] 35 | | | short, [INFO] [stdout] 36 | | | long, [INFO] [stdout] ... | | [INFO] [stdout] 63 | | | markdown_projects: Option>, [INFO] [stdout] 64 | | | }, [INFO] [stdout] | | |_____- the second-largest variant contains at least 96 bytes [INFO] [stdout] ... | [INFO] [stdout] 115 | | / Project { [INFO] [stdout] 116 | | | #[arg(help = "The project to edit. If not provided, the current directory will be used.")] [INFO] [stdout] 117 | | | project: Option, [INFO] [stdout] 118 | | | #[command(subcommand)] [INFO] [stdout] 119 | | | command: ProjectCommands, [INFO] [stdout] 120 | | | }, [INFO] [stdout] | | |_____- the largest variant contains at least 440 bytes [INFO] [stdout] 121 | | #[command(about = "Validate dependencies are installed.")] [INFO] [stdout] 122 | | CheckDependencies, [INFO] [stdout] 123 | | } [INFO] [stdout] | |___^ the entire enum is at least 440 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 119 - command: ProjectCommands, [INFO] [stdout] 119 + command: Box, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> cli/src/cli.rs:126:1 [INFO] [stdout] | [INFO] [stdout] 126 | / pub(crate) enum ProjectCommands { [INFO] [stdout] 127 | | #[command(about = "Add or modify templates in the project.")] [INFO] [stdout] 128 | | / Templates { [INFO] [stdout] 129 | | | #[arg(help = "The template name to edit or add.")] [INFO] [stdout] 130 | | | template: String, [INFO] [stdout] 131 | | | #[command(subcommand)] [INFO] [stdout] 132 | | | command: TemplatesCommands, [INFO] [stdout] 133 | | | }, [INFO] [stdout] | | |_____- the largest variant contains at least 416 bytes [INFO] [stdout] ... | [INFO] [stdout] 207 | | / Markdown { [INFO] [stdout] 208 | | | #[command(subcommand)] [INFO] [stdout] 209 | | | command: ManageMarkdownProjectsCommand, [INFO] [stdout] 210 | | | }, [INFO] [stdout] | | |_____- the second-largest variant contains at least 104 bytes [INFO] [stdout] ... | [INFO] [stdout] 235 | | SmartClean, [INFO] [stdout] 236 | | } [INFO] [stdout] | |___^ the entire enum is at least 416 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 132 - command: TemplatesCommands, [INFO] [stdout] 132 + command: Box, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> cli/src/main.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | format!("{}", self.level_color(level, self.level_token(level)),) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `self.level_color(level, self.level_token(level)).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `writeln!` args [INFO] [stdout] --> cli/src/main.rs:41:52 [INFO] [stdout] | [INFO] [stdout] 41 | writeln!(buf, "{}{}", prefix, record.args().to_string(),) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct pattern is not needed for a unit variant [INFO] [stdout] --> cli/src/main.rs:246:46 [INFO] [stdout] | [INFO] [stdout] 246 | ManageInjectionsCommand::List {} => { [INFO] [stdout] | ^^^ help: remove the struct pattern [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern [INFO] [stdout] = note: `#[warn(clippy::unneeded_struct_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> cli/src/main.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | format!("{}", self.level_color(level, self.level_token(level)),) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `self.level_color(level, self.level_token(level)).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `writeln!` args [INFO] [stdout] --> cli/src/main.rs:41:52 [INFO] [stdout] | [INFO] [stdout] 41 | writeln!(buf, "{}{}", prefix, record.args().to_string(),) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct pattern is not needed for a unit variant [INFO] [stdout] --> cli/src/main.rs:246:46 [INFO] [stdout] | [INFO] [stdout] 246 | ManageInjectionsCommand::List {} => { [INFO] [stdout] | ^^^ help: remove the struct pattern [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern [INFO] [stdout] = note: `#[warn(clippy::unneeded_struct_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 25.74s [INFO] running `Command { std: "docker" "inspect" "4610c097951f8a321cfdd81e0db9bdc29d17ced5ebec0271d866d37aefcdeb1e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4610c097951f8a321cfdd81e0db9bdc29d17ced5ebec0271d866d37aefcdeb1e", kill_on_drop: false }` [INFO] [stdout] 4610c097951f8a321cfdd81e0db9bdc29d17ced5ebec0271d866d37aefcdeb1e