[INFO] cloning repository https://github.com/TheLion102009/Lion-Launcher [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TheLion102009/Lion-Launcher" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTheLion102009%2FLion-Launcher", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTheLion102009%2FLion-Launcher'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b01d7b2d69bc085415ffdff1b2ac74832795253b [INFO] linting TheLion102009/Lion-Launcher against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTheLion102009%2FLion-Launcher" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-7-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/TheLion102009/Lion-Launcher [INFO] finished tweaking git repo https://github.com/TheLion102009/Lion-Launcher [INFO] tweaked toml for git repo https://github.com/TheLion102009/Lion-Launcher written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/TheLion102009/Lion-Launcher on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/TheLion102009/Lion-Launcher already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serialize-to-javascript-impl v0.1.2 [INFO] [stderr] Downloaded schemars_derive v0.8.22 [INFO] [stderr] Downloaded zmij v1.0.17 [INFO] [stderr] Downloaded directories v5.0.1 [INFO] [stderr] Downloaded phf_macros v0.10.0 [INFO] [stderr] Downloaded serialize-to-javascript v0.1.2 [INFO] [stderr] Downloaded gdkx11 v0.18.2 [INFO] [stderr] Downloaded dlopen2 v0.8.2 [INFO] [stderr] Downloaded tauri-codegen v2.5.2 [INFO] [stderr] Downloaded cargo_toml v0.22.3 [INFO] [stderr] Downloaded softbuffer v0.4.8 [INFO] [stderr] Downloaded hyper-util v0.1.19 [INFO] [stderr] Downloaded zerocopy-derive v0.8.34 [INFO] [stderr] Downloaded time v0.3.46 [INFO] [stderr] Downloaded schemars v1.2.0 [INFO] [stderr] Downloaded objc2-web-kit v0.3.2 [INFO] [stderr] Downloaded wry v0.53.5 [INFO] [stderr] Downloaded schemars v0.9.0 [INFO] [stderr] Downloaded muda v0.17.1 [INFO] [stderr] Downloaded objc2-security v0.3.2 [INFO] [stderr] Downloaded zerocopy v0.8.34 [INFO] [stderr] Downloaded tao v0.34.5 [INFO] [stderr] Downloaded tauri v2.9.5 [INFO] [stderr] Downloaded objc2-core-image v0.3.2 [INFO] [stderr] Downloaded objc2-core-text v0.3.2 [INFO] [stderr] Downloaded tauri-utils v2.8.1 [INFO] [stderr] Downloaded tauri-runtime-wry v2.9.3 [INFO] [stderr] Downloaded tray-icon v0.21.3 [INFO] [stderr] Downloaded html5ever v0.29.1 [INFO] [stderr] Downloaded cssparser v0.29.6 [INFO] [stderr] Downloaded schemars v0.8.22 [INFO] [stderr] Downloaded tauri-plugin-shell v2.3.4 [INFO] [stderr] Downloaded tauri-build v2.5.3 [INFO] [stderr] Downloaded ico v0.4.0 [INFO] [stderr] Downloaded tauri-macros v2.5.2 [INFO] [stderr] Downloaded bzip2-sys v0.1.13+1.0.8 [INFO] [stderr] Downloaded objc2-cloud-kit v0.3.2 [INFO] [stderr] Downloaded objc2-core-data v0.3.2 [INFO] [stderr] Downloaded objc2-core-video v0.3.2 [INFO] [stderr] Downloaded plist v1.8.0 [INFO] [stderr] Downloaded camino v1.2.2 [INFO] [stderr] Downloaded markup5ever v0.14.1 [INFO] [stderr] Downloaded selectors v0.24.0 [INFO] [stderr] Downloaded cc v1.2.54 [INFO] [stderr] Downloaded tauri-runtime v2.9.2 [INFO] [stderr] Downloaded ctor v0.2.9 [INFO] [stderr] Downloaded infer v0.19.0 [INFO] [stderr] Downloaded dtoa v1.0.11 [INFO] [stderr] Downloaded servo_arc v0.2.0 [INFO] [stderr] Downloaded objc2-javascript-core v0.3.2 [INFO] [stderr] Downloaded objc2-exception-helper v0.1.1 [INFO] [stderr] Downloaded serde-untagged v0.1.9 [INFO] [stderr] Downloaded webview2-com-macros v0.8.1 [INFO] [stderr] Downloaded toml v0.9.11+spec-1.1.0 [INFO] [stderr] Downloaded tauri-plugin v2.5.2 [INFO] [stderr] Downloaded time-macros v0.2.26 [INFO] [stderr] Downloaded find-msvc-tools v0.1.8 [INFO] [stderr] Downloaded tauri-winres v0.3.5 [INFO] [stderr] Downloaded webview2-com v0.38.2 [INFO] [stderr] Downloaded cargo_metadata v0.19.2 [INFO] [stderr] Downloaded kuchikiki v0.8.8-speedreader [INFO] [stderr] Downloaded window-vibrancy v0.6.0 [INFO] [stderr] Downloaded webview2-com-sys v0.38.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 370aa6151b0acf9f859a32fddd4f281eff249a1270d64fcda9ca142526488ead [INFO] running `Command { std: "docker" "start" "-a" "370aa6151b0acf9f859a32fddd4f281eff249a1270d64fcda9ca142526488ead", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "370aa6151b0acf9f859a32fddd4f281eff249a1270d64fcda9ca142526488ead", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "370aa6151b0acf9f859a32fddd4f281eff249a1270d64fcda9ca142526488ead", kill_on_drop: false }` [INFO] [stdout] 370aa6151b0acf9f859a32fddd4f281eff249a1270d64fcda9ca142526488ead [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 33a1e4c2116f44a5a4b92ab5fe4b1cbed05ba7ec0d61654a61958dedb7d23f37 [INFO] running `Command { std: "docker" "start" "-a" "33a1e4c2116f44a5a4b92ab5fe4b1cbed05ba7ec0d61654a61958dedb7d23f37", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling smallvec v1.15.1 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Compiling cfg-if v1.0.4 [INFO] [stderr] Compiling zerocopy v0.8.34 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling find-msvc-tools v0.1.8 [INFO] [stderr] Compiling stable_deref_trait v1.2.1 [INFO] [stderr] Compiling cfg-expr v0.15.8 [INFO] [stderr] Compiling memchr v2.7.6 [INFO] [stderr] Compiling zmij v1.0.17 [INFO] [stderr] Compiling siphasher v1.0.2 [INFO] [stderr] Compiling phf_shared v0.11.3 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling typeid v1.0.3 [INFO] [stderr] Compiling litemap v0.8.1 [INFO] [stderr] Compiling itoa v1.0.17 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Compiling writeable v0.6.2 [INFO] [stderr] Compiling erased-serde v0.4.9 [INFO] [stderr] Compiling phf_shared v0.8.0 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling syn v2.0.114 [INFO] [stderr] Compiling getrandom v0.2.17 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling cc v1.2.54 [INFO] [stderr] Compiling rand_core v0.5.1 [INFO] [stderr] Compiling icu_properties_data v2.1.2 [INFO] [stderr] Compiling icu_normalizer_data v2.1.1 [INFO] [stderr] Compiling scopeguard v1.2.0 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Compiling rand_pcg v0.2.1 [INFO] [stderr] Compiling new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling lock_api v0.4.14 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Compiling winnow v0.7.14 [INFO] [stderr] Compiling mac v0.1.1 [INFO] [stderr] Compiling precomputed-hash v0.1.1 [INFO] [stderr] Compiling futf v0.1.5 [INFO] [stderr] Compiling parking_lot v0.12.5 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Compiling log v0.4.29 [INFO] [stderr] Compiling dtoa v1.0.11 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling utf-8 v0.7.6 [INFO] [stderr] Compiling utf8_iter v1.0.4 [INFO] [stderr] Compiling toml_writer v1.0.6+spec-1.1.0 [INFO] [stderr] Compiling percent-encoding v2.3.2 [INFO] [stderr] Compiling form_urlencoded v1.2.2 [INFO] [stderr] Compiling tendril v0.4.3 [INFO] [stderr] Compiling dtoa-short v0.3.5 [INFO] [stderr] Compiling aho-corasick v1.1.4 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling gio v0.18.4 [INFO] [stderr] Compiling nodrop v0.1.14 [INFO] [stderr] Compiling camino v1.2.2 [INFO] [stderr] Checking bytes v1.11.0 [INFO] [stderr] Compiling ppv-lite86 v0.2.21 [INFO] [stderr] Compiling regex-syntax v0.8.8 [INFO] [stderr] Compiling semver v1.0.27 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling rand_chacha v0.3.1 [INFO] [stderr] Compiling rand_chacha v0.2.2 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling rand v0.7.3 [INFO] [stderr] Compiling toml_parser v1.0.6+spec-1.1.0 [INFO] [stderr] Compiling toml_datetime v0.7.5+spec-1.1.0 [INFO] [stderr] Compiling serde_spanned v1.0.4 [INFO] [stderr] Compiling phf_generator v0.11.3 [INFO] [stderr] Compiling phf_generator v0.10.0 [INFO] [stderr] Compiling phf_generator v0.8.0 [INFO] [stderr] Compiling string_cache_codegen v0.5.4 [INFO] [stderr] Compiling phf_codegen v0.11.3 [INFO] [stderr] Compiling phf_codegen v0.8.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling darling_core v0.21.3 [INFO] [stderr] Compiling selectors v0.24.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling markup5ever v0.14.1 [INFO] [stderr] Compiling toml v0.9.11+spec-1.1.0 [INFO] [stderr] Compiling uuid v1.20.0 [INFO] [stderr] Compiling unic-char-range v0.9.0 [INFO] [stderr] Compiling matches v0.1.10 [INFO] [stderr] Compiling alloc-no-stdlib v2.0.4 [INFO] [stderr] Compiling unic-common v0.9.0 [INFO] [stderr] Compiling unic-ucd-version v0.9.0 [INFO] [stderr] Compiling alloc-stdlib v0.2.2 [INFO] [stderr] Compiling unic-char-property v0.9.0 [INFO] [stderr] Compiling regex-automata v0.4.13 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Compiling servo_arc v0.2.0 [INFO] [stderr] Compiling fxhash v0.2.1 [INFO] [stderr] Compiling phf v0.8.0 [INFO] [stderr] Compiling hashbrown v0.12.3 [INFO] [stderr] Compiling schemars v0.8.22 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling zerofrom v0.1.6 [INFO] [stderr] Compiling phf_macros v0.11.3 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling darling_macro v0.21.3 [INFO] [stderr] Compiling zerovec v0.11.5 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling zerotrie v0.2.3 [INFO] [stderr] Compiling darling v0.21.3 [INFO] [stderr] Compiling serde_with_macros v3.16.1 [INFO] [stderr] Compiling phf_macros v0.10.0 [INFO] [stderr] Compiling tinystr v0.8.2 [INFO] [stderr] Compiling potential_utf v0.1.4 [INFO] [stderr] Compiling cssparser v0.29.6 [INFO] [stderr] Compiling icu_locale_core v2.1.1 [INFO] [stderr] Compiling icu_collections v2.1.1 [INFO] [stderr] Compiling phf v0.10.1 [INFO] [stderr] Compiling phf v0.11.3 [INFO] [stderr] Compiling cssparser-macros v0.6.1 [INFO] [stderr] Compiling ctor v0.2.9 [INFO] [stderr] Compiling derive_more v0.99.20 [INFO] [stderr] Compiling match_token v0.1.0 [INFO] [stderr] Compiling icu_provider v2.1.1 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Compiling thiserror v2.0.18 [INFO] [stderr] Compiling icu_properties v2.1.2 [INFO] [stderr] Compiling icu_normalizer v2.1.1 [INFO] [stderr] Compiling regex v1.12.2 [INFO] [stderr] Compiling toml_datetime v0.6.3 [INFO] [stderr] Compiling serde_spanned v0.6.9 [INFO] [stderr] Compiling string_cache v0.8.9 [INFO] [stderr] Compiling jsonptr v0.6.3 [INFO] [stderr] Compiling toml_edit v0.20.2 [INFO] [stderr] Compiling cargo-platform v0.1.9 [INFO] [stderr] Compiling schemars_derive v0.8.22 [INFO] [stderr] Compiling unic-ucd-ident v0.9.0 [INFO] [stderr] Compiling html5ever v0.29.1 [INFO] [stderr] Compiling brotli-decompressor v5.0.0 [INFO] [stderr] Compiling idna_adapter v1.2.1 [INFO] [stderr] Compiling cfb v0.7.3 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Compiling idna v1.1.0 [INFO] [stderr] Compiling url v2.5.8 [INFO] [stderr] Compiling dunce v1.0.5 [INFO] [stderr] Compiling dyn-clone v1.0.20 [INFO] [stderr] Compiling infer v0.19.0 [INFO] [stderr] Compiling brotli v8.0.2 [INFO] [stderr] Compiling http v1.4.0 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Compiling urlpattern v0.3.0 [INFO] [stderr] Compiling cargo_metadata v0.19.2 [INFO] [stderr] Compiling toml v0.8.2 [INFO] [stderr] Compiling system-deps v6.2.2 [INFO] [stderr] Compiling proc-macro-crate v2.0.2 [INFO] [stderr] Compiling json-patch v3.0.1 [INFO] [stderr] Compiling kuchikiki v0.8.8-speedreader [INFO] [stderr] Compiling serde_with v3.16.1 [INFO] [stderr] Compiling serde-untagged v0.1.9 [INFO] [stderr] Compiling anyhow v1.0.100 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling glob v0.3.3 [INFO] [stderr] Compiling glib-sys v0.18.1 [INFO] [stderr] Compiling gobject-sys v0.18.0 [INFO] [stderr] Compiling gio-sys v0.18.1 [INFO] [stderr] Compiling gdk-sys v0.18.2 [INFO] [stderr] Compiling glib-macros v0.18.5 [INFO] [stderr] Compiling cairo-sys-rs v0.18.2 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.18.0 [INFO] [stderr] Compiling pango-sys v0.18.0 [INFO] [stderr] Compiling atk-sys v0.18.2 [INFO] [stderr] Compiling gtk-sys v0.18.2 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling field-offset v0.3.6 [INFO] [stderr] Compiling javascriptcore-rs-sys v1.1.1 [INFO] [stderr] Compiling soup3-sys v0.5.0 [INFO] [stderr] Compiling gtk v0.18.2 [INFO] [stderr] Compiling option-ext v0.2.0 [INFO] [stderr] Compiling dirs-sys v0.5.0 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling tauri-utils v2.8.1 [INFO] [stderr] Compiling webkit2gtk-sys v2.0.1 [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling embed-resource v3.0.6 [INFO] [stderr] Compiling typenum v1.19.0 [INFO] [stderr] Compiling simd-adler32 v0.3.8 [INFO] [stderr] Compiling time-macros v0.2.26 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking deranged v0.5.5 [INFO] [stderr] Checking glib v0.18.5 [INFO] [stderr] Compiling tauri-winres v0.3.5 [INFO] [stderr] Compiling gtk3-macros v0.18.2 [INFO] [stderr] Compiling dirs v6.0.0 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Compiling gdkx11-sys v0.18.2 [INFO] [stderr] Compiling cargo_toml v0.22.3 [INFO] [stderr] Compiling adler2 v2.0.1 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking time v0.3.46 [INFO] [stderr] Compiling miniz_oxide v0.8.9 [INFO] [stderr] Checking x11 v2.21.0 [INFO] [stderr] Compiling crc32fast v1.5.0 [INFO] [stderr] Checking dpi v0.1.2 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Compiling cookie v0.18.1 [INFO] [stderr] Compiling flate2 v1.1.8 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling fdeflate v0.3.7 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling zstd-sys v2.0.16+zstd.1.5.7 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Compiling ucd-trie v0.1.7 [INFO] [stderr] Compiling pest v2.8.5 [INFO] [stderr] Compiling png v0.17.16 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking cairo-rs v0.18.5 [INFO] [stderr] Checking atk v0.18.2 [INFO] [stderr] Checking javascriptcore-rs v1.1.2 [INFO] [stderr] Compiling tauri-build v2.5.3 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling dlopen2_derive v0.4.3 [INFO] [stderr] Compiling cpufeatures v0.2.17 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Compiling wry v0.53.5 [INFO] [stderr] Compiling tauri-runtime v2.9.2 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking dlopen2 v0.8.2 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Compiling sha2 v0.10.9 [INFO] [stderr] Compiling tauri-plugin v2.5.2 [INFO] [stderr] Compiling pest_meta v2.8.5 [INFO] [stderr] Compiling ico v0.4.0 [INFO] [stderr] Checking gdkwayland-sys v0.18.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling bzip2-sys v0.1.13+1.0.8 [INFO] [stderr] Compiling zstd-safe v5.0.2+zstd.1.5.2 [INFO] [stderr] Compiling base64 v0.22.1 [INFO] [stderr] Compiling rayon-core v1.13.0 [INFO] [stderr] Compiling tauri-runtime-wry v2.9.3 [INFO] [stderr] Checking keyboard-types v0.7.0 [INFO] [stderr] Compiling tauri-codegen v2.5.2 [INFO] [stderr] Compiling pest_generator v2.8.5 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Compiling serialize-to-javascript-impl v0.1.2 [INFO] [stderr] Checking is-docker v0.2.0 [INFO] [stderr] Checking os_pipe v1.2.3 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking base64ct v1.8.3 [INFO] [stderr] Checking dlv-list v0.3.0 [INFO] [stderr] Checking pathdiff v0.2.3 [INFO] [stderr] Checking ordered-multimap v0.4.3 [INFO] [stderr] Checking password-hash v0.4.2 [INFO] [stderr] Checking serialize-to-javascript v0.1.2 [INFO] [stderr] Checking sigchld v0.2.4 [INFO] [stderr] Checking is-wsl v0.4.0 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Compiling pest_derive v2.8.5 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking heck v0.5.0 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking ron v0.7.1 [INFO] [stderr] Checking json5 v0.4.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking open v5.3.3 [INFO] [stderr] Checking shared_child v1.1.1 [INFO] [stderr] Checking rust-ini v0.18.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking nu-ansi-term v0.50.3 [INFO] [stderr] Compiling tauri v2.9.5 [INFO] [stderr] Compiling tauri-plugin-shell v2.3.4 [INFO] [stderr] Compiling tauri-macros v2.5.2 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Compiling Lion-Launcher v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Checking config v0.13.4 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking tracing-subscriber v0.3.22 [INFO] [stderr] Checking sysinfo v0.30.13 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking zstd v0.11.2+zstd.1.5.2 [INFO] [stderr] Checking zip v0.6.6 [INFO] [stderr] Checking pango v0.18.3 [INFO] [stderr] Checking gdk-pixbuf v0.18.5 [INFO] [stderr] Checking soup3 v0.5.0 [INFO] [stderr] Checking gdk v0.18.2 [INFO] [stderr] Checking gdkx11 v0.18.2 [INFO] [stderr] Checking webkit2gtk v2.0.1 [INFO] [stderr] Checking tao v0.34.5 [INFO] [stderr] Checking muda v0.17.1 [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/core/minecraft/neoforge.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / /// Basierend auf PandoraLauncher und PrismLauncher Best Practices [INFO] [stdout] 8 | | [INFO] [stdout] | |_^ [INFO] [stdout] 9 | /// Ermittelt die neueste NeoForge-Version für eine Minecraft-Version dynamisch von der API [INFO] [stdout] 10 | async fn get_latest_neoforge_version(mc_version: &str) -> Result { [INFO] [stdout] | ------------------------------------ the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 8 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> src/core/minecraft/neoforge.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / /// Basierend auf PandoraLauncher und PrismLauncher Best Practices [INFO] [stdout] 8 | | [INFO] [stdout] | |_^ [INFO] [stdout] 9 | /// Ermittelt die neueste NeoForge-Version für eine Minecraft-Version dynamisch von der API [INFO] [stdout] 10 | async fn get_latest_neoforge_version(mc_version: &str) -> Result { [INFO] [stdout] | ------------------------------------ the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the documentation should include the empty line include it in the comment [INFO] [stdout] | [INFO] [stdout] 8 | /// [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `ModSource` which implements the `Copy` trait [INFO] [stdout] --> src/gui/mod_browser.rs:131:62 [INFO] [stdout] | [INFO] [stdout] 131 | let all_versions = manager.get_mod_versions_raw(&mod_id, mod_source.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `mod_source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/gui/mod.rs:48:33 [INFO] [stdout] | [INFO] [stdout] 48 | .filter(|e| e.path().extension().map_or(false, |ext| ext == "txt")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 48 - .filter(|e| e.path().extension().map_or(false, |ext| ext == "txt")) [INFO] [stdout] 48 + .filter(|e| e.path().extension().is_some_and(|ext| ext == "txt")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/gui/mod.rs:188:27 [INFO] [stdout] | [INFO] [stdout] 188 | let pattern = format!("neoforge-"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"neoforge-".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/gui/mod.rs:469:36 [INFO] [stdout] | [INFO] [stdout] 469 | Some(name_part.replace('-', " ").replace('_', " ")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['-', '_'], " ")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] = note: `#[warn(clippy::collapsible_str_replace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/gui/mod.rs:484:32 [INFO] [stdout] | [INFO] [stdout] 484 | Some(name_part.replace('-', " ").replace('_', " ")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['-', '_'], " ")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/gui/mod.rs:493:22 [INFO] [stdout] | [INFO] [stdout] 493 | (Some(clean_name.replace('-', " ").replace('_', " ")), None, mod_id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['-', '_'], " ")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/gui/mod.rs:659:17 [INFO] [stdout] | [INFO] [stdout] 659 | / if let Some(latest) = modrinth_info { [INFO] [stdout] 660 | | let has_update = mod_info.version.as_ref() [INFO] [stdout] 661 | | .map(|v| v != &latest.version) [INFO] [stdout] 662 | | .unwrap_or(false); [INFO] [stdout] ... | [INFO] [stdout] 673 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/gui/mod.rs:658:23 [INFO] [stdout] | [INFO] [stdout] 658 | if let Ok(modrinth_info) = search_modrinth_by_name(mod_id).await { [INFO] [stdout] | ^^^^^^^^^^^^^ replace this binding [INFO] [stdout] 659 | if let Some(latest) = modrinth_info { [INFO] [stdout] | ^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/gui/mod.rs:811:5 [INFO] [stdout] | [INFO] [stdout] 811 | packs.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 811 - packs.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] 811 + packs.sort_by_key(|a| a.name.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/gui/mod.rs:863:5 [INFO] [stdout] | [INFO] [stdout] 863 | packs.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 863 - packs.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] 863 + packs.sort_by_key(|a| a.name.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/gui/mod.rs:997:46 [INFO] [stdout] | [INFO] [stdout] 997 | if !is_blacklisted_key(&key) { [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 998 | | combined_values.insert(key, value); [INFO] [stdout] 999 | | } else if !combined_values.contains_key(&key) { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/gui/mod.rs:999:63 [INFO] [stdout] | [INFO] [stdout] 999 | } else if !combined_values.contains_key(&key) { [INFO] [stdout] | _______________________________________________________________^ [INFO] [stdout] 1000 | | combined_values.insert(key, value); [INFO] [stdout] 1001 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/gui/mod.rs:999:24 [INFO] [stdout] | [INFO] [stdout] 999 | } else if !combined_values.contains_key(&key) { [INFO] [stdout] | ________________________^ [INFO] [stdout] 1000 | | combined_values.insert(key, value); [INFO] [stdout] 1001 | | } [INFO] [stdout] | |_________________^ help: try: `combined_values.entry(key).or_insert(value);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/gui/mod.rs:1149:17 [INFO] [stdout] | [INFO] [stdout] 1149 | / if !settings.contains_key(&key) { [INFO] [stdout] 1150 | | settings.insert(key, value); [INFO] [stdout] 1151 | | } [INFO] [stdout] | |_________________^ help: try: `settings.entry(key).or_insert(value);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/core/minecraft/installer.rs:59:32 [INFO] [stdout] | [INFO] [stdout] 59 | if let Ok(_) = self.download_manager.download_with_hash(&url, &lib_dest, None).await { [INFO] [stdout] | -------^^^^^------------------------------------------------------------------------ help: try: `if self.download_manager.download_with_hash(&url, &lib_dest, None).await.is_ok()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `ModSource` which implements the `Copy` trait [INFO] [stdout] --> src/gui/mod_browser.rs:131:62 [INFO] [stdout] | [INFO] [stdout] 131 | let all_versions = manager.get_mod_versions_raw(&mod_id, mod_source.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `mod_source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/core/minecraft/neoforge.rs:573:1 [INFO] [stdout] | [INFO] [stdout] 573 | / pub fn build_launch_command( [INFO] [stdout] 574 | | installation: &NeoForgeInstallation, [INFO] [stdout] 575 | | java_path: &str, [INFO] [stdout] 576 | | memory_mb: u32, [INFO] [stdout] ... | [INFO] [stdout] 585 | | asset_index: &str, [INFO] [stdout] 586 | | ) -> Command { [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/core/minecraft/forge.rs:155:21 [INFO] [stdout] | [INFO] [stdout] 155 | v.split('-').last().map(|s| s.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 155 - v.split('-').last().map(|s| s.to_string()) [INFO] [stdout] 155 + v.split('-').next_back().map(|s| s.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `split_once` [INFO] [stdout] --> src/core/minecraft/forge.rs:167:44 [INFO] [stdout] | [INFO] [stdout] 167 | if let Some(mcp) = ver.splitn(2, '-').nth(1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ver.split_once('-').map(|x| x.1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_split_once [INFO] [stdout] = note: `#[warn(clippy::manual_split_once)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/core/minecraft/forge.rs:426:5 [INFO] [stdout] | [INFO] [stdout] 426 | / async fn run_processors( [INFO] [stdout] 427 | | processors: &[Processor], [INFO] [stdout] 428 | | data: &std::collections::HashMap, [INFO] [stdout] 429 | | libraries_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 436 | | mcp_version: &str, [INFO] [stdout] 437 | | ) -> Result { [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly performing saturating subtraction [INFO] [stdout] --> src/core/minecraft/forge.rs:577:25 [INFO] [stdout] | [INFO] [stdout] 577 | if i > 0 { i -= 1; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i = i.saturating_sub(1);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/minecraft/forge.rs:857:13 [INFO] [stdout] | [INFO] [stdout] 857 | / if dm.download_with_hash(&url, dest, None).await.is_ok() { [INFO] [stdout] 858 | | if dest.exists() && std::fs::metadata(dest).map(|m| m.len() > 0).unwrap_or(false) { [INFO] [stdout] 859 | | tracing::debug!("Heruntergeladen von {}: {}", repo, maven_path); [INFO] [stdout] 860 | | return; [INFO] [stdout] 861 | | } [INFO] [stdout] 862 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 857 ~ if dm.download_with_hash(&url, dest, None).await.is_ok() [INFO] [stdout] 858 ~ && dest.exists() && std::fs::metadata(dest).map(|m| m.len() > 0).unwrap_or(false) { [INFO] [stdout] 859 | tracing::debug!("Heruntergeladen von {}: {}", repo, maven_path); [INFO] [stdout] 860 | return; [INFO] [stdout] 861 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/core/minecraft/forge.rs:980:1 [INFO] [stdout] | [INFO] [stdout] 980 | / pub fn resolve_arg_placeholders( [INFO] [stdout] 981 | | arg: &str, [INFO] [stdout] 982 | | libraries_dir: &Path, [INFO] [stdout] 983 | | natives_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 991 | | username: &str, [INFO] [stdout] 992 | | ) -> String { [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/core/minecraft/worlds.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | worlds.sort_by(|a, b| b.last_played.cmp(&a.last_played)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 70 - worlds.sort_by(|a, b| b.last_played.cmp(&a.last_played)); [INFO] [stdout] 70 + worlds.sort_by_key(|b| std::cmp::Reverse(b.last_played)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: initializer for `thread_local` value can be made `const` [INFO] [stdout] --> src/core/minecraft/mod.rs:22:54 [INFO] [stdout] | [INFO] [stdout] 22 | static EXTRA_LAUNCH_ARGS: RefCell> = RefCell::new(Vec::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `const { RefCell::new(Vec::new()) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_thread_local [INFO] [stdout] = note: `#[warn(clippy::missing_const_for_thread_local)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/core/minecraft/mod.rs:308:5 [INFO] [stdout] | [INFO] [stdout] 308 | / async fn launch_neoforge_new( [INFO] [stdout] 309 | | &self, [INFO] [stdout] 310 | | profile: &Profile, [INFO] [stdout] 311 | | version_info: &VersionInfo, [INFO] [stdout] ... | [INFO] [stdout] 320 | | access_token: Option<&str>, [INFO] [stdout] 321 | | ) -> Result<()> { [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/core/minecraft/mod.rs:429:5 [INFO] [stdout] | [INFO] [stdout] 429 | / async fn launch_neoforge_or_forge( [INFO] [stdout] 430 | | &self, [INFO] [stdout] 431 | | profile: &Profile, [INFO] [stdout] 432 | | version_info: &VersionInfo, [INFO] [stdout] ... | [INFO] [stdout] 441 | | access_token: Option<&str>, [INFO] [stdout] 442 | | ) -> Result<()> { [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/gui/mod.rs:48:33 [INFO] [stdout] | [INFO] [stdout] 48 | .filter(|e| e.path().extension().map_or(false, |ext| ext == "txt")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_some_and` instead [INFO] [stdout] | [INFO] [stdout] 48 - .filter(|e| e.path().extension().map_or(false, |ext| ext == "txt")) [INFO] [stdout] 48 + .filter(|e| e.path().extension().is_some_and(|ext| ext == "txt")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/core/minecraft/mod.rs:918:5 [INFO] [stdout] | [INFO] [stdout] 918 | / async fn launch_standard( [INFO] [stdout] 919 | | &self, [INFO] [stdout] 920 | | profile: &Profile, [INFO] [stdout] 921 | | main_class: &str, [INFO] [stdout] ... | [INFO] [stdout] 930 | | access_token: Option<&str>, [INFO] [stdout] 931 | | ) -> Result<()> { [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/gui/mod.rs:188:27 [INFO] [stdout] | [INFO] [stdout] 188 | let pattern = format!("neoforge-"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"neoforge-".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/core/minecraft/mod.rs:1012:28 [INFO] [stdout] | [INFO] [stdout] 1012 | let filename = path.split('/').last()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1012 - let filename = path.split('/').last()?; [INFO] [stdout] 1012 + let filename = path.split('/').next_back()?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/gui/mod.rs:469:36 [INFO] [stdout] | [INFO] [stdout] 469 | Some(name_part.replace('-', " ").replace('_', " ")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['-', '_'], " ")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] = note: `#[warn(clippy::collapsible_str_replace)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/gui/mod.rs:484:32 [INFO] [stdout] | [INFO] [stdout] 484 | Some(name_part.replace('-', " ").replace('_', " ")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['-', '_'], " ")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used consecutive `str::replace` call [INFO] [stdout] --> src/gui/mod.rs:493:22 [INFO] [stdout] | [INFO] [stdout] 493 | (Some(clean_name.replace('-', " ").replace('_', " ")), None, mod_id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `replace(['-', '_'], " ")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_str_replace [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/core/minecraft/mod.rs:1366:34 [INFO] [stdout] | [INFO] [stdout] 1366 | if let Some(v) = lib.name.split(':').last() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1366 - if let Some(v) = lib.name.split(':').last() { [INFO] [stdout] 1366 + if let Some(v) = lib.name.split(':').next_back() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/core/minecraft/mod.rs:1371:34 [INFO] [stdout] | [INFO] [stdout] 1371 | if let Some(v) = lib.name.split(':').last() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1371 - if let Some(v) = lib.name.split(':').last() { [INFO] [stdout] 1371 + if let Some(v) = lib.name.split(':').next_back() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if let` can be collapsed into the outer `if let` [INFO] [stdout] --> src/gui/mod.rs:659:17 [INFO] [stdout] | [INFO] [stdout] 659 | / if let Some(latest) = modrinth_info { [INFO] [stdout] 660 | | let has_update = mod_info.version.as_ref() [INFO] [stdout] 661 | | .map(|v| v != &latest.version) [INFO] [stdout] 662 | | .unwrap_or(false); [INFO] [stdout] ... | [INFO] [stdout] 673 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/gui/mod.rs:658:23 [INFO] [stdout] | [INFO] [stdout] 658 | if let Ok(modrinth_info) = search_modrinth_by_name(mod_id).await { [INFO] [stdout] | ^^^^^^^^^^^^^ replace this binding [INFO] [stdout] 659 | if let Some(latest) = modrinth_info { [INFO] [stdout] | ^^^^^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/gui/mod.rs:811:5 [INFO] [stdout] | [INFO] [stdout] 811 | packs.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 811 - packs.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] 811 + packs.sort_by_key(|a| a.name.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/gui/mod.rs:863:5 [INFO] [stdout] | [INFO] [stdout] 863 | packs.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 863 - packs.sort_by(|a, b| a.name.to_lowercase().cmp(&b.name.to_lowercase())); [INFO] [stdout] 863 + packs.sort_by_key(|a| a.name.to_lowercase()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/gui/mod.rs:997:46 [INFO] [stdout] | [INFO] [stdout] 997 | if !is_blacklisted_key(&key) { [INFO] [stdout] | ______________________________________________^ [INFO] [stdout] 998 | | combined_values.insert(key, value); [INFO] [stdout] 999 | | } else if !combined_values.contains_key(&key) { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/gui/mod.rs:999:63 [INFO] [stdout] | [INFO] [stdout] 999 | } else if !combined_values.contains_key(&key) { [INFO] [stdout] | _______________________________________________________________^ [INFO] [stdout] 1000 | | combined_values.insert(key, value); [INFO] [stdout] 1001 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/gui/mod.rs:999:24 [INFO] [stdout] | [INFO] [stdout] 999 | } else if !combined_values.contains_key(&key) { [INFO] [stdout] | ________________________^ [INFO] [stdout] 1000 | | combined_values.insert(key, value); [INFO] [stdout] 1001 | | } [INFO] [stdout] | |_________________^ help: try: `combined_values.entry(key).or_insert(value);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] = note: `#[warn(clippy::map_entry)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stdout] --> src/gui/mod.rs:1149:17 [INFO] [stdout] | [INFO] [stdout] 1149 | / if !settings.contains_key(&key) { [INFO] [stdout] 1150 | | settings.insert(key, value); [INFO] [stdout] 1151 | | } [INFO] [stdout] | |_________________^ help: try: `settings.entry(key).or_insert(value);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/core/minecraft/installer.rs:59:32 [INFO] [stdout] | [INFO] [stdout] 59 | if let Ok(_) = self.download_manager.download_with_hash(&url, &lib_dest, None).await { [INFO] [stdout] | -------^^^^^------------------------------------------------------------------------ help: try: `if self.download_manager.download_with_hash(&url, &lib_dest, None).await.is_ok()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/minecraft/mod.rs:1811:9 [INFO] [stdout] | [INFO] [stdout] 1811 | / if installer_path.exists() { [INFO] [stdout] 1812 | | if !Self::is_valid_zip(&installer_path) { [INFO] [stdout] 1813 | | tracing::warn!("Existing Forge installer is corrupted, re-downloading..."); [INFO] [stdout] 1814 | | tokio::fs::remove_file(&installer_path).await.ok(); [INFO] [stdout] 1815 | | } [INFO] [stdout] 1816 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1811 ~ if installer_path.exists() [INFO] [stdout] 1812 ~ && !Self::is_valid_zip(&installer_path) { [INFO] [stdout] 1813 | tracing::warn!("Existing Forge installer is corrupted, re-downloading..."); [INFO] [stdout] 1814 | tokio::fs::remove_file(&installer_path).await.ok(); [INFO] [stdout] 1815 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/minecraft/mod.rs:2044:9 [INFO] [stdout] | [INFO] [stdout] 2044 | / if installer_path.exists() { [INFO] [stdout] 2045 | | if !Self::is_valid_zip(&installer_path) { [INFO] [stdout] 2046 | | tracing::warn!("Existing NeoForge installer is corrupted, re-downloading..."); [INFO] [stdout] 2047 | | tokio::fs::remove_file(&installer_path).await.ok(); [INFO] [stdout] 2048 | | } [INFO] [stdout] 2049 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 2044 ~ if installer_path.exists() [INFO] [stdout] 2045 ~ && !Self::is_valid_zip(&installer_path) { [INFO] [stdout] 2046 | tracing::warn!("Existing NeoForge installer is corrupted, re-downloading..."); [INFO] [stdout] 2047 | tokio::fs::remove_file(&installer_path).await.ok(); [INFO] [stdout] 2048 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/core/minecraft/neoforge.rs:573:1 [INFO] [stdout] | [INFO] [stdout] 573 | / pub fn build_launch_command( [INFO] [stdout] 574 | | installation: &NeoForgeInstallation, [INFO] [stdout] 575 | | java_path: &str, [INFO] [stdout] 576 | | memory_mb: u32, [INFO] [stdout] ... | [INFO] [stdout] 585 | | asset_index: &str, [INFO] [stdout] 586 | | ) -> Command { [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/core/minecraft/mod.rs:2401:27 [INFO] [stdout] | [INFO] [stdout] 2401 | for (_, asset) in &idx.objects { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 2401 - for (_, asset) in &idx.objects { [INFO] [stdout] 2401 + for asset in idx.objects.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/core/minecraft/forge.rs:155:21 [INFO] [stdout] | [INFO] [stdout] 155 | v.split('-').last().map(|s| s.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 155 - v.split('-').last().map(|s| s.to_string()) [INFO] [stdout] 155 + v.split('-').next_back().map(|s| s.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `split_once` [INFO] [stdout] --> src/core/minecraft/forge.rs:167:44 [INFO] [stdout] | [INFO] [stdout] 167 | if let Some(mcp) = ver.splitn(2, '-').nth(1) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ver.split_once('-').map(|x| x.1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_split_once [INFO] [stdout] = note: `#[warn(clippy::manual_split_once)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/core/minecraft/forge.rs:426:5 [INFO] [stdout] | [INFO] [stdout] 426 | / async fn run_processors( [INFO] [stdout] 427 | | processors: &[Processor], [INFO] [stdout] 428 | | data: &std::collections::HashMap, [INFO] [stdout] 429 | | libraries_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 436 | | mcp_version: &str, [INFO] [stdout] 437 | | ) -> Result { [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implicitly performing saturating subtraction [INFO] [stdout] --> src/core/minecraft/forge.rs:577:25 [INFO] [stdout] | [INFO] [stdout] 577 | if i > 0 { i -= 1; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i = i.saturating_sub(1);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_saturating_sub [INFO] [stdout] = note: `#[warn(clippy::implicit_saturating_sub)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/minecraft/forge.rs:857:13 [INFO] [stdout] | [INFO] [stdout] 857 | / if dm.download_with_hash(&url, dest, None).await.is_ok() { [INFO] [stdout] 858 | | if dest.exists() && std::fs::metadata(dest).map(|m| m.len() > 0).unwrap_or(false) { [INFO] [stdout] 859 | | tracing::debug!("Heruntergeladen von {}: {}", repo, maven_path); [INFO] [stdout] 860 | | return; [INFO] [stdout] 861 | | } [INFO] [stdout] 862 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 857 ~ if dm.download_with_hash(&url, dest, None).await.is_ok() [INFO] [stdout] 858 ~ && dest.exists() && std::fs::metadata(dest).map(|m| m.len() > 0).unwrap_or(false) { [INFO] [stdout] 859 | tracing::debug!("Heruntergeladen von {}: {}", repo, maven_path); [INFO] [stdout] 860 | return; [INFO] [stdout] 861 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (11/7) [INFO] [stdout] --> src/core/minecraft/forge.rs:980:1 [INFO] [stdout] | [INFO] [stdout] 980 | / pub fn resolve_arg_placeholders( [INFO] [stdout] 981 | | arg: &str, [INFO] [stdout] 982 | | libraries_dir: &Path, [INFO] [stdout] 983 | | natives_dir: &Path, [INFO] [stdout] ... | [INFO] [stdout] 991 | | username: &str, [INFO] [stdout] 992 | | ) -> String { [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/core/minecraft/worlds.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | worlds.sort_by(|a, b| b.last_played.cmp(&a.last_played)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 70 - worlds.sort_by(|a, b| b.last_played.cmp(&a.last_played)); [INFO] [stdout] 70 + worlds.sort_by_key(|b| std::cmp::Reverse(b.last_played)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: initializer for `thread_local` value can be made `const` [INFO] [stdout] --> src/core/minecraft/mod.rs:22:54 [INFO] [stdout] | [INFO] [stdout] 22 | static EXTRA_LAUNCH_ARGS: RefCell> = RefCell::new(Vec::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `const { RefCell::new(Vec::new()) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_const_for_thread_local [INFO] [stdout] = note: `#[warn(clippy::missing_const_for_thread_local)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/core/auth/mod.rs:32:1 [INFO] [stdout] | [INFO] [stdout] 32 | / impl Default for AuthState { [INFO] [stdout] 33 | | fn default() -> Self { [INFO] [stdout] 34 | | Self { [INFO] [stdout] 35 | | accounts: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 39 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 27 + #[derive(Default)] [INFO] [stdout] 28 | pub struct AuthState { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/core/minecraft/mod.rs:308:5 [INFO] [stdout] | [INFO] [stdout] 308 | / async fn launch_neoforge_new( [INFO] [stdout] 309 | | &self, [INFO] [stdout] 310 | | profile: &Profile, [INFO] [stdout] 311 | | version_info: &VersionInfo, [INFO] [stdout] ... | [INFO] [stdout] 320 | | access_token: Option<&str>, [INFO] [stdout] 321 | | ) -> Result<()> { [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/core/minecraft/mod.rs:429:5 [INFO] [stdout] | [INFO] [stdout] 429 | / async fn launch_neoforge_or_forge( [INFO] [stdout] 430 | | &self, [INFO] [stdout] 431 | | profile: &Profile, [INFO] [stdout] 432 | | version_info: &VersionInfo, [INFO] [stdout] ... | [INFO] [stdout] 441 | | access_token: Option<&str>, [INFO] [stdout] 442 | | ) -> Result<()> { [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/core/minecraft/mod.rs:918:5 [INFO] [stdout] | [INFO] [stdout] 918 | / async fn launch_standard( [INFO] [stdout] 919 | | &self, [INFO] [stdout] 920 | | profile: &Profile, [INFO] [stdout] 921 | | main_class: &str, [INFO] [stdout] ... | [INFO] [stdout] 930 | | access_token: Option<&str>, [INFO] [stdout] 931 | | ) -> Result<()> { [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/core/minecraft/mod.rs:1012:28 [INFO] [stdout] | [INFO] [stdout] 1012 | let filename = path.split('/').last()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1012 - let filename = path.split('/').last()?; [INFO] [stdout] 1012 + let filename = path.split('/').next_back()?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/core/minecraft/mod.rs:1366:34 [INFO] [stdout] | [INFO] [stdout] 1366 | if let Some(v) = lib.name.split(':').last() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1366 - if let Some(v) = lib.name.split(':').last() { [INFO] [stdout] 1366 + if let Some(v) = lib.name.split(':').next_back() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/core/minecraft/mod.rs:1371:34 [INFO] [stdout] | [INFO] [stdout] 1371 | if let Some(v) = lib.name.split(':').last() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1371 - if let Some(v) = lib.name.split(':').last() { [INFO] [stdout] 1371 + if let Some(v) = lib.name.split(':').next_back() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/minecraft/mod.rs:1811:9 [INFO] [stdout] | [INFO] [stdout] 1811 | / if installer_path.exists() { [INFO] [stdout] 1812 | | if !Self::is_valid_zip(&installer_path) { [INFO] [stdout] 1813 | | tracing::warn!("Existing Forge installer is corrupted, re-downloading..."); [INFO] [stdout] 1814 | | tokio::fs::remove_file(&installer_path).await.ok(); [INFO] [stdout] 1815 | | } [INFO] [stdout] 1816 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 1811 ~ if installer_path.exists() [INFO] [stdout] 1812 ~ && !Self::is_valid_zip(&installer_path) { [INFO] [stdout] 1813 | tracing::warn!("Existing Forge installer is corrupted, re-downloading..."); [INFO] [stdout] 1814 | tokio::fs::remove_file(&installer_path).await.ok(); [INFO] [stdout] 1815 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/core/minecraft/mod.rs:2044:9 [INFO] [stdout] | [INFO] [stdout] 2044 | / if installer_path.exists() { [INFO] [stdout] 2045 | | if !Self::is_valid_zip(&installer_path) { [INFO] [stdout] 2046 | | tracing::warn!("Existing NeoForge installer is corrupted, re-downloading..."); [INFO] [stdout] 2047 | | tokio::fs::remove_file(&installer_path).await.ok(); [INFO] [stdout] 2048 | | } [INFO] [stdout] 2049 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 2044 ~ if installer_path.exists() [INFO] [stdout] 2045 ~ && !Self::is_valid_zip(&installer_path) { [INFO] [stdout] 2046 | tracing::warn!("Existing NeoForge installer is corrupted, re-downloading..."); [INFO] [stdout] 2047 | tokio::fs::remove_file(&installer_path).await.ok(); [INFO] [stdout] 2048 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to want to iterate on a map's values [INFO] [stdout] --> src/core/minecraft/mod.rs:2401:27 [INFO] [stdout] | [INFO] [stdout] 2401 | for (_, asset) in &idx.objects { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stdout] = note: `#[warn(clippy::for_kv_map)]` on by default [INFO] [stdout] help: use the corresponding method [INFO] [stdout] | [INFO] [stdout] 2401 - for (_, asset) in &idx.objects { [INFO] [stdout] 2401 + for asset in idx.objects.values() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/core/auth/mod.rs:32:1 [INFO] [stdout] | [INFO] [stdout] 32 | / impl Default for AuthState { [INFO] [stdout] 33 | | fn default() -> Self { [INFO] [stdout] 34 | | Self { [INFO] [stdout] 35 | | accounts: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 39 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 27 + #[derive(Default)] [INFO] [stdout] 28 | pub struct AuthState { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/api/forge_compat.rs:227:17 [INFO] [stdout] | [INFO] [stdout] 227 | / all_versions.iter() [INFO] [stdout] 228 | | .filter(|v| v.loader_type == LoaderType::NeoForge && !v.is_beta) [INFO] [stdout] 229 | | .next() [INFO] [stdout] | |___________________________^ help: try: `all_versions.iter().find(|v| v.loader_type == LoaderType::NeoForge && !v.is_beta)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] = note: `#[warn(clippy::filter_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/api/forge_compat.rs:237:33 [INFO] [stdout] | [INFO] [stdout] 237 | .or_else(|| all_versions.iter().filter(|v| v.loader_type == LoaderType::Forge).next()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `all_versions.iter().find(|v| v.loader_type == LoaderType::Forge)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/api/forge_compat.rs:227:17 [INFO] [stdout] | [INFO] [stdout] 227 | / all_versions.iter() [INFO] [stdout] 228 | | .filter(|v| v.loader_type == LoaderType::NeoForge && !v.is_beta) [INFO] [stdout] 229 | | .next() [INFO] [stdout] | |___________________________^ help: try: `all_versions.iter().find(|v| v.loader_type == LoaderType::NeoForge && !v.is_beta)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] = note: `#[warn(clippy::filter_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `filter(..).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(..)` instead [INFO] [stdout] --> src/api/forge_compat.rs:237:33 [INFO] [stdout] | [INFO] [stdout] 237 | .or_else(|| all_versions.iter().filter(|v| v.loader_type == LoaderType::Forge).next()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `all_versions.iter().find(|v| v.loader_type == LoaderType::Forge)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/core/minecraft/neoforge.rs:530:26 [INFO] [stdout] | [INFO] [stdout] 530 | let possible_paths = vec![ [INFO] [stdout] | __________________________^ [INFO] [stdout] 531 | | libraries_dir.join(format!("net/minecraft/client/{}-{}/client-{}-{}-srg.jar", [INFO] [stdout] 532 | | mc_version, neoform_version, mc_version, neoform_version)), [INFO] [stdout] 533 | | libraries_dir.join(format!("net/minecraft/client/{}-{}/client-{}-{}-slim.jar", [INFO] [stdout] 534 | | mc_version, neoform_version, mc_version, neoform_version)), [INFO] [stdout] 535 | | libraries_dir.join(format!("net/minecraft/{}/{}.jar", mc_version, mc_version)), [INFO] [stdout] 536 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 530 ~ let possible_paths = [libraries_dir.join(format!("net/minecraft/client/{}-{}/client-{}-{}-srg.jar", [INFO] [stdout] 531 + mc_version, neoform_version, mc_version, neoform_version)), [INFO] [stdout] 532 + libraries_dir.join(format!("net/minecraft/client/{}-{}/client-{}-{}-slim.jar", [INFO] [stdout] 533 + mc_version, neoform_version, mc_version, neoform_version)), [INFO] [stdout] 534 ~ libraries_dir.join(format!("net/minecraft/{}/{}.jar", mc_version, mc_version))]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/core/minecraft/neoforge.rs:530:26 [INFO] [stdout] | [INFO] [stdout] 530 | let possible_paths = vec![ [INFO] [stdout] | __________________________^ [INFO] [stdout] 531 | | libraries_dir.join(format!("net/minecraft/client/{}-{}/client-{}-{}-srg.jar", [INFO] [stdout] 532 | | mc_version, neoform_version, mc_version, neoform_version)), [INFO] [stdout] 533 | | libraries_dir.join(format!("net/minecraft/client/{}-{}/client-{}-{}-slim.jar", [INFO] [stdout] 534 | | mc_version, neoform_version, mc_version, neoform_version)), [INFO] [stdout] 535 | | libraries_dir.join(format!("net/minecraft/{}/{}.jar", mc_version, mc_version)), [INFO] [stdout] 536 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 530 ~ let possible_paths = [libraries_dir.join(format!("net/minecraft/client/{}-{}/client-{}-{}-srg.jar", [INFO] [stdout] 531 + mc_version, neoform_version, mc_version, neoform_version)), [INFO] [stdout] 532 + libraries_dir.join(format!("net/minecraft/client/{}-{}/client-{}-{}-slim.jar", [INFO] [stdout] 533 + mc_version, neoform_version, mc_version, neoform_version)), [INFO] [stdout] 534 ~ libraries_dir.join(format!("net/minecraft/{}/{}.jar", mc_version, mc_version))]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5m 42s [INFO] running `Command { std: "docker" "inspect" "33a1e4c2116f44a5a4b92ab5fe4b1cbed05ba7ec0d61654a61958dedb7d23f37", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "33a1e4c2116f44a5a4b92ab5fe4b1cbed05ba7ec0d61654a61958dedb7d23f37", kill_on_drop: false }` [INFO] [stdout] 33a1e4c2116f44a5a4b92ab5fe4b1cbed05ba7ec0d61654a61958dedb7d23f37