[INFO] cloning repository https://github.com/TheElectronWill/rust-mount-watcher [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TheElectronWill/rust-mount-watcher" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTheElectronWill%2Frust-mount-watcher", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTheElectronWill%2Frust-mount-watcher'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 755798c1caf6dcbe990c179c829bbd2d6f4814c0 [INFO] linting TheElectronWill/rust-mount-watcher against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTheElectronWill%2Frust-mount-watcher" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/TheElectronWill/rust-mount-watcher [INFO] finished tweaking git repo https://github.com/TheElectronWill/rust-mount-watcher [INFO] tweaked toml for git repo https://github.com/TheElectronWill/rust-mount-watcher written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/TheElectronWill/rust-mount-watcher on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/TheElectronWill/rust-mount-watcher already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded thiserror-impl v2.0.0 [INFO] [stderr] Downloaded env_logger v0.11.0 [INFO] [stderr] Downloaded timerfd v1.6.0 [INFO] [stderr] Downloaded thiserror v2.0.0 [INFO] [stderr] Downloaded mio v1.0.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a901c0d7cf85787c127c4d90954e30422239110804030ce038119cdf4b9528e7 [INFO] running `Command { std: "docker" "start" "-a" "a901c0d7cf85787c127c4d90954e30422239110804030ce038119cdf4b9528e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a901c0d7cf85787c127c4d90954e30422239110804030ce038119cdf4b9528e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a901c0d7cf85787c127c4d90954e30422239110804030ce038119cdf4b9528e7", kill_on_drop: false }` [INFO] [stdout] a901c0d7cf85787c127c4d90954e30422239110804030ce038119cdf4b9528e7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5ed49d02a5d2e1924a8d84f9dce17e146aa7d6486e1b22e62a6fb3639ed36192 [INFO] running `Command { std: "docker" "start" "-a" "5ed49d02a5d2e1924a8d84f9dce17e146aa7d6486e1b22e62a6fb3639ed36192", kill_on_drop: false }` [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Compiling thiserror v2.0.0 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking anstream v0.6.19 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking mio v1.0.0 [INFO] [stderr] Checking timerfd v1.6.0 [INFO] [stderr] Compiling thiserror-impl v2.0.0 [INFO] [stderr] Checking mount-watcher v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: useless conversion to the same type: `std::str::SplitAsciiWhitespace<'_>` [INFO] [stdout] --> src/mount.rs:45:26 [INFO] [stdout] | [INFO] [stdout] 45 | let mut fields = line.split_ascii_whitespace().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `line.split_ascii_whitespace()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/watch.rs:174:13 [INFO] [stdout] | [INFO] [stdout] 174 | !(coalesced && !self.coalescing), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!coalesced || self.coalescing` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking env_logger v0.11.0 [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> tests/integration.rs:86:26 [INFO] [stdout] | [INFO] [stdout] 86 | .join("\n\t") [INFO] [stdout] | __________________________^ [INFO] [stdout] 87 | | .to_string() [INFO] [stdout] | |________________________^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `println!` args [INFO] [stdout] --> tests/integration.rs:96:26 [INFO] [stdout] | [INFO] [stdout] 96 | .join("\n\t") [INFO] [stdout] | __________________________^ [INFO] [stdout] 97 | | .to_string() [INFO] [stdout] | |________________________^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::str::SplitAsciiWhitespace<'_>` [INFO] [stdout] --> src/mount.rs:45:26 [INFO] [stdout] | [INFO] [stdout] 45 | let mut fields = line.split_ascii_whitespace().into_iter(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `line.split_ascii_whitespace()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/mount.rs:103:16 [INFO] [stdout] | [INFO] [stdout] 103 | values.into_iter().map(|s| s.to_string()).collect() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/mount.rs:114:27 [INFO] [stdout] | [INFO] [stdout] 114 | parse_proc_mounts(&content, &mut mounts).unwrap(); [INFO] [stdout] | ^^^^^^^^ help: change this to: `content` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/watch.rs:174:13 [INFO] [stdout] | [INFO] [stdout] 174 | !(coalesced && !self.coalescing), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!coalesced || self.coalescing` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.68s [INFO] running `Command { std: "docker" "inspect" "5ed49d02a5d2e1924a8d84f9dce17e146aa7d6486e1b22e62a6fb3639ed36192", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5ed49d02a5d2e1924a8d84f9dce17e146aa7d6486e1b22e62a6fb3639ed36192", kill_on_drop: false }` [INFO] [stdout] 5ed49d02a5d2e1924a8d84f9dce17e146aa7d6486e1b22e62a6fb3639ed36192