[INFO] cloning repository https://github.com/ThamizhiniyanCS/codecrafters-shell-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ThamizhiniyanCS/codecrafters-shell-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FThamizhiniyanCS%2Fcodecrafters-shell-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FThamizhiniyanCS%2Fcodecrafters-shell-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 32e2d5ce679991de9b9cff3af5c10e1bf8a5e194 [INFO] linting ThamizhiniyanCS/codecrafters-shell-rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FThamizhiniyanCS%2Fcodecrafters-shell-rust" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ThamizhiniyanCS/codecrafters-shell-rust [INFO] finished tweaking git repo https://github.com/ThamizhiniyanCS/codecrafters-shell-rust [INFO] tweaked toml for git repo https://github.com/ThamizhiniyanCS/codecrafters-shell-rust written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ThamizhiniyanCS/codecrafters-shell-rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ThamizhiniyanCS/codecrafters-shell-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded syn v2.0.75 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d9f9506231ad9676213129430097a4d3dd8517116c11e5d4b3b11eefbf9b074d [INFO] running `Command { std: "docker" "start" "-a" "d9f9506231ad9676213129430097a4d3dd8517116c11e5d4b3b11eefbf9b074d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d9f9506231ad9676213129430097a4d3dd8517116c11e5d4b3b11eefbf9b074d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d9f9506231ad9676213129430097a4d3dd8517116c11e5d4b3b11eefbf9b074d", kill_on_drop: false }` [INFO] [stdout] d9f9506231ad9676213129430097a4d3dd8517116c11e5d4b3b11eefbf9b074d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 96315c70d1215f690acc2a807fd3d35e0ff59916f991b18ca82e1070932c557b [INFO] running `Command { std: "docker" "start" "-a" "96315c70d1215f690acc2a807fd3d35e0ff59916f991b18ca82e1070932c557b", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.75 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking codecrafters-shell v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this is a decimal constant [INFO] [stdout] --> src/utils.rs:263:23 [INFO] [stdout] | [INFO] [stdout] 263 | results.push((010, args_string.to_string())) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stdout] = note: `#[warn(clippy::zero_prefixed_literal)]` on by default [INFO] [stdout] help: if you mean to use a decimal constant, remove the `0` to avoid confusion [INFO] [stdout] | [INFO] [stdout] 263 - results.push((010, args_string.to_string())) [INFO] [stdout] 263 + results.push((10, args_string.to_string())) [INFO] [stdout] | [INFO] [stdout] help: if you mean to use an octal constant, use `0o` [INFO] [stdout] | [INFO] [stdout] 263 | results.push((0o10, args_string.to_string())) [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this is a decimal constant [INFO] [stdout] --> src/utils.rs:263:23 [INFO] [stdout] | [INFO] [stdout] 263 | results.push((010, args_string.to_string())) [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stdout] = note: `#[warn(clippy::zero_prefixed_literal)]` on by default [INFO] [stdout] help: if you mean to use a decimal constant, remove the `0` to avoid confusion [INFO] [stdout] | [INFO] [stdout] 263 - results.push((010, args_string.to_string())) [INFO] [stdout] 263 + results.push((10, args_string.to_string())) [INFO] [stdout] | [INFO] [stdout] help: if you mean to use an octal constant, use `0o` [INFO] [stdout] | [INFO] [stdout] 263 | results.push((0o10, args_string.to_string())) [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `command` is never read [INFO] [stdout] --> src/main.rs:34:41 [INFO] [stdout] | [INFO] [stdout] 34 | let mut command: Option<&str> = Some(""); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `args_string` is never read [INFO] [stdout] --> src/main.rs:35:47 [INFO] [stdout] | [INFO] [stdout] 35 | let mut args_string: Option = Some(String::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `command` is never read [INFO] [stdout] --> src/main.rs:34:41 [INFO] [stdout] | [INFO] [stdout] 34 | let mut command: Option<&str> = Some(""); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `args_string` is never read [INFO] [stdout] --> src/main.rs:35:47 [INFO] [stdout] | [INFO] [stdout] 35 | let mut args_string: Option = Some(String::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:71:17 [INFO] [stdout] | [INFO] [stdout] 71 | characters: &Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 71 - characters: &Vec, [INFO] [stdout] 71 + characters: &[char], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:98:67 [INFO] [stdout] | [INFO] [stdout] 98 | match crate::IS_MULTIPLE_ARGUMENTS_REGEX_PATTERN.is_match(&args_string) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `args_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:126:36 [INFO] [stdout] | [INFO] [stdout] 126 | for index in regex_set.matches(&args_string).into_iter() { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `args_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:130:57 [INFO] [stdout] | [INFO] [stdout] 130 | for capture in regexes[0].captures_iter(&args_string) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `args_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/utils.rs:131:21 [INFO] [stdout] | [INFO] [stdout] 131 | / match is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) [INFO] [stdout] 132 | | { [INFO] [stdout] 133 | | Some(res) => { [INFO] [stdout] 134 | | let temp = &res[1..res.len() - 1].to_string(); [INFO] [stdout] ... | [INFO] [stdout] 138 | | None => (), [INFO] [stdout] 139 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 131 ~ if let Some(res) = is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) { [INFO] [stdout] 132 + let temp = &res[1..res.len() - 1].to_string(); [INFO] [stdout] 133 + [INFO] [stdout] 134 + results.push((0, temp.clone())); [INFO] [stdout] 135 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:144:57 [INFO] [stdout] | [INFO] [stdout] 144 | for capture in regexes[1].captures_iter(&args_string) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `args_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/utils.rs:145:21 [INFO] [stdout] | [INFO] [stdout] 145 | / match is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) [INFO] [stdout] 146 | | { [INFO] [stdout] 147 | | Some(res) => { [INFO] [stdout] 148 | | let mut temp: Vec> = [INFO] [stdout] ... | [INFO] [stdout] 192 | | None => (), [INFO] [stdout] 193 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 145 ~ if let Some(res) = is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) { [INFO] [stdout] 146 + let mut temp: Vec> = [INFO] [stdout] 147 + res.chars().map(|char| Some(char)).collect(); [INFO] [stdout] 148 + [INFO] [stdout] 149 + for capture in [INFO] [stdout] 150 + crate::ESCAPE_BACKSLASH_INSIDE_DOUBLE_QUOTES_REGEX_PATTERN [INFO] [stdout] 151 + .captures_iter(&res) [INFO] [stdout] 152 + { [INFO] [stdout] 153 + let m = capture.get(1).unwrap(); [INFO] [stdout] 154 + match m.as_str() { [INFO] [stdout] 155 + "\\\\" => { [INFO] [stdout] 156 + temp[m.start()] = Some('\\'); [INFO] [stdout] 157 + temp[m.end() - 1] = None; [INFO] [stdout] 158 + } [INFO] [stdout] 159 + "\\$" => { [INFO] [stdout] 160 + temp[m.start()] = Some('$'); [INFO] [stdout] 161 + temp[m.end() - 1] = None; [INFO] [stdout] 162 + } [INFO] [stdout] 163 + "\\\"" => { [INFO] [stdout] 164 + temp[m.start()] = Some('\"'); [INFO] [stdout] 165 + temp[m.end() - 1] = None; [INFO] [stdout] 166 + } [INFO] [stdout] 167 + "\\\\n" => { [INFO] [stdout] 168 + temp[m.start()] = Some('\\'); [INFO] [stdout] 169 + temp[m.start() + 1] = Some('n'); [INFO] [stdout] 170 + temp[m.end() - 1] = None; [INFO] [stdout] 171 + } [INFO] [stdout] 172 + "\"" => { [INFO] [stdout] 173 + temp[m.start()] = None; [INFO] [stdout] 174 + } [INFO] [stdout] 175 + _ => (), [INFO] [stdout] 176 + } [INFO] [stdout] 177 + } [INFO] [stdout] 178 + [INFO] [stdout] 179 + let mut final_string: String = String::new(); [INFO] [stdout] 180 + [INFO] [stdout] 181 + for opt in temp { [INFO] [stdout] 182 + match opt { [INFO] [stdout] 183 + Some(c) => final_string.push(c), [INFO] [stdout] 184 + None => (), [INFO] [stdout] 185 + } [INFO] [stdout] 186 + } [INFO] [stdout] 187 + [INFO] [stdout] 188 + results.push((1, final_string)); [INFO] [stdout] 189 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/utils.rs:149:49 [INFO] [stdout] | [INFO] [stdout] 149 | ... res.chars().map(|char| Some(char)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Some` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils.rs:71:17 [INFO] [stdout] | [INFO] [stdout] 71 | characters: &Vec, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 71 - characters: &Vec, [INFO] [stdout] 71 + characters: &[char], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/utils.rs:184:33 [INFO] [stdout] | [INFO] [stdout] 184 | / ... match opt { [INFO] [stdout] 185 | | ... Some(c) => final_string.push(c), [INFO] [stdout] 186 | | ... None => (), [INFO] [stdout] 187 | | ... } [INFO] [stdout] | |_______________________^ help: try: `if let Some(c) = opt { final_string.push(c) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:198:57 [INFO] [stdout] | [INFO] [stdout] 198 | for capture in regexes[2].captures_iter(&args_string) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `args_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/utils.rs:199:21 [INFO] [stdout] | [INFO] [stdout] 199 | / match is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) [INFO] [stdout] 200 | | { [INFO] [stdout] 201 | | Some(res) => results.push((2, res)), [INFO] [stdout] 202 | | None => (), [INFO] [stdout] 203 | | } [INFO] [stdout] | |_____________________^ help: try: `if let Some(res) = is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) { results.push((2, res)) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:208:57 [INFO] [stdout] | [INFO] [stdout] 208 | for capture in regexes[3].captures_iter(&args_string) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `args_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/utils.rs:209:21 [INFO] [stdout] | [INFO] [stdout] 209 | / match is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) [INFO] [stdout] 210 | | { [INFO] [stdout] 211 | | Some(res) => { [INFO] [stdout] 212 | | let mut temp = res; [INFO] [stdout] ... | [INFO] [stdout] 220 | | None => (), [INFO] [stdout] 221 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 209 ~ if let Some(res) = is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) { [INFO] [stdout] 210 + let mut temp = res; [INFO] [stdout] 211 + [INFO] [stdout] 212 + if !temp.contains('/') { [INFO] [stdout] 213 + temp = temp.replace('\\', ""); [INFO] [stdout] 214 + }; [INFO] [stdout] 215 + [INFO] [stdout] 216 + results.push((3, temp)); [INFO] [stdout] 217 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:226:57 [INFO] [stdout] | [INFO] [stdout] 226 | for capture in regexes[4].captures_iter(&args_string) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `args_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/utils.rs:230:29 [INFO] [stdout] | [INFO] [stdout] 230 | / ... if res.contains("/") { [INFO] [stdout] 231 | | ... results.push((4, res)) [INFO] [stdout] 232 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 229 ~ Some(res) [INFO] [stdout] 230 ~ if res.contains("/") => { [INFO] [stdout] 231 | results.push((4, res)) [INFO] [stdout] 232 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/utils.rs:227:21 [INFO] [stdout] | [INFO] [stdout] 227 | / match is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) [INFO] [stdout] 228 | | { [INFO] [stdout] 229 | | Some(res) => { [INFO] [stdout] 230 | | if res.contains("/") { [INFO] [stdout] ... | [INFO] [stdout] 234 | | None => (), [INFO] [stdout] 235 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 227 ~ if let Some(res) = is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) { [INFO] [stdout] 228 + if res.contains("/") { [INFO] [stdout] 229 + results.push((4, res)) [INFO] [stdout] 230 + } [INFO] [stdout] 231 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:98:67 [INFO] [stdout] | [INFO] [stdout] 98 | match crate::IS_MULTIPLE_ARGUMENTS_REGEX_PATTERN.is_match(&args_string) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `args_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:126:36 [INFO] [stdout] | [INFO] [stdout] 126 | for index in regex_set.matches(&args_string).into_iter() { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `args_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:130:57 [INFO] [stdout] | [INFO] [stdout] 130 | for capture in regexes[0].captures_iter(&args_string) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `args_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/utils.rs:131:21 [INFO] [stdout] | [INFO] [stdout] 131 | / match is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) [INFO] [stdout] 132 | | { [INFO] [stdout] 133 | | Some(res) => { [INFO] [stdout] 134 | | let temp = &res[1..res.len() - 1].to_string(); [INFO] [stdout] ... | [INFO] [stdout] 138 | | None => (), [INFO] [stdout] 139 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 131 ~ if let Some(res) = is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) { [INFO] [stdout] 132 + let temp = &res[1..res.len() - 1].to_string(); [INFO] [stdout] 133 + [INFO] [stdout] 134 + results.push((0, temp.clone())); [INFO] [stdout] 135 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:144:57 [INFO] [stdout] | [INFO] [stdout] 144 | for capture in regexes[1].captures_iter(&args_string) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `args_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:240:57 [INFO] [stdout] | [INFO] [stdout] 240 | for capture in regexes[5].captures_iter(&args_string) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `args_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/utils.rs:241:21 [INFO] [stdout] | [INFO] [stdout] 241 | / match is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) [INFO] [stdout] 242 | | { [INFO] [stdout] 243 | | Some(res) => results.push((5, res)), [INFO] [stdout] 244 | | None => (), [INFO] [stdout] 245 | | } [INFO] [stdout] | |_____________________^ help: try: `if let Some(res) = is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) { results.push((5, res)) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:250:57 [INFO] [stdout] | [INFO] [stdout] 250 | for capture in regexes[6].captures_iter(&args_string) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `args_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/utils.rs:145:21 [INFO] [stdout] | [INFO] [stdout] 145 | / match is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) [INFO] [stdout] 146 | | { [INFO] [stdout] 147 | | Some(res) => { [INFO] [stdout] 148 | | let mut temp: Vec> = [INFO] [stdout] ... | [INFO] [stdout] 192 | | None => (), [INFO] [stdout] 193 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 145 ~ if let Some(res) = is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) { [INFO] [stdout] 146 + let mut temp: Vec> = [INFO] [stdout] 147 + res.chars().map(|char| Some(char)).collect(); [INFO] [stdout] 148 + [INFO] [stdout] 149 + for capture in [INFO] [stdout] 150 + crate::ESCAPE_BACKSLASH_INSIDE_DOUBLE_QUOTES_REGEX_PATTERN [INFO] [stdout] 151 + .captures_iter(&res) [INFO] [stdout] 152 + { [INFO] [stdout] 153 + let m = capture.get(1).unwrap(); [INFO] [stdout] 154 + match m.as_str() { [INFO] [stdout] 155 + "\\\\" => { [INFO] [stdout] 156 + temp[m.start()] = Some('\\'); [INFO] [stdout] 157 + temp[m.end() - 1] = None; [INFO] [stdout] 158 + } [INFO] [stdout] 159 + "\\$" => { [INFO] [stdout] 160 + temp[m.start()] = Some('$'); [INFO] [stdout] 161 + temp[m.end() - 1] = None; [INFO] [stdout] 162 + } [INFO] [stdout] 163 + "\\\"" => { [INFO] [stdout] 164 + temp[m.start()] = Some('\"'); [INFO] [stdout] 165 + temp[m.end() - 1] = None; [INFO] [stdout] 166 + } [INFO] [stdout] 167 + "\\\\n" => { [INFO] [stdout] 168 + temp[m.start()] = Some('\\'); [INFO] [stdout] 169 + temp[m.start() + 1] = Some('n'); [INFO] [stdout] 170 + temp[m.end() - 1] = None; [INFO] [stdout] 171 + } [INFO] [stdout] 172 + "\"" => { [INFO] [stdout] 173 + temp[m.start()] = None; [INFO] [stdout] 174 + } [INFO] [stdout] 175 + _ => (), [INFO] [stdout] 176 + } [INFO] [stdout] 177 + } [INFO] [stdout] 178 + [INFO] [stdout] 179 + let mut final_string: String = String::new(); [INFO] [stdout] 180 + [INFO] [stdout] 181 + for opt in temp { [INFO] [stdout] 182 + match opt { [INFO] [stdout] 183 + Some(c) => final_string.push(c), [INFO] [stdout] 184 + None => (), [INFO] [stdout] 185 + } [INFO] [stdout] 186 + } [INFO] [stdout] 187 + [INFO] [stdout] 188 + results.push((1, final_string)); [INFO] [stdout] 189 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/utils.rs:251:21 [INFO] [stdout] | [INFO] [stdout] 251 | / match is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) [INFO] [stdout] 252 | | { [INFO] [stdout] 253 | | Some(res) => results.push((6, res)), [INFO] [stdout] 254 | | None => (), [INFO] [stdout] 255 | | } [INFO] [stdout] | |_____________________^ help: try: `if let Some(res) = is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) { results.push((6, res)) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/utils.rs:149:49 [INFO] [stdout] | [INFO] [stdout] 149 | ... res.chars().map(|char| Some(char)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `Some` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 60 | if !command.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `command.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `command_captures` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 37 | if command_captures.is_none() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = command_captures` [INFO] [stdout] ... [INFO] [stdout] 40 | let capture = command_captures.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `command` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:61:19 [INFO] [stdout] | [INFO] [stdout] 60 | if !command.is_none() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 61 | match command.unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `command` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:67:37 [INFO] [stdout] | [INFO] [stdout] 60 | if !command.is_none() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 67 | _ => utils::execute(command.unwrap(), processed_args), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/utils.rs:184:33 [INFO] [stdout] | [INFO] [stdout] 184 | / ... match opt { [INFO] [stdout] 185 | | ... Some(c) => final_string.push(c), [INFO] [stdout] 186 | | ... None => (), [INFO] [stdout] 187 | | ... } [INFO] [stdout] | |_______________________^ help: try: `if let Some(c) = opt { final_string.push(c) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:198:57 [INFO] [stdout] | [INFO] [stdout] 198 | for capture in regexes[2].captures_iter(&args_string) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `args_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/utils.rs:199:21 [INFO] [stdout] | [INFO] [stdout] 199 | / match is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) [INFO] [stdout] 200 | | { [INFO] [stdout] 201 | | Some(res) => results.push((2, res)), [INFO] [stdout] 202 | | None => (), [INFO] [stdout] 203 | | } [INFO] [stdout] | |_____________________^ help: try: `if let Some(res) = is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) { results.push((2, res)) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/main.rs:55:60 [INFO] [stdout] | [INFO] [stdout] 55 | let processed_args: Option> = match args_string { [INFO] [stdout] | ____________________________________________________________^ [INFO] [stdout] 56 | | Some(args_str) => Some(utils::parse_args(&args_str)), [INFO] [stdout] 57 | | None => None, [INFO] [stdout] 58 | | }; [INFO] [stdout] | |_________^ help: try: `args_string.map(|args_str| utils::parse_args(&args_str))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:208:57 [INFO] [stdout] | [INFO] [stdout] 208 | for capture in regexes[3].captures_iter(&args_string) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `args_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/utils.rs:209:21 [INFO] [stdout] | [INFO] [stdout] 209 | / match is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) [INFO] [stdout] 210 | | { [INFO] [stdout] 211 | | Some(res) => { [INFO] [stdout] 212 | | let mut temp = res; [INFO] [stdout] ... | [INFO] [stdout] 220 | | None => (), [INFO] [stdout] 221 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 209 ~ if let Some(res) = is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) { [INFO] [stdout] 210 + let mut temp = res; [INFO] [stdout] 211 + [INFO] [stdout] 212 + if !temp.contains('/') { [INFO] [stdout] 213 + temp = temp.replace('\\', ""); [INFO] [stdout] 214 + }; [INFO] [stdout] 215 + [INFO] [stdout] 216 + results.push((3, temp)); [INFO] [stdout] 217 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:226:57 [INFO] [stdout] | [INFO] [stdout] 226 | for capture in regexes[4].captures_iter(&args_string) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `args_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/utils.rs:230:29 [INFO] [stdout] | [INFO] [stdout] 230 | / ... if res.contains("/") { [INFO] [stdout] 231 | | ... results.push((4, res)) [INFO] [stdout] 232 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 229 ~ Some(res) [INFO] [stdout] 230 ~ if res.contains("/") => { [INFO] [stdout] 231 | results.push((4, res)) [INFO] [stdout] 232 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/utils.rs:227:21 [INFO] [stdout] | [INFO] [stdout] 227 | / match is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) [INFO] [stdout] 228 | | { [INFO] [stdout] 229 | | Some(res) => { [INFO] [stdout] 230 | | if res.contains("/") { [INFO] [stdout] ... | [INFO] [stdout] 234 | | None => (), [INFO] [stdout] 235 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 227 ~ if let Some(res) = is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) { [INFO] [stdout] 228 + if res.contains("/") { [INFO] [stdout] 229 + results.push((4, res)) [INFO] [stdout] 230 + } [INFO] [stdout] 231 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:240:57 [INFO] [stdout] | [INFO] [stdout] 240 | for capture in regexes[5].captures_iter(&args_string) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `args_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/utils.rs:241:21 [INFO] [stdout] | [INFO] [stdout] 241 | / match is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) [INFO] [stdout] 242 | | { [INFO] [stdout] 243 | | Some(res) => results.push((5, res)), [INFO] [stdout] 244 | | None => (), [INFO] [stdout] 245 | | } [INFO] [stdout] | |_____________________^ help: try: `if let Some(res) = is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) { results.push((5, res)) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils.rs:250:57 [INFO] [stdout] | [INFO] [stdout] 250 | for capture in regexes[6].captures_iter(&args_string) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `args_string` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/utils.rs:251:21 [INFO] [stdout] | [INFO] [stdout] 251 | / match is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) [INFO] [stdout] 252 | | { [INFO] [stdout] 253 | | Some(res) => results.push((6, res)), [INFO] [stdout] 254 | | None => (), [INFO] [stdout] 255 | | } [INFO] [stdout] | |_____________________^ help: try: `if let Some(res) = is_separate_argument(capture.get(1).unwrap(), &characters, characters_len) { results.push((6, res)) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 60 | if !command.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `command.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `command_captures` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:40:27 [INFO] [stdout] | [INFO] [stdout] 37 | if command_captures.is_none() { [INFO] [stdout] | ----------------------------- help: try: `if let Some() = command_captures` [INFO] [stdout] ... [INFO] [stdout] 40 | let capture = command_captures.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `command` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:61:19 [INFO] [stdout] | [INFO] [stdout] 60 | if !command.is_none() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 61 | match command.unwrap() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `command` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:67:37 [INFO] [stdout] | [INFO] [stdout] 60 | if !command.is_none() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 67 | _ => utils::execute(command.unwrap(), processed_args), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/main.rs:55:60 [INFO] [stdout] | [INFO] [stdout] 55 | let processed_args: Option> = match args_string { [INFO] [stdout] | ____________________________________________________________^ [INFO] [stdout] 56 | | Some(args_str) => Some(utils::parse_args(&args_str)), [INFO] [stdout] 57 | | None => None, [INFO] [stdout] 58 | | }; [INFO] [stdout] | |_________^ help: try: `args_string.map(|args_str| utils::parse_args(&args_str))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.13s [INFO] running `Command { std: "docker" "inspect" "96315c70d1215f690acc2a807fd3d35e0ff59916f991b18ca82e1070932c557b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "96315c70d1215f690acc2a807fd3d35e0ff59916f991b18ca82e1070932c557b", kill_on_drop: false }` [INFO] [stdout] 96315c70d1215f690acc2a807fd3d35e0ff59916f991b18ca82e1070932c557b