[INFO] cloning repository https://github.com/TegranGrigorian/rusty-sync
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TegranGrigorian/rusty-sync" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTegranGrigorian%2Frusty-sync", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTegranGrigorian%2Frusty-sync'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] bb54aba71b129836565f64e0d9ce92285929562f
[INFO] linting TegranGrigorian/rusty-sync against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTegranGrigorian%2Frusty-sync" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/TegranGrigorian/rusty-sync
[INFO] finished tweaking git repo https://github.com/TegranGrigorian/rusty-sync
[INFO] tweaked toml for git repo https://github.com/TegranGrigorian/rusty-sync written to /workspace/builds/worker-4-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/TegranGrigorian/rusty-sync on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/TegranGrigorian/rusty-sync already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded libredox v0.1.9
[INFO] [stderr]   Downloaded bitflags v2.9.3
[INFO] [stderr]   Downloaded dirs v5.0.1
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] d3ebe8af7574bff1ea6a0584e256e36803eb034ccd42352c628dd4da09d789a5
[INFO] running `Command { std: "docker" "start" "-a" "d3ebe8af7574bff1ea6a0584e256e36803eb034ccd42352c628dd4da09d789a5", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "d3ebe8af7574bff1ea6a0584e256e36803eb034ccd42352c628dd4da09d789a5", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "d3ebe8af7574bff1ea6a0584e256e36803eb034ccd42352c628dd4da09d789a5", kill_on_drop: false }`
[INFO] [stdout] d3ebe8af7574bff1ea6a0584e256e36803eb034ccd42352c628dd4da09d789a5
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] ccae6eea0da9e8bc73f9c069cc46451082447351e3449d97ba44cb6506840c32
[INFO] running `Command { std: "docker" "start" "-a" "ccae6eea0da9e8bc73f9c069cc46451082447351e3449d97ba44cb6506840c32", kill_on_drop: false }`
[INFO] [stderr]    Compiling proc-macro2 v1.0.95
[INFO] [stderr]     Checking option-ext v0.2.0
[INFO] [stderr]     Checking memchr v2.7.5
[INFO] [stderr]     Checking dirs-sys v0.4.1
[INFO] [stderr]     Checking dirs v5.0.1
[INFO] [stderr]    Compiling quote v1.0.40
[INFO] [stderr]    Compiling syn v2.0.104
[INFO] [stderr]    Compiling serde_derive v1.0.219
[INFO] [stderr]     Checking serde v1.0.219
[INFO] [stderr]     Checking serde_json v1.0.142
[INFO] [stderr]     Checking rusty-sync v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unused import: `self`
[INFO] [stdout]  --> src/cli/interface_init.rs:8:15
[INFO] [stdout]   |
[INFO] [stdout] 8 | use std::io::{self, Write};
[INFO] [stdout]   |               ^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused import: `self`
[INFO] [stdout]  --> src/cli/interface_init.rs:8:15
[INFO] [stdout]   |
[INFO] [stdout] 8 | use std::io::{self, Write};
[INFO] [stdout]   |               ^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `file_tree`
[INFO] [stdout]   --> src/cloud/upload_files.rs:12:13
[INFO] [stdout]    |
[INFO] [stdout] 12 |         let file_tree: FileNode =
[INFO] [stdout]    |             ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_tree`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `local_tree`
[INFO] [stdout]    --> src/cli/interface_init.rs:255:13
[INFO] [stdout]     |
[INFO] [stdout] 255 |         let local_tree = ReadFileTree::generate_tree_preserving_sync_data(local_folder)
[INFO] [stdout]     |             ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_local_tree`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `git_remotes.get(0)`
[INFO] [stdout]    --> src/utils/tree_serializer.rs:330:29
[INFO] [stdout]     |
[INFO] [stdout] 330 |                 git_remote: git_remotes.get(0).cloned(), // Use the first remote if available
[INFO] [stdout]     |                             ^^^^^^^^^^^^^^^^^^ help: try: `git_remotes.first()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout]     = note: `#[warn(clippy::get_first)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `git_remotes.get(0)`
[INFO] [stdout]    --> src/utils/tree_serializer.rs:356:37
[INFO] [stdout]     |
[INFO] [stdout] 356 |                         git_remote: git_remotes.get(0).cloned(),
[INFO] [stdout]     |                                     ^^^^^^^^^^^^^^^^^^ help: try: `git_remotes.first()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this can be `std::io::Error::other(_)`
[INFO] [stdout]    --> src/utils/tree_serializer.rs:421:26
[INFO] [stdout]     |
[INFO] [stdout] 421 |             .map_err(|e| io::Error::new(io::ErrorKind::Other, e.to_string()))?;
[INFO] [stdout]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
[INFO] [stdout]     = note: `#[warn(clippy::io_other_error)]` on by default
[INFO] [stdout] help: use `std::io::Error::other`
[INFO] [stdout]     |
[INFO] [stdout] 421 -             .map_err(|e| io::Error::new(io::ErrorKind::Other, e.to_string()))?;
[INFO] [stdout] 421 +             .map_err(|e| io::Error::other(e.to_string()))?;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/utils/tree_serializer.rs:560:16
[INFO] [stdout]     |
[INFO] [stdout] 560 |             if !local_tree.find_by_path(&remote_file.path).is_some() {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `local_tree.find_by_path(&remote_file.path).is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/utils/tree_serializer.rs:627:9
[INFO] [stdout]     |
[INFO] [stdout] 627 | /         if Path::new(&structure_file).exists() {
[INFO] [stdout] 628 | |             if let Ok(bucket) = Self::read_bucket_from_structure(&structure_file) {
[INFO] [stdout] 629 | |                 return Ok(bucket);
[INFO] [stdout] 630 | |             }
[INFO] [stdout] 631 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 627 ~         if Path::new(&structure_file).exists()
[INFO] [stdout] 628 ~             && let Ok(bucket) = Self::read_bucket_from_structure(&structure_file) {
[INFO] [stdout] 629 |                 return Ok(bucket);
[INFO] [stdout] 630 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/utils/tree_serializer.rs:636:13
[INFO] [stdout]     |
[INFO] [stdout] 636 | /             match std::fs::read_to_string(&config_file) {
[INFO] [stdout] 637 | |                 Ok(bucket) => return Ok(bucket.trim().to_string()),
[INFO] [stdout] 638 | |                 Err(_) => {}
[INFO] [stdout] 639 | |             }
[INFO] [stdout]     | |_____________^ help: try: `if let Ok(bucket) = std::fs::read_to_string(&config_file) { return Ok(bucket.trim().to_string()) }`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]     = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/utils/tree_serializer.rs:669:9
[INFO] [stdout]     |
[INFO] [stdout] 669 | /         if let Ok(json) = serde_json::from_str::<serde_json::Value>(&file_content) {
[INFO] [stdout] 670 | |             if let Some(bucket) = json.get("bucket_name").and_then(|b| b.as_str()) {
[INFO] [stdout] 671 | |                 return Ok(bucket.to_string());
[INFO] [stdout] 672 | |             }
[INFO] [stdout] 673 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 669 ~         if let Ok(json) = serde_json::from_str::<serde_json::Value>(&file_content)
[INFO] [stdout] 670 ~             && let Some(bucket) = json.get("bucket_name").and_then(|b| b.as_str()) {
[INFO] [stdout] 671 |                 return Ok(bucket.to_string());
[INFO] [stdout] 672 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]   --> src/utils/git_util.rs:39:20
[INFO] [stdout]    |
[INFO] [stdout] 39 |               } else if in_remote_section && line.starts_with("url =") {
[INFO] [stdout]    |  ____________________^
[INFO] [stdout] 40 | |                 if let Some(url) = line.split('=').nth(1) {
[INFO] [stdout] 41 | |                     urls.push(url.trim().to_string());
[INFO] [stdout] 42 | |                 }
[INFO] [stdout] 43 | |             }
[INFO] [stdout]    | |_____________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 39 ~             } else if in_remote_section && line.starts_with("url =")
[INFO] [stdout] 40 ~                 && let Some(url) = line.split('=').nth(1) {
[INFO] [stdout] 41 |                     urls.push(url.trim().to_string());
[INFO] [stdout] 42 ~                 }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `GitIgnore`
[INFO] [stdout]   --> src/utils/git_util.rs:57:5
[INFO] [stdout]    |
[INFO] [stdout] 57 | /     pub fn new() -> Self {
[INFO] [stdout] 58 | |         GitIgnore {
[INFO] [stdout] 59 | |             ignored_paths: Vec::new(),
[INFO] [stdout] 60 | |         }
[INFO] [stdout] 61 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 56 + impl Default for GitIgnore {
[INFO] [stdout] 57 +     fn default() -> Self {
[INFO] [stdout] 58 +         Self::new()
[INFO] [stdout] 59 +     }
[INFO] [stdout] 60 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stdout]    --> src/cli/interface_init.rs:177:16
[INFO] [stdout]     |
[INFO] [stdout] 177 |         if let Err(_) = BucketManager::save_bucket_association(&local_folder_abs, bucket) {
[INFO] [stdout]     |         -------^^^^^^-------------------------------------------------------------------- help: try: `if BucketManager::save_bucket_association(&local_folder_abs, bucket).is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]     = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]    --> src/cli/interface_init.rs:293:13
[INFO] [stdout]     |
[INFO] [stdout] 291 | /             let tree = ReadFileTree::generate_tree(local_folder)
[INFO] [stdout] 292 | |                 .map_err(|e| format!("Failed to generate file tree: {}", e))?;
[INFO] [stdout]     | |______________________________________________________________________________- unnecessary `let` binding
[INFO] [stdout] 293 |               tree
[INFO] [stdout]     |               ^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]     = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]     |
[INFO] [stdout] 291 ~             
[INFO] [stdout] 292 ~             ReadFileTree::generate_tree(local_folder)
[INFO] [stdout] 293 +                 .map_err(|e| format!("Failed to generate file tree: {}", e))?
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stdout]    --> src/cli/interface_init.rs:304:16
[INFO] [stdout]     |
[INFO] [stdout] 304 |         if let Err(_) = BucketManager::save_bucket_association(local_folder, bucket) {
[INFO] [stdout]     |         -------^^^^^^--------------------------------------------------------------- help: try: `if BucketManager::save_bucket_association(local_folder, bucket).is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stdout]    --> src/cli/interface_init.rs:574:16
[INFO] [stdout]     |
[INFO] [stdout] 574 |         if let Err(_) = BucketManager::save_bucket_association(&local_folder, &bucket) {
[INFO] [stdout]     |         -------^^^^^^----------------------------------------------------------------- help: try: `if BucketManager::save_bucket_association(&local_folder, &bucket).is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/cli/interface_init.rs:662:17
[INFO] [stdout]     |
[INFO] [stdout] 662 |                 return Ok(());
[INFO] [stdout]     |                 ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 662 -                 return Ok(());
[INFO] [stdout] 662 +                 Ok(())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `file_tree`
[INFO] [stdout]   --> src/cloud/upload_files.rs:12:13
[INFO] [stdout]    |
[INFO] [stdout] 12 |         let file_tree: FileNode =
[INFO] [stdout]    |             ^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_file_tree`
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unused variable: `local_tree`
[INFO] [stdout]    --> src/cli/interface_init.rs:255:13
[INFO] [stdout]     |
[INFO] [stdout] 255 |         let local_tree = ReadFileTree::generate_tree_preserving_sync_data(local_folder)
[INFO] [stdout]     |             ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_local_tree`
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/test.rs:62:17
[INFO] [stdout]    |
[INFO] [stdout] 62 |                 format!("EXAMPLE.struct_git.json")
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"EXAMPLE.struct_git.json".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout]    = note: `#[warn(clippy::useless_format)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:11:9
[INFO] [stdout]    |
[INFO] [stdout] 11 |         return;
[INFO] [stdout]    |         ^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 10 -         InitInterface::run();
[INFO] [stdout] 11 -         return;
[INFO] [stdout] 10 +         InitInterface::run();
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]   --> src/test.rs:62:17
[INFO] [stdout]    |
[INFO] [stdout] 62 |                 format!("EXAMPLE.struct_git.json")
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"EXAMPLE.struct_git.json".to_string()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout]    = note: `#[warn(clippy::useless_format)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:11:9
[INFO] [stdout]    |
[INFO] [stdout] 11 |         return;
[INFO] [stdout]    |         ^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 10 -         InitInterface::run();
[INFO] [stdout] 11 -         return;
[INFO] [stdout] 10 +         InitInterface::run();
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `git_remotes.get(0)`
[INFO] [stdout]    --> src/utils/tree_serializer.rs:330:29
[INFO] [stdout]     |
[INFO] [stdout] 330 |                 git_remote: git_remotes.get(0).cloned(), // Use the first remote if available
[INFO] [stdout]     |                             ^^^^^^^^^^^^^^^^^^ help: try: `git_remotes.first()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout]     = note: `#[warn(clippy::get_first)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `git_remotes.get(0)`
[INFO] [stdout]    --> src/utils/tree_serializer.rs:356:37
[INFO] [stdout]     |
[INFO] [stdout] 356 |                         git_remote: git_remotes.get(0).cloned(),
[INFO] [stdout]     |                                     ^^^^^^^^^^^^^^^^^^ help: try: `git_remotes.first()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this can be `std::io::Error::other(_)`
[INFO] [stdout]    --> src/utils/tree_serializer.rs:421:26
[INFO] [stdout]     |
[INFO] [stdout] 421 |             .map_err(|e| io::Error::new(io::ErrorKind::Other, e.to_string()))?;
[INFO] [stdout]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error
[INFO] [stdout]     = note: `#[warn(clippy::io_other_error)]` on by default
[INFO] [stdout] help: use `std::io::Error::other`
[INFO] [stdout]     |
[INFO] [stdout] 421 -             .map_err(|e| io::Error::new(io::ErrorKind::Other, e.to_string()))?;
[INFO] [stdout] 421 +             .map_err(|e| io::Error::other(e.to_string()))?;
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/utils/tree_serializer.rs:560:16
[INFO] [stdout]     |
[INFO] [stdout] 560 |             if !local_tree.find_by_path(&remote_file.path).is_some() {
[INFO] [stdout]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `local_tree.find_by_path(&remote_file.path).is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/utils/tree_serializer.rs:627:9
[INFO] [stdout]     |
[INFO] [stdout] 627 | /         if Path::new(&structure_file).exists() {
[INFO] [stdout] 628 | |             if let Ok(bucket) = Self::read_bucket_from_structure(&structure_file) {
[INFO] [stdout] 629 | |                 return Ok(bucket);
[INFO] [stdout] 630 | |             }
[INFO] [stdout] 631 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 627 ~         if Path::new(&structure_file).exists()
[INFO] [stdout] 628 ~             && let Ok(bucket) = Self::read_bucket_from_structure(&structure_file) {
[INFO] [stdout] 629 |                 return Ok(bucket);
[INFO] [stdout] 630 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
[INFO] [stdout]    --> src/utils/tree_serializer.rs:636:13
[INFO] [stdout]     |
[INFO] [stdout] 636 | /             match std::fs::read_to_string(&config_file) {
[INFO] [stdout] 637 | |                 Ok(bucket) => return Ok(bucket.trim().to_string()),
[INFO] [stdout] 638 | |                 Err(_) => {}
[INFO] [stdout] 639 | |             }
[INFO] [stdout]     | |_____________^ help: try: `if let Ok(bucket) = std::fs::read_to_string(&config_file) { return Ok(bucket.trim().to_string()) }`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stdout]     = note: `#[warn(clippy::single_match)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/utils/tree_serializer.rs:669:9
[INFO] [stdout]     |
[INFO] [stdout] 669 | /         if let Ok(json) = serde_json::from_str::<serde_json::Value>(&file_content) {
[INFO] [stdout] 670 | |             if let Some(bucket) = json.get("bucket_name").and_then(|b| b.as_str()) {
[INFO] [stdout] 671 | |                 return Ok(bucket.to_string());
[INFO] [stdout] 672 | |             }
[INFO] [stdout] 673 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 669 ~         if let Ok(json) = serde_json::from_str::<serde_json::Value>(&file_content)
[INFO] [stdout] 670 ~             && let Some(bucket) = json.get("bucket_name").and_then(|b| b.as_str()) {
[INFO] [stdout] 671 |                 return Ok(bucket.to_string());
[INFO] [stdout] 672 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]   --> src/utils/git_util.rs:39:20
[INFO] [stdout]    |
[INFO] [stdout] 39 |               } else if in_remote_section && line.starts_with("url =") {
[INFO] [stdout]    |  ____________________^
[INFO] [stdout] 40 | |                 if let Some(url) = line.split('=').nth(1) {
[INFO] [stdout] 41 | |                     urls.push(url.trim().to_string());
[INFO] [stdout] 42 | |                 }
[INFO] [stdout] 43 | |             }
[INFO] [stdout]    | |_____________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 39 ~             } else if in_remote_section && line.starts_with("url =")
[INFO] [stdout] 40 ~                 && let Some(url) = line.split('=').nth(1) {
[INFO] [stdout] 41 |                     urls.push(url.trim().to_string());
[INFO] [stdout] 42 ~                 }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `GitIgnore`
[INFO] [stdout]   --> src/utils/git_util.rs:57:5
[INFO] [stdout]    |
[INFO] [stdout] 57 | /     pub fn new() -> Self {
[INFO] [stdout] 58 | |         GitIgnore {
[INFO] [stdout] 59 | |             ignored_paths: Vec::new(),
[INFO] [stdout] 60 | |         }
[INFO] [stdout] 61 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 56 + impl Default for GitIgnore {
[INFO] [stdout] 57 +     fn default() -> Self {
[INFO] [stdout] 58 +         Self::new()
[INFO] [stdout] 59 +     }
[INFO] [stdout] 60 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stdout]    --> src/cli/interface_init.rs:177:16
[INFO] [stdout]     |
[INFO] [stdout] 177 |         if let Err(_) = BucketManager::save_bucket_association(&local_folder_abs, bucket) {
[INFO] [stdout]     |         -------^^^^^^-------------------------------------------------------------------- help: try: `if BucketManager::save_bucket_association(&local_folder_abs, bucket).is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout]     = note: `#[warn(clippy::redundant_pattern_matching)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]    --> src/cli/interface_init.rs:293:13
[INFO] [stdout]     |
[INFO] [stdout] 291 | /             let tree = ReadFileTree::generate_tree(local_folder)
[INFO] [stdout] 292 | |                 .map_err(|e| format!("Failed to generate file tree: {}", e))?;
[INFO] [stdout]     | |______________________________________________________________________________- unnecessary `let` binding
[INFO] [stdout] 293 |               tree
[INFO] [stdout]     |               ^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]     = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]     |
[INFO] [stdout] 291 ~             
[INFO] [stdout] 292 ~             ReadFileTree::generate_tree(local_folder)
[INFO] [stdout] 293 +                 .map_err(|e| format!("Failed to generate file tree: {}", e))?
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stdout]    --> src/cli/interface_init.rs:304:16
[INFO] [stdout]     |
[INFO] [stdout] 304 |         if let Err(_) = BucketManager::save_bucket_association(local_folder, bucket) {
[INFO] [stdout]     |         -------^^^^^^--------------------------------------------------------------- help: try: `if BucketManager::save_bucket_association(local_folder, bucket).is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stdout]    --> src/cli/interface_init.rs:574:16
[INFO] [stdout]     |
[INFO] [stdout] 574 |         if let Err(_) = BucketManager::save_bucket_association(&local_folder, &bucket) {
[INFO] [stdout]     |         -------^^^^^^----------------------------------------------------------------- help: try: `if BucketManager::save_bucket_association(&local_folder, &bucket).is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/cli/interface_init.rs:662:17
[INFO] [stdout]     |
[INFO] [stdout] 662 |                 return Ok(());
[INFO] [stdout]     |                 ^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]     = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 662 -                 return Ok(());
[INFO] [stdout] 662 +                 Ok(())
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.04s
[INFO] running `Command { std: "docker" "inspect" "ccae6eea0da9e8bc73f9c069cc46451082447351e3449d97ba44cb6506840c32", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "ccae6eea0da9e8bc73f9c069cc46451082447351e3449d97ba44cb6506840c32", kill_on_drop: false }`
[INFO] [stdout] ccae6eea0da9e8bc73f9c069cc46451082447351e3449d97ba44cb6506840c32