[INFO] cloning repository https://github.com/TKafoe/aoc2024 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TKafoe/aoc2024" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTKafoe%2Faoc2024", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTKafoe%2Faoc2024'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 075bd65fd88f3c8a0fb77b2251e839a8e9bce344 [INFO] linting TKafoe/aoc2024 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTKafoe%2Faoc2024" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/TKafoe/aoc2024 [INFO] finished tweaking git repo https://github.com/TKafoe/aoc2024 [INFO] tweaked toml for git repo https://github.com/TKafoe/aoc2024 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/TKafoe/aoc2024 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/TKafoe/aoc2024 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6e783d1e2d89b428418a1f7582884d5242756760be5892f84ebde1365b4f51bd [INFO] running `Command { std: "docker" "start" "-a" "6e783d1e2d89b428418a1f7582884d5242756760be5892f84ebde1365b4f51bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6e783d1e2d89b428418a1f7582884d5242756760be5892f84ebde1365b4f51bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e783d1e2d89b428418a1f7582884d5242756760be5892f84ebde1365b4f51bd", kill_on_drop: false }` [INFO] [stdout] 6e783d1e2d89b428418a1f7582884d5242756760be5892f84ebde1365b4f51bd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fd67b449e960ce2f8835b1fcb3ac0e616a377867b50afa7e85b1b64f02f4a9c5 [INFO] running `Command { std: "docker" "start" "-a" "fd67b449e960ce2f8835b1fcb3ac0e616a377867b50afa7e85b1b64f02f4a9c5", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.4.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking aoc-2024 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Rational64` [INFO] [stdout] --> src/day13/solver.rs:2:33 [INFO] [stdout] | [INFO] [stdout] 2 | use num_rational::{BigRational, Rational64}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Rational64` [INFO] [stdout] --> src/day13/solver.rs:2:33 [INFO] [stdout] | [INFO] [stdout] 2 | use num_rational::{BigRational, Rational64}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `test_p2` [INFO] [stdout] --> src/day14/solver.rs:142:19 [INFO] [stdout] | [INFO] [stdout] 142 | let (test_p1, test_p2) = solve_per_path(&"src/day14/test.txt", test_field_size); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_test_p2` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `l` [INFO] [stdout] --> src/day1/solver.rs:41:14 [INFO] [stdout] | [INFO] [stdout] 41 | for i in 0..l.len() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 41 - for i in 0..l.len() { [INFO] [stdout] 41 + for in &l { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day1/solver.rs:64:55 [INFO] [stdout] | [INFO] [stdout] 64 | let (result_test_p1, result_test_p2) = solve_file(&test_file); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `test_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day1/solver.rs:65:57 [INFO] [stdout] | [INFO] [stdout] 65 | let (result_input_p1, result_input_p2) = solve_file(&input_file); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `input_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/day2/solver.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | /// the numbers as decreasing or increasing. [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day2/solver.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return true; [INFO] [stdout] 74 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day2/solver.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return true; [INFO] [stdout] 84 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day2/solver.rs:103:20 [INFO] [stdout] | [INFO] [stdout] 103 | fn is_safe(report: &Vec, use_problem_dampener: bool) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 103 - fn is_safe(report: &Vec, use_problem_dampener: bool) -> bool { [INFO] [stdout] 103 + fn is_safe(report: &[i32], use_problem_dampener: bool) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day3/solver.rs:13:25 [INFO] [stdout] | [INFO] [stdout] 13 | extract_muls(input, &re_pattern) [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `re_pattern` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/day3/solver.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 49 | let result = multiply(muls); [INFO] [stdout] | ---------------------------- unnecessary `let` binding [INFO] [stdout] 50 | [INFO] [stdout] 51 | result [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 49 ~ [INFO] [stdout] 50 | [INFO] [stdout] 51 ~ multiply(muls) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/day3/solver.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | let muls; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `muls` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 42 ~ [INFO] [stdout] 43 ~ let muls = if !use_disables { [INFO] [stdout] 44 ~ extract_muls_without_disables(input) [INFO] [stdout] 45 | } else { [INFO] [stdout] 46 ~ extract_muls_with_disables(input) [INFO] [stdout] 47 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day4/solver.rs:3:29 [INFO] [stdout] | [INFO] [stdout] 3 | fn parse_horizontals(input: &Vec>, m: &mut Vec>) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - fn parse_horizontals(input: &Vec>, m: &mut Vec>) -> i32 { [INFO] [stdout] 3 + fn parse_horizontals(input: &[Vec<(char, (i32, i32))>], m: &mut Vec>) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/day4/solver.rs:3:63 [INFO] [stdout] | [INFO] [stdout] 3 | fn parse_horizontals(input: &Vec>, m: &mut Vec>) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - fn parse_horizontals(input: &Vec>, m: &mut Vec>) -> i32 { [INFO] [stdout] 3 + fn parse_horizontals(input: &Vec>, m: &mut [Vec]) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `input` [INFO] [stdout] --> src/day4/solver.rs:5:14 [INFO] [stdout] | [INFO] [stdout] 5 | for j in 0..input.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 5 - for j in 0..input.len() { [INFO] [stdout] 5 + for in &input { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day4/solver.rs:31:29 [INFO] [stdout] | [INFO] [stdout] 31 | fn extract_verticals(input: &Vec>) -> Vec> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 31 - fn extract_verticals(input: &Vec>) -> Vec> { [INFO] [stdout] 31 + fn extract_verticals(input: &[Vec<(char, (i32, i32))>]) -> Vec> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `r` is only used to index `input` [INFO] [stdout] --> src/day4/solver.rs:36:18 [INFO] [stdout] | [INFO] [stdout] 36 | for r in 0..input.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 36 - for r in 0..input.len() { [INFO] [stdout] 36 + for in &input { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(char, (i32, i32))` which implements the `Copy` trait [INFO] [stdout] --> src/day4/solver.rs:37:27 [INFO] [stdout] | [INFO] [stdout] 37 | vertical.push(input[r][c].clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `input[r][c]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day4/solver.rs:46:34 [INFO] [stdout] | [INFO] [stdout] 46 | fn extract_diagonals_down(input: &Vec>) -> Vec> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 46 - fn extract_diagonals_down(input: &Vec>) -> Vec> { [INFO] [stdout] 46 + fn extract_diagonals_down(input: &[Vec<(char, (i32, i32))>]) -> Vec> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(char, (i32, i32))` which implements the `Copy` trait [INFO] [stdout] --> src/day4/solver.rs:55:27 [INFO] [stdout] | [INFO] [stdout] 55 | diagonal.push(input[t_r_i][c_i].clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `input[t_r_i][c_i]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(char, (i32, i32))` which implements the `Copy` trait [INFO] [stdout] --> src/day4/solver.rs:70:27 [INFO] [stdout] | [INFO] [stdout] 70 | diagonal.push(input[r_i][t_c_i].clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `input[r_i][t_c_i]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day4/solver.rs:82:32 [INFO] [stdout] | [INFO] [stdout] 82 | fn extract_diagonals_up(input: &Vec>) -> Vec> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 82 - fn extract_diagonals_up(input: &Vec>) -> Vec> { [INFO] [stdout] 82 + fn extract_diagonals_up(input: &[Vec<(char, (i32, i32))>]) -> Vec> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(char, (i32, i32))` which implements the `Copy` trait [INFO] [stdout] --> src/day4/solver.rs:90:27 [INFO] [stdout] | [INFO] [stdout] 90 | diagonal.push(input[t_r_i as usize][c_i].clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `input[t_r_i as usize][c_i]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(char, (i32, i32))` which implements the `Copy` trait [INFO] [stdout] --> src/day4/solver.rs:105:27 [INFO] [stdout] | [INFO] [stdout] 105 | diagonal.push(input[r_i as usize][t_c_i].clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `input[r_i as usize][t_c_i]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/day4/solver.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | char_v.push('.'); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec!['.';SIZE]` [INFO] [stdout] = help: or `char_v.extend(std::iter::repeat_n('.', SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] = note: `#[warn(clippy::same_item_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day4/solver.rs:159:19 [INFO] [stdout] | [INFO] [stdout] 159 | fn count_x_mas(m: &Vec>) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 159 - fn count_x_mas(m: &Vec>) -> i32 { [INFO] [stdout] 159 + fn count_x_mas(m: &[Vec<(char, (i32, i32))>]) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/day4/solver.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | / if m[r][c].0 == 'A' { [INFO] [stdout] 164 | | if check_mas(m[r - 1][c - 1].0, m[r + 1][c + 1].0) [INFO] [stdout] 165 | | && check_mas(m[r + 1][c - 1].0, m[r - 1][c + 1].0) [INFO] [stdout] ... | [INFO] [stdout] 169 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 163 ~ if m[r][c].0 == 'A' [INFO] [stdout] 164 ~ && check_mas(m[r - 1][c - 1].0, m[r + 1][c + 1].0) [INFO] [stdout] 165 | && check_mas(m[r + 1][c - 1].0, m[r - 1][c + 1].0) [INFO] [stdout] 166 | { [INFO] [stdout] 167 | ct += 1; [INFO] [stdout] 168 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `input` [INFO] [stdout] --> src/day4/solver.rs:179:14 [INFO] [stdout] | [INFO] [stdout] 179 | for i in 0..input.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 179 - for i in 0..input.len() { [INFO] [stdout] 179 + for (i, ) in input.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `c` is used to index `input` [INFO] [stdout] --> src/day4/solver.rs:181:18 [INFO] [stdout] | [INFO] [stdout] 181 | for c in 0..input[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 181 - for c in 0..input[i].len() { [INFO] [stdout] 181 + for (c, ) in input.iter().enumerate().take(input[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/day5/solver.rs:4:20 [INFO] [stdout] | [INFO] [stdout] 4 | fn shift_vector(v: &mut Vec, to_i: usize, from_i: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 - fn shift_vector(v: &mut Vec, to_i: usize, from_i: usize) { [INFO] [stdout] 4 + fn shift_vector(v: &mut [i32], to_i: usize, from_i: usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/day5/solver.rs:6:14 [INFO] [stdout] | [INFO] [stdout] 6 | for i in to_i..from_i + 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 6 - for i in to_i..from_i + 1 { [INFO] [stdout] 6 + for in v.iter_mut().take(from_i + 1).skip(to_i) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like you are swapping `v[i]` and `swap` manually [INFO] [stdout] --> src/day5/solver.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | / let t = v[i]; [INFO] [stdout] 8 | | v[i] = swap; [INFO] [stdout] 9 | | [INFO] [stdout] 10 | | swap = t; [INFO] [stdout] | |_________________^ help: try: `std::mem::swap(&mut v[i], &mut swap);` [INFO] [stdout] | [INFO] [stdout] = note: or maybe you should use `std::mem::replace`? [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] = note: `#[warn(clippy::manual_swap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day5/solver.rs:51:24 [INFO] [stdout] | [INFO] [stdout] 51 | if !check_rule(&update_list, rule) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `update_list` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day5/solver.rs:140:48 [INFO] [stdout] | [INFO] [stdout] 140 | let (test_rules, test_updates) = load_data(&test_path); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `test_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day5/solver.rs:141:38 [INFO] [stdout] | [INFO] [stdout] 141 | let (rules, updates) = load_data(&input_path); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `input_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `field` [INFO] [stdout] --> src/day6/solver.rs:11:14 [INFO] [stdout] | [INFO] [stdout] 11 | for i in 0..field.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 11 - for i in 0..field.len() { [INFO] [stdout] 11 + for (i, ) in field.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `field` [INFO] [stdout] --> src/day6/solver.rs:12:18 [INFO] [stdout] | [INFO] [stdout] 12 | for j in 0..field[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 12 - for j in 0..field[i].len() { [INFO] [stdout] 12 + for (j, ) in field.iter().enumerate().take(field[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/day6/solver.rs:23:39 [INFO] [stdout] | [INFO] [stdout] 23 | fn move_guard(pos: (i32, i32), field: &mut Vec>) -> (i32, i32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 23 - fn move_guard(pos: (i32, i32), field: &mut Vec>) -> (i32, i32) { [INFO] [stdout] 23 + fn move_guard(pos: (i32, i32), field: &mut [Vec]) -> (i32, i32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/day6/solver.rs:80:14 [INFO] [stdout] | [INFO] [stdout] 80 | _ => assert!(false), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/day6/solver.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/day7/solver.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | if terms.len() == 0 && num == target { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `terms.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/day7/solver.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | if terms.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `terms.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day8/solver.rs:38:29 [INFO] [stdout] | [INFO] [stdout] 38 | fn compute_antinodes(nodes: &Vec<(char, (i32, i32))>, field_size: (i32, i32), p2: bool) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 38 - fn compute_antinodes(nodes: &Vec<(char, (i32, i32))>, field_size: (i32, i32), p2: bool) -> i32 { [INFO] [stdout] 38 + fn compute_antinodes(nodes: &[(char, (i32, i32))], field_size: (i32, i32), p2: bool) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/day8/solver.rs:67:29 [INFO] [stdout] | [INFO] [stdout] 67 | fn load_data(path: &str) -> (Vec<(char, (i32, i32))>, (i32, i32)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `lines` [INFO] [stdout] --> src/day8/solver.rs:72:14 [INFO] [stdout] | [INFO] [stdout] 72 | for i in 0..lines.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 72 - for i in 0..lines.len() { [INFO] [stdout] 72 + for (i, ) in lines.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `lines` [INFO] [stdout] --> src/day8/solver.rs:73:18 [INFO] [stdout] | [INFO] [stdout] 73 | for j in 0..lines[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 73 - for j in 0..lines[i].len() { [INFO] [stdout] 73 + for (j, ) in lines.iter().enumerate().take(lines[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `data` [INFO] [stdout] --> src/day9/solver.rs:12:14 [INFO] [stdout] | [INFO] [stdout] 12 | for i in 0..data.len() - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 12 - for i in 0..data.len() - 1 { [INFO] [stdout] 12 + for in data.iter().take(data.len() - 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/day9/solver.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 32 | fn rearrange(input: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 - fn rearrange(input: &mut Vec) { [INFO] [stdout] 32 + fn rearrange(input: &mut [String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day9/solver.rs:53:27 [INFO] [stdout] | [INFO] [stdout] 53 | fn find_free_space(input: &Vec, len: i32, i: i32) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 53 - fn find_free_space(input: &Vec, len: i32, i: i32) -> i32 { [INFO] [stdout] 53 + fn find_free_space(input: &[String], len: i32, i: i32) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day9/solver.rs:109:28 [INFO] [stdout] | [INFO] [stdout] 109 | fn compute_checksum(input: &Vec) -> i128 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 109 - fn compute_checksum(input: &Vec) -> i128 { [INFO] [stdout] 109 + fn compute_checksum(input: &[String]) -> i128 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `input` [INFO] [stdout] --> src/day9/solver.rs:111:14 [INFO] [stdout] | [INFO] [stdout] 111 | for i in 0..input.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 111 - for i in 0..input.len() { [INFO] [stdout] 111 + for (i, ) in input.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day9/solver.rs:123:36 [INFO] [stdout] | [INFO] [stdout] 123 | let mut test_input = load_data(&test_path); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `test_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day9/solver.rs:126:31 [INFO] [stdout] | [INFO] [stdout] 126 | let mut input = load_data(&path); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day9/solver.rs:136:28 [INFO] [stdout] | [INFO] [stdout] 136 | test_input = load_data(&test_path); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `test_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day9/solver.rs:137:23 [INFO] [stdout] | [INFO] [stdout] 137 | input = load_data(&path); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day10/solver.rs:15:37 [INFO] [stdout] | [INFO] [stdout] 15 | fn in_field(pos: (i32, i32), field: &Vec>) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 - fn in_field(pos: (i32, i32), field: &Vec>) -> bool { [INFO] [stdout] 15 + fn in_field(pos: (i32, i32), field: &[Vec]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `data` [INFO] [stdout] --> src/day10/solver.rs:75:14 [INFO] [stdout] | [INFO] [stdout] 75 | for i in 0..data.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 75 - for i in 0..data.len() { [INFO] [stdout] 75 + for (i, ) in data.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `data` [INFO] [stdout] --> src/day10/solver.rs:76:18 [INFO] [stdout] | [INFO] [stdout] 76 | for j in 0..data[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 76 - for j in 0..data[i].len() { [INFO] [stdout] 76 + for (j, ) in data.iter().enumerate().take(data[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/day11/solver.rs:28:15 [INFO] [stdout] | [INFO] [stdout] 28 | } else if num.to_string().len() % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `num.to_string().len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day11/solver.rs:47:41 [INFO] [stdout] | [INFO] [stdout] 47 | fn blink_n_recursively(n: usize, input: &Vec) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 47 - fn blink_n_recursively(n: usize, input: &Vec) -> usize { [INFO] [stdout] 47 + fn blink_n_recursively(n: usize, input: &[usize]) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `input` [INFO] [stdout] --> src/day11/solver.rs:50:14 [INFO] [stdout] | [INFO] [stdout] 50 | for i in 0..input.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 50 - for i in 0..input.len() { [INFO] [stdout] 50 + for in &input { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day11/solver.rs:58:31 [INFO] [stdout] | [INFO] [stdout] 58 | let test_data = load_data(&test_path); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `test_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day11/solver.rs:66:26 [INFO] [stdout] | [INFO] [stdout] 66 | let data = load_data(&path); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day12/solver.rs:14:37 [INFO] [stdout] | [INFO] [stdout] 14 | fn in_field(pos: (i32, i32), field: &Vec>) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 14 - fn in_field(pos: (i32, i32), field: &Vec>) -> bool { [INFO] [stdout] 14 + fn in_field(pos: (i32, i32), field: &[Vec]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/day12/solver.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | if edges.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `edges.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/day12/solver.rs:129:11 [INFO] [stdout] | [INFO] [stdout] 129 | while queue.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!queue.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day13/solver.rs:32:27 [INFO] [stdout] | [INFO] [stdout] 32 | fn get_solutions(problem: &Vec<(i64, i64)>, corrected: bool) -> (BigInt, BigInt) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 - fn get_solutions(problem: &Vec<(i64, i64)>, corrected: bool) -> (BigInt, BigInt) { [INFO] [stdout] 32 + fn get_solutions(problem: &[(i64, i64)], corrected: bool) -> (BigInt, BigInt) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i128` is unnecessary [INFO] [stdout] --> src/day13/solver.rs:41:28 [INFO] [stdout] | [INFO] [stdout] 41 | x3 += BigInt::from(10000000000000 as i128); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `10000000000000_i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i128` is unnecessary [INFO] [stdout] --> src/day13/solver.rs:42:28 [INFO] [stdout] | [INFO] [stdout] 42 | y3 += BigInt::from(10000000000000 as i128); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `10000000000000_i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day13/solver.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | && (!(&a * problem[0].0 + &b * problem[1].0 == BigInt::from(problem[2].0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(&a * problem[0].0 + &b * problem[1].0 != BigInt::from(problem[2].0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day13/solver.rs:65:16 [INFO] [stdout] | [INFO] [stdout] 65 | || !(&a * problem[0].1 + &b * problem[1].1 == BigInt::from(problem[2].1))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(&a * problem[0].1 + &b * problem[1].1 != BigInt::from(problem[2].1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day13/solver.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | && (!(&a * problem[0].0 + &b * problem[1].0 [INFO] [stdout] | _____________^ [INFO] [stdout] 72 | | == BigInt::from(problem[2].0) + BigInt::from(10000000000000 as i128)) [INFO] [stdout] | |_________________________________________________________________________________^ help: try: `(&a * problem[0].0 + &b * problem[1].0 != BigInt::from(problem[2].0) + BigInt::from(10000000000000 as i128))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day13/solver.rs:73:16 [INFO] [stdout] | [INFO] [stdout] 73 | || !(&a * problem[0].1 + &b * problem[1].1 [INFO] [stdout] | ________________^ [INFO] [stdout] 74 | | == BigInt::from(problem[2].1) + BigInt::from(10000000000000 as i128))) [INFO] [stdout] | |_____________________________________________________________________________________^ help: try: `(&a * problem[0].1 + &b * problem[1].1 != BigInt::from(problem[2].1) + BigInt::from(10000000000000 as i128))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i128` is unnecessary [INFO] [stdout] --> src/day13/solver.rs:72:58 [INFO] [stdout] | [INFO] [stdout] 72 | == BigInt::from(problem[2].0) + BigInt::from(10000000000000 as i128)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `10000000000000_i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i128` is unnecessary [INFO] [stdout] --> src/day13/solver.rs:74:62 [INFO] [stdout] | [INFO] [stdout] 74 | == BigInt::from(problem[2].1) + BigInt::from(10000000000000 as i128))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `10000000000000_i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day13/solver.rs:82:28 [INFO] [stdout] | [INFO] [stdout] 82 | fn compute_costs(problems: &Vec>, corrected: bool) -> BigInt { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 82 - fn compute_costs(problems: &Vec>, corrected: bool) -> BigInt { [INFO] [stdout] 82 + fn compute_costs(problems: &[Vec<(i64, i64)>], corrected: bool) -> BigInt { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day14/solver.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | return (-1, -1); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return (-1, -1); [INFO] [stdout] 62 + (-1, -1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/day14/solver.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | row.push('.'); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec!['.';SIZE]` [INFO] [stdout] = help: or `row.extend(std::iter::repeat_n('.', SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/day14/solver.rs:105:27 [INFO] [stdout] | [INFO] [stdout] 105 | let p1 = map.values().fold(1, |agg, v| agg * v); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `product::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day14/solver.rs:142:45 [INFO] [stdout] | [INFO] [stdout] 142 | let (test_p1, test_p2) = solve_per_path(&"src/day14/test.txt", test_field_size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `"src/day14/test.txt"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day14/solver.rs:143:35 [INFO] [stdout] | [INFO] [stdout] 143 | let (p1, p2) = solve_per_path(&"src/day14/input.txt", field_size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `"src/day14/input.txt"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `test_p2` [INFO] [stdout] --> src/day14/solver.rs:142:19 [INFO] [stdout] | [INFO] [stdout] 142 | let (test_p1, test_p2) = solve_per_path(&"src/day14/test.txt", test_field_size); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_test_p2` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `l` [INFO] [stdout] --> src/day1/solver.rs:41:14 [INFO] [stdout] | [INFO] [stdout] 41 | for i in 0..l.len() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 41 - for i in 0..l.len() { [INFO] [stdout] 41 + for in &l { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day1/solver.rs:64:55 [INFO] [stdout] | [INFO] [stdout] 64 | let (result_test_p1, result_test_p2) = solve_file(&test_file); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `test_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day1/solver.rs:65:57 [INFO] [stdout] | [INFO] [stdout] 65 | let (result_input_p1, result_input_p2) = solve_file(&input_file); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `input_file` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/day2/solver.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | /// the numbers as decreasing or increasing. [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day2/solver.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return true; [INFO] [stdout] 74 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day2/solver.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return true; [INFO] [stdout] 84 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day2/solver.rs:103:20 [INFO] [stdout] | [INFO] [stdout] 103 | fn is_safe(report: &Vec, use_problem_dampener: bool) -> bool { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 103 - fn is_safe(report: &Vec, use_problem_dampener: bool) -> bool { [INFO] [stdout] 103 + fn is_safe(report: &[i32], use_problem_dampener: bool) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day3/solver.rs:13:25 [INFO] [stdout] | [INFO] [stdout] 13 | extract_muls(input, &re_pattern) [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `re_pattern` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/day3/solver.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 49 | let result = multiply(muls); [INFO] [stdout] | ---------------------------- unnecessary `let` binding [INFO] [stdout] 50 | [INFO] [stdout] 51 | result [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 49 ~ [INFO] [stdout] 50 | [INFO] [stdout] 51 ~ multiply(muls) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/day3/solver.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | let muls; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `muls` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 42 ~ [INFO] [stdout] 43 ~ let muls = if !use_disables { [INFO] [stdout] 44 ~ extract_muls_without_disables(input) [INFO] [stdout] 45 | } else { [INFO] [stdout] 46 ~ extract_muls_with_disables(input) [INFO] [stdout] 47 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day4/solver.rs:3:29 [INFO] [stdout] | [INFO] [stdout] 3 | fn parse_horizontals(input: &Vec>, m: &mut Vec>) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - fn parse_horizontals(input: &Vec>, m: &mut Vec>) -> i32 { [INFO] [stdout] 3 + fn parse_horizontals(input: &[Vec<(char, (i32, i32))>], m: &mut Vec>) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/day4/solver.rs:3:63 [INFO] [stdout] | [INFO] [stdout] 3 | fn parse_horizontals(input: &Vec>, m: &mut Vec>) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 3 - fn parse_horizontals(input: &Vec>, m: &mut Vec>) -> i32 { [INFO] [stdout] 3 + fn parse_horizontals(input: &Vec>, m: &mut [Vec]) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `input` [INFO] [stdout] --> src/day4/solver.rs:5:14 [INFO] [stdout] | [INFO] [stdout] 5 | for j in 0..input.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 5 - for j in 0..input.len() { [INFO] [stdout] 5 + for in &input { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day4/solver.rs:31:29 [INFO] [stdout] | [INFO] [stdout] 31 | fn extract_verticals(input: &Vec>) -> Vec> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 31 - fn extract_verticals(input: &Vec>) -> Vec> { [INFO] [stdout] 31 + fn extract_verticals(input: &[Vec<(char, (i32, i32))>]) -> Vec> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `r` is only used to index `input` [INFO] [stdout] --> src/day4/solver.rs:36:18 [INFO] [stdout] | [INFO] [stdout] 36 | for r in 0..input.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 36 - for r in 0..input.len() { [INFO] [stdout] 36 + for in &input { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(char, (i32, i32))` which implements the `Copy` trait [INFO] [stdout] --> src/day4/solver.rs:37:27 [INFO] [stdout] | [INFO] [stdout] 37 | vertical.push(input[r][c].clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `input[r][c]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day4/solver.rs:46:34 [INFO] [stdout] | [INFO] [stdout] 46 | fn extract_diagonals_down(input: &Vec>) -> Vec> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 46 - fn extract_diagonals_down(input: &Vec>) -> Vec> { [INFO] [stdout] 46 + fn extract_diagonals_down(input: &[Vec<(char, (i32, i32))>]) -> Vec> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(char, (i32, i32))` which implements the `Copy` trait [INFO] [stdout] --> src/day4/solver.rs:55:27 [INFO] [stdout] | [INFO] [stdout] 55 | diagonal.push(input[t_r_i][c_i].clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `input[t_r_i][c_i]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(char, (i32, i32))` which implements the `Copy` trait [INFO] [stdout] --> src/day4/solver.rs:70:27 [INFO] [stdout] | [INFO] [stdout] 70 | diagonal.push(input[r_i][t_c_i].clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `input[r_i][t_c_i]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day4/solver.rs:82:32 [INFO] [stdout] | [INFO] [stdout] 82 | fn extract_diagonals_up(input: &Vec>) -> Vec> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 82 - fn extract_diagonals_up(input: &Vec>) -> Vec> { [INFO] [stdout] 82 + fn extract_diagonals_up(input: &[Vec<(char, (i32, i32))>]) -> Vec> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(char, (i32, i32))` which implements the `Copy` trait [INFO] [stdout] --> src/day4/solver.rs:90:27 [INFO] [stdout] | [INFO] [stdout] 90 | diagonal.push(input[t_r_i as usize][c_i].clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `input[t_r_i as usize][c_i]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(char, (i32, i32))` which implements the `Copy` trait [INFO] [stdout] --> src/day4/solver.rs:105:27 [INFO] [stdout] | [INFO] [stdout] 105 | diagonal.push(input[r_i as usize][t_c_i].clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `input[r_i as usize][t_c_i]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/day4/solver.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | char_v.push('.'); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec!['.';SIZE]` [INFO] [stdout] = help: or `char_v.extend(std::iter::repeat_n('.', SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] = note: `#[warn(clippy::same_item_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day4/solver.rs:159:19 [INFO] [stdout] | [INFO] [stdout] 159 | fn count_x_mas(m: &Vec>) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 159 - fn count_x_mas(m: &Vec>) -> i32 { [INFO] [stdout] 159 + fn count_x_mas(m: &[Vec<(char, (i32, i32))>]) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/day4/solver.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | / if m[r][c].0 == 'A' { [INFO] [stdout] 164 | | if check_mas(m[r - 1][c - 1].0, m[r + 1][c + 1].0) [INFO] [stdout] 165 | | && check_mas(m[r + 1][c - 1].0, m[r - 1][c + 1].0) [INFO] [stdout] ... | [INFO] [stdout] 169 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 163 ~ if m[r][c].0 == 'A' [INFO] [stdout] 164 ~ && check_mas(m[r - 1][c - 1].0, m[r + 1][c + 1].0) [INFO] [stdout] 165 | && check_mas(m[r + 1][c - 1].0, m[r - 1][c + 1].0) [INFO] [stdout] 166 | { [INFO] [stdout] 167 | ct += 1; [INFO] [stdout] 168 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `input` [INFO] [stdout] --> src/day4/solver.rs:179:14 [INFO] [stdout] | [INFO] [stdout] 179 | for i in 0..input.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 179 - for i in 0..input.len() { [INFO] [stdout] 179 + for (i, ) in input.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `c` is used to index `input` [INFO] [stdout] --> src/day4/solver.rs:181:18 [INFO] [stdout] | [INFO] [stdout] 181 | for c in 0..input[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 181 - for c in 0..input[i].len() { [INFO] [stdout] 181 + for (c, ) in input.iter().enumerate().take(input[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/day5/solver.rs:4:20 [INFO] [stdout] | [INFO] [stdout] 4 | fn shift_vector(v: &mut Vec, to_i: usize, from_i: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 4 - fn shift_vector(v: &mut Vec, to_i: usize, from_i: usize) { [INFO] [stdout] 4 + fn shift_vector(v: &mut [i32], to_i: usize, from_i: usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `v` [INFO] [stdout] --> src/day5/solver.rs:6:14 [INFO] [stdout] | [INFO] [stdout] 6 | for i in to_i..from_i + 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 6 - for i in to_i..from_i + 1 { [INFO] [stdout] 6 + for in v.iter_mut().take(from_i + 1).skip(to_i) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like you are swapping `v[i]` and `swap` manually [INFO] [stdout] --> src/day5/solver.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 7 | / let t = v[i]; [INFO] [stdout] 8 | | v[i] = swap; [INFO] [stdout] 9 | | [INFO] [stdout] 10 | | swap = t; [INFO] [stdout] | |_________________^ help: try: `std::mem::swap(&mut v[i], &mut swap);` [INFO] [stdout] | [INFO] [stdout] = note: or maybe you should use `std::mem::replace`? [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] = note: `#[warn(clippy::manual_swap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day5/solver.rs:51:24 [INFO] [stdout] | [INFO] [stdout] 51 | if !check_rule(&update_list, rule) { [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `update_list` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day5/solver.rs:140:48 [INFO] [stdout] | [INFO] [stdout] 140 | let (test_rules, test_updates) = load_data(&test_path); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `test_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day5/solver.rs:141:38 [INFO] [stdout] | [INFO] [stdout] 141 | let (rules, updates) = load_data(&input_path); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `input_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `field` [INFO] [stdout] --> src/day6/solver.rs:11:14 [INFO] [stdout] | [INFO] [stdout] 11 | for i in 0..field.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 11 - for i in 0..field.len() { [INFO] [stdout] 11 + for (i, ) in field.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `field` [INFO] [stdout] --> src/day6/solver.rs:12:18 [INFO] [stdout] | [INFO] [stdout] 12 | for j in 0..field[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 12 - for j in 0..field[i].len() { [INFO] [stdout] 12 + for (j, ) in field.iter().enumerate().take(field[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/day6/solver.rs:23:39 [INFO] [stdout] | [INFO] [stdout] 23 | fn move_guard(pos: (i32, i32), field: &mut Vec>) -> (i32, i32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 23 - fn move_guard(pos: (i32, i32), field: &mut Vec>) -> (i32, i32) { [INFO] [stdout] 23 + fn move_guard(pos: (i32, i32), field: &mut [Vec]) -> (i32, i32) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/day6/solver.rs:80:14 [INFO] [stdout] | [INFO] [stdout] 80 | _ => assert!(false), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/day6/solver.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/day7/solver.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | if terms.len() == 0 && num == target { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `terms.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/day7/solver.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 8 | if terms.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `terms.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day8/solver.rs:38:29 [INFO] [stdout] | [INFO] [stdout] 38 | fn compute_antinodes(nodes: &Vec<(char, (i32, i32))>, field_size: (i32, i32), p2: bool) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 38 - fn compute_antinodes(nodes: &Vec<(char, (i32, i32))>, field_size: (i32, i32), p2: bool) -> i32 { [INFO] [stdout] 38 + fn compute_antinodes(nodes: &[(char, (i32, i32))], field_size: (i32, i32), p2: bool) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/day8/solver.rs:67:29 [INFO] [stdout] | [INFO] [stdout] 67 | fn load_data(path: &str) -> (Vec<(char, (i32, i32))>, (i32, i32)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `lines` [INFO] [stdout] --> src/day8/solver.rs:72:14 [INFO] [stdout] | [INFO] [stdout] 72 | for i in 0..lines.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 72 - for i in 0..lines.len() { [INFO] [stdout] 72 + for (i, ) in lines.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `lines` [INFO] [stdout] --> src/day8/solver.rs:73:18 [INFO] [stdout] | [INFO] [stdout] 73 | for j in 0..lines[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 73 - for j in 0..lines[i].len() { [INFO] [stdout] 73 + for (j, ) in lines.iter().enumerate().take(lines[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `data` [INFO] [stdout] --> src/day9/solver.rs:12:14 [INFO] [stdout] | [INFO] [stdout] 12 | for i in 0..data.len() - 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 12 - for i in 0..data.len() - 1 { [INFO] [stdout] 12 + for in data.iter().take(data.len() - 1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&mut Vec` instead of `&mut [_]` involves a new object where a slice will do [INFO] [stdout] --> src/day9/solver.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 32 | fn rearrange(input: &mut Vec) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 - fn rearrange(input: &mut Vec) { [INFO] [stdout] 32 + fn rearrange(input: &mut [String]) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day9/solver.rs:53:27 [INFO] [stdout] | [INFO] [stdout] 53 | fn find_free_space(input: &Vec, len: i32, i: i32) -> i32 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 53 - fn find_free_space(input: &Vec, len: i32, i: i32) -> i32 { [INFO] [stdout] 53 + fn find_free_space(input: &[String], len: i32, i: i32) -> i32 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day9/solver.rs:109:28 [INFO] [stdout] | [INFO] [stdout] 109 | fn compute_checksum(input: &Vec) -> i128 { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 109 - fn compute_checksum(input: &Vec) -> i128 { [INFO] [stdout] 109 + fn compute_checksum(input: &[String]) -> i128 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `input` [INFO] [stdout] --> src/day9/solver.rs:111:14 [INFO] [stdout] | [INFO] [stdout] 111 | for i in 0..input.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 111 - for i in 0..input.len() { [INFO] [stdout] 111 + for (i, ) in input.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day9/solver.rs:123:36 [INFO] [stdout] | [INFO] [stdout] 123 | let mut test_input = load_data(&test_path); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `test_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day9/solver.rs:126:31 [INFO] [stdout] | [INFO] [stdout] 126 | let mut input = load_data(&path); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day9/solver.rs:136:28 [INFO] [stdout] | [INFO] [stdout] 136 | test_input = load_data(&test_path); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `test_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day9/solver.rs:137:23 [INFO] [stdout] | [INFO] [stdout] 137 | input = load_data(&path); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day10/solver.rs:15:37 [INFO] [stdout] | [INFO] [stdout] 15 | fn in_field(pos: (i32, i32), field: &Vec>) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 15 - fn in_field(pos: (i32, i32), field: &Vec>) -> bool { [INFO] [stdout] 15 + fn in_field(pos: (i32, i32), field: &[Vec]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `data` [INFO] [stdout] --> src/day10/solver.rs:75:14 [INFO] [stdout] | [INFO] [stdout] 75 | for i in 0..data.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 75 - for i in 0..data.len() { [INFO] [stdout] 75 + for (i, ) in data.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `data` [INFO] [stdout] --> src/day10/solver.rs:76:18 [INFO] [stdout] | [INFO] [stdout] 76 | for j in 0..data[i].len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 76 - for j in 0..data[i].len() { [INFO] [stdout] 76 + for (j, ) in data.iter().enumerate().take(data[i].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/day11/solver.rs:28:15 [INFO] [stdout] | [INFO] [stdout] 28 | } else if num.to_string().len() % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `num.to_string().len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day11/solver.rs:47:41 [INFO] [stdout] | [INFO] [stdout] 47 | fn blink_n_recursively(n: usize, input: &Vec) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 47 - fn blink_n_recursively(n: usize, input: &Vec) -> usize { [INFO] [stdout] 47 + fn blink_n_recursively(n: usize, input: &[usize]) -> usize { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `input` [INFO] [stdout] --> src/day11/solver.rs:50:14 [INFO] [stdout] | [INFO] [stdout] 50 | for i in 0..input.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 50 - for i in 0..input.len() { [INFO] [stdout] 50 + for in &input { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day11/solver.rs:58:31 [INFO] [stdout] | [INFO] [stdout] 58 | let test_data = load_data(&test_path); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `test_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day11/solver.rs:66:26 [INFO] [stdout] | [INFO] [stdout] 66 | let data = load_data(&path); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day12/solver.rs:14:37 [INFO] [stdout] | [INFO] [stdout] 14 | fn in_field(pos: (i32, i32), field: &Vec>) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 14 - fn in_field(pos: (i32, i32), field: &Vec>) -> bool { [INFO] [stdout] 14 + fn in_field(pos: (i32, i32), field: &[Vec]) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/day12/solver.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | if edges.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `edges.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/day12/solver.rs:129:11 [INFO] [stdout] | [INFO] [stdout] 129 | while queue.len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!queue.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day13/solver.rs:32:27 [INFO] [stdout] | [INFO] [stdout] 32 | fn get_solutions(problem: &Vec<(i64, i64)>, corrected: bool) -> (BigInt, BigInt) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 32 - fn get_solutions(problem: &Vec<(i64, i64)>, corrected: bool) -> (BigInt, BigInt) { [INFO] [stdout] 32 + fn get_solutions(problem: &[(i64, i64)], corrected: bool) -> (BigInt, BigInt) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i128` is unnecessary [INFO] [stdout] --> src/day13/solver.rs:41:28 [INFO] [stdout] | [INFO] [stdout] 41 | x3 += BigInt::from(10000000000000 as i128); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `10000000000000_i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i128` is unnecessary [INFO] [stdout] --> src/day13/solver.rs:42:28 [INFO] [stdout] | [INFO] [stdout] 42 | y3 += BigInt::from(10000000000000 as i128); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `10000000000000_i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day13/solver.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | && (!(&a * problem[0].0 + &b * problem[1].0 == BigInt::from(problem[2].0)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(&a * problem[0].0 + &b * problem[1].0 != BigInt::from(problem[2].0))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day13/solver.rs:65:16 [INFO] [stdout] | [INFO] [stdout] 65 | || !(&a * problem[0].1 + &b * problem[1].1 == BigInt::from(problem[2].1))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(&a * problem[0].1 + &b * problem[1].1 != BigInt::from(problem[2].1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day13/solver.rs:71:13 [INFO] [stdout] | [INFO] [stdout] 71 | && (!(&a * problem[0].0 + &b * problem[1].0 [INFO] [stdout] | _____________^ [INFO] [stdout] 72 | | == BigInt::from(problem[2].0) + BigInt::from(10000000000000 as i128)) [INFO] [stdout] | |_________________________________________________________________________________^ help: try: `(&a * problem[0].0 + &b * problem[1].0 != BigInt::from(problem[2].0) + BigInt::from(10000000000000 as i128))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/day13/solver.rs:73:16 [INFO] [stdout] | [INFO] [stdout] 73 | || !(&a * problem[0].1 + &b * problem[1].1 [INFO] [stdout] | ________________^ [INFO] [stdout] 74 | | == BigInt::from(problem[2].1) + BigInt::from(10000000000000 as i128))) [INFO] [stdout] | |_____________________________________________________________________________________^ help: try: `(&a * problem[0].1 + &b * problem[1].1 != BigInt::from(problem[2].1) + BigInt::from(10000000000000 as i128))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i128` is unnecessary [INFO] [stdout] --> src/day13/solver.rs:72:58 [INFO] [stdout] | [INFO] [stdout] 72 | == BigInt::from(problem[2].0) + BigInt::from(10000000000000 as i128)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `10000000000000_i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i128` is unnecessary [INFO] [stdout] --> src/day13/solver.rs:74:62 [INFO] [stdout] | [INFO] [stdout] 74 | == BigInt::from(problem[2].1) + BigInt::from(10000000000000 as i128))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `10000000000000_i128` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/day13/solver.rs:82:28 [INFO] [stdout] | [INFO] [stdout] 82 | fn compute_costs(problems: &Vec>, corrected: bool) -> BigInt { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 82 - fn compute_costs(problems: &Vec>, corrected: bool) -> BigInt { [INFO] [stdout] 82 + fn compute_costs(problems: &[Vec<(i64, i64)>], corrected: bool) -> BigInt { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/day14/solver.rs:62:5 [INFO] [stdout] | [INFO] [stdout] 62 | return (-1, -1); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 - return (-1, -1); [INFO] [stdout] 62 + (-1, -1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/day14/solver.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | row.push('.'); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec!['.';SIZE]` [INFO] [stdout] = help: or `row.extend(std::iter::repeat_n('.', SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.fold` can be written more succinctly using another method [INFO] [stdout] --> src/day14/solver.rs:105:27 [INFO] [stdout] | [INFO] [stdout] 105 | let p1 = map.values().fold(1, |agg, v| agg * v); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `product::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day14/solver.rs:142:45 [INFO] [stdout] | [INFO] [stdout] 142 | let (test_p1, test_p2) = solve_per_path(&"src/day14/test.txt", test_field_size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `"src/day14/test.txt"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/day14/solver.rs:143:35 [INFO] [stdout] | [INFO] [stdout] 143 | let (p1, p2) = solve_per_path(&"src/day14/input.txt", field_size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `"src/day14/input.txt"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.07s [INFO] running `Command { std: "docker" "inspect" "fd67b449e960ce2f8835b1fcb3ac0e616a377867b50afa7e85b1b64f02f4a9c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fd67b449e960ce2f8835b1fcb3ac0e616a377867b50afa7e85b1b64f02f4a9c5", kill_on_drop: false }` [INFO] [stdout] fd67b449e960ce2f8835b1fcb3ac0e616a377867b50afa7e85b1b64f02f4a9c5