[INFO] cloning repository https://github.com/TJ9867/findit [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TJ9867/findit" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTJ9867%2Ffindit", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTJ9867%2Ffindit'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4b2c1340b18e1c39ca31fa690adfcc77ad42efb2 [INFO] linting TJ9867/findit against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTJ9867%2Ffindit" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/TJ9867/findit [INFO] finished tweaking git repo https://github.com/TJ9867/findit [INFO] tweaked toml for git repo https://github.com/TJ9867/findit written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/TJ9867/findit on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/TJ9867/findit already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded work-queue v0.1.4 [INFO] [stderr] Downloaded memmap2 v0.9.4 [INFO] [stderr] Downloaded generator v0.7.5 [INFO] [stderr] Downloaded async-recursion v1.0.5 [INFO] [stderr] Downloaded type-map v0.5.0 [INFO] [stderr] Downloaded serde v1.0.196 [INFO] [stderr] Downloaded glutin_glx_sys v0.5.0 [INFO] [stderr] Downloaded wayland-cursor v0.31.1 [INFO] [stderr] Downloaded gpu-descriptor v0.3.0 [INFO] [stderr] Downloaded egui-wgpu v0.28.1 [INFO] [stderr] Downloaded enumflags2 v0.7.9 [INFO] [stderr] Downloaded clipboard-win v5.1.0 [INFO] [stderr] Downloaded document-features v0.2.8 [INFO] [stderr] Downloaded webbrowser v1.0.1 [INFO] [stderr] Downloaded zvariant v3.15.0 [INFO] [stderr] Downloaded wayland-client v0.31.2 [INFO] [stderr] Downloaded eframe v0.28.1 [INFO] [stderr] Downloaded png v0.17.12 [INFO] [stderr] Downloaded rayon v1.8.1 [INFO] [stderr] Downloaded zbus v3.15.0 [INFO] [stderr] Downloaded evalexpr v11.3.0 [INFO] [stderr] Downloaded egui-file-dialog v0.6.0 [INFO] [stderr] Downloaded indexmap v2.2.3 [INFO] [stderr] Downloaded x11rb v0.13.0 [INFO] [stderr] Downloaded syn v2.0.49 [INFO] [stderr] Downloaded glutin v0.31.3 [INFO] [stderr] Downloaded sctk-adwaita v0.8.1 [INFO] [stderr] Downloaded wayland-backend v0.3.3 [INFO] [stderr] Downloaded half v2.3.1 [INFO] [stderr] Downloaded egui-winit v0.28.1 [INFO] [stderr] Downloaded polling v3.4.0 [INFO] [stderr] Downloaded wayland-scanner v0.31.1 [INFO] [stderr] Downloaded mime_guess2 v2.0.5 [INFO] [stderr] Downloaded egui_extras v0.28.1 [INFO] [stderr] Downloaded bitstream-io v2.5.3 [INFO] [stderr] Downloaded bumpalo v3.15.0 [INFO] [stderr] Downloaded loom v0.6.1 [INFO] [stderr] Downloaded async-once-cell v0.5.3 [INFO] [stderr] Downloaded x11rb-protocol v0.13.0 [INFO] [stderr] Downloaded winit v0.29.10 [INFO] [stderr] Downloaded atspi-common v0.3.0 [INFO] [stderr] Downloaded atspi-proxies v0.3.0 [INFO] [stderr] Downloaded event-listener v5.0.0 [INFO] [stderr] Downloaded tempfile v3.10.0 [INFO] [stderr] Downloaded accesskit_winit v0.16.1 [INFO] [stderr] Downloaded arboard v3.3.1 [INFO] [stderr] Downloaded egui_glow v0.28.1 [INFO] [stderr] Downloaded accesskit v0.12.2 [INFO] [stderr] Downloaded glutin-winit v0.4.2 [INFO] [stderr] Downloaded atspi-connection v0.3.0 [INFO] [stderr] Downloaded atspi v0.19.0 [INFO] [stderr] Downloaded zbus_macros v3.15.0 [INFO] [stderr] Downloaded zbus_names v2.6.0 [INFO] [stderr] Downloaded accesskit_unix v0.6.2 [INFO] [stderr] Downloaded smithay-clipboard v0.7.0 [INFO] [stderr] Downloaded hermit-abi v0.3.6 [INFO] [stderr] Downloaded wayland-sys v0.31.1 [INFO] [stderr] Downloaded enumn v0.1.13 [INFO] [stderr] Downloaded serde_derive v1.0.196 [INFO] [stderr] Downloaded serde_repr v0.1.18 [INFO] [stderr] Downloaded xdg-home v1.1.0 [INFO] [stderr] Downloaded enumflags2_derive v0.7.9 [INFO] [stderr] Downloaded zvariant_derive v3.15.0 [INFO] [stderr] Downloaded error-code v3.0.0 [INFO] [stderr] Downloaded glutin_egl_sys v0.6.0 [INFO] [stderr] Downloaded smol_str v0.2.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 09a375db0eeb078c4d94d6b19a23f2fbf526e665c4187a57d76f90b11c4c02e6 [INFO] running `Command { std: "docker" "start" "-a" "09a375db0eeb078c4d94d6b19a23f2fbf526e665c4187a57d76f90b11c4c02e6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "09a375db0eeb078c4d94d6b19a23f2fbf526e665c4187a57d76f90b11c4c02e6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "09a375db0eeb078c4d94d6b19a23f2fbf526e665c4187a57d76f90b11c4c02e6", kill_on_drop: false }` [INFO] [stdout] 09a375db0eeb078c4d94d6b19a23f2fbf526e665c4187a57d76f90b11c4c02e6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ad93d5f1408270158a310a4a7ff63256d4fc1c984901279554ca7ba6b07daa53 [INFO] running `Command { std: "docker" "start" "-a" "ad93d5f1408270158a310a4a7ff63256d4fc1c984901279554ca7ba6b07daa53", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Checking libloading v0.8.1 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Compiling syn v2.0.49 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling wayland-sys v0.31.1 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling quick-xml v0.31.0 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling toml_datetime v0.6.5 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Checking event-listener v4.0.3 [INFO] [stderr] Compiling indexmap v2.2.3 [INFO] [stderr] Checking event-listener-strategy v0.4.0 [INFO] [stderr] Checking event-listener v5.0.0 [INFO] [stderr] Compiling wayland-scanner v0.31.1 [INFO] [stderr] Checking ttf-parser v0.20.0 [INFO] [stderr] Compiling wayland-backend v0.3.3 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Checking event-listener-strategy v0.5.0 [INFO] [stderr] Checking async-lock v3.3.0 [INFO] [stderr] Checking futures-lite v2.2.0 [INFO] [stderr] Compiling aho-corasick v1.1.2 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.8 [INFO] [stderr] Checking waker-fn v1.1.1 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Checking async-task v4.7.0 [INFO] [stderr] Checking owned_ttf_parser v0.20.0 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking piper v0.2.1 [INFO] [stderr] Checking ab_glyph v0.2.23 [INFO] [stderr] Checking async-channel v2.2.0 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Compiling zvariant_utils v1.0.1 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling async-fs v1.6.0 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling regex-automata v0.4.5 [INFO] [stderr] Checking wayland-client v0.31.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Compiling bytemuck_derive v1.5.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling enumflags2_derive v0.7.9 [INFO] [stderr] Compiling zvariant_derive v3.15.0 [INFO] [stderr] Checking bytemuck v1.14.3 [INFO] [stderr] Checking wayland-protocols v0.31.2 [INFO] [stderr] Compiling enumn v0.1.13 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking blocking v1.5.1 [INFO] [stderr] Checking polling v3.4.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Compiling xml-rs v0.8.19 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking calloop v0.12.4 [INFO] [stderr] Compiling regex v1.10.3 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling async-recursion v1.0.5 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Compiling serde_repr v0.1.18 [INFO] [stderr] Compiling zbus_macros v3.15.0 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking async-executor v1.8.0 [INFO] [stderr] Checking async-broadcast v0.5.1 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Checking xdg-home v1.1.0 [INFO] [stderr] Checking xkeysym v0.2.0 [INFO] [stderr] Compiling smithay-client-toolkit v0.18.1 [INFO] [stderr] Checking cursor-icon v1.1.0 [INFO] [stderr] Checking xcursor v0.3.5 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking wayland-cursor v0.31.1 [INFO] [stderr] Checking calloop-wayland-source v0.2.0 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking wayland-protocols-wlr v0.2.0 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking x11rb-protocol v0.13.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling winit v0.29.10 [INFO] [stderr] Checking enumflags2 v0.7.9 [INFO] [stderr] Checking zvariant v3.15.0 [INFO] [stderr] Checking accesskit v0.12.2 [INFO] [stderr] Checking emath v0.28.1 [INFO] [stderr] Checking ecolor v0.28.1 [INFO] [stderr] Checking aligned-vec v0.5.0 [INFO] [stderr] Compiling built v0.7.4 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Checking epaint v0.28.1 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Compiling rav1e v0.7.1 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking v_frame v0.3.8 [INFO] [stderr] Checking zbus_names v2.6.0 [INFO] [stderr] Checking sctk-adwaita v0.8.1 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking rayon v1.8.1 [INFO] [stderr] Checking xkbcommon-dl v0.4.2 [INFO] [stderr] Checking wayland-protocols-plasma v0.2.0 [INFO] [stderr] Checking zbus v3.15.0 [INFO] [stderr] Compiling glutin_glx_sys v0.5.0 [INFO] [stderr] Compiling glutin_egl_sys v0.6.0 [INFO] [stderr] Compiling profiling-procmacros v1.0.15 [INFO] [stderr] Checking raw-window-handle v0.6.0 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking smol_str v0.2.1 [INFO] [stderr] Checking av1-grain v0.2.3 [INFO] [stderr] Checking profiling v1.0.15 [INFO] [stderr] Checking egui v0.28.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking accesskit_consumer v0.16.1 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Compiling glutin v0.31.3 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Compiling noop_proc_macro v0.3.0 [INFO] [stderr] Checking imgref v1.10.1 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking async-once-cell v0.5.3 [INFO] [stderr] Checking bitstream-io v2.5.3 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Compiling mime_guess2 v2.0.5 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking rgb v0.8.37 [INFO] [stderr] Checking avif-serialize v0.8.1 [INFO] [stderr] Compiling glutin-winit v0.4.2 [INFO] [stderr] Checking half v2.3.1 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Checking zune-jpeg v0.4.13 [INFO] [stderr] Checking gif v0.13.1 [INFO] [stderr] Checking exr v1.72.0 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking webbrowser v1.0.1 [INFO] [stderr] Checking image-webp v0.1.3 [INFO] [stderr] Checking png v0.17.12 [INFO] [stderr] Checking atspi-common v0.3.0 [INFO] [stderr] Checking smithay-clipboard v0.7.0 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Compiling enum-map-derive v0.17.0 [INFO] [stderr] Compiling litrs v0.4.1 [INFO] [stderr] Checking glow v0.13.1 [INFO] [stderr] Checking web-time v0.2.4 [INFO] [stderr] Compiling document-features v0.2.8 [INFO] [stderr] Checking enum-map v2.7.3 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking sysinfo v0.30.13 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking egui_glow v0.28.1 [INFO] [stderr] Checking egui_extras v0.28.1 [INFO] [stderr] Checking work-queue v0.1.4 [INFO] [stderr] Checking egui-file-dialog v0.6.0 [INFO] [stderr] Checking evalexpr v11.3.0 [INFO] [stderr] Checking json v0.12.4 [INFO] [stderr] Checking atspi-proxies v0.3.0 [INFO] [stderr] Checking x11rb v0.13.0 [INFO] [stderr] Checking ravif v0.11.5 [INFO] [stderr] Checking image v0.25.2 [INFO] [stderr] Checking atspi-connection v0.3.0 [INFO] [stderr] Checking atspi v0.19.0 [INFO] [stderr] Checking accesskit_unix v0.6.2 [INFO] [stderr] Checking arboard v3.3.1 [INFO] [stderr] Checking accesskit_winit v0.16.1 [INFO] [stderr] Checking egui-winit v0.28.1 [INFO] [stderr] Checking eframe v0.28.1 [INFO] [stderr] Checking quer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | use json; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:16:1 [INFO] [stdout] | [INFO] [stdout] 16 | use json; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/main.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | struct Task(Box) + Send>); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:206:23 [INFO] [stdout] | [INFO] [stdout] 206 | progress: self.progress.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.progress` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:207:24 [INFO] [stdout] | [INFO] [stdout] 207 | max_files: self.max_files.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.max_files` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:209:23 [INFO] [stdout] | [INFO] [stdout] 209 | max_hits: self.max_hits.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.max_hits` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:211:24 [INFO] [stdout] | [INFO] [stdout] 211 | alignment: self.alignment.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.alignment` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:233:31 [INFO] [stdout] | [INFO] [stdout] 233 | configure_text_styles(&cc); [INFO] [stdout] | ^^^ help: change this to: `cc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:269:62 [INFO] [stdout] | [INFO] [stdout] 269 | let viewport_id = egui::ViewportId::from_hash_of(format!("file_dialog")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"file_dialog".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:273:29 [INFO] [stdout] | [INFO] [stdout] 273 | .with_title(format!("Export File To")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Export File To".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:355:66 [INFO] [stdout] | [INFO] [stdout] 355 | let viewport_id = egui::ViewportId::from_hash_of(format!("folder_dialog")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"folder_dialog".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:359:33 [INFO] [stdout] | [INFO] [stdout] 359 | .with_title(format!("Open Folder to Search")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Open Folder to Search".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/main.rs:441:44 [INFO] [stdout] | [INFO] [stdout] 441 | if self.regex_str.len() == 0 as usize { [INFO] [stdout] | ^^^^^^^^^^ help: try: `0_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:566:26 [INFO] [stdout] | [INFO] [stdout] 566 | if ui.button(format!("Sort ascending")).clicked() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Sort ascending".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:571:26 [INFO] [stdout] | [INFO] [stdout] 571 | if ui.button(format!("Sort descending")).clicked() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Sort descending".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:576:26 [INFO] [stdout] | [INFO] [stdout] 576 | if ui.button(format!("Cancel")).clicked() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Cancel".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:593:26 [INFO] [stdout] | [INFO] [stdout] 593 | if ui.button(format!("Copy full path")).clicked() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Copy full path".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:597:26 [INFO] [stdout] | [INFO] [stdout] 597 | if ui.button(format!("Copy filename")).clicked() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Copy filename".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:601:26 [INFO] [stdout] | [INFO] [stdout] 601 | if ui.button(format!("Copy enclosing dir")).clicked() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Copy enclosing dir".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:606:26 [INFO] [stdout] | [INFO] [stdout] 606 | if ui.button(format!("Sort ascending")).clicked() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Sort ascending".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:610:26 [INFO] [stdout] | [INFO] [stdout] 610 | if ui.button(format!("Sort descending")).clicked() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Sort descending".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:616:25 [INFO] [stdout] | [INFO] [stdout] 616 | .button(format!("Export File results to .imhexbm...")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Export File results to .imhexbm...".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:641:36 [INFO] [stdout] | [INFO] [stdout] 641 | resp.clone().on_hover_text(format!("{path_value}")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `path_value.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:672:26 [INFO] [stdout] | [INFO] [stdout] 672 | if ui.button(format!("Sort ascending")).clicked() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Sort ascending".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:673:17 [INFO] [stdout] | [INFO] [stdout] 673 | self.findings.sort_by(|a, b| a.offset.cmp(&b.offset)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 673 - self.findings.sort_by(|a, b| a.offset.cmp(&b.offset)); [INFO] [stdout] 673 + self.findings.sort_by_key(|a| a.offset); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:676:26 [INFO] [stdout] | [INFO] [stdout] 676 | if ui.button(format!("Sort descending")).clicked() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Sort descending".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:677:17 [INFO] [stdout] | [INFO] [stdout] 677 | self.findings.sort_by(|a, b| b.offset.cmp(&a.offset)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 677 - self.findings.sort_by(|a, b| b.offset.cmp(&a.offset)); [INFO] [stdout] 677 + self.findings.sort_by_key(|b| std::cmp::Reverse(b.offset)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:709:9 [INFO] [stdout] | [INFO] [stdout] 709 | return hexdump; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 709 - return hexdump; [INFO] [stdout] 709 + hexdump [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:718:9 [INFO] [stdout] | [INFO] [stdout] 718 | return hexdump; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 718 - return hexdump; [INFO] [stdout] 718 + hexdump [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i64` is unnecessary [INFO] [stdout] --> src/main.rs:739:51 [INFO] [stdout] | [INFO] [stdout] 739 | let offset = std::cmp::max::(0 as i64, offset as i64 - 32) as usize; [INFO] [stdout] | ^^^^^^^^ help: try: `0_i64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i64` is unnecessary [INFO] [stdout] --> src/main.rs:751:47 [INFO] [stdout] | [INFO] [stdout] 751 | let offset = std::cmp::max::(0 as i64, offset as i64 - 32) as usize; [INFO] [stdout] | ^^^^^^^^ help: try: `0_i64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:820:54 [INFO] [stdout] | [INFO] [stdout] 820 | let label = egui::Label::new(format!("{path}")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `path.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:826:58 [INFO] [stdout] | [INFO] [stdout] 826 | self.respond_to_filepath_cell(&resp, &path, ctx); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:840:54 [INFO] [stdout] | [INFO] [stdout] 840 | let label = egui::Label::new(format!("{match_content}")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `match_content.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:849:25 [INFO] [stdout] | [INFO] [stdout] 849 | &path, [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:852:26 [INFO] [stdout] | [INFO] [stdout] 852 | &format!("{match_content}"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `match_content.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:857:54 [INFO] [stdout] | [INFO] [stdout] 857 | let label = egui::Label::new(format!("🔍")).truncate().selectable(false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"🔍".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:861:56 [INFO] [stdout] | [INFO] [stdout] 861 | self.response_to_hex_preview(resp, &path, offset, match_size, ctx); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:872:24 [INFO] [stdout] | [INFO] [stdout] 872 | if self.previous_searches.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.previous_searches.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:954:16 [INFO] [stdout] | [INFO] [stdout] 954 | if self.findings.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.findings.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:972:12 [INFO] [stdout] | [INFO] [stdout] 972 | if self.findings.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.findings.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:984:23 [INFO] [stdout] | [INFO] [stdout] 984 | } else if self.worker_threads.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.worker_threads.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/main.rs:1090:17 [INFO] [stdout] | [INFO] [stdout] 1090 | if let Some(ent) = entry.as_ref().ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] = note: `#[warn(clippy::match_result_ok)]` on by default [INFO] [stdout] help: consider matching on `Ok(ent)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 1090 - if let Some(ent) = entry.as_ref().ok() { [INFO] [stdout] 1090 + if let Ok(ent) = entry.as_ref() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:1108:19 [INFO] [stdout] | [INFO] [stdout] 1108 | findings: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1108 - findings: &Vec, [INFO] [stdout] 1108 + findings: &[Finding], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:1279:12 [INFO] [stdout] | [INFO] [stdout] 1279 | if !file_data.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `file_data.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:1309:17 [INFO] [stdout] | [INFO] [stdout] 1309 | return; // don't continue if there's a problem with regex [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1308 - Err(_err_msg) => { [INFO] [stdout] 1309 - return; // don't continue if there's a problem with regex [INFO] [stdout] 1308 + Err(_err_msg) => {// don't continue if there's a problem with regex [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:1289:63 [INFO] [stdout] | [INFO] [stdout] 1289 | process_binary_match(&search_opts, m, &entry, &tx); [INFO] [stdout] | ^^^^^^ help: change this to: `entry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:1289:71 [INFO] [stdout] | [INFO] [stdout] 1289 | process_binary_match(&search_opts, m, &entry, &tx); [INFO] [stdout] | ^^^ help: change this to: `tx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:1298:61 [INFO] [stdout] | [INFO] [stdout] 1298 | process_text_match(&search_opts, m, &entry, &tx); [INFO] [stdout] | ^^^^^^ help: change this to: `entry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:1298:69 [INFO] [stdout] | [INFO] [stdout] 1298 | process_text_match(&search_opts, m, &entry, &tx); [INFO] [stdout] | ^^^ help: change this to: `tx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:1361:5 [INFO] [stdout] | [INFO] [stdout] 1361 | / return wlkdir [INFO] [stdout] 1362 | | .into_iter() [INFO] [stdout] 1363 | | .filter_entry(move |e| match options.hidden_files { [INFO] [stdout] 1364 | | FilterTypeEnum::NoHidden => { [INFO] [stdout] ... | [INFO] [stdout] 1370 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1361 ~ wlkdir [INFO] [stdout] 1362 + .into_iter() [INFO] [stdout] 1363 + .filter_entry(move |e| match options.hidden_files { [INFO] [stdout] 1364 + FilterTypeEnum::NoHidden => { [INFO] [stdout] 1365 + return !is_hidden(e); [INFO] [stdout] 1366 + } [INFO] [stdout] 1367 + FilterTypeEnum::AllFiles => { [INFO] [stdout] 1368 + return true; [INFO] [stdout] 1369 + } [INFO] [stdout] 1370 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:1365:17 [INFO] [stdout] | [INFO] [stdout] 1365 | return !is_hidden(e); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1365 - return !is_hidden(e); [INFO] [stdout] 1365 + !is_hidden(e) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:1368:17 [INFO] [stdout] | [INFO] [stdout] 1368 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1368 - return true; [INFO] [stdout] 1368 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:1373:44 [INFO] [stdout] | [INFO] [stdout] 1373 | fn convert_simplified_hex_regex(regex_str: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1373 - fn convert_simplified_hex_regex(regex_str: &String) -> Result { [INFO] [stdout] 1373 + fn convert_simplified_hex_regex(regex_str: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/main.rs:1376:12 [INFO] [stdout] | [INFO] [stdout] 1376 | if let Some(_) = invalid_char_re.find(&no_spaces) { [INFO] [stdout] | -------^^^^^^^----------------------------------- help: try: `if invalid_char_re.find(&no_spaces).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/main.rs:32:13 [INFO] [stdout] | [INFO] [stdout] 32 | struct Task(Box) + Send>); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:206:23 [INFO] [stdout] | [INFO] [stdout] 206 | progress: self.progress.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.progress` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:207:24 [INFO] [stdout] | [INFO] [stdout] 207 | max_files: self.max_files.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.max_files` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:209:23 [INFO] [stdout] | [INFO] [stdout] 209 | max_hits: self.max_hits.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.max_hits` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i32` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:211:24 [INFO] [stdout] | [INFO] [stdout] 211 | alignment: self.alignment.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.alignment` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:233:31 [INFO] [stdout] | [INFO] [stdout] 233 | configure_text_styles(&cc); [INFO] [stdout] | ^^^ help: change this to: `cc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:269:62 [INFO] [stdout] | [INFO] [stdout] 269 | let viewport_id = egui::ViewportId::from_hash_of(format!("file_dialog")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"file_dialog".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:273:29 [INFO] [stdout] | [INFO] [stdout] 273 | .with_title(format!("Export File To")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Export File To".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:355:66 [INFO] [stdout] | [INFO] [stdout] 355 | let viewport_id = egui::ViewportId::from_hash_of(format!("folder_dialog")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"folder_dialog".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:359:33 [INFO] [stdout] | [INFO] [stdout] 359 | .with_title(format!("Open Folder to Search")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Open Folder to Search".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/main.rs:441:44 [INFO] [stdout] | [INFO] [stdout] 441 | if self.regex_str.len() == 0 as usize { [INFO] [stdout] | ^^^^^^^^^^ help: try: `0_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:566:26 [INFO] [stdout] | [INFO] [stdout] 566 | if ui.button(format!("Sort ascending")).clicked() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Sort ascending".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:571:26 [INFO] [stdout] | [INFO] [stdout] 571 | if ui.button(format!("Sort descending")).clicked() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Sort descending".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:576:26 [INFO] [stdout] | [INFO] [stdout] 576 | if ui.button(format!("Cancel")).clicked() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Cancel".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:593:26 [INFO] [stdout] | [INFO] [stdout] 593 | if ui.button(format!("Copy full path")).clicked() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Copy full path".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:597:26 [INFO] [stdout] | [INFO] [stdout] 597 | if ui.button(format!("Copy filename")).clicked() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Copy filename".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:601:26 [INFO] [stdout] | [INFO] [stdout] 601 | if ui.button(format!("Copy enclosing dir")).clicked() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Copy enclosing dir".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:606:26 [INFO] [stdout] | [INFO] [stdout] 606 | if ui.button(format!("Sort ascending")).clicked() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Sort ascending".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:610:26 [INFO] [stdout] | [INFO] [stdout] 610 | if ui.button(format!("Sort descending")).clicked() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Sort descending".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:616:25 [INFO] [stdout] | [INFO] [stdout] 616 | .button(format!("Export File results to .imhexbm...")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Export File results to .imhexbm...".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:641:36 [INFO] [stdout] | [INFO] [stdout] 641 | resp.clone().on_hover_text(format!("{path_value}")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `path_value.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:672:26 [INFO] [stdout] | [INFO] [stdout] 672 | if ui.button(format!("Sort ascending")).clicked() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Sort ascending".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:673:17 [INFO] [stdout] | [INFO] [stdout] 673 | self.findings.sort_by(|a, b| a.offset.cmp(&b.offset)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 673 - self.findings.sort_by(|a, b| a.offset.cmp(&b.offset)); [INFO] [stdout] 673 + self.findings.sort_by_key(|a| a.offset); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:676:26 [INFO] [stdout] | [INFO] [stdout] 676 | if ui.button(format!("Sort descending")).clicked() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Sort descending".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/main.rs:677:17 [INFO] [stdout] | [INFO] [stdout] 677 | self.findings.sort_by(|a, b| b.offset.cmp(&a.offset)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 677 - self.findings.sort_by(|a, b| b.offset.cmp(&a.offset)); [INFO] [stdout] 677 + self.findings.sort_by_key(|b| std::cmp::Reverse(b.offset)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:709:9 [INFO] [stdout] | [INFO] [stdout] 709 | return hexdump; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 709 - return hexdump; [INFO] [stdout] 709 + hexdump [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:718:9 [INFO] [stdout] | [INFO] [stdout] 718 | return hexdump; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 718 - return hexdump; [INFO] [stdout] 718 + hexdump [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i64` is unnecessary [INFO] [stdout] --> src/main.rs:739:51 [INFO] [stdout] | [INFO] [stdout] 739 | let offset = std::cmp::max::(0 as i64, offset as i64 - 32) as usize; [INFO] [stdout] | ^^^^^^^^ help: try: `0_i64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i64` is unnecessary [INFO] [stdout] --> src/main.rs:751:47 [INFO] [stdout] | [INFO] [stdout] 751 | let offset = std::cmp::max::(0 as i64, offset as i64 - 32) as usize; [INFO] [stdout] | ^^^^^^^^ help: try: `0_i64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:820:54 [INFO] [stdout] | [INFO] [stdout] 820 | let label = egui::Label::new(format!("{path}")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `path.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:826:58 [INFO] [stdout] | [INFO] [stdout] 826 | self.respond_to_filepath_cell(&resp, &path, ctx); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:840:54 [INFO] [stdout] | [INFO] [stdout] 840 | let label = egui::Label::new(format!("{match_content}")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `match_content.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:849:25 [INFO] [stdout] | [INFO] [stdout] 849 | &path, [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:852:26 [INFO] [stdout] | [INFO] [stdout] 852 | &format!("{match_content}"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `match_content.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:857:54 [INFO] [stdout] | [INFO] [stdout] 857 | let label = egui::Label::new(format!("🔍")).truncate().selectable(false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"🔍".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:861:56 [INFO] [stdout] | [INFO] [stdout] 861 | self.response_to_hex_preview(resp, &path, offset, match_size, ctx); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:872:24 [INFO] [stdout] | [INFO] [stdout] 872 | if self.previous_searches.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.previous_searches.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:954:16 [INFO] [stdout] | [INFO] [stdout] 954 | if self.findings.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.findings.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:972:12 [INFO] [stdout] | [INFO] [stdout] 972 | if self.findings.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.findings.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:984:23 [INFO] [stdout] | [INFO] [stdout] 984 | } else if self.worker_threads.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.worker_threads.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/main.rs:1090:17 [INFO] [stdout] | [INFO] [stdout] 1090 | if let Some(ent) = entry.as_ref().ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] = note: `#[warn(clippy::match_result_ok)]` on by default [INFO] [stdout] help: consider matching on `Ok(ent)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 1090 - if let Some(ent) = entry.as_ref().ok() { [INFO] [stdout] 1090 + if let Ok(ent) = entry.as_ref() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:1108:19 [INFO] [stdout] | [INFO] [stdout] 1108 | findings: &Vec, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1108 - findings: &Vec, [INFO] [stdout] 1108 + findings: &[Finding], [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:1279:12 [INFO] [stdout] | [INFO] [stdout] 1279 | if !file_data.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `file_data.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:1309:17 [INFO] [stdout] | [INFO] [stdout] 1309 | return; // don't continue if there's a problem with regex [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1308 - Err(_err_msg) => { [INFO] [stdout] 1309 - return; // don't continue if there's a problem with regex [INFO] [stdout] 1308 + Err(_err_msg) => {// don't continue if there's a problem with regex [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:1289:63 [INFO] [stdout] | [INFO] [stdout] 1289 | process_binary_match(&search_opts, m, &entry, &tx); [INFO] [stdout] | ^^^^^^ help: change this to: `entry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:1289:71 [INFO] [stdout] | [INFO] [stdout] 1289 | process_binary_match(&search_opts, m, &entry, &tx); [INFO] [stdout] | ^^^ help: change this to: `tx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:1298:61 [INFO] [stdout] | [INFO] [stdout] 1298 | process_text_match(&search_opts, m, &entry, &tx); [INFO] [stdout] | ^^^^^^ help: change this to: `entry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:1298:69 [INFO] [stdout] | [INFO] [stdout] 1298 | process_text_match(&search_opts, m, &entry, &tx); [INFO] [stdout] | ^^^ help: change this to: `tx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:1361:5 [INFO] [stdout] | [INFO] [stdout] 1361 | / return wlkdir [INFO] [stdout] 1362 | | .into_iter() [INFO] [stdout] 1363 | | .filter_entry(move |e| match options.hidden_files { [INFO] [stdout] 1364 | | FilterTypeEnum::NoHidden => { [INFO] [stdout] ... | [INFO] [stdout] 1370 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1361 ~ wlkdir [INFO] [stdout] 1362 + .into_iter() [INFO] [stdout] 1363 + .filter_entry(move |e| match options.hidden_files { [INFO] [stdout] 1364 + FilterTypeEnum::NoHidden => { [INFO] [stdout] 1365 + return !is_hidden(e); [INFO] [stdout] 1366 + } [INFO] [stdout] 1367 + FilterTypeEnum::AllFiles => { [INFO] [stdout] 1368 + return true; [INFO] [stdout] 1369 + } [INFO] [stdout] 1370 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:1365:17 [INFO] [stdout] | [INFO] [stdout] 1365 | return !is_hidden(e); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1365 - return !is_hidden(e); [INFO] [stdout] 1365 + !is_hidden(e) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:1368:17 [INFO] [stdout] | [INFO] [stdout] 1368 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1368 - return true; [INFO] [stdout] 1368 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:1373:44 [INFO] [stdout] | [INFO] [stdout] 1373 | fn convert_simplified_hex_regex(regex_str: &String) -> Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1373 - fn convert_simplified_hex_regex(regex_str: &String) -> Result { [INFO] [stdout] 1373 + fn convert_simplified_hex_regex(regex_str: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> src/main.rs:1376:12 [INFO] [stdout] | [INFO] [stdout] 1376 | if let Some(_) = invalid_char_re.find(&no_spaces) { [INFO] [stdout] | -------^^^^^^^----------------------------------- help: try: `if invalid_char_re.find(&no_spaces).is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 56s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: document-features v0.2.8 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "ad93d5f1408270158a310a4a7ff63256d4fc1c984901279554ca7ba6b07daa53", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad93d5f1408270158a310a4a7ff63256d4fc1c984901279554ca7ba6b07daa53", kill_on_drop: false }` [INFO] [stdout] ad93d5f1408270158a310a4a7ff63256d4fc1c984901279554ca7ba6b07daa53