[INFO] cloning repository https://github.com/TDL28/sqlite-reader-rust
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TDL28/sqlite-reader-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTDL28%2Fsqlite-reader-rust", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTDL28%2Fsqlite-reader-rust'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 8a783897d6b94d575ed23d3c8e4c76274367b4bc
[INFO] linting TDL28/sqlite-reader-rust against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTDL28%2Fsqlite-reader-rust" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/TDL28/sqlite-reader-rust
[INFO] finished tweaking git repo https://github.com/TDL28/sqlite-reader-rust
[INFO] tweaked toml for git repo https://github.com/TDL28/sqlite-reader-rust written to /workspace/builds/worker-3-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/TDL28/sqlite-reader-rust on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/TDL28/sqlite-reader-rust already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded sqlite3-sys v0.18.0
[INFO] [stderr]   Downloaded sqlite v0.37.0
[INFO] [stderr]   Downloaded argparse v0.2.2
[INFO] [stderr]   Downloaded cc v1.2.20
[INFO] [stderr]   Downloaded sqlite3-src v0.7.0
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 26a0c1ed019b0f04ccae0f52132303dcf37721c8fe46b443af58971d95446ece
[INFO] running `Command { std: "docker" "start" "-a" "26a0c1ed019b0f04ccae0f52132303dcf37721c8fe46b443af58971d95446ece", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "26a0c1ed019b0f04ccae0f52132303dcf37721c8fe46b443af58971d95446ece", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "26a0c1ed019b0f04ccae0f52132303dcf37721c8fe46b443af58971d95446ece", kill_on_drop: false }`
[INFO] [stdout] 26a0c1ed019b0f04ccae0f52132303dcf37721c8fe46b443af58971d95446ece
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 1c37f4166de69c44217e676b0bc99832251fbdbe5b968b13c6bdd6c5ea8791ca
[INFO] running `Command { std: "docker" "start" "-a" "1c37f4166de69c44217e676b0bc99832251fbdbe5b968b13c6bdd6c5ea8791ca", kill_on_drop: false }`
[INFO] [stderr]    Compiling shlex v1.3.0
[INFO] [stderr]    Compiling pkg-config v0.3.32
[INFO] [stderr]     Checking argparse v0.2.2
[INFO] [stderr]    Compiling cc v1.2.20
[INFO] [stderr]    Compiling sqlite3-src v0.7.0
[INFO] [stderr]     Checking sqlite3-sys v0.18.0
[INFO] [stderr]     Checking sqlite v0.37.0
[INFO] [stderr]     Checking reader v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/main.rs:1:1
[INFO] [stdout]   |
[INFO] [stdout] 1 | use sqlite;
[INFO] [stdout]   | ^^^^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout]   = note: `#[warn(clippy::single_component_path_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this import is redundant
[INFO] [stdout]  --> src/main.rs:1:1
[INFO] [stdout]   |
[INFO] [stdout] 1 | use sqlite;
[INFO] [stdout]   | ^^^^^^^^^^^ help: remove it entirely
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
[INFO] [stdout]   = note: `#[warn(clippy::single_component_path_imports)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:62:12
[INFO] [stdout]    |
[INFO] [stdout] 62 |         if !table.is_none() {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^ help: try: `table.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `table` after checking its variant with `is_none`
[INFO] [stdout]   --> src/main.rs:64:41
[INFO] [stdout]    |
[INFO] [stdout] 62 |         if !table.is_none() {
[INFO] [stdout]    |             --------------- the check is happening here
[INFO] [stdout] 63 |             let columns = get_columns(&db, &table.clone().unwrap());
[INFO] [stdout] 64 |             println!("Columns in '{}'", table.unwrap());
[INFO] [stdout]    |                                         ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `if let` or `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/main.rs:128:36
[INFO] [stdout]     |
[INFO] [stdout] 128 |     let mut statement = db.prepare(&format!("PRAGMA table_info({})", table_name)).unwrap();
[INFO] [stdout]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("PRAGMA table_info({})", table_name)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/main.rs:136:77
[INFO] [stdout]     |
[INFO] [stdout] 136 | fn get_table_content(db: &sqlite::Connection, table_name: &String, columns: &Vec<String>) -> Vec<Vec<String>> {
[INFO] [stdout]     |                                                                             ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 136 ~ fn get_table_content(db: &sqlite::Connection, table_name: &String, columns: &[String]) -> Vec<Vec<String>> {
[INFO] [stdout] 137 |     let mut rows = Vec::new();
[INFO] [stdout] ...
[INFO] [stdout] 142 |     } else {
[INFO] [stdout] 143 ~         columns.to_owned()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for cloning elements
[INFO] [stdout]    --> src/main.rs:146:15
[INFO] [stdout]     |
[INFO] [stdout] 146 |     rows.push(columns.iter().map(|c| c.clone()).collect::<Vec<String>>()); // Add header row
[INFO] [stdout]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `columns.iter().cloned()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout]     = note: `#[warn(clippy::map_clone)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/main.rs:149:36
[INFO] [stdout]     |
[INFO] [stdout] 149 |     let mut statement = db.prepare(&format!("SELECT {} FROM {}", column_names, table_name)).unwrap();
[INFO] [stdout]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("SELECT {} FROM {}", column_names, table_name)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:62:12
[INFO] [stdout]    |
[INFO] [stdout] 62 |         if !table.is_none() {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^ help: try: `table.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `unwrap` on `table` after checking its variant with `is_none`
[INFO] [stdout]   --> src/main.rs:64:41
[INFO] [stdout]    |
[INFO] [stdout] 62 |         if !table.is_none() {
[INFO] [stdout]    |             --------------- the check is happening here
[INFO] [stdout] 63 |             let columns = get_columns(&db, &table.clone().unwrap());
[INFO] [stdout] 64 |             println!("Columns in '{}'", table.unwrap());
[INFO] [stdout]    |                                         ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: try using `if let` or `match`
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap
[INFO] [stdout]    = note: `#[warn(clippy::unnecessary_unwrap)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/main.rs:128:36
[INFO] [stdout]     |
[INFO] [stdout] 128 |     let mut statement = db.prepare(&format!("PRAGMA table_info({})", table_name)).unwrap();
[INFO] [stdout]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("PRAGMA table_info({})", table_name)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/main.rs:136:77
[INFO] [stdout]     |
[INFO] [stdout] 136 | fn get_table_content(db: &sqlite::Connection, table_name: &String, columns: &Vec<String>) -> Vec<Vec<String>> {
[INFO] [stdout]     |                                                                             ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]     = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 136 ~ fn get_table_content(db: &sqlite::Connection, table_name: &String, columns: &[String]) -> Vec<Vec<String>> {
[INFO] [stdout] 137 |     let mut rows = Vec::new();
[INFO] [stdout] ...
[INFO] [stdout] 142 |     } else {
[INFO] [stdout] 143 ~         columns.to_owned()
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for cloning elements
[INFO] [stdout]    --> src/main.rs:146:15
[INFO] [stdout]     |
[INFO] [stdout] 146 |     rows.push(columns.iter().map(|c| c.clone()).collect::<Vec<String>>()); // Add header row
[INFO] [stdout]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `columns.iter().cloned()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout]     = note: `#[warn(clippy::map_clone)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/main.rs:149:36
[INFO] [stdout]     |
[INFO] [stdout] 149 |     let mut statement = db.prepare(&format!("SELECT {} FROM {}", column_names, table_name)).unwrap();
[INFO] [stdout]     |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("SELECT {} FROM {}", column_names, table_name)`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.29s
[INFO] running `Command { std: "docker" "inspect" "1c37f4166de69c44217e676b0bc99832251fbdbe5b968b13c6bdd6c5ea8791ca", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "1c37f4166de69c44217e676b0bc99832251fbdbe5b968b13c6bdd6c5ea8791ca", kill_on_drop: false }`
[INFO] [stdout] 1c37f4166de69c44217e676b0bc99832251fbdbe5b968b13c6bdd6c5ea8791ca