[INFO] cloning repository https://github.com/Sympatron/embedded-storage-sim [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Sympatron/embedded-storage-sim" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSympatron%2Fembedded-storage-sim", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSympatron%2Fembedded-storage-sim'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e9598b1923f3fb4d6bc999afa480d157240b71be [INFO] linting Sympatron/embedded-storage-sim against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSympatron%2Fembedded-storage-sim" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Sympatron/embedded-storage-sim [INFO] finished tweaking git repo https://github.com/Sympatron/embedded-storage-sim [INFO] tweaked toml for git repo https://github.com/Sympatron/embedded-storage-sim written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Sympatron/embedded-storage-sim on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Sympatron/embedded-storage-sim already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating git repository `https://github.com/a-littlebit/egui_alignments.git` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://github.com/tweedegolf/sequential-storage.git` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded egui_tiles v0.14.0 [INFO] [stderr] Downloaded fugit v0.3.9 [INFO] [stderr] Downloaded egui_plot v0.34.0 [INFO] [stderr] Downloaded toml_edit v0.23.9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2a7d50943b680b7c56c59d2d9c462ac23e4a8315978d3cc2c33139351c4bc6c9 [INFO] running `Command { std: "docker" "start" "-a" "2a7d50943b680b7c56c59d2d9c462ac23e4a8315978d3cc2c33139351c4bc6c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2a7d50943b680b7c56c59d2d9c462ac23e4a8315978d3cc2c33139351c4bc6c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2a7d50943b680b7c56c59d2d9c462ac23e4a8315978d3cc2c33139351c4bc6c9", kill_on_drop: false }` [INFO] [stdout] 2a7d50943b680b7c56c59d2d9c462ac23e4a8315978d3cc2c33139351c4bc6c9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9ae2c1ed2d95574f65ed91b987aeb03cfde8bae4c00c76f00bfb8655b946906e [INFO] running `Command { std: "docker" "start" "-a" "9ae2c1ed2d95574f65ed91b987aeb03cfde8bae4c00c76f00bfb8655b946906e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Compiling zerocopy v0.8.31 [INFO] [stderr] Checking rustix v1.1.2 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling wayland-sys v0.31.7 [INFO] [stderr] Compiling toml_parser v1.0.4 [INFO] [stderr] Compiling indexmap v2.12.1 [INFO] [stderr] Compiling toml_datetime v0.7.3 [INFO] [stderr] Compiling cc v1.2.49 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling static_assertions v1.1.0 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Checking uuid v1.19.0 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Compiling naga v27.0.3 [INFO] [stderr] Checking codespan-reporting v0.12.0 [INFO] [stderr] Compiling wgpu-hal v27.0.4 [INFO] [stderr] Checking ash v0.38.0+1.3.281 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Compiling wgpu-core v27.0.3 [INFO] [stderr] Compiling wgpu v27.0.1 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking syn v2.0.111 [INFO] [stderr] Checking type-map v0.5.1 [INFO] [stderr] Checking embedded-storage v0.3.1 [INFO] [stderr] Checking gcd v2.3.0 [INFO] [stderr] Compiling toml_edit v0.23.9 [INFO] [stderr] Checking png v0.18.0 [INFO] [stderr] Checking fugit v0.3.9 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking async-executor v1.13.3 [INFO] [stderr] Checking embedded-storage-async v0.4.1 [INFO] [stderr] Checking sequential-storage v6.0.1 (https://github.com/tweedegolf/sequential-storage.git?branch=master#313ec07e) [INFO] [stderr] Compiling wayland-backend v0.3.11 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking async-lock v3.4.1 [INFO] [stderr] Checking async-broadcast v0.7.2 [INFO] [stderr] Compiling wayland-scanner v0.31.7 [INFO] [stderr] Checking ordered-float v5.1.0 [INFO] [stderr] Checking pxfm v0.1.27 [INFO] [stderr] Compiling proc-macro-crate v3.4.0 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking signal-hook-registry v1.4.7 [INFO] [stderr] Checking memmap2 v0.9.9 [INFO] [stderr] Checking x11-dl v2.21.0 [INFO] [stderr] Checking khronos-egl v6.0.0 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking glutin_glx_sys v0.6.1 [INFO] [stderr] Checking moxcms v0.7.10 [INFO] [stderr] Checking glutin v0.32.3 [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking gethostname v1.1.0 [INFO] [stderr] Checking x11rb v0.13.2 [INFO] [stderr] Checking async-io v2.6.0 [INFO] [stderr] Checking async-signal v0.2.13 [INFO] [stderr] Checking wayland-client v0.31.11 [INFO] [stderr] Checking wayland-csd-frame v0.3.0 [INFO] [stderr] Checking async-process v2.5.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling zerocopy-derive v0.8.31 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling enumn v0.1.14 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking wayland-protocols v0.32.9 [INFO] [stderr] Checking wayland-cursor v0.31.11 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Checking tracing v0.1.43 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking calloop v0.14.3 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking calloop v0.13.0 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tiny-skia-path v0.11.4 [INFO] [stderr] Checking wgpu-types v27.0.1 [INFO] [stderr] Checking calloop-wayland-source v0.3.0 [INFO] [stderr] Checking calloop-wayland-source v0.4.1 [INFO] [stderr] Checking zvariant_utils v3.2.1 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking accesskit v0.21.1 [INFO] [stderr] Checking quick-xml v0.36.2 [INFO] [stderr] Checking emath v0.33.3 [INFO] [stderr] Checking tiny-skia v0.11.4 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking image v0.25.9 [INFO] [stderr] Compiling zvariant_derive v5.8.0 [INFO] [stderr] Checking ecolor v0.33.3 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking epaint v0.33.3 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Compiling zvariant v5.8.0 [INFO] [stderr] Checking arboard v3.6.1 [INFO] [stderr] Checking accesskit_consumer v0.31.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking webbrowser v1.0.6 [INFO] [stderr] Checking egui v0.33.3 [INFO] [stderr] Checking zbus_names v4.2.0 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.9 [INFO] [stderr] Checking wayland-protocols-plasma v0.3.9 [INFO] [stderr] Checking wayland-protocols-misc v0.3.9 [INFO] [stderr] Checking wayland-protocols-experimental v20250721.0.1 [INFO] [stderr] Checking zbus_xml v5.0.2 [INFO] [stderr] Checking zbus-lockstep v0.5.2 [INFO] [stderr] Checking smithay-client-toolkit v0.19.2 [INFO] [stderr] Checking smithay-client-toolkit v0.20.0 [INFO] [stderr] Compiling zbus_macros v5.12.0 [INFO] [stderr] Compiling zbus-lockstep-macros v0.5.2 [INFO] [stderr] Checking smithay-clipboard v0.7.3 [INFO] [stderr] Checking sctk-adwaita v0.10.1 [INFO] [stderr] Checking winit v0.30.12 [INFO] [stderr] Checking zbus v5.12.0 [INFO] [stderr] Checking glutin-winit v0.5.0 [INFO] [stderr] Checking egui_glow v0.33.3 [INFO] [stderr] Checking egui_tiles v0.14.0 [INFO] [stderr] Checking egui_plot v0.34.0 [INFO] [stderr] Checking egui_alignments v0.3.6 (https://github.com/a-littlebit/egui_alignments.git?branch=master#6b1bb388) [INFO] [stderr] Checking wgpu-core-deps-windows-linux-android v27.0.0 [INFO] [stderr] Checking atspi-common v0.9.0 [INFO] [stderr] Checking atspi-proxies v0.9.0 [INFO] [stderr] Checking accesskit_atspi_common v0.14.2 [INFO] [stderr] Checking atspi-connection v0.9.0 [INFO] [stderr] Checking atspi v0.25.0 [INFO] [stderr] Checking accesskit_unix v0.17.2 [INFO] [stderr] Checking egui-wgpu v0.33.3 [INFO] [stderr] Checking accesskit_winit v0.29.2 [INFO] [stderr] Checking egui-winit v0.33.3 [INFO] [stderr] Checking eframe v0.33.3 [INFO] [stderr] Checking embedded-storage-sim v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/blocking.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | / if self.page_cycles[page_index] > self.minimum_safe_erase_cycles { [INFO] [stdout] 69 | | if (self.page_cycles[page_index] - self.minimum_safe_erase_cycles) [INFO] [stdout] 70 | | % self.bit_failure_every_x_erases [INFO] [stdout] 71 | | == 0 [INFO] [stdout] ... | [INFO] [stdout] 84 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 68 ~ if self.page_cycles[page_index] > self.minimum_safe_erase_cycles [INFO] [stdout] 69 ~ && (self.page_cycles[page_index] - self.minimum_safe_erase_cycles) [INFO] [stdout] 70 | % self.bit_failure_every_x_erases [INFO] [stdout] ... [INFO] [stdout] 82 | } [INFO] [stdout] 83 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/blocking.rs:69:20 [INFO] [stdout] | [INFO] [stdout] 69 | if (self.page_cycles[page_index] - self.minimum_safe_erase_cycles) [INFO] [stdout] | ____________________^ [INFO] [stdout] 70 | | % self.bit_failure_every_x_erases [INFO] [stdout] 71 | | == 0 [INFO] [stdout] | |________________________^ help: replace with: `(self.page_cycles[page_index] - self.minimum_safe_erase_cycles).is_multiple_of(self.bit_failure_every_x_erases)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/blocking.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | / if self.page_cycles[page_index] > self.minimum_safe_erase_cycles { [INFO] [stdout] 69 | | if (self.page_cycles[page_index] - self.minimum_safe_erase_cycles) [INFO] [stdout] 70 | | % self.bit_failure_every_x_erases [INFO] [stdout] 71 | | == 0 [INFO] [stdout] ... | [INFO] [stdout] 84 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 68 ~ if self.page_cycles[page_index] > self.minimum_safe_erase_cycles [INFO] [stdout] 69 ~ && (self.page_cycles[page_index] - self.minimum_safe_erase_cycles) [INFO] [stdout] 70 | % self.bit_failure_every_x_erases [INFO] [stdout] ... [INFO] [stdout] 82 | } [INFO] [stdout] 83 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/blocking.rs:69:20 [INFO] [stdout] | [INFO] [stdout] 69 | if (self.page_cycles[page_index] - self.minimum_safe_erase_cycles) [INFO] [stdout] | ____________________^ [INFO] [stdout] 70 | | % self.bit_failure_every_x_erases [INFO] [stdout] 71 | | == 0 [INFO] [stdout] | |________________________^ help: replace with: `(self.page_cycles[page_index] - self.minimum_safe_erase_cycles).is_multiple_of(self.bit_failure_every_x_erases)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/gui.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | while let Some(next) = rx.lock().unwrap().try_recv().ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] = note: `#[warn(clippy::match_result_ok)]` on by default [INFO] [stdout] help: consider matching on `Ok(next)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 91 - while let Some(next) = rx.lock().unwrap().try_recv().ok() { [INFO] [stdout] 91 + while let Ok(next) = rx.lock().unwrap().try_recv() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: matching on `Some` with `ok()` is redundant [INFO] [stdout] --> src/gui.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | while let Some(next) = rx.lock().unwrap().try_recv().ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_result_ok [INFO] [stdout] = note: `#[warn(clippy::match_result_ok)]` on by default [INFO] [stdout] help: consider matching on `Ok(next)` and removing the call to `ok` instead [INFO] [stdout] | [INFO] [stdout] 91 - while let Some(next) = rx.lock().unwrap().try_recv().ok() { [INFO] [stdout] 91 + while let Ok(next) = rx.lock().unwrap().try_recv() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gui.rs:426:17 [INFO] [stdout] | [INFO] [stdout] 426 | / if self.runner.is_working() { [INFO] [stdout] 427 | | if ui.button("Cancel").clicked() { [INFO] [stdout] 428 | | self.runner.start_workload(Workload::Cancel); [INFO] [stdout] 429 | | } [INFO] [stdout] 430 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 426 ~ if self.runner.is_working() [INFO] [stdout] 427 ~ && ui.button("Cancel").clicked() { [INFO] [stdout] 428 | self.runner.start_workload(Workload::Cancel); [INFO] [stdout] 429 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/gui.rs:521:16 [INFO] [stdout] | [INFO] [stdout] 521 | let rows = (pages + cols - 1) / cols; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `pages.div_ceil(cols)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gui.rs:610:9 [INFO] [stdout] | [INFO] [stdout] 610 | return "".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 610 - return "".to_string(); [INFO] [stdout] 610 + "".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gui.rs:612:9 [INFO] [stdout] | [INFO] [stdout] 612 | return "0 s".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 612 - return "0 s".to_string(); [INFO] [stdout] 612 + "0 s".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/gui.rs:426:17 [INFO] [stdout] | [INFO] [stdout] 426 | / if self.runner.is_working() { [INFO] [stdout] 427 | | if ui.button("Cancel").clicked() { [INFO] [stdout] 428 | | self.runner.start_workload(Workload::Cancel); [INFO] [stdout] 429 | | } [INFO] [stdout] 430 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 426 ~ if self.runner.is_working() [INFO] [stdout] 427 ~ && ui.button("Cancel").clicked() { [INFO] [stdout] 428 | self.runner.start_workload(Workload::Cancel); [INFO] [stdout] 429 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/gui.rs:521:16 [INFO] [stdout] | [INFO] [stdout] 521 | let rows = (pages + cols - 1) / cols; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `pages.div_ceil(cols)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/workloads/mod.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | / impl ToString for Operation { [INFO] [stdout] 13 | | fn to_string(&self) -> String { [INFO] [stdout] 14 | | match self { [INFO] [stdout] 15 | | Operation::QueuePush => "Push".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 22 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return Ok(()); [INFO] [stdout] 21 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gui.rs:610:9 [INFO] [stdout] | [INFO] [stdout] 610 | return "".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 610 - return "".to_string(); [INFO] [stdout] 610 + "".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/gui.rs:612:9 [INFO] [stdout] | [INFO] [stdout] 612 | return "0 s".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 612 - return "0 s".to_string(); [INFO] [stdout] 612 + "0 s".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: direct implementation of `ToString` [INFO] [stdout] --> src/workloads/mod.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | / impl ToString for Operation { [INFO] [stdout] 13 | | fn to_string(&self) -> String { [INFO] [stdout] 14 | | match self { [INFO] [stdout] 15 | | Operation::QueuePush => "Push".to_string(), [INFO] [stdout] ... | [INFO] [stdout] 22 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: prefer implementing `Display` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_trait_impl [INFO] [stdout] = note: `#[warn(clippy::to_string_trait_impl)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 21 - return Ok(()); [INFO] [stdout] 21 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 16s [INFO] running `Command { std: "docker" "inspect" "9ae2c1ed2d95574f65ed91b987aeb03cfde8bae4c00c76f00bfb8655b946906e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9ae2c1ed2d95574f65ed91b987aeb03cfde8bae4c00c76f00bfb8655b946906e", kill_on_drop: false }` [INFO] [stdout] 9ae2c1ed2d95574f65ed91b987aeb03cfde8bae4c00c76f00bfb8655b946906e