[INFO] cloning repository https://github.com/SubstructureOne/impulse [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SubstructureOne/impulse" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSubstructureOne%2Fimpulse", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSubstructureOne%2Fimpulse'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5cd34ae8f0202cf79b7f7b4ecf1a2f9cc27d3013 [INFO] linting SubstructureOne/impulse against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSubstructureOne%2Fimpulse" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/SubstructureOne/impulse [INFO] finished tweaking git repo https://github.com/SubstructureOne/impulse [INFO] tweaked toml for git repo https://github.com/SubstructureOne/impulse written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/SubstructureOne/impulse on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/SubstructureOne/impulse already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded test-log v0.2.12 [INFO] [stderr] Downloaded postgres-protocol v0.6.5 [INFO] [stderr] Downloaded migrations_macros v2.1.0 [INFO] [stderr] Downloaded diesel-derive-enum v2.1.0 [INFO] [stderr] Downloaded containers-api v0.7.0 [INFO] [stderr] Downloaded random-pick v1.2.16 [INFO] [stderr] Downloaded random-number v0.1.8 [INFO] [stderr] Downloaded tokio-postgres v0.7.8 [INFO] [stderr] Downloaded clap v4.3.21 [INFO] [stderr] Downloaded docker-api v0.12.2 [INFO] [stderr] Downloaded docker-api-stubs v0.4.0 [INFO] [stderr] Downloaded prettyplease v0.2.15 [INFO] [stderr] Downloaded winnow v0.5.4 [INFO] [stderr] Downloaded syn v2.0.32 [INFO] [stderr] Downloaded migrations_internals v2.1.0 [INFO] [stderr] Downloaded diesel_migrations v2.1.0 [INFO] [stderr] Downloaded clap_builder v4.3.21 [INFO] [stderr] Downloaded hyperlocal v0.8.0 [INFO] [stderr] Downloaded xattr v1.0.1 [INFO] [stderr] Downloaded random-number-macro-impl v0.1.7 [INFO] [stderr] Downloaded postgres-derive v0.4.4 [INFO] [stderr] Downloaded postgres-types v0.2.5 [INFO] [stderr] Downloaded prew v0.3.3 [INFO] [stderr] Downloaded passwords v3.1.13 [INFO] [stderr] Downloaded pg_query v0.8.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9990b039a55818e6d08d72b45a8f7d9654019f6339e03d9a3c913be92b0b5817 [INFO] running `Command { std: "docker" "start" "-a" "9990b039a55818e6d08d72b45a8f7d9654019f6339e03d9a3c913be92b0b5817", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9990b039a55818e6d08d72b45a8f7d9654019f6339e03d9a3c913be92b0b5817", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9990b039a55818e6d08d72b45a8f7d9654019f6339e03d9a3c913be92b0b5817", kill_on_drop: false }` [INFO] [stdout] 9990b039a55818e6d08d72b45a8f7d9654019f6339e03d9a3c913be92b0b5817 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2f32475db79b33ea4bfdd706fbbaff7d2ddba419ff391a5a9867f1dd0f577f53 [INFO] running `Command { std: "docker" "start" "-a" "2f32475db79b33ea4bfdd706fbbaff7d2ddba419ff391a5a9867f1dd0f577f53", kill_on_drop: false }` [INFO] [stderr] Compiling serde_derive v1.0.183 [INFO] [stderr] Compiling serde v1.0.183 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking pin-project-lite v0.2.11 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Compiling either v1.9.0 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling syn v2.0.32 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Compiling serde_json v1.0.104 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Compiling anyhow v1.0.72 [INFO] [stderr] Compiling tokio v1.29.1 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling clang-sys v1.6.1 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Compiling regex-syntax v0.7.4 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Compiling bitflags v2.3.3 [INFO] [stderr] Compiling prettyplease v0.2.15 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling rustix v0.38.7 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling which v4.4.0 [INFO] [stderr] Compiling cc v1.0.82 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Compiling bytes v1.4.0 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling linux-raw-sys v0.4.5 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling libloading v0.7.4 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Compiling thiserror v1.0.44 [INFO] [stderr] Compiling log v0.4.19 [INFO] [stderr] Compiling hashbrown v0.14.0 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Compiling fastrand v2.0.0 [INFO] [stderr] Compiling petgraph v0.6.3 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling indexmap v2.0.0 [INFO] [stderr] Compiling bindgen v0.66.1 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Checking cpufeatures v0.2.9 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Compiling winnow v0.5.4 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Compiling prost-build v0.10.4 [INFO] [stderr] Checking sha2 v0.10.7 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking httparse v1.8.0 [INFO] [stderr] Checking md-5 v0.10.5 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking stringprep v0.1.3 [INFO] [stderr] Compiling tempfile v3.7.1 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking siphasher v0.3.10 [INFO] [stderr] Compiling async-trait v0.1.72 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Compiling pq-sys v0.4.8 [INFO] [stderr] Compiling regex-automata v0.3.6 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking base64 v0.21.2 [INFO] [stderr] Checking phf_shared v0.11.2 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking scheduled-thread-pool v0.2.7 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking chrono v0.4.26 [INFO] [stderr] Checking toml_datetime v0.6.3 [INFO] [stderr] Checking serde_spanned v0.6.3 [INFO] [stderr] Checking postgres-protocol v0.6.5 [INFO] [stderr] Checking filetime v0.2.22 [INFO] [stderr] Checking xattr v1.0.1 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking tar v0.4.40 [INFO] [stderr] Checking r2d2 v0.8.10 [INFO] [stderr] Checking url v2.4.0 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking uuid v1.4.1 [INFO] [stderr] Checking socket2 v0.5.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap_builder v4.3.21 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking async_once v0.2.6 [INFO] [stderr] Compiling regex v1.9.3 [INFO] [stderr] Compiling toml_edit v0.19.14 [INFO] [stderr] Compiling prost-derive v0.10.1 [INFO] [stderr] Compiling test-log v0.2.12 [INFO] [stderr] Compiling darling_core v0.20.3 [INFO] [stderr] Compiling diesel_table_macro_syntax v0.1.0 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.44 [INFO] [stderr] Compiling pin-project-internal v1.1.3 [INFO] [stderr] Compiling postgres-derive v0.4.4 [INFO] [stderr] Compiling random-number-macro-impl v0.1.7 [INFO] [stderr] Compiling diesel_derives v2.1.0 [INFO] [stderr] Compiling clap_derive v4.3.12 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Compiling enum-iterator-derive v1.2.1 [INFO] [stderr] Checking random-number v0.1.8 [INFO] [stderr] Checking random-pick v1.2.16 [INFO] [stderr] Checking postgres-types v0.2.5 [INFO] [stderr] Checking passwords v3.1.13 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Compiling diesel-derive-enum v2.1.0 [INFO] [stderr] Compiling toml v0.7.6 [INFO] [stderr] Compiling prost v0.10.4 [INFO] [stderr] Checking pin-project v1.1.3 [INFO] [stderr] Compiling prost-types v0.10.1 [INFO] [stderr] Checking enum-iterator v1.4.1 [INFO] [stderr] Compiling migrations_internals v2.1.0 [INFO] [stderr] Compiling migrations_macros v2.1.0 [INFO] [stderr] Compiling darling_macro v0.20.3 [INFO] [stderr] Checking clap v4.3.21 [INFO] [stderr] Compiling darling v0.20.3 [INFO] [stderr] Compiling serde_with_macros v2.3.3 [INFO] [stderr] Checking serde_with v2.3.3 [INFO] [stderr] Checking diesel v2.1.0 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking asynchronous-codec v0.6.2 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking docker-api-stubs v0.4.0 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking tokio-util v0.7.8 [INFO] [stderr] Compiling pg_query v0.8.2 [INFO] [stderr] Checking tokio-postgres v0.7.8 [INFO] [stderr] Checking hyperlocal v0.8.0 [INFO] [stderr] Checking containers-api v0.7.0 [INFO] [stderr] Checking docker-api v0.12.2 [INFO] [stderr] Checking diesel_migrations v2.1.0 [INFO] [stderr] Checking prew v0.3.3 [INFO] [stderr] Checking impulse v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/reports.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | / return Report { [INFO] [stdout] 133 | | report_id: value.report_id, [INFO] [stdout] 134 | | username: value.username, [INFO] [stdout] 135 | | packet_type: PostgresqlPacketType::from_str(&value.packet_type).unwrap(), [INFO] [stdout] ... | [INFO] [stdout] 140 | | charged: value.charged, [INFO] [stdout] 141 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 132 ~ Report { [INFO] [stdout] 133 + report_id: value.report_id, [INFO] [stdout] 134 + username: value.username, [INFO] [stdout] 135 + packet_type: PostgresqlPacketType::from_str(&value.packet_type).unwrap(), [INFO] [stdout] 136 + packet_time: value.packet_time, [INFO] [stdout] 137 + direction, [INFO] [stdout] 138 + packet_info: value.packet_info, [INFO] [stdout] 139 + packet_bytes: value.packet_bytes, [INFO] [stdout] 140 + charged: value.charged, [INFO] [stdout] 141 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/models/reports.rs:128:25 [INFO] [stdout] | [INFO] [stdout] 128 | let direction = match value.direction { [INFO] [stdout] | _________________________^ [INFO] [stdout] 129 | | Some(dir) => Some(PacketDirection::from_str(&dir).unwrap()), [INFO] [stdout] 130 | | None => None [INFO] [stdout] 131 | | }; [INFO] [stdout] | |_________^ help: try: `value.direction.map(|dir| PacketDirection::from_str(&dir).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/reports.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | / return Report { [INFO] [stdout] 133 | | report_id: value.report_id, [INFO] [stdout] 134 | | username: value.username, [INFO] [stdout] 135 | | packet_type: PostgresqlPacketType::from_str(&value.packet_type).unwrap(), [INFO] [stdout] ... | [INFO] [stdout] 140 | | charged: value.charged, [INFO] [stdout] 141 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 132 ~ Report { [INFO] [stdout] 133 + report_id: value.report_id, [INFO] [stdout] 134 + username: value.username, [INFO] [stdout] 135 + packet_type: PostgresqlPacketType::from_str(&value.packet_type).unwrap(), [INFO] [stdout] 136 + packet_time: value.packet_time, [INFO] [stdout] 137 + direction, [INFO] [stdout] 138 + packet_info: value.packet_info, [INFO] [stdout] 139 + packet_bytes: value.packet_bytes, [INFO] [stdout] 140 + charged: value.charged, [INFO] [stdout] 141 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/models/reports.rs:128:25 [INFO] [stdout] | [INFO] [stdout] 128 | let direction = match value.direction { [INFO] [stdout] | _________________________^ [INFO] [stdout] 129 | | Some(dir) => Some(PacketDirection::from_str(&dir).unwrap()), [INFO] [stdout] 130 | | None => None [INFO] [stdout] 131 | | }; [INFO] [stdout] | |_________^ help: try: `value.direction.map(|dir| PacketDirection::from_str(&dir).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/reports.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 208 | / return ReportToCharge { [INFO] [stdout] 209 | | report_id: value.report_id, [INFO] [stdout] 210 | | user_id: value.user_id, [INFO] [stdout] 211 | | packet_type: PostgresqlPacketType::from_str(&value.packet_type).unwrap(), [INFO] [stdout] 212 | | direction, [INFO] [stdout] 213 | | num_bytes: value.num_bytes, [INFO] [stdout] 214 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 ~ ReportToCharge { [INFO] [stdout] 209 + report_id: value.report_id, [INFO] [stdout] 210 + user_id: value.user_id, [INFO] [stdout] 211 + packet_type: PostgresqlPacketType::from_str(&value.packet_type).unwrap(), [INFO] [stdout] 212 + direction, [INFO] [stdout] 213 + num_bytes: value.num_bytes, [INFO] [stdout] 214 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/models/reports.rs:204:25 [INFO] [stdout] | [INFO] [stdout] 204 | let direction = match value.direction { [INFO] [stdout] | _________________________^ [INFO] [stdout] 205 | | Some(dir) => Some(PacketDirection::from_str(&dir).unwrap()), [INFO] [stdout] 206 | | None => None [INFO] [stdout] 207 | | }; [INFO] [stdout] | |_________^ help: try: `value.direction.map(|dir| PacketDirection::from_str(&dir).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/reports.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | / return ReportToCharge { [INFO] [stdout] 224 | | report_id: value.report_id, [INFO] [stdout] 225 | | user_id: None, [INFO] [stdout] 226 | | packet_type: value.packet_type, [INFO] [stdout] 227 | | direction: value.direction, [INFO] [stdout] 228 | | num_bytes [INFO] [stdout] 229 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 223 ~ ReportToCharge { [INFO] [stdout] 224 + report_id: value.report_id, [INFO] [stdout] 225 + user_id: None, [INFO] [stdout] 226 + packet_type: value.packet_type, [INFO] [stdout] 227 + direction: value.direction, [INFO] [stdout] 228 + num_bytes [INFO] [stdout] 229 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/models/reports.rs:253:25 [INFO] [stdout] | [INFO] [stdout] 253 | let direction = match direction { [INFO] [stdout] | _________________________^ [INFO] [stdout] 254 | | Some(dir) => Some(dir.to_string()), [INFO] [stdout] 255 | | None => None [INFO] [stdout] 256 | | }; [INFO] [stdout] | |_________^ help: try: `direction.map(|dir| dir.to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/reports.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 208 | / return ReportToCharge { [INFO] [stdout] 209 | | report_id: value.report_id, [INFO] [stdout] 210 | | user_id: value.user_id, [INFO] [stdout] 211 | | packet_type: PostgresqlPacketType::from_str(&value.packet_type).unwrap(), [INFO] [stdout] 212 | | direction, [INFO] [stdout] 213 | | num_bytes: value.num_bytes, [INFO] [stdout] 214 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 ~ ReportToCharge { [INFO] [stdout] 209 + report_id: value.report_id, [INFO] [stdout] 210 + user_id: value.user_id, [INFO] [stdout] 211 + packet_type: PostgresqlPacketType::from_str(&value.packet_type).unwrap(), [INFO] [stdout] 212 + direction, [INFO] [stdout] 213 + num_bytes: value.num_bytes, [INFO] [stdout] 214 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/models/reports.rs:204:25 [INFO] [stdout] | [INFO] [stdout] 204 | let direction = match value.direction { [INFO] [stdout] | _________________________^ [INFO] [stdout] 205 | | Some(dir) => Some(PacketDirection::from_str(&dir).unwrap()), [INFO] [stdout] 206 | | None => None [INFO] [stdout] 207 | | }; [INFO] [stdout] | |_________^ help: try: `value.direction.map(|dir| PacketDirection::from_str(&dir).unwrap())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/models/reports.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | / return ReportToCharge { [INFO] [stdout] 224 | | report_id: value.report_id, [INFO] [stdout] 225 | | user_id: None, [INFO] [stdout] 226 | | packet_type: value.packet_type, [INFO] [stdout] 227 | | direction: value.direction, [INFO] [stdout] 228 | | num_bytes [INFO] [stdout] 229 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 223 ~ ReportToCharge { [INFO] [stdout] 224 + report_id: value.report_id, [INFO] [stdout] 225 + user_id: None, [INFO] [stdout] 226 + packet_type: value.packet_type, [INFO] [stdout] 227 + direction: value.direction, [INFO] [stdout] 228 + num_bytes [INFO] [stdout] 229 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/models/reports.rs:253:25 [INFO] [stdout] | [INFO] [stdout] 253 | let direction = match direction { [INFO] [stdout] | _________________________^ [INFO] [stdout] 254 | | Some(dir) => Some(dir.to_string()), [INFO] [stdout] 255 | | None => None [INFO] [stdout] 256 | | }; [INFO] [stdout] | |_________^ help: try: `direction.map(|dir| dir.to_string())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/models/charges.rs:123:18 [INFO] [stdout] | [INFO] [stdout] 123 | .or_insert(HashMap::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `or_insert` to construct default value [INFO] [stdout] --> src/models/charges.rs:123:18 [INFO] [stdout] | [INFO] [stdout] 123 | .or_insert(HashMap::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default [INFO] [stdout] = note: `#[warn(clippy::unwrap_or_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/models/charges.rs:122:24 [INFO] [stdout] | [INFO] [stdout] 122 | .entry(report.user_id.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `report.user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Option` which implements the `Copy` trait [INFO] [stdout] --> src/models/charges.rs:122:24 [INFO] [stdout] | [INFO] [stdout] 122 | .entry(report.user_id.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `report.user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/models/charges.rs:226:12 [INFO] [stdout] | [INFO] [stdout] 226 | if new_report.num_bytes == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `new_report.num_bytes.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/models/charges.rs:244:59 [INFO] [stdout] | [INFO] [stdout] 244 | new_report.user_id.unwrap_or_else(|| Uuid::nil()), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Uuid::nil` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/models/charges.rs:267:26 [INFO] [stdout] | [INFO] [stdout] 267 | let report_ids = match charge_.report_ids { [INFO] [stdout] | __________________________^ [INFO] [stdout] 268 | | Some(reports) => Some( [INFO] [stdout] 269 | | reports [INFO] [stdout] 270 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 274 | | None => None [INFO] [stdout] 275 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 267 ~ let report_ids = charge_.report_ids.map(|reports| reports [INFO] [stdout] 268 + .iter() [INFO] [stdout] 269 + .map(|rid| rid.unwrap()) [INFO] [stdout] 270 ~ .collect::>()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/models/charges.rs:226:12 [INFO] [stdout] | [INFO] [stdout] 226 | if new_report.num_bytes == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `new_report.num_bytes.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/models/charges.rs:244:59 [INFO] [stdout] | [INFO] [stdout] 244 | new_report.user_id.unwrap_or_else(|| Uuid::nil()), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Uuid::nil` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/models/charges.rs:267:26 [INFO] [stdout] | [INFO] [stdout] 267 | let report_ids = match charge_.report_ids { [INFO] [stdout] | __________________________^ [INFO] [stdout] 268 | | Some(reports) => Some( [INFO] [stdout] 269 | | reports [INFO] [stdout] 270 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 274 | | None => None [INFO] [stdout] 275 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 267 ~ let report_ids = charge_.report_ids.map(|reports| reports [INFO] [stdout] 268 + .iter() [INFO] [stdout] 269 + .map(|rid| rid.unwrap()) [INFO] [stdout] 270 ~ .collect::>()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait [INFO] [stdout] --> src/models/charges.rs:371:13 [INFO] [stdout] | [INFO] [stdout] 371 | self.user_id.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait [INFO] [stdout] --> src/models/charges.rs:371:13 [INFO] [stdout] | [INFO] [stdout] 371 | self.user_id.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/models/transactions.rs:105:26 [INFO] [stdout] | [INFO] [stdout] 105 | let charge_ids = match txn_.charge_ids { [INFO] [stdout] | __________________________^ [INFO] [stdout] 106 | | Some(ids_vec) => Some( [INFO] [stdout] 107 | | ids_vec [INFO] [stdout] 108 | | .into_iter() [INFO] [stdout] ... | [INFO] [stdout] 113 | | None => None [INFO] [stdout] 114 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 105 ~ let charge_ids = txn_.charge_ids.map(|ids_vec| ids_vec [INFO] [stdout] 106 + .into_iter() [INFO] [stdout] 107 + .filter(|&x| !x.is_none()) [INFO] [stdout] 108 + .map(|x| x.unwrap()) [INFO] [stdout] 109 ~ .collect::>()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/models/transactions.rs:109:34 [INFO] [stdout] | [INFO] [stdout] 109 | .filter(|&x| !x.is_none()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `x.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/models/transactions.rs:161:18 [INFO] [stdout] | [INFO] [stdout] 161 | charges: &Vec [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 161 - charges: &Vec [INFO] [stdout] 161 + charges: &[Charge] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/models/transactions.rs:105:26 [INFO] [stdout] | [INFO] [stdout] 105 | let charge_ids = match txn_.charge_ids { [INFO] [stdout] | __________________________^ [INFO] [stdout] 106 | | Some(ids_vec) => Some( [INFO] [stdout] 107 | | ids_vec [INFO] [stdout] 108 | | .into_iter() [INFO] [stdout] ... | [INFO] [stdout] 113 | | None => None [INFO] [stdout] 114 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 105 ~ let charge_ids = txn_.charge_ids.map(|ids_vec| ids_vec [INFO] [stdout] 106 + .into_iter() [INFO] [stdout] 107 + .filter(|&x| !x.is_none()) [INFO] [stdout] 108 + .map(|x| x.unwrap()) [INFO] [stdout] 109 ~ .collect::>()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/models/transactions.rs:109:34 [INFO] [stdout] | [INFO] [stdout] 109 | .filter(|&x| !x.is_none()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `x.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/models/transactions.rs:161:18 [INFO] [stdout] | [INFO] [stdout] 161 | charges: &Vec [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 161 - charges: &Vec [INFO] [stdout] 161 + charges: &[Charge] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `models::users::User` [INFO] [stdout] --> src/models/users.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | / users [INFO] [stdout] 36 | | .find(user_id_) [INFO] [stdout] 37 | | .first::(conn)? [INFO] [stdout] 38 | | .into() [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 35 ~ users [INFO] [stdout] 36 + .find(user_id_) [INFO] [stdout] 37 + .first::(conn)? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `models::users::User` [INFO] [stdout] --> src/models/users.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | / users [INFO] [stdout] 36 | | .find(user_id_) [INFO] [stdout] 37 | | .first::(conn)? [INFO] [stdout] 38 | | .into() [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 35 ~ users [INFO] [stdout] 36 + .find(user_id_) [INFO] [stdout] 37 + .first::(conn)? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/manage/postgres.rs:28:6 [INFO] [stdout] | [INFO] [stdout] 28 | impl<'a> Display for PostgresManager { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/manage/postgres.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | Ok(self.pg_connect_db(&self.config.pg_user)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 35 - Ok(self.pg_connect_db(&self.config.pg_user)?) [INFO] [stdout] 35 + self.pg_connect_db(&self.config.pg_user) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> src/manage/postgres.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | self.config.pg_port.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.config.pg_port` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/manage/postgres.rs:28:6 [INFO] [stdout] | [INFO] [stdout] 28 | impl<'a> Display for PostgresManager { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/manage/postgres.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | Ok(self.pg_connect_db(&self.config.pg_user)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 35 - Ok(self.pg_connect_db(&self.config.pg_user)?) [INFO] [stdout] 35 + self.pg_connect_db(&self.config.pg_user) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u32` which implements the `Copy` trait [INFO] [stdout] --> src/manage/postgres.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | self.config.pg_port.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.config.pg_port` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::iter::Map, {closure@src/manage/postgres.rs:220:18: 220:24}>` [INFO] [stdout] --> src/manage/postgres.rs:218:25 [INFO] [stdout] | [INFO] [stdout] 218 | let name2uuid = User::all(impulse_conn)? [INFO] [stdout] | _________________________^ [INFO] [stdout] 219 | | .iter() [INFO] [stdout] 220 | | .map(|user| (user.pg_name.clone(), user.user_id)) [INFO] [stdout] 221 | | .into_iter() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 218 ~ let name2uuid = User::all(impulse_conn)? [INFO] [stdout] 219 + .iter() [INFO] [stdout] 220 + .map(|user| (user.pg_name.clone(), user.user_id)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::iter::Map, {closure@src/manage/postgres.rs:220:18: 220:24}>` [INFO] [stdout] --> src/manage/postgres.rs:218:25 [INFO] [stdout] | [INFO] [stdout] 218 | let name2uuid = User::all(impulse_conn)? [INFO] [stdout] | _________________________^ [INFO] [stdout] 219 | | .iter() [INFO] [stdout] 220 | | .map(|user| (user.pg_name.clone(), user.user_id)) [INFO] [stdout] 221 | | .into_iter() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 218 ~ let name2uuid = User::all(impulse_conn)? [INFO] [stdout] 219 + .iter() [INFO] [stdout] 220 + .map(|user| (user.pg_name.clone(), user.user_id)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ImpulseReporter` [INFO] [stdout] --> src/prew.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | / pub fn new() -> ImpulseReporter { [INFO] [stdout] 62 | | ImpulseReporter { } [INFO] [stdout] 63 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 60 + impl Default for ImpulseReporter { [INFO] [stdout] 61 + fn default() -> Self { [INFO] [stdout] 62 + Self::new() [INFO] [stdout] 63 + } [INFO] [stdout] 64 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `RemoveAppendedUserNameTransformer` [INFO] [stdout] --> src/prew.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 112 | / pub fn new() -> RemoveAppendedUserNameTransformer { [INFO] [stdout] 113 | | RemoveAppendedUserNameTransformer {} [INFO] [stdout] 114 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 111 + impl Default for RemoveAppendedUserNameTransformer { [INFO] [stdout] 112 + fn default() -> Self { [INFO] [stdout] 113 + Self::new() [INFO] [stdout] 114 + } [INFO] [stdout] 115 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/prew.rs:133:21 [INFO] [stdout] | [INFO] [stdout] 133 | / if column.bytes.len() >= suffix.len() { [INFO] [stdout] 134 | | if column.bytes[column.bytes.len() - offset..].eq(&suffix) { [INFO] [stdout] 135 | | modify = true; [INFO] [stdout] 136 | | break; [INFO] [stdout] 137 | | } [INFO] [stdout] 138 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 133 ~ if column.bytes.len() >= suffix.len() [INFO] [stdout] 134 ~ && column.bytes[column.bytes.len() - offset..].eq(&suffix) { [INFO] [stdout] 135 | modify = true; [INFO] [stdout] 136 | break; [INFO] [stdout] 137 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ImpulseReporter` [INFO] [stdout] --> src/prew.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 61 | / pub fn new() -> ImpulseReporter { [INFO] [stdout] 62 | | ImpulseReporter { } [INFO] [stdout] 63 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 60 + impl Default for ImpulseReporter { [INFO] [stdout] 61 + fn default() -> Self { [INFO] [stdout] 62 + Self::new() [INFO] [stdout] 63 + } [INFO] [stdout] 64 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/prew.rs:141:94 [INFO] [stdout] | [INFO] [stdout] 141 | let new_columns = message.columns.iter().map(|column| self.modify_column(&column, &suffix)).collect(); [INFO] [stdout] | ^^^^^^^ help: change this to: `column` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `AppendUserNameTransformer` [INFO] [stdout] --> src/prew.rs:162:5 [INFO] [stdout] | [INFO] [stdout] 162 | / pub fn new() -> AppendUserNameTransformer { [INFO] [stdout] 163 | | AppendUserNameTransformer {} [INFO] [stdout] 164 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 161 + impl Default for AppendUserNameTransformer { [INFO] [stdout] 162 + fn default() -> Self { [INFO] [stdout] 163 + Self::new() [INFO] [stdout] 164 + } [INFO] [stdout] 165 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `RemoveAppendedUserNameTransformer` [INFO] [stdout] --> src/prew.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 112 | / pub fn new() -> RemoveAppendedUserNameTransformer { [INFO] [stdout] 113 | | RemoveAppendedUserNameTransformer {} [INFO] [stdout] 114 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 111 + impl Default for RemoveAppendedUserNameTransformer { [INFO] [stdout] 112 + fn default() -> Self { [INFO] [stdout] 113 + Self::new() [INFO] [stdout] 114 + } [INFO] [stdout] 115 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/prew.rs:133:21 [INFO] [stdout] | [INFO] [stdout] 133 | / if column.bytes.len() >= suffix.len() { [INFO] [stdout] 134 | | if column.bytes[column.bytes.len() - offset..].eq(&suffix) { [INFO] [stdout] 135 | | modify = true; [INFO] [stdout] 136 | | break; [INFO] [stdout] 137 | | } [INFO] [stdout] 138 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 133 ~ if column.bytes.len() >= suffix.len() [INFO] [stdout] 134 ~ && column.bytes[column.bytes.len() - offset..].eq(&suffix) { [INFO] [stdout] 135 | modify = true; [INFO] [stdout] 136 | break; [INFO] [stdout] 137 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/prew.rs:141:94 [INFO] [stdout] | [INFO] [stdout] 141 | let new_columns = message.columns.iter().map(|column| self.modify_column(&column, &suffix)).collect(); [INFO] [stdout] | ^^^^^^^ help: change this to: `column` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `AppendUserNameTransformer` [INFO] [stdout] --> src/prew.rs:162:5 [INFO] [stdout] | [INFO] [stdout] 162 | / pub fn new() -> AppendUserNameTransformer { [INFO] [stdout] 163 | | AppendUserNameTransformer {} [INFO] [stdout] 164 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 161 + impl Default for AppendUserNameTransformer { [INFO] [stdout] 162 + fn default() -> Self { [INFO] [stdout] 163 + Self::new() [INFO] [stdout] 164 + } [INFO] [stdout] 165 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `impulse_config` and `managed_db_manager` are never read [INFO] [stdout] --> tests/common/mod.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 63 | pub struct TestContext { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 64 | pub impulse_config: Rc, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 65 | pub impulse_manager: PostgresManager, [INFO] [stdout] 66 | pub managed_db_manager: PostgresManager, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ExpectedEquals` is never used [INFO] [stdout] --> tests/common/mod.rs:137:11 [INFO] [stdout] | [INFO] [stdout] 137 | pub trait ExpectedEquals { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DateTime` which implements the `Copy` trait [INFO] [stdout] --> tests/common/mod.rs:143:52 [INFO] [stdout] | [INFO] [stdout] 143 | let duration = other.signed_duration_since(self.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `impulse_config` and `managed_db_manager` are never read [INFO] [stdout] --> tests/common/mod.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 63 | pub struct TestContext { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 64 | pub impulse_config: Rc, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 65 | pub impulse_manager: PostgresManager, [INFO] [stdout] 66 | pub managed_db_manager: PostgresManager, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `impulse_config` and `managed_db_manager` are never read [INFO] [stdout] --> tests/common/mod.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 63 | pub struct TestContext { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 64 | pub impulse_config: Rc, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 65 | pub impulse_manager: PostgresManager, [INFO] [stdout] 66 | pub managed_db_manager: PostgresManager, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DateTime` which implements the `Copy` trait [INFO] [stdout] --> tests/common/mod.rs:143:52 [INFO] [stdout] | [INFO] [stdout] 143 | let duration = other.signed_duration_since(self.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait [INFO] [stdout] --> tests/test_users.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | user_id.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait [INFO] [stdout] --> tests/test_users.rs:36:18 [INFO] [stdout] | [INFO] [stdout] 36 | user_id: user_id.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DateTime` which implements the `Copy` trait [INFO] [stdout] --> tests/common/mod.rs:143:52 [INFO] [stdout] | [INFO] [stdout] 143 | let duration = other.signed_duration_since(self.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait [INFO] [stdout] --> tests/test_transactions.rs:46:20 [INFO] [stdout] | [INFO] [stdout] 46 | from_user: from_user.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `from_user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait [INFO] [stdout] --> tests/test_transactions.rs:47:18 [INFO] [stdout] | [INFO] [stdout] 47 | to_user: to_user.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `to_user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait [INFO] [stdout] --> tests/test_transactions.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | from_user.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `from_user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait [INFO] [stdout] --> tests/test_transactions.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | to_user.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `to_user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `timecharge1` [INFO] [stdout] --> tests/test_charges.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | let timecharge1 = NewTimeCharge::create( [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_timecharge1` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait [INFO] [stdout] --> tests/test_transactions.rs:122:18 [INFO] [stdout] | [INFO] [stdout] 122 | user_id: user_id.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `impulse_config` and `managed_db_manager` are never read [INFO] [stdout] --> tests/common/mod.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 63 | pub struct TestContext { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 64 | pub impulse_config: Rc, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 65 | pub impulse_manager: PostgresManager, [INFO] [stdout] 66 | pub managed_db_manager: PostgresManager, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait [INFO] [stdout] --> tests/test_transactions.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 129 | user_id.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DateTime` which implements the `Copy` trait [INFO] [stdout] --> tests/common/mod.rs:143:52 [INFO] [stdout] | [INFO] [stdout] 143 | let duration = other.signed_duration_since(self.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Uuid` which implements the `Copy` trait [INFO] [stdout] --> tests/test_charges.rs:42:18 [INFO] [stdout] | [INFO] [stdout] 42 | user_id: user_id.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `user_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `impulse_config` is never read [INFO] [stdout] --> tests/common/mod.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 63 | pub struct TestContext { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 64 | pub impulse_config: Rc, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ExpectedEquals` is never used [INFO] [stdout] --> tests/common/mod.rs:137:11 [INFO] [stdout] | [INFO] [stdout] 137 | pub trait ExpectedEquals { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `DateTime` which implements the `Copy` trait [INFO] [stdout] --> tests/common/mod.rs:143:52 [INFO] [stdout] | [INFO] [stdout] 143 | let duration = other.signed_duration_since(self.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/test_postgres.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | &managed_db_manager, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `managed_db_manager` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> tests/test_postgres.rs:53:16 [INFO] [stdout] | [INFO] [stdout] 53 | if let Ok(_) = failed_conn { [INFO] [stdout] | -------^^^^^-------------- help: try: `if failed_conn.is_ok()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> tests/test_postgres.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | / assert!( [INFO] [stdout] 55 | | false, [INFO] [stdout] 56 | | "Should not have been able to connect to postgres database as user {}", [INFO] [stdout] 57 | | &info.username [INFO] [stdout] 58 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 22s [INFO] running `Command { std: "docker" "inspect" "2f32475db79b33ea4bfdd706fbbaff7d2ddba419ff391a5a9867f1dd0f577f53", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2f32475db79b33ea4bfdd706fbbaff7d2ddba419ff391a5a9867f1dd0f577f53", kill_on_drop: false }` [INFO] [stdout] 2f32475db79b33ea4bfdd706fbbaff7d2ddba419ff391a5a9867f1dd0f577f53