[INFO] cloning repository https://github.com/StrathSEDS-on-GitHub/BLaIM [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/StrathSEDS-on-GitHub/BLaIM" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FStrathSEDS-on-GitHub%2FBLaIM", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FStrathSEDS-on-GitHub%2FBLaIM'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] a6236444f1df45ca3bc96e2dfe2b049b2520b2c8 [INFO] linting StrathSEDS-on-GitHub/BLaIM against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FStrathSEDS-on-GitHub%2FBLaIM" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/StrathSEDS-on-GitHub/BLaIM [INFO] finished tweaking git repo https://github.com/StrathSEDS-on-GitHub/BLaIM [INFO] tweaked toml for git repo https://github.com/StrathSEDS-on-GitHub/BLaIM written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/StrathSEDS-on-GitHub/BLaIM on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/StrathSEDS-on-GitHub/BLaIM already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wasm-bindgen-futures v0.4.53 [INFO] [stderr] Downloaded tower-sessions-memory-store v0.14.0 [INFO] [stderr] Downloaded tower-cookies v0.11.0 [INFO] [stderr] Downloaded tokio-rustls v0.26.3 [INFO] [stderr] Downloaded owo-colors v4.2.2 [INFO] [stderr] Downloaded tower-sessions-core v0.14.0 [INFO] [stderr] Downloaded camino v1.2.0 [INFO] [stderr] Downloaded tempfile v3.22.0 [INFO] [stderr] Downloaded tower-sessions v0.14.0 [INFO] [stderr] Downloaded tower-sessions-sqlx-store v0.15.0 [INFO] [stderr] Downloaded windows-sys v0.61.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fb13e318aad6ec0b2528c57928383e1a0bbc30d16a93c7023bba35ed08b232e0 [INFO] running `Command { std: "docker" "start" "-a" "fb13e318aad6ec0b2528c57928383e1a0bbc30d16a93c7023bba35ed08b232e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fb13e318aad6ec0b2528c57928383e1a0bbc30d16a93c7023bba35ed08b232e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb13e318aad6ec0b2528c57928383e1a0bbc30d16a93c7023bba35ed08b232e0", kill_on_drop: false }` [INFO] [stdout] fb13e318aad6ec0b2528c57928383e1a0bbc30d16a93c7023bba35ed08b232e0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 64060f428d084cb65c457a78ef560ab50f62c2e50e1cc166f2c0c98bb823b015 [INFO] running `Command { std: "docker" "start" "-a" "64060f428d084cb65c457a78ef560ab50f62c2e50e1cc166f2c0c98bb823b015", kill_on_drop: false }` [INFO] [stderr] Compiling serde_core v1.0.225 [INFO] [stderr] Compiling serde v1.0.225 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Compiling find-msvc-tools v0.1.2 [INFO] [stderr] Compiling serde_derive v1.0.225 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Compiling zerofrom v0.1.6 [INFO] [stderr] Compiling stable_deref_trait v1.2.0 [INFO] [stderr] Checking indexmap v2.11.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling litemap v0.8.0 [INFO] [stderr] Compiling writeable v0.6.1 [INFO] [stderr] Compiling cc v1.2.38 [INFO] [stderr] Compiling yoke v0.8.0 [INFO] [stderr] Compiling zerovec v0.11.4 [INFO] [stderr] Compiling zerotrie v0.2.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling memchr v2.7.5 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Compiling icu_normalizer_data v2.0.0 [INFO] [stderr] Compiling icu_properties_data v2.0.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling socket2 v0.6.0 [INFO] [stderr] Compiling mio v1.0.4 [INFO] [stderr] Compiling zerocopy v0.8.27 [INFO] [stderr] Compiling bytes v1.10.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling deranged v0.5.3 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Compiling tracing-core v0.1.34 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling concurrent-queue v2.5.0 [INFO] [stderr] Compiling crc v3.3.0 [INFO] [stderr] Compiling tokio v1.47.1 [INFO] [stderr] Compiling event-listener v5.4.1 [INFO] [stderr] Compiling sha2 v0.10.9 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Compiling unicode-normalization v0.1.24 [INFO] [stderr] Compiling crossbeam-queue v0.3.12 [INFO] [stderr] Compiling hmac v0.12.1 [INFO] [stderr] Compiling tinystr v0.8.1 [INFO] [stderr] Compiling potential_utf v0.1.3 [INFO] [stderr] Compiling unicode-properties v0.1.3 [INFO] [stderr] Compiling icu_collections v2.0.0 [INFO] [stderr] Compiling icu_locale_core v2.0.0 [INFO] [stderr] Compiling hkdf v0.12.4 [INFO] [stderr] Compiling openssl v0.10.73 [INFO] [stderr] Compiling md-5 v0.10.6 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Compiling bitflags v2.9.4 [INFO] [stderr] Compiling time v0.3.44 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Compiling stringprep v0.1.5 [INFO] [stderr] Compiling icu_provider v2.0.0 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling icu_properties v2.0.1 [INFO] [stderr] Compiling ppv-lite86 v0.2.21 [INFO] [stderr] Compiling owo-colors v4.2.2 [INFO] [stderr] Checking nu-ansi-term v0.50.1 [INFO] [stderr] Compiling rustls v0.22.4 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Compiling color-spantrace v0.3.0 [INFO] [stderr] Checking home v0.5.11 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking axum-core v0.5.2 [INFO] [stderr] Checking object v0.36.7 [INFO] [stderr] Checking indenter v0.3.4 [INFO] [stderr] Checking http-range-header v0.4.2 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking webpki-roots v1.0.2 [INFO] [stderr] Compiling cookie v0.18.1 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking webpki-roots v0.26.11 [INFO] [stderr] Checking webpki-roots v0.25.4 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking tracing-subscriber v0.3.20 [INFO] [stderr] Compiling serenity v0.12.4 [INFO] [stderr] Checking regex-syntax v0.8.6 [INFO] [stderr] Compiling askama_parser v0.14.0 [INFO] [stderr] Compiling basic-toml v0.1.10 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Compiling futures-intrusive v0.5.0 [INFO] [stderr] Checking rustls-webpki v0.102.8 [INFO] [stderr] Compiling tokio-stream v0.1.17 [INFO] [stderr] Checking tracing-error v0.2.1 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking regex-automata v0.4.10 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking serde_cow v0.1.2 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Checking typemap_rev v0.3.0 [INFO] [stderr] Checking levenshtein v1.0.5 [INFO] [stderr] Checking uwl v0.6.0 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Compiling axum-macros v0.5.0 [INFO] [stderr] Compiling sqlx-core v0.8.6 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Checking backtrace v0.3.75 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Compiling poise_macros v0.6.1 [INFO] [stderr] Checking color-eyre v0.6.5 [INFO] [stderr] Checking regex v1.11.2 [INFO] [stderr] Compiling askama_derive v0.14.0 [INFO] [stderr] Checking tower-cookies v0.11.0 [INFO] [stderr] Checking tungstenite v0.21.0 [INFO] [stderr] Compiling command_attr v0.5.3 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling sqlx-postgres v0.8.6 [INFO] [stderr] Checking askama v0.14.0 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking tower-sessions-core v0.14.0 [INFO] [stderr] Checking tokio-tungstenite v0.21.0 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking tower-sessions-memory-store v0.14.0 [INFO] [stderr] Checking tower-sessions v0.14.0 [INFO] [stderr] Compiling sqlx-macros-core v0.8.6 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking hyper v1.7.0 [INFO] [stderr] Compiling sqlx-macros v0.8.6 [INFO] [stderr] Checking sqlx v0.8.6 [INFO] [stderr] Checking tower-sessions-sqlx-store v0.15.0 [INFO] [stderr] Checking hyper-util v0.1.17 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking axum v0.8.4 [INFO] [stderr] Checking reqwest v0.12.23 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking blaim-db v0.1.0 (/opt/rustwide/workdir/blaim-db) [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> blaim-db/src/lib.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | if let Some(x) = x { Some((x, s)) } else { None } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `x.map(|x| (x, s))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> blaim-db/src/lib.rs:75:26 [INFO] [stdout] | [INFO] [stdout] 75 | fn searcher_impl<'a>($var: &'a $ty) -> impl Iterator { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] ... [INFO] [stdout] 106 | / fuzzy_searcher!(Member, |member| { [INFO] [stdout] 107 | | [ [INFO] [stdout] 108 | | member.username.as_str(), [INFO] [stdout] 109 | | member.nick.as_ref().map_or("", |v| v), [INFO] [stdout] 110 | | ] [INFO] [stdout] 111 | | .into_iter() [INFO] [stdout] 112 | | }), [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] = note: this warning originates in the macro `fuzzy_searcher` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 75 - fn searcher_impl<'a>($var: &'a $ty) -> impl Iterator { [INFO] [stdout] 75 + fn searcher_impl($var: &$ty) -> impl Iterator { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> blaim-db/src/lib.rs:75:26 [INFO] [stdout] | [INFO] [stdout] 75 | fn searcher_impl<'a>($var: &'a $ty) -> impl Iterator { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] ... [INFO] [stdout] 144 | fuzzy_searcher_once!(Location, |location| location.name.as_str()), [INFO] [stdout] | ----------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: this warning originates in the macro `fuzzy_searcher` which comes from the expansion of the macro `fuzzy_searcher_once` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 75 - fn searcher_impl<'a>($var: &'a $ty) -> impl Iterator { [INFO] [stdout] 75 + fn searcher_impl($var: &$ty) -> impl Iterator { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> blaim-db/src/lib.rs:75:26 [INFO] [stdout] | [INFO] [stdout] 75 | fn searcher_impl<'a>($var: &'a $ty) -> impl Iterator { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] ... [INFO] [stdout] 181 | fuzzy_searcher_once!(Item, |i| i.name.as_str()), [INFO] [stdout] | ----------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: this warning originates in the macro `fuzzy_searcher` which comes from the expansion of the macro `fuzzy_searcher_once` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 75 - fn searcher_impl<'a>($var: &'a $ty) -> impl Iterator { [INFO] [stdout] 75 + fn searcher_impl($var: &$ty) -> impl Iterator { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> blaim-db/src/lib.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | if let Some(x) = x { Some((x, s)) } else { None } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `x.map(|x| (x, s))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> blaim-db/src/lib.rs:75:26 [INFO] [stdout] | [INFO] [stdout] 75 | fn searcher_impl<'a>($var: &'a $ty) -> impl Iterator { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] ... [INFO] [stdout] 106 | / fuzzy_searcher!(Member, |member| { [INFO] [stdout] 107 | | [ [INFO] [stdout] 108 | | member.username.as_str(), [INFO] [stdout] 109 | | member.nick.as_ref().map_or("", |v| v), [INFO] [stdout] 110 | | ] [INFO] [stdout] 111 | | .into_iter() [INFO] [stdout] 112 | | }), [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] = note: this warning originates in the macro `fuzzy_searcher` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 75 - fn searcher_impl<'a>($var: &'a $ty) -> impl Iterator { [INFO] [stdout] 75 + fn searcher_impl($var: &$ty) -> impl Iterator { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> blaim-db/src/lib.rs:75:26 [INFO] [stdout] | [INFO] [stdout] 75 | fn searcher_impl<'a>($var: &'a $ty) -> impl Iterator { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] ... [INFO] [stdout] 144 | fuzzy_searcher_once!(Location, |location| location.name.as_str()), [INFO] [stdout] | ----------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: this warning originates in the macro `fuzzy_searcher` which comes from the expansion of the macro `fuzzy_searcher_once` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 75 - fn searcher_impl<'a>($var: &'a $ty) -> impl Iterator { [INFO] [stdout] 75 + fn searcher_impl($var: &$ty) -> impl Iterator { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> blaim-db/src/lib.rs:75:26 [INFO] [stdout] | [INFO] [stdout] 75 | fn searcher_impl<'a>($var: &'a $ty) -> impl Iterator { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] ... [INFO] [stdout] 181 | fuzzy_searcher_once!(Item, |i| i.name.as_str()), [INFO] [stdout] | ----------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: this warning originates in the macro `fuzzy_searcher` which comes from the expansion of the macro `fuzzy_searcher_once` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 75 - fn searcher_impl<'a>($var: &'a $ty) -> impl Iterator { [INFO] [stdout] 75 + fn searcher_impl($var: &$ty) -> impl Iterator { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking blaim-web v0.1.0 (/opt/rustwide/workdir/blaim-web) [INFO] [stderr] Checking poise v0.6.1 [INFO] [stderr] Checking blaim v0.1.0 (/opt/rustwide/workdir/blaim) [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> blaim/src/main.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | / format!( [INFO] [stdout] 35 | | "{}", [INFO] [stdout] 36 | | blaim_db::find_location_name(connection, owner) [INFO] [stdout] 37 | | .await [INFO] [stdout] ... | [INFO] [stdout] 40 | | .name [INFO] [stdout] 41 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] help: consider using `.to_string()` [INFO] [stdout] | [INFO] [stdout] 34 ~ blaim_db::find_location_name(connection, owner) [INFO] [stdout] 35 + .await [INFO] [stdout] 36 + .unwrap() [INFO] [stdout] 37 + .unwrap() [INFO] [stdout] 38 + .name.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> blaim/src/main.rs:129:8 [INFO] [stdout] | [INFO] [stdout] 129 | if present_updates.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!present_updates.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> blaim/src/main.rs:157:8 [INFO] [stdout] | [INFO] [stdout] 157 | if alternatives.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!alternatives.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> blaim/src/main.rs:165:30 [INFO] [stdout] | [INFO] [stdout] 165 | ... .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:234:61 [INFO] [stdout] | [INFO] [stdout] 234 | let (embed_, components) = recreate(&state, &mut *transaction, item_id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:290:39 [INFO] [stdout] | [INFO] [stdout] 290 | let items = blaim_db::lookup_item(&mut *transaction, &item).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:306:52 [INFO] [stdout] | [INFO] [stdout] 306 | let previous_owner = blaim_db::get_last_holder(&mut *transaction, selected.id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> blaim/src/main.rs:329:17 [INFO] [stdout] | [INFO] [stdout] 329 | -> Pin< [INFO] [stdout] | _________________^ [INFO] [stdout] 330 | | Box< [INFO] [stdout] 331 | | dyn Future)>> [INFO] [stdout] 332 | | + Send [INFO] [stdout] 333 | | + 'a, [INFO] [stdout] 334 | | >, [INFO] [stdout] 335 | | > { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> blaim/src/main.rs:348:17 [INFO] [stdout] | [INFO] [stdout] 348 | &selected, [INFO] [stdout] | ^^^^^^^^^ help: change this to: `selected` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:365:44 [INFO] [stdout] | [INFO] [stdout] 365 | let (embed, components) = task(&state, &mut *transaction, selected_id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:402:45 [INFO] [stdout] | [INFO] [stdout] 402 | let items = blaim_db::get_itemtrees(&mut *connection, user.id.to_string()).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `&mut connection` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:418:49 [INFO] [stdout] | [INFO] [stdout] 418 | let items = blaim_db::get_all_itemtrees(&mut *connection).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `&mut connection` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:465:38 [INFO] [stdout] | [INFO] [stdout] 465 | let item = blaim_db::lookup_item(&mut *connection, &item).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `&mut connection` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:480:44 [INFO] [stdout] | [INFO] [stdout] 480 | let history = blaim_db::borrow_history(&mut *connection, item.id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `&mut connection` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:494:37 [INFO] [stdout] | [INFO] [stdout] 494 | borrowers.push(format_owner(&mut *connection, borrower).await + "\n") [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `&mut connection` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:498:43 [INFO] [stdout] | [INFO] [stdout] 498 | let parent_box = blaim_db::parent_box(&mut *connection, item).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `&mut connection` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:506:30 [INFO] [stdout] | [INFO] [stdout] 506 | format_owner(&mut *connection, &history.first().unwrap().0).await, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `&mut connection` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:624:39 [INFO] [stdout] | [INFO] [stdout] 624 | let items = blaim_db::lookup_item(&mut *transaction, &item).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:642:51 [INFO] [stdout] | [INFO] [stdout] 642 | let Some(location) = blaim_db::lookup_storage(&mut *transaction, &location) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:657:43 [INFO] [stdout] | [INFO] [stdout] 657 | let owner = blaim_db::get_last_holder(&mut *transaction, selected.id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> blaim/src/main.rs:672:12 [INFO] [stdout] | [INFO] [stdout] 672 | && owner.strip_prefix("loc:").unwrap_or(owner) == &location.strid [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `location.strid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> blaim/src/main.rs:692:17 [INFO] [stdout] | [INFO] [stdout] 692 | -> Pin< [INFO] [stdout] | _________________^ [INFO] [stdout] 693 | | Box< [INFO] [stdout] 694 | | dyn Future)>> [INFO] [stdout] 695 | | + Send [INFO] [stdout] 696 | | + 'a, [INFO] [stdout] 697 | | >, [INFO] [stdout] 698 | | > { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> blaim/src/main.rs:711:17 [INFO] [stdout] | [INFO] [stdout] 711 | &selected, [INFO] [stdout] | ^^^^^^^^^ help: change this to: `selected` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:733:44 [INFO] [stdout] | [INFO] [stdout] 733 | let (embed, components) = task(&state, &mut *transaction, selected.id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:774:39 [INFO] [stdout] | [INFO] [stdout] 774 | let items = blaim_db::lookup_item(&mut *transaction, &item).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:790:43 [INFO] [stdout] | [INFO] [stdout] 790 | let owner = blaim_db::get_last_holder(&mut *transaction, selected.id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> blaim/src/main.rs:825:17 [INFO] [stdout] | [INFO] [stdout] 825 | -> Pin< [INFO] [stdout] | _________________^ [INFO] [stdout] 826 | | Box< [INFO] [stdout] 827 | | dyn Future)>> [INFO] [stdout] 828 | | + Send [INFO] [stdout] 829 | | + 'a, [INFO] [stdout] 830 | | >, [INFO] [stdout] 831 | | > { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> blaim/src/main.rs:843:17 [INFO] [stdout] | [INFO] [stdout] 843 | &selected, [INFO] [stdout] | ^^^^^^^^^ help: change this to: `selected` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:859:44 [INFO] [stdout] | [INFO] [stdout] 859 | let (embed, components) = task(&state, &mut *transaction, selected.id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:926:39 [INFO] [stdout] | [INFO] [stdout] 926 | let items = blaim_db::lookup_item(&mut *transaction, &item).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> blaim/src/main.rs:945:17 [INFO] [stdout] | [INFO] [stdout] 945 | -> Pin< [INFO] [stdout] | _________________^ [INFO] [stdout] 946 | | Box< [INFO] [stdout] 947 | | dyn Future)>> [INFO] [stdout] 948 | | + Send [INFO] [stdout] 949 | | + 'a, [INFO] [stdout] 950 | | >, [INFO] [stdout] 951 | | > { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> blaim/src/main.rs:970:16 [INFO] [stdout] | [INFO] [stdout] 970 | if alternatives.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!alternatives.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:1016:44 [INFO] [stdout] | [INFO] [stdout] 1016 | let (embed, components) = task(&state, &mut *transaction, selected.id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> blaim/src/main.rs:1097:17 [INFO] [stdout] | [INFO] [stdout] 1097 | let found = blaim_db::lookup_item(&mut *pool.acquire().await?, &item) [INFO] [stdout] | _________________^ [INFO] [stdout] 1098 | | .await? [INFO] [stdout] 1099 | | .into_iter() [INFO] [stdout] 1100 | | .nth(0); [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] help: try calling `.next()` instead of `.nth(0)` [INFO] [stdout] | [INFO] [stdout] 1097 ~ let found = blaim_db::lookup_item(&mut *pool.acquire().await?, &item) [INFO] [stdout] 1098 + .await? [INFO] [stdout] 1099 ~ .into_iter().next(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `lookup_item_retaining_query` doesn't need a mutable reference [INFO] [stdout] --> blaim/src/main.rs:1137:55 [INFO] [stdout] | [INFO] [stdout] 1137 | .map(|it| lookup_item_retaining_query(it, &mut &ctx.data().pool)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 1137 - .map(|it| lookup_item_retaining_query(it, &mut &ctx.data().pool)), [INFO] [stdout] 1137 + .map(|it| lookup_item_retaining_query(it, &&ctx.data().pool)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> blaim/src/main.rs:1137:55 [INFO] [stdout] | [INFO] [stdout] 1137 | .map(|it| lookup_item_retaining_query(it, &mut &ctx.data().pool)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&ctx.data().pool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> blaim/src/main.rs:1153:12 [INFO] [stdout] | [INFO] [stdout] 1153 | if let Some(_) = errors.peek() { [INFO] [stdout] | -------^^^^^^^---------------- help: try: `if errors.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:1170:9 [INFO] [stdout] | [INFO] [stdout] 1170 | &mut *transaction, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> blaim/src/main.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | / format!( [INFO] [stdout] 35 | | "{}", [INFO] [stdout] 36 | | blaim_db::find_location_name(connection, owner) [INFO] [stdout] 37 | | .await [INFO] [stdout] ... | [INFO] [stdout] 40 | | .name [INFO] [stdout] 41 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] help: consider using `.to_string()` [INFO] [stdout] | [INFO] [stdout] 34 ~ blaim_db::find_location_name(connection, owner) [INFO] [stdout] 35 + .await [INFO] [stdout] 36 + .unwrap() [INFO] [stdout] 37 + .unwrap() [INFO] [stdout] 38 + .name.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> blaim/src/main.rs:129:8 [INFO] [stdout] | [INFO] [stdout] 129 | if present_updates.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!present_updates.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> blaim/src/main.rs:157:8 [INFO] [stdout] | [INFO] [stdout] 157 | if alternatives.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!alternatives.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> blaim/src/main.rs:165:30 [INFO] [stdout] | [INFO] [stdout] 165 | ... .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:234:61 [INFO] [stdout] | [INFO] [stdout] 234 | let (embed_, components) = recreate(&state, &mut *transaction, item_id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `lookup_item_retaining_query` doesn't need a mutable reference [INFO] [stdout] --> blaim/src/main.rs:1231:55 [INFO] [stdout] | [INFO] [stdout] 1231 | .map(|it| lookup_item_retaining_query(it, &mut &ctx.data().pool)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 1231 - .map(|it| lookup_item_retaining_query(it, &mut &ctx.data().pool)), [INFO] [stdout] 1231 + .map(|it| lookup_item_retaining_query(it, &&ctx.data().pool)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> blaim/src/main.rs:1231:55 [INFO] [stdout] | [INFO] [stdout] 1231 | .map(|it| lookup_item_retaining_query(it, &mut &ctx.data().pool)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&ctx.data().pool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> blaim/src/main.rs:1246:12 [INFO] [stdout] | [INFO] [stdout] 1246 | if let Some(_) = errors.peek() { [INFO] [stdout] | -------^^^^^^^---------------- help: try: `if errors.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:1262:43 [INFO] [stdout] | [INFO] [stdout] 1262 | if let Err(err) = blaim_db::unbox_all(&mut *transaction, box_item, items).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:290:39 [INFO] [stdout] | [INFO] [stdout] 290 | let items = blaim_db::lookup_item(&mut *transaction, &item).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:306:52 [INFO] [stdout] | [INFO] [stdout] 306 | let previous_owner = blaim_db::get_last_holder(&mut *transaction, selected.id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> blaim/src/main.rs:329:17 [INFO] [stdout] | [INFO] [stdout] 329 | -> Pin< [INFO] [stdout] | _________________^ [INFO] [stdout] 330 | | Box< [INFO] [stdout] 331 | | dyn Future)>> [INFO] [stdout] 332 | | + Send [INFO] [stdout] 333 | | + 'a, [INFO] [stdout] 334 | | >, [INFO] [stdout] 335 | | > { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> blaim/src/main.rs:348:17 [INFO] [stdout] | [INFO] [stdout] 348 | &selected, [INFO] [stdout] | ^^^^^^^^^ help: change this to: `selected` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:365:44 [INFO] [stdout] | [INFO] [stdout] 365 | let (embed, components) = task(&state, &mut *transaction, selected_id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:402:45 [INFO] [stdout] | [INFO] [stdout] 402 | let items = blaim_db::get_itemtrees(&mut *connection, user.id.to_string()).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `&mut connection` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:418:49 [INFO] [stdout] | [INFO] [stdout] 418 | let items = blaim_db::get_all_itemtrees(&mut *connection).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `&mut connection` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:465:38 [INFO] [stdout] | [INFO] [stdout] 465 | let item = blaim_db::lookup_item(&mut *connection, &item).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `&mut connection` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:480:44 [INFO] [stdout] | [INFO] [stdout] 480 | let history = blaim_db::borrow_history(&mut *connection, item.id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `&mut connection` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:494:37 [INFO] [stdout] | [INFO] [stdout] 494 | borrowers.push(format_owner(&mut *connection, borrower).await + "\n") [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `&mut connection` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:498:43 [INFO] [stdout] | [INFO] [stdout] 498 | let parent_box = blaim_db::parent_box(&mut *connection, item).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `&mut connection` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:506:30 [INFO] [stdout] | [INFO] [stdout] 506 | format_owner(&mut *connection, &history.first().unwrap().0).await, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `&mut connection` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `iter_partition_in_place` is declared but not used [INFO] [stdout] --> blaim/src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(iter_partition_in_place)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_features)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:624:39 [INFO] [stdout] | [INFO] [stdout] 624 | let items = blaim_db::lookup_item(&mut *transaction, &item).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:642:51 [INFO] [stdout] | [INFO] [stdout] 642 | let Some(location) = blaim_db::lookup_storage(&mut *transaction, &location) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:657:43 [INFO] [stdout] | [INFO] [stdout] 657 | let owner = blaim_db::get_last_holder(&mut *transaction, selected.id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: taken reference of right operand [INFO] [stdout] --> blaim/src/main.rs:672:12 [INFO] [stdout] | [INFO] [stdout] 672 | && owner.strip_prefix("loc:").unwrap_or(owner) == &location.strid [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--------------- [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `location.strid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> blaim/src/main.rs:692:17 [INFO] [stdout] | [INFO] [stdout] 692 | -> Pin< [INFO] [stdout] | _________________^ [INFO] [stdout] 693 | | Box< [INFO] [stdout] 694 | | dyn Future)>> [INFO] [stdout] 695 | | + Send [INFO] [stdout] 696 | | + 'a, [INFO] [stdout] 697 | | >, [INFO] [stdout] 698 | | > { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> blaim/src/main.rs:711:17 [INFO] [stdout] | [INFO] [stdout] 711 | &selected, [INFO] [stdout] | ^^^^^^^^^ help: change this to: `selected` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:733:44 [INFO] [stdout] | [INFO] [stdout] 733 | let (embed, components) = task(&state, &mut *transaction, selected.id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:774:39 [INFO] [stdout] | [INFO] [stdout] 774 | let items = blaim_db::lookup_item(&mut *transaction, &item).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:790:43 [INFO] [stdout] | [INFO] [stdout] 790 | let owner = blaim_db::get_last_holder(&mut *transaction, selected.id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> blaim/src/main.rs:825:17 [INFO] [stdout] | [INFO] [stdout] 825 | -> Pin< [INFO] [stdout] | _________________^ [INFO] [stdout] 826 | | Box< [INFO] [stdout] 827 | | dyn Future)>> [INFO] [stdout] 828 | | + Send [INFO] [stdout] 829 | | + 'a, [INFO] [stdout] 830 | | >, [INFO] [stdout] 831 | | > { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> blaim/src/main.rs:843:17 [INFO] [stdout] | [INFO] [stdout] 843 | &selected, [INFO] [stdout] | ^^^^^^^^^ help: change this to: `selected` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:859:44 [INFO] [stdout] | [INFO] [stdout] 859 | let (embed, components) = task(&state, &mut *transaction, selected.id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:926:39 [INFO] [stdout] | [INFO] [stdout] 926 | let items = blaim_db::lookup_item(&mut *transaction, &item).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> blaim/src/main.rs:945:17 [INFO] [stdout] | [INFO] [stdout] 945 | -> Pin< [INFO] [stdout] | _________________^ [INFO] [stdout] 946 | | Box< [INFO] [stdout] 947 | | dyn Future)>> [INFO] [stdout] 948 | | + Send [INFO] [stdout] 949 | | + 'a, [INFO] [stdout] 950 | | >, [INFO] [stdout] 951 | | > { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> blaim/src/main.rs:970:16 [INFO] [stdout] | [INFO] [stdout] 970 | if alternatives.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!alternatives.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:1016:44 [INFO] [stdout] | [INFO] [stdout] 1016 | let (embed, components) = task(&state, &mut *transaction, selected.id).await?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent [INFO] [stdout] --> blaim/src/main.rs:1097:17 [INFO] [stdout] | [INFO] [stdout] 1097 | let found = blaim_db::lookup_item(&mut *pool.acquire().await?, &item) [INFO] [stdout] | _________________^ [INFO] [stdout] 1098 | | .await? [INFO] [stdout] 1099 | | .into_iter() [INFO] [stdout] 1100 | | .nth(0); [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero [INFO] [stdout] = note: `#[warn(clippy::iter_nth_zero)]` on by default [INFO] [stdout] help: try calling `.next()` instead of `.nth(0)` [INFO] [stdout] | [INFO] [stdout] 1097 ~ let found = blaim_db::lookup_item(&mut *pool.acquire().await?, &item) [INFO] [stdout] 1098 + .await? [INFO] [stdout] 1099 ~ .into_iter().next(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `lookup_item_retaining_query` doesn't need a mutable reference [INFO] [stdout] --> blaim/src/main.rs:1137:55 [INFO] [stdout] | [INFO] [stdout] 1137 | .map(|it| lookup_item_retaining_query(it, &mut &ctx.data().pool)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 1137 - .map(|it| lookup_item_retaining_query(it, &mut &ctx.data().pool)), [INFO] [stdout] 1137 + .map(|it| lookup_item_retaining_query(it, &&ctx.data().pool)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> blaim/src/main.rs:1137:55 [INFO] [stdout] | [INFO] [stdout] 1137 | .map(|it| lookup_item_retaining_query(it, &mut &ctx.data().pool)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&ctx.data().pool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> blaim/src/main.rs:1153:12 [INFO] [stdout] | [INFO] [stdout] 1153 | if let Some(_) = errors.peek() { [INFO] [stdout] | -------^^^^^^^---------------- help: try: `if errors.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:1170:9 [INFO] [stdout] | [INFO] [stdout] 1170 | &mut *transaction, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `lookup_item_retaining_query` doesn't need a mutable reference [INFO] [stdout] --> blaim/src/main.rs:1231:55 [INFO] [stdout] | [INFO] [stdout] 1231 | .map(|it| lookup_item_retaining_query(it, &mut &ctx.data().pool)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 1231 - .map(|it| lookup_item_retaining_query(it, &mut &ctx.data().pool)), [INFO] [stdout] 1231 + .map(|it| lookup_item_retaining_query(it, &&ctx.data().pool)), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> blaim/src/main.rs:1231:55 [INFO] [stdout] | [INFO] [stdout] 1231 | .map(|it| lookup_item_retaining_query(it, &mut &ctx.data().pool)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&ctx.data().pool` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_some()` [INFO] [stdout] --> blaim/src/main.rs:1246:12 [INFO] [stdout] | [INFO] [stdout] 1246 | if let Some(_) = errors.peek() { [INFO] [stdout] | -------^^^^^^^---------------- help: try: `if errors.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> blaim/src/main.rs:1262:43 [INFO] [stdout] | [INFO] [stdout] 1262 | if let Err(err) = blaim_db::unbox_all(&mut *transaction, box_item, items).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `&mut transaction` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: feature `iter_partition_in_place` is declared but not used [INFO] [stdout] --> blaim/src/main.rs:1:12 [INFO] [stdout] | [INFO] [stdout] 1 | #![feature(iter_partition_in_place)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_features)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 29s [INFO] running `Command { std: "docker" "inspect" "64060f428d084cb65c457a78ef560ab50f62c2e50e1cc166f2c0c98bb823b015", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "64060f428d084cb65c457a78ef560ab50f62c2e50e1cc166f2c0c98bb823b015", kill_on_drop: false }` [INFO] [stdout] 64060f428d084cb65c457a78ef560ab50f62c2e50e1cc166f2c0c98bb823b015