[INFO] cloning repository https://github.com/Stinners/portal [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Stinners/portal" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FStinners%2Fportal", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FStinners%2Fportal'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 66b06391757178c497e03310087294a3483250b0 [INFO] linting Stinners/portal/66b06391757178c497e03310087294a3483250b0 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FStinners%2Fportal" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Stinners/portal [INFO] finished tweaking git repo https://github.com/Stinners/portal [INFO] tweaked toml for git repo https://github.com/Stinners/portal written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Stinners/portal on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Stinners/portal already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded dtoa v0.4.2 [INFO] [stderr] Downloaded itoa v0.4.1 [INFO] [stderr] Downloaded quote v0.4.2 [INFO] [stderr] Downloaded serde_derive v1.0.36 [INFO] [stderr] Downloaded serde_json v1.0.13 [INFO] [stderr] Downloaded lazy_static v1.0.0 [INFO] [stderr] Downloaded redox_syscall v0.1.37 [INFO] [stderr] Downloaded bitflags v1.0.1 [INFO] [stderr] Downloaded atty v0.2.8 [INFO] [stderr] Downloaded proc-macro2 v0.2.3 [INFO] [stderr] Downloaded textwrap v0.9.0 [INFO] [stderr] Downloaded ansi_term v0.11.0 [INFO] [stderr] Downloaded num-traits v0.2.2 [INFO] [stderr] Downloaded strsim v0.7.0 [INFO] [stderr] Downloaded serde v1.0.36 [INFO] [stderr] Downloaded serde_derive_internals v0.22.2 [INFO] [stderr] Downloaded syn v0.12.15 [INFO] [stderr] Downloaded unicode-width v0.1.4 [INFO] [stderr] Downloaded clap v2.31.2 [INFO] [stderr] Downloaded vec_map v0.8.0 [INFO] [stderr] Downloaded libc v0.2.40 [INFO] [stderr] Downloaded winapi v0.3.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 65d317596c132f475a74bd4714b741b9f8f2a1e2802107935c98d2c2995743a2 [INFO] running `Command { std: "docker" "start" "-a" "65d317596c132f475a74bd4714b741b9f8f2a1e2802107935c98d2c2995743a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "65d317596c132f475a74bd4714b741b9f8f2a1e2802107935c98d2c2995743a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "65d317596c132f475a74bd4714b741b9f8f2a1e2802107935c98d2c2995743a2", kill_on_drop: false }` [INFO] [stdout] 65d317596c132f475a74bd4714b741b9f8f2a1e2802107935c98d2c2995743a2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a17904dbac09f75c9f7363156f1142fa8fd075981989e128f53702d9ec5d2dfc [INFO] running `Command { std: "docker" "start" "-a" "a17904dbac09f75c9f7363156f1142fa8fd075981989e128f53702d9ec5d2dfc", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling proc-macro2 v0.2.3 [INFO] [stderr] Checking libc v0.2.40 [INFO] [stderr] Checking unicode-width v0.1.4 [INFO] [stderr] Checking serde v1.0.36 [INFO] [stderr] Checking bitflags v1.0.1 [INFO] [stderr] Checking dtoa v0.4.2 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Checking num-traits v0.2.2 [INFO] [stderr] Checking textwrap v0.9.0 [INFO] [stderr] Checking vec_map v0.8.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking itoa v0.4.1 [INFO] [stderr] Checking lazy_static v1.0.0 [INFO] [stderr] Checking atty v0.2.8 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Compiling quote v0.4.2 [INFO] [stderr] Compiling syn v0.12.15 [INFO] [stderr] Compiling serde_derive_internals v0.22.2 [INFO] [stderr] Compiling serde_derive v1.0.36 [INFO] [stderr] Checking serde_json v1.0.13 [INFO] [stderr] Checking portal v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error[E0432]: unresolved import `database::normalize_path` [INFO] [stdout] --> src/main.rs:112:8 [INFO] [stdout] | [INFO] [stdout] 112 | use::database::normalize_path; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ no `normalize_path` in `database` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/settings.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | / lazy_static! { [INFO] [stdout] 7 | | pub static ref SETTINGS: Settings = { [INFO] [stdout] 8 | | let home_dir = env::home_dir().unwrap(); [INFO] [stdout] 9 | | let path = home_dir.join(PathBuf::from(".config/portal/settings.json")); [INFO] [stdout] 10 | | Settings::fetch(&path).unwrap() [INFO] [stdout] 11 | | }; [INFO] [stdout] 12 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/state.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / lazy_static! { [INFO] [stdout] 8 | | pub static ref STATE: State = State::fetch(&SETTINGS.state_file).unwrap(); [INFO] [stdout] 9 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] For more information about this error, try `rustc --explain E0432`. [INFO] [stdout] [INFO] [stderr] error: could not compile `portal` (bin "portal" test) due to 1 previous error; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/settings.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | / lazy_static! { [INFO] [stdout] 7 | | pub static ref SETTINGS: Settings = { [INFO] [stdout] 8 | | let home_dir = env::home_dir().unwrap(); [INFO] [stdout] 9 | | let path = home_dir.join(PathBuf::from(".config/portal/settings.json")); [INFO] [stdout] 10 | | Settings::fetch(&path).unwrap() [INFO] [stdout] 11 | | }; [INFO] [stdout] 12 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/state.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / lazy_static! { [INFO] [stdout] 8 | | pub static ref STATE: State = State::fetch(&SETTINGS.state_file).unwrap(); [INFO] [stdout] 9 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this let-binding has unit value [INFO] [stdout] --> src/database.rs:81:5 [INFO] [stdout] | [INFO] [stdout] 81 | let _ = add_value(database, &new_dir); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stdout] = note: `#[warn(clippy::let_unit_value)]` on by default [INFO] [stdout] help: omit the `let` binding [INFO] [stdout] | [INFO] [stdout] 81 - let _ = add_value(database, &new_dir); [INFO] [stdout] 81 + add_value(database, &new_dir); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::path::PathBuf` [INFO] [stdout] --> src/main.rs:61:20 [INFO] [stdout] | [INFO] [stdout] 61 | let step = PathBuf::from(step); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `step` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/settings.rs:14:17 [INFO] [stdout] | [INFO] [stdout] 14 | #[derive(Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `Settings` is not local [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Settings` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/settings.rs:14:28 [INFO] [stdout] | [INFO] [stdout] 14 | #[derive(Clone, Serialize, Deserialize)] [INFO] [stdout] | -^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `Settings` is not local [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Settings` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/state.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | #[derive(Clone, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `State` is not local [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_State` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/state.rs:11:28 [INFO] [stdout] | [INFO] [stdout] 11 | #[derive(Clone, Serialize, Deserialize)] [INFO] [stdout] | -^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `State` is not local [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_State` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "a17904dbac09f75c9f7363156f1142fa8fd075981989e128f53702d9ec5d2dfc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a17904dbac09f75c9f7363156f1142fa8fd075981989e128f53702d9ec5d2dfc", kill_on_drop: false }` [INFO] [stdout] a17904dbac09f75c9f7363156f1142fa8fd075981989e128f53702d9ec5d2dfc