[INFO] cloning repository https://github.com/Starflight-code/starbot [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Starflight-code/starbot" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FStarflight-code%2Fstarbot", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FStarflight-code%2Fstarbot'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b9247652e13b9f3f22d21d61da9230f8d31dbfd1 [INFO] linting Starflight-code/starbot against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FStarflight-code%2Fstarbot" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Starflight-code/starbot [INFO] finished tweaking git repo https://github.com/Starflight-code/starbot [INFO] tweaked toml for git repo https://github.com/Starflight-code/starbot written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Starflight-code/starbot on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Starflight-code/starbot already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded command_attr v0.5.3 [INFO] [stderr] Downloaded croner v2.1.0 [INFO] [stderr] Downloaded migrations_internals v2.2.0 [INFO] [stderr] Downloaded rustls-webpki v0.102.5 [INFO] [stderr] Downloaded rustls v0.23.11 [INFO] [stderr] Downloaded diesel v2.2.8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e31ca4df94d12e77ae6b30965385130782f604df3411102a467b5832c5cb1315 [INFO] running `Command { std: "docker" "start" "-a" "e31ca4df94d12e77ae6b30965385130782f604df3411102a467b5832c5cb1315", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e31ca4df94d12e77ae6b30965385130782f604df3411102a467b5832c5cb1315", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e31ca4df94d12e77ae6b30965385130782f604df3411102a467b5832c5cb1315", kill_on_drop: false }` [INFO] [stdout] e31ca4df94d12e77ae6b30965385130782f604df3411102a467b5832c5cb1315 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ab76ea9d9ea40ca617264b1b912aac8a885bd707d7f5e3638b3bb5d80123ed84 [INFO] running `Command { std: "docker" "start" "-a" "ab76ea9d9ea40ca617264b1b912aac8a885bd707d7f5e3638b3bb5d80123ed84", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling cc v1.2.17 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling syn v2.0.71 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling rustls v0.22.4 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling openssl v0.10.70 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Compiling winnow v0.6.20 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking lock_api v0.4.12 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking webpki-roots v0.26.3 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling serenity v0.12.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling command_attr v0.5.3 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking uwl v0.6.0 [INFO] [stderr] Checking levenshtein v1.0.5 [INFO] [stderr] Checking typemap_rev v0.3.0 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Checking rand v0.9.0 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling openssl-sys v0.9.105 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling diesel_table_macro_syntax v0.2.0 [INFO] [stderr] Checking rustls-webpki v0.102.5 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking tokio v1.44.1 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling dsl_auto_type v0.1.2 [INFO] [stderr] Compiling poise_macros v0.6.1 [INFO] [stderr] Compiling diesel_derives v2.2.3 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_spanned v0.6.8 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking chrono v0.4.40 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking serde_cow v0.1.2 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking tungstenite v0.21.0 [INFO] [stderr] Checking diesel v2.2.8 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking tokio-tungstenite v0.21.0 [INFO] [stderr] Checking croner v2.1.0 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking migrations_internals v2.2.0 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Compiling migrations_macros v2.2.0 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.10 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.15 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking diesel_migrations v2.2.0 [INFO] [stderr] Checking poise v0.6.1 [INFO] [stderr] Checking starbot v1.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/monitor.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | history_state: history_state, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `history_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/scheduler_data.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 69 | lastids: lastids, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `lastids` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/monitor.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | history_state: history_state, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `history_state` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/scheduler_data.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 69 | lastids: lastids, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `lastids` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `cache` after checking its variant with `is_some` [INFO] [stdout] --> src/api.rs:61:20 [INFO] [stdout] | [INFO] [stdout] 60 | let json = if cache.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = cache` [INFO] [stdout] 61 | let json = cache.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/api.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | return Ok(post); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 - return Ok(post); [INFO] [stdout] 147 + Ok(post) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/api.rs:70:16 [INFO] [stdout] | [INFO] [stdout] 70 | if let Err(_) = json_response { [INFO] [stdout] | -------^^^^^^---------------- help: try: `if json_response.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/api.rs:75:16 [INFO] [stdout] | [INFO] [stdout] 75 | if let Err(_) = json_response { [INFO] [stdout] | -------^^^^^^---------------- help: try: `if json_response.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/api.rs:111:16 [INFO] [stdout] | [INFO] [stdout] 111 | if json["data"]["children"][randint]["data"]["subreddit"].to_string() == "null" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `json["data"]["children"][randint]["data"]["subreddit"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/api.rs:153:12 [INFO] [stdout] | [INFO] [stdout] 153 | if let Err(_) = json_response { [INFO] [stdout] | -------^^^^^^---------------- help: try: `if json_response.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/api.rs:158:12 [INFO] [stdout] | [INFO] [stdout] 158 | if let Err(_) = json_response { [INFO] [stdout] | -------^^^^^^---------------- help: try: `if json_response.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/api.rs:164:30 [INFO] [stdout] | [INFO] [stdout] 164 | serde_json::from_str(&json_response.as_str()).expect("JSON Deserialization Error"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `json_response.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/api.rs:190:5 [INFO] [stdout] | [INFO] [stdout] 190 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 190 - return false; [INFO] [stdout] 190 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/api.rs:177:27 [INFO] [stdout] | [INFO] [stdout] 177 | let param_extension = url [INFO] [stdout] | ___________________________^ [INFO] [stdout] 178 | | .trim() [INFO] [stdout] 179 | | .split('.') [INFO] [stdout] 180 | | .last() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 180 - .last() [INFO] [stdout] 180 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/database.rs:30:33 [INFO] [stdout] | [INFO] [stdout] 30 | SqliteConnection::establish(&database_url) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `database_url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `post.image_link` after checking its variant with `is_some` [INFO] [stdout] --> src/discord.rs:14:37 [INFO] [stdout] | [INFO] [stdout] 13 | if post.image_link.is_some() { [INFO] [stdout] | ---------------------------- help: try: `if let Some() = post.image_link` [INFO] [stdout] 14 | embed = embed.clone().image(post.image_link.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `post.url` after checking its variant with `is_some` [INFO] [stdout] --> src/discord.rs:17:35 [INFO] [stdout] | [INFO] [stdout] 16 | if post.url.is_some() { [INFO] [stdout] | --------------------- help: try: `if let Some() = post.url` [INFO] [stdout] 17 | embed = embed.clone().url(post.url.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/discord.rs:7:16 [INFO] [stdout] | [INFO] [stdout] 7 | .title(format!("{}", post.title)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `post.title.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/discord.rs:8:22 [INFO] [stdout] | [INFO] [stdout] 8 | .description(format!("{}", post.body)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `post.body.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memcache.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | return self.expiration < Utc::now(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return self.expiration < Utc::now(); [INFO] [stdout] 13 + self.expiration < Utc::now() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Memcache` [INFO] [stdout] --> src/memcache.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | / pub fn new() -> Memcache { [INFO] [stdout] 33 | | return Memcache { [INFO] [stdout] 34 | | cache: HashMap::new(), [INFO] [stdout] 35 | | }; [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 25 + impl Default for Memcache { [INFO] [stdout] 26 + fn default() -> Self { [INFO] [stdout] 27 + Self::new() [INFO] [stdout] 28 + } [INFO] [stdout] 29 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/memcache.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 28 | if !value.is_none() && value.unwrap().is_expired() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `value.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memcache.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | / return Memcache { [INFO] [stdout] 34 | | cache: HashMap::new(), [INFO] [stdout] 35 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 ~ Memcache { [INFO] [stdout] 34 + cache: HashMap::new(), [INFO] [stdout] 35 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memcache.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | return Some(&value.unwrap().json); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return Some(&value.unwrap().json); [INFO] [stdout] 55 + Some(&value.unwrap().json) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memcache.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 58 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return None; [INFO] [stdout] 58 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/monitor.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return true; [INFO] [stdout] 78 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: items after a test module [INFO] [stdout] --> src/scheduler.rs:66:1 [INFO] [stdout] | [INFO] [stdout] 66 | mod tests { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 92 | pub async fn scheduler(client: serenity::Client) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 161 | pub async fn run_automation(cache: &Http, automation: &mut ScheduledAutomation) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#items_after_test_module [INFO] [stdout] = note: `#[warn(clippy::items_after_test_module)]` on by default [INFO] [stdout] = help: move the items to before the test module was defined [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheduler.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | return (execute_next, return_time, automations); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return (execute_next, return_time, automations); [INFO] [stdout] 42 + (execute_next, return_time, automations) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `index` is used to index `scheduled` [INFO] [stdout] --> src/scheduler.rs:34:18 [INFO] [stdout] | [INFO] [stdout] 34 | for index in 0..scheduled.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 34 - for index in 0..scheduled.len() { [INFO] [stdout] 34 + for (index, ) in scheduled.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/scheduler.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 106 | if automations.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `automations.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u64` [INFO] [stdout] --> src/scheduler.rs:135:45 [INFO] [stdout] | [INFO] [stdout] 135 | ... &ChannelId::new(automations[i].channelid.try_into().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u64` [INFO] [stdout] --> src/scheduler.rs:146:45 [INFO] [stdout] | [INFO] [stdout] 146 | ... &ChannelId::new(automations[i].channelid.try_into().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `cache` after checking its variant with `is_some` [INFO] [stdout] --> src/api.rs:61:20 [INFO] [stdout] | [INFO] [stdout] 60 | let json = if cache.is_some() { [INFO] [stdout] | ------------------ help: try: `if let Some() = cache` [INFO] [stdout] 61 | let json = cache.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/api.rs:147:5 [INFO] [stdout] | [INFO] [stdout] 147 | return Ok(post); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 - return Ok(post); [INFO] [stdout] 147 + Ok(post) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u64` [INFO] [stdout] --> src/scheduler.rs:170:37 [INFO] [stdout] | [INFO] [stdout] 170 | &ChannelId::new(automation.channelid.try_into().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u64` [INFO] [stdout] --> src/scheduler.rs:181:37 [INFO] [stdout] | [INFO] [stdout] 181 | &ChannelId::new(automation.channelid.try_into().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/api.rs:70:16 [INFO] [stdout] | [INFO] [stdout] 70 | if let Err(_) = json_response { [INFO] [stdout] | -------^^^^^^---------------- help: try: `if json_response.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/api.rs:75:16 [INFO] [stdout] | [INFO] [stdout] 75 | if let Err(_) = json_response { [INFO] [stdout] | -------^^^^^^---------------- help: try: `if json_response.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheduler_data.rs:17:39 [INFO] [stdout] | [INFO] [stdout] 17 | AutomationType::Reddit => return 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - AutomationType::Reddit => return 1, [INFO] [stdout] 17 + AutomationType::Reddit => 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheduler_data.rs:18:37 [INFO] [stdout] | [INFO] [stdout] 18 | AutomationType::XKCD => return 2, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - AutomationType::XKCD => return 2, [INFO] [stdout] 18 + AutomationType::XKCD => 2, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheduler_data.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | return Some(AutomationType::Reddit); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return Some(AutomationType::Reddit); [INFO] [stdout] 25 + Some(AutomationType::Reddit) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheduler_data.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | return Some(AutomationType::XKCD); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return Some(AutomationType::XKCD); [INFO] [stdout] 28 + Some(AutomationType::XKCD) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheduler_data.rs:31:17 [INFO] [stdout] | [INFO] [stdout] 31 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return None; [INFO] [stdout] 31 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/scheduler_data.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | / pub fn new( [INFO] [stdout] 52 | | cron_expresssion: String, [INFO] [stdout] 53 | | db_name: String, [INFO] [stdout] 54 | | display_name: String, [INFO] [stdout] ... | [INFO] [stdout] 60 | | has_image: bool, [INFO] [stdout] 61 | | ) -> ScheduledAutomation { [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/api.rs:111:16 [INFO] [stdout] | [INFO] [stdout] 111 | if json["data"]["children"][randint]["data"]["subreddit"].to_string() == "null" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `json["data"]["children"][randint]["data"]["subreddit"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheduler_data.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | / return ScheduledAutomation { [INFO] [stdout] 63 | | cron: croner::Cron::new(&cron_expresssion).parse().unwrap(), [INFO] [stdout] 64 | | cron_expresssion, [INFO] [stdout] 65 | | db_name, [INFO] [stdout] ... | [INFO] [stdout] 72 | | has_image, [INFO] [stdout] 73 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 ~ ScheduledAutomation { [INFO] [stdout] 63 + cron: croner::Cron::new(&cron_expresssion).parse().unwrap(), [INFO] [stdout] 64 + cron_expresssion, [INFO] [stdout] 65 + db_name, [INFO] [stdout] 66 + display_name, [INFO] [stdout] 67 + channelid, [INFO] [stdout] 68 + iterator, [INFO] [stdout] 69 + lastids: lastids, [INFO] [stdout] 70 + db_scheduled_id, [INFO] [stdout] 71 + handler: AutomationType::from_db(handler).unwrap(), [INFO] [stdout] 72 + has_image, [INFO] [stdout] 73 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheduler_data.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | / return self [INFO] [stdout] 78 | | .cron [INFO] [stdout] 79 | | .find_next_occurrence(&Local::now(), false) [INFO] [stdout] 80 | | .unwrap(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 ~ self [INFO] [stdout] 78 + .cron [INFO] [stdout] 79 + .find_next_occurrence(&Local::now(), false) [INFO] [stdout] 80 ~ .unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheduler_data.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 137 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 137 - return false; [INFO] [stdout] 137 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/scheduler_data.rs:133:16 [INFO] [stdout] | [INFO] [stdout] 133 | if String::from(last_id) == id { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `last_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/api.rs:153:12 [INFO] [stdout] | [INFO] [stdout] 153 | if let Err(_) = json_response { [INFO] [stdout] | -------^^^^^^---------------- help: try: `if json_response.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/api.rs:158:12 [INFO] [stdout] | [INFO] [stdout] 158 | if let Err(_) = json_response { [INFO] [stdout] | -------^^^^^^---------------- help: try: `if json_response.is_err()` [INFO] [stdout] | [INFO] [stdout] = note: this will change drop order of the result, as well as all temporaries [INFO] [stdout] = note: add `#[allow(clippy::redundant_pattern_matching)]` if this is important [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/api.rs:164:30 [INFO] [stdout] | [INFO] [stdout] 164 | serde_json::from_str(&json_response.as_str()).expect("JSON Deserialization Error"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `json_response.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/api.rs:190:5 [INFO] [stdout] | [INFO] [stdout] 190 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 190 - return false; [INFO] [stdout] 190 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/api.rs:177:27 [INFO] [stdout] | [INFO] [stdout] 177 | let param_extension = url [INFO] [stdout] | ___________________________^ [INFO] [stdout] 178 | | .trim() [INFO] [stdout] 179 | | .split('.') [INFO] [stdout] 180 | | .last() [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 180 - .last() [INFO] [stdout] 180 + .next_back() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/database.rs:30:33 [INFO] [stdout] | [INFO] [stdout] 30 | SqliteConnection::establish(&database_url) [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `database_url` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `post.image_link` after checking its variant with `is_some` [INFO] [stdout] --> src/discord.rs:14:37 [INFO] [stdout] | [INFO] [stdout] 13 | if post.image_link.is_some() { [INFO] [stdout] | ---------------------------- help: try: `if let Some() = post.image_link` [INFO] [stdout] 14 | embed = embed.clone().image(post.image_link.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `post.url` after checking its variant with `is_some` [INFO] [stdout] --> src/discord.rs:17:35 [INFO] [stdout] | [INFO] [stdout] 16 | if post.url.is_some() { [INFO] [stdout] | --------------------- help: try: `if let Some() = post.url` [INFO] [stdout] 17 | embed = embed.clone().url(post.url.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/discord.rs:7:16 [INFO] [stdout] | [INFO] [stdout] 7 | .title(format!("{}", post.title)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `post.title.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/discord.rs:8:22 [INFO] [stdout] | [INFO] [stdout] 8 | .description(format!("{}", post.body)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `post.body.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memcache.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | return self.expiration < Utc::now(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 13 - return self.expiration < Utc::now(); [INFO] [stdout] 13 + self.expiration < Utc::now() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Memcache` [INFO] [stdout] --> src/memcache.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 32 | / pub fn new() -> Memcache { [INFO] [stdout] 33 | | return Memcache { [INFO] [stdout] 34 | | cache: HashMap::new(), [INFO] [stdout] 35 | | }; [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 25 + impl Default for Memcache { [INFO] [stdout] 26 + fn default() -> Self { [INFO] [stdout] 27 + Self::new() [INFO] [stdout] 28 + } [INFO] [stdout] 29 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/memcache.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 28 | if !value.is_none() && value.unwrap().is_expired() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `value.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memcache.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | / return Memcache { [INFO] [stdout] 34 | | cache: HashMap::new(), [INFO] [stdout] 35 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 ~ Memcache { [INFO] [stdout] 34 + cache: HashMap::new(), [INFO] [stdout] 35 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memcache.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 55 | return Some(&value.unwrap().json); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - return Some(&value.unwrap().json); [INFO] [stdout] 55 + Some(&value.unwrap().json) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/memcache.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 58 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 58 - return None; [INFO] [stdout] 58 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/monitor.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return true; [INFO] [stdout] 78 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheduler.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | return (execute_next, return_time, automations); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return (execute_next, return_time, automations); [INFO] [stdout] 42 + (execute_next, return_time, automations) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `index` is used to index `scheduled` [INFO] [stdout] --> src/scheduler.rs:34:18 [INFO] [stdout] | [INFO] [stdout] 34 | for index in 0..scheduled.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 34 - for index in 0..scheduled.len() { [INFO] [stdout] 34 + for (index, ) in scheduled.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/scheduler.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 106 | if automations.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `automations.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u64` [INFO] [stdout] --> src/scheduler.rs:135:45 [INFO] [stdout] | [INFO] [stdout] 135 | ... &ChannelId::new(automations[i].channelid.try_into().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u64` [INFO] [stdout] --> src/scheduler.rs:146:45 [INFO] [stdout] | [INFO] [stdout] 146 | ... &ChannelId::new(automations[i].channelid.try_into().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u64` [INFO] [stdout] --> src/scheduler.rs:170:37 [INFO] [stdout] | [INFO] [stdout] 170 | &ChannelId::new(automation.channelid.try_into().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u64` [INFO] [stdout] --> src/scheduler.rs:181:37 [INFO] [stdout] | [INFO] [stdout] 181 | &ChannelId::new(automation.channelid.try_into().unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing `.try_into()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheduler_data.rs:17:39 [INFO] [stdout] | [INFO] [stdout] 17 | AutomationType::Reddit => return 1, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 17 - AutomationType::Reddit => return 1, [INFO] [stdout] 17 + AutomationType::Reddit => 1, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheduler_data.rs:18:37 [INFO] [stdout] | [INFO] [stdout] 18 | AutomationType::XKCD => return 2, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - AutomationType::XKCD => return 2, [INFO] [stdout] 18 + AutomationType::XKCD => 2, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheduler_data.rs:25:17 [INFO] [stdout] | [INFO] [stdout] 25 | return Some(AutomationType::Reddit); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return Some(AutomationType::Reddit); [INFO] [stdout] 25 + Some(AutomationType::Reddit) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheduler_data.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | return Some(AutomationType::XKCD); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 - return Some(AutomationType::XKCD); [INFO] [stdout] 28 + Some(AutomationType::XKCD) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheduler_data.rs:31:17 [INFO] [stdout] | [INFO] [stdout] 31 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return None; [INFO] [stdout] 31 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/scheduler_data.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | / pub fn new( [INFO] [stdout] 52 | | cron_expresssion: String, [INFO] [stdout] 53 | | db_name: String, [INFO] [stdout] 54 | | display_name: String, [INFO] [stdout] ... | [INFO] [stdout] 60 | | has_image: bool, [INFO] [stdout] 61 | | ) -> ScheduledAutomation { [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheduler_data.rs:62:9 [INFO] [stdout] | [INFO] [stdout] 62 | / return ScheduledAutomation { [INFO] [stdout] 63 | | cron: croner::Cron::new(&cron_expresssion).parse().unwrap(), [INFO] [stdout] 64 | | cron_expresssion, [INFO] [stdout] 65 | | db_name, [INFO] [stdout] ... | [INFO] [stdout] 72 | | has_image, [INFO] [stdout] 73 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 62 ~ ScheduledAutomation { [INFO] [stdout] 63 + cron: croner::Cron::new(&cron_expresssion).parse().unwrap(), [INFO] [stdout] 64 + cron_expresssion, [INFO] [stdout] 65 + db_name, [INFO] [stdout] 66 + display_name, [INFO] [stdout] 67 + channelid, [INFO] [stdout] 68 + iterator, [INFO] [stdout] 69 + lastids: lastids, [INFO] [stdout] 70 + db_scheduled_id, [INFO] [stdout] 71 + handler: AutomationType::from_db(handler).unwrap(), [INFO] [stdout] 72 + has_image, [INFO] [stdout] 73 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheduler_data.rs:77:9 [INFO] [stdout] | [INFO] [stdout] 77 | / return self [INFO] [stdout] 78 | | .cron [INFO] [stdout] 79 | | .find_next_occurrence(&Local::now(), false) [INFO] [stdout] 80 | | .unwrap(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 77 ~ self [INFO] [stdout] 78 + .cron [INFO] [stdout] 79 + .find_next_occurrence(&Local::now(), false) [INFO] [stdout] 80 ~ .unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/scheduler_data.rs:137:9 [INFO] [stdout] | [INFO] [stdout] 137 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 137 - return false; [INFO] [stdout] 137 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/scheduler_data.rs:133:16 [INFO] [stdout] | [INFO] [stdout] 133 | if String::from(last_id) == id { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `last_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u64` is unnecessary [INFO] [stdout] --> src/main.rs:143:34 [INFO] [stdout] | [INFO] [stdout] 143 | "parent_id": 1307187771542343771 as u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `1307187771542343771_u64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u64` is unnecessary [INFO] [stdout] --> src/main.rs:146:35 [INFO] [stdout] | [INFO] [stdout] 146 | ... "id": 233056950361915392 as u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `233056950361915392_u64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:379:46 [INFO] [stdout] | [INFO] [stdout] 379 | let mut client: Client = Client::builder(&token, intents) [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:385:44 [INFO] [stdout] | [INFO] [stdout] 385 | let scheduler_client = Client::builder(&token, intents) [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u64` is unnecessary [INFO] [stdout] --> src/main.rs:143:34 [INFO] [stdout] | [INFO] [stdout] 143 | "parent_id": 1307187771542343771 as u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `1307187771542343771_u64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u64` is unnecessary [INFO] [stdout] --> src/main.rs:146:35 [INFO] [stdout] | [INFO] [stdout] 146 | ... "id": 233056950361915392 as u64, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `233056950361915392_u64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:379:46 [INFO] [stdout] | [INFO] [stdout] 379 | let mut client: Client = Client::builder(&token, intents) [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:385:44 [INFO] [stdout] | [INFO] [stdout] 385 | let scheduler_client = Client::builder(&token, intents) [INFO] [stdout] | ^^^^^^ help: change this to: `token` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 51s [INFO] running `Command { std: "docker" "inspect" "ab76ea9d9ea40ca617264b1b912aac8a885bd707d7f5e3638b3bb5d80123ed84", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ab76ea9d9ea40ca617264b1b912aac8a885bd707d7f5e3638b3bb5d80123ed84", kill_on_drop: false }` [INFO] [stdout] ab76ea9d9ea40ca617264b1b912aac8a885bd707d7f5e3638b3bb5d80123ed84