[INFO] cloning repository https://github.com/Srynetix/pssh-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Srynetix/pssh-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSrynetix%2Fpssh-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSrynetix%2Fpssh-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 31b69302a963abe242560eefe892bce04aae8cf0 [INFO] linting Srynetix/pssh-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSrynetix%2Fpssh-rs" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Srynetix/pssh-rs [INFO] finished tweaking git repo https://github.com/Srynetix/pssh-rs [INFO] tweaked toml for git repo https://github.com/Srynetix/pssh-rs written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Srynetix/pssh-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Srynetix/pssh-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded fern v0.4.3 [INFO] [stderr] Downloaded atty v0.2.3 [INFO] [stderr] Downloaded maplit v1.0.0 [INFO] [stderr] Downloaded linked-hash-map v0.5.0 [INFO] [stderr] Downloaded yaml-rust v0.4.0 [INFO] [stderr] Downloaded textwrap v0.9.0 [INFO] [stderr] Downloaded chrono v0.4.0 [INFO] [stderr] Downloaded clap v2.29.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 866eee35f814176a410973d874164af88e75c629252a8bd1a742067146af6990 [INFO] running `Command { std: "docker" "start" "-a" "866eee35f814176a410973d874164af88e75c629252a8bd1a742067146af6990", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "866eee35f814176a410973d874164af88e75c629252a8bd1a742067146af6990", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "866eee35f814176a410973d874164af88e75c629252a8bd1a742067146af6990", kill_on_drop: false }` [INFO] [stdout] 866eee35f814176a410973d874164af88e75c629252a8bd1a742067146af6990 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3caff08653d991967ae0a9e76995a0bd3517989bc099f04c7c522038ae06ac05 [INFO] running `Command { std: "docker" "start" "-a" "3caff08653d991967ae0a9e76995a0bd3517989bc099f04c7c522038ae06ac05", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking num-integer v0.1.35 [INFO] [stderr] Checking unicode-width v0.1.4 [INFO] [stderr] Checking bitflags v1.0.1 [INFO] [stderr] Checking linked-hash-map v0.5.0 [INFO] [stderr] Checking ansi_term v0.10.2 [INFO] [stderr] Checking vec_map v0.8.0 [INFO] [stderr] Checking maplit v1.0.0 [INFO] [stderr] Checking atty v0.2.3 [INFO] [stderr] Checking fern v0.4.3 [INFO] [stderr] Checking textwrap v0.9.0 [INFO] [stderr] Checking num-iter v0.1.34 [INFO] [stderr] Checking yaml-rust v0.4.0 [INFO] [stderr] Checking clap v2.29.0 [INFO] [stderr] Checking num v0.1.41 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking pssh-rs v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/config.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | self.ip.as_ref().map(|x| println!(" IP: {}", x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 82 - self.ip.as_ref().map(|x| println!(" IP: {}", x)); [INFO] [stdout] 82 + if let Some(x) = self.ip.as_ref() { println!(" IP: {}", x) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/config.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | self.port.as_ref().map(|x| println!(" Port: {}", x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 83 - self.port.as_ref().map(|x| println!(" Port: {}", x)); [INFO] [stdout] 83 + if let Some(x) = self.port.as_ref() { println!(" Port: {}", x) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/config.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | self.user.as_ref().map(|x| println!(" User: {}", x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 84 - self.user.as_ref().map(|x| println!(" User: {}", x)); [INFO] [stdout] 84 + if let Some(x) = self.user.as_ref() { println!(" User: {}", x) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/config.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | self.pass.as_ref().map(|_| println!(" Pass: *******")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 85 - self.pass.as_ref().map(|_| println!(" Pass: *******")); [INFO] [stdout] 85 + if let Some(_) = self.pass.as_ref() { println!(" Pass: *******") } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/config.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | self.identity.as_ref().map(|x| println!(" Identity: {}", x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 86 - self.identity.as_ref().map(|x| println!(" Identity: {}", x)); [INFO] [stdout] 86 + if let Some(x) = self.identity.as_ref() { println!(" Identity: {}", x) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/config.rs:105:43 [INFO] [stdout] | [INFO] [stdout] 105 | let mut f = File::open(&path_to_file).expect(&format!("File {} not found.", path_to_file)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("File {} not found.", path_to_file))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/config.rs:167:12 [INFO] [stdout] | [INFO] [stdout] 167 | if current_parent == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `current_parent.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/config.rs:264:34 [INFO] [stdout] | [INFO] [stdout] 264 | let current_key = if parent_key == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `parent_key.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/config.rs:328:17 [INFO] [stdout] | [INFO] [stdout] 328 | assert!(config.default_values.contains_key("four") == false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!config.default_values.contains_key("four")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/config.rs:365:52 [INFO] [stdout] | [INFO] [stdout] 365 | let config = fetch_default_values_for_name(&"toto".to_string(), &values).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use: `"toto"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/config.rs:370:52 [INFO] [stdout] | [INFO] [stdout] 370 | let config = fetch_default_values_for_name(&"coucou".to_string(), &values).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: use: `"coucou"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/config.rs:375:52 [INFO] [stdout] | [INFO] [stdout] 375 | let config = fetch_default_values_for_name(&"coucou:pouet".to_string(), &values).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"coucou:pouet"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/config.rs:379:52 [INFO] [stdout] | [INFO] [stdout] 379 | let config = fetch_default_values_for_name(&"coucou:hello".to_string(), &values).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"coucou:hello"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/config.rs:383:52 [INFO] [stdout] | [INFO] [stdout] 383 | let config = fetch_default_values_for_name(&"coucou:hello:one".to_string(), &values).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `"coucou:hello:one"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/config.rs:413:48 [INFO] [stdout] | [INFO] [stdout] 413 | let m_coucou = configured_machines.get(&"coucou".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `"coucou"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/config.rs:414:54 [INFO] [stdout] | [INFO] [stdout] 414 | let m_coucou_hello = configured_machines.get(&"coucou:hello".to_string()).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `"coucou:hello"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/config.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | self.ip.as_ref().map(|x| println!(" IP: {}", x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] = note: `#[warn(clippy::option_map_unit_fn)]` on by default [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 82 - self.ip.as_ref().map(|x| println!(" IP: {}", x)); [INFO] [stdout] 82 + if let Some(x) = self.ip.as_ref() { println!(" IP: {}", x) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/config.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | self.port.as_ref().map(|x| println!(" Port: {}", x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 83 - self.port.as_ref().map(|x| println!(" Port: {}", x)); [INFO] [stdout] 83 + if let Some(x) = self.port.as_ref() { println!(" Port: {}", x) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/config.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | self.user.as_ref().map(|x| println!(" User: {}", x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 84 - self.user.as_ref().map(|x| println!(" User: {}", x)); [INFO] [stdout] 84 + if let Some(x) = self.user.as_ref() { println!(" User: {}", x) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/config.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | self.pass.as_ref().map(|_| println!(" Pass: *******")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 85 - self.pass.as_ref().map(|_| println!(" Pass: *******")); [INFO] [stdout] 85 + if let Some(_) = self.pass.as_ref() { println!(" Pass: *******") } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` [INFO] [stdout] --> src/config.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | self.identity.as_ref().map(|x| println!(" Identity: {}", x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stdout] help: use `if let` instead [INFO] [stdout] | [INFO] [stdout] 86 - self.identity.as_ref().map(|x| println!(" Identity: {}", x)); [INFO] [stdout] 86 + if let Some(x) = self.identity.as_ref() { println!(" Identity: {}", x) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/config.rs:105:43 [INFO] [stdout] | [INFO] [stdout] 105 | let mut f = File::open(&path_to_file).expect(&format!("File {} not found.", path_to_file)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("File {} not found.", path_to_file))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/shell.rs:132:52 [INFO] [stdout] | [INFO] [stdout] 132 | let matches = app.get_matches_from_safe_borrow(&mut env::args_os()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `env::args_os()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `eprintln!` args [INFO] [stdout] --> src/shell.rs:174:34 [INFO] [stdout] | [INFO] [stdout] 174 | eprintln!("{}", error.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/config.rs:167:12 [INFO] [stdout] | [INFO] [stdout] 167 | if current_parent == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `current_parent.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `config.identity` after checking its variant with `is_some` [INFO] [stdout] --> src/wrapper.rs:41:30 [INFO] [stdout] | [INFO] [stdout] 40 | if config.identity.is_some() { [INFO] [stdout] | ---------------------------- help: try: `if let Some() = &config.identity` [INFO] [stdout] 41 | command.args(&["-i", config.identity.as_ref().unwrap()]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `config.port` after checking its variant with `is_some` [INFO] [stdout] --> src/wrapper.rs:45:32 [INFO] [stdout] | [INFO] [stdout] 44 | if config.port.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &config.port` [INFO] [stdout] 45 | command.args(&["-P", &(config.port.as_ref().unwrap().to_string())]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `config.user` after checking its variant with `is_some` [INFO] [stdout] --> src/wrapper.rs:57:14 [INFO] [stdout] | [INFO] [stdout] 55 | let user_path = if config.user.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &config.user` [INFO] [stdout] 56 | format!("{}@{}:{}", [INFO] [stdout] 57 | &config.user.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/wrapper.rs:41:22 [INFO] [stdout] | [INFO] [stdout] 41 | command.args(&["-i", config.identity.as_ref().unwrap()]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-i", config.identity.as_ref().unwrap()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/wrapper.rs:45:22 [INFO] [stdout] | [INFO] [stdout] 45 | command.args(&["-P", &(config.port.as_ref().unwrap().to_string())]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-P", &(config.port.as_ref().unwrap().to_string())]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/wrapper.rs:47:22 [INFO] [stdout] | [INFO] [stdout] 47 | command.args(&["-P", "22"]); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `["-P", "22"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/wrapper.rs:70:25 [INFO] [stdout] | [INFO] [stdout] 70 | command.arg(&source); [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/wrapper.rs:75:25 [INFO] [stdout] | [INFO] [stdout] 75 | command.arg(&destination); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `destination` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/wrapper.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 106 | if !config.user.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `config.user.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `config.identity` after checking its variant with `is_some` [INFO] [stdout] --> src/wrapper.rs:95:30 [INFO] [stdout] | [INFO] [stdout] 94 | if config.identity.is_some() { [INFO] [stdout] | ---------------------------- help: try: `if let Some() = &config.identity` [INFO] [stdout] 95 | command.args(&["-i", config.identity.as_ref().unwrap()]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `config.port` after checking its variant with `is_some` [INFO] [stdout] --> src/wrapper.rs:99:32 [INFO] [stdout] | [INFO] [stdout] 98 | if config.port.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &config.port` [INFO] [stdout] 99 | command.args(&["-p", &(config.port.as_ref().unwrap().to_string())]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `user_name` after checking its variant with `is_some` [INFO] [stdout] --> src/wrapper.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 115 | let user_path = if user_name.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = user_name` [INFO] [stdout] 116 | format!("{}@{}", [INFO] [stdout] 117 | user_name.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/wrapper.rs:95:22 [INFO] [stdout] | [INFO] [stdout] 95 | command.args(&["-i", config.identity.as_ref().unwrap()]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-i", config.identity.as_ref().unwrap()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/wrapper.rs:99:22 [INFO] [stdout] | [INFO] [stdout] 99 | command.args(&["-p", &(config.port.as_ref().unwrap().to_string())]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-p", &(config.port.as_ref().unwrap().to_string())]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/wrapper.rs:101:22 [INFO] [stdout] | [INFO] [stdout] 101 | command.args(&["-p", "22"]); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `["-p", "22"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/wrapper.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 121 | / format!("{}", [INFO] [stdout] 122 | | config.ip.as_ref().unwrap() [INFO] [stdout] 123 | | ) [INFO] [stdout] | |_________^ help: consider using `.to_string()`: `config.ip.as_ref().unwrap().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/config.rs:264:34 [INFO] [stdout] | [INFO] [stdout] 264 | let current_key = if parent_key == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `parent_key.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/shell.rs:132:52 [INFO] [stdout] | [INFO] [stdout] 132 | let matches = app.get_matches_from_safe_borrow(&mut env::args_os()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `env::args_os()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `eprintln!` args [INFO] [stdout] --> src/shell.rs:174:34 [INFO] [stdout] | [INFO] [stdout] 174 | eprintln!("{}", error.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `config.identity` after checking its variant with `is_some` [INFO] [stdout] --> src/wrapper.rs:41:30 [INFO] [stdout] | [INFO] [stdout] 40 | if config.identity.is_some() { [INFO] [stdout] | ---------------------------- help: try: `if let Some() = &config.identity` [INFO] [stdout] 41 | command.args(&["-i", config.identity.as_ref().unwrap()]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `config.port` after checking its variant with `is_some` [INFO] [stdout] --> src/wrapper.rs:45:32 [INFO] [stdout] | [INFO] [stdout] 44 | if config.port.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &config.port` [INFO] [stdout] 45 | command.args(&["-P", &(config.port.as_ref().unwrap().to_string())]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `config.user` after checking its variant with `is_some` [INFO] [stdout] --> src/wrapper.rs:57:14 [INFO] [stdout] | [INFO] [stdout] 55 | let user_path = if config.user.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &config.user` [INFO] [stdout] 56 | format!("{}@{}:{}", [INFO] [stdout] 57 | &config.user.as_ref().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/wrapper.rs:41:22 [INFO] [stdout] | [INFO] [stdout] 41 | command.args(&["-i", config.identity.as_ref().unwrap()]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-i", config.identity.as_ref().unwrap()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/wrapper.rs:45:22 [INFO] [stdout] | [INFO] [stdout] 45 | command.args(&["-P", &(config.port.as_ref().unwrap().to_string())]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-P", &(config.port.as_ref().unwrap().to_string())]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/wrapper.rs:47:22 [INFO] [stdout] | [INFO] [stdout] 47 | command.args(&["-P", "22"]); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `["-P", "22"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/wrapper.rs:70:25 [INFO] [stdout] | [INFO] [stdout] 70 | command.arg(&source); [INFO] [stdout] | ^^^^^^^ help: change this to: `source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/wrapper.rs:75:25 [INFO] [stdout] | [INFO] [stdout] 75 | command.arg(&destination); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `destination` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/wrapper.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 106 | if !config.user.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `config.user.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `config.identity` after checking its variant with `is_some` [INFO] [stdout] --> src/wrapper.rs:95:30 [INFO] [stdout] | [INFO] [stdout] 94 | if config.identity.is_some() { [INFO] [stdout] | ---------------------------- help: try: `if let Some() = &config.identity` [INFO] [stdout] 95 | command.args(&["-i", config.identity.as_ref().unwrap()]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `config.port` after checking its variant with `is_some` [INFO] [stdout] --> src/wrapper.rs:99:32 [INFO] [stdout] | [INFO] [stdout] 98 | if config.port.is_some() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = &config.port` [INFO] [stdout] 99 | command.args(&["-p", &(config.port.as_ref().unwrap().to_string())]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `user_name` after checking its variant with `is_some` [INFO] [stdout] --> src/wrapper.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 115 | let user_path = if user_name.is_some() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = user_name` [INFO] [stdout] 116 | format!("{}@{}", [INFO] [stdout] 117 | user_name.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/wrapper.rs:95:22 [INFO] [stdout] | [INFO] [stdout] 95 | command.args(&["-i", config.identity.as_ref().unwrap()]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-i", config.identity.as_ref().unwrap()]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/wrapper.rs:99:22 [INFO] [stdout] | [INFO] [stdout] 99 | command.args(&["-p", &(config.port.as_ref().unwrap().to_string())]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["-p", &(config.port.as_ref().unwrap().to_string())]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/wrapper.rs:101:22 [INFO] [stdout] | [INFO] [stdout] 101 | command.args(&["-p", "22"]); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `["-p", "22"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/wrapper.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 121 | / format!("{}", [INFO] [stdout] 122 | | config.ip.as_ref().unwrap() [INFO] [stdout] 123 | | ) [INFO] [stdout] | |_________^ help: consider using `.to_string()`: `config.ip.as_ref().unwrap().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.44s [INFO] running `Command { std: "docker" "inspect" "3caff08653d991967ae0a9e76995a0bd3517989bc099f04c7c522038ae06ac05", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3caff08653d991967ae0a9e76995a0bd3517989bc099f04c7c522038ae06ac05", kill_on_drop: false }` [INFO] [stdout] 3caff08653d991967ae0a9e76995a0bd3517989bc099f04c7c522038ae06ac05