[INFO] cloning repository https://github.com/SpeedyTurtle599/lattice-boltzmann-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SpeedyTurtle599/lattice-boltzmann-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSpeedyTurtle599%2Flattice-boltzmann-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSpeedyTurtle599%2Flattice-boltzmann-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 94707d3e2c52b049b4305f6bb4ff80af9fa15c56 [INFO] linting SpeedyTurtle599/lattice-boltzmann-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSpeedyTurtle599%2Flattice-boltzmann-rs" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/SpeedyTurtle599/lattice-boltzmann-rs [INFO] removed 0 missing examples [INFO] finished tweaking git repo https://github.com/SpeedyTurtle599/lattice-boltzmann-rs [INFO] tweaked toml for git repo https://github.com/SpeedyTurtle599/lattice-boltzmann-rs written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/SpeedyTurtle599/lattice-boltzmann-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/SpeedyTurtle599/lattice-boltzmann-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded stl_io v0.8.5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eadcd7d1834979666394bb9acfe8150db891f60d6d8698940e9516979bd9b3c4 [INFO] running `Command { std: "docker" "start" "-a" "eadcd7d1834979666394bb9acfe8150db891f60d6d8698940e9516979bd9b3c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eadcd7d1834979666394bb9acfe8150db891f60d6d8698940e9516979bd9b3c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eadcd7d1834979666394bb9acfe8150db891f60d6d8698940e9516979bd9b3c4", kill_on_drop: false }` [INFO] [stdout] eadcd7d1834979666394bb9acfe8150db891f60d6d8698940e9516979bd9b3c4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ee1b75415b9ec27fc5533d161f564cc343f8eb9fa3465e361ff1aeb45574287b [INFO] running `Command { std: "docker" "start" "-a" "ee1b75415b9ec27fc5533d161f564cc343f8eb9fa3465e361ff1aeb45574287b", kill_on_drop: false }` [INFO] [stderr] Compiling thiserror v2.0.12 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Compiling naga v25.0.1 [INFO] [stderr] Checking libloading v0.8.8 [INFO] [stderr] Checking bit-vec v0.8.0 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking codespan-reporting v0.12.0 [INFO] [stderr] Compiling wgpu-hal v25.0.2 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Compiling wgpu-core v25.0.2 [INFO] [stderr] Compiling portable-atomic v1.11.1 [INFO] [stderr] Compiling wgpu v25.0.2 [INFO] [stderr] Checking anstream v0.6.19 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking khronos-egl v6.0.0 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking bit-set v0.8.0 [INFO] [stderr] Checking ash v0.38.0+1.3.281 [INFO] [stderr] Checking jiff v0.2.15 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking half v2.6.0 [INFO] [stderr] Checking ordered-float v4.6.0 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking stl_io v0.8.5 [INFO] [stderr] Checking indexmap v2.9.0 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking env_filter v0.1.3 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling bytemuck_derive v1.9.3 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling nalgebra-macros v0.2.2 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Checking tokio v1.45.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking bytemuck v1.23.1 [INFO] [stderr] Checking safe_arch v0.7.4 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking wide v0.7.33 [INFO] [stderr] Checking simba v0.9.0 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Checking serde_json v1.0.140 [INFO] [stderr] Checking spirv v0.3.0+sdk-1.3.268.0 [INFO] [stderr] Checking gpu-alloc-types v0.3.0 [INFO] [stderr] Checking gpu-descriptor-types v0.2.0 [INFO] [stderr] Checking wgpu-types v25.0.0 [INFO] [stderr] Checking gpu-descriptor v0.3.2 [INFO] [stderr] Checking gpu-alloc v0.6.0 [INFO] [stderr] Checking nalgebra v0.33.2 [INFO] [stderr] Checking wgpu-core-deps-windows-linux-android v25.0.0 [INFO] [stderr] Checking lattice-boltzmann-rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `temp_buffer`, `config_buffer`, `timestamp_period`, `query_set`, and `query_buffer` are never read [INFO] [stdout] --> src/gpu.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct GPUContext { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 17 | temp_buffer: wgpu::Buffer, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 18 | config_buffer: wgpu::Buffer, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 26 | timestamp_period: f32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 27 | query_set: Option, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 28 | query_buffer: Option, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `reachable` [INFO] [stdout] --> src/geometry.rs:267:18 [INFO] [stdout] | [INFO] [stdout] 267 | for i in 0..domain.nx { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 267 - for i in 0..domain.nx { [INFO] [stdout] 267 + for (i, ) in reachable.iter_mut().enumerate().take(domain.nx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is used to index `reachable` [INFO] [stdout] --> src/geometry.rs:268:22 [INFO] [stdout] | [INFO] [stdout] 268 | for k in 0..domain.nz { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 268 - for k in 0..domain.nz { [INFO] [stdout] 268 + for (k, ) in reachable.iter_mut().enumerate().take(domain.nz) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `reachable` [INFO] [stdout] --> src/geometry.rs:282:18 [INFO] [stdout] | [INFO] [stdout] 282 | for i in 0..domain.nx { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 282 - for i in 0..domain.nx { [INFO] [stdout] 282 + for (i, ) in reachable.iter_mut().enumerate().take(domain.nx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `reachable` [INFO] [stdout] --> src/geometry.rs:283:22 [INFO] [stdout] | [INFO] [stdout] 283 | for j in 0..domain.ny { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 283 - for j in 0..domain.ny { [INFO] [stdout] 283 + for (j, ) in reachable.iter_mut().enumerate().take(domain.ny) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `reachable` [INFO] [stdout] --> src/geometry.rs:335:18 [INFO] [stdout] | [INFO] [stdout] 335 | for i in 0..domain.nx { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 335 - for i in 0..domain.nx { [INFO] [stdout] 335 + for (i, ) in reachable.iter().enumerate().take(domain.nx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `reachable` [INFO] [stdout] --> src/geometry.rs:336:22 [INFO] [stdout] | [INFO] [stdout] 336 | for j in 0..domain.ny { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 336 - for j in 0..domain.ny { [INFO] [stdout] 336 + for (j, ) in reachable.iter().enumerate().take(domain.ny) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is used to index `reachable` [INFO] [stdout] --> src/geometry.rs:337:26 [INFO] [stdout] | [INFO] [stdout] 337 | for k in 0..domain.nz { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 337 - for k in 0..domain.nz { [INFO] [stdout] 337 + for (k, ) in reachable.iter().enumerate().take(domain.nz) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/solver.rs:72:24 [INFO] [stdout] | [INFO] [stdout] 72 | if (i == 0 && j == config.domain.ny / 2 && k == config.domain.nz / 2) || [INFO] [stdout] | ________________________^ [INFO] [stdout] 73 | | (i == config.domain.nx / 2 && j == config.domain.ny / 2 && k == config.domain.nz / 2) { [INFO] [stdout] | |____________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 72 - if (i == 0 && j == config.domain.ny / 2 && k == config.domain.nz / 2) || [INFO] [stdout] 73 - (i == config.domain.nx / 2 && j == config.domain.ny / 2 && k == config.domain.nz / 2) { [INFO] [stdout] 72 + if !(j != config.domain.ny / 2 || k != config.domain.nz / 2 || i != 0 && i != config.domain.nx / 2) { [INFO] [stdout] | [INFO] [stdout] 72 - if (i == 0 && j == config.domain.ny / 2 && k == config.domain.nz / 2) || [INFO] [stdout] 73 - (i == config.domain.nx / 2 && j == config.domain.ny / 2 && k == config.domain.nz / 2) { [INFO] [stdout] 72 + if (i == config.domain.nx / 2 || i == 0) && k == config.domain.nz / 2 && j == config.domain.ny / 2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/solver.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 116 | if self.iteration % self.config.output.output_frequency == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.iteration.is_multiple_of(self.config.output.output_frequency)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/solver.rs:139:16 [INFO] [stdout] | [INFO] [stdout] 139 | if self.iteration % self.config.output.output_frequency == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.iteration.is_multiple_of(self.config.output.output_frequency)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/solver.rs:157:20 [INFO] [stdout] | [INFO] [stdout] 157 | if self.iteration % 10 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.iteration.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/gpu.rs:468:26 [INFO] [stdout] | [INFO] [stdout] 468 | let dispatch_x = (self.nx + self.workgroup_size_x - 1) / self.workgroup_size_x; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `self.nx.div_ceil(self.workgroup_size_x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/gpu.rs:469:26 [INFO] [stdout] | [INFO] [stdout] 469 | let dispatch_y = (self.ny + self.workgroup_size_y - 1) / self.workgroup_size_y; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `self.ny.div_ceil(self.workgroup_size_y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/gpu.rs:470:26 [INFO] [stdout] | [INFO] [stdout] 470 | let dispatch_z = (self.nz + self.workgroup_size_z - 1) / self.workgroup_size_z; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `self.nz.div_ceil(self.workgroup_size_z)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `temp_buffer`, `config_buffer`, `timestamp_period`, `query_set`, and `query_buffer` are never read [INFO] [stdout] --> src/gpu.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct GPUContext { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 17 | temp_buffer: wgpu::Buffer, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 18 | config_buffer: wgpu::Buffer, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 26 | timestamp_period: f32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 27 | query_set: Option, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 28 | query_buffer: Option, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `reachable` [INFO] [stdout] --> src/geometry.rs:267:18 [INFO] [stdout] | [INFO] [stdout] 267 | for i in 0..domain.nx { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 267 - for i in 0..domain.nx { [INFO] [stdout] 267 + for (i, ) in reachable.iter_mut().enumerate().take(domain.nx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is used to index `reachable` [INFO] [stdout] --> src/geometry.rs:268:22 [INFO] [stdout] | [INFO] [stdout] 268 | for k in 0..domain.nz { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 268 - for k in 0..domain.nz { [INFO] [stdout] 268 + for (k, ) in reachable.iter_mut().enumerate().take(domain.nz) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `reachable` [INFO] [stdout] --> src/geometry.rs:282:18 [INFO] [stdout] | [INFO] [stdout] 282 | for i in 0..domain.nx { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 282 - for i in 0..domain.nx { [INFO] [stdout] 282 + for (i, ) in reachable.iter_mut().enumerate().take(domain.nx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `reachable` [INFO] [stdout] --> src/geometry.rs:283:22 [INFO] [stdout] | [INFO] [stdout] 283 | for j in 0..domain.ny { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 283 - for j in 0..domain.ny { [INFO] [stdout] 283 + for (j, ) in reachable.iter_mut().enumerate().take(domain.ny) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `reachable` [INFO] [stdout] --> src/geometry.rs:335:18 [INFO] [stdout] | [INFO] [stdout] 335 | for i in 0..domain.nx { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 335 - for i in 0..domain.nx { [INFO] [stdout] 335 + for (i, ) in reachable.iter().enumerate().take(domain.nx) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `reachable` [INFO] [stdout] --> src/geometry.rs:336:22 [INFO] [stdout] | [INFO] [stdout] 336 | for j in 0..domain.ny { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 336 - for j in 0..domain.ny { [INFO] [stdout] 336 + for (j, ) in reachable.iter().enumerate().take(domain.ny) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `k` is used to index `reachable` [INFO] [stdout] --> src/geometry.rs:337:26 [INFO] [stdout] | [INFO] [stdout] 337 | for k in 0..domain.nz { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 337 - for k in 0..domain.nz { [INFO] [stdout] 337 + for (k, ) in reachable.iter().enumerate().take(domain.nz) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/solver.rs:72:24 [INFO] [stdout] | [INFO] [stdout] 72 | if (i == 0 && j == config.domain.ny / 2 && k == config.domain.nz / 2) || [INFO] [stdout] | ________________________^ [INFO] [stdout] 73 | | (i == config.domain.nx / 2 && j == config.domain.ny / 2 && k == config.domain.nz / 2) { [INFO] [stdout] | |____________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 72 - if (i == 0 && j == config.domain.ny / 2 && k == config.domain.nz / 2) || [INFO] [stdout] 73 - (i == config.domain.nx / 2 && j == config.domain.ny / 2 && k == config.domain.nz / 2) { [INFO] [stdout] 72 + if !(j != config.domain.ny / 2 || k != config.domain.nz / 2 || i != 0 && i != config.domain.nx / 2) { [INFO] [stdout] | [INFO] [stdout] 72 - if (i == 0 && j == config.domain.ny / 2 && k == config.domain.nz / 2) || [INFO] [stdout] 73 - (i == config.domain.nx / 2 && j == config.domain.ny / 2 && k == config.domain.nz / 2) { [INFO] [stdout] 72 + if (i == config.domain.nx / 2 || i == 0) && k == config.domain.nz / 2 && j == config.domain.ny / 2 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/solver.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 116 | if self.iteration % self.config.output.output_frequency == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.iteration.is_multiple_of(self.config.output.output_frequency)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/solver.rs:139:16 [INFO] [stdout] | [INFO] [stdout] 139 | if self.iteration % self.config.output.output_frequency == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.iteration.is_multiple_of(self.config.output.output_frequency)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/solver.rs:157:20 [INFO] [stdout] | [INFO] [stdout] 157 | if self.iteration % 10 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.iteration.is_multiple_of(10)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/gpu.rs:468:26 [INFO] [stdout] | [INFO] [stdout] 468 | let dispatch_x = (self.nx + self.workgroup_size_x - 1) / self.workgroup_size_x; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `self.nx.div_ceil(self.workgroup_size_x)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/gpu.rs:469:26 [INFO] [stdout] | [INFO] [stdout] 469 | let dispatch_y = (self.ny + self.workgroup_size_y - 1) / self.workgroup_size_y; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `self.ny.div_ceil(self.workgroup_size_y)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/gpu.rs:470:26 [INFO] [stdout] | [INFO] [stdout] 470 | let dispatch_z = (self.nz + self.workgroup_size_z - 1) / self.workgroup_size_z; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `self.nz.div_ceil(self.workgroup_size_z)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> examples/gpu_diagnostics.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use wgpu; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | use env_logger; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 49.09s [INFO] running `Command { std: "docker" "inspect" "ee1b75415b9ec27fc5533d161f564cc343f8eb9fa3465e361ff1aeb45574287b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ee1b75415b9ec27fc5533d161f564cc343f8eb9fa3465e361ff1aeb45574287b", kill_on_drop: false }` [INFO] [stdout] ee1b75415b9ec27fc5533d161f564cc343f8eb9fa3465e361ff1aeb45574287b