[INFO] cloning repository https://github.com/SolraBizna/input2cmds [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SolraBizna/input2cmds" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSolraBizna%2Finput2cmds", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSolraBizna%2Finput2cmds'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 5ea1bc0d5b6ddcf8661588c8654286226264a228 [INFO] linting SolraBizna/input2cmds against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSolraBizna%2Finput2cmds" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/SolraBizna/input2cmds [INFO] finished tweaking git repo https://github.com/SolraBizna/input2cmds [INFO] tweaked toml for git repo https://github.com/SolraBizna/input2cmds written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/SolraBizna/input2cmds on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/SolraBizna/input2cmds already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded anyhow v1.0.53 [INFO] [stderr] Downloaded libc v0.2.73 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 156ae919a7e8f2c5d7dc02910bd871f8ea50e2067cc6855ceea9ff9ddd2728ea [INFO] running `Command { std: "docker" "start" "-a" "156ae919a7e8f2c5d7dc02910bd871f8ea50e2067cc6855ceea9ff9ddd2728ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "156ae919a7e8f2c5d7dc02910bd871f8ea50e2067cc6855ceea9ff9ddd2728ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "156ae919a7e8f2c5d7dc02910bd871f8ea50e2067cc6855ceea9ff9ddd2728ea", kill_on_drop: false }` [INFO] [stdout] 156ae919a7e8f2c5d7dc02910bd871f8ea50e2067cc6855ceea9ff9ddd2728ea [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 111beae37271b4a93e8ef46e281fca76e0d43ed444cdd0cac8f29d079f4eedcb [INFO] running `Command { std: "docker" "start" "-a" "111beae37271b4a93e8ef46e281fca76e0d43ed444cdd0cac8f29d079f4eedcb", kill_on_drop: false }` [INFO] [stderr] Compiling anyhow v1.0.53 [INFO] [stderr] Compiling libc v0.2.73 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking input2cmds v0.9.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | line_number = line_number + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_number += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:86:28 [INFO] [stdout] | [INFO] [stdout] 86 | if !event_sender.send(*event).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `event_sender.send(*event).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/main.rs:107:39 [INFO] [stdout] | [INFO] [stdout] 107 | let parsed = &el[5..].parse(); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/main.rs:102:21 [INFO] [stdout] | [INFO] [stdout] 102 | if el.starts_with("type=") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 102 ~ if let Some() = el.strip_prefix("type=") { [INFO] [stdout] 103 | if wants_type.is_some() { [INFO] [stdout] ... [INFO] [stdout] 106 | } [INFO] [stdout] 107 ~ let parsed = &.parse(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/main.rs:123:39 [INFO] [stdout] | [INFO] [stdout] 123 | let parsed = &el[5..].parse(); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/main.rs:118:26 [INFO] [stdout] | [INFO] [stdout] 118 | else if el.starts_with("code=") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 118 ~ else if let Some() = el.strip_prefix("code=") { [INFO] [stdout] 119 | if wants_code.is_some() { [INFO] [stdout] ... [INFO] [stdout] 122 | } [INFO] [stdout] 123 ~ let parsed = &.parse(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/main.rs:139:39 [INFO] [stdout] | [INFO] [stdout] 139 | let parsed = &el[6..].parse(); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/main.rs:134:26 [INFO] [stdout] | [INFO] [stdout] 134 | else if el.starts_with("value=") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 134 ~ else if let Some() = el.strip_prefix("value=") { [INFO] [stdout] 135 | if wants_value.is_some() { [INFO] [stdout] ... [INFO] [stdout] 138 | } [INFO] [stdout] 139 ~ let parsed = &.parse(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/main.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | line_number = line_number + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_number += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:86:28 [INFO] [stdout] | [INFO] [stdout] 86 | if !event_sender.send(*event).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `event_sender.send(*event).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/main.rs:107:39 [INFO] [stdout] | [INFO] [stdout] 107 | let parsed = &el[5..].parse(); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/main.rs:102:21 [INFO] [stdout] | [INFO] [stdout] 102 | if el.starts_with("type=") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 102 ~ if let Some() = el.strip_prefix("type=") { [INFO] [stdout] 103 | if wants_type.is_some() { [INFO] [stdout] ... [INFO] [stdout] 106 | } [INFO] [stdout] 107 ~ let parsed = &.parse(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/main.rs:123:39 [INFO] [stdout] | [INFO] [stdout] 123 | let parsed = &el[5..].parse(); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/main.rs:118:26 [INFO] [stdout] | [INFO] [stdout] 118 | else if el.starts_with("code=") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 118 ~ else if let Some() = el.strip_prefix("code=") { [INFO] [stdout] 119 | if wants_code.is_some() { [INFO] [stdout] ... [INFO] [stdout] 122 | } [INFO] [stdout] 123 ~ let parsed = &.parse(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/main.rs:139:39 [INFO] [stdout] | [INFO] [stdout] 139 | let parsed = &el[6..].parse(); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/main.rs:134:26 [INFO] [stdout] | [INFO] [stdout] 134 | else if el.starts_with("value=") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 134 ~ else if let Some() = el.strip_prefix("value=") { [INFO] [stdout] 135 | if wants_value.is_some() { [INFO] [stdout] ... [INFO] [stdout] 138 | } [INFO] [stdout] 139 ~ let parsed = &.parse(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.14s [INFO] running `Command { std: "docker" "inspect" "111beae37271b4a93e8ef46e281fca76e0d43ed444cdd0cac8f29d079f4eedcb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "111beae37271b4a93e8ef46e281fca76e0d43ed444cdd0cac8f29d079f4eedcb", kill_on_drop: false }` [INFO] [stdout] 111beae37271b4a93e8ef46e281fca76e0d43ed444cdd0cac8f29d079f4eedcb