[INFO] cloning repository https://github.com/SneznyKocur/osu-music-extractor-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SneznyKocur/osu-music-extractor-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSneznyKocur%2Fosu-music-extractor-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSneznyKocur%2Fosu-music-extractor-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 57c0d6ce3c5c067b8695bfa2a45172f1ba3094c2 [INFO] linting SneznyKocur/osu-music-extractor-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSneznyKocur%2Fosu-music-extractor-rs" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/SneznyKocur/osu-music-extractor-rs [INFO] finished tweaking git repo https://github.com/SneznyKocur/osu-music-extractor-rs [INFO] tweaked toml for git repo https://github.com/SneznyKocur/osu-music-extractor-rs written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/SneznyKocur/osu-music-extractor-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/SneznyKocur/osu-music-extractor-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded mp4ameta_proc v0.6.0 [INFO] [stderr] Downloaded audiotags-macro v0.2.0 [INFO] [stderr] Downloaded metaflac v0.2.8 [INFO] [stderr] Downloaded readme-rustdocifier v0.1.1 [INFO] [stderr] Downloaded id3 v1.16.2 [INFO] [stderr] Downloaded mp4ameta v0.11.0 [INFO] [stderr] Downloaded audiotags v0.5.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 10a4fade13eaac9dec163bde21a650c8835d8dd0301bd707b846d626c9692f46 [INFO] running `Command { std: "docker" "start" "-a" "10a4fade13eaac9dec163bde21a650c8835d8dd0301bd707b846d626c9692f46", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "10a4fade13eaac9dec163bde21a650c8835d8dd0301bd707b846d626c9692f46", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "10a4fade13eaac9dec163bde21a650c8835d8dd0301bd707b846d626c9692f46", kill_on_drop: false }` [INFO] [stdout] 10a4fade13eaac9dec163bde21a650c8835d8dd0301bd707b846d626c9692f46 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] de2d698e80f42996695231918b77e9ff7db35edddf1ef029ea9e2b053ead3a54 [INFO] running `Command { std: "docker" "start" "-a" "de2d698e80f42996695231918b77e9ff7db35edddf1ef029ea9e2b053ead3a54", kill_on_drop: false }` [INFO] [stderr] Compiling mp4ameta_proc v0.6.0 [INFO] [stderr] Checking audiotags-macro v0.2.0 [INFO] [stderr] Checking miniz_oxide v0.8.7 [INFO] [stderr] Checking metaflac v0.2.8 [INFO] [stderr] Compiling syn v2.0.100 [INFO] [stderr] Checking mp4ameta v0.11.0 [INFO] [stderr] Checking flate2 v1.1.1 [INFO] [stderr] Checking id3 v1.16.2 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking audiotags v0.5.0 [INFO] [stderr] Checking osu-music-extractor v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:31:28 [INFO] [stdout] | [INFO] [stdout] 31 | let directory: &Path = &file_path.parent().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `file_path.parent().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:66:8 [INFO] [stdout] | [INFO] [stdout] 66 | if !(extension == "osu") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(extension != "osu")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/main.rs:53:49 [INFO] [stdout] | [INFO] [stdout] 53 | fn copy(file_path: &DirEntry, output_dir: &Path) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:146:8 [INFO] [stdout] | [INFO] [stdout] 146 | if output_directory == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `output_directory.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/main.rs:155:23 [INFO] [stdout] | [INFO] [stdout] 155 | .map(|res| res.map(|e| e)) [INFO] [stdout] | ^^^^^^^^^^^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:159:20 [INFO] [stdout] | [INFO] [stdout] 159 | visit_dirs(&entry, output_path).unwrap(); [INFO] [stdout] | ^^^^^^ help: change this to: `entry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:31:28 [INFO] [stdout] | [INFO] [stdout] 31 | let directory: &Path = &file_path.parent().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `file_path.parent().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:66:8 [INFO] [stdout] | [INFO] [stdout] 66 | if !(extension == "osu") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(extension != "osu")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/main.rs:53:49 [INFO] [stdout] | [INFO] [stdout] 53 | fn copy(file_path: &DirEntry, output_dir: &Path) -> () { [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/main.rs:146:8 [INFO] [stdout] | [INFO] [stdout] 146 | if output_directory == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `output_directory.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/main.rs:155:23 [INFO] [stdout] | [INFO] [stdout] 155 | .map(|res| res.map(|e| e)) [INFO] [stdout] | ^^^^^^^^^^^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:159:20 [INFO] [stdout] | [INFO] [stdout] 159 | visit_dirs(&entry, output_path).unwrap(); [INFO] [stdout] | ^^^^^^ help: change this to: `entry` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.70s [INFO] running `Command { std: "docker" "inspect" "de2d698e80f42996695231918b77e9ff7db35edddf1ef029ea9e2b053ead3a54", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de2d698e80f42996695231918b77e9ff7db35edddf1ef029ea9e2b053ead3a54", kill_on_drop: false }` [INFO] [stdout] de2d698e80f42996695231918b77e9ff7db35edddf1ef029ea9e2b053ead3a54