[INFO] cloning repository https://github.com/SmallChungus1/rust_lab2
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SmallChungus1/rust_lab2" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSmallChungus1%2Frust_lab2", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSmallChungus1%2Frust_lab2'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] e21b660ed302c6689281414a8da153757afd1eec
[INFO] linting SmallChungus1/rust_lab2 against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSmallChungus1%2Frust_lab2" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/SmallChungus1/rust_lab2
[INFO] finished tweaking git repo https://github.com/SmallChungus1/rust_lab2
[INFO] tweaked toml for git repo https://github.com/SmallChungus1/rust_lab2 written to /workspace/builds/worker-3-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/SmallChungus1/rust_lab2 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/SmallChungus1/rust_lab2 already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 952660cf6216e858985e9d326e3cbc69476ae0f00054bffafbfcd3cd4ef7e7dc
[INFO] running `Command { std: "docker" "start" "-a" "952660cf6216e858985e9d326e3cbc69476ae0f00054bffafbfcd3cd4ef7e7dc", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "952660cf6216e858985e9d326e3cbc69476ae0f00054bffafbfcd3cd4ef7e7dc", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "952660cf6216e858985e9d326e3cbc69476ae0f00054bffafbfcd3cd4ef7e7dc", kill_on_drop: false }`
[INFO] [stdout] 952660cf6216e858985e9d326e3cbc69476ae0f00054bffafbfcd3cd4ef7e7dc
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 5fa861f1c74e6d752a0468a5e13bbd0c4a1e34694c94f6560f312242f8e7b1fd
[INFO] running `Command { std: "docker" "start" "-a" "5fa861f1c74e6d752a0468a5e13bbd0c4a1e34694c94f6560f312242f8e7b1fd", kill_on_drop: false }`
[INFO] [stderr]     Checking lab2 v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lab2/script_gen.rs:42:13
[INFO] [stdout]    |
[INFO] [stdout] 42 |             return Err(GENERATION_FAILURE);
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 42 -             return Err(GENERATION_FAILURE);
[INFO] [stdout] 42 +             Err(GENERATION_FAILURE)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Play`
[INFO] [stdout]   --> src/lab2/play.rs:23:5
[INFO] [stdout]    |
[INFO] [stdout] 23 | /     pub fn new() -> Self {
[INFO] [stdout] 24 | |         Self {
[INFO] [stdout] 25 | |             fragments: Vec::new(),
[INFO] [stdout] 26 | |         }
[INFO] [stdout] 27 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 22 + impl Default for Play {
[INFO] [stdout] 23 +     fn default() -> Self {
[INFO] [stdout] 24 +         Self::new()
[INFO] [stdout] 25 +     }
[INFO] [stdout] 26 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this match could be written as a `let` statement
[INFO] [stdout]   --> src/lab2/play.rs:39:13
[INFO] [stdout]    |
[INFO] [stdout] 39 | /             match a_cfg {(is_title, text_field) => { //both is_title and text_field are refs
[INFO] [stdout] 40 | |                 if *is_title{
[INFO] [stdout] 41 | |                     title_str = text_field.to_string();
[INFO] [stdout] 42 | |                 }else{
[INFO] [stdout] ...  |
[INFO] [stdout] 60 | |             }}
[INFO] [stdout]    | |______________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
[INFO] [stdout]    = note: `#[warn(clippy::match_single_binding)]` on by default
[INFO] [stdout] help: consider using a `let` statement
[INFO] [stdout]    |
[INFO] [stdout] 39 ~             let (is_title, text_field) = a_cfg;
[INFO] [stdout] 40 +             if *is_title{
[INFO] [stdout] 41 +                 title_str = text_field.to_string();
[INFO] [stdout] 42 +             }else{
[INFO] [stdout] 43 +                 //1: push title_str init SceneFrag to vec of fragments and update idx
[INFO] [stdout] 44 +                 self.fragments.push(SceneFragment::new(&title_str));
[INFO] [stdout] 45 +                 latest_frag_idx = self.fragments.len() - 1;
[INFO] [stdout] 46 +                 //2: reset title_str to empty
[INFO] [stdout] 47 +                 title_str = String::new();
[INFO] [stdout] 48 +                 //3: pass text_field to new fragment prepare method method and 4 match result on errors
[INFO] [stdout] 49 +                 match self.fragments[latest_frag_idx].prepare(text_field){
[INFO] [stdout] 50 +                     Ok(_) => {
[INFO] [stdout] 51 +                         //do nothing
[INFO] [stdout] 52 +                     },
[INFO] [stdout] 53 +                     Err(e_code) => {
[INFO] [stdout] 54 +                         eprintln!("Error from process config of Play after calling prepare on Fragment: {}", e_code);
[INFO] [stdout] 55 +                         return Err(GENERATION_FAILURE);
[INFO] [stdout] 56 +                     },
[INFO] [stdout] 57 +                 }
[INFO] [stdout] 58 +                 
[INFO] [stdout] 59 +             }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do
[INFO] [stdout]   --> src/lab2/play.rs:66:40
[INFO] [stdout]    |
[INFO] [stdout] 66 |     pub fn add_config(&self, cfg_line: &String, play_cfg: &mut ScriptConfig){
[INFO] [stdout]    |                                        ^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 66 -     pub fn add_config(&self, cfg_line: &String, play_cfg: &mut ScriptConfig){
[INFO] [stdout] 66 +     pub fn add_config(&self, cfg_line: &str, play_cfg: &mut ScriptConfig){
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lab2/play.rs:102:39
[INFO] [stdout]     |
[INFO] [stdout] 102 |         match grab_trimmed_file_lines(&cfg_fname, &mut cfg_lines) {
[INFO] [stdout]     |                                       ^^^^^^^^^^ help: change this to: `cfg_fname`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lab2/play.rs:138:41
[INFO] [stdout]     |
[INFO] [stdout] 138 |         if self.fragments.is_empty() || !self.fragments[0].scene_title.split_whitespace().next().is_some(){
[INFO] [stdout]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.fragments[0].scene_title.split_whitespace().next().is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/lab2/player.rs:28:12
[INFO] [stdout]    |
[INFO] [stdout] 28 |         if unparsed_line.len() > 0 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!unparsed_line.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lab2/player.rs:50:54
[INFO] [stdout]    |
[INFO] [stdout] 50 |         if let Err(e_code) = grab_trimmed_file_lines(&part_name, &mut cur_file_line_vec) {
[INFO] [stdout]    |                                                      ^^^^^^^^^^ help: change this to: `part_name`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lab2/script_gen.rs:42:13
[INFO] [stdout]    |
[INFO] [stdout] 42 |             return Err(GENERATION_FAILURE);
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 42 -             return Err(GENERATION_FAILURE);
[INFO] [stdout] 42 +             Err(GENERATION_FAILURE)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you should consider adding a `Default` implementation for `Play`
[INFO] [stdout]   --> src/lab2/play.rs:23:5
[INFO] [stdout]    |
[INFO] [stdout] 23 | /     pub fn new() -> Self {
[INFO] [stdout] 24 | |         Self {
[INFO] [stdout] 25 | |             fragments: Vec::new(),
[INFO] [stdout] 26 | |         }
[INFO] [stdout] 27 | |     }
[INFO] [stdout]    | |_____^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stdout]    = note: `#[warn(clippy::new_without_default)]` on by default
[INFO] [stdout] help: try adding this
[INFO] [stdout]    |
[INFO] [stdout] 22 + impl Default for Play {
[INFO] [stdout] 23 +     fn default() -> Self {
[INFO] [stdout] 24 +         Self::new()
[INFO] [stdout] 25 +     }
[INFO] [stdout] 26 + }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lab2/player.rs:84:13
[INFO] [stdout]    |
[INFO] [stdout] 84 |             return Some(self.char_lines[self.cur_entry_idx].0)
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 84 -             return Some(self.char_lines[self.cur_entry_idx].0)
[INFO] [stdout] 84 +             Some(self.char_lines[self.cur_entry_idx].0)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lab2/player.rs:86:13
[INFO] [stdout]    |
[INFO] [stdout] 86 |             return None
[INFO] [stdout]    |             ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 86 -             return None
[INFO] [stdout] 86 +             None
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lab2/player.rs:101:9
[INFO] [stdout]     |
[INFO] [stdout] 101 |         return false
[INFO] [stdout]     |         ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 101 -         return false
[INFO] [stdout] 101 +         false
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/lab2/player.rs:95:12
[INFO] [stdout]    |
[INFO] [stdout] 95 |         if self.char_lines.len() == 0 && other.char_lines.len() == 0{
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.char_lines.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/lab2/player.rs:95:42
[INFO] [stdout]    |
[INFO] [stdout] 95 |         if self.char_lines.len() == 0 && other.char_lines.len() == 0{
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `other.char_lines.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/lab2/player.rs:97:18
[INFO] [stdout]    |
[INFO] [stdout] 97 |         }else if self.char_lines.len() != 0 && other.char_lines.len() != 0{
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.char_lines.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/lab2/player.rs:97:48
[INFO] [stdout]    |
[INFO] [stdout] 97 |         }else if self.char_lines.len() != 0 && other.char_lines.len() != 0{
[INFO] [stdout]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!other.char_lines.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this match could be written as a `let` statement
[INFO] [stdout]   --> src/lab2/play.rs:39:13
[INFO] [stdout]    |
[INFO] [stdout] 39 | /             match a_cfg {(is_title, text_field) => { //both is_title and text_field are refs
[INFO] [stdout] 40 | |                 if *is_title{
[INFO] [stdout] 41 | |                     title_str = text_field.to_string();
[INFO] [stdout] 42 | |                 }else{
[INFO] [stdout] ...  |
[INFO] [stdout] 60 | |             }}
[INFO] [stdout]    | |______________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
[INFO] [stdout]    = note: `#[warn(clippy::match_single_binding)]` on by default
[INFO] [stdout] help: consider using a `let` statement
[INFO] [stdout]    |
[INFO] [stdout] 39 ~             let (is_title, text_field) = a_cfg;
[INFO] [stdout] 40 +             if *is_title{
[INFO] [stdout] 41 +                 title_str = text_field.to_string();
[INFO] [stdout] 42 +             }else{
[INFO] [stdout] 43 +                 //1: push title_str init SceneFrag to vec of fragments and update idx
[INFO] [stdout] 44 +                 self.fragments.push(SceneFragment::new(&title_str));
[INFO] [stdout] 45 +                 latest_frag_idx = self.fragments.len() - 1;
[INFO] [stdout] 46 +                 //2: reset title_str to empty
[INFO] [stdout] 47 +                 title_str = String::new();
[INFO] [stdout] 48 +                 //3: pass text_field to new fragment prepare method method and 4 match result on errors
[INFO] [stdout] 49 +                 match self.fragments[latest_frag_idx].prepare(text_field){
[INFO] [stdout] 50 +                     Ok(_) => {
[INFO] [stdout] 51 +                         //do nothing
[INFO] [stdout] 52 +                     },
[INFO] [stdout] 53 +                     Err(e_code) => {
[INFO] [stdout] 54 +                         eprintln!("Error from process config of Play after calling prepare on Fragment: {}", e_code);
[INFO] [stdout] 55 +                         return Err(GENERATION_FAILURE);
[INFO] [stdout] 56 +                     },
[INFO] [stdout] 57 +                 }
[INFO] [stdout] 58 +                 
[INFO] [stdout] 59 +             }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type
[INFO] [stdout]    --> src/lab2/player.rs:111:1
[INFO] [stdout]     |
[INFO] [stdout] 111 | / impl PartialOrd for Player{
[INFO] [stdout] 112 | |     fn partial_cmp(&self, other: &Self) -> Option<Ordering>{
[INFO] [stdout] 113 | |         if self.char_lines.len() == 0 && other.char_lines.len() != 0 {
[INFO] [stdout] 114 | |             return Some(Ordering::Less)
[INFO] [stdout] ...   |
[INFO] [stdout] 129 | | }
[INFO] [stdout]     | |_^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl
[INFO] [stdout]     = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 112 -     fn partial_cmp(&self, other: &Self) -> Option<Ordering>{
[INFO] [stdout] 113 -         if self.char_lines.len() == 0 && other.char_lines.len() != 0 {
[INFO] [stdout] 114 -             return Some(Ordering::Less)
[INFO] [stdout] 115 -         }
[INFO] [stdout] 116 -         if self.char_lines.len() != 0 && other.char_lines.len() == 0 {
[INFO] [stdout] 117 -             return Some(Ordering::Greater)
[INFO] [stdout] 118 -         }
[INFO] [stdout] 119 -         //first line number comparison
[INFO] [stdout] 120 -         if self.char_lines[0].0 < other.char_lines[0].0{
[INFO] [stdout] 121 -             return Some(Ordering::Less)
[INFO] [stdout] 122 -         }
[INFO] [stdout] 123 -         if self.char_lines[0].0 > other.char_lines[0].0{
[INFO] [stdout] 124 -             return Some(Ordering::Greater)
[INFO] [stdout] 125 -         }
[INFO] [stdout] 126 -         return Some(Ordering::Equal)
[INFO] [stdout] 127 - 
[INFO] [stdout] 128 -     }
[INFO] [stdout] 112 +     fn partial_cmp(&self, other: &Self) -> Option<Ordering>{ Some(self.cmp(other)) }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lab2/player.rs:126:9
[INFO] [stdout]     |
[INFO] [stdout] 126 |         return Some(Ordering::Equal)
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 126 -         return Some(Ordering::Equal)
[INFO] [stdout] 126 +         Some(Ordering::Equal)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lab2/player.rs:113:12
[INFO] [stdout]     |
[INFO] [stdout] 113 |         if self.char_lines.len() == 0 && other.char_lines.len() != 0 {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.char_lines.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lab2/player.rs:113:42
[INFO] [stdout]     |
[INFO] [stdout] 113 |         if self.char_lines.len() == 0 && other.char_lines.len() != 0 {
[INFO] [stdout]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!other.char_lines.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lab2/player.rs:116:12
[INFO] [stdout]     |
[INFO] [stdout] 116 |         if self.char_lines.len() != 0 && other.char_lines.len() == 0 {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.char_lines.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lab2/player.rs:116:42
[INFO] [stdout]     |
[INFO] [stdout] 116 |         if self.char_lines.len() != 0 && other.char_lines.len() == 0 {
[INFO] [stdout]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `other.char_lines.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do
[INFO] [stdout]   --> src/lab2/play.rs:66:40
[INFO] [stdout]    |
[INFO] [stdout] 66 |     pub fn add_config(&self, cfg_line: &String, play_cfg: &mut ScriptConfig){
[INFO] [stdout]    |                                        ^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 66 -     pub fn add_config(&self, cfg_line: &String, play_cfg: &mut ScriptConfig){
[INFO] [stdout] 66 +     pub fn add_config(&self, cfg_line: &str, play_cfg: &mut ScriptConfig){
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lab2/player.rs:147:9
[INFO] [stdout]     |
[INFO] [stdout] 147 |         return Ordering::Equal
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 147 -         return Ordering::Equal
[INFO] [stdout] 147 +         Ordering::Equal
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lab2/player.rs:134:12
[INFO] [stdout]     |
[INFO] [stdout] 134 |         if self.char_lines.len() == 0 && other.char_lines.len() != 0 {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.char_lines.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lab2/player.rs:134:42
[INFO] [stdout]     |
[INFO] [stdout] 134 |         if self.char_lines.len() == 0 && other.char_lines.len() != 0 {
[INFO] [stdout]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!other.char_lines.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lab2/player.rs:137:12
[INFO] [stdout]     |
[INFO] [stdout] 137 |         if self.char_lines.len() != 0 && other.char_lines.len() == 0 {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.char_lines.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lab2/player.rs:137:42
[INFO] [stdout]     |
[INFO] [stdout] 137 |         if self.char_lines.len() != 0 && other.char_lines.len() == 0 {
[INFO] [stdout]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `other.char_lines.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lab2/play.rs:102:39
[INFO] [stdout]     |
[INFO] [stdout] 102 |         match grab_trimmed_file_lines(&cfg_fname, &mut cfg_lines) {
[INFO] [stdout]     |                                       ^^^^^^^^^^ help: change this to: `cfg_fname`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lab2/play.rs:138:41
[INFO] [stdout]     |
[INFO] [stdout] 138 |         if self.fragments.is_empty() || !self.fragments[0].scene_title.split_whitespace().next().is_some(){
[INFO] [stdout]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.fragments[0].scene_title.split_whitespace().next().is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this match could be written as a `let` statement
[INFO] [stdout]   --> src/lab2/scene_fragments.rs:36:13
[INFO] [stdout]    |
[INFO] [stdout] 36 | / ...   match a_cfg {(char_name, speak_file) => {
[INFO] [stdout] 37 | | ...     let mut new_player = Player::new(&char_name); //need mut since prepare take mut &self
[INFO] [stdout] 38 | | ...
[INFO] [stdout] 39 | | ...     if let Err(e) = new_player.prepare(speak_file){ //TODO: confirm if this is the prepare function he wants us to call and if...
[INFO] [stdout] ...  |
[INFO] [stdout] 44 | | ...     self.chars_in_play.push(new_player);
[INFO] [stdout] 45 | | ...   }}
[INFO] [stdout]    | |________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
[INFO] [stdout] help: consider using a `let` statement
[INFO] [stdout]    |
[INFO] [stdout] 36 ~             let (char_name, speak_file) = a_cfg;
[INFO] [stdout] 37 +             {
[INFO] [stdout] 38 +               let mut new_player = Player::new(&char_name); //need mut since prepare take mut &self
[INFO] [stdout] 39 + 
[INFO] [stdout] 40 +               if let Err(e) = new_player.prepare(speak_file){ //TODO: confirm if this is the prepare function he wants us to call and if we should call this before or after push to vec?
[INFO] [stdout] 41 +                 eprintln!("Error from process_config of SceneFragment: {}", e);
[INFO] [stdout] 42 +                 return Err(GENERATION_FAILURE);
[INFO] [stdout] 43 +               }
[INFO] [stdout] 44 +               
[INFO] [stdout] 45 +               self.chars_in_play.push(new_player);
[INFO] [stdout] 46 +             }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lab2/scene_fragments.rs:37:48
[INFO] [stdout]    |
[INFO] [stdout] 37 |               let mut new_player = Player::new(&char_name); //need mut since prepare take mut &self
[INFO] [stdout]    |                                                ^^^^^^^^^^ help: change this to: `char_name`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do
[INFO] [stdout]   --> src/lab2/scene_fragments.rs:51:40
[INFO] [stdout]    |
[INFO] [stdout] 51 |     pub fn add_config(&self, cfg_line: &String, play_cfg: &mut PlayConfig){
[INFO] [stdout]    |                                        ^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 51 -     pub fn add_config(&self, cfg_line: &String, play_cfg: &mut PlayConfig){
[INFO] [stdout] 51 +     pub fn add_config(&self, cfg_line: &str, play_cfg: &mut PlayConfig){
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/lab2/player.rs:28:12
[INFO] [stdout]    |
[INFO] [stdout] 28 |         if unparsed_line.len() > 0 {
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!unparsed_line.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lab2/scene_fragments.rs:77:39
[INFO] [stdout]    |
[INFO] [stdout] 77 |         match grab_trimmed_file_lines(&cfg_fname, &mut cfg_lines) {
[INFO] [stdout]    |                                       ^^^^^^^^^^ help: change this to: `cfg_fname`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lab2/player.rs:50:54
[INFO] [stdout]    |
[INFO] [stdout] 50 |         if let Err(e_code) = grab_trimmed_file_lines(&part_name, &mut cur_file_line_vec) {
[INFO] [stdout]    |                                                      ^^^^^^^^^^ help: change this to: `part_name`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lab2/player.rs:84:13
[INFO] [stdout]    |
[INFO] [stdout] 84 |             return Some(self.char_lines[self.cur_entry_idx].0)
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 84 -             return Some(self.char_lines[self.cur_entry_idx].0)
[INFO] [stdout] 84 +             Some(self.char_lines[self.cur_entry_idx].0)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/lab2/player.rs:86:13
[INFO] [stdout]    |
[INFO] [stdout] 86 |             return None
[INFO] [stdout]    |             ^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 86 -             return None
[INFO] [stdout] 86 +             None
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/lab2/scene_fragments.rs:135:17
[INFO] [stdout]     |
[INFO] [stdout] 135 | /                 if !linenum_insert_status{
[INFO] [stdout] 136 | |                     if WHINGE.load(Ordering::SeqCst){
[INFO] [stdout] 137 | |                         eprintln!("WHINGE Warning: duplicate line detected for line number: {}", line_num);
[INFO] [stdout] 138 | |                     }
[INFO] [stdout] 139 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 135 ~                 if !linenum_insert_status
[INFO] [stdout] 136 ~                     && WHINGE.load(Ordering::SeqCst){
[INFO] [stdout] 137 |                         eprintln!("WHINGE Warning: duplicate line detected for line number: {}", line_num);
[INFO] [stdout] 138 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lab2/player.rs:101:9
[INFO] [stdout]     |
[INFO] [stdout] 101 |         return false
[INFO] [stdout]     |         ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 101 -         return false
[INFO] [stdout] 101 +         false
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/lab2/player.rs:95:12
[INFO] [stdout]    |
[INFO] [stdout] 95 |         if self.char_lines.len() == 0 && other.char_lines.len() == 0{
[INFO] [stdout]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.char_lines.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/lab2/scene_fragments.rs:147:9
[INFO] [stdout]     |
[INFO] [stdout] 147 | /         if WHINGE.load(Ordering::SeqCst) {
[INFO] [stdout] 148 | |             if linenum_and_speaker_vec[0].0 != 0{
[INFO] [stdout] 149 | |                 eprintln!("WHINGE Warning: line number should start at 0!");
[INFO] [stdout] ...   |
[INFO] [stdout] 152 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 147 ~         if WHINGE.load(Ordering::SeqCst)
[INFO] [stdout] 148 ~             && linenum_and_speaker_vec[0].0 != 0{
[INFO] [stdout] 149 |                 eprintln!("WHINGE Warning: line number should start at 0!");
[INFO] [stdout] 150 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/lab2/player.rs:95:42
[INFO] [stdout]    |
[INFO] [stdout] 95 |         if self.char_lines.len() == 0 && other.char_lines.len() == 0{
[INFO] [stdout]    |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `other.char_lines.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/lab2/player.rs:97:18
[INFO] [stdout]    |
[INFO] [stdout] 97 |         }else if self.char_lines.len() != 0 && other.char_lines.len() != 0{
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.char_lines.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/lab2/player.rs:97:48
[INFO] [stdout]    |
[INFO] [stdout] 97 |         }else if self.char_lines.len() != 0 && other.char_lines.len() != 0{
[INFO] [stdout]    |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!other.char_lines.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type
[INFO] [stdout]    --> src/lab2/player.rs:111:1
[INFO] [stdout]     |
[INFO] [stdout] 111 | / impl PartialOrd for Player{
[INFO] [stdout] 112 | |     fn partial_cmp(&self, other: &Self) -> Option<Ordering>{
[INFO] [stdout] 113 | |         if self.char_lines.len() == 0 && other.char_lines.len() != 0 {
[INFO] [stdout] 114 | |             return Some(Ordering::Less)
[INFO] [stdout] ...   |
[INFO] [stdout] 129 | | }
[INFO] [stdout]     | |_^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl
[INFO] [stdout]     = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 112 -     fn partial_cmp(&self, other: &Self) -> Option<Ordering>{
[INFO] [stdout] 113 -         if self.char_lines.len() == 0 && other.char_lines.len() != 0 {
[INFO] [stdout] 114 -             return Some(Ordering::Less)
[INFO] [stdout] 115 -         }
[INFO] [stdout] 116 -         if self.char_lines.len() != 0 && other.char_lines.len() == 0 {
[INFO] [stdout] 117 -             return Some(Ordering::Greater)
[INFO] [stdout] 118 -         }
[INFO] [stdout] 119 -         //first line number comparison
[INFO] [stdout] 120 -         if self.char_lines[0].0 < other.char_lines[0].0{
[INFO] [stdout] 121 -             return Some(Ordering::Less)
[INFO] [stdout] 122 -         }
[INFO] [stdout] 123 -         if self.char_lines[0].0 > other.char_lines[0].0{
[INFO] [stdout] 124 -             return Some(Ordering::Greater)
[INFO] [stdout] 125 -         }
[INFO] [stdout] 126 -         return Some(Ordering::Equal)
[INFO] [stdout] 127 - 
[INFO] [stdout] 128 -     }
[INFO] [stdout] 112 +     fn partial_cmp(&self, other: &Self) -> Option<Ordering>{ Some(self.cmp(other)) }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lab2/player.rs:126:9
[INFO] [stdout]     |
[INFO] [stdout] 126 |         return Some(Ordering::Equal)
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 126 -         return Some(Ordering::Equal)
[INFO] [stdout] 126 +         Some(Ordering::Equal)
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lab2/player.rs:113:12
[INFO] [stdout]     |
[INFO] [stdout] 113 |         if self.char_lines.len() == 0 && other.char_lines.len() != 0 {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.char_lines.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lab2/player.rs:113:42
[INFO] [stdout]     |
[INFO] [stdout] 113 |         if self.char_lines.len() == 0 && other.char_lines.len() != 0 {
[INFO] [stdout]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!other.char_lines.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lab2/player.rs:116:12
[INFO] [stdout]     |
[INFO] [stdout] 116 |         if self.char_lines.len() != 0 && other.char_lines.len() == 0 {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.char_lines.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lab2/player.rs:116:42
[INFO] [stdout]     |
[INFO] [stdout] 116 |         if self.char_lines.len() != 0 && other.char_lines.len() == 0 {
[INFO] [stdout]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `other.char_lines.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/lab2/player.rs:147:9
[INFO] [stdout]     |
[INFO] [stdout] 147 |         return Ordering::Equal
[INFO] [stdout]     |         ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 147 -         return Ordering::Equal
[INFO] [stdout] 147 +         Ordering::Equal
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lab2/player.rs:134:12
[INFO] [stdout]     |
[INFO] [stdout] 134 |         if self.char_lines.len() == 0 && other.char_lines.len() != 0 {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.char_lines.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lab2/player.rs:134:42
[INFO] [stdout]     |
[INFO] [stdout] 134 |         if self.char_lines.len() == 0 && other.char_lines.len() != 0 {
[INFO] [stdout]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!other.char_lines.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lab2/player.rs:137:12
[INFO] [stdout]     |
[INFO] [stdout] 137 |         if self.char_lines.len() != 0 && other.char_lines.len() == 0 {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.char_lines.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/lab2/player.rs:137:42
[INFO] [stdout]     |
[INFO] [stdout] 137 |         if self.char_lines.len() != 0 && other.char_lines.len() == 0 {
[INFO] [stdout]     |                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `other.char_lines.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:60:5
[INFO] [stdout]    |
[INFO] [stdout] 60 |     return ReturnWrapper::new(SUCCESS_CODE)
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 60 -     return ReturnWrapper::new(SUCCESS_CODE)
[INFO] [stdout] 60 +     ReturnWrapper::new(SUCCESS_CODE)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this match could be written as a `let` statement
[INFO] [stdout]   --> src/lab2/scene_fragments.rs:36:13
[INFO] [stdout]    |
[INFO] [stdout] 36 | / ...   match a_cfg {(char_name, speak_file) => {
[INFO] [stdout] 37 | | ...     let mut new_player = Player::new(&char_name); //need mut since prepare take mut &self
[INFO] [stdout] 38 | | ...
[INFO] [stdout] 39 | | ...     if let Err(e) = new_player.prepare(speak_file){ //TODO: confirm if this is the prepare function he wants us to call and if...
[INFO] [stdout] ...  |
[INFO] [stdout] 44 | | ...     self.chars_in_play.push(new_player);
[INFO] [stdout] 45 | | ...   }}
[INFO] [stdout]    | |________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_single_binding
[INFO] [stdout] help: consider using a `let` statement
[INFO] [stdout]    |
[INFO] [stdout] 36 ~             let (char_name, speak_file) = a_cfg;
[INFO] [stdout] 37 +             {
[INFO] [stdout] 38 +               let mut new_player = Player::new(&char_name); //need mut since prepare take mut &self
[INFO] [stdout] 39 + 
[INFO] [stdout] 40 +               if let Err(e) = new_player.prepare(speak_file){ //TODO: confirm if this is the prepare function he wants us to call and if we should call this before or after push to vec?
[INFO] [stdout] 41 +                 eprintln!("Error from process_config of SceneFragment: {}", e);
[INFO] [stdout] 42 +                 return Err(GENERATION_FAILURE);
[INFO] [stdout] 43 +               }
[INFO] [stdout] 44 +               
[INFO] [stdout] 45 +               self.chars_in_play.push(new_player);
[INFO] [stdout] 46 +             }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lab2/scene_fragments.rs:37:48
[INFO] [stdout]    |
[INFO] [stdout] 37 |               let mut new_player = Player::new(&char_name); //need mut since prepare take mut &self
[INFO] [stdout]    |                                                ^^^^^^^^^^ help: change this to: `char_name`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do
[INFO] [stdout]   --> src/lab2/scene_fragments.rs:51:40
[INFO] [stdout]    |
[INFO] [stdout] 51 |     pub fn add_config(&self, cfg_line: &String, play_cfg: &mut PlayConfig){
[INFO] [stdout]    |                                        ^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 51 -     pub fn add_config(&self, cfg_line: &String, play_cfg: &mut PlayConfig){
[INFO] [stdout] 51 +     pub fn add_config(&self, cfg_line: &str, play_cfg: &mut PlayConfig){
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/lab2/scene_fragments.rs:77:39
[INFO] [stdout]    |
[INFO] [stdout] 77 |         match grab_trimmed_file_lines(&cfg_fname, &mut cfg_lines) {
[INFO] [stdout]    |                                       ^^^^^^^^^^ help: change this to: `cfg_fname`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/lab2/scene_fragments.rs:135:17
[INFO] [stdout]     |
[INFO] [stdout] 135 | /                 if !linenum_insert_status{
[INFO] [stdout] 136 | |                     if WHINGE.load(Ordering::SeqCst){
[INFO] [stdout] 137 | |                         eprintln!("WHINGE Warning: duplicate line detected for line number: {}", line_num);
[INFO] [stdout] 138 | |                     }
[INFO] [stdout] 139 | |                 }
[INFO] [stdout]     | |_________________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]     = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 135 ~                 if !linenum_insert_status
[INFO] [stdout] 136 ~                     && WHINGE.load(Ordering::SeqCst){
[INFO] [stdout] 137 |                         eprintln!("WHINGE Warning: duplicate line detected for line number: {}", line_num);
[INFO] [stdout] 138 ~                     }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]    --> src/lab2/scene_fragments.rs:147:9
[INFO] [stdout]     |
[INFO] [stdout] 147 | /         if WHINGE.load(Ordering::SeqCst) {
[INFO] [stdout] 148 | |             if linenum_and_speaker_vec[0].0 != 0{
[INFO] [stdout] 149 | |                 eprintln!("WHINGE Warning: line number should start at 0!");
[INFO] [stdout] ...   |
[INFO] [stdout] 152 | |         }
[INFO] [stdout]     | |_________^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]     |
[INFO] [stdout] 147 ~         if WHINGE.load(Ordering::SeqCst)
[INFO] [stdout] 148 ~             && linenum_and_speaker_vec[0].0 != 0{
[INFO] [stdout] 149 |                 eprintln!("WHINGE Warning: line number should start at 0!");
[INFO] [stdout] 150 ~             }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:60:5
[INFO] [stdout]    |
[INFO] [stdout] 60 |     return ReturnWrapper::new(SUCCESS_CODE)
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 60 -     return ReturnWrapper::new(SUCCESS_CODE)
[INFO] [stdout] 60 +     ReturnWrapper::new(SUCCESS_CODE)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.37s
[INFO] running `Command { std: "docker" "inspect" "5fa861f1c74e6d752a0468a5e13bbd0c4a1e34694c94f6560f312242f8e7b1fd", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "5fa861f1c74e6d752a0468a5e13bbd0c4a1e34694c94f6560f312242f8e7b1fd", kill_on_drop: false }`
[INFO] [stdout] 5fa861f1c74e6d752a0468a5e13bbd0c4a1e34694c94f6560f312242f8e7b1fd