[INFO] cloning repository https://github.com/Sk3pz/ape_bot [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Sk3pz/ape_bot" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSk3pz%2Fape_bot", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSk3pz%2Fape_bot'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6d9f1a1ecf9e2a46cfab13fda7641856d42bc98f [INFO] linting Sk3pz/ape_bot/6d9f1a1ecf9e2a46cfab13fda7641856d42bc98f against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSk3pz%2Fape_bot" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Sk3pz/ape_bot [INFO] finished tweaking git repo https://github.com/Sk3pz/ape_bot [INFO] tweaked toml for git repo https://github.com/Sk3pz/ape_bot written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Sk3pz/ape_bot on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Sk3pz/ape_bot already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded uwl v0.6.0 [INFO] [stderr] Downloaded levenshtein v1.0.5 [INFO] [stderr] Downloaded smallvec v1.15.0 [INFO] [stderr] Downloaded iana-time-zone v0.1.63 [INFO] [stderr] Downloaded bytecount v0.6.8 [INFO] [stderr] Downloaded serde_cow v0.1.2 [INFO] [stderr] Downloaded typemap_rev v0.3.0 [INFO] [stderr] Downloaded tagptr v0.2.0 [INFO] [stderr] Downloaded webpki-roots v0.26.11 [INFO] [stderr] Downloaded tokio-rustls v0.24.1 [INFO] [stderr] Downloaded dotenv v0.15.0 [INFO] [stderr] Downloaded dashmap v5.5.3 [INFO] [stderr] Downloaded async-trait v0.1.88 [INFO] [stderr] Downloaded data-encoding v2.9.0 [INFO] [stderr] Downloaded futures v0.3.31 [INFO] [stderr] Downloaded tracing-core v0.1.33 [INFO] [stderr] Downloaded http v1.3.1 [INFO] [stderr] Downloaded cc v1.2.23 [INFO] [stderr] Downloaded hashbrown v0.15.3 [INFO] [stderr] Downloaded rustls-webpki v0.102.8 [INFO] [stderr] Downloaded rustls-webpki v0.101.7 [INFO] [stderr] Downloaded hashbrown v0.14.5 [INFO] [stderr] Downloaded pulldown-cmark v0.9.6 [INFO] [stderr] Downloaded webpki-roots v0.25.4 [INFO] [stderr] Downloaded chrono v0.4.41 [INFO] [stderr] Downloaded webpki-roots v1.0.0 [INFO] [stderr] Downloaded icu_properties_data v2.0.0 [INFO] [stderr] Downloaded bumpalo v3.17.0 [INFO] [stderr] Downloaded rustls v0.21.12 [INFO] [stderr] Downloaded rustls v0.22.4 [INFO] [stderr] Downloaded tempfile v3.20.0 [INFO] [stderr] Downloaded mini-moka v0.10.3 [INFO] [stderr] Downloaded tungstenite v0.21.0 [INFO] [stderr] Downloaded rustls-pki-types v1.12.0 [INFO] [stderr] Downloaded tracing-attributes v0.1.28 [INFO] [stderr] Downloaded windows-strings v0.4.1 [INFO] [stderr] Downloaded windows-core v0.61.1 [INFO] [stderr] Downloaded serenity v0.12.4 [INFO] [stderr] Downloaded error-chain v0.12.4 [INFO] [stderr] Downloaded errno v0.3.12 [INFO] [stderr] Downloaded zeroize v1.8.1 [INFO] [stderr] Downloaded command_attr v0.5.3 [INFO] [stderr] Downloaded hyper-rustls v0.24.2 [INFO] [stderr] Downloaded mime_guess v2.0.5 [INFO] [stderr] Downloaded sct v0.7.1 [INFO] [stderr] Downloaded wasm-streams v0.4.2 [INFO] [stderr] Downloaded web-sys v0.3.77 [INFO] [stderr] Downloaded tokio-tungstenite v0.21.0 [INFO] [stderr] Downloaded camino v1.1.9 [INFO] [stderr] Downloaded cargo_metadata v0.14.2 [INFO] [stderr] Downloaded glob v0.3.2 [INFO] [stderr] Downloaded triomphe v0.1.14 [INFO] [stderr] Downloaded semver v1.0.26 [INFO] [stderr] Downloaded tokio v1.45.0 [INFO] [stderr] Downloaded fxhash v0.2.1 [INFO] [stderr] Downloaded wasm-bindgen-futures v0.4.50 [INFO] [stderr] Downloaded futures-macro v0.3.31 [INFO] [stderr] Downloaded tokio-rustls v0.25.0 [INFO] [stderr] Downloaded android-tzdata v0.1.1 [INFO] [stderr] Downloaded rustversion v1.0.20 [INFO] [stderr] Downloaded windows-interface v0.59.1 [INFO] [stderr] Downloaded windows-result v0.3.3 [INFO] [stderr] Downloaded cargo-platform v0.1.9 [INFO] [stderr] Downloaded typesize-derive v0.1.11 [INFO] [stderr] Downloaded getrandom v0.2.16 [INFO] [stderr] Downloaded secrecy v0.8.0 [INFO] [stderr] Downloaded icu_properties v2.0.0 [INFO] [stderr] Downloaded windows-implement v0.60.0 [INFO] [stderr] Downloaded skeptic v0.13.7 [INFO] [stderr] Downloaded socket2 v0.5.9 [INFO] [stderr] Downloaded windows-link v0.1.1 [INFO] [stderr] Downloaded unicase v2.8.1 [INFO] [stderr] Downloaded typesize v0.1.14 [INFO] [stderr] Downloaded tokio-macros v2.5.0 [INFO] [stderr] Downloaded ring v0.17.14 [INFO] [stderr] Downloaded better_term v1.4.61 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a708ed499a397c8d592a37fe9eefea7eed763f82421e69251893dac0faf8f473 [INFO] running `Command { std: "docker" "start" "-a" "a708ed499a397c8d592a37fe9eefea7eed763f82421e69251893dac0faf8f473", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a708ed499a397c8d592a37fe9eefea7eed763f82421e69251893dac0faf8f473", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a708ed499a397c8d592a37fe9eefea7eed763f82421e69251893dac0faf8f473", kill_on_drop: false }` [INFO] [stdout] a708ed499a397c8d592a37fe9eefea7eed763f82421e69251893dac0faf8f473 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fb0c8f3e21d4d089a09a3975f5cb056d4a746e74e7183b4b2c92a499bee56403 [INFO] running `Command { std: "docker" "start" "-a" "fb0c8f3e21d4d089a09a3975f5cb056d4a746e74e7183b4b2c92a499bee56403", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.95 [INFO] [stderr] Compiling unicode-ident v1.0.18 [INFO] [stderr] Compiling libc v0.2.172 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking pin-project-lite v0.2.16 [INFO] [stderr] Checking bytes v1.10.1 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking itoa v1.0.15 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking writeable v0.6.1 [INFO] [stderr] Compiling cc v1.2.23 [INFO] [stderr] Checking smallvec v1.15.0 [INFO] [stderr] Checking litemap v0.8.0 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling typenum v1.18.0 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking futures-sink v0.3.31 [INFO] [stderr] Compiling icu_normalizer_data v2.0.0 [INFO] [stderr] Compiling icu_properties_data v2.0.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking rustls-pki-types v1.12.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling quote v1.0.40 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Compiling syn v2.0.101 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking socket2 v0.5.9 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking mio v1.0.3 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Compiling zerocopy v0.8.25 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking tracing-core v0.1.33 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking equivalent v1.0.2 [INFO] [stderr] Checking utf8_iter v1.0.4 [INFO] [stderr] Compiling rustls v0.22.4 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking hashbrown v0.15.3 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Compiling unicase v2.8.1 [INFO] [stderr] Checking indexmap v2.9.0 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking tower-service v0.3.3 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking cpufeatures v0.2.17 [INFO] [stderr] Checking ryu v1.0.20 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking webpki-roots v1.0.0 [INFO] [stderr] Checking http v1.3.1 [INFO] [stderr] Checking data-encoding v2.9.0 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking miniz_oxide v0.8.8 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking webpki-roots v0.26.11 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking encoding_rs v0.8.35 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking time-core v0.1.4 [INFO] [stderr] Compiling serenity v0.12.4 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking iana-time-zone v0.1.63 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking webpki-roots v0.25.4 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking ipnet v2.11.0 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking flate2 v1.1.1 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking levenshtein v1.0.5 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Checking typemap_rev v0.3.0 [INFO] [stderr] Checking uwl v0.6.0 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Checking better_term v1.4.61 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling tracing-attributes v0.1.28 [INFO] [stderr] Checking tokio v1.45.0 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.102.8 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Compiling async-trait v0.1.88 [INFO] [stderr] Checking zerovec v0.11.2 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Compiling command_attr v0.5.3 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.0 [INFO] [stderr] Checking tokio-util v0.7.15 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking deranged v0.4.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking serde_cow v0.1.2 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking chrono v0.4.41 [INFO] [stderr] Checking secrecy v0.8.0 [INFO] [stderr] Checking tungstenite v0.21.0 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Checking tokio-tungstenite v0.21.0 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking ape_bot_v2 v0.10.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `folded` and `played_round` are never read [INFO] [stdout] --> src/games/texas_holdem.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 6 | struct Player { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 10 | folded: bool, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 11 | played_round: bool, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `determine_winner` is never used [INFO] [stdout] --> src/games/texas_holdem.rs:81:8 [INFO] [stdout] | [INFO] [stdout] 23 | impl TexasHoldem { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 81 | fn determine_winner(&self) -> Vec<&Player> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/userfile.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | id: id.clone(), [INFO] [stdout] | ^^^^^^^^^^ help: try dereferencing it: `*id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/userfile.rs:73:70 [INFO] [stdout] | [INFO] [stdout] 73 | ...m_str(data.as_str()).expect(format!("failed to deserialize user data with ID {}", id).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("failed to deserialize user data with ID {}", id))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/userfile.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 76 | id: id.clone(), [INFO] [stdout] | ^^^^^^^^^^ help: try dereferencing it: `*id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/userfile.rs:93:14 [INFO] [stdout] | [INFO] [stdout] 93 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/userfile.rs:308:9 [INFO] [stdout] | [INFO] [stdout] 308 | / if let Some(item) = self.file.inventory.get_equipped() { [INFO] [stdout] 309 | | Some(item.clone()) [INFO] [stdout] 310 | | } else { [INFO] [stdout] 311 | | None [INFO] [stdout] 312 | | } [INFO] [stdout] | |_________^ help: try: `self.file.inventory.get_equipped().map(|item| item.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GuildId` which implements the `Copy` trait [INFO] [stdout] --> src/guildfile.rs:23:17 [INFO] [stdout] | [INFO] [stdout] 23 | id: guild_id.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*guild_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/guildfile.rs:44:72 [INFO] [stdout] | [INFO] [stdout] 44 | ...m_str(data.as_str()).expect(format!("failed to deserialize guild data with ID {}", id).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("failed to deserialize guild data with ID {}", id))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GuildId` which implements the `Copy` trait [INFO] [stdout] --> src/guildfile.rs:47:17 [INFO] [stdout] | [INFO] [stdout] 47 | id: id.clone(), [INFO] [stdout] | ^^^^^^^^^^ help: try dereferencing it: `*id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/guildfile.rs:64:14 [INFO] [stdout] | [INFO] [stdout] 64 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/commands/banana/info.rs:26:39 [INFO] [stdout] | [INFO] [stdout] 26 | ("Can Prestige:", format!("{}", if userfile.can_prestige() { "Yes!" } else { "No (lvl 100)" }), true) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(if userfile.can_prestige() { "Yes!" } else { "No (lvl 100)" }).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/commands/banana/info.rs:31:33 [INFO] [stdout] | [INFO] [stdout] 31 | ("Can Ascend:", format!("{}", if userfile.can_ascend() { "Yes!" } else { "No (prestige 10 + 1mil:banana:)" }), true), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(if userfile.can_ascend() { "Yes!" } else { "No (prestige 10 + 1mil:banana:)" }).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/commands/banana/levelup.rs:52:39 [INFO] [stdout] | [INFO] [stdout] 52 | ("Can Prestige:", format!("{}", if userfile.can_prestige() { "Yes!" } else { "No (lvl 100)" }), true) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(if userfile.can_prestige() { "Yes!" } else { "No (lvl 100)" }).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/commands/banana/levelup.rs:56:33 [INFO] [stdout] | [INFO] [stdout] 56 | ("Can Ascend:", format!("{}", if userfile.can_ascend() { "Yes!" } else { "No (prestige 10 + 1mil:banana:)" }), true), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(if userfile.can_ascend() { "Yes!" } else { "No (prestige 10 + 1mil:banana:)" }).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/commands/banana/leaderboard.rs:57:20 [INFO] [stdout] | [INFO] [stdout] 57 | if top_users.len() >= 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!top_users.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/commands/banana/leaderboard.rs:82:17 [INFO] [stdout] | [INFO] [stdout] 82 | let n1 = if top_users.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!top_users.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `serenity::all::UserId` [INFO] [stdout] --> src/commands/banana/leaderboard.rs:83:10 [INFO] [stdout] | [INFO] [stdout] 83 | (UserId::from(top_users[0].id).to_user(&ctx.http).await.unwrap().global_name.unwrap_or("UNKNOWN".to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `UserId::from()`: `top_users[0].id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `serenity::all::UserId` [INFO] [stdout] --> src/commands/banana/leaderboard.rs:90:10 [INFO] [stdout] | [INFO] [stdout] 90 | (UserId::from(top_users[1].id).to_user(&ctx.http).await.unwrap().global_name.unwrap_or("UNKNOWN".to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `UserId::from()`: `top_users[1].id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `serenity::all::UserId` [INFO] [stdout] --> src/commands/banana/leaderboard.rs:97:10 [INFO] [stdout] | [INFO] [stdout] 97 | (UserId::from(top_users[2].id).to_user(&ctx.http).await.unwrap().global_name.unwrap_or("UNKNOWN".to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `UserId::from()`: `top_users[2].id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/commands/banana/leaderboard.rs:110:91 [INFO] [stdout] | [INFO] [stdout] 110 | ... if n1.1 != 0 { format!("Ascention: `{}`", n1.1.to_string()) } else { "".to_string() }, [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/commands/banana/leaderboard.rs:113:77 [INFO] [stdout] | [INFO] [stdout] 113 | ... if n2.1 != 0 { format!("Ascention: `{}`", n2.1.to_string()) } else { "".to_string() }, [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/commands/banana/leaderboard.rs:116:77 [INFO] [stdout] | [INFO] [stdout] 116 | ... if n3.1 != 0 { format!("Ascention: `{}`", n3.1.to_string()) } else { "".to_string() }, [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/commands/blackjack_cmd.rs:118:52 [INFO] [stdout] | [INFO] [stdout] 118 | GAMES.lock().await.insert(GameHandler::new(user.clone(), Games::BlackJack(game))); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/commands/blackjack_cmd.rs:131:27 [INFO] [stdout] | [INFO] [stdout] 131 | .field("Options", format!("{}", game.give_options()), false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `game.give_options().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/commands/blackjack_cmd.rs:144:48 [INFO] [stdout] | [INFO] [stdout] 144 | GAMES.lock().await.insert(GameHandler::new(user.clone(), Games::BlackJack(game))); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/commands/mine.rs:44:37 [INFO] [stdout] | [INFO] [stdout] 44 | let game = GameHandler::new(sender.clone(), Games::MineBattle(battle)); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/mine.rs:183:37 [INFO] [stdout] | [INFO] [stdout] 183 | if MINING.lock().await.contains(&sender) { [INFO] [stdout] | ^^^^^^^ help: change this to: `sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/mine.rs:202:41 [INFO] [stdout] | [INFO] [stdout] 202 | let mut user_file = UserValues::get(&sender); [INFO] [stdout] | ^^^^^^^ help: change this to: `sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/commands/mine.rs:227:30 [INFO] [stdout] | [INFO] [stdout] 227 | MINING.lock().await.push(sender.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/commands/mine.rs:240:18 [INFO] [stdout] | [INFO] [stdout] 240 | let sender = sender.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/commands/inventory_cmd.rs:19:95 [INFO] [stdout] | [INFO] [stdout] 19 | ... if let Some(item) = equipped { format!("Equipped: {}\n", item.to_string()) } else { "".to_string() })) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:11:31 [INFO] [stdout] | [INFO] [stdout] 11 | command_response(ctx, &cmd, "Me confused, Enter the number of the item you wish to buy").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:20:31 [INFO] [stdout] | [INFO] [stdout] 20 | command_response(ctx, &cmd, "Your inventory is full! (use `/discard #` to throw out an item!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:27:39 [INFO] [stdout] | [INFO] [stdout] 27 | command_response(ctx, &cmd, "You already own this item!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:31:39 [INFO] [stdout] | [INFO] [stdout] 31 | command_response(ctx, &cmd, "You don't have enough super nanners!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:48:39 [INFO] [stdout] | [INFO] [stdout] 48 | command_response(ctx, &cmd, "You don't have enough super nanners!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:65:39 [INFO] [stdout] | [INFO] [stdout] 65 | command_response(ctx, &cmd, "You don't have enough super nanners!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:86:39 [INFO] [stdout] | [INFO] [stdout] 86 | command_response(ctx, &cmd, "You don't have enough super nanners!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:107:39 [INFO] [stdout] | [INFO] [stdout] 107 | command_response(ctx, &cmd, "You don't have enough super nanners!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:124:39 [INFO] [stdout] | [INFO] [stdout] 124 | command_response(ctx, &cmd, "You don't have enough super nanners!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:141:39 [INFO] [stdout] | [INFO] [stdout] 141 | command_response(ctx, &cmd, "You don't have enough super nanners!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:158:39 [INFO] [stdout] | [INFO] [stdout] 158 | command_response(ctx, &cmd, "You don't have enough super nanners!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:175:39 [INFO] [stdout] | [INFO] [stdout] 175 | command_response(ctx, &cmd, "You don't have enough super nanners!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:195:35 [INFO] [stdout] | [INFO] [stdout] 195 | command_response(ctx, &cmd, "Invalid item number!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/discard.rs:9:31 [INFO] [stdout] | [INFO] [stdout] 9 | command_response(ctx, &cmd, "Me confused, Enter a number for the mine level you want to mine at.").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/discard.rs:14:31 [INFO] [stdout] | [INFO] [stdout] 14 | command_response(ctx, &cmd, "Invalid item number! (must be positive)").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/discard.rs:24:31 [INFO] [stdout] | [INFO] [stdout] 24 | command_response(ctx, &cmd, "Invalid item number!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/discard.rs:32:27 [INFO] [stdout] | [INFO] [stdout] 32 | command_response(ctx, &cmd, format!("{} discarded!", item_clone)).await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/collect_minions.rs:12:26 [INFO] [stdout] | [INFO] [stdout] 12 | command_response(&ctx, &cmd, "You don't have any minions to collect sludge from.").await; [INFO] [stdout] | ^^^^ help: change this to: `ctx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/collect_minions.rs:12:32 [INFO] [stdout] | [INFO] [stdout] 12 | command_response(&ctx, &cmd, "You don't have any minions to collect sludge from.").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/collect_minions.rs:21:22 [INFO] [stdout] | [INFO] [stdout] 21 | command_response(&ctx, &cmd, format!("You collected {} sludge from your minions totalling {}:banana:", total_sludge, bananas)).a... [INFO] [stdout] | ^^^^ help: change this to: `ctx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/collect_minions.rs:21:28 [INFO] [stdout] | [INFO] [stdout] 21 | command_response(&ctx, &cmd, format!("You collected {} sludge from your minions totalling {}:banana:", total_sludge, bananas)).a... [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/commands/pvp_command.rs:73:30 [INFO] [stdout] | [INFO] [stdout] 73 | let game = PvPArena::new(user.clone(), stake, flags); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/commands/pvp_command.rs:76:59 [INFO] [stdout] | [INFO] [stdout] 76 | let code = GAMES.lock().await.insert(GameHandler::new(user.clone(), Games::PvP(game))); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/equip.rs:8:31 [INFO] [stdout] | [INFO] [stdout] 8 | command_response(ctx, &cmd, "Me confused, Enter the number of the item you wish to equip from your inventory.").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/equip.rs:20:31 [INFO] [stdout] | [INFO] [stdout] 20 | command_response(ctx, &cmd, "Invalid item slot!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/equip.rs:38:31 [INFO] [stdout] | [INFO] [stdout] 38 | command_response(ctx, &cmd, "You can't equip that!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/unequip.rs:11:31 [INFO] [stdout] | [INFO] [stdout] 11 | command_response(ctx, &cmd, "You don't have anything equipped!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/unequip.rs:19:27 [INFO] [stdout] | [INFO] [stdout] 19 | command_response(ctx, &cmd, "Item unequipped!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/join.rs:10:31 [INFO] [stdout] | [INFO] [stdout] 10 | command_response(ctx, &command, "Me confused, Enter the number of the item you wish to equip from your inventory.").await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `command` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i64` which implements the `Copy` trait [INFO] [stdout] --> src/commands/join.rs:14:16 [INFO] [stdout] | [INFO] [stdout] 14 | let code = code.clone() as usize; [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/join.rs:19:31 [INFO] [stdout] | [INFO] [stdout] 19 | command_response(ctx, &command, "Invalid game code!").await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `command` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/join.rs:30:35 [INFO] [stdout] | [INFO] [stdout] 30 | command_response(ctx, &command, "You don't have enough bananas to join this game!").await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `command` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/join.rs:38:31 [INFO] [stdout] | [INFO] [stdout] 38 | command_response(ctx, &command, "You are already in a game!").await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `command` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/commands/join.rs:45:76 [INFO] [stdout] | [INFO] [stdout] 45 | let join_attempt = GAMES.lock().await.add_player(code as GameCode, user.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/join.rs:51:40 [INFO] [stdout] | [INFO] [stdout] 51 | command_response_loud(ctx, &command, "You have joined the game!").await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `command` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/join.rs:57:27 [INFO] [stdout] | [INFO] [stdout] 57 | command_response(ctx, &command, "You can't join that game!").await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `command` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/blackjack.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | / match card.card_type { [INFO] [stdout] 11 | | CardType::Ten | CardType::Jack | CardType::Queen | CardType::King => true, [INFO] [stdout] 12 | | _ => false [INFO] [stdout] 13 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 10 - match card.card_type { [INFO] [stdout] 11 - CardType::Ten | CardType::Jack | CardType::Queen | CardType::King => true, [INFO] [stdout] 12 - _ => false [INFO] [stdout] 13 - } [INFO] [stdout] 10 + matches!(card.card_type, CardType::Ten | CardType::Jack | CardType::Queen | CardType::King) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BlackjackHand` [INFO] [stdout] --> src/games/blackjack.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | / pub fn new() -> BlackjackHand { [INFO] [stdout] 39 | | BlackjackHand { [INFO] [stdout] 40 | | cards: Vec::new(), [INFO] [stdout] 41 | | } [INFO] [stdout] 42 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 37 + impl Default for BlackjackHand { [INFO] [stdout] 38 + fn default() -> Self { [INFO] [stdout] 39 + Self::new() [INFO] [stdout] 40 + } [INFO] [stdout] 41 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/games/blackjack.rs:187:43 [INFO] [stdout] | [INFO] [stdout] 187 | let player = BlackjackPlayer::new(bet.clone()); [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `bet` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/games/blackjack.rs:336:26 [INFO] [stdout] | [INFO] [stdout] 336 | .description(format!("{}", message)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `message.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/games/blackjack.rs:342:31 [INFO] [stdout] | [INFO] [stdout] 342 | .field("Options", format!("{}", self.give_options()), false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `self.give_options().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/games/blackjack.rs:494:9 [INFO] [stdout] | [INFO] [stdout] 494 | / return match first_word { [INFO] [stdout] 495 | | "hit" if !self.player.playing_hand().is_blackjack() => { [INFO] [stdout] 496 | | self.hit(); [INFO] [stdout] 497 | | if self.player.playing_hand().is_bust() { [INFO] [stdout] ... | [INFO] [stdout] 552 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 494 ~ match first_word { [INFO] [stdout] 495 + "hit" if !self.player.playing_hand().is_blackjack() => { [INFO] [stdout] 496 + self.hit(); [INFO] [stdout] 497 + if self.player.playing_hand().is_bust() { [INFO] [stdout] 498 + return self.determine_winner(&mut userfile, msg); [INFO] [stdout] 499 + } [INFO] [stdout] 500 + (self.craft_embed(&msg.author.global_name.clone().unwrap(), "You hit! Me looking forward to stealing those nanners!".to_string()), false) [INFO] [stdout] 501 + }, [INFO] [stdout] 502 + "stand" => { [INFO] [stdout] 503 + self.stand(); [INFO] [stdout] 504 + // determine winner [INFO] [stdout] 505 + self.determine_winner(&mut userfile, msg) [INFO] [stdout] 506 + }, [INFO] [stdout] 507 + "split" if self.player.can_split() => { [INFO] [stdout] 508 + // if can't afford [INFO] [stdout] 509 + if userfile.get_bananas() < self.player.bet { [INFO] [stdout] 510 + // reply with error [INFO] [stdout] 511 + return (self.craft_embed(&msg.author.global_name.clone().unwrap(), "You do not have enough bananas to split!".to_string()), false); [INFO] [stdout] 512 + } [INFO] [stdout] 513 + [INFO] [stdout] 514 + self.player.split(); [INFO] [stdout] 515 + userfile.remove_bananas(self.player.bet); [INFO] [stdout] 516 + self.hit(); [INFO] [stdout] 517 + [INFO] [stdout] 518 + (self.craft_embed(&msg.author.global_name.clone().unwrap(), "You split! Me for sure gonna win now!".to_string()), false) [INFO] [stdout] 519 + } [INFO] [stdout] 520 + "double" if self.turn == 0 && !self.player.playing_hand().is_blackjack() => { [INFO] [stdout] 521 + let mut amt = self.player.bet; [INFO] [stdout] 522 + if let Some(next) = words.next() { [INFO] [stdout] 523 + let Ok(a) = next.parse::() else { [INFO] [stdout] 524 + // reply with error [INFO] [stdout] 525 + return (self.craft_embed(&msg.author.global_name.clone().unwrap(), "You must provide a valid amount to double down with!".to_string()), false); [INFO] [stdout] 526 + }; [INFO] [stdout] 527 + // ensure amount is above 5 and below the player's current bet [INFO] [stdout] 528 + if amt < 5 || amt >= self.player.bet { [INFO] [stdout] 529 + // reply with error [INFO] [stdout] 530 + return (self.craft_embed(&msg.author.global_name.clone().unwrap(), [INFO] [stdout] 531 + format!("You must provide a valid amount to double down with! (5 to {})", self.player.bet)), false); [INFO] [stdout] 532 + } [INFO] [stdout] 533 + [INFO] [stdout] 534 + amt = a; [INFO] [stdout] 535 + } [INFO] [stdout] 536 + [INFO] [stdout] 537 + // ensure player has enough money [INFO] [stdout] 538 + if userfile.get_bananas() < amt { [INFO] [stdout] 539 + // reply with error [INFO] [stdout] 540 + return (self.craft_embed(&msg.author.global_name.clone().unwrap(), "You do not have enough bananas to double down with!".to_string()), false); [INFO] [stdout] 541 + } [INFO] [stdout] 542 + [INFO] [stdout] 543 + userfile.remove_bananas(amt); [INFO] [stdout] 544 + [INFO] [stdout] 545 + self.double_down(amt); [INFO] [stdout] 546 + self.determine_winner(&mut userfile, msg) [INFO] [stdout] 547 + }, [INFO] [stdout] 548 + _ => { [INFO] [stdout] 549 + // reply with error [INFO] [stdout] 550 + (self.craft_embed(&msg.author.global_name.clone().unwrap(), "Me no understand what you say. Me only know the following options:".to_string()), false) [INFO] [stdout] 551 + } [INFO] [stdout] 552 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `SludgeMonsterBattle` [INFO] [stdout] --> src/games/sludge_monster_battle.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> Self { [INFO] [stdout] 15 | | // create a new sludge monster battle [INFO] [stdout] 16 | | let boss_health = thread_rng().gen_range(1..=5) * 100; [INFO] [stdout] 17 | | Self { [INFO] [stdout] ... | [INFO] [stdout] 29 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 12 + impl Default for SludgeMonsterBattle { [INFO] [stdout] 13 + fn default() -> Self { [INFO] [stdout] 14 + Self::new() [INFO] [stdout] 15 + } [INFO] [stdout] 16 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/games/pvp.rs:59:19 [INFO] [stdout] | [INFO] [stdout] 59 | host: host.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `host` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/games/pvp.rs:77:21 [INFO] [stdout] | [INFO] [stdout] 77 | health: self.base_health as u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.base_health` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/games/pvp.rs:259:24 [INFO] [stdout] | [INFO] [stdout] 259 | if msg.mentions.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `msg.mentions.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/games/pvp.rs:510:32 [INFO] [stdout] | [INFO] [stdout] 510 | ... if msg.mentions.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `msg.mentions.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/games/pvp.rs:637:54 [INFO] [stdout] | [INFO] [stdout] 637 | return Some(self.handle_win(ctx, self.players[index].user.clone()).await); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.players[index].user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | / match self { [INFO] [stdout] 38 | | CardType::Jack | CardType::Queen | CardType::King => true, [INFO] [stdout] 39 | | _ => false, [INFO] [stdout] 40 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 37 - match self { [INFO] [stdout] 38 - CardType::Jack | CardType::Queen | CardType::King => true, [INFO] [stdout] 39 - _ => false, [INFO] [stdout] 40 - } [INFO] [stdout] 37 + matches!(self, CardType::Jack | CardType::Queen | CardType::King) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:47:30 [INFO] [stdout] | [INFO] [stdout] 47 | CardType::Ace => match other { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 48 | | CardType::Ace => true, [INFO] [stdout] 49 | | _ => false, [INFO] [stdout] 50 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 47 - CardType::Ace => match other { [INFO] [stdout] 48 - CardType::Ace => true, [INFO] [stdout] 49 - _ => false, [INFO] [stdout] 50 - }, [INFO] [stdout] 47 + CardType::Ace => matches!(other, CardType::Ace), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:51:30 [INFO] [stdout] | [INFO] [stdout] 51 | CardType::Two => match other { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 52 | | CardType::Two => true, [INFO] [stdout] 53 | | _ => false, [INFO] [stdout] 54 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 51 - CardType::Two => match other { [INFO] [stdout] 52 - CardType::Two => true, [INFO] [stdout] 53 - _ => false, [INFO] [stdout] 54 - }, [INFO] [stdout] 51 + CardType::Two => matches!(other, CardType::Two), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:55:32 [INFO] [stdout] | [INFO] [stdout] 55 | CardType::Three => match other { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 56 | | CardType::Three => true, [INFO] [stdout] 57 | | _ => false, [INFO] [stdout] 58 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 55 - CardType::Three => match other { [INFO] [stdout] 56 - CardType::Three => true, [INFO] [stdout] 57 - _ => false, [INFO] [stdout] 58 - }, [INFO] [stdout] 55 + CardType::Three => matches!(other, CardType::Three), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:59:31 [INFO] [stdout] | [INFO] [stdout] 59 | CardType::Four => match other { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 60 | | CardType::Four => true, [INFO] [stdout] 61 | | _ => false, [INFO] [stdout] 62 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 59 - CardType::Four => match other { [INFO] [stdout] 60 - CardType::Four => true, [INFO] [stdout] 61 - _ => false, [INFO] [stdout] 62 - }, [INFO] [stdout] 59 + CardType::Four => matches!(other, CardType::Four), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:63:31 [INFO] [stdout] | [INFO] [stdout] 63 | CardType::Five => match other { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 64 | | CardType::Five => true, [INFO] [stdout] 65 | | _ => false, [INFO] [stdout] 66 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 63 - CardType::Five => match other { [INFO] [stdout] 64 - CardType::Five => true, [INFO] [stdout] 65 - _ => false, [INFO] [stdout] 66 - }, [INFO] [stdout] 63 + CardType::Five => matches!(other, CardType::Five), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:67:30 [INFO] [stdout] | [INFO] [stdout] 67 | CardType::Six => match other { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 68 | | CardType::Six => true, [INFO] [stdout] 69 | | _ => false, [INFO] [stdout] 70 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 67 - CardType::Six => match other { [INFO] [stdout] 68 - CardType::Six => true, [INFO] [stdout] 69 - _ => false, [INFO] [stdout] 70 - }, [INFO] [stdout] 67 + CardType::Six => matches!(other, CardType::Six), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:71:32 [INFO] [stdout] | [INFO] [stdout] 71 | CardType::Seven => match other { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 72 | | CardType::Seven => true, [INFO] [stdout] 73 | | _ => false, [INFO] [stdout] 74 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 71 - CardType::Seven => match other { [INFO] [stdout] 72 - CardType::Seven => true, [INFO] [stdout] 73 - _ => false, [INFO] [stdout] 74 - }, [INFO] [stdout] 71 + CardType::Seven => matches!(other, CardType::Seven), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:75:32 [INFO] [stdout] | [INFO] [stdout] 75 | CardType::Eight => match other { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 76 | | CardType::Eight => true, [INFO] [stdout] 77 | | _ => false, [INFO] [stdout] 78 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 75 - CardType::Eight => match other { [INFO] [stdout] 76 - CardType::Eight => true, [INFO] [stdout] 77 - _ => false, [INFO] [stdout] 78 - }, [INFO] [stdout] 75 + CardType::Eight => matches!(other, CardType::Eight), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:79:31 [INFO] [stdout] | [INFO] [stdout] 79 | CardType::Nine => match other { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 80 | | CardType::Nine => true, [INFO] [stdout] 81 | | _ => false, [INFO] [stdout] 82 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 79 - CardType::Nine => match other { [INFO] [stdout] 80 - CardType::Nine => true, [INFO] [stdout] 81 - _ => false, [INFO] [stdout] 82 - }, [INFO] [stdout] 79 + CardType::Nine => matches!(other, CardType::Nine), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:83:30 [INFO] [stdout] | [INFO] [stdout] 83 | CardType::Ten => match other { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 84 | | CardType::Ten => true, [INFO] [stdout] 85 | | _ => false, [INFO] [stdout] 86 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 83 - CardType::Ten => match other { [INFO] [stdout] 84 - CardType::Ten => true, [INFO] [stdout] 85 - _ => false, [INFO] [stdout] 86 - }, [INFO] [stdout] 83 + CardType::Ten => matches!(other, CardType::Ten), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:87:31 [INFO] [stdout] | [INFO] [stdout] 87 | CardType::Jack => match other { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 88 | | CardType::Jack => true, [INFO] [stdout] 89 | | _ => false, [INFO] [stdout] 90 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 87 - CardType::Jack => match other { [INFO] [stdout] 88 - CardType::Jack => true, [INFO] [stdout] 89 - _ => false, [INFO] [stdout] 90 - }, [INFO] [stdout] 87 + CardType::Jack => matches!(other, CardType::Jack), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:91:32 [INFO] [stdout] | [INFO] [stdout] 91 | CardType::Queen => match other { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 92 | | CardType::Queen => true, [INFO] [stdout] 93 | | _ => false, [INFO] [stdout] 94 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 91 - CardType::Queen => match other { [INFO] [stdout] 92 - CardType::Queen => true, [INFO] [stdout] 93 - _ => false, [INFO] [stdout] 94 - }, [INFO] [stdout] 91 + CardType::Queen => matches!(other, CardType::Queen), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:95:31 [INFO] [stdout] | [INFO] [stdout] 95 | CardType::King => match other { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 96 | | CardType::King => true, [INFO] [stdout] 97 | | _ => false, [INFO] [stdout] 98 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 95 - CardType::King => match other { [INFO] [stdout] 96 - CardType::King => true, [INFO] [stdout] 97 - _ => false, [INFO] [stdout] 98 - }, [INFO] [stdout] 95 + CardType::King => matches!(other, CardType::King), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:99:32 [INFO] [stdout] | [INFO] [stdout] 99 | CardType::Joker => match other { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 100 | | CardType::Joker => true, [INFO] [stdout] 101 | | _ => false, [INFO] [stdout] 102 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 99 - CardType::Joker => match other { [INFO] [stdout] 100 - CardType::Joker => true, [INFO] [stdout] 101 - _ => false, [INFO] [stdout] 102 - }, [INFO] [stdout] 99 + CardType::Joker => matches!(other, CardType::Joker), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | / match self { [INFO] [stdout] 118 | | Suit::Hearts | Suit::Diamonds => true, [INFO] [stdout] 119 | | _ => false, [INFO] [stdout] 120 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 117 - match self { [INFO] [stdout] 118 - Suit::Hearts | Suit::Diamonds => true, [INFO] [stdout] 119 - _ => false, [INFO] [stdout] 120 - } [INFO] [stdout] 117 + matches!(self, Suit::Hearts | Suit::Diamonds) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | / match self { [INFO] [stdout] 125 | | Suit::Clubs | Suit::Spades => true, [INFO] [stdout] 126 | | _ => false, [INFO] [stdout] 127 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 124 - match self { [INFO] [stdout] 125 - Suit::Clubs | Suit::Spades => true, [INFO] [stdout] 126 - _ => false, [INFO] [stdout] 127 - } [INFO] [stdout] 124 + matches!(self, Suit::Clubs | Suit::Spades) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:134:29 [INFO] [stdout] | [INFO] [stdout] 134 | Suit::Hearts => match other { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 135 | | Suit::Hearts => true, [INFO] [stdout] 136 | | _ => false, [INFO] [stdout] 137 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 134 - Suit::Hearts => match other { [INFO] [stdout] 135 - Suit::Hearts => true, [INFO] [stdout] 136 - _ => false, [INFO] [stdout] 137 - }, [INFO] [stdout] 134 + Suit::Hearts => matches!(other, Suit::Hearts), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:138:31 [INFO] [stdout] | [INFO] [stdout] 138 | Suit::Diamonds => match other { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 139 | | Suit::Diamonds => true, [INFO] [stdout] 140 | | _ => false, [INFO] [stdout] 141 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 138 - Suit::Diamonds => match other { [INFO] [stdout] 139 - Suit::Diamonds => true, [INFO] [stdout] 140 - _ => false, [INFO] [stdout] 141 - }, [INFO] [stdout] 138 + Suit::Diamonds => matches!(other, Suit::Diamonds), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:142:28 [INFO] [stdout] | [INFO] [stdout] 142 | Suit::Clubs => match other { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 143 | | Suit::Clubs => true, [INFO] [stdout] 144 | | _ => false, [INFO] [stdout] 145 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 142 - Suit::Clubs => match other { [INFO] [stdout] 143 - Suit::Clubs => true, [INFO] [stdout] 144 - _ => false, [INFO] [stdout] 145 - }, [INFO] [stdout] 142 + Suit::Clubs => matches!(other, Suit::Clubs), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:146:29 [INFO] [stdout] | [INFO] [stdout] 146 | Suit::Spades => match other { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 147 | | Suit::Spades => true, [INFO] [stdout] 148 | | _ => false, [INFO] [stdout] 149 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 146 - Suit::Spades => match other { [INFO] [stdout] 147 - Suit::Spades => true, [INFO] [stdout] 148 - _ => false, [INFO] [stdout] 149 - }, [INFO] [stdout] 146 + Suit::Spades => matches!(other, Suit::Spades), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/games/mod.rs:451:31 [INFO] [stdout] | [INFO] [stdout] 451 | self.players.contains(&player) [INFO] [stdout] | ^^^^^^^ help: change this to: `player` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `GamesManager` [INFO] [stdout] --> src/games/mod.rs:466:5 [INFO] [stdout] | [INFO] [stdout] 466 | / pub fn new() -> GamesManager { [INFO] [stdout] 467 | | GamesManager { games: HashMap::new() } [INFO] [stdout] 468 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 465 + impl Default for GamesManager { [INFO] [stdout] 466 + fn default() -> Self { [INFO] [stdout] 467 + Self::new() [INFO] [stdout] 468 + } [INFO] [stdout] 469 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/games/mod.rs:472:27 [INFO] [stdout] | [INFO] [stdout] 472 | self.games.insert(code.clone(), game); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/games/mod.rs:506:33 [INFO] [stdout] | [INFO] [stdout] 506 | self.games.contains_key(&code) [INFO] [stdout] | ^^^^^ help: change this to: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/games/mod.rs:512:29 [INFO] [stdout] | [INFO] [stdout] 512 | return Some(code.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/games/mod.rs:517:29 [INFO] [stdout] | [INFO] [stdout] 517 | return Some(code.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/games/mod.rs:532:9 [INFO] [stdout] | [INFO] [stdout] 532 | / for game in self.games.values_mut() { [INFO] [stdout] 533 | | if game.has_player(player) { [INFO] [stdout] 534 | | return Some(game); [INFO] [stdout] ... | [INFO] [stdout] 537 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `self.games.values_mut().find(|game| game.has_player(player)).map(|v| v as _)` [INFO] [stdout] | [INFO] [stdout] = note: you may need to dereference some variables [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] = note: `#[warn(clippy::manual_find)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/games/mod.rs:540:9 [INFO] [stdout] | [INFO] [stdout] 540 | / for game in self.games.values_mut() { [INFO] [stdout] 541 | | if game.host == *player { [INFO] [stdout] 542 | | return Some(game); [INFO] [stdout] ... | [INFO] [stdout] 545 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `self.games.values_mut().find(|game| game.host == *player).map(|v| v as _)` [INFO] [stdout] | [INFO] [stdout] = note: you may need to dereference some variables [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/games/mod.rs:559:25 [INFO] [stdout] | [INFO] [stdout] 559 | game.add_player(user.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `folded` and `played_round` are never read [INFO] [stdout] --> src/games/texas_holdem.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 6 | struct Player { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] ... [INFO] [stdout] 10 | folded: bool, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 11 | played_round: bool, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `determine_winner` is never used [INFO] [stdout] --> src/games/texas_holdem.rs:81:8 [INFO] [stdout] | [INFO] [stdout] 23 | impl TexasHoldem { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 81 | fn determine_winner(&self) -> Vec<&Player> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/inventory.rs:34:18 [INFO] [stdout] | [INFO] [stdout] 34 | Some(&item) [INFO] [stdout] | ^^^^^ help: change this to: `item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/mine_data.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 19 | if self.items.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.items.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return false; [INFO] [stdout] 82 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/userfile.rs:38:17 [INFO] [stdout] | [INFO] [stdout] 38 | id: id.clone(), [INFO] [stdout] | ^^^^^^^^^^ help: try dereferencing it: `*id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/userfile.rs:73:70 [INFO] [stdout] | [INFO] [stdout] 73 | ...m_str(data.as_str()).expect(format!("failed to deserialize user data with ID {}", id).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("failed to deserialize user data with ID {}", id))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/userfile.rs:76:17 [INFO] [stdout] | [INFO] [stdout] 76 | id: id.clone(), [INFO] [stdout] | ^^^^^^^^^^ help: try dereferencing it: `*id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/userfile.rs:93:14 [INFO] [stdout] | [INFO] [stdout] 93 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] = note: `#[warn(clippy::suspicious_open_options)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Option::map` [INFO] [stdout] --> src/userfile.rs:308:9 [INFO] [stdout] | [INFO] [stdout] 308 | / if let Some(item) = self.file.inventory.get_equipped() { [INFO] [stdout] 309 | | Some(item.clone()) [INFO] [stdout] 310 | | } else { [INFO] [stdout] 311 | | None [INFO] [stdout] 312 | | } [INFO] [stdout] | |_________^ help: try: `self.file.inventory.get_equipped().map(|item| item.clone())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map [INFO] [stdout] = note: `#[warn(clippy::manual_map)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `msg.mentions.get(0)` [INFO] [stdout] --> src/main.rs:197:33 [INFO] [stdout] | [INFO] [stdout] 197 | let recipient = msg.mentions.get(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `msg.mentions.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GuildId` which implements the `Copy` trait [INFO] [stdout] --> src/guildfile.rs:23:17 [INFO] [stdout] | [INFO] [stdout] 23 | id: guild_id.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*guild_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/guildfile.rs:44:72 [INFO] [stdout] | [INFO] [stdout] 44 | ...m_str(data.as_str()).expect(format!("failed to deserialize guild data with ID {}", id).as_str()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("failed to deserialize guild data with ID {}", id))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `GuildId` which implements the `Copy` trait [INFO] [stdout] --> src/guildfile.rs:47:17 [INFO] [stdout] | [INFO] [stdout] 47 | id: id.clone(), [INFO] [stdout] | ^^^^^^^^^^ help: try dereferencing it: `*id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined [INFO] [stdout] --> src/guildfile.rs:64:14 [INFO] [stdout] | [INFO] [stdout] 64 | .create(true) [INFO] [stdout] | ^^^^^^^^^^^^- help: add: `.truncate(true)` [INFO] [stdout] | [INFO] [stdout] = help: if you intend to overwrite an existing file entirely, call `.truncate(true)` [INFO] [stdout] = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)` [INFO] [stdout] = help: alternatively, use `.append(true)` to append to the file instead of overwriting it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:317:67 [INFO] [stdout] | [INFO] [stdout] 317 | builder = builder.add_file(CreateAttachment::path(format!("{}", thumbnail_path)).await.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `thumbnail_path.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:347:12 [INFO] [stdout] | [INFO] [stdout] 347 | if msg.embeds.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!msg.embeds.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/commands/banana/info.rs:26:39 [INFO] [stdout] | [INFO] [stdout] 26 | ("Can Prestige:", format!("{}", if userfile.can_prestige() { "Yes!" } else { "No (lvl 100)" }), true) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(if userfile.can_prestige() { "Yes!" } else { "No (lvl 100)" }).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/commands/banana/info.rs:31:33 [INFO] [stdout] | [INFO] [stdout] 31 | ("Can Ascend:", format!("{}", if userfile.can_ascend() { "Yes!" } else { "No (prestige 10 + 1mil:banana:)" }), true), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(if userfile.can_ascend() { "Yes!" } else { "No (prestige 10 + 1mil:banana:)" }).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/commands/banana/levelup.rs:52:39 [INFO] [stdout] | [INFO] [stdout] 52 | ("Can Prestige:", format!("{}", if userfile.can_prestige() { "Yes!" } else { "No (lvl 100)" }), true) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(if userfile.can_prestige() { "Yes!" } else { "No (lvl 100)" }).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/commands/banana/levelup.rs:56:33 [INFO] [stdout] | [INFO] [stdout] 56 | ("Can Ascend:", format!("{}", if userfile.can_ascend() { "Yes!" } else { "No (prestige 10 + 1mil:banana:)" }), true), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `(if userfile.can_ascend() { "Yes!" } else { "No (prestige 10 + 1mil:banana:)" }).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:476:9 [INFO] [stdout] | [INFO] [stdout] 476 | / match interaction { [INFO] [stdout] 477 | | Interaction::Command(command) => { [INFO] [stdout] 478 | | let command_name = command.data.name.as_str(); [INFO] [stdout] 479 | | let sender = &command.user; [INFO] [stdout] ... | [INFO] [stdout] 594 | | _ => {} [INFO] [stdout] 595 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 476 ~ if let Interaction::Command(command) = interaction { [INFO] [stdout] 477 + let command_name = command.data.name.as_str(); [INFO] [stdout] 478 + let sender = &command.user; [INFO] [stdout] 479 + let guild = command.guild_id; [INFO] [stdout] 480 + if guild.is_none() { [INFO] [stdout] 481 + command_response(&ctx, &command, "This command can only be used in a server").await; [INFO] [stdout] 482 + return; [INFO] [stdout] 483 + } [INFO] [stdout] 484 + let guild_id = guild.unwrap(); [INFO] [stdout] 485 + let command_options = &command.data.options(); [INFO] [stdout] 486 + let channel = command.channel_id; [INFO] [stdout] 487 + [INFO] [stdout] 488 + let mut guild_settings = guildfile::GuildSettings::get(&guild_id); [INFO] [stdout] 489 + [INFO] [stdout] 490 + // non-channel specific commands [INFO] [stdout] 491 + match command_name { [INFO] [stdout] 492 + "help" => { [INFO] [stdout] 493 + help::run(&ctx, &command).await; [INFO] [stdout] 494 + return; [INFO] [stdout] 495 + } [INFO] [stdout] 496 + "info" => { [INFO] [stdout] 497 + banana::info::run(&ctx, &command, &sender.id).await; [INFO] [stdout] 498 + return; [INFO] [stdout] 499 + } [INFO] [stdout] 500 + "levelup" => { [INFO] [stdout] 501 + banana::levelup::run(command_options, &ctx, &command, &sender.id).await; [INFO] [stdout] 502 + return; [INFO] [stdout] 503 + } [INFO] [stdout] 504 + "prestige" => { [INFO] [stdout] 505 + banana::prestige::run(&ctx, &command, &sender.id).await; [INFO] [stdout] 506 + return; [INFO] [stdout] 507 + } [INFO] [stdout] 508 + "leaderboard" => { [INFO] [stdout] 509 + banana::leaderboard::run(&ctx, &command).await; [INFO] [stdout] 510 + return; [INFO] [stdout] 511 + } [INFO] [stdout] 512 + "pay" => { [INFO] [stdout] 513 + banana::pay::run(command_options, &ctx, &command, &sender.id).await; [INFO] [stdout] 514 + return; [INFO] [stdout] 515 + } [INFO] [stdout] 516 + "ascend" => { [INFO] [stdout] 517 + banana::ascend::run(&ctx, &command, &sender.id).await; [INFO] [stdout] 518 + return; [INFO] [stdout] 519 + } [INFO] [stdout] 520 + "inventory" => { [INFO] [stdout] 521 + inventory_cmd::run(&ctx, &command).await; [INFO] [stdout] 522 + return; [INFO] [stdout] 523 + } [INFO] [stdout] 524 + "shop" => { [INFO] [stdout] 525 + shop::run(&ctx, &command).await; [INFO] [stdout] 526 + return; [INFO] [stdout] 527 + } [INFO] [stdout] 528 + "buy" => { [INFO] [stdout] 529 + buy::run(command_options, &ctx, &command).await; [INFO] [stdout] 530 + return; [INFO] [stdout] 531 + } [INFO] [stdout] 532 + "discard" => { [INFO] [stdout] 533 + discard::run(command_options, &ctx, &command).await; [INFO] [stdout] 534 + return; [INFO] [stdout] 535 + } [INFO] [stdout] 536 + "collect_minions" => { [INFO] [stdout] 537 + collect_minions::run(&ctx, &command).await; [INFO] [stdout] 538 + return; [INFO] [stdout] 539 + } [INFO] [stdout] 540 + "equip" => { [INFO] [stdout] 541 + equip::run(command_options, &ctx, &command).await; [INFO] [stdout] 542 + return; [INFO] [stdout] 543 + } [INFO] [stdout] 544 + "unequip" => { [INFO] [stdout] 545 + unequip::run(&ctx, &command).await; [INFO] [stdout] 546 + return; [INFO] [stdout] 547 + } [INFO] [stdout] 548 + "pvp" => { [INFO] [stdout] 549 + pvp_command::run(command_options, &ctx, &command, &sender.id).await; [INFO] [stdout] 550 + return; [INFO] [stdout] 551 + } [INFO] [stdout] 552 + "join" => { [INFO] [stdout] 553 + join::run(command_options, &ctx, &command, &sender.id).await; [INFO] [stdout] 554 + return; [INFO] [stdout] 555 + } [INFO] [stdout] 556 + "admin_channel" => { [INFO] [stdout] 557 + admin::run(command_options, &ctx, &command, &guild_id).await; [INFO] [stdout] 558 + return; [INFO] [stdout] 559 + } [INFO] [stdout] 560 + _ => {} [INFO] [stdout] 561 + } [INFO] [stdout] 562 + [INFO] [stdout] 563 + // spam commands that need checked [INFO] [stdout] 564 + if guild_settings.is_allowed_channel(channel.get()) { [INFO] [stdout] 565 + match command_name { [INFO] [stdout] 566 + "blackjack" => { [INFO] [stdout] 567 + blackjack_cmd::run(command_options, &ctx, &command, &sender.id).await; [INFO] [stdout] 568 + } [INFO] [stdout] 569 + "slots" => { [INFO] [stdout] 570 + slots::run(command_options, &ctx, &command, &sender.id).await; [INFO] [stdout] 571 + } [INFO] [stdout] 572 + "fiftyfifty" => { [INFO] [stdout] 573 + fiftyfifty::run(&ctx, &command, &sender.id).await; [INFO] [stdout] 574 + } [INFO] [stdout] 575 + "mine" => { [INFO] [stdout] 576 + mine::run(command_options, &ctx, &channel, command.clone(), &sender.id).await; [INFO] [stdout] 577 + } [INFO] [stdout] 578 + _ => { [INFO] [stdout] 579 + command_response(&ctx, &command, "That do be a monkey brain moment").await; [INFO] [stdout] 580 + } [INFO] [stdout] 581 + } [INFO] [stdout] 582 + } else { [INFO] [stdout] 583 + let allowed_channels = { [INFO] [stdout] 584 + let mut channels = Vec::new(); [INFO] [stdout] 585 + for cid in guild_settings.get_channels() { [INFO] [stdout] 586 + channels.push(cid.to_channel(&ctx).await.unwrap().to_string()); [INFO] [stdout] 587 + } [INFO] [stdout] 588 + channels [INFO] [stdout] 589 + }; [INFO] [stdout] 590 + command_response(&ctx, &command, format!("That command is only allowed in the following channel(s): {}", allowed_channels.join(", "))).await; [INFO] [stdout] 591 + } [INFO] [stdout] 592 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/commands/banana/leaderboard.rs:57:20 [INFO] [stdout] | [INFO] [stdout] 57 | if top_users.len() >= 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!top_users.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/commands/banana/leaderboard.rs:82:17 [INFO] [stdout] | [INFO] [stdout] 82 | let n1 = if top_users.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!top_users.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `serenity::all::UserId` [INFO] [stdout] --> src/commands/banana/leaderboard.rs:83:10 [INFO] [stdout] | [INFO] [stdout] 83 | (UserId::from(top_users[0].id).to_user(&ctx.http).await.unwrap().global_name.unwrap_or("UNKNOWN".to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `UserId::from()`: `top_users[0].id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `serenity::all::UserId` [INFO] [stdout] --> src/commands/banana/leaderboard.rs:90:10 [INFO] [stdout] | [INFO] [stdout] 90 | (UserId::from(top_users[1].id).to_user(&ctx.http).await.unwrap().global_name.unwrap_or("UNKNOWN".to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `UserId::from()`: `top_users[1].id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `serenity::all::UserId` [INFO] [stdout] --> src/commands/banana/leaderboard.rs:97:10 [INFO] [stdout] | [INFO] [stdout] 97 | (UserId::from(top_users[2].id).to_user(&ctx.http).await.unwrap().global_name.unwrap_or("UNKNOWN".to_string()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `UserId::from()`: `top_users[2].id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/commands/banana/leaderboard.rs:110:91 [INFO] [stdout] | [INFO] [stdout] 110 | ... if n1.1 != 0 { format!("Ascention: `{}`", n1.1.to_string()) } else { "".to_string() }, [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/commands/banana/leaderboard.rs:113:77 [INFO] [stdout] | [INFO] [stdout] 113 | ... if n2.1 != 0 { format!("Ascention: `{}`", n2.1.to_string()) } else { "".to_string() }, [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/commands/banana/leaderboard.rs:116:77 [INFO] [stdout] | [INFO] [stdout] 116 | ... if n3.1 != 0 { format!("Ascention: `{}`", n3.1.to_string()) } else { "".to_string() }, [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/commands/blackjack_cmd.rs:118:52 [INFO] [stdout] | [INFO] [stdout] 118 | GAMES.lock().await.insert(GameHandler::new(user.clone(), Games::BlackJack(game))); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/commands/blackjack_cmd.rs:131:27 [INFO] [stdout] | [INFO] [stdout] 131 | .field("Options", format!("{}", game.give_options()), false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `game.give_options().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/commands/blackjack_cmd.rs:144:48 [INFO] [stdout] | [INFO] [stdout] 144 | GAMES.lock().await.insert(GameHandler::new(user.clone(), Games::BlackJack(game))); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/commands/mine.rs:44:37 [INFO] [stdout] | [INFO] [stdout] 44 | let game = GameHandler::new(sender.clone(), Games::MineBattle(battle)); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/mine.rs:183:37 [INFO] [stdout] | [INFO] [stdout] 183 | if MINING.lock().await.contains(&sender) { [INFO] [stdout] | ^^^^^^^ help: change this to: `sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/mine.rs:202:41 [INFO] [stdout] | [INFO] [stdout] 202 | let mut user_file = UserValues::get(&sender); [INFO] [stdout] | ^^^^^^^ help: change this to: `sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/commands/mine.rs:227:30 [INFO] [stdout] | [INFO] [stdout] 227 | MINING.lock().await.push(sender.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/commands/mine.rs:240:18 [INFO] [stdout] | [INFO] [stdout] 240 | let sender = sender.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*sender` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/commands/inventory_cmd.rs:19:95 [INFO] [stdout] | [INFO] [stdout] 19 | ... if let Some(item) = equipped { format!("Equipped: {}\n", item.to_string()) } else { "".to_string() })) [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:11:31 [INFO] [stdout] | [INFO] [stdout] 11 | command_response(ctx, &cmd, "Me confused, Enter the number of the item you wish to buy").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:20:31 [INFO] [stdout] | [INFO] [stdout] 20 | command_response(ctx, &cmd, "Your inventory is full! (use `/discard #` to throw out an item!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:27:39 [INFO] [stdout] | [INFO] [stdout] 27 | command_response(ctx, &cmd, "You already own this item!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:31:39 [INFO] [stdout] | [INFO] [stdout] 31 | command_response(ctx, &cmd, "You don't have enough super nanners!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:48:39 [INFO] [stdout] | [INFO] [stdout] 48 | command_response(ctx, &cmd, "You don't have enough super nanners!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:65:39 [INFO] [stdout] | [INFO] [stdout] 65 | command_response(ctx, &cmd, "You don't have enough super nanners!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:86:39 [INFO] [stdout] | [INFO] [stdout] 86 | command_response(ctx, &cmd, "You don't have enough super nanners!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:107:39 [INFO] [stdout] | [INFO] [stdout] 107 | command_response(ctx, &cmd, "You don't have enough super nanners!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:124:39 [INFO] [stdout] | [INFO] [stdout] 124 | command_response(ctx, &cmd, "You don't have enough super nanners!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:141:39 [INFO] [stdout] | [INFO] [stdout] 141 | command_response(ctx, &cmd, "You don't have enough super nanners!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:158:39 [INFO] [stdout] | [INFO] [stdout] 158 | command_response(ctx, &cmd, "You don't have enough super nanners!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:175:39 [INFO] [stdout] | [INFO] [stdout] 175 | command_response(ctx, &cmd, "You don't have enough super nanners!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/buy.rs:195:35 [INFO] [stdout] | [INFO] [stdout] 195 | command_response(ctx, &cmd, "Invalid item number!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/discard.rs:9:31 [INFO] [stdout] | [INFO] [stdout] 9 | command_response(ctx, &cmd, "Me confused, Enter a number for the mine level you want to mine at.").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/discard.rs:14:31 [INFO] [stdout] | [INFO] [stdout] 14 | command_response(ctx, &cmd, "Invalid item number! (must be positive)").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/discard.rs:24:31 [INFO] [stdout] | [INFO] [stdout] 24 | command_response(ctx, &cmd, "Invalid item number!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/discard.rs:32:27 [INFO] [stdout] | [INFO] [stdout] 32 | command_response(ctx, &cmd, format!("{} discarded!", item_clone)).await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/collect_minions.rs:12:26 [INFO] [stdout] | [INFO] [stdout] 12 | command_response(&ctx, &cmd, "You don't have any minions to collect sludge from.").await; [INFO] [stdout] | ^^^^ help: change this to: `ctx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/collect_minions.rs:12:32 [INFO] [stdout] | [INFO] [stdout] 12 | command_response(&ctx, &cmd, "You don't have any minions to collect sludge from.").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/collect_minions.rs:21:22 [INFO] [stdout] | [INFO] [stdout] 21 | command_response(&ctx, &cmd, format!("You collected {} sludge from your minions totalling {}:banana:", total_sludge, bananas)).a... [INFO] [stdout] | ^^^^ help: change this to: `ctx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/collect_minions.rs:21:28 [INFO] [stdout] | [INFO] [stdout] 21 | command_response(&ctx, &cmd, format!("You collected {} sludge from your minions totalling {}:banana:", total_sludge, bananas)).a... [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/commands/pvp_command.rs:73:30 [INFO] [stdout] | [INFO] [stdout] 73 | let game = PvPArena::new(user.clone(), stake, flags); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/commands/pvp_command.rs:76:59 [INFO] [stdout] | [INFO] [stdout] 76 | let code = GAMES.lock().await.insert(GameHandler::new(user.clone(), Games::PvP(game))); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/equip.rs:8:31 [INFO] [stdout] | [INFO] [stdout] 8 | command_response(ctx, &cmd, "Me confused, Enter the number of the item you wish to equip from your inventory.").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/equip.rs:20:31 [INFO] [stdout] | [INFO] [stdout] 20 | command_response(ctx, &cmd, "Invalid item slot!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/equip.rs:38:31 [INFO] [stdout] | [INFO] [stdout] 38 | command_response(ctx, &cmd, "You can't equip that!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/unequip.rs:11:31 [INFO] [stdout] | [INFO] [stdout] 11 | command_response(ctx, &cmd, "You don't have anything equipped!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/unequip.rs:19:27 [INFO] [stdout] | [INFO] [stdout] 19 | command_response(ctx, &cmd, "Item unequipped!").await; [INFO] [stdout] | ^^^^ help: change this to: `cmd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/join.rs:10:31 [INFO] [stdout] | [INFO] [stdout] 10 | command_response(ctx, &command, "Me confused, Enter the number of the item you wish to equip from your inventory.").await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `command` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `i64` which implements the `Copy` trait [INFO] [stdout] --> src/commands/join.rs:14:16 [INFO] [stdout] | [INFO] [stdout] 14 | let code = code.clone() as usize; [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/join.rs:19:31 [INFO] [stdout] | [INFO] [stdout] 19 | command_response(ctx, &command, "Invalid game code!").await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `command` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/join.rs:30:35 [INFO] [stdout] | [INFO] [stdout] 30 | command_response(ctx, &command, "You don't have enough bananas to join this game!").await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `command` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/join.rs:38:31 [INFO] [stdout] | [INFO] [stdout] 38 | command_response(ctx, &command, "You are already in a game!").await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `command` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/commands/join.rs:45:76 [INFO] [stdout] | [INFO] [stdout] 45 | let join_attempt = GAMES.lock().await.add_player(code as GameCode, user.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/join.rs:51:40 [INFO] [stdout] | [INFO] [stdout] 51 | command_response_loud(ctx, &command, "You have joined the game!").await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `command` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/join.rs:57:27 [INFO] [stdout] | [INFO] [stdout] 57 | command_response(ctx, &command, "You can't join that game!").await; [INFO] [stdout] | ^^^^^^^^ help: change this to: `command` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/blackjack.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | / match card.card_type { [INFO] [stdout] 11 | | CardType::Ten | CardType::Jack | CardType::Queen | CardType::King => true, [INFO] [stdout] 12 | | _ => false [INFO] [stdout] 13 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 10 - match card.card_type { [INFO] [stdout] 11 - CardType::Ten | CardType::Jack | CardType::Queen | CardType::King => true, [INFO] [stdout] 12 - _ => false [INFO] [stdout] 13 - } [INFO] [stdout] 10 + matches!(card.card_type, CardType::Ten | CardType::Jack | CardType::Queen | CardType::King) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BlackjackHand` [INFO] [stdout] --> src/games/blackjack.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | / pub fn new() -> BlackjackHand { [INFO] [stdout] 39 | | BlackjackHand { [INFO] [stdout] 40 | | cards: Vec::new(), [INFO] [stdout] 41 | | } [INFO] [stdout] 42 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 37 + impl Default for BlackjackHand { [INFO] [stdout] 38 + fn default() -> Self { [INFO] [stdout] 39 + Self::new() [INFO] [stdout] 40 + } [INFO] [stdout] 41 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u64` which implements the `Copy` trait [INFO] [stdout] --> src/games/blackjack.rs:187:43 [INFO] [stdout] | [INFO] [stdout] 187 | let player = BlackjackPlayer::new(bet.clone()); [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `bet` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/games/blackjack.rs:336:26 [INFO] [stdout] | [INFO] [stdout] 336 | .description(format!("{}", message)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `message.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/games/blackjack.rs:342:31 [INFO] [stdout] | [INFO] [stdout] 342 | .field("Options", format!("{}", self.give_options()), false) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `self.give_options().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/games/blackjack.rs:494:9 [INFO] [stdout] | [INFO] [stdout] 494 | / return match first_word { [INFO] [stdout] 495 | | "hit" if !self.player.playing_hand().is_blackjack() => { [INFO] [stdout] 496 | | self.hit(); [INFO] [stdout] 497 | | if self.player.playing_hand().is_bust() { [INFO] [stdout] ... | [INFO] [stdout] 552 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 494 ~ match first_word { [INFO] [stdout] 495 + "hit" if !self.player.playing_hand().is_blackjack() => { [INFO] [stdout] 496 + self.hit(); [INFO] [stdout] 497 + if self.player.playing_hand().is_bust() { [INFO] [stdout] 498 + return self.determine_winner(&mut userfile, msg); [INFO] [stdout] 499 + } [INFO] [stdout] 500 + (self.craft_embed(&msg.author.global_name.clone().unwrap(), "You hit! Me looking forward to stealing those nanners!".to_string()), false) [INFO] [stdout] 501 + }, [INFO] [stdout] 502 + "stand" => { [INFO] [stdout] 503 + self.stand(); [INFO] [stdout] 504 + // determine winner [INFO] [stdout] 505 + self.determine_winner(&mut userfile, msg) [INFO] [stdout] 506 + }, [INFO] [stdout] 507 + "split" if self.player.can_split() => { [INFO] [stdout] 508 + // if can't afford [INFO] [stdout] 509 + if userfile.get_bananas() < self.player.bet { [INFO] [stdout] 510 + // reply with error [INFO] [stdout] 511 + return (self.craft_embed(&msg.author.global_name.clone().unwrap(), "You do not have enough bananas to split!".to_string()), false); [INFO] [stdout] 512 + } [INFO] [stdout] 513 + [INFO] [stdout] 514 + self.player.split(); [INFO] [stdout] 515 + userfile.remove_bananas(self.player.bet); [INFO] [stdout] 516 + self.hit(); [INFO] [stdout] 517 + [INFO] [stdout] 518 + (self.craft_embed(&msg.author.global_name.clone().unwrap(), "You split! Me for sure gonna win now!".to_string()), false) [INFO] [stdout] 519 + } [INFO] [stdout] 520 + "double" if self.turn == 0 && !self.player.playing_hand().is_blackjack() => { [INFO] [stdout] 521 + let mut amt = self.player.bet; [INFO] [stdout] 522 + if let Some(next) = words.next() { [INFO] [stdout] 523 + let Ok(a) = next.parse::() else { [INFO] [stdout] 524 + // reply with error [INFO] [stdout] 525 + return (self.craft_embed(&msg.author.global_name.clone().unwrap(), "You must provide a valid amount to double down with!".to_string()), false); [INFO] [stdout] 526 + }; [INFO] [stdout] 527 + // ensure amount is above 5 and below the player's current bet [INFO] [stdout] 528 + if amt < 5 || amt >= self.player.bet { [INFO] [stdout] 529 + // reply with error [INFO] [stdout] 530 + return (self.craft_embed(&msg.author.global_name.clone().unwrap(), [INFO] [stdout] 531 + format!("You must provide a valid amount to double down with! (5 to {})", self.player.bet)), false); [INFO] [stdout] 532 + } [INFO] [stdout] 533 + [INFO] [stdout] 534 + amt = a; [INFO] [stdout] 535 + } [INFO] [stdout] 536 + [INFO] [stdout] 537 + // ensure player has enough money [INFO] [stdout] 538 + if userfile.get_bananas() < amt { [INFO] [stdout] 539 + // reply with error [INFO] [stdout] 540 + return (self.craft_embed(&msg.author.global_name.clone().unwrap(), "You do not have enough bananas to double down with!".to_string()), false); [INFO] [stdout] 541 + } [INFO] [stdout] 542 + [INFO] [stdout] 543 + userfile.remove_bananas(amt); [INFO] [stdout] 544 + [INFO] [stdout] 545 + self.double_down(amt); [INFO] [stdout] 546 + self.determine_winner(&mut userfile, msg) [INFO] [stdout] 547 + }, [INFO] [stdout] 548 + _ => { [INFO] [stdout] 549 + // reply with error [INFO] [stdout] 550 + (self.craft_embed(&msg.author.global_name.clone().unwrap(), "Me no understand what you say. Me only know the following options:".to_string()), false) [INFO] [stdout] 551 + } [INFO] [stdout] 552 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `SludgeMonsterBattle` [INFO] [stdout] --> src/games/sludge_monster_battle.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> Self { [INFO] [stdout] 15 | | // create a new sludge monster battle [INFO] [stdout] 16 | | let boss_health = thread_rng().gen_range(1..=5) * 100; [INFO] [stdout] 17 | | Self { [INFO] [stdout] ... | [INFO] [stdout] 29 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 12 + impl Default for SludgeMonsterBattle { [INFO] [stdout] 13 + fn default() -> Self { [INFO] [stdout] 14 + Self::new() [INFO] [stdout] 15 + } [INFO] [stdout] 16 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/games/pvp.rs:59:19 [INFO] [stdout] | [INFO] [stdout] 59 | host: host.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `host` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/games/pvp.rs:77:21 [INFO] [stdout] | [INFO] [stdout] 77 | health: self.base_health as u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.base_health` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/games/pvp.rs:259:24 [INFO] [stdout] | [INFO] [stdout] 259 | if msg.mentions.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `msg.mentions.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/games/pvp.rs:510:32 [INFO] [stdout] | [INFO] [stdout] 510 | ... if msg.mentions.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `msg.mentions.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/games/pvp.rs:637:54 [INFO] [stdout] | [INFO] [stdout] 637 | return Some(self.handle_win(ctx, self.players[index].user.clone()).await); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.players[index].user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | / match self { [INFO] [stdout] 38 | | CardType::Jack | CardType::Queen | CardType::King => true, [INFO] [stdout] 39 | | _ => false, [INFO] [stdout] 40 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 37 - match self { [INFO] [stdout] 38 - CardType::Jack | CardType::Queen | CardType::King => true, [INFO] [stdout] 39 - _ => false, [INFO] [stdout] 40 - } [INFO] [stdout] 37 + matches!(self, CardType::Jack | CardType::Queen | CardType::King) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:47:30 [INFO] [stdout] | [INFO] [stdout] 47 | CardType::Ace => match other { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 48 | | CardType::Ace => true, [INFO] [stdout] 49 | | _ => false, [INFO] [stdout] 50 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 47 - CardType::Ace => match other { [INFO] [stdout] 48 - CardType::Ace => true, [INFO] [stdout] 49 - _ => false, [INFO] [stdout] 50 - }, [INFO] [stdout] 47 + CardType::Ace => matches!(other, CardType::Ace), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:51:30 [INFO] [stdout] | [INFO] [stdout] 51 | CardType::Two => match other { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 52 | | CardType::Two => true, [INFO] [stdout] 53 | | _ => false, [INFO] [stdout] 54 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 51 - CardType::Two => match other { [INFO] [stdout] 52 - CardType::Two => true, [INFO] [stdout] 53 - _ => false, [INFO] [stdout] 54 - }, [INFO] [stdout] 51 + CardType::Two => matches!(other, CardType::Two), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:55:32 [INFO] [stdout] | [INFO] [stdout] 55 | CardType::Three => match other { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 56 | | CardType::Three => true, [INFO] [stdout] 57 | | _ => false, [INFO] [stdout] 58 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 55 - CardType::Three => match other { [INFO] [stdout] 56 - CardType::Three => true, [INFO] [stdout] 57 - _ => false, [INFO] [stdout] 58 - }, [INFO] [stdout] 55 + CardType::Three => matches!(other, CardType::Three), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:59:31 [INFO] [stdout] | [INFO] [stdout] 59 | CardType::Four => match other { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 60 | | CardType::Four => true, [INFO] [stdout] 61 | | _ => false, [INFO] [stdout] 62 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 59 - CardType::Four => match other { [INFO] [stdout] 60 - CardType::Four => true, [INFO] [stdout] 61 - _ => false, [INFO] [stdout] 62 - }, [INFO] [stdout] 59 + CardType::Four => matches!(other, CardType::Four), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:63:31 [INFO] [stdout] | [INFO] [stdout] 63 | CardType::Five => match other { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 64 | | CardType::Five => true, [INFO] [stdout] 65 | | _ => false, [INFO] [stdout] 66 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 63 - CardType::Five => match other { [INFO] [stdout] 64 - CardType::Five => true, [INFO] [stdout] 65 - _ => false, [INFO] [stdout] 66 - }, [INFO] [stdout] 63 + CardType::Five => matches!(other, CardType::Five), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:67:30 [INFO] [stdout] | [INFO] [stdout] 67 | CardType::Six => match other { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 68 | | CardType::Six => true, [INFO] [stdout] 69 | | _ => false, [INFO] [stdout] 70 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 67 - CardType::Six => match other { [INFO] [stdout] 68 - CardType::Six => true, [INFO] [stdout] 69 - _ => false, [INFO] [stdout] 70 - }, [INFO] [stdout] 67 + CardType::Six => matches!(other, CardType::Six), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:71:32 [INFO] [stdout] | [INFO] [stdout] 71 | CardType::Seven => match other { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 72 | | CardType::Seven => true, [INFO] [stdout] 73 | | _ => false, [INFO] [stdout] 74 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 71 - CardType::Seven => match other { [INFO] [stdout] 72 - CardType::Seven => true, [INFO] [stdout] 73 - _ => false, [INFO] [stdout] 74 - }, [INFO] [stdout] 71 + CardType::Seven => matches!(other, CardType::Seven), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:75:32 [INFO] [stdout] | [INFO] [stdout] 75 | CardType::Eight => match other { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 76 | | CardType::Eight => true, [INFO] [stdout] 77 | | _ => false, [INFO] [stdout] 78 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 75 - CardType::Eight => match other { [INFO] [stdout] 76 - CardType::Eight => true, [INFO] [stdout] 77 - _ => false, [INFO] [stdout] 78 - }, [INFO] [stdout] 75 + CardType::Eight => matches!(other, CardType::Eight), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:79:31 [INFO] [stdout] | [INFO] [stdout] 79 | CardType::Nine => match other { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 80 | | CardType::Nine => true, [INFO] [stdout] 81 | | _ => false, [INFO] [stdout] 82 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 79 - CardType::Nine => match other { [INFO] [stdout] 80 - CardType::Nine => true, [INFO] [stdout] 81 - _ => false, [INFO] [stdout] 82 - }, [INFO] [stdout] 79 + CardType::Nine => matches!(other, CardType::Nine), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:83:30 [INFO] [stdout] | [INFO] [stdout] 83 | CardType::Ten => match other { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 84 | | CardType::Ten => true, [INFO] [stdout] 85 | | _ => false, [INFO] [stdout] 86 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 83 - CardType::Ten => match other { [INFO] [stdout] 84 - CardType::Ten => true, [INFO] [stdout] 85 - _ => false, [INFO] [stdout] 86 - }, [INFO] [stdout] 83 + CardType::Ten => matches!(other, CardType::Ten), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:87:31 [INFO] [stdout] | [INFO] [stdout] 87 | CardType::Jack => match other { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 88 | | CardType::Jack => true, [INFO] [stdout] 89 | | _ => false, [INFO] [stdout] 90 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 87 - CardType::Jack => match other { [INFO] [stdout] 88 - CardType::Jack => true, [INFO] [stdout] 89 - _ => false, [INFO] [stdout] 90 - }, [INFO] [stdout] 87 + CardType::Jack => matches!(other, CardType::Jack), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:91:32 [INFO] [stdout] | [INFO] [stdout] 91 | CardType::Queen => match other { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 92 | | CardType::Queen => true, [INFO] [stdout] 93 | | _ => false, [INFO] [stdout] 94 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 91 - CardType::Queen => match other { [INFO] [stdout] 92 - CardType::Queen => true, [INFO] [stdout] 93 - _ => false, [INFO] [stdout] 94 - }, [INFO] [stdout] 91 + CardType::Queen => matches!(other, CardType::Queen), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:95:31 [INFO] [stdout] | [INFO] [stdout] 95 | CardType::King => match other { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 96 | | CardType::King => true, [INFO] [stdout] 97 | | _ => false, [INFO] [stdout] 98 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 95 - CardType::King => match other { [INFO] [stdout] 96 - CardType::King => true, [INFO] [stdout] 97 - _ => false, [INFO] [stdout] 98 - }, [INFO] [stdout] 95 + CardType::King => matches!(other, CardType::King), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:99:32 [INFO] [stdout] | [INFO] [stdout] 99 | CardType::Joker => match other { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 100 | | CardType::Joker => true, [INFO] [stdout] 101 | | _ => false, [INFO] [stdout] 102 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 99 - CardType::Joker => match other { [INFO] [stdout] 100 - CardType::Joker => true, [INFO] [stdout] 101 - _ => false, [INFO] [stdout] 102 - }, [INFO] [stdout] 99 + CardType::Joker => matches!(other, CardType::Joker), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | / match self { [INFO] [stdout] 118 | | Suit::Hearts | Suit::Diamonds => true, [INFO] [stdout] 119 | | _ => false, [INFO] [stdout] 120 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 117 - match self { [INFO] [stdout] 118 - Suit::Hearts | Suit::Diamonds => true, [INFO] [stdout] 119 - _ => false, [INFO] [stdout] 120 - } [INFO] [stdout] 117 + matches!(self, Suit::Hearts | Suit::Diamonds) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 124 | / match self { [INFO] [stdout] 125 | | Suit::Clubs | Suit::Spades => true, [INFO] [stdout] 126 | | _ => false, [INFO] [stdout] 127 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 124 - match self { [INFO] [stdout] 125 - Suit::Clubs | Suit::Spades => true, [INFO] [stdout] 126 - _ => false, [INFO] [stdout] 127 - } [INFO] [stdout] 124 + matches!(self, Suit::Clubs | Suit::Spades) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:134:29 [INFO] [stdout] | [INFO] [stdout] 134 | Suit::Hearts => match other { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 135 | | Suit::Hearts => true, [INFO] [stdout] 136 | | _ => false, [INFO] [stdout] 137 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 134 - Suit::Hearts => match other { [INFO] [stdout] 135 - Suit::Hearts => true, [INFO] [stdout] 136 - _ => false, [INFO] [stdout] 137 - }, [INFO] [stdout] 134 + Suit::Hearts => matches!(other, Suit::Hearts), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:138:31 [INFO] [stdout] | [INFO] [stdout] 138 | Suit::Diamonds => match other { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 139 | | Suit::Diamonds => true, [INFO] [stdout] 140 | | _ => false, [INFO] [stdout] 141 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 138 - Suit::Diamonds => match other { [INFO] [stdout] 139 - Suit::Diamonds => true, [INFO] [stdout] 140 - _ => false, [INFO] [stdout] 141 - }, [INFO] [stdout] 138 + Suit::Diamonds => matches!(other, Suit::Diamonds), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:142:28 [INFO] [stdout] | [INFO] [stdout] 142 | Suit::Clubs => match other { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 143 | | Suit::Clubs => true, [INFO] [stdout] 144 | | _ => false, [INFO] [stdout] 145 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 142 - Suit::Clubs => match other { [INFO] [stdout] 143 - Suit::Clubs => true, [INFO] [stdout] 144 - _ => false, [INFO] [stdout] 145 - }, [INFO] [stdout] 142 + Suit::Clubs => matches!(other, Suit::Clubs), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/games/mod.rs:146:29 [INFO] [stdout] | [INFO] [stdout] 146 | Suit::Spades => match other { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 147 | | Suit::Spades => true, [INFO] [stdout] 148 | | _ => false, [INFO] [stdout] 149 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 146 - Suit::Spades => match other { [INFO] [stdout] 147 - Suit::Spades => true, [INFO] [stdout] 148 - _ => false, [INFO] [stdout] 149 - }, [INFO] [stdout] 146 + Suit::Spades => matches!(other, Suit::Spades), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/games/mod.rs:451:31 [INFO] [stdout] | [INFO] [stdout] 451 | self.players.contains(&player) [INFO] [stdout] | ^^^^^^^ help: change this to: `player` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `GamesManager` [INFO] [stdout] --> src/games/mod.rs:466:5 [INFO] [stdout] | [INFO] [stdout] 466 | / pub fn new() -> GamesManager { [INFO] [stdout] 467 | | GamesManager { games: HashMap::new() } [INFO] [stdout] 468 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 465 + impl Default for GamesManager { [INFO] [stdout] 466 + fn default() -> Self { [INFO] [stdout] 467 + Self::new() [INFO] [stdout] 468 + } [INFO] [stdout] 469 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/games/mod.rs:472:27 [INFO] [stdout] | [INFO] [stdout] 472 | self.games.insert(code.clone(), game); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/games/mod.rs:506:33 [INFO] [stdout] | [INFO] [stdout] 506 | self.games.contains_key(&code) [INFO] [stdout] | ^^^^^ help: change this to: `code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/games/mod.rs:512:29 [INFO] [stdout] | [INFO] [stdout] 512 | return Some(code.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/games/mod.rs:517:29 [INFO] [stdout] | [INFO] [stdout] 517 | return Some(code.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/games/mod.rs:532:9 [INFO] [stdout] | [INFO] [stdout] 532 | / for game in self.games.values_mut() { [INFO] [stdout] 533 | | if game.has_player(player) { [INFO] [stdout] 534 | | return Some(game); [INFO] [stdout] ... | [INFO] [stdout] 537 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `self.games.values_mut().find(|game| game.has_player(player)).map(|v| v as _)` [INFO] [stdout] | [INFO] [stdout] = note: you may need to dereference some variables [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] = note: `#[warn(clippy::manual_find)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `Iterator::find` [INFO] [stdout] --> src/games/mod.rs:540:9 [INFO] [stdout] | [INFO] [stdout] 540 | / for game in self.games.values_mut() { [INFO] [stdout] 541 | | if game.host == *player { [INFO] [stdout] 542 | | return Some(game); [INFO] [stdout] ... | [INFO] [stdout] 545 | | None [INFO] [stdout] | |____________^ help: replace with an iterator: `self.games.values_mut().find(|game| game.host == *player).map(|v| v as _)` [INFO] [stdout] | [INFO] [stdout] = note: you may need to dereference some variables [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_find [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UserId` which implements the `Copy` trait [INFO] [stdout] --> src/games/mod.rs:559:25 [INFO] [stdout] | [INFO] [stdout] 559 | game.add_player(user.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `user` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/inventory.rs:34:18 [INFO] [stdout] | [INFO] [stdout] 34 | Some(&item) [INFO] [stdout] | ^^^^^ help: change this to: `item` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/mine_data.rs:19:12 [INFO] [stdout] | [INFO] [stdout] 19 | if self.items.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.items.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:82:5 [INFO] [stdout] | [INFO] [stdout] 82 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return false; [INFO] [stdout] 82 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `msg.mentions.get(0)` [INFO] [stdout] --> src/main.rs:197:33 [INFO] [stdout] | [INFO] [stdout] 197 | let recipient = msg.mentions.get(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `msg.mentions.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:317:67 [INFO] [stdout] | [INFO] [stdout] 317 | builder = builder.add_file(CreateAttachment::path(format!("{}", thumbnail_path)).await.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `thumbnail_path.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:347:12 [INFO] [stdout] | [INFO] [stdout] 347 | if msg.embeds.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!msg.embeds.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:476:9 [INFO] [stdout] | [INFO] [stdout] 476 | / match interaction { [INFO] [stdout] 477 | | Interaction::Command(command) => { [INFO] [stdout] 478 | | let command_name = command.data.name.as_str(); [INFO] [stdout] 479 | | let sender = &command.user; [INFO] [stdout] ... | [INFO] [stdout] 594 | | _ => {} [INFO] [stdout] 595 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 476 ~ if let Interaction::Command(command) = interaction { [INFO] [stdout] 477 + let command_name = command.data.name.as_str(); [INFO] [stdout] 478 + let sender = &command.user; [INFO] [stdout] 479 + let guild = command.guild_id; [INFO] [stdout] 480 + if guild.is_none() { [INFO] [stdout] 481 + command_response(&ctx, &command, "This command can only be used in a server").await; [INFO] [stdout] 482 + return; [INFO] [stdout] 483 + } [INFO] [stdout] 484 + let guild_id = guild.unwrap(); [INFO] [stdout] 485 + let command_options = &command.data.options(); [INFO] [stdout] 486 + let channel = command.channel_id; [INFO] [stdout] 487 + [INFO] [stdout] 488 + let mut guild_settings = guildfile::GuildSettings::get(&guild_id); [INFO] [stdout] 489 + [INFO] [stdout] 490 + // non-channel specific commands [INFO] [stdout] 491 + match command_name { [INFO] [stdout] 492 + "help" => { [INFO] [stdout] 493 + help::run(&ctx, &command).await; [INFO] [stdout] 494 + return; [INFO] [stdout] 495 + } [INFO] [stdout] 496 + "info" => { [INFO] [stdout] 497 + banana::info::run(&ctx, &command, &sender.id).await; [INFO] [stdout] 498 + return; [INFO] [stdout] 499 + } [INFO] [stdout] 500 + "levelup" => { [INFO] [stdout] 501 + banana::levelup::run(command_options, &ctx, &command, &sender.id).await; [INFO] [stdout] 502 + return; [INFO] [stdout] 503 + } [INFO] [stdout] 504 + "prestige" => { [INFO] [stdout] 505 + banana::prestige::run(&ctx, &command, &sender.id).await; [INFO] [stdout] 506 + return; [INFO] [stdout] 507 + } [INFO] [stdout] 508 + "leaderboard" => { [INFO] [stdout] 509 + banana::leaderboard::run(&ctx, &command).await; [INFO] [stdout] 510 + return; [INFO] [stdout] 511 + } [INFO] [stdout] 512 + "pay" => { [INFO] [stdout] 513 + banana::pay::run(command_options, &ctx, &command, &sender.id).await; [INFO] [stdout] 514 + return; [INFO] [stdout] 515 + } [INFO] [stdout] 516 + "ascend" => { [INFO] [stdout] 517 + banana::ascend::run(&ctx, &command, &sender.id).await; [INFO] [stdout] 518 + return; [INFO] [stdout] 519 + } [INFO] [stdout] 520 + "inventory" => { [INFO] [stdout] 521 + inventory_cmd::run(&ctx, &command).await; [INFO] [stdout] 522 + return; [INFO] [stdout] 523 + } [INFO] [stdout] 524 + "shop" => { [INFO] [stdout] 525 + shop::run(&ctx, &command).await; [INFO] [stdout] 526 + return; [INFO] [stdout] 527 + } [INFO] [stdout] 528 + "buy" => { [INFO] [stdout] 529 + buy::run(command_options, &ctx, &command).await; [INFO] [stdout] 530 + return; [INFO] [stdout] 531 + } [INFO] [stdout] 532 + "discard" => { [INFO] [stdout] 533 + discard::run(command_options, &ctx, &command).await; [INFO] [stdout] 534 + return; [INFO] [stdout] 535 + } [INFO] [stdout] 536 + "collect_minions" => { [INFO] [stdout] 537 + collect_minions::run(&ctx, &command).await; [INFO] [stdout] 538 + return; [INFO] [stdout] 539 + } [INFO] [stdout] 540 + "equip" => { [INFO] [stdout] 541 + equip::run(command_options, &ctx, &command).await; [INFO] [stdout] 542 + return; [INFO] [stdout] 543 + } [INFO] [stdout] 544 + "unequip" => { [INFO] [stdout] 545 + unequip::run(&ctx, &command).await; [INFO] [stdout] 546 + return; [INFO] [stdout] 547 + } [INFO] [stdout] 548 + "pvp" => { [INFO] [stdout] 549 + pvp_command::run(command_options, &ctx, &command, &sender.id).await; [INFO] [stdout] 550 + return; [INFO] [stdout] 551 + } [INFO] [stdout] 552 + "join" => { [INFO] [stdout] 553 + join::run(command_options, &ctx, &command, &sender.id).await; [INFO] [stdout] 554 + return; [INFO] [stdout] 555 + } [INFO] [stdout] 556 + "admin_channel" => { [INFO] [stdout] 557 + admin::run(command_options, &ctx, &command, &guild_id).await; [INFO] [stdout] 558 + return; [INFO] [stdout] 559 + } [INFO] [stdout] 560 + _ => {} [INFO] [stdout] 561 + } [INFO] [stdout] 562 + [INFO] [stdout] 563 + // spam commands that need checked [INFO] [stdout] 564 + if guild_settings.is_allowed_channel(channel.get()) { [INFO] [stdout] 565 + match command_name { [INFO] [stdout] 566 + "blackjack" => { [INFO] [stdout] 567 + blackjack_cmd::run(command_options, &ctx, &command, &sender.id).await; [INFO] [stdout] 568 + } [INFO] [stdout] 569 + "slots" => { [INFO] [stdout] 570 + slots::run(command_options, &ctx, &command, &sender.id).await; [INFO] [stdout] 571 + } [INFO] [stdout] 572 + "fiftyfifty" => { [INFO] [stdout] 573 + fiftyfifty::run(&ctx, &command, &sender.id).await; [INFO] [stdout] 574 + } [INFO] [stdout] 575 + "mine" => { [INFO] [stdout] 576 + mine::run(command_options, &ctx, &channel, command.clone(), &sender.id).await; [INFO] [stdout] 577 + } [INFO] [stdout] 578 + _ => { [INFO] [stdout] 579 + command_response(&ctx, &command, "That do be a monkey brain moment").await; [INFO] [stdout] 580 + } [INFO] [stdout] 581 + } [INFO] [stdout] 582 + } else { [INFO] [stdout] 583 + let allowed_channels = { [INFO] [stdout] 584 + let mut channels = Vec::new(); [INFO] [stdout] 585 + for cid in guild_settings.get_channels() { [INFO] [stdout] 586 + channels.push(cid.to_channel(&ctx).await.unwrap().to_string()); [INFO] [stdout] 587 + } [INFO] [stdout] 588 + channels [INFO] [stdout] 589 + }; [INFO] [stdout] 590 + command_response(&ctx, &command, format!("That command is only allowed in the following channel(s): {}", allowed_channels.join(", "))).await; [INFO] [stdout] 591 + } [INFO] [stdout] 592 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 54s [INFO] running `Command { std: "docker" "inspect" "fb0c8f3e21d4d089a09a3975f5cb056d4a746e74e7183b4b2c92a499bee56403", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb0c8f3e21d4d089a09a3975f5cb056d4a746e74e7183b4b2c92a499bee56403", kill_on_drop: false }` [INFO] [stdout] fb0c8f3e21d4d089a09a3975f5cb056d4a746e74e7183b4b2c92a499bee56403