[INFO] cloning repository https://github.com/SirSquirrel09/music-info
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SirSquirrel09/music-info" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSirSquirrel09%2Fmusic-info", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSirSquirrel09%2Fmusic-info'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 6e4f733cdf51fa3394e3a988b90d5bf68a7f7537
[INFO] linting SirSquirrel09/music-info against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSirSquirrel09%2Fmusic-info" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/SirSquirrel09/music-info
[INFO] finished tweaking git repo https://github.com/SirSquirrel09/music-info
[INFO] tweaked toml for git repo https://github.com/SirSquirrel09/music-info written to /workspace/builds/worker-3-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/SirSquirrel09/music-info on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/SirSquirrel09/music-info already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 3ace5229e9f40f2230c64ee42b628819a5701c0f2eb58c5f3b025b3aa5f9c5c5
[INFO] running `Command { std: "docker" "start" "-a" "3ace5229e9f40f2230c64ee42b628819a5701c0f2eb58c5f3b025b3aa5f9c5c5", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "3ace5229e9f40f2230c64ee42b628819a5701c0f2eb58c5f3b025b3aa5f9c5c5", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "3ace5229e9f40f2230c64ee42b628819a5701c0f2eb58c5f3b025b3aa5f9c5c5", kill_on_drop: false }`
[INFO] [stdout] 3ace5229e9f40f2230c64ee42b628819a5701c0f2eb58c5f3b025b3aa5f9c5c5
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] f660a9a7006927a62c656a5a0b9f2a97e33a0d141c51db404e33931fb2428999
[INFO] running `Command { std: "docker" "start" "-a" "f660a9a7006927a62c656a5a0b9f2a97e33a0d141c51db404e33931fb2428999", kill_on_drop: false }`
[INFO] [stderr]     Checking music-info v1.0.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:22:5
[INFO] [stdout]    |
[INFO] [stdout] 22 |     return the_stuff;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 22 -     return the_stuff;
[INFO] [stdout] 22 +     the_stuff
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:22:5
[INFO] [stdout]    |
[INFO] [stdout] 22 |     return the_stuff;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 22 -     return the_stuff;
[INFO] [stdout] 22 +     the_stuff
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]   --> src/main.rs:11:9
[INFO] [stdout]    |
[INFO] [stdout] 11 | /         if arg.contains("--player=") {
[INFO] [stdout] 12 | |             if let Some(player) = arg.split("=").nth(1) {
[INFO] [stdout] 13 | |                 the_stuff[0] = player.to_string();
[INFO] [stdout] 14 | |             }
[INFO] [stdout] 15 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]    = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 11 ~         if arg.contains("--player=")
[INFO] [stdout] 12 ~             && let Some(player) = arg.split("=").nth(1) {
[INFO] [stdout] 13 |                 the_stuff[0] = player.to_string();
[INFO] [stdout] 14 ~             }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]   --> src/main.rs:16:9
[INFO] [stdout]    |
[INFO] [stdout] 16 | /         if arg.contains("--format=") {
[INFO] [stdout] 17 | |             if let Some(format) = arg.split("=").nth(1) {
[INFO] [stdout] 18 | |                 the_stuff[1] = format.to_string();
[INFO] [stdout] 19 | |             }
[INFO] [stdout] 20 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 16 ~         if arg.contains("--format=")
[INFO] [stdout] 17 ~             && let Some(format) = arg.split("=").nth(1) {
[INFO] [stdout] 18 |                 the_stuff[1] = format.to_string();
[INFO] [stdout] 19 ~             }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:29:5
[INFO] [stdout]    |
[INFO] [stdout] 29 |     return cmd_trimmed;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 29 -     return cmd_trimmed;
[INFO] [stdout] 29 +     cmd_trimmed
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]   --> src/main.rs:11:9
[INFO] [stdout]    |
[INFO] [stdout] 11 | /         if arg.contains("--player=") {
[INFO] [stdout] 12 | |             if let Some(player) = arg.split("=").nth(1) {
[INFO] [stdout] 13 | |                 the_stuff[0] = player.to_string();
[INFO] [stdout] 14 | |             }
[INFO] [stdout] 15 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout]    = note: `#[warn(clippy::collapsible_if)]` on by default
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 11 ~         if arg.contains("--player=")
[INFO] [stdout] 12 ~             && let Some(player) = arg.split("=").nth(1) {
[INFO] [stdout] 13 |                 the_stuff[0] = player.to_string();
[INFO] [stdout] 14 ~             }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this `if` statement can be collapsed
[INFO] [stdout]   --> src/main.rs:16:9
[INFO] [stdout]    |
[INFO] [stdout] 16 | /         if arg.contains("--format=") {
[INFO] [stdout] 17 | |             if let Some(format) = arg.split("=").nth(1) {
[INFO] [stdout] 18 | |                 the_stuff[1] = format.to_string();
[INFO] [stdout] 19 | |             }
[INFO] [stdout] 20 | |         }
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stdout] help: collapse nested if block
[INFO] [stdout]    |
[INFO] [stdout] 16 ~         if arg.contains("--format=")
[INFO] [stdout] 17 ~             && let Some(format) = arg.split("=").nth(1) {
[INFO] [stdout] 18 |                 the_stuff[1] = format.to_string();
[INFO] [stdout] 19 ~             }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:49:8
[INFO] [stdout]    |
[INFO] [stdout] 49 |     if !(String::from_utf8_lossy(&check.stdout).trim().to_string() == "".to_string()) {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(String::from_utf8_lossy(&check.stdout).trim().to_string() != "".to_string())`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:29:5
[INFO] [stdout]    |
[INFO] [stdout] 29 |     return cmd_trimmed;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 29 -     return cmd_trimmed;
[INFO] [stdout] 29 +     cmd_trimmed
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]   --> src/main.rs:38:18
[INFO] [stdout]    |
[INFO] [stdout] 38 |     if player == "auto".to_string() {
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^ help: try: `"auto"`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout]    = note: `#[warn(clippy::cmp_owned)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]   --> src/main.rs:41:37
[INFO] [stdout]    |
[INFO] [stdout] 41 |          if let Some(firstplayer) = detect_to_string.split("\n").nth(0) {
[INFO] [stdout]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `detect_to_string.split("\n").next()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout]    = note: `#[warn(clippy::iter_nth_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/main.rs:49:8
[INFO] [stdout]    |
[INFO] [stdout] 49 |     if !(String::from_utf8_lossy(&check.stdout).trim().to_string() == "".to_string()) {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(String::from_utf8_lossy(&check.stdout).trim().to_string() != "".to_string())`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]   --> src/main.rs:38:18
[INFO] [stdout]    |
[INFO] [stdout] 38 |     if player == "auto".to_string() {
[INFO] [stdout]    |                  ^^^^^^^^^^^^^^^^^^ help: try: `"auto"`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout]    = note: `#[warn(clippy::cmp_owned)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: called `.nth(0)` on a `std::iter::Iterator`, when `.next()` is equivalent
[INFO] [stdout]   --> src/main.rs:41:37
[INFO] [stdout]    |
[INFO] [stdout] 41 |          if let Some(firstplayer) = detect_to_string.split("\n").nth(0) {
[INFO] [stdout]    |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try calling `.next()` instead of `.nth(0)`: `detect_to_string.split("\n").next()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth_zero
[INFO] [stdout]    = note: `#[warn(clippy::iter_nth_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]   --> src/main.rs:49:10
[INFO] [stdout]    |
[INFO] [stdout] 49 |     if !(String::from_utf8_lossy(&check.stdout).trim().to_string() == "".to_string()) {
[INFO] [stdout]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `String::from_utf8_lossy(&check.stdout).trim()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]   --> src/main.rs:49:71
[INFO] [stdout]    |
[INFO] [stdout] 49 |     if !(String::from_utf8_lossy(&check.stdout).trim().to_string() == "".to_string()) {
[INFO] [stdout]    |                                                                       ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]   --> src/main.rs:49:10
[INFO] [stdout]    |
[INFO] [stdout] 49 |     if !(String::from_utf8_lossy(&check.stdout).trim().to_string() == "".to_string()) {
[INFO] [stdout]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `String::from_utf8_lossy(&check.stdout).trim()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this creates an owned instance just for comparison
[INFO] [stdout]   --> src/main.rs:49:71
[INFO] [stdout]    |
[INFO] [stdout] 49 |     if !(String::from_utf8_lossy(&check.stdout).trim().to_string() == "".to_string()) {
[INFO] [stdout]    |                                                                       ^^^^^^^^^^^^^^ help: try: `""`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.10s
[INFO] running `Command { std: "docker" "inspect" "f660a9a7006927a62c656a5a0b9f2a97e33a0d141c51db404e33931fb2428999", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "f660a9a7006927a62c656a5a0b9f2a97e33a0d141c51db404e33931fb2428999", kill_on_drop: false }`
[INFO] [stdout] f660a9a7006927a62c656a5a0b9f2a97e33a0d141c51db404e33931fb2428999