[INFO] cloning repository https://github.com/SimoneBorella/snap-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SimoneBorella/snap-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSimoneBorella%2Fsnap-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSimoneBorella%2Fsnap-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1c49424272c032365ac5b9dacc55faf843f358e9 [INFO] linting SimoneBorella/snap-rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSimoneBorella%2Fsnap-rust" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/SimoneBorella/snap-rust [INFO] finished tweaking git repo https://github.com/SimoneBorella/snap-rust [INFO] tweaked toml for git repo https://github.com/SimoneBorella/snap-rust written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/SimoneBorella/snap-rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/SimoneBorella/snap-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded libwayshot v0.2.0 [INFO] [stderr] Downloaded display-info v0.4.5 [INFO] [stderr] Downloaded wayland-protocols-wlr v0.1.0 [INFO] [stderr] Downloaded glutin_egl_sys v0.5.1 [INFO] [stderr] Downloaded imagesize v0.10.1 [INFO] [stderr] Downloaded egui-winit v0.22.0 [INFO] [stderr] Downloaded data-url v0.2.0 [INFO] [stderr] Downloaded roxmltree v0.15.1 [INFO] [stderr] Downloaded event-listener v4.0.2 [INFO] [stderr] Downloaded futures-lite v2.1.0 [INFO] [stderr] Downloaded glutin v0.30.10 [INFO] [stderr] Downloaded eframe v0.22.0 [INFO] [stderr] Downloaded resvg v0.28.0 [INFO] [stderr] Downloaded kurbo v0.8.3 [INFO] [stderr] Downloaded wayland-protocols v0.30.1 [INFO] [stderr] Downloaded usvg v0.28.0 [INFO] [stderr] Downloaded winnow v0.5.32 [INFO] [stderr] Downloaded exr v1.71.0 [INFO] [stderr] Downloaded xcb v1.3.0 [INFO] [stderr] Downloaded syn v2.0.47 [INFO] [stderr] Downloaded crossbeam-channel v0.5.10 [INFO] [stderr] Downloaded wide v0.7.13 [INFO] [stderr] Downloaded gdk-sys v0.18.0 [INFO] [stderr] Downloaded accesskit_unix v0.5.2 [INFO] [stderr] Downloaded egui_glow v0.22.0 [INFO] [stderr] Downloaded egui_extras v0.22.0 [INFO] [stderr] Downloaded global-hotkey v0.4.1 [INFO] [stderr] Downloaded atk-sys v0.18.0 [INFO] [stderr] Downloaded simplecss v0.2.1 [INFO] [stderr] Downloaded svgtypes v0.8.2 [INFO] [stderr] Downloaded gtk-sys v0.18.0 [INFO] [stderr] Downloaded screenshots v0.8.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 75fc43ded9b113e6842b6b93951cc9caa2f48bc12c6a14627e303f945979ab93 [INFO] running `Command { std: "docker" "start" "-a" "75fc43ded9b113e6842b6b93951cc9caa2f48bc12c6a14627e303f945979ab93", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "75fc43ded9b113e6842b6b93951cc9caa2f48bc12c6a14627e303f945979ab93", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "75fc43ded9b113e6842b6b93951cc9caa2f48bc12c6a14627e303f945979ab93", kill_on_drop: false }` [INFO] [stdout] 75fc43ded9b113e6842b6b93951cc9caa2f48bc12c6a14627e303f945979ab93 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a9ac2235536fe91f68717ac9723cdadf742b3c734e6756b9ad2ec9d56469f126 [INFO] running `Command { std: "docker" "start" "-a" "a9ac2235536fe91f68717ac9723cdadf742b3c734e6756b9ad2ec9d56469f126", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.75 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling pkg-config v0.3.28 [INFO] [stderr] Compiling serde v1.0.194 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Compiling winnow v0.5.32 [INFO] [stderr] Compiling target-lexicon v0.12.13 [INFO] [stderr] Compiling crossbeam-utils v0.8.18 [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Compiling xml-rs v0.8.19 [INFO] [stderr] Checking libloading v0.8.1 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking fdeflate v0.3.3 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking ab_glyph_rasterizer v0.1.8 [INFO] [stderr] Compiling wayland-sys v0.29.5 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Checking ttf-parser v0.20.0 [INFO] [stderr] Compiling indexmap v2.1.0 [INFO] [stderr] Compiling cfg-expr v0.15.6 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Compiling wayland-sys v0.30.1 [INFO] [stderr] Checking concurrent-queue v2.4.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.17 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking png v0.17.10 [INFO] [stderr] Checking strict-num v0.1.1 [INFO] [stderr] Compiling slotmap v1.0.7 [INFO] [stderr] Checking event-listener v4.0.2 [INFO] [stderr] Compiling syn v2.0.47 [INFO] [stderr] Compiling wayland-scanner v0.29.5 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Checking crossbeam-deque v0.8.4 [INFO] [stderr] Checking event-listener-strategy v0.4.0 [INFO] [stderr] Checking num-integer v0.1.45 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking async-lock v3.2.0 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Compiling aho-corasick v1.1.2 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Compiling smithay-client-toolkit v0.16.1 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking futures-lite v2.1.0 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Checking weezl v0.1.7 [INFO] [stderr] Compiling wayland-client v0.29.5 [INFO] [stderr] Compiling wayland-protocols v0.29.5 [INFO] [stderr] Checking xcursor v0.3.5 [INFO] [stderr] Checking async-task v4.7.0 [INFO] [stderr] Checking waker-fn v1.1.1 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Compiling rustix v0.37.27 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking piper v0.2.1 [INFO] [stderr] Compiling regex-automata v0.4.3 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking owned_ttf_parser v0.20.0 [INFO] [stderr] Checking wayland-commons v0.29.5 [INFO] [stderr] Checking ab_glyph v0.2.23 [INFO] [stderr] Checking async-channel v2.1.1 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Compiling ahash v0.8.7 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Compiling async-fs v1.6.0 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Checking half v2.2.1 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Checking gif v0.12.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking jpeg-decoder v0.3.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking exr v1.71.0 [INFO] [stderr] Compiling wayland-backend v0.1.2 [INFO] [stderr] Compiling toml_datetime v0.6.5 [INFO] [stderr] Compiling serde_spanned v0.6.5 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking cpufeatures v0.2.11 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling toml_edit v0.21.0 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Checking async-executor v1.8.0 [INFO] [stderr] Compiling winit v0.28.7 [INFO] [stderr] Checking tiff v0.9.0 [INFO] [stderr] Checking async-broadcast v0.5.1 [INFO] [stderr] Compiling quick-xml v0.28.2 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking base64 v0.21.5 [INFO] [stderr] Checking wayland-cursor v0.29.5 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Compiling glutin_glx_sys v0.4.0 [INFO] [stderr] Compiling glutin_egl_sys v0.5.1 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Compiling quick-xml v0.30.0 [INFO] [stderr] Checking xdg-home v1.0.0 [INFO] [stderr] Compiling wayland-scanner v0.30.1 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking unicode-bidi v0.3.14 [INFO] [stderr] Compiling x11rb v0.12.0 [INFO] [stderr] Compiling zvariant_utils v1.0.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling xcb v1.3.0 [INFO] [stderr] Checking x11rb-protocol v0.12.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling regex v1.10.2 [INFO] [stderr] Compiling libdbus-sys v0.2.5 [INFO] [stderr] Checking gethostname v0.3.0 [INFO] [stderr] Checking num-complex v0.4.4 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Compiling glutin v0.30.10 [INFO] [stderr] Compiling matrixmultiply v0.3.8 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Checking xmlparser v0.13.6 [INFO] [stderr] Compiling rustix v0.38.28 [INFO] [stderr] Checking svgtypes v0.8.2 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking roxmltree v0.15.1 [INFO] [stderr] Compiling bytemuck_derive v1.5.0 [INFO] [stderr] Compiling serde_derive v1.0.194 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling enumn v0.1.13 [INFO] [stderr] Compiling enumflags2_derive v0.7.8 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling toml v0.8.8 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Compiling async-recursion v1.0.5 [INFO] [stderr] Compiling system-deps v6.2.0 [INFO] [stderr] Compiling zvariant_derive v3.15.0 [INFO] [stderr] Checking bytemuck v1.14.0 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling serde_repr v0.1.18 [INFO] [stderr] Compiling atspi-macros v0.2.0 [INFO] [stderr] Compiling zbus_macros v3.14.1 [INFO] [stderr] Checking tiny-skia-path v0.8.4 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking safe_arch v0.7.1 [INFO] [stderr] Checking calloop v0.10.6 [INFO] [stderr] Checking image v0.24.7 [INFO] [stderr] Checking wayland-client v0.30.2 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tiny-skia v0.8.4 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking kurbo v0.8.3 [INFO] [stderr] Checking wide v0.7.13 [INFO] [stderr] Compiling glutin-winit v0.3.0 [INFO] [stderr] Checking simplecss v0.2.1 [INFO] [stderr] Checking blocking v1.5.1 [INFO] [stderr] Compiling glib-sys v0.18.1 [INFO] [stderr] Compiling gobject-sys v0.18.0 [INFO] [stderr] Compiling gdk-sys v0.18.0 [INFO] [stderr] Compiling atk-sys v0.18.0 [INFO] [stderr] Compiling gio-sys v0.18.1 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.18.0 [INFO] [stderr] Compiling cairo-sys-rs v0.18.2 [INFO] [stderr] Compiling pango-sys v0.18.0 [INFO] [stderr] Compiling gtk-sys v0.18.0 [INFO] [stderr] Checking wayland-protocols v0.30.1 [INFO] [stderr] Checking libloading v0.7.4 [INFO] [stderr] Checking imagesize v0.10.1 [INFO] [stderr] Checking ttf-parser v0.15.2 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking data-url v0.2.0 [INFO] [stderr] Checking rctree v0.5.0 [INFO] [stderr] Checking simba v0.7.3 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking usvg v0.28.0 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rgb v0.8.37 [INFO] [stderr] Checking webbrowser v0.8.12 [INFO] [stderr] Checking memmap2 v0.7.1 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking pico-args v0.5.0 [INFO] [stderr] Checking unicode-segmentation v1.10.1 [INFO] [stderr] Checking glow v0.12.3 [INFO] [stderr] Compiling rfd v0.12.1 [INFO] [stderr] Checking resvg v0.28.0 [INFO] [stderr] Checking owned_ttf_parser v0.15.2 [INFO] [stderr] Checking rusttype v0.9.3 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking num v0.4.1 [INFO] [stderr] Checking rand_distr v0.2.2 [INFO] [stderr] Checking crossbeam-channel v0.5.10 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking wayland-protocols-wlr v0.1.0 [INFO] [stderr] Checking versions v5.0.1 [INFO] [stderr] Checking arboard v3.3.0 [INFO] [stderr] Checking display-info v0.4.5 [INFO] [stderr] Checking libwayshot v0.2.0 [INFO] [stderr] Checking dbus v0.9.7 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking accesskit v0.11.2 [INFO] [stderr] Checking enumflags2 v0.7.8 [INFO] [stderr] Checking emath v0.22.0 [INFO] [stderr] Checking ecolor v0.22.0 [INFO] [stderr] Checking ron v0.8.1 [INFO] [stderr] Checking keyboard-types v0.7.0 [INFO] [stderr] Checking zvariant v3.15.0 [INFO] [stderr] Checking epaint v0.22.0 [INFO] [stderr] Checking nalgebra v0.30.1 [INFO] [stderr] Checking accesskit_consumer v0.15.2 [INFO] [stderr] Checking global-hotkey v0.4.1 [INFO] [stderr] Checking egui v0.22.0 [INFO] [stderr] Checking which v4.4.2 [INFO] [stderr] Checking zbus_names v2.6.0 [INFO] [stderr] Checking screenshots v0.8.6 [INFO] [stderr] Checking native-dialog v0.7.0 [INFO] [stderr] Checking zbus v3.14.1 [INFO] [stderr] Checking egui_glow v0.22.0 [INFO] [stderr] Checking egui_extras v0.22.0 [INFO] [stderr] Checking atspi v0.10.1 [INFO] [stderr] Checking imageproc v0.23.0 [INFO] [stderr] Checking sctk-adwaita v0.5.4 [INFO] [stderr] Checking smithay-clipboard v0.6.6 [INFO] [stderr] Checking accesskit_unix v0.5.2 [INFO] [stderr] Checking accesskit_winit v0.14.4 [INFO] [stderr] Checking egui-winit v0.22.0 [INFO] [stderr] Checking eframe v0.22.0 [INFO] [stderr] Checking snap_rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/app/hotkeys_utils.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/app/hotkeys_utils.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | registered_hotkey: registered_hotkey [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `registered_hotkey` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/app.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | rx: rx, [INFO] [stdout] | ^^^^^^ help: replace it with: `rx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/app.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | tx: tx, [INFO] [stdout] | ^^^^^^ help: replace it with: `tx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/app/hotkeys_utils.rs:21:13 [INFO] [stdout] | [INFO] [stdout] 21 | label: label, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `label` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/app/hotkeys_utils.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 26 | registered_hotkey: registered_hotkey [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `registered_hotkey` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/app.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | rx: rx, [INFO] [stdout] | ^^^^^^ help: replace it with: `rx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/app.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | tx: tx, [INFO] [stdout] | ^^^^^^ help: replace it with: `tx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/app/tool_utils.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 68 | return srgb; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return srgb; [INFO] [stdout] 68 + srgb [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/app/tool_utils.rs:60:23 [INFO] [stdout] | [INFO] [stdout] 60 | srgb[i] = 0 as u8; [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/app/tool_utils.rs:62:23 [INFO] [stdout] | [INFO] [stdout] 62 | srgb[i] = 255 as u8; [INFO] [stdout] | ^^^^^^^^^ help: try: `255_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/app/tool_utils.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | return Pos2::new(pos[0]*real_image_size[0] as f32/image_rect_size[0], pos[1]*real_image_size[1] as f32/image_rect_size[1]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return Pos2::new(pos[0]*real_image_size[0] as f32/image_rect_size[0], pos[1]*real_image_size[1] as f32/image_rect_size[1]); [INFO] [stdout] 72 + Pos2::new(pos[0]*real_image_size[0] as f32/image_rect_size[0], pos[1]*real_image_size[1] as f32/image_rect_size[1]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/app/tool_utils.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 68 | return srgb; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return srgb; [INFO] [stdout] 68 + srgb [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/app/tool_utils.rs:60:23 [INFO] [stdout] | [INFO] [stdout] 60 | srgb[i] = 0 as u8; [INFO] [stdout] | ^^^^^^^ help: try: `0_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `u8` is unnecessary [INFO] [stdout] --> src/app/tool_utils.rs:62:23 [INFO] [stdout] | [INFO] [stdout] 62 | srgb[i] = 255 as u8; [INFO] [stdout] | ^^^^^^^^^ help: try: `255_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/app/tool_utils.rs:72:5 [INFO] [stdout] | [INFO] [stdout] 72 | return Pos2::new(pos[0]*real_image_size[0] as f32/image_rect_size[0], pos[1]*real_image_size[1] as f32/image_rect_size[1]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 72 - return Pos2::new(pos[0]*real_image_size[0] as f32/image_rect_size[0], pos[1]*real_image_size[1] as f32/image_rect_size[1]); [INFO] [stdout] 72 + Pos2::new(pos[0]*real_image_size[0] as f32/image_rect_size[0], pos[1]*real_image_size[1] as f32/image_rect_size[1]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `HotKey` which implements the `Copy` trait [INFO] [stdout] --> src/app/hotkeys_utils.rs:32:34 [INFO] [stdout] | [INFO] [stdout] 32 | self.registered_hotkey = registered_hotkey.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `registered_hotkey` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/app.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | / let mut hotkeys_vec: Vec = Vec::new(); [INFO] [stdout] 60 | | hotkeys_vec.push(Hotkey::new("Copy".to_string(), "CTRL".to_string(), "C".to_string())); [INFO] [stdout] 61 | | hotkeys_vec.push(Hotkey::new("Save".to_string(), "CTRL".to_string(), "S".to_string())); [INFO] [stdout] 62 | | hotkeys_vec.push(Hotkey::new("Take".to_string(), "CTRL".to_string(), "T".to_string())); [INFO] [stdout] ... | [INFO] [stdout] 66 | | hotkeys_vec.push(Hotkey::new("Undo".to_string(), "CTRL".to_string(), "Z".to_string())); [INFO] [stdout] 67 | | hotkeys_vec.push(Hotkey::new("Redo".to_string(), "CTRL".to_string(), "Y".to_string())); [INFO] [stdout] | |_______________________________________________________________________________________________^ help: consider using the `vec![]` macro: `let hotkeys_vec: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/app.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | return app; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 - return app; [INFO] [stdout] 106 + app [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/app.rs:134:43 [INFO] [stdout] | [INFO] [stdout] 134 | if action_value =="Take".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"Take"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/app.rs:138:48 [INFO] [stdout] | [INFO] [stdout] 138 | else if action_value =="Save".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"Save"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/app.rs:143:48 [INFO] [stdout] | [INFO] [stdout] 143 | else if action_value =="Copy".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"Copy"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/app.rs:148:48 [INFO] [stdout] | [INFO] [stdout] 148 | else if action_value =="None".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"None"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/app.rs:153:48 [INFO] [stdout] | [INFO] [stdout] 153 | else if action_value =="Pen".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"Pen"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/app.rs:158:48 [INFO] [stdout] | [INFO] [stdout] 158 | else if action_value =="Crop".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"Crop"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/app.rs:163:48 [INFO] [stdout] | [INFO] [stdout] 163 | else if action_value =="Undo".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"Undo"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:168:30 [INFO] [stdout] | [INFO] [stdout] 168 | else if action_value =="Redo".to_string() { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 169 | | if self.snapshot.is_some(){ [INFO] [stdout] 170 | | self.redo(); [INFO] [stdout] 171 | | } [INFO] [stdout] 172 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 168 ~ else if action_value =="Redo".to_string() [INFO] [stdout] 169 ~ && self.snapshot.is_some(){ [INFO] [stdout] 170 | self.redo(); [INFO] [stdout] 171 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/app.rs:168:48 [INFO] [stdout] | [INFO] [stdout] 168 | else if action_value =="Redo".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"Redo"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/app.rs:186:23 [INFO] [stdout] | [INFO] [stdout] 186 | let display = self.display.unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.display.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64` which implements the `Copy` trait [INFO] [stdout] --> src/app.rs:187:25 [INFO] [stdout] | [INFO] [stdout] 187 | let mut timer = self.timer.unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.timer.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app.rs:233:21 [INFO] [stdout] | [INFO] [stdout] 233 | &snapshot.as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `snapshot.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/app.rs:234:21 [INFO] [stdout] | [INFO] [stdout] 234 | snapshot.width() as u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `snapshot.width()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/app.rs:235:21 [INFO] [stdout] | [INFO] [stdout] 235 | snapshot.height() as u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `snapshot.height()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `HotKey` which implements the `Copy` trait [INFO] [stdout] --> src/app/hotkeys_utils.rs:32:34 [INFO] [stdout] | [INFO] [stdout] 32 | self.registered_hotkey = registered_hotkey.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `registered_hotkey` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing last element with `self.snapshots_undo.get(self.snapshots_undo.len() - 1)` [INFO] [stdout] --> src/app.rs:260:34 [INFO] [stdout] | [INFO] [stdout] 260 | self.snapshot = Some(self.snapshots_undo.get(self.snapshots_undo.len()-1).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.snapshots_undo.back()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_last_with_len [INFO] [stdout] = note: `#[warn(clippy::get_last_with_len)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/app.rs:265:12 [INFO] [stdout] | [INFO] [stdout] 265 | if self.snapshots_redo.len()>0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.snapshots_redo.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing last element with `self.snapshots_undo.get(self.snapshots_undo.len() - 1)` [INFO] [stdout] --> src/app.rs:267:34 [INFO] [stdout] | [INFO] [stdout] 267 | self.snapshot = Some(self.snapshots_undo.get(self.snapshots_undo.len()-1).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.snapshots_undo.back()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_last_with_len [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app.rs:296:31 [INFO] [stdout] | [INFO] [stdout] 296 | draw_line(&mut self.snapshot.as_mut().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.snapshot.as_mut().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `[u8; 4]` [INFO] [stdout] --> src/app.rs:300:25 [INFO] [stdout] | [INFO] [stdout] 300 | color.into() [INFO] [stdout] | ^^^^^^^^^^^^ help: consider removing `.into()`: `color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/app.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | / let mut hotkeys_vec: Vec = Vec::new(); [INFO] [stdout] 60 | | hotkeys_vec.push(Hotkey::new("Copy".to_string(), "CTRL".to_string(), "C".to_string())); [INFO] [stdout] 61 | | hotkeys_vec.push(Hotkey::new("Save".to_string(), "CTRL".to_string(), "S".to_string())); [INFO] [stdout] 62 | | hotkeys_vec.push(Hotkey::new("Take".to_string(), "CTRL".to_string(), "T".to_string())); [INFO] [stdout] ... | [INFO] [stdout] 66 | | hotkeys_vec.push(Hotkey::new("Undo".to_string(), "CTRL".to_string(), "Z".to_string())); [INFO] [stdout] 67 | | hotkeys_vec.push(Hotkey::new("Redo".to_string(), "CTRL".to_string(), "Y".to_string())); [INFO] [stdout] | |_______________________________________________________________________________________________^ help: consider using the `vec![]` macro: `let hotkeys_vec: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/app.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | return app; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 106 - return app; [INFO] [stdout] 106 + app [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/app.rs:369:25 [INFO] [stdout] | [INFO] [stdout] 369 | top_left_rect.max.x = top_left_rect.max.x/2.; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `top_left_rect.max.x /= 2.` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/app.rs:134:43 [INFO] [stdout] | [INFO] [stdout] 134 | if action_value =="Take".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"Take"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/app.rs:138:48 [INFO] [stdout] | [INFO] [stdout] 138 | else if action_value =="Save".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"Save"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/app.rs:143:48 [INFO] [stdout] | [INFO] [stdout] 143 | else if action_value =="Copy".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"Copy"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/app.rs:148:48 [INFO] [stdout] | [INFO] [stdout] 148 | else if action_value =="None".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"None"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/app.rs:153:48 [INFO] [stdout] | [INFO] [stdout] 153 | else if action_value =="Pen".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `"Pen"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/app.rs:158:48 [INFO] [stdout] | [INFO] [stdout] 158 | else if action_value =="Crop".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"Crop"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/app.rs:163:48 [INFO] [stdout] | [INFO] [stdout] 163 | else if action_value =="Undo".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"Undo"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/app.rs:168:30 [INFO] [stdout] | [INFO] [stdout] 168 | else if action_value =="Redo".to_string() { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 169 | | if self.snapshot.is_some(){ [INFO] [stdout] 170 | | self.redo(); [INFO] [stdout] 171 | | } [INFO] [stdout] 172 | | } [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 168 ~ else if action_value =="Redo".to_string() [INFO] [stdout] 169 ~ && self.snapshot.is_some(){ [INFO] [stdout] 170 | self.redo(); [INFO] [stdout] 171 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/app.rs:168:48 [INFO] [stdout] | [INFO] [stdout] 168 | else if action_value =="Redo".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"Redo"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `usize` which implements the `Copy` trait [INFO] [stdout] --> src/app.rs:186:23 [INFO] [stdout] | [INFO] [stdout] 186 | let display = self.display.unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.display.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f64` which implements the `Copy` trait [INFO] [stdout] --> src/app.rs:187:25 [INFO] [stdout] | [INFO] [stdout] 187 | let mut timer = self.timer.unwrap().clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.timer.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app.rs:233:21 [INFO] [stdout] | [INFO] [stdout] 233 | &snapshot.as_bytes(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `snapshot.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/app.rs:234:21 [INFO] [stdout] | [INFO] [stdout] 234 | snapshot.width() as u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `snapshot.width()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/app.rs:235:21 [INFO] [stdout] | [INFO] [stdout] 235 | snapshot.height() as u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `snapshot.height()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/app.rs:472:17 [INFO] [stdout] | [INFO] [stdout] 472 | side_rect.max.x = side_rect.max.x - 12.; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `side_rect.max.x -= 12.` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing last element with `self.snapshots_undo.get(self.snapshots_undo.len() - 1)` [INFO] [stdout] --> src/app.rs:260:34 [INFO] [stdout] | [INFO] [stdout] 260 | self.snapshot = Some(self.snapshots_undo.get(self.snapshots_undo.len()-1).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.snapshots_undo.back()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_last_with_len [INFO] [stdout] = note: `#[warn(clippy::get_last_with_len)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/app.rs:265:12 [INFO] [stdout] | [INFO] [stdout] 265 | if self.snapshots_redo.len()>0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.snapshots_redo.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing last element with `self.snapshots_undo.get(self.snapshots_undo.len() - 1)` [INFO] [stdout] --> src/app.rs:267:34 [INFO] [stdout] | [INFO] [stdout] 267 | self.snapshot = Some(self.snapshots_undo.get(self.snapshots_undo.len()-1).unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.snapshots_undo.back()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_last_with_len [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/app.rs:525:29 [INFO] [stdout] | [INFO] [stdout] 525 | / ... if self.pen_size<1{ [INFO] [stdout] 526 | | ... self.pen_size = 1; [INFO] [stdout] 527 | | ... } [INFO] [stdout] 528 | | ... if self.pen_size>30{ [INFO] [stdout] 529 | | ... self.pen_size = 30; [INFO] [stdout] 530 | | ... } [INFO] [stdout] | |_______________________^ help: replace with clamp: `self.pen_size = self.pen_size.clamp(1, 30);` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/app.rs:296:31 [INFO] [stdout] | [INFO] [stdout] 296 | draw_line(&mut self.snapshot.as_mut().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.snapshot.as_mut().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `[u8; 4]` [INFO] [stdout] --> src/app.rs:300:25 [INFO] [stdout] | [INFO] [stdout] 300 | color.into() [INFO] [stdout] | ^^^^^^^^^^^^ help: consider removing `.into()`: `color` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/app.rs:369:25 [INFO] [stdout] | [INFO] [stdout] 369 | top_left_rect.max.x = top_left_rect.max.x/2.; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `top_left_rect.max.x /= 2.` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app.rs:637:36 [INFO] [stdout] | [INFO] [stdout] 637 | ... if !key.is_none(){ [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `key.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/app.rs:613:44 [INFO] [stdout] | [INFO] [stdout] 613 | ... .selected_text(format!("{:}", hotkey.tmp_modifier)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `hotkey.tmp_modifier.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/app.rs:626:32 [INFO] [stdout] | [INFO] [stdout] 626 | ... if hotkey.tmp_code.len() == 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `hotkey.tmp_code.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/app.rs:698:20 [INFO] [stdout] | [INFO] [stdout] 698 | if self.valid_hotkeys==false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.valid_hotkeys` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/app.rs:472:17 [INFO] [stdout] | [INFO] [stdout] 472 | side_rect.max.x = side_rect.max.x - 12.; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `side_rect.max.x -= 12.` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/app.rs:753:9 [INFO] [stdout] | [INFO] [stdout] 753 | / match self.rx.try_recv() { [INFO] [stdout] 754 | | Ok(snapshot) => { [INFO] [stdout] 755 | | self.snapshots_undo.clear(); [INFO] [stdout] 756 | | self.snapshots_redo.clear(); [INFO] [stdout] ... | [INFO] [stdout] 763 | | Err(_) => {} [INFO] [stdout] 764 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 753 ~ if let Ok(snapshot) = self.rx.try_recv() { [INFO] [stdout] 754 + self.snapshots_undo.clear(); [INFO] [stdout] 755 + self.snapshots_redo.clear(); [INFO] [stdout] 756 + [INFO] [stdout] 757 + self.snapshot = Some(snapshot.clone()); [INFO] [stdout] 758 + self.snapshots_undo.push_back(snapshot); [INFO] [stdout] 759 + [INFO] [stdout] 760 + frame.set_visible(true); [INFO] [stdout] 761 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/app.rs:525:29 [INFO] [stdout] | [INFO] [stdout] 525 | / ... if self.pen_size<1{ [INFO] [stdout] 526 | | ... self.pen_size = 1; [INFO] [stdout] 527 | | ... } [INFO] [stdout] 528 | | ... if self.pen_size>30{ [INFO] [stdout] 529 | | ... self.pen_size = 30; [INFO] [stdout] 530 | | ... } [INFO] [stdout] | |_______________________^ help: replace with clamp: `self.pen_size = self.pen_size.clamp(1, 30);` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | native_options.min_window_size = Some(eframe::egui::Vec2::new(750., 500.)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `eframe::NativeOptions { min_window_size: Some(eframe::egui::Vec2::new(750., 500.)), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/main.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | let mut native_options = eframe::NativeOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/app.rs:637:36 [INFO] [stdout] | [INFO] [stdout] 637 | ... if !key.is_none(){ [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `key.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/app.rs:613:44 [INFO] [stdout] | [INFO] [stdout] 613 | ... .selected_text(format!("{:}", hotkey.tmp_modifier)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `hotkey.tmp_modifier.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/app.rs:626:32 [INFO] [stdout] | [INFO] [stdout] 626 | ... if hotkey.tmp_code.len() == 0{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `hotkey.tmp_code.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/app.rs:698:20 [INFO] [stdout] | [INFO] [stdout] 698 | if self.valid_hotkeys==false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!self.valid_hotkeys` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/app.rs:753:9 [INFO] [stdout] | [INFO] [stdout] 753 | / match self.rx.try_recv() { [INFO] [stdout] 754 | | Ok(snapshot) => { [INFO] [stdout] 755 | | self.snapshots_undo.clear(); [INFO] [stdout] 756 | | self.snapshots_redo.clear(); [INFO] [stdout] ... | [INFO] [stdout] 763 | | Err(_) => {} [INFO] [stdout] 764 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 753 ~ if let Ok(snapshot) = self.rx.try_recv() { [INFO] [stdout] 754 + self.snapshots_undo.clear(); [INFO] [stdout] 755 + self.snapshots_redo.clear(); [INFO] [stdout] 756 + [INFO] [stdout] 757 + self.snapshot = Some(snapshot.clone()); [INFO] [stdout] 758 + self.snapshots_undo.push_back(snapshot); [INFO] [stdout] 759 + [INFO] [stdout] 760 + frame.set_visible(true); [INFO] [stdout] 761 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/main.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | native_options.min_window_size = Some(eframe::egui::Vec2::new(750., 500.)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `eframe::NativeOptions { min_window_size: Some(eframe::egui::Vec2::new(750., 500.)), ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/main.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | let mut native_options = eframe::NativeOptions::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 37s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: screenshots v0.8.6 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "a9ac2235536fe91f68717ac9723cdadf742b3c734e6756b9ad2ec9d56469f126", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a9ac2235536fe91f68717ac9723cdadf742b3c734e6756b9ad2ec9d56469f126", kill_on_drop: false }` [INFO] [stdout] a9ac2235536fe91f68717ac9723cdadf742b3c734e6756b9ad2ec9d56469f126