[INFO] cloning repository https://github.com/ShawnL427/SanFran-Roads
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ShawnL427/SanFran-Roads" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FShawnL427%2FSanFran-Roads", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FShawnL427%2FSanFran-Roads'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 537b8a62dbc6c2bb69aa485e5df2124ed91cdef2
[INFO] linting ShawnL427/SanFran-Roads against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FShawnL427%2FSanFran-Roads" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/ShawnL427/SanFran-Roads
[INFO] finished tweaking git repo https://github.com/ShawnL427/SanFran-Roads
[INFO] tweaked toml for git repo https://github.com/ShawnL427/SanFran-Roads written to /workspace/builds/worker-7-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/ShawnL427/SanFran-Roads on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/ShawnL427/SanFran-Roads already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded csv v1.3.0
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 591deb3dbff17f6892afa493ccc72044dd0d9b58e8a00ccdf688d1031ebf003f
[INFO] running `Command { std: "docker" "start" "-a" "591deb3dbff17f6892afa493ccc72044dd0d9b58e8a00ccdf688d1031ebf003f", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "591deb3dbff17f6892afa493ccc72044dd0d9b58e8a00ccdf688d1031ebf003f", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "591deb3dbff17f6892afa493ccc72044dd0d9b58e8a00ccdf688d1031ebf003f", kill_on_drop: false }`
[INFO] [stdout] 591deb3dbff17f6892afa493ccc72044dd0d9b58e8a00ccdf688d1031ebf003f
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 6cf72fe7928c3ce5d45a24348ff8e5c9808c965efb0ce9b8bd93ea93aaab47cd
[INFO] running `Command { std: "docker" "start" "-a" "6cf72fe7928c3ce5d45a24348ff8e5c9808c965efb0ce9b8bd93ea93aaab47cd", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.153
[INFO] [stderr]    Compiling serde v1.0.200
[INFO] [stderr]     Checking memchr v2.7.2
[INFO] [stderr]     Checking csv-core v0.1.11
[INFO] [stderr]     Checking getrandom v0.2.14
[INFO] [stderr]     Checking rand_core v0.6.4
[INFO] [stderr]     Checking rand_chacha v0.3.1
[INFO] [stderr]     Checking rand v0.8.5
[INFO] [stderr]     Checking csv v1.3.0
[INFO] [stderr]     Checking average_distances v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/helper/mod.rs:20:5
[INFO] [stdout]    |
[INFO] [stdout] 20 |     return result;
[INFO] [stdout]    |     ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 20 -     return result;
[INFO] [stdout] 20 +     result
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/helper/mod.rs:32:5
[INFO] [stdout]    |
[INFO] [stdout] 32 |     return adjacency_list;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 32 -     return adjacency_list;
[INFO] [stdout] 32 +     adjacency_list
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/helper/mod.rs:41:5
[INFO] [stdout]    |
[INFO] [stdout] 41 |     return weighted_adjacency_list;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 41 -     return weighted_adjacency_list;
[INFO] [stdout] 41 +     weighted_adjacency_list
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/helper/mod.rs:61:5
[INFO] [stdout]    |
[INFO] [stdout] 61 |     return result;
[INFO] [stdout]    |     ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 61 -     return result;
[INFO] [stdout] 61 +     result
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/helper/mod.rs:82:5
[INFO] [stdout]    |
[INFO] [stdout] 82 |     return node_pos;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 82 -     return node_pos;
[INFO] [stdout] 82 +     node_pos
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:38:5
[INFO] [stdout]    |
[INFO] [stdout] 38 |     return distances;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 38 -     return distances;
[INFO] [stdout] 38 +     distances
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:10:72
[INFO] [stdout]    |
[INFO] [stdout] 10 | fn breadth_first_search(node: usize, node_count:usize, adjacency_list: &Vec<Vec<usize>>) ->  Vec<i32> {
[INFO] [stdout]    |                                                                        ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 10 - fn breadth_first_search(node: usize, node_count:usize, adjacency_list: &Vec<Vec<usize>>) ->  Vec<i32> {
[INFO] [stdout] 10 + fn breadth_first_search(node: usize, node_count:usize, adjacency_list: &[Vec<usize>]) ->  Vec<i32> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:116:11
[INFO] [stdout]     |
[INFO] [stdout] 116 |     while !pqueue.peek().is_none() {
[INFO] [stdout]     |           ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pqueue.peek().is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:126:5
[INFO] [stdout]     |
[INFO] [stdout] 126 |     return dist;
[INFO] [stdout]     |     ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 126 -     return dist;
[INFO] [stdout] 126 +     dist
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:42:70
[INFO] [stdout]    |
[INFO] [stdout] 42 | fn dijkstras(node: usize, node_count:usize, weighted_adjacency_list: &Vec<Vec<(usize, f64)>>) -> Vec<f64>{
[INFO] [stdout]    |                                                                      ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 42 - fn dijkstras(node: usize, node_count:usize, weighted_adjacency_list: &Vec<Vec<(usize, f64)>>) -> Vec<f64>{
[INFO] [stdout] 42 + fn dijkstras(node: usize, node_count:usize, weighted_adjacency_list: &[Vec<(usize, f64)>]) -> Vec<f64>{
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type
[INFO] [stdout]    --> src/main.rs:98:5
[INFO] [stdout]     |
[INFO] [stdout]  98 | /     impl PartialOrd for Rev {
[INFO] [stdout]  99 | |         fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
[INFO] [stdout] 100 | |             other.0.partial_cmp(&self.0)
[INFO] [stdout] 101 | |         }
[INFO] [stdout] 102 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl
[INFO] [stdout]     = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout]  99 -         fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
[INFO] [stdout] 100 -             other.0.partial_cmp(&self.0)
[INFO] [stdout] 101 -         }
[INFO] [stdout]  99 +         fn partial_cmp(&self, other: &Self) -> Option<Ordering> { Some(self.cmp(other)) }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:140:5
[INFO] [stdout]     |
[INFO] [stdout] 140 |     return average;
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 140 -     return average;
[INFO] [stdout] 140 +     average
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/main.rs:129:46
[INFO] [stdout]     |
[INFO] [stdout] 129 | fn average_distances(node: usize, distances: &Vec<i32>) -> f64 { //given a node and list of distances from node, compute average di...
[INFO] [stdout]     |                                              ^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 129 - fn average_distances(node: usize, distances: &Vec<i32>) -> f64 { //given a node and list of distances from node, compute average distance
[INFO] [stdout] 129 + fn average_distances(node: usize, distances: &[i32]) -> f64 { //given a node and list of distances from node, compute average distance
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is used to index `distances`
[INFO] [stdout]    --> src/main.rs:132:14
[INFO] [stdout]     |
[INFO] [stdout] 132 |     for i in 0..distances.len() {
[INFO] [stdout]     |              ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]     = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]     |
[INFO] [stdout] 132 -     for i in 0..distances.len() {
[INFO] [stdout] 132 +     for (i, <item>) in distances.iter().enumerate() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:154:5
[INFO] [stdout]     |
[INFO] [stdout] 154 |     return average;
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 154 -     return average;
[INFO] [stdout] 154 +     average
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/main.rs:143:55
[INFO] [stdout]     |
[INFO] [stdout] 143 | fn average_weighted_distances(node: usize, distances: &Vec<f64>) -> f64 { //given node and list of distances, compute average assum...
[INFO] [stdout]     |                                                       ^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 143 - fn average_weighted_distances(node: usize, distances: &Vec<f64>) -> f64 { //given node and list of distances, compute average assuming all points visited
[INFO] [stdout] 143 + fn average_weighted_distances(node: usize, distances: &[f64]) -> f64 { //given node and list of distances, compute average assuming all points visited
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is used to index `distances`
[INFO] [stdout]    --> src/main.rs:146:14
[INFO] [stdout]     |
[INFO] [stdout] 146 |     for i in 0..distances.len() {
[INFO] [stdout]     |              ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]     |
[INFO] [stdout] 146 -     for i in 0..distances.len() {
[INFO] [stdout] 146 +     for (i, <item>) in distances.iter().enumerate() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout]    --> src/main.rs:152:24
[INFO] [stdout]     |
[INFO] [stdout] 152 |     let average: f64 = sum as f64 / visited_count;
[INFO] [stdout]     |                        ^^^^^^^^^^ help: try: `sum`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/main.rs:164:39
[INFO] [stdout]     |
[INFO] [stdout] 164 |     let edges = helper::extract_edges(format!("sf_edges.txt"));
[INFO] [stdout]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"sf_edges.txt".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout]     = note: `#[warn(clippy::useless_format)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/main.rs:174:31
[INFO] [stdout]     |
[INFO] [stdout] 174 |     let _ = file.write_record(&["node_x", "node_y", "average_distance"]);
[INFO] [stdout]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["node_x", "node_y", "average_distance"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/main.rs:199:48
[INFO] [stdout]     |
[INFO] [stdout] 199 |     let edges = helper::extract_weighted_edges(format!("sf_edges.txt"));
[INFO] [stdout]     |                                                ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"sf_edges.txt".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/main.rs:209:31
[INFO] [stdout]     |
[INFO] [stdout] 209 |     let _ = file.write_record(&["node_x", "node_y", "average_distance"]);
[INFO] [stdout]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["node_x", "node_y", "average_distance"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/helper/mod.rs:20:5
[INFO] [stdout]    |
[INFO] [stdout] 20 |     return result;
[INFO] [stdout]    |     ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 20 -     return result;
[INFO] [stdout] 20 +     result
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/helper/mod.rs:32:5
[INFO] [stdout]    |
[INFO] [stdout] 32 |     return adjacency_list;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 32 -     return adjacency_list;
[INFO] [stdout] 32 +     adjacency_list
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/helper/mod.rs:41:5
[INFO] [stdout]    |
[INFO] [stdout] 41 |     return weighted_adjacency_list;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 41 -     return weighted_adjacency_list;
[INFO] [stdout] 41 +     weighted_adjacency_list
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/helper/mod.rs:61:5
[INFO] [stdout]    |
[INFO] [stdout] 61 |     return result;
[INFO] [stdout]    |     ^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 61 -     return result;
[INFO] [stdout] 61 +     result
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/helper/mod.rs:82:5
[INFO] [stdout]    |
[INFO] [stdout] 82 |     return node_pos;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 82 -     return node_pos;
[INFO] [stdout] 82 +     node_pos
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/main.rs:38:5
[INFO] [stdout]    |
[INFO] [stdout] 38 |     return distances;
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 38 -     return distances;
[INFO] [stdout] 38 +     distances
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:10:72
[INFO] [stdout]    |
[INFO] [stdout] 10 | fn breadth_first_search(node: usize, node_count:usize, adjacency_list: &Vec<Vec<usize>>) ->  Vec<i32> {
[INFO] [stdout]    |                                                                        ^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout]    = note: `#[warn(clippy::ptr_arg)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 10 - fn breadth_first_search(node: usize, node_count:usize, adjacency_list: &Vec<Vec<usize>>) ->  Vec<i32> {
[INFO] [stdout] 10 + fn breadth_first_search(node: usize, node_count:usize, adjacency_list: &[Vec<usize>]) ->  Vec<i32> {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:116:11
[INFO] [stdout]     |
[INFO] [stdout] 116 |     while !pqueue.peek().is_none() {
[INFO] [stdout]     |           ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `pqueue.peek().is_some()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:126:5
[INFO] [stdout]     |
[INFO] [stdout] 126 |     return dist;
[INFO] [stdout]     |     ^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 126 -     return dist;
[INFO] [stdout] 126 +     dist
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]   --> src/main.rs:42:70
[INFO] [stdout]    |
[INFO] [stdout] 42 | fn dijkstras(node: usize, node_count:usize, weighted_adjacency_list: &Vec<Vec<(usize, f64)>>) -> Vec<f64>{
[INFO] [stdout]    |                                                                      ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]    |
[INFO] [stdout] 42 - fn dijkstras(node: usize, node_count:usize, weighted_adjacency_list: &Vec<Vec<(usize, f64)>>) -> Vec<f64>{
[INFO] [stdout] 42 + fn dijkstras(node: usize, node_count:usize, weighted_adjacency_list: &[Vec<(usize, f64)>]) -> Vec<f64>{
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type
[INFO] [stdout]    --> src/main.rs:98:5
[INFO] [stdout]     |
[INFO] [stdout]  98 | /     impl PartialOrd for Rev {
[INFO] [stdout]  99 | |         fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
[INFO] [stdout] 100 | |             other.0.partial_cmp(&self.0)
[INFO] [stdout] 101 | |         }
[INFO] [stdout] 102 | |     }
[INFO] [stdout]     | |_____^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl
[INFO] [stdout]     = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout]  99 -         fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
[INFO] [stdout] 100 -             other.0.partial_cmp(&self.0)
[INFO] [stdout] 101 -         }
[INFO] [stdout]  99 +         fn partial_cmp(&self, other: &Self) -> Option<Ordering> { Some(self.cmp(other)) }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:140:5
[INFO] [stdout]     |
[INFO] [stdout] 140 |     return average;
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 140 -     return average;
[INFO] [stdout] 140 +     average
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/main.rs:129:46
[INFO] [stdout]     |
[INFO] [stdout] 129 | fn average_distances(node: usize, distances: &Vec<i32>) -> f64 { //given a node and list of distances from node, compute average di...
[INFO] [stdout]     |                                              ^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 129 - fn average_distances(node: usize, distances: &Vec<i32>) -> f64 { //given a node and list of distances from node, compute average distance
[INFO] [stdout] 129 + fn average_distances(node: usize, distances: &[i32]) -> f64 { //given a node and list of distances from node, compute average distance
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is used to index `distances`
[INFO] [stdout]    --> src/main.rs:132:14
[INFO] [stdout]     |
[INFO] [stdout] 132 |     for i in 0..distances.len() {
[INFO] [stdout]     |              ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout]     = note: `#[warn(clippy::needless_range_loop)]` on by default
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]     |
[INFO] [stdout] 132 -     for i in 0..distances.len() {
[INFO] [stdout] 132 +     for (i, <item>) in distances.iter().enumerate() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]    --> src/main.rs:154:5
[INFO] [stdout]     |
[INFO] [stdout] 154 |     return average;
[INFO] [stdout]     |     ^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]     |
[INFO] [stdout] 154 -     return average;
[INFO] [stdout] 154 +     average
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do
[INFO] [stdout]    --> src/main.rs:143:55
[INFO] [stdout]     |
[INFO] [stdout] 143 | fn average_weighted_distances(node: usize, distances: &Vec<f64>) -> f64 { //given node and list of distances, compute average assum...
[INFO] [stdout]     |                                                       ^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stdout] help: change this to
[INFO] [stdout]     |
[INFO] [stdout] 143 - fn average_weighted_distances(node: usize, distances: &Vec<f64>) -> f64 { //given node and list of distances, compute average assuming all points visited
[INFO] [stdout] 143 + fn average_weighted_distances(node: usize, distances: &[f64]) -> f64 { //given node and list of distances, compute average assuming all points visited
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the loop variable `i` is used to index `distances`
[INFO] [stdout]    --> src/main.rs:146:14
[INFO] [stdout]     |
[INFO] [stdout] 146 |     for i in 0..distances.len() {
[INFO] [stdout]     |              ^^^^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stdout] help: consider using an iterator and enumerate()
[INFO] [stdout]     |
[INFO] [stdout] 146 -     for i in 0..distances.len() {
[INFO] [stdout] 146 +     for (i, <item>) in distances.iter().enumerate() {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: casting to the same type is unnecessary (`f64` -> `f64`)
[INFO] [stdout]    --> src/main.rs:152:24
[INFO] [stdout]     |
[INFO] [stdout] 152 |     let average: f64 = sum as f64 / visited_count;
[INFO] [stdout]     |                        ^^^^^^^^^^ help: try: `sum`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_cast)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/main.rs:164:39
[INFO] [stdout]     |
[INFO] [stdout] 164 |     let edges = helper::extract_edges(format!("sf_edges.txt"));
[INFO] [stdout]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"sf_edges.txt".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout]     = note: `#[warn(clippy::useless_format)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/main.rs:174:31
[INFO] [stdout]     |
[INFO] [stdout] 174 |     let _ = file.write_record(&["node_x", "node_y", "average_distance"]);
[INFO] [stdout]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["node_x", "node_y", "average_distance"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless use of `format!`
[INFO] [stdout]    --> src/main.rs:199:48
[INFO] [stdout]     |
[INFO] [stdout] 199 |     let edges = helper::extract_weighted_edges(format!("sf_edges.txt"));
[INFO] [stdout]     |                                                ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"sf_edges.txt".to_string()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]    --> src/main.rs:209:31
[INFO] [stdout]     |
[INFO] [stdout] 209 |     let _ = file.write_record(&["node_x", "node_y", "average_distance"]);
[INFO] [stdout]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["node_x", "node_y", "average_distance"]`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.61s
[INFO] running `Command { std: "docker" "inspect" "6cf72fe7928c3ce5d45a24348ff8e5c9808c965efb0ce9b8bd93ea93aaab47cd", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "6cf72fe7928c3ce5d45a24348ff8e5c9808c965efb0ce9b8bd93ea93aaab47cd", kill_on_drop: false }`
[INFO] [stdout] 6cf72fe7928c3ce5d45a24348ff8e5c9808c965efb0ce9b8bd93ea93aaab47cd