[INFO] cloning repository https://github.com/Seven0492/calculator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Seven0492/calculator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSeven0492%2Fcalculator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSeven0492%2Fcalculator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 128b40a1c24d7440b3a90b33d92b1d4507cfecec [INFO] linting Seven0492/calculator against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSeven0492%2Fcalculator" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Seven0492/calculator [INFO] finished tweaking git repo https://github.com/Seven0492/calculator [INFO] tweaked toml for git repo https://github.com/Seven0492/calculator written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Seven0492/calculator on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Seven0492/calculator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded path-dedot v3.0.18 [INFO] [stderr] Downloaded path-absolutize v3.0.13 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b2f717fc77009e3a7c38e5104f247f6457d33ee195ee515742301fbf32f6c2af [INFO] running `Command { std: "docker" "start" "-a" "b2f717fc77009e3a7c38e5104f247f6457d33ee195ee515742301fbf32f6c2af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b2f717fc77009e3a7c38e5104f247f6457d33ee195ee515742301fbf32f6c2af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b2f717fc77009e3a7c38e5104f247f6457d33ee195ee515742301fbf32f6c2af", kill_on_drop: false }` [INFO] [stdout] b2f717fc77009e3a7c38e5104f247f6457d33ee195ee515742301fbf32f6c2af [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f13307bdf1297d47ae3a27c1bca7075fbad5d6a799c8095a04904a7888dbf91b [INFO] running `Command { std: "docker" "start" "-a" "f13307bdf1297d47ae3a27c1bca7075fbad5d6a799c8095a04904a7888dbf91b", kill_on_drop: false }` [INFO] [stderr] Checking once_cell v1.15.0 [INFO] [stderr] Checking path-dedot v3.0.18 [INFO] [stderr] Checking path-absolutize v3.0.13 [INFO] [stderr] Checking calculator v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: file is loaded as a module multiple times: `src/doc/mod.rs` [INFO] [stdout] --> src/main.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | mod doc; [INFO] [stdout] | ^^^^^^^^ first loaded here [INFO] [stdout] | [INFO] [stdout] ::: src/iterate/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod doc; [INFO] [stdout] | ^^^^^^^^ loaded again here [INFO] [stdout] | [INFO] [stdout] ::: src/iterate/module/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod doc; [INFO] [stdout] | ^^^^^^^^ loaded again here [INFO] [stdout] | [INFO] [stdout] = help: replace all but one `mod` item with `use` items [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_mod [INFO] [stdout] = note: `#[warn(clippy::duplicate_mod)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `help` is never used [INFO] [stdout] --> src/iterate/module/doc.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn help() { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/doc/mod.rs:24:22 [INFO] [stdout] | [INFO] [stdout] 24 | } else if n == 2 { [INFO] [stdout] | ______________________^ [INFO] [stdout] 25 | | eprintln!( [INFO] [stdout] 26 | | "Wrong formatting! Please execute the program without any arguments for documentation" [INFO] [stdout] 27 | | ); [INFO] [stdout] 28 | | } else if n == 3 { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/doc/mod.rs:28:22 [INFO] [stdout] | [INFO] [stdout] 28 | } else if n == 3 { [INFO] [stdout] | ______________________^ [INFO] [stdout] 29 | | eprintln!( [INFO] [stdout] 30 | | "Wrong formatting! Please execute the program without any arguments for documentation" [INFO] [stdout] 31 | | ); [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/iterate/doc.rs:24:22 [INFO] [stdout] | [INFO] [stdout] 24 | } else if n == 2 { [INFO] [stdout] | ______________________^ [INFO] [stdout] 25 | | eprintln!( [INFO] [stdout] 26 | | "Wrong formatting! Please execute the program without any arguments for documentation" [INFO] [stdout] 27 | | ); [INFO] [stdout] 28 | | } else if n == 3 { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/iterate/doc.rs:28:22 [INFO] [stdout] | [INFO] [stdout] 28 | } else if n == 3 { [INFO] [stdout] | ______________________^ [INFO] [stdout] 29 | | eprintln!( [INFO] [stdout] 30 | | "Wrong formatting! Please execute the program without any arguments for documentation" [INFO] [stdout] 31 | | ); [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/iterate/module/doc.rs:24:22 [INFO] [stdout] | [INFO] [stdout] 24 | } else if n == 2 { [INFO] [stdout] | ______________________^ [INFO] [stdout] 25 | | eprintln!( [INFO] [stdout] 26 | | "Wrong formatting! Please execute the program without any arguments for documentation" [INFO] [stdout] 27 | | ); [INFO] [stdout] 28 | | } else if n == 3 { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/iterate/module/doc.rs:28:22 [INFO] [stdout] | [INFO] [stdout] 28 | } else if n == 3 { [INFO] [stdout] | ______________________^ [INFO] [stdout] 29 | | eprintln!( [INFO] [stdout] 30 | | "Wrong formatting! Please execute the program without any arguments for documentation" [INFO] [stdout] 31 | | ); [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/iterate/module/mod.rs:28:26 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn make_numset(args: &Vec, i: &usize) -> NumSet { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 28 - pub fn make_numset(args: &Vec, i: &usize) -> NumSet { [INFO] [stdout] 28 + pub fn make_numset(args: &[String], i: &usize) -> NumSet { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/iterate/module/mod.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 30 | / let numbers = NumSet { [INFO] [stdout] 31 | | num1: args[i + 0].clone(), [INFO] [stdout] 32 | | symbol: String::new(), [INFO] [stdout] 33 | | num2: args[i + 1].clone(), [INFO] [stdout] 34 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 35 | numbers [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 30 ~ [INFO] [stdout] 31 ~ NumSet { [INFO] [stdout] 32 + num1: args[i + 0].clone(), [INFO] [stdout] 33 + symbol: String::new(), [INFO] [stdout] 34 + num2: args[i + 1].clone(), [INFO] [stdout] 35 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/iterate/module/mod.rs:31:24 [INFO] [stdout] | [INFO] [stdout] 31 | num1: args[i + 0].clone(), [INFO] [stdout] | ^^^^^ help: consider reducing it to: `*i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/iterate/module/mod.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 37 | / let numbers = NumSet { [INFO] [stdout] 38 | | num1: args[i + 0].clone(), [INFO] [stdout] 39 | | symbol: args[i + 1].clone(), [INFO] [stdout] 40 | | num2: args[i + 2].clone(), [INFO] [stdout] 41 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 42 | numbers [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 37 ~ [INFO] [stdout] 38 ~ NumSet { [INFO] [stdout] 39 + num1: args[i + 0].clone(), [INFO] [stdout] 40 + symbol: args[i + 1].clone(), [INFO] [stdout] 41 + num2: args[i + 2].clone(), [INFO] [stdout] 42 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/iterate/module/mod.rs:38:24 [INFO] [stdout] | [INFO] [stdout] 38 | num1: args[i + 0].clone(), [INFO] [stdout] | ^^^^^ help: consider reducing it to: `*i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/iterate/module/mod.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 58 - print!("\n"); [INFO] [stdout] 58 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/iterate/module/mod.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 66 - print!("\n"); [INFO] [stdout] 66 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/iterate/module/mod.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 74 - print!("\n"); [INFO] [stdout] 74 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/iterate/module/mod.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 82 - print!("\n"); [INFO] [stdout] 82 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/iterate/module/mod.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 90 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 90 - print!("\n"); [INFO] [stdout] 90 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/iterate/mod.rs:86:20 [INFO] [stdout] | [INFO] [stdout] 86 | if set.num1 == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `set.num1.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/iterate/mod.rs:101:27 [INFO] [stdout] | [INFO] [stdout] 101 | } else if set.num2 == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `set.num2.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/iterate/mod.rs:167:16 [INFO] [stdout] | [INFO] [stdout] 167 | if set.num1 != "" && set.num2 != "" && set.symbol != "" && search_for_symbol == 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!set.num1.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/iterate/mod.rs:167:34 [INFO] [stdout] | [INFO] [stdout] 167 | if set.num1 != "" && set.num2 != "" && set.symbol != "" && search_for_symbol == 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!set.num2.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/iterate/mod.rs:167:52 [INFO] [stdout] | [INFO] [stdout] 167 | if set.num1 != "" && set.num2 != "" && set.symbol != "" && search_for_symbol == 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!set.symbol.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/iterate/mod.rs:186:23 [INFO] [stdout] | [INFO] [stdout] 186 | } else if set.num2 == "" && set.symbol == "" && set.num1 != "" && search_for_symbol == 1 [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `set.num2.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/iterate/mod.rs:186:41 [INFO] [stdout] | [INFO] [stdout] 186 | } else if set.num2 == "" && set.symbol == "" && set.num1 != "" && search_for_symbol == 1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `set.symbol.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/iterate/mod.rs:186:61 [INFO] [stdout] | [INFO] [stdout] 186 | } else if set.num2 == "" && set.symbol == "" && set.num1 != "" && search_for_symbol == 1 [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!set.num1.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 39 | || !args[0].parse::().is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args[0].parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/main.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | drop(dir1); [INFO] [stdout] | ^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&std::path::Path` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 24 - drop(dir1); [INFO] [stdout] 24 + let _ = dir1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: file is loaded as a module multiple times: `src/doc/mod.rs` [INFO] [stdout] --> src/main.rs:6:1 [INFO] [stdout] | [INFO] [stdout] 6 | mod doc; [INFO] [stdout] | ^^^^^^^^ first loaded here [INFO] [stdout] | [INFO] [stdout] ::: src/iterate/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod doc; [INFO] [stdout] | ^^^^^^^^ loaded again here [INFO] [stdout] | [INFO] [stdout] ::: src/iterate/module/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | mod doc; [INFO] [stdout] | ^^^^^^^^ loaded again here [INFO] [stdout] | [INFO] [stdout] = help: replace all but one `mod` item with `use` items [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicate_mod [INFO] [stdout] = note: `#[warn(clippy::duplicate_mod)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `help` is never used [INFO] [stdout] --> src/iterate/module/doc.rs:1:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn help() { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/doc/mod.rs:24:22 [INFO] [stdout] | [INFO] [stdout] 24 | } else if n == 2 { [INFO] [stdout] | ______________________^ [INFO] [stdout] 25 | | eprintln!( [INFO] [stdout] 26 | | "Wrong formatting! Please execute the program without any arguments for documentation" [INFO] [stdout] 27 | | ); [INFO] [stdout] 28 | | } else if n == 3 { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/doc/mod.rs:28:22 [INFO] [stdout] | [INFO] [stdout] 28 | } else if n == 3 { [INFO] [stdout] | ______________________^ [INFO] [stdout] 29 | | eprintln!( [INFO] [stdout] 30 | | "Wrong formatting! Please execute the program without any arguments for documentation" [INFO] [stdout] 31 | | ); [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/iterate/doc.rs:24:22 [INFO] [stdout] | [INFO] [stdout] 24 | } else if n == 2 { [INFO] [stdout] | ______________________^ [INFO] [stdout] 25 | | eprintln!( [INFO] [stdout] 26 | | "Wrong formatting! Please execute the program without any arguments for documentation" [INFO] [stdout] 27 | | ); [INFO] [stdout] 28 | | } else if n == 3 { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/iterate/doc.rs:28:22 [INFO] [stdout] | [INFO] [stdout] 28 | } else if n == 3 { [INFO] [stdout] | ______________________^ [INFO] [stdout] 29 | | eprintln!( [INFO] [stdout] 30 | | "Wrong formatting! Please execute the program without any arguments for documentation" [INFO] [stdout] 31 | | ); [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/iterate/module/doc.rs:24:22 [INFO] [stdout] | [INFO] [stdout] 24 | } else if n == 2 { [INFO] [stdout] | ______________________^ [INFO] [stdout] 25 | | eprintln!( [INFO] [stdout] 26 | | "Wrong formatting! Please execute the program without any arguments for documentation" [INFO] [stdout] 27 | | ); [INFO] [stdout] 28 | | } else if n == 3 { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/iterate/module/doc.rs:28:22 [INFO] [stdout] | [INFO] [stdout] 28 | } else if n == 3 { [INFO] [stdout] | ______________________^ [INFO] [stdout] 29 | | eprintln!( [INFO] [stdout] 30 | | "Wrong formatting! Please execute the program without any arguments for documentation" [INFO] [stdout] 31 | | ); [INFO] [stdout] 32 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/iterate/module/mod.rs:28:26 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn make_numset(args: &Vec, i: &usize) -> NumSet { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 28 - pub fn make_numset(args: &Vec, i: &usize) -> NumSet { [INFO] [stdout] 28 + pub fn make_numset(args: &[String], i: &usize) -> NumSet { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/iterate/module/mod.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 30 | / let numbers = NumSet { [INFO] [stdout] 31 | | num1: args[i + 0].clone(), [INFO] [stdout] 32 | | symbol: String::new(), [INFO] [stdout] 33 | | num2: args[i + 1].clone(), [INFO] [stdout] 34 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 35 | numbers [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 30 ~ [INFO] [stdout] 31 ~ NumSet { [INFO] [stdout] 32 + num1: args[i + 0].clone(), [INFO] [stdout] 33 + symbol: String::new(), [INFO] [stdout] 34 + num2: args[i + 1].clone(), [INFO] [stdout] 35 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/iterate/module/mod.rs:31:24 [INFO] [stdout] | [INFO] [stdout] 31 | num1: args[i + 0].clone(), [INFO] [stdout] | ^^^^^ help: consider reducing it to: `*i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/iterate/module/mod.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 37 | / let numbers = NumSet { [INFO] [stdout] 38 | | num1: args[i + 0].clone(), [INFO] [stdout] 39 | | symbol: args[i + 1].clone(), [INFO] [stdout] 40 | | num2: args[i + 2].clone(), [INFO] [stdout] 41 | | }; [INFO] [stdout] | |__________- unnecessary `let` binding [INFO] [stdout] 42 | numbers [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 37 ~ [INFO] [stdout] 38 ~ NumSet { [INFO] [stdout] 39 + num1: args[i + 0].clone(), [INFO] [stdout] 40 + symbol: args[i + 1].clone(), [INFO] [stdout] 41 + num2: args[i + 2].clone(), [INFO] [stdout] 42 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/iterate/module/mod.rs:38:24 [INFO] [stdout] | [INFO] [stdout] 38 | num1: args[i + 0].clone(), [INFO] [stdout] | ^^^^^ help: consider reducing it to: `*i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/iterate/module/mod.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] = note: `#[warn(clippy::print_with_newline)]` on by default [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 58 - print!("\n"); [INFO] [stdout] 58 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/iterate/module/mod.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 66 - print!("\n"); [INFO] [stdout] 66 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/iterate/module/mod.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 74 - print!("\n"); [INFO] [stdout] 74 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/iterate/module/mod.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 82 - print!("\n"); [INFO] [stdout] 82 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `print!()` with a format string that ends in a single newline [INFO] [stdout] --> src/iterate/module/mod.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 90 | print!("\n"); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stdout] help: use `println!` instead [INFO] [stdout] | [INFO] [stdout] 90 - print!("\n"); [INFO] [stdout] 90 + println!(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/iterate/mod.rs:86:20 [INFO] [stdout] | [INFO] [stdout] 86 | if set.num1 == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `set.num1.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/iterate/mod.rs:101:27 [INFO] [stdout] | [INFO] [stdout] 101 | } else if set.num2 == "" { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `set.num2.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/iterate/mod.rs:167:16 [INFO] [stdout] | [INFO] [stdout] 167 | if set.num1 != "" && set.num2 != "" && set.symbol != "" && search_for_symbol == 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!set.num1.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/iterate/mod.rs:167:34 [INFO] [stdout] | [INFO] [stdout] 167 | if set.num1 != "" && set.num2 != "" && set.symbol != "" && search_for_symbol == 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!set.num2.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/iterate/mod.rs:167:52 [INFO] [stdout] | [INFO] [stdout] 167 | if set.num1 != "" && set.num2 != "" && set.symbol != "" && search_for_symbol == 1 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!set.symbol.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/iterate/mod.rs:186:23 [INFO] [stdout] | [INFO] [stdout] 186 | } else if set.num2 == "" && set.symbol == "" && set.num1 != "" && search_for_symbol == 1 [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `set.num2.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/iterate/mod.rs:186:41 [INFO] [stdout] | [INFO] [stdout] 186 | } else if set.num2 == "" && set.symbol == "" && set.num1 != "" && search_for_symbol == 1 [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `set.symbol.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/iterate/mod.rs:186:61 [INFO] [stdout] | [INFO] [stdout] 186 | } else if set.num2 == "" && set.symbol == "" && set.num1 != "" && search_for_symbol == 1 [INFO] [stdout] | ^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!set.num1.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 39 | || !args[0].parse::().is_ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args[0].parse::().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/main.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | drop(dir1); [INFO] [stdout] | ^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&std::path::Path` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 24 - drop(dir1); [INFO] [stdout] 24 + let _ = dir1; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.88s [INFO] running `Command { std: "docker" "inspect" "f13307bdf1297d47ae3a27c1bca7075fbad5d6a799c8095a04904a7888dbf91b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f13307bdf1297d47ae3a27c1bca7075fbad5d6a799c8095a04904a7888dbf91b", kill_on_drop: false }` [INFO] [stdout] f13307bdf1297d47ae3a27c1bca7075fbad5d6a799c8095a04904a7888dbf91b