[INFO] cloning repository https://github.com/Scriptodude/rust-learn
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Scriptodude/rust-learn" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FScriptodude%2Frust-learn", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FScriptodude%2Frust-learn'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 2e183d13fc39d48ff4ba4732993a44abae02fd8f
[INFO] linting Scriptodude/rust-learn against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FScriptodude%2Frust-learn" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/Scriptodude/rust-learn
[INFO] finished tweaking git repo https://github.com/Scriptodude/rust-learn
[INFO] tweaked toml for git repo https://github.com/Scriptodude/rust-learn written to /workspace/builds/worker-5-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/Scriptodude/rust-learn on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/Scriptodude/rust-learn already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 48864917bec4b3360b5e3a9521179d05a87dca406043a9d7eedd31d6d1235c04
[INFO] running `Command { std: "docker" "start" "-a" "48864917bec4b3360b5e3a9521179d05a87dca406043a9d7eedd31d6d1235c04", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "48864917bec4b3360b5e3a9521179d05a87dca406043a9d7eedd31d6d1235c04", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "48864917bec4b3360b5e3a9521179d05a87dca406043a9d7eedd31d6d1235c04", kill_on_drop: false }`
[INFO] [stdout] 48864917bec4b3360b5e3a9521179d05a87dca406043a9d7eedd31d6d1235c04
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] c6f43f72d9b5fe276a3643841a4745efb0df20dee6e64c9ea82a4836cb702c66
[INFO] running `Command { std: "docker" "start" "-a" "c6f43f72d9b5fe276a3643841a4745efb0df20dee6e64c9ea82a4836cb702c66", kill_on_drop: false }`
[INFO] [stderr]     Checking rust-learn v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]   --> src/hello_world/mod.rs:16:23
[INFO] [stdout]    |
[INFO] [stdout] 16 |                object = "the lazy dog",
[INFO] [stdout]    |  _______________________^
[INFO] [stdout] 17 | |              subject = "the quick brown fox",
[INFO] [stdout] 18 | |              verb = "jumps over");
[INFO] [stdout]    | |________________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stdout]    = note: `#[warn(clippy::print_literal)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 15 -     println!("{subject} {verb} {object}",
[INFO] [stdout] 16 -              object = "the lazy dog",
[INFO] [stdout] 17 -              subject = "the quick brown fox",
[INFO] [stdout] 18 -              verb = "jumps over");
[INFO] [stdout] 15 +     println!("the quick brown fox jumps over the lazy dog");
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]   --> src/hello_world/mod.rs:32:49
[INFO] [stdout]    |
[INFO] [stdout] 32 |     println!("My name is {0}, {1} {0}", "Bond", "James");
[INFO] [stdout]    |                                                 ^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 32 -     println!("My name is {0}, {1} {0}", "Bond", "James");
[INFO] [stdout] 32 +     println!("My name is {0}, James {0}", "Bond");
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/primitives/lit_and_ops.rs:14:38
[INFO] [stdout]    |
[INFO] [stdout] 14 |     println!("true AND false is {}", true && false);
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^ help: try: `false`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/primitives/lit_and_ops.rs:15:37
[INFO] [stdout]    |
[INFO] [stdout] 15 |     println!("true OR false is {}", true || false);
[INFO] [stdout]    |                                     ^^^^^^^^^^^^^ help: try: `true`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/primitives/lit_and_ops.rs:16:32
[INFO] [stdout]    |
[INFO] [stdout] 16 |     println!("NOT true is {}", !true);
[INFO] [stdout]    |                                ^^^^^ help: try: `false`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/primitives/tuples.rs:72:5
[INFO] [stdout]    |
[INFO] [stdout] 72 |     return Matrix(m.0, m.2, m.1, m.3);
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 72 -     return Matrix(m.0, m.2, m.1, m.3);
[INFO] [stdout] 72 +     Matrix(m.0, m.2, m.1, m.3)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/borrowing/mod.rs:14:26
[INFO] [stdout]    |
[INFO] [stdout] 14 |         let c = lifetime(&a, &b);
[INFO] [stdout]    |                          ^^ help: change this to: `a`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/borrowing/mod.rs:14:30
[INFO] [stdout]    |
[INFO] [stdout] 14 |         let c = lifetime(&a, &b);
[INFO] [stdout]    |                              ^^ help: change this to: `b`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/borrowing/mod.rs:30:26
[INFO] [stdout]    |
[INFO] [stdout] 30 |         let c = lifetime(&b, &a);
[INFO] [stdout]    |                          ^^ help: change this to: `b`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/borrowing/mod.rs:30:30
[INFO] [stdout]    |
[INFO] [stdout] 30 |         let c = lifetime(&b, &a);
[INFO] [stdout]    |                              ^^ help: change this to: `a`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the following explicit lifetimes could be elided: 'b
[INFO] [stdout]   --> src/borrowing/mod.rs:41:17
[INFO] [stdout]    |
[INFO] [stdout] 41 | fn lifetime<'a, 'b>(test: &'a str, test2: &'b str) -> &'a str {
[INFO] [stdout]    |                 ^^                         ^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stdout]    = note: `#[warn(clippy::needless_lifetimes)]` on by default
[INFO] [stdout] help: elide the lifetimes
[INFO] [stdout]    |
[INFO] [stdout] 41 - fn lifetime<'a, 'b>(test: &'a str, test2: &'b str) -> &'a str {
[INFO] [stdout] 41 + fn lifetime<'a>(test: &'a str, test2: &str) -> &'a str {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/borrowing/mod.rs:43:5
[INFO] [stdout]    |
[INFO] [stdout] 43 |     return "returned value of lifetime";
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 43 -     return "returned value of lifetime";
[INFO] [stdout] 43 +     "returned value of lifetime"
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]   --> src/hello_world/mod.rs:16:23
[INFO] [stdout]    |
[INFO] [stdout] 16 |                object = "the lazy dog",
[INFO] [stdout]    |  _______________________^
[INFO] [stdout] 17 | |              subject = "the quick brown fox",
[INFO] [stdout] 18 | |              verb = "jumps over");
[INFO] [stdout]    | |________________________________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stdout]    = note: `#[warn(clippy::print_literal)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 15 -     println!("{subject} {verb} {object}",
[INFO] [stdout] 16 -              object = "the lazy dog",
[INFO] [stdout] 17 -              subject = "the quick brown fox",
[INFO] [stdout] 18 -              verb = "jumps over");
[INFO] [stdout] 15 +     println!("the quick brown fox jumps over the lazy dog");
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: literal with an empty format string
[INFO] [stdout]   --> src/hello_world/mod.rs:32:49
[INFO] [stdout]    |
[INFO] [stdout] 32 |     println!("My name is {0}, {1} {0}", "Bond", "James");
[INFO] [stdout]    |                                                 ^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 32 -     println!("My name is {0}, {1} {0}", "Bond", "James");
[INFO] [stdout] 32 +     println!("My name is {0}, James {0}", "Bond");
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/primitives/lit_and_ops.rs:14:38
[INFO] [stdout]    |
[INFO] [stdout] 14 |     println!("true AND false is {}", true && false);
[INFO] [stdout]    |                                      ^^^^^^^^^^^^^ help: try: `false`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/primitives/lit_and_ops.rs:15:37
[INFO] [stdout]    |
[INFO] [stdout] 15 |     println!("true OR false is {}", true || false);
[INFO] [stdout]    |                                     ^^^^^^^^^^^^^ help: try: `true`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/primitives/lit_and_ops.rs:16:32
[INFO] [stdout]    |
[INFO] [stdout] 16 |     println!("NOT true is {}", !true);
[INFO] [stdout]    |                                ^^^^^ help: try: `false`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/primitives/tuples.rs:72:5
[INFO] [stdout]    |
[INFO] [stdout] 72 |     return Matrix(m.0, m.2, m.1, m.3);
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 72 -     return Matrix(m.0, m.2, m.1, m.3);
[INFO] [stdout] 72 +     Matrix(m.0, m.2, m.1, m.3)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/borrowing/mod.rs:14:26
[INFO] [stdout]    |
[INFO] [stdout] 14 |         let c = lifetime(&a, &b);
[INFO] [stdout]    |                          ^^ help: change this to: `a`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/borrowing/mod.rs:14:30
[INFO] [stdout]    |
[INFO] [stdout] 14 |         let c = lifetime(&a, &b);
[INFO] [stdout]    |                              ^^ help: change this to: `b`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/borrowing/mod.rs:30:26
[INFO] [stdout]    |
[INFO] [stdout] 30 |         let c = lifetime(&b, &a);
[INFO] [stdout]    |                          ^^ help: change this to: `b`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]   --> src/borrowing/mod.rs:30:30
[INFO] [stdout]    |
[INFO] [stdout] 30 |         let c = lifetime(&b, &a);
[INFO] [stdout]    |                              ^^ help: change this to: `a`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the following explicit lifetimes could be elided: 'b
[INFO] [stdout]   --> src/borrowing/mod.rs:41:17
[INFO] [stdout]    |
[INFO] [stdout] 41 | fn lifetime<'a, 'b>(test: &'a str, test2: &'b str) -> &'a str {
[INFO] [stdout]    |                 ^^                         ^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stdout]    = note: `#[warn(clippy::needless_lifetimes)]` on by default
[INFO] [stdout] help: elide the lifetimes
[INFO] [stdout]    |
[INFO] [stdout] 41 - fn lifetime<'a, 'b>(test: &'a str, test2: &'b str) -> &'a str {
[INFO] [stdout] 41 + fn lifetime<'a>(test: &'a str, test2: &str) -> &'a str {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/borrowing/mod.rs:43:5
[INFO] [stdout]    |
[INFO] [stdout] 43 |     return "returned value of lifetime";
[INFO] [stdout]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 43 -     return "returned value of lifetime";
[INFO] [stdout] 43 +     "returned value of lifetime"
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.20s
[INFO] running `Command { std: "docker" "inspect" "c6f43f72d9b5fe276a3643841a4745efb0df20dee6e64c9ea82a4836cb702c66", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "c6f43f72d9b5fe276a3643841a4745efb0df20dee6e64c9ea82a4836cb702c66", kill_on_drop: false }`
[INFO] [stdout] c6f43f72d9b5fe276a3643841a4745efb0df20dee6e64c9ea82a4836cb702c66