[INFO] cloning repository https://github.com/Sargvd/shell
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Sargvd/shell" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSargvd%2Fshell", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSargvd%2Fshell'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 9a40e1feef1e31d8681b292e028506b5fd45ed7e
[INFO] linting Sargvd/shell against nightly for clippy-nonminimal_bool-denied
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSargvd%2Fshell" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/Sargvd/shell
[INFO] finished tweaking git repo https://github.com/Sargvd/shell
[INFO] tweaked toml for git repo https://github.com/Sargvd/shell written to /workspace/builds/worker-6-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/Sargvd/shell on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/Sargvd/shell already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 5c1bc710b8d62a7f4a7d32a36393918d1d98242d9e3546172d0bd3acbd88f308
[INFO] running `Command { std: "docker" "start" "-a" "5c1bc710b8d62a7f4a7d32a36393918d1d98242d9e3546172d0bd3acbd88f308", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "5c1bc710b8d62a7f4a7d32a36393918d1d98242d9e3546172d0bd3acbd88f308", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "5c1bc710b8d62a7f4a7d32a36393918d1d98242d9e3546172d0bd3acbd88f308", kill_on_drop: false }`
[INFO] [stdout] 5c1bc710b8d62a7f4a7d32a36393918d1d98242d9e3546172d0bd3acbd88f308
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] ffcfb5f43dc030600070df10c851ff2cd034b79dae840c09fa95ede0fc5be705
[INFO] running `Command { std: "docker" "start" "-a" "ffcfb5f43dc030600070df10c851ff2cd034b79dae840c09fa95ede0fc5be705", kill_on_drop: false }`
[INFO] [stderr]     Checking codecrafters-shell v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined
[INFO] [stdout]   --> src/builtins.rs:32:14
[INFO] [stdout]    |
[INFO] [stdout] 32 |             .create(true)
[INFO] [stdout]    |              ^^^^^^^^^^^^- help: add: `.truncate(true)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: if you intend to overwrite an existing file entirely, call `.truncate(true)`
[INFO] [stdout]    = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)`
[INFO] [stdout]    = help: alternatively, use `.append(true)` to append to the file instead of overwriting it
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options
[INFO] [stdout]    = note: `#[warn(clippy::suspicious_open_options)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined
[INFO] [stdout]   --> src/builtins.rs:43:14
[INFO] [stdout]    |
[INFO] [stdout] 43 |             .create(true)
[INFO] [stdout]    |              ^^^^^^^^^^^^- help: add: `.truncate(true)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: if you intend to overwrite an existing file entirely, call `.truncate(true)`
[INFO] [stdout]    = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)`
[INFO] [stdout]    = help: alternatively, use `.append(true)` to append to the file instead of overwriting it
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/builtins.rs:51:8
[INFO] [stdout]    |
[INFO] [stdout] 51 |     if args.len() == 0 {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/builtins.rs:62:51
[INFO] [stdout]    |
[INFO] [stdout] 62 |             let full_path = Path::new(&path).join(&maybe_cmd);
[INFO] [stdout]    |                                                   ^^^^^^^^^^ help: change this to: `maybe_cmd`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/builtins.rs:85:8
[INFO] [stdout]    |
[INFO] [stdout] 85 |     if args.len() == 0 {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/parser.rs:37:20
[INFO] [stdout]    |
[INFO] [stdout] 37 |                 if !cmd.redirection.is_none() {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cmd.redirection.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/parser.rs:39:27
[INFO] [stdout]    |
[INFO] [stdout] 39 |                 } else if !cmd.stderr_redirection.is_none() {
[INFO] [stdout]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cmd.stderr_redirection.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined
[INFO] [stdout]   --> src/builtins.rs:32:14
[INFO] [stdout]    |
[INFO] [stdout] 32 |             .create(true)
[INFO] [stdout]    |              ^^^^^^^^^^^^- help: add: `.truncate(true)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: if you intend to overwrite an existing file entirely, call `.truncate(true)`
[INFO] [stdout]    = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)`
[INFO] [stdout]    = help: alternatively, use `.append(true)` to append to the file instead of overwriting it
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options
[INFO] [stdout]    = note: `#[warn(clippy::suspicious_open_options)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: file opened with `create`, but `truncate` behavior not defined
[INFO] [stdout]   --> src/builtins.rs:43:14
[INFO] [stdout]    |
[INFO] [stdout] 43 |             .create(true)
[INFO] [stdout]    |              ^^^^^^^^^^^^- help: add: `.truncate(true)`
[INFO] [stdout]    |
[INFO] [stdout]    = help: if you intend to overwrite an existing file entirely, call `.truncate(true)`
[INFO] [stdout]    = help: if you instead know that you may want to keep some parts of the old file, call `.truncate(false)`
[INFO] [stdout]    = help: alternatively, use `.append(true)` to append to the file instead of overwriting it
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_open_options
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/builtins.rs:51:8
[INFO] [stdout]    |
[INFO] [stdout] 51 |     if args.len() == 0 {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]    = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the borrowed expression implements the required traits
[INFO] [stdout]   --> src/builtins.rs:62:51
[INFO] [stdout]    |
[INFO] [stdout] 62 |             let full_path = Path::new(&path).join(&maybe_cmd);
[INFO] [stdout]    |                                                   ^^^^^^^^^^ help: change this to: `maybe_cmd`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
[INFO] [stdout]    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]   --> src/builtins.rs:85:8
[INFO] [stdout]    |
[INFO] [stdout] 85 |     if args.len() == 0 {
[INFO] [stdout]    |        ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/parser.rs:37:20
[INFO] [stdout]    |
[INFO] [stdout] 37 |                 if !cmd.redirection.is_none() {
[INFO] [stdout]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cmd.redirection.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]    = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]   --> src/parser.rs:39:27
[INFO] [stdout]    |
[INFO] [stdout] 39 |                 } else if !cmd.stderr_redirection.is_none() {
[INFO] [stdout]    |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cmd.stderr_redirection.is_some()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.37s
[INFO] running `Command { std: "docker" "inspect" "ffcfb5f43dc030600070df10c851ff2cd034b79dae840c09fa95ede0fc5be705", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "ffcfb5f43dc030600070df10c851ff2cd034b79dae840c09fa95ede0fc5be705", kill_on_drop: false }`
[INFO] [stdout] ffcfb5f43dc030600070df10c851ff2cd034b79dae840c09fa95ede0fc5be705