[INFO] cloning repository https://github.com/Sarek/goodwe-prom [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Sarek/goodwe-prom" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSarek%2Fgoodwe-prom", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSarek%2Fgoodwe-prom'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 288825087789ecd1aade5f9cbd444ac5e3eee368 [INFO] linting Sarek/goodwe-prom against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSarek%2Fgoodwe-prom" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Sarek/goodwe-prom [INFO] finished tweaking git repo https://github.com/Sarek/goodwe-prom [INFO] tweaked toml for git repo https://github.com/Sarek/goodwe-prom written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Sarek/goodwe-prom on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Sarek/goodwe-prom already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded crc16 v0.4.0 [INFO] [stderr] Downloaded strsim v0.11.0 [INFO] [stderr] Downloaded clap v4.5.3 [INFO] [stderr] Downloaded clap_derive v4.5.3 [INFO] [stderr] Downloaded cc v1.1.8 [INFO] [stderr] Downloaded syn v2.0.53 [INFO] [stderr] Downloaded object v0.36.3 [INFO] [stderr] Downloaded h2 v0.4.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 21968425dbc43a6a33b1e69e638663f486d29abba59a2e9c3bead751feaf52c3 [INFO] running `Command { std: "docker" "start" "-a" "21968425dbc43a6a33b1e69e638663f486d29abba59a2e9c3bead751feaf52c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "21968425dbc43a6a33b1e69e638663f486d29abba59a2e9c3bead751feaf52c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "21968425dbc43a6a33b1e69e638663f486d29abba59a2e9c3bead751feaf52c3", kill_on_drop: false }` [INFO] [stdout] 21968425dbc43a6a33b1e69e638663f486d29abba59a2e9c3bead751feaf52c3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8f67afa059fd2e686cfd8b21c50026cc3f973bdab6af94855a934553d1387903 [INFO] running `Command { std: "docker" "start" "-a" "8f67afa059fd2e686cfd8b21c50026cc3f973bdab6af94855a934553d1387903", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Compiling axum-core v0.4.3 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Compiling axum v0.7.5 [INFO] [stderr] Compiling crc16 v0.4.0 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.53 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling clap_derive v4.5.3 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking clap v4.5.3 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking h2 v0.4.3 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking goodwe-prom v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:17:41 [INFO] [stdout] | [INFO] [stdout] 17 | metric.read_data(self.base, &data)? [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:208:37 [INFO] [stdout] | [INFO] [stdout] 208 | get_register_bytes::<2>(&data, self.base.register as usize, base_register as usize)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:262:37 [INFO] [stdout] | [INFO] [stdout] 262 | get_register_bytes::<2>(&data, self.base.register as usize, base_register as usize)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:316:37 [INFO] [stdout] | [INFO] [stdout] 316 | get_register_bytes::<2>(&data, self.base.register as usize, base_register as usize)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:369:37 [INFO] [stdout] | [INFO] [stdout] 369 | get_register_bytes::<4>(&data, self.base.register as usize, base_register as usize)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:421:37 [INFO] [stdout] | [INFO] [stdout] 421 | get_register_bytes::<2>(&data, self.base.register as usize, base_register as usize)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:475:37 [INFO] [stdout] | [INFO] [stdout] 475 | get_register_bytes::<2>(&data, self.base.register as usize, base_register as usize)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:528:37 [INFO] [stdout] | [INFO] [stdout] 528 | get_register_bytes::<2>(&data, self.base.register as usize, base_register as usize)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:17:41 [INFO] [stdout] | [INFO] [stdout] 17 | metric.read_data(self.base, &data)? [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:582:37 [INFO] [stdout] | [INFO] [stdout] 582 | get_register_bytes::<2>(&data, self.base.register as usize, base_register as usize)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:636:37 [INFO] [stdout] | [INFO] [stdout] 636 | get_register_bytes::<4>(&data, self.base.register as usize, base_register as usize)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:690:37 [INFO] [stdout] | [INFO] [stdout] 690 | get_register_bytes::<4>(&data, self.base.register as usize, base_register as usize)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:743:37 [INFO] [stdout] | [INFO] [stdout] 743 | get_register_bytes::<2>(&data, self.base.register as usize, base_register as usize)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:796:37 [INFO] [stdout] | [INFO] [stdout] 796 | get_register_bytes::<2>(&data, self.base.register as usize, base_register as usize)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:208:37 [INFO] [stdout] | [INFO] [stdout] 208 | get_register_bytes::<2>(&data, self.base.register as usize, base_register as usize)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/metrics/modbus/mod.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | / let mut retval: Vec = Vec::new(); [INFO] [stdout] 46 | | retval.push((checksum & 0xff) as u8); [INFO] [stdout] 47 | | retval.push(((checksum >> 8) & 0xff) as u8); [INFO] [stdout] | |________________________________________________^ help: consider using the `vec![]` macro: `let retval: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:262:37 [INFO] [stdout] | [INFO] [stdout] 262 | get_register_bytes::<2>(&data, self.base.register as usize, base_register as usize)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/metrics/modbus/mod.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | / let mut data: Vec = Vec::new(); [INFO] [stdout] 53 | | [INFO] [stdout] 54 | | data.push(addr); [INFO] [stdout] 55 | | data.push(cmd as u8); [INFO] [stdout] ... | [INFO] [stdout] 58 | | data.push(((param >> 8) & 0xff) as u8); [INFO] [stdout] 59 | | data.push((param & 0xff) as u8); [INFO] [stdout] | |____________________________________^ help: consider using the `vec![]` macro: `let mut data: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/metrics/modbus/mod.rs:86:8 [INFO] [stdout] | [INFO] [stdout] 86 | if !cmd.is_some() || ((cmd.unwrap() & 0x80) > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `cmd.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:316:37 [INFO] [stdout] | [INFO] [stdout] 316 | get_register_bytes::<2>(&data, self.base.register as usize, base_register as usize)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/metrics/modbus/mod.rs:66:26 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn get_payload(data: &Vec) -> Result, ModbusError> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 66 - pub fn get_payload(data: &Vec) -> Result, ModbusError> { [INFO] [stdout] 66 + pub fn get_payload(data: &[u8]) -> Result, ModbusError> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/metrics/modbus/mod.rs:101:21 [INFO] [stdout] | [INFO] [stdout] 101 | retval.push(data.next().unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.next().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:369:37 [INFO] [stdout] | [INFO] [stdout] 369 | get_register_bytes::<4>(&data, self.base.register as usize, base_register as usize)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:421:37 [INFO] [stdout] | [INFO] [stdout] 421 | get_register_bytes::<2>(&data, self.base.register as usize, base_register as usize)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:475:37 [INFO] [stdout] | [INFO] [stdout] 475 | get_register_bytes::<2>(&data, self.base.register as usize, base_register as usize)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:528:37 [INFO] [stdout] | [INFO] [stdout] 528 | get_register_bytes::<2>(&data, self.base.register as usize, base_register as usize)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Error` [INFO] [stdout] --> src/metrics/mod.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | / pub enum MetricsError { [INFO] [stdout] 15 | | #[allow(dead_code)] [INFO] [stdout] 16 | | MetricReadError(definitions::MetricReadError), [INFO] [stdout] 17 | | ModbusError(ModbusError), [INFO] [stdout] 18 | | NetworkError(std::io::Error), [INFO] [stdout] 19 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:582:37 [INFO] [stdout] | [INFO] [stdout] 582 | get_register_bytes::<2>(&data, self.base.register as usize, base_register as usize)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:636:37 [INFO] [stdout] | [INFO] [stdout] 636 | get_register_bytes::<4>(&data, self.base.register as usize, base_register as usize)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:690:37 [INFO] [stdout] | [INFO] [stdout] 690 | get_register_bytes::<4>(&data, self.base.register as usize, base_register as usize)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:743:37 [INFO] [stdout] | [INFO] [stdout] 743 | get_register_bytes::<2>(&data, self.base.register as usize, base_register as usize)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/metrics/definitions/mod.rs:796:37 [INFO] [stdout] | [INFO] [stdout] 796 | get_register_bytes::<2>(&data, self.base.register as usize, base_register as usize)?; [INFO] [stdout] | ^^^^^ help: change this to: `data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/metrics/modbus/mod.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | / let mut retval: Vec = Vec::new(); [INFO] [stdout] 46 | | retval.push((checksum & 0xff) as u8); [INFO] [stdout] 47 | | retval.push(((checksum >> 8) & 0xff) as u8); [INFO] [stdout] | |________________________________________________^ help: consider using the `vec![]` macro: `let retval: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/metrics/modbus/mod.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | / let mut data: Vec = Vec::new(); [INFO] [stdout] 53 | | [INFO] [stdout] 54 | | data.push(addr); [INFO] [stdout] 55 | | data.push(cmd as u8); [INFO] [stdout] ... | [INFO] [stdout] 58 | | data.push(((param >> 8) & 0xff) as u8); [INFO] [stdout] 59 | | data.push((param & 0xff) as u8); [INFO] [stdout] | |____________________________________^ help: consider using the `vec![]` macro: `let mut data: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/metrics/modbus/mod.rs:86:8 [INFO] [stdout] | [INFO] [stdout] 86 | if !cmd.is_some() || ((cmd.unwrap() & 0x80) > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `cmd.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/metrics/modbus/mod.rs:66:26 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn get_payload(data: &Vec) -> Result, ModbusError> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 66 - pub fn get_payload(data: &Vec) -> Result, ModbusError> { [INFO] [stdout] 66 + pub fn get_payload(data: &[u8]) -> Result, ModbusError> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/metrics/modbus/mod.rs:101:21 [INFO] [stdout] | [INFO] [stdout] 101 | retval.push(data.next().unwrap().clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*data.next().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Error` [INFO] [stdout] --> src/metrics/mod.rs:14:1 [INFO] [stdout] | [INFO] [stdout] 14 | / pub enum MetricsError { [INFO] [stdout] 15 | | #[allow(dead_code)] [INFO] [stdout] 16 | | MetricReadError(definitions::MetricReadError), [INFO] [stdout] 17 | | ModbusError(ModbusError), [INFO] [stdout] 18 | | NetworkError(std::io::Error), [INFO] [stdout] 19 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 24.10s [INFO] running `Command { std: "docker" "inspect" "8f67afa059fd2e686cfd8b21c50026cc3f973bdab6af94855a934553d1387903", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f67afa059fd2e686cfd8b21c50026cc3f973bdab6af94855a934553d1387903", kill_on_drop: false }` [INFO] [stdout] 8f67afa059fd2e686cfd8b21c50026cc3f973bdab6af94855a934553d1387903