[INFO] cloning repository https://github.com/SantiagoCalligari/http_server [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SantiagoCalligari/http_server" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSantiagoCalligari%2Fhttp_server", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSantiagoCalligari%2Fhttp_server'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 18ac62c530ba89bb21142391da8318720a1f7076 [INFO] linting SantiagoCalligari/http_server against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSantiagoCalligari%2Fhttp_server" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/SantiagoCalligari/http_server [INFO] finished tweaking git repo https://github.com/SantiagoCalligari/http_server [INFO] tweaked toml for git repo https://github.com/SantiagoCalligari/http_server written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/SantiagoCalligari/http_server on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/SantiagoCalligari/http_server already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded proc-macro2 v1.0.70 [INFO] [stderr] Downloaded mio v0.8.10 [INFO] [stderr] Downloaded tokio v1.35.0 [INFO] [stderr] Downloaded libc v0.2.151 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6207b1bab77ce726b54a70c9bedc23e37141d24ddade1d515a948fd5bf330fd5 [INFO] running `Command { std: "docker" "start" "-a" "6207b1bab77ce726b54a70c9bedc23e37141d24ddade1d515a948fd5bf330fd5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6207b1bab77ce726b54a70c9bedc23e37141d24ddade1d515a948fd5bf330fd5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6207b1bab77ce726b54a70c9bedc23e37141d24ddade1d515a948fd5bf330fd5", kill_on_drop: false }` [INFO] [stdout] 6207b1bab77ce726b54a70c9bedc23e37141d24ddade1d515a948fd5bf330fd5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b99d296bf2e3f2b7ca51050b5520ddb84de069f2b7033d4fe00c1bd2ef7d2805 [INFO] running `Command { std: "docker" "start" "-a" "b99d296bf2e3f2b7ca51050b5520ddb84de069f2b7033d4fe00c1bd2ef7d2805", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Checking tokio v1.35.0 [INFO] [stderr] Checking http_server v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/http_request.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | method: method, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/http_request.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | path: path, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/http_request.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | version: version, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/http_request.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | headers: headers, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `stream` [INFO] [stdout] --> src/http_reply.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 61 | pub async fn post_reply(stream: &TcpStream, _request: HttpRequest<'_>) { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_stream` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/http_request.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | method: method, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `method` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/http_request.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | path: path, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/http_request.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | version: version, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/http_request.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | headers: headers, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `version` and `headers` are never read [INFO] [stdout] --> src/http_request.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct HttpRequest<'a> { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 5 | pub version: &'a str, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 6 | pub headers: Vec>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HttpRequest` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `key` and `value` are never read [INFO] [stdout] --> src/http_request.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Header<'a> { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 11 | pub key: &'a str, [INFO] [stdout] | ^^^ [INFO] [stdout] 12 | pub value: &'a str, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Header` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:8:21 [INFO] [stdout] | [INFO] [stdout] 8 | write_to_stream(&stream, b"HTTP/1.1 200 OK\nContent-Type: ").await; [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:11:35 [INFO] [stdout] | [INFO] [stdout] 11 | "html" => write_to_stream(&stream, b"text/html; charset=UTF-8").await, [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:13:34 [INFO] [stdout] | [INFO] [stdout] 13 | "css" => write_to_stream(&stream, b"text/css; charset=UTF-8").await, [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:14:33 [INFO] [stdout] | [INFO] [stdout] 14 | "js" => write_to_stream(&stream, b"text/javascript; charset=UTF-8").await, [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:16:30 [INFO] [stdout] | [INFO] [stdout] 16 | _ => write_to_stream(&stream, b"text/plain; charset=UTF-8").await, [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:18:21 [INFO] [stdout] | [INFO] [stdout] 18 | write_to_stream(&stream, b"\nContent-Length: ").await; [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:35:27 [INFO] [stdout] | [INFO] [stdout] 35 | write_response_header(&stream, extension).await; [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:40:29 [INFO] [stdout] | [INFO] [stdout] 40 | write_to_stream(&stream, size.to_string().as_bytes()).await; [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:41:29 [INFO] [stdout] | [INFO] [stdout] 41 | write_to_stream(&stream, b"\n\n").await; [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:42:29 [INFO] [stdout] | [INFO] [stdout] 42 | write_to_stream(&stream, file_lines.as_bytes()).await; [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:45:21 [INFO] [stdout] | [INFO] [stdout] 45 | write_to_stream(&stream, b"\n").await; [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:51:20 [INFO] [stdout] | [INFO] [stdout] 51 | write_file(&stream, request.path).await; [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | &stream, [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/http_request.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 30 | if !strings.peek().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `strings.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/http_request.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | if path == "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `path.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:13:28 [INFO] [stdout] | [INFO] [stdout] 13 | "GET" => get_reply(&stream, request).await, [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:14:30 [INFO] [stdout] | [INFO] [stdout] 14 | "POST" => post_reply(&stream, request).await, [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:15:28 [INFO] [stdout] | [INFO] [stdout] 15 | "PUT" => put_reply(&stream, request).await, [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:16:30 [INFO] [stdout] | [INFO] [stdout] 16 | "HEAD" => head_reply(&stream, request).await, [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:17:26 [INFO] [stdout] | [INFO] [stdout] 17 | _ => reply_error(&stream, request).await, [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::io::Error` [INFO] [stdout] --> src/main.rs:38:28 [INFO] [stdout] | [INFO] [stdout] 38 | return Err(e.into()); [INFO] [stdout] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/http_request.rs:15:36 [INFO] [stdout] | [INFO] [stdout] 15 | async fn parse_header(full_header: &str) -> Header { [INFO] [stdout] | ^^^^ ^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 15 | async fn parse_header(full_header: &str) -> Header<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/http_request.rs:24:41 [INFO] [stdout] | [INFO] [stdout] 24 | pub async fn parse_request(raw_request: &str) -> HttpRequest { [INFO] [stdout] | ^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 24 | pub async fn parse_request(raw_request: &str) -> HttpRequest<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `stream` [INFO] [stdout] --> src/http_reply.rs:61:25 [INFO] [stdout] | [INFO] [stdout] 61 | pub async fn post_reply(stream: &TcpStream, _request: HttpRequest<'_>) { [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_stream` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `version` and `headers` are never read [INFO] [stdout] --> src/http_request.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct HttpRequest<'a> { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 5 | pub version: &'a str, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 6 | pub headers: Vec>, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HttpRequest` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `key` and `value` are never read [INFO] [stdout] --> src/http_request.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Header<'a> { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 11 | pub key: &'a str, [INFO] [stdout] | ^^^ [INFO] [stdout] 12 | pub value: &'a str, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Header` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:8:21 [INFO] [stdout] | [INFO] [stdout] 8 | write_to_stream(&stream, b"HTTP/1.1 200 OK\nContent-Type: ").await; [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:11:35 [INFO] [stdout] | [INFO] [stdout] 11 | "html" => write_to_stream(&stream, b"text/html; charset=UTF-8").await, [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:13:34 [INFO] [stdout] | [INFO] [stdout] 13 | "css" => write_to_stream(&stream, b"text/css; charset=UTF-8").await, [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:14:33 [INFO] [stdout] | [INFO] [stdout] 14 | "js" => write_to_stream(&stream, b"text/javascript; charset=UTF-8").await, [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:16:30 [INFO] [stdout] | [INFO] [stdout] 16 | _ => write_to_stream(&stream, b"text/plain; charset=UTF-8").await, [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:18:21 [INFO] [stdout] | [INFO] [stdout] 18 | write_to_stream(&stream, b"\nContent-Length: ").await; [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:35:27 [INFO] [stdout] | [INFO] [stdout] 35 | write_response_header(&stream, extension).await; [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:40:29 [INFO] [stdout] | [INFO] [stdout] 40 | write_to_stream(&stream, size.to_string().as_bytes()).await; [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:41:29 [INFO] [stdout] | [INFO] [stdout] 41 | write_to_stream(&stream, b"\n\n").await; [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:42:29 [INFO] [stdout] | [INFO] [stdout] 42 | write_to_stream(&stream, file_lines.as_bytes()).await; [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:45:21 [INFO] [stdout] | [INFO] [stdout] 45 | write_to_stream(&stream, b"\n").await; [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:51:20 [INFO] [stdout] | [INFO] [stdout] 51 | write_file(&stream, request.path).await; [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/http_reply.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | &stream, [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/http_request.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 30 | if !strings.peek().is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `strings.peek().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/http_request.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | if path == "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `path.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:13:28 [INFO] [stdout] | [INFO] [stdout] 13 | "GET" => get_reply(&stream, request).await, [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:14:30 [INFO] [stdout] | [INFO] [stdout] 14 | "POST" => post_reply(&stream, request).await, [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:15:28 [INFO] [stdout] | [INFO] [stdout] 15 | "PUT" => put_reply(&stream, request).await, [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:16:30 [INFO] [stdout] | [INFO] [stdout] 16 | "HEAD" => head_reply(&stream, request).await, [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:17:26 [INFO] [stdout] | [INFO] [stdout] 17 | _ => reply_error(&stream, request).await, [INFO] [stdout] | ^^^^^^^ help: change this to: `stream` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::io::Error` [INFO] [stdout] --> src/main.rs:38:28 [INFO] [stdout] | [INFO] [stdout] 38 | return Err(e.into()); [INFO] [stdout] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/http_request.rs:15:36 [INFO] [stdout] | [INFO] [stdout] 15 | async fn parse_header(full_header: &str) -> Header { [INFO] [stdout] | ^^^^ ^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 15 | async fn parse_header(full_header: &str) -> Header<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/http_request.rs:24:41 [INFO] [stdout] | [INFO] [stdout] 24 | pub async fn parse_request(raw_request: &str) -> HttpRequest { [INFO] [stdout] | ^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 24 | pub async fn parse_request(raw_request: &str) -> HttpRequest<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.18s [INFO] running `Command { std: "docker" "inspect" "b99d296bf2e3f2b7ca51050b5520ddb84de069f2b7033d4fe00c1bd2ef7d2805", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b99d296bf2e3f2b7ca51050b5520ddb84de069f2b7033d4fe00c1bd2ef7d2805", kill_on_drop: false }` [INFO] [stdout] b99d296bf2e3f2b7ca51050b5520ddb84de069f2b7033d4fe00c1bd2ef7d2805