[INFO] cloning repository https://github.com/Samy-Annasri/rustboy [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Samy-Annasri/rustboy" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSamy-Annasri%2Frustboy", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSamy-Annasri%2Frustboy'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 07f7289fc4282e967c52c19e3475fc78c21a06d4 [INFO] linting Samy-Annasri/rustboy against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSamy-Annasri%2Frustboy" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Samy-Annasri/rustboy [INFO] finished tweaking git repo https://github.com/Samy-Annasri/rustboy [INFO] tweaked toml for git repo https://github.com/Samy-Annasri/rustboy written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Samy-Annasri/rustboy on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Samy-Annasri/rustboy already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded symphonia-metadata v0.5.5 [INFO] [stderr] Downloaded symphonia v0.5.5 [INFO] [stderr] Downloaded symphonia-bundle-mp3 v0.5.5 [INFO] [stderr] Downloaded symphonia-core v0.5.5 [INFO] [stderr] Downloaded libredox v0.1.11 [INFO] [stderr] Downloaded redox_syscall v0.6.0 [INFO] [stderr] Downloaded xkb v0.2.1 [INFO] [stderr] Downloaded xkbcommon-sys v0.7.5 [INFO] [stderr] Downloaded minifb v0.20.0 [INFO] [stderr] Downloaded nom v5.1.3 [INFO] [stderr] Downloaded bindgen v0.56.0 [INFO] [stderr] Downloaded nix v0.20.2 [INFO] [stderr] Downloaded sdl2 v0.35.2 [INFO] [stderr] Downloaded sdl2-sys v0.35.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 012be237396d49def0a8bab3dd4695396fe3e0fff9ba7fa685247886790e0e9f [INFO] running `Command { std: "docker" "start" "-a" "012be237396d49def0a8bab3dd4695396fe3e0fff9ba7fa685247886790e0e9f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "012be237396d49def0a8bab3dd4695396fe3e0fff9ba7fa685247886790e0e9f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "012be237396d49def0a8bab3dd4695396fe3e0fff9ba7fa685247886790e0e9f", kill_on_drop: false }` [INFO] [stdout] 012be237396d49def0a8bab3dd4695396fe3e0fff9ba7fa685247886790e0e9f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e6bc6fb4b93d7226677fb6762e1a108d73f3ef56cd7238017925ccceb26c7a09 [INFO] running `Command { std: "docker" "start" "-a" "e6bc6fb4b93d7226677fb6762e1a108d73f3ef56cd7238017925ccceb26c7a09", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.7.6 [INFO] [stderr] Compiling glob v0.3.3 [INFO] [stderr] Compiling xml-rs v0.8.28 [INFO] [stderr] Compiling regex-syntax v0.8.8 [INFO] [stderr] Compiling unicode-width v0.1.14 [INFO] [stderr] Compiling wayland-sys v0.28.6 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling nom v5.1.3 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling libloading v0.8.9 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling humantime v2.3.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling bindgen v0.56.0 [INFO] [stderr] Compiling vec_map v0.8.2 [INFO] [stderr] Compiling log v0.4.29 [INFO] [stderr] Compiling ansi_term v0.12.1 [INFO] [stderr] Compiling termcolor v1.4.1 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling shlex v0.1.1 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Checking nix v0.20.2 [INFO] [stderr] Compiling cpal v0.15.3 [INFO] [stderr] Checking cty v0.2.2 [INFO] [stderr] Checking tinyvec v1.10.0 [INFO] [stderr] Checking raw-window-handle v0.4.3 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking symphonia-core v0.5.5 [INFO] [stderr] Compiling minifb v0.20.0 [INFO] [stderr] Compiling clang-sys v1.8.1 [INFO] [stderr] Checking xcursor v0.3.10 [INFO] [stderr] Checking raw-window-handle v0.3.4 [INFO] [stderr] Checking tempfile v3.24.0 [INFO] [stderr] Checking lewton v0.10.2 [INFO] [stderr] Checking alsa v0.9.1 [INFO] [stderr] Compiling wayland-scanner v0.28.6 [INFO] [stderr] Compiling aho-corasick v1.1.4 [INFO] [stderr] Compiling wayland-client v0.28.6 [INFO] [stderr] Compiling wayland-protocols v0.28.6 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling which v3.1.1 [INFO] [stderr] Compiling clap v2.34.0 [INFO] [stderr] Checking symphonia-metadata v0.5.5 [INFO] [stderr] Compiling cexpr v0.4.0 [INFO] [stderr] Checking symphonia-bundle-mp3 v0.5.5 [INFO] [stderr] Checking symphonia v0.5.5 [INFO] [stderr] Checking rodio v0.17.3 [INFO] [stderr] Compiling regex-automata v0.4.13 [INFO] [stderr] Checking wayland-commons v0.28.6 [INFO] [stderr] Checking wayland-cursor v0.28.6 [INFO] [stderr] Compiling regex v1.12.2 [INFO] [stderr] Compiling env_logger v0.8.4 [INFO] [stderr] Compiling xkbcommon-sys v0.7.5 [INFO] [stderr] Checking xkb v0.2.1 [INFO] [stderr] Checking rustboy v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: value assigned to `cycles` is never read [INFO] [stdout] --> src/cpu.rs:859:17 [INFO] [stdout] | [INFO] [stdout] 859 | cycles = 4; // Default cycles for unknown, or panic [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `cycles` is never read [INFO] [stdout] --> src/cpu.rs:859:17 [INFO] [stdout] | [INFO] [stdout] 859 | cycles = 4; // Default cycles for unknown, or panic [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `frame_start` [INFO] [stdout] --> src/main.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | let frame_start = std::time::Instant::now(); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_frame_start` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Flag` is never used [INFO] [stdout] --> src/cpu.rs:10:10 [INFO] [stdout] | [INFO] [stdout] 10 | pub enum Flag { Z, N, H, C } [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `xor_a_r8`, `or_a_r8`, and `ld_hld_a` are never used [INFO] [stdout] --> src/cpu.rs:1016:8 [INFO] [stdout] | [INFO] [stdout] 31 | impl Cpu { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 1016 | fn xor_a_r8(&mut self, target: Reg8) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1041 | fn or_a_r8(&mut self, target: Reg8,) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1154 | fn ld_hld_a(&mut self, bus: &mut Bus) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `length` is never read [INFO] [stdout] --> src/apu.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct SquareChannel { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 4 | pub length: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `tick` is never used [INFO] [stdout] --> src/apu.rs:143:12 [INFO] [stdout] | [INFO] [stdout] 66 | impl Apu { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 143 | pub fn tick(&mut self) {} [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `frame_start` [INFO] [stdout] --> src/main.rs:65:13 [INFO] [stdout] | [INFO] [stdout] 65 | let frame_start = std::time::Instant::now(); [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_frame_start` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `Flag` is never used [INFO] [stdout] --> src/cpu.rs:10:10 [INFO] [stdout] | [INFO] [stdout] 10 | pub enum Flag { Z, N, H, C } [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `xor_a_r8`, `or_a_r8`, and `ld_hld_a` are never used [INFO] [stdout] --> src/cpu.rs:1016:8 [INFO] [stdout] | [INFO] [stdout] 31 | impl Cpu { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 1016 | fn xor_a_r8(&mut self, target: Reg8) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1041 | fn or_a_r8(&mut self, target: Reg8,) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1154 | fn ld_hld_a(&mut self, bus: &mut Bus) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `length` is never read [INFO] [stdout] --> src/apu.rs:4:9 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct SquareChannel { [INFO] [stdout] | ------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 4 | pub length: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `tick` is never used [INFO] [stdout] --> src/apu.rs:143:12 [INFO] [stdout] | [INFO] [stdout] 66 | impl Apu { [INFO] [stdout] | -------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 143 | pub fn tick(&mut self) {} [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/bus.rs:41:17 [INFO] [stdout] | [INFO] [stdout] 41 | / if (address as usize) < self.rom.len() { [INFO] [stdout] 42 | | self.rom[address as usize] [INFO] [stdout] 43 | | } else { [INFO] [stdout] 44 | | 0 [INFO] [stdout] 45 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 40 ~ 0x0000..=0x7FFF [INFO] [stdout] 41 ~ if (address as usize) < self.rom.len() => { [INFO] [stdout] 42 | self.rom[address as usize] [INFO] [stdout] 43 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/bus.rs:41:17 [INFO] [stdout] | [INFO] [stdout] 41 | / if (address as usize) < self.rom.len() { [INFO] [stdout] 42 | | self.rom[address as usize] [INFO] [stdout] 43 | | } else { [INFO] [stdout] 44 | | 0 [INFO] [stdout] 45 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 40 ~ 0x0000..=0x7FFF [INFO] [stdout] 41 ~ if (address as usize) < self.rom.len() => { [INFO] [stdout] 42 | self.rom[address as usize] [INFO] [stdout] 43 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:75:17 [INFO] [stdout] | [INFO] [stdout] 75 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - self.pc = 0x0040; [INFO] [stdout] 74 - [INFO] [stdout] 75 - return; [INFO] [stdout] 73 + self.pc = 0x0040; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cpu.rs:75:17 [INFO] [stdout] | [INFO] [stdout] 75 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - self.pc = 0x0040; [INFO] [stdout] 74 - [INFO] [stdout] 75 - return; [INFO] [stdout] 73 + self.pc = 0x0040; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:1084:9 [INFO] [stdout] | [INFO] [stdout] 1084 | self.a = self.a & value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.a &= value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/cpu.rs:1084:9 [INFO] [stdout] | [INFO] [stdout] 1084 | self.a = self.a & value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.a &= value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Reg8` which implements the `Copy` trait [INFO] [stdout] --> src/cpu.rs:1605:36 [INFO] [stdout] | [INFO] [stdout] 1605 | let val = self.get_reg_val(target.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Reg8` which implements the `Copy` trait [INFO] [stdout] --> src/cpu.rs:1632:36 [INFO] [stdout] | [INFO] [stdout] 1632 | let val = self.get_reg_val(target.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Reg8` which implements the `Copy` trait [INFO] [stdout] --> src/cpu.rs:1658:36 [INFO] [stdout] | [INFO] [stdout] 1658 | let val = self.get_reg_val(target.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Reg8` which implements the `Copy` trait [INFO] [stdout] --> src/cpu.rs:1686:36 [INFO] [stdout] | [INFO] [stdout] 1686 | let val = self.get_reg_val(target.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Reg8` which implements the `Copy` trait [INFO] [stdout] --> src/cpu.rs:1714:36 [INFO] [stdout] | [INFO] [stdout] 1714 | let val = self.get_reg_val(target.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Reg8` which implements the `Copy` trait [INFO] [stdout] --> src/cpu.rs:1605:36 [INFO] [stdout] | [INFO] [stdout] 1605 | let val = self.get_reg_val(target.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Reg8` which implements the `Copy` trait [INFO] [stdout] --> src/cpu.rs:1740:36 [INFO] [stdout] | [INFO] [stdout] 1740 | let val = self.get_reg_val(target.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Reg8` which implements the `Copy` trait [INFO] [stdout] --> src/cpu.rs:1766:36 [INFO] [stdout] | [INFO] [stdout] 1766 | let val = self.get_reg_val(target.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Reg8` which implements the `Copy` trait [INFO] [stdout] --> src/cpu.rs:1632:36 [INFO] [stdout] | [INFO] [stdout] 1632 | let val = self.get_reg_val(target.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Reg8` which implements the `Copy` trait [INFO] [stdout] --> src/cpu.rs:1658:36 [INFO] [stdout] | [INFO] [stdout] 1658 | let val = self.get_reg_val(target.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Reg8` which implements the `Copy` trait [INFO] [stdout] --> src/cpu.rs:1811:36 [INFO] [stdout] | [INFO] [stdout] 1811 | let val = self.get_reg_val(target.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Reg8` which implements the `Copy` trait [INFO] [stdout] --> src/cpu.rs:1686:36 [INFO] [stdout] | [INFO] [stdout] 1686 | let val = self.get_reg_val(target.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu.rs:1829:37 [INFO] [stdout] | [INFO] [stdout] 1829 | if (self.f & 0x20) != 0 || (!((self.f & 0x40) != 0) && (a & 0x0F) > 9) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((self.f & 0x40) == 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu.rs:1833:37 [INFO] [stdout] | [INFO] [stdout] 1833 | if (self.f & 0x10) != 0 || (!((self.f & 0x40) != 0) && a > 0x99) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((self.f & 0x40) == 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Reg8` which implements the `Copy` trait [INFO] [stdout] --> src/cpu.rs:1714:36 [INFO] [stdout] | [INFO] [stdout] 1714 | let val = self.get_reg_val(target.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Reg8` which implements the `Copy` trait [INFO] [stdout] --> src/cpu.rs:1740:36 [INFO] [stdout] | [INFO] [stdout] 1740 | let val = self.get_reg_val(target.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Reg8` which implements the `Copy` trait [INFO] [stdout] --> src/cpu.rs:1766:36 [INFO] [stdout] | [INFO] [stdout] 1766 | let val = self.get_reg_val(target.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Reg8` which implements the `Copy` trait [INFO] [stdout] --> src/cpu.rs:1811:36 [INFO] [stdout] | [INFO] [stdout] 1811 | let val = self.get_reg_val(target.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu.rs:1829:37 [INFO] [stdout] | [INFO] [stdout] 1829 | if (self.f & 0x20) != 0 || (!((self.f & 0x40) != 0) && (a & 0x0F) > 9) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((self.f & 0x40) == 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cpu.rs:1833:37 [INFO] [stdout] | [INFO] [stdout] 1833 | if (self.f & 0x10) != 0 || (!((self.f & 0x40) != 0) && a > 0x99) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((self.f & 0x40) == 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 44.34s [INFO] running `Command { std: "docker" "inspect" "e6bc6fb4b93d7226677fb6762e1a108d73f3ef56cd7238017925ccceb26c7a09", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e6bc6fb4b93d7226677fb6762e1a108d73f3ef56cd7238017925ccceb26c7a09", kill_on_drop: false }` [INFO] [stdout] e6bc6fb4b93d7226677fb6762e1a108d73f3ef56cd7238017925ccceb26c7a09