[INFO] cloning repository https://github.com/SamuelBowman/scrunchie [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/SamuelBowman/scrunchie" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSamuelBowman%2Fscrunchie", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSamuelBowman%2Fscrunchie'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9417079ad02ff2db6c339130e9d49fb78da10c98 [INFO] linting SamuelBowman/scrunchie against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSamuelBowman%2Fscrunchie" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/SamuelBowman/scrunchie [INFO] finished tweaking git repo https://github.com/SamuelBowman/scrunchie [INFO] tweaked toml for git repo https://github.com/SamuelBowman/scrunchie written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/SamuelBowman/scrunchie on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/SamuelBowman/scrunchie already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rayon-core v1.8.1 [INFO] [stderr] Downloaded gif v0.11.1 [INFO] [stderr] Downloaded terminal_size v0.1.13 [INFO] [stderr] Downloaded weezl v0.1.1 [INFO] [stderr] Downloaded indicatif v0.15.0 [INFO] [stderr] Downloaded number_prefix v0.3.0 [INFO] [stderr] Downloaded console v0.13.0 [INFO] [stderr] Downloaded rayon v1.4.1 [INFO] [stderr] Downloaded image v0.23.10 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1f14ed68ec0e159ebe34d820d806a5b7f10abd86e312a2e09794f0d9867060f2 [INFO] running `Command { std: "docker" "start" "-a" "1f14ed68ec0e159ebe34d820d806a5b7f10abd86e312a2e09794f0d9867060f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1f14ed68ec0e159ebe34d820d806a5b7f10abd86e312a2e09794f0d9867060f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f14ed68ec0e159ebe34d820d806a5b7f10abd86e312a2e09794f0d9867060f2", kill_on_drop: false }` [INFO] [stdout] 1f14ed68ec0e159ebe34d820d806a5b7f10abd86e312a2e09794f0d9867060f2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2f86db28b592dbdffdcef10c414f8f64cb1f0656bd02cc6f5029dfb18058cea4 [INFO] running `Command { std: "docker" "start" "-a" "2f86db28b592dbdffdcef10c414f8f64cb1f0656bd02cc6f5029dfb18058cea4", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.79 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling rayon-core v1.8.1 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Compiling rayon v1.4.1 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling num-rational v0.3.0 [INFO] [stderr] Compiling num-iter v0.1.41 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking crossbeam-channel v0.4.4 [INFO] [stderr] Checking regex-syntax v0.6.20 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking weezl v0.1.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking bytemuck v1.4.1 [INFO] [stderr] Checking number_prefix v0.3.0 [INFO] [stderr] Checking gif v0.11.1 [INFO] [stderr] Checking crossbeam-epoch v0.8.2 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking tiff v0.5.0 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking terminal_size v0.1.13 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking png v0.16.7 [INFO] [stderr] Checking regex v1.4.1 [INFO] [stderr] Checking console v0.13.0 [INFO] [stderr] Checking indicatif v0.15.0 [INFO] [stderr] Checking jpeg-decoder v0.1.20 [INFO] [stderr] Checking image v0.23.10 [INFO] [stderr] Checking scrunchie v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use gif; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use image; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use gif; [INFO] [stdout] | ^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | use image; [INFO] [stdout] | ^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | return neighbors; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return neighbors; [INFO] [stdout] 79 + neighbors [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | return neighbors; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return neighbors; [INFO] [stdout] 82 + neighbors [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | return neighbors; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return neighbors; [INFO] [stdout] 86 + neighbors [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:90:56 [INFO] [stdout] | [INFO] [stdout] 90 | fn generate_bottom_up_vector(img: &RgbImage, energies: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 90 - fn generate_bottom_up_vector(img: &RgbImage, energies: &Vec) -> Vec { [INFO] [stdout] 90 + fn generate_bottom_up_vector(img: &RgbImage, energies: &[u32]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:110:55 [INFO] [stdout] | [INFO] [stdout] 110 | fn determine_best_seam<'a>(img: &RgbImage, bottom_up: &'a Vec) -> &'a Seam { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 110 - fn determine_best_seam<'a>(img: &RgbImage, bottom_up: &'a Vec) -> &'a Seam { [INFO] [stdout] 110 + fn determine_best_seam<'a>(img: &RgbImage, bottom_up: &'a [Seam]) -> &'a Seam { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:115:55 [INFO] [stdout] | [INFO] [stdout] 115 | fn seam_to_position_vector(img: &RgbImage, bottom_up: &Vec, initial_seam: &Seam) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 115 - fn seam_to_position_vector(img: &RgbImage, bottom_up: &Vec, initial_seam: &Seam) -> Vec { [INFO] [stdout] 115 + fn seam_to_position_vector(img: &RgbImage, bottom_up: &[Seam], initial_seam: &Seam) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:139:16 [INFO] [stdout] | [INFO] [stdout] 139 | if !(old_x == posn_to_remove.0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(old_x != posn_to_remove.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:132:73 [INFO] [stdout] | [INFO] [stdout] 132 | let posns_to_remove = seam_to_position_vector(&old_img, &bottom_up, &seam); [INFO] [stdout] | ^^^^^ help: change this to: `seam` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | return neighbors; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return neighbors; [INFO] [stdout] 79 + neighbors [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | return neighbors; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 82 - return neighbors; [INFO] [stdout] 82 + neighbors [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 86 | return neighbors; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 86 - return neighbors; [INFO] [stdout] 86 + neighbors [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:90:56 [INFO] [stdout] | [INFO] [stdout] 90 | fn generate_bottom_up_vector(img: &RgbImage, energies: &Vec) -> Vec { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 90 - fn generate_bottom_up_vector(img: &RgbImage, energies: &Vec) -> Vec { [INFO] [stdout] 90 + fn generate_bottom_up_vector(img: &RgbImage, energies: &[u32]) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:110:55 [INFO] [stdout] | [INFO] [stdout] 110 | fn determine_best_seam<'a>(img: &RgbImage, bottom_up: &'a Vec) -> &'a Seam { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 110 - fn determine_best_seam<'a>(img: &RgbImage, bottom_up: &'a Vec) -> &'a Seam { [INFO] [stdout] 110 + fn determine_best_seam<'a>(img: &RgbImage, bottom_up: &'a [Seam]) -> &'a Seam { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:115:55 [INFO] [stdout] | [INFO] [stdout] 115 | fn seam_to_position_vector(img: &RgbImage, bottom_up: &Vec, initial_seam: &Seam) -> Vec { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 115 - fn seam_to_position_vector(img: &RgbImage, bottom_up: &Vec, initial_seam: &Seam) -> Vec { [INFO] [stdout] 115 + fn seam_to_position_vector(img: &RgbImage, bottom_up: &[Seam], initial_seam: &Seam) -> Vec { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:139:16 [INFO] [stdout] | [INFO] [stdout] 139 | if !(old_x == posn_to_remove.0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(old_x != posn_to_remove.0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:132:73 [INFO] [stdout] | [INFO] [stdout] 132 | let posns_to_remove = seam_to_position_vector(&old_img, &bottom_up, &seam); [INFO] [stdout] | ^^^^^ help: change this to: `seam` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:366:73 [INFO] [stdout] | [INFO] [stdout] 366 | let posns_to_remove = seam_to_position_vector(&img, &bottom_up, &seam); [INFO] [stdout] | ^^^^^ help: change this to: `seam` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.97s [INFO] running `Command { std: "docker" "inspect" "2f86db28b592dbdffdcef10c414f8f64cb1f0656bd02cc6f5029dfb18058cea4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2f86db28b592dbdffdcef10c414f8f64cb1f0656bd02cc6f5029dfb18058cea4", kill_on_drop: false }` [INFO] [stdout] 2f86db28b592dbdffdcef10c414f8f64cb1f0656bd02cc6f5029dfb18058cea4