[INFO] cloning repository https://github.com/Salman-Sali/dynorow [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Salman-Sali/dynorow" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSalman-Sali%2Fdynorow", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSalman-Sali%2Fdynorow'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 80b9abb5533ef12cbc19d622d4fc7442e2abf20b [INFO] linting Salman-Sali/dynorow against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FSalman-Sali%2Fdynorow" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/Salman-Sali/dynorow [INFO] finished tweaking git repo https://github.com/Salman-Sali/dynorow [INFO] tweaked toml for git repo https://github.com/Salman-Sali/dynorow written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/Salman-Sali/dynorow on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/Salman-Sali/dynorow already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded base64-simd v0.8.0 [INFO] [stderr] Downloaded outref v0.5.2 [INFO] [stderr] Downloaded bytes-utils v0.1.4 [INFO] [stderr] Downloaded vsimd v0.8.0 [INFO] [stderr] Downloaded aws-types v1.3.11 [INFO] [stderr] Downloaded dynorow_derive v0.1.3 [INFO] [stderr] Downloaded aws-smithy-observability v0.1.5 [INFO] [stderr] Downloaded aws-smithy-query v0.60.9 [INFO] [stderr] Downloaded xmlparser v0.13.6 [INFO] [stderr] Downloaded aws-smithy-http v0.62.6 [INFO] [stderr] Downloaded aws-smithy-xml v0.60.13 [INFO] [stderr] Downloaded aws-smithy-json v0.61.9 [INFO] [stderr] Downloaded aws-smithy-async v1.2.7 [INFO] [stderr] Downloaded aws-sdk-sso v1.91.0 [INFO] [stderr] Downloaded aws-sdk-ssooidc v1.93.0 [INFO] [stderr] Downloaded aws-smithy-runtime v1.9.5 [INFO] [stderr] Downloaded aws-sdk-sts v1.95.0 [INFO] [stderr] Downloaded aws-sigv4 v1.3.7 [INFO] [stderr] Downloaded aws-runtime v1.5.17 [INFO] [stderr] Downloaded aws-smithy-http-client v1.1.5 [INFO] [stderr] Downloaded aws-config v1.8.12 [INFO] [stderr] Downloaded aws-smithy-runtime-api v1.9.3 [INFO] [stderr] Downloaded aws-smithy-types v1.3.5 [INFO] [stderr] Downloaded serde_dynamo v4.3.0 [INFO] [stderr] Downloaded aws-credential-types v1.2.11 [INFO] [stderr] Downloaded aws-sdk-dynamodb v1.101.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 51226af4264f5491d0bc8d5324693c10126efdc26b0c1973c3feb76d00942e9c [INFO] running `Command { std: "docker" "start" "-a" "51226af4264f5491d0bc8d5324693c10126efdc26b0c1973c3feb76d00942e9c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "51226af4264f5491d0bc8d5324693c10126efdc26b0c1973c3feb76d00942e9c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "51226af4264f5491d0bc8d5324693c10126efdc26b0c1973c3feb76d00942e9c", kill_on_drop: false }` [INFO] [stdout] 51226af4264f5491d0bc8d5324693c10126efdc26b0c1973c3feb76d00942e9c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] debbc752403cba68e9a135634e9cf8b50a04d65c299f727fc882410d79f8a011 [INFO] running `Command { std: "docker" "start" "-a" "debbc752403cba68e9a135634e9cf8b50a04d65c299f727fc882410d79f8a011", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.105 [INFO] [stderr] Compiling find-msvc-tools v0.1.6 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking vsimd v0.8.0 [INFO] [stderr] Checking outref v0.5.2 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Checking socket2 v0.6.1 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking bytes-utils v0.1.4 [INFO] [stderr] Checking time v0.3.44 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking ryu v1.0.22 [INFO] [stderr] Compiling aws-lc-rs v1.15.2 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking rustls-pki-types v1.13.2 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Compiling rustls v0.23.36 [INFO] [stderr] Compiling cc v1.2.51 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking openssl-probe v0.2.0 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Compiling aws-types v1.3.11 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking uuid v1.19.0 [INFO] [stderr] Compiling zerocopy v0.8.33 [INFO] [stderr] Compiling memchr v2.7.6 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking base64-simd v0.8.0 [INFO] [stderr] Compiling regex-syntax v0.8.9 [INFO] [stderr] Compiling zmij v1.0.12 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking rustls-native-certs v0.8.3 [INFO] [stderr] Checking xmlparser v0.13.6 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking unicode-ident v1.0.22 [INFO] [stderr] Checking iana-time-zone v0.1.65 [INFO] [stderr] Checking aws-smithy-xml v0.60.13 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Compiling quote v1.0.43 [INFO] [stderr] Checking syn v2.0.114 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Compiling aws-lc-sys v0.35.0 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking serde_dynamo v4.3.0 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking dynorow_derive v0.1.3 (/opt/rustwide/workdir/dynorow_derive) [INFO] [stdout] warning: useless conversion to the same type: `proc_macro2::TokenStream` [INFO] [stdout] --> dynorow_derive/src/generators/as_attribute_values.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | / quote! { [INFO] [stdout] 47 | | impl dynorow::traits::as_attribute_key_values::AsAttributeKeyValues for #struct_name_expr { [INFO] [stdout] 48 | | fn as_attribute_key_values(&self) -> std::collections::HashMap std::collections::HashMap { [INFO] [stdout] 49 + use dynorow::traits::into_attribute_value::*; [INFO] [stdout] 50 + let mut result = std::collections::HashMap::::new(); [INFO] [stdout] 51 + [INFO] [stdout] 52 + #fields_token [INFO] [stdout] 53 + [INFO] [stdout] 54 + return result; [INFO] [stdout] 55 + } [INFO] [stdout] 56 + } [INFO] [stdout] 57 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> dynorow_derive/src/generators/conditional_expression_builder.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | / if let Some(sk_key) = struct_info.get_sk_key() { [INFO] [stdout] 27 | | if struct_info.find_in_handled_fields("sort_key").is_none() { [INFO] [stdout] 28 | | generate_field_function_token("sort_key", &sk_key).to_tokens(&mut field_tokens); [INFO] [stdout] 29 | | } [INFO] [stdout] 30 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 26 ~ if let Some(sk_key) = struct_info.get_sk_key() [INFO] [stdout] 27 ~ && struct_info.find_in_handled_fields("sort_key").is_none() { [INFO] [stdout] 28 | generate_field_function_token("sort_key", &sk_key).to_tokens(&mut field_tokens); [INFO] [stdout] 29 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> dynorow_derive/src/generators/try_from_attribute_value_hashmap.rs:12:65 [INFO] [stdout] | [INFO] [stdout] 12 | let field_tokens = generate_attribute_value_to_fields_token(&struct_info); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `struct_info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> dynorow_derive/src/generators/try_from_attribute_value_hashmap.rs:34:68 [INFO] [stdout] | [INFO] [stdout] 34 | let attribute_parse_token = generate_attribute_parse_token(&field); [INFO] [stdout] | ^^^^^^ help: change this to: `field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `proc_macro2::TokenStream` [INFO] [stdout] --> dynorow_derive/src/generators/try_from_get_item_output.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | / quote::quote! { [INFO] [stdout] 10 | | impl TryFrom for #struct_name { [INFO] [stdout] 11 | | type Error = dynorow::error::Error; [INFO] [stdout] ... | [INFO] [stdout] 21 | | }.into() [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 9 ~ quote::quote! { [INFO] [stdout] 10 + impl TryFrom for #struct_name { [INFO] [stdout] 11 + type Error = dynorow::error::Error; [INFO] [stdout] 12 + [INFO] [stdout] 13 + fn try_from(value: dynorow::aws_sdk_dynamodb::operation::get_item::GetItemOutput) -> Result { [INFO] [stdout] 14 + let Some(items) = value.item else { [INFO] [stdout] 15 + return Err(dynorow::error::Error::value_not_found("GetItemOuput.item".into())); [INFO] [stdout] 16 + }; [INFO] [stdout] 17 + [INFO] [stdout] 18 + Self::try_from(items) [INFO] [stdout] 19 + } [INFO] [stdout] 20 + } [INFO] [stdout] 21 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> dynorow_derive/src/generators/update_expression_builder.rs:19:51 [INFO] [stdout] | [INFO] [stdout] 19 | generate_dynomap_field_function_token(&field).to_tokens(&mut field_tokens); [INFO] [stdout] | ^^^^^^ help: change this to: `field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> dynorow_derive/src/generators/update_expression_builder.rs:21:43 [INFO] [stdout] | [INFO] [stdout] 21 | generate_field_function_token(&field).to_tokens(&mut field_tokens); [INFO] [stdout] | ^^^^^^ help: change this to: `field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> dynorow_derive/src/generators/update_expression_builder_for_dynomap.rs:13:39 [INFO] [stdout] | [INFO] [stdout] 13 | generate_field_function_token(&field).to_tokens(&mut field_tokens); [INFO] [stdout] | ^^^^^^ help: change this to: `field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> dynorow_derive/src/struct_info/field_info.rs:79:1 [INFO] [stdout] | [INFO] [stdout] 79 | impl Into for FieldScan { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 79 ~ impl From for FieldInfo { [INFO] [stdout] 80 ~ fn from(val: FieldScan) -> Self { [INFO] [stdout] 81 | FieldInfo::new( [INFO] [stdout] 82 ~ val.field_name.clone(), [INFO] [stdout] 83 ~ val.get_key(), [INFO] [stdout] 84 ~ val.field_type, [INFO] [stdout] 85 ~ val.field_syn_type, [INFO] [stdout] 86 ~ val.ignore, [INFO] [stdout] 87 ~ val.is_option, [INFO] [stdout] 88 ~ val.is_serde, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> dynorow_derive/src/struct_info/field_info.rs:97:17 [INFO] [stdout] | [INFO] [stdout] 97 | return segment; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return segment; [INFO] [stdout] 97 + segment [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> dynorow_derive/src/struct_info/field_info.rs:118:50 [INFO] [stdout] | [INFO] [stdout] 118 | syn::GenericArgument::Type(t) => return t.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - syn::GenericArgument::Type(t) => return t.clone(), [INFO] [stdout] 118 + syn::GenericArgument::Type(t) => t.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> dynorow_derive/src/struct_info/field_info.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | return Key::Key(self.key.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 187 - return Key::Key(self.key.clone()); [INFO] [stdout] 187 + Key::Key(self.key.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> dynorow_derive/src/struct_info/field_info.rs:221:9 [INFO] [stdout] | [INFO] [stdout] 221 | return field_scan.into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 221 - return field_scan.into(); [INFO] [stdout] 221 + field_scan.into() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> dynorow_derive/src/struct_info/field_info.rs:193:45 [INFO] [stdout] | [INFO] [stdout] 193 | let mut field_scan = FieldScan::new(&field); [INFO] [stdout] | ^^^^^^ help: change this to: `field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> dynorow_derive/src/struct_info/field_info.rs:217:17 [INFO] [stdout] | [INFO] [stdout] 217 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 217 - return Ok(()); [INFO] [stdout] 217 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> dynorow_derive/src/struct_info/key.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | Key(String), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> dynorow_derive/src/struct_info/mod.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | return struct_info; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return struct_info; [INFO] [stdout] 84 + struct_info [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> dynorow_derive/src/struct_info/mod.rs:63:21 [INFO] [stdout] | [INFO] [stdout] 63 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return Ok(()); [INFO] [stdout] 63 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> dynorow_derive/src/struct_info/mod.rs:79:38 [INFO] [stdout] | [INFO] [stdout] 79 | struct_info.insert_field(FieldInfo::try_from(field).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `&Field` to `FieldInfo` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 79 - struct_info.insert_field(FieldInfo::try_from(field).unwrap()); [INFO] [stdout] 79 + struct_info.insert_field(FieldInfo::from(field)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> dynorow_derive/src/struct_info/mod.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | return pk.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - return pk.clone(); [INFO] [stdout] 152 + pk.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> dynorow_derive/src/struct_info/mod.rs:164:9 [INFO] [stdout] | [INFO] [stdout] 164 | / let Some(sk_field) = self.fields.iter().find(|x| matches!(x.key, Key::Sk(_))) else { [INFO] [stdout] 165 | | return None; [INFO] [stdout] 166 | | }; [INFO] [stdout] | |__________^ help: replace it with: `let sk_field = self.fields.iter().find(|x| matches!(x.key, Key::Sk(_)))?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> dynorow_derive/src/struct_info/mod.rs:218:12 [INFO] [stdout] | [INFO] [stdout] 218 | if !(struct_has_pk || struct_has_pk_value) && !field_has_pk { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(struct_has_pk || struct_has_pk_value || field_has_pk)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling tokio-macros v2.6.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stdout] warning: useless conversion to the same type: `proc_macro2::TokenStream` [INFO] [stdout] --> dynorow_derive/src/generators/as_attribute_values.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | / quote! { [INFO] [stdout] 47 | | impl dynorow::traits::as_attribute_key_values::AsAttributeKeyValues for #struct_name_expr { [INFO] [stdout] 48 | | fn as_attribute_key_values(&self) -> std::collections::HashMap std::collections::HashMap { [INFO] [stdout] 49 + use dynorow::traits::into_attribute_value::*; [INFO] [stdout] 50 + let mut result = std::collections::HashMap::::new(); [INFO] [stdout] 51 + [INFO] [stdout] 52 + #fields_token [INFO] [stdout] 53 + [INFO] [stdout] 54 + return result; [INFO] [stdout] 55 + } [INFO] [stdout] 56 + } [INFO] [stdout] 57 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> dynorow_derive/src/generators/conditional_expression_builder.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | / if let Some(sk_key) = struct_info.get_sk_key() { [INFO] [stdout] 27 | | if struct_info.find_in_handled_fields("sort_key").is_none() { [INFO] [stdout] 28 | | generate_field_function_token("sort_key", &sk_key).to_tokens(&mut field_tokens); [INFO] [stdout] 29 | | } [INFO] [stdout] 30 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 26 ~ if let Some(sk_key) = struct_info.get_sk_key() [INFO] [stdout] 27 ~ && struct_info.find_in_handled_fields("sort_key").is_none() { [INFO] [stdout] 28 | generate_field_function_token("sort_key", &sk_key).to_tokens(&mut field_tokens); [INFO] [stdout] 29 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> dynorow_derive/src/generators/try_from_attribute_value_hashmap.rs:12:65 [INFO] [stdout] | [INFO] [stdout] 12 | let field_tokens = generate_attribute_value_to_fields_token(&struct_info); [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `struct_info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> dynorow_derive/src/generators/try_from_attribute_value_hashmap.rs:34:68 [INFO] [stdout] | [INFO] [stdout] 34 | let attribute_parse_token = generate_attribute_parse_token(&field); [INFO] [stdout] | ^^^^^^ help: change this to: `field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stdout] warning: useless conversion to the same type: `proc_macro2::TokenStream` [INFO] [stdout] --> dynorow_derive/src/generators/try_from_get_item_output.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | / quote::quote! { [INFO] [stdout] 10 | | impl TryFrom for #struct_name { [INFO] [stdout] 11 | | type Error = dynorow::error::Error; [INFO] [stdout] ... | [INFO] [stdout] 21 | | }.into() [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 9 ~ quote::quote! { [INFO] [stdout] 10 + impl TryFrom for #struct_name { [INFO] [stdout] 11 + type Error = dynorow::error::Error; [INFO] [stdout] 12 + [INFO] [stdout] 13 + fn try_from(value: dynorow::aws_sdk_dynamodb::operation::get_item::GetItemOutput) -> Result { [INFO] [stdout] 14 + let Some(items) = value.item else { [INFO] [stdout] 15 + return Err(dynorow::error::Error::value_not_found("GetItemOuput.item".into())); [INFO] [stdout] 16 + }; [INFO] [stdout] 17 + [INFO] [stdout] 18 + Self::try_from(items) [INFO] [stdout] 19 + } [INFO] [stdout] 20 + } [INFO] [stdout] 21 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> dynorow_derive/src/generators/update_expression_builder.rs:19:51 [INFO] [stdout] | [INFO] [stdout] 19 | generate_dynomap_field_function_token(&field).to_tokens(&mut field_tokens); [INFO] [stdout] | ^^^^^^ help: change this to: `field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> dynorow_derive/src/generators/update_expression_builder.rs:21:43 [INFO] [stdout] | [INFO] [stdout] 21 | generate_field_function_token(&field).to_tokens(&mut field_tokens); [INFO] [stdout] | ^^^^^^ help: change this to: `field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> dynorow_derive/src/generators/update_expression_builder_for_dynomap.rs:13:39 [INFO] [stdout] | [INFO] [stdout] 13 | generate_field_function_token(&field).to_tokens(&mut field_tokens); [INFO] [stdout] | ^^^^^^ help: change this to: `field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> dynorow_derive/src/struct_info/field_info.rs:79:1 [INFO] [stdout] | [INFO] [stdout] 79 | impl Into for FieldScan { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 79 ~ impl From for FieldInfo { [INFO] [stdout] 80 ~ fn from(val: FieldScan) -> Self { [INFO] [stdout] 81 | FieldInfo::new( [INFO] [stdout] 82 ~ val.field_name.clone(), [INFO] [stdout] 83 ~ val.get_key(), [INFO] [stdout] 84 ~ val.field_type, [INFO] [stdout] 85 ~ val.field_syn_type, [INFO] [stdout] 86 ~ val.ignore, [INFO] [stdout] 87 ~ val.is_option, [INFO] [stdout] 88 ~ val.is_serde, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> dynorow_derive/src/struct_info/field_info.rs:97:17 [INFO] [stdout] | [INFO] [stdout] 97 | return segment; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return segment; [INFO] [stdout] 97 + segment [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> dynorow_derive/src/struct_info/field_info.rs:118:50 [INFO] [stdout] | [INFO] [stdout] 118 | syn::GenericArgument::Type(t) => return t.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - syn::GenericArgument::Type(t) => return t.clone(), [INFO] [stdout] 118 + syn::GenericArgument::Type(t) => t.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> dynorow_derive/src/struct_info/field_info.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | return Key::Key(self.key.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 187 - return Key::Key(self.key.clone()); [INFO] [stdout] 187 + Key::Key(self.key.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> dynorow_derive/src/struct_info/field_info.rs:221:9 [INFO] [stdout] | [INFO] [stdout] 221 | return field_scan.into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 221 - return field_scan.into(); [INFO] [stdout] 221 + field_scan.into() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> dynorow_derive/src/struct_info/field_info.rs:193:45 [INFO] [stdout] | [INFO] [stdout] 193 | let mut field_scan = FieldScan::new(&field); [INFO] [stdout] | ^^^^^^ help: change this to: `field` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> dynorow_derive/src/struct_info/field_info.rs:217:17 [INFO] [stdout] | [INFO] [stdout] 217 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 217 - return Ok(()); [INFO] [stdout] 217 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant name ends with the enum's name [INFO] [stdout] --> dynorow_derive/src/struct_info/key.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | Key(String), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> dynorow_derive/src/struct_info/mod.rs:84:9 [INFO] [stdout] | [INFO] [stdout] 84 | return struct_info; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return struct_info; [INFO] [stdout] 84 + struct_info [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> dynorow_derive/src/struct_info/mod.rs:63:21 [INFO] [stdout] | [INFO] [stdout] 63 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return Ok(()); [INFO] [stdout] 63 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of a fallible conversion when an infallible one could be used [INFO] [stdout] --> dynorow_derive/src/struct_info/mod.rs:79:38 [INFO] [stdout] | [INFO] [stdout] 79 | struct_info.insert_field(FieldInfo::try_from(field).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: converting `&Field` to `FieldInfo` cannot fail [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions [INFO] [stdout] = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default [INFO] [stdout] help: use [INFO] [stdout] | [INFO] [stdout] 79 - struct_info.insert_field(FieldInfo::try_from(field).unwrap()); [INFO] [stdout] 79 + struct_info.insert_field(FieldInfo::from(field)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> dynorow_derive/src/struct_info/mod.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | return pk.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 - return pk.clone(); [INFO] [stdout] 152 + pk.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> dynorow_derive/src/struct_info/mod.rs:164:9 [INFO] [stdout] | [INFO] [stdout] 164 | / let Some(sk_field) = self.fields.iter().find(|x| matches!(x.key, Key::Sk(_))) else { [INFO] [stdout] 165 | | return None; [INFO] [stdout] 166 | | }; [INFO] [stdout] | |__________^ help: replace it with: `let sk_field = self.fields.iter().find(|x| matches!(x.key, Key::Sk(_)))?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> dynorow_derive/src/struct_info/mod.rs:218:12 [INFO] [stdout] | [INFO] [stdout] 218 | if !(struct_has_pk || struct_has_pk_value) && !field_has_pk { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!(struct_has_pk || struct_has_pk_value || field_has_pk)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling dynorow_derive v0.1.3 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking aws-smithy-async v1.2.7 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking aws-smithy-types v1.3.5 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Checking h2 v0.3.27 [INFO] [stderr] Checking aws-smithy-runtime-api v1.9.3 [INFO] [stderr] Checking aws-smithy-json v0.61.9 [INFO] [stderr] Checking aws-smithy-query v0.60.9 [INFO] [stderr] Checking aws-smithy-http v0.62.6 [INFO] [stderr] Checking aws-credential-types v1.2.11 [INFO] [stderr] Checking aws-smithy-observability v0.1.5 [INFO] [stderr] Checking aws-sigv4 v1.3.7 [INFO] [stderr] Checking rustls-webpki v0.103.8 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking aws-smithy-http-client v1.1.5 [INFO] [stderr] Checking aws-smithy-runtime v1.9.5 [INFO] [stderr] Checking aws-runtime v1.5.17 [INFO] [stderr] Checking aws-sdk-dynamodb v1.101.0 [INFO] [stderr] Checking aws-sdk-ssooidc v1.93.0 [INFO] [stderr] Checking aws-sdk-sso v1.91.0 [INFO] [stderr] Checking aws-sdk-sts v1.95.0 [INFO] [stderr] Checking aws-config v1.8.12 [INFO] [stderr] Checking dynorow v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/key.rs:212:17 [INFO] [stdout] | [INFO] [stdout] 212 | partition_key: partition_key, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `partition_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/key.rs:214:17 [INFO] [stdout] | [INFO] [stdout] 214 | sort_key: sort_key, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sort_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/key.rs:212:17 [INFO] [stdout] | [INFO] [stdout] 212 | partition_key: partition_key, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `partition_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/key.rs:214:17 [INFO] [stdout] | [INFO] [stdout] 214 | sort_key: sort_key, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sort_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type parameter `T` goes unused in function definition [INFO] [stdout] --> src/dynamodb_context/dynamodb_table.rs:45:24 [INFO] [stdout] | [INFO] [stdout] 45 | pub async fn exists(&self, key: KeyValue) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters [INFO] [stdout] = note: `#[warn(clippy::extra_unused_type_parameters)]` on by default [INFO] [stdout] help: consider removing the parameter [INFO] [stdout] | [INFO] [stdout] 45 - pub async fn exists(&self, key: KeyValue) -> Result { [INFO] [stdout] 45 + pub async fn exists(&self, key: KeyValue) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dynamodb_context/dynamodb_table.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | / return match row_exists_result { [INFO] [stdout] 56 | | Ok(x) => Ok(x.item.is_some()), [INFO] [stdout] 57 | | Err(e) => Err(Error::sdk_error("Failure while checking if row exists", e)), [INFO] [stdout] 58 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 ~ match row_exists_result { [INFO] [stdout] 56 + Ok(x) => Ok(x.item.is_some()), [INFO] [stdout] 57 + Err(e) => Err(Error::sdk_error("Failure while checking if row exists", e)), [INFO] [stdout] 58 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dynamodb_context/dynamodb_table.rs:215:9 [INFO] [stdout] | [INFO] [stdout] 215 | return Ok(GetListResult::new(result, last_key)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 215 - return Ok(GetListResult::new(result, last_key)); [INFO] [stdout] 215 + Ok(GetListResult::new(result, last_key)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type parameter `T` goes unused in function definition [INFO] [stdout] --> src/dynamodb_context/dynamodb_table.rs:247:40 [INFO] [stdout] | [INFO] [stdout] 247 | pub async fn update_with_expression( [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters [INFO] [stdout] help: consider removing the parameter [INFO] [stdout] | [INFO] [stdout] 247 - pub async fn update_with_expression( [INFO] [stdout] 247 + pub async fn update_with_expression( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type parameter `T` goes unused in function definition [INFO] [stdout] --> src/dynamodb_context/dynamodb_table.rs:271:39 [INFO] [stdout] | [INFO] [stdout] 271 | pub async fn update_with_condition( [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters [INFO] [stdout] help: consider removing the parameter [INFO] [stdout] | [INFO] [stdout] 271 - pub async fn update_with_condition( [INFO] [stdout] 271 + pub async fn update_with_condition( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dynamodb_context/dynamodb_table.rs:400:9 [INFO] [stdout] | [INFO] [stdout] 400 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 400 - return Ok(()); [INFO] [stdout] 400 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/dynamodb_context/dynamodb_table.rs:394:12 [INFO] [stdout] | [INFO] [stdout] 394 | if final_unprocessed.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!final_unprocessed.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dynamodb_context/dynamodb_table.rs:440:9 [INFO] [stdout] | [INFO] [stdout] 440 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 440 - return Ok(()); [INFO] [stdout] 440 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/dynamodb_context/dynamodb_table.rs:434:12 [INFO] [stdout] | [INFO] [stdout] 434 | if final_unprocessed.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!final_unprocessed.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dynamodb_context/dynamodb_table.rs:484:9 [INFO] [stdout] | [INFO] [stdout] 484 | return Ok(requests); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 484 - return Ok(requests); [INFO] [stdout] 484 + Ok(requests) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `dynamodb_context::expression::conditional::operations::ConditionalOpeartion` [INFO] [stdout] --> src/dynamodb_context/expression/conditional/operations.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn to_string(&self) -> String { [INFO] [stdout] 13 | | match self { [INFO] [stdout] 14 | | ConditionalOpeartion::And => String::from("AND"), [INFO] [stdout] 15 | | ConditionalOpeartion::Or => String::from("OR"), [INFO] [stdout] 16 | | } [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `dynamodb_context::expression::conditional::operations::ConditionalOpeartion` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dynamodb_context/expression/conditional/mod.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return result; [INFO] [stdout] 75 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dynamodb_context/expression/conditional/mod.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 - return result; [INFO] [stdout] 115 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `dynamodb_context::expression::conditional::ConditionalExpression` [INFO] [stdout] --> src/dynamodb_context/expression/conditional/mod.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | / pub fn to_string(&self) -> String { [INFO] [stdout] 119 | | let mut context = ExpressionContext::new("vc"); [INFO] [stdout] 120 | | self.to_string_with_context(&mut context) [INFO] [stdout] 121 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `dynamodb_context::expression::conditional::ConditionalExpression` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `dynamodb_context::expression::update::UpdateExpression` [INFO] [stdout] --> src/dynamodb_context/expression/update/mod.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 64 | / pub fn to_string(&self) -> String { [INFO] [stdout] 65 | | let mut context = ExpressionContext::new("vu"); [INFO] [stdout] 66 | | self.to_string_with_context(&mut context) [INFO] [stdout] 67 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `dynamodb_context::expression::update::UpdateExpression` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type parameter `T` goes unused in function definition [INFO] [stdout] --> src/dynamodb_context/dynamodb_table.rs:45:24 [INFO] [stdout] | [INFO] [stdout] 45 | pub async fn exists(&self, key: KeyValue) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters [INFO] [stdout] = note: `#[warn(clippy::extra_unused_type_parameters)]` on by default [INFO] [stdout] help: consider removing the parameter [INFO] [stdout] | [INFO] [stdout] 45 - pub async fn exists(&self, key: KeyValue) -> Result { [INFO] [stdout] 45 + pub async fn exists(&self, key: KeyValue) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dynamodb_context/dynamodb_table.rs:55:9 [INFO] [stdout] | [INFO] [stdout] 55 | / return match row_exists_result { [INFO] [stdout] 56 | | Ok(x) => Ok(x.item.is_some()), [INFO] [stdout] 57 | | Err(e) => Err(Error::sdk_error("Failure while checking if row exists", e)), [INFO] [stdout] 58 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 ~ match row_exists_result { [INFO] [stdout] 56 + Ok(x) => Ok(x.item.is_some()), [INFO] [stdout] 57 + Err(e) => Err(Error::sdk_error("Failure while checking if row exists", e)), [INFO] [stdout] 58 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dynamodb_context/expression/update/mod.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 140 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 140 - return result; [INFO] [stdout] 140 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dynamodb_context/expression/update/mod.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 166 - return result; [INFO] [stdout] 166 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dynamodb_context/dynamodb_table.rs:215:9 [INFO] [stdout] | [INFO] [stdout] 215 | return Ok(GetListResult::new(result, last_key)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 215 - return Ok(GetListResult::new(result, last_key)); [INFO] [stdout] 215 + Ok(GetListResult::new(result, last_key)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type parameter `T` goes unused in function definition [INFO] [stdout] --> src/dynamodb_context/dynamodb_table.rs:247:40 [INFO] [stdout] | [INFO] [stdout] 247 | pub async fn update_with_expression( [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters [INFO] [stdout] help: consider removing the parameter [INFO] [stdout] | [INFO] [stdout] 247 - pub async fn update_with_expression( [INFO] [stdout] 247 + pub async fn update_with_expression( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type parameter `T` goes unused in function definition [INFO] [stdout] --> src/dynamodb_context/dynamodb_table.rs:271:39 [INFO] [stdout] | [INFO] [stdout] 271 | pub async fn update_with_condition( [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_type_parameters [INFO] [stdout] help: consider removing the parameter [INFO] [stdout] | [INFO] [stdout] 271 - pub async fn update_with_condition( [INFO] [stdout] 271 + pub async fn update_with_condition( [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dynamodb_context/dynamodb_table.rs:400:9 [INFO] [stdout] | [INFO] [stdout] 400 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 400 - return Ok(()); [INFO] [stdout] 400 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/dynamodb_context/dynamodb_table.rs:394:12 [INFO] [stdout] | [INFO] [stdout] 394 | if final_unprocessed.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!final_unprocessed.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dynamodb_context/dynamodb_table.rs:440:9 [INFO] [stdout] | [INFO] [stdout] 440 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 440 - return Ok(()); [INFO] [stdout] 440 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/dynamodb_sdk_extensions/with_expresssion.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 57 | if &result != SET { [INFO] [stdout] | -------^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: use the left value directly: `result` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/dynamodb_context/dynamodb_table.rs:434:12 [INFO] [stdout] | [INFO] [stdout] 434 | if final_unprocessed.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!final_unprocessed.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dynamodb_sdk_extensions/with_expresssion.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return result; [INFO] [stdout] 78 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dynamodb_context/dynamodb_table.rs:484:9 [INFO] [stdout] | [INFO] [stdout] 484 | return Ok(requests); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 484 - return Ok(requests); [INFO] [stdout] 484 + Ok(requests) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/key.rs:108:23 [INFO] [stdout] | [INFO] [stdout] 108 | sort_key: sort_key.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `sort_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/key.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 - return false; [INFO] [stdout] 151 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `dynamodb_context::expression::conditional::operations::ConditionalOpeartion` [INFO] [stdout] --> src/dynamodb_context/expression/conditional/operations.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn to_string(&self) -> String { [INFO] [stdout] 13 | | match self { [INFO] [stdout] 14 | | ConditionalOpeartion::And => String::from("AND"), [INFO] [stdout] 15 | | ConditionalOpeartion::Or => String::from("OR"), [INFO] [stdout] 16 | | } [INFO] [stdout] 17 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `dynamodb_context::expression::conditional::operations::ConditionalOpeartion` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] = note: `#[warn(clippy::inherent_to_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/key.rs:219:9 [INFO] [stdout] | [INFO] [stdout] 219 | / return Ok(KeyValue::PartitionKey { [INFO] [stdout] 220 | | key: partition_key, [INFO] [stdout] 221 | | value: partition_key_value.clone(), [INFO] [stdout] 222 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 219 ~ Ok(KeyValue::PartitionKey { [INFO] [stdout] 220 + key: partition_key, [INFO] [stdout] 221 + value: partition_key_value.clone(), [INFO] [stdout] 222 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/key.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 241 - return result; [INFO] [stdout] 241 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dynamodb_context/expression/conditional/mod.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return result; [INFO] [stdout] 75 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/key.rs:297:17 [INFO] [stdout] | [INFO] [stdout] 297 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 297 - return false; [INFO] [stdout] 297 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/key.rs:303:17 [INFO] [stdout] | [INFO] [stdout] 303 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 303 - return false; [INFO] [stdout] 303 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/key.rs:319:17 [INFO] [stdout] | [INFO] [stdout] 319 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 319 - return false; [INFO] [stdout] 319 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/key.rs:325:17 [INFO] [stdout] | [INFO] [stdout] 325 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 325 - return false; [INFO] [stdout] 325 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dynamodb_context/expression/conditional/mod.rs:115:9 [INFO] [stdout] | [INFO] [stdout] 115 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 - return result; [INFO] [stdout] 115 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `dynamodb_context::expression::conditional::ConditionalExpression` [INFO] [stdout] --> src/dynamodb_context/expression/conditional/mod.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | / pub fn to_string(&self) -> String { [INFO] [stdout] 119 | | let mut context = ExpressionContext::new("vc"); [INFO] [stdout] 120 | | self.to_string_with_context(&mut context) [INFO] [stdout] 121 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `dynamodb_context::expression::conditional::ConditionalExpression` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/key.rs:345:17 [INFO] [stdout] | [INFO] [stdout] 345 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 345 - return false; [INFO] [stdout] 345 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/key.rs:351:17 [INFO] [stdout] | [INFO] [stdout] 351 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 351 - return false; [INFO] [stdout] 351 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: local variable doesn't need to be boxed here [INFO] [stdout] --> src/traits/deletable.rs:11:28 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn into_delete_request(deletable: Box<&dyn Deletable>) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stdout] = note: `#[warn(clippy::boxed_local)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/deletable.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | / return match key { [INFO] [stdout] 15 | | KeyValue::CompositeKey { partition_key, partition_key_value, sort_key, sort_key_value } => { [INFO] [stdout] 16 | | Ok(builder [INFO] [stdout] 17 | | .key(partition_key, partition_key_value) [INFO] [stdout] ... | [INFO] [stdout] 30 | | }, [INFO] [stdout] 31 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ match key { [INFO] [stdout] 15 + KeyValue::CompositeKey { partition_key, partition_key_value, sort_key, sort_key_value } => { [INFO] [stdout] 16 + Ok(builder [INFO] [stdout] 17 + .key(partition_key, partition_key_value) [INFO] [stdout] 18 + .key(sort_key, sort_key_value) [INFO] [stdout] 19 + .build() [INFO] [stdout] 20 + .map_err(|e| Error::sdk_error("Error while building delete request.", e)))? [INFO] [stdout] 21 + [INFO] [stdout] 22 + }, [INFO] [stdout] 23 + KeyValue::PartitionKey { key, value } => { [INFO] [stdout] 24 + Ok( [INFO] [stdout] 25 + builder [INFO] [stdout] 26 + .key(key, value) [INFO] [stdout] 27 + .build() [INFO] [stdout] 28 + .map_err(|e| Error::sdk_error("Error while building delete request.", e))? [INFO] [stdout] 29 + ) [INFO] [stdout] 30 + }, [INFO] [stdout] 31 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/from_attribute_value.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | return Err(Error::parse_error(value, "T", String::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return Err(Error::parse_error(value, "T", String::new())); [INFO] [stdout] 19 + Err(Error::parse_error(value, "T", String::new())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/from_attribute_value.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return Ok(None); [INFO] [stdout] 29 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/from_attribute_value.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | return T::from_attribute_value(value).map(|x| Some(x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return T::from_attribute_value(value).map(|x| Some(x)); [INFO] [stdout] 31 + T::from_attribute_value(value).map(|x| Some(x)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/from_attribute_value.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | return Err(Error::parse_error(value, "Vec", String::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return Err(Error::parse_error(value, "Vec", String::new())); [INFO] [stdout] 48 + Err(Error::parse_error(value, "Vec", String::new())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/from_attribute_value.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | return Err(Error::parse_error(value, "String", String::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return Err(Error::parse_error(value, "String", String::new())); [INFO] [stdout] 57 + Err(Error::parse_error(value, "String", String::new())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/from_attribute_value.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | return Err(Error::parse_error(value, "i32", String::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return Err(Error::parse_error(value, "i32", String::new())); [INFO] [stdout] 68 + Err(Error::parse_error(value, "i32", String::new())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/traits/from_attribute_value.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | / if let Ok(number) = value.as_n() { [INFO] [stdout] 64 | | if let Ok(parsed_value) = number.parse::() { [INFO] [stdout] 65 | | return Ok(parsed_value); [INFO] [stdout] 66 | | } [INFO] [stdout] 67 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 63 ~ if let Ok(number) = value.as_n() [INFO] [stdout] 64 ~ && let Ok(parsed_value) = number.parse::() { [INFO] [stdout] 65 | return Ok(parsed_value); [INFO] [stdout] 66 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/from_attribute_value.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | return Err(Error::parse_error(value, "u32", String::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return Err(Error::parse_error(value, "u32", String::new())); [INFO] [stdout] 79 + Err(Error::parse_error(value, "u32", String::new())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/traits/from_attribute_value.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | / if let Ok(number) = value.as_n() { [INFO] [stdout] 75 | | if let Ok(parsed_value) = number.parse::() { [INFO] [stdout] 76 | | return Ok(parsed_value); [INFO] [stdout] 77 | | } [INFO] [stdout] 78 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 74 ~ if let Ok(number) = value.as_n() [INFO] [stdout] 75 ~ && let Ok(parsed_value) = number.parse::() { [INFO] [stdout] 76 | return Ok(parsed_value); [INFO] [stdout] 77 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/from_attribute_value.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | return Err(Error::parse_error(value, "f32", String::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return Err(Error::parse_error(value, "f32", String::new())); [INFO] [stdout] 90 + Err(Error::parse_error(value, "f32", String::new())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/traits/from_attribute_value.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | / if let Ok(number) = value.as_n() { [INFO] [stdout] 86 | | if let Ok(parsed_value) = number.parse::() { [INFO] [stdout] 87 | | return Ok(parsed_value); [INFO] [stdout] 88 | | } [INFO] [stdout] 89 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 85 ~ if let Ok(number) = value.as_n() [INFO] [stdout] 86 ~ && let Ok(parsed_value) = number.parse::() { [INFO] [stdout] 87 | return Ok(parsed_value); [INFO] [stdout] 88 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/from_attribute_value.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | return Err(Error::parse_error(value, "bool", String::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - return Err(Error::parse_error(value, "bool", String::new())); [INFO] [stdout] 99 + Err(Error::parse_error(value, "bool", String::new())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/from_attribute_value.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | return Err(Error::parse_error(value, "HashSet", String::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 - return Err(Error::parse_error(value, "HashSet", String::new())); [INFO] [stdout] 112 + Err(Error::parse_error(value, "HashSet", String::new())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/from_attribute_value.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | return Err(Error::parse_error(value, "HashSet", String::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 132 - return Err(Error::parse_error(value, "HashSet", String::new())); [INFO] [stdout] 132 + Err(Error::parse_error(value, "HashSet", String::new())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/from_attribute_value.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | / return Err(Error::parse_error( [INFO] [stdout] 153 | | value, [INFO] [stdout] 154 | | "Result", [INFO] [stdout] 155 | | String::new(), [INFO] [stdout] 156 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 ~ Err(Error::parse_error( [INFO] [stdout] 153 + value, [INFO] [stdout] 154 + "Result", [INFO] [stdout] 155 + String::new(), [INFO] [stdout] 156 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `into_*` usually take `self` by value [INFO] [stdout] --> src/traits/into_attribute_value.rs:8:29 [INFO] [stdout] | [INFO] [stdout] 8 | fn into_attribute_value(&self) -> AttributeValue; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/traits/into_attribute_value.rs:58:32 [INFO] [stdout] | [INFO] [stdout] 58 | AttributeValue::Ss(self.iter().map(|x| x.clone()).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.iter().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/matches_template.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return true; [INFO] [stdout] 41 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/traits/matches_template.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | / if !begins_with_variable { [INFO] [stdout] 21 | | if !value.starts_with(parts[0]) { [INFO] [stdout] 22 | | return false; [INFO] [stdout] 23 | | } [INFO] [stdout] 24 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 20 ~ if !begins_with_variable [INFO] [stdout] 21 ~ && !value.starts_with(parts[0]) { [INFO] [stdout] 22 | return false; [INFO] [stdout] 23 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/traits/matches_template.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | / if !ends_with_variable { [INFO] [stdout] 28 | | if !value.ends_with(parts[parts.len() - 1]) { [INFO] [stdout] 29 | | return false; [INFO] [stdout] 30 | | } [INFO] [stdout] 31 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 27 ~ if !ends_with_variable [INFO] [stdout] 28 ~ && !value.ends_with(parts[parts.len() - 1]) { [INFO] [stdout] 29 | return false; [INFO] [stdout] 30 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/traits/serde_dynamo_attribute_value_into.rs:29:58 [INFO] [stdout] | [INFO] [stdout] 29 | AttributeValue::Bs(items.into_iter().map(|x| Blob::from(x)).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Blob::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/serde_dynamo_attribute_value_into.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return result; [INFO] [stdout] 49 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: implementation of inherent method `to_string(&self) -> String` for type `dynamodb_context::expression::update::UpdateExpression` [INFO] [stdout] --> src/dynamodb_context/expression/update/mod.rs:64:5 [INFO] [stdout] | [INFO] [stdout] 64 | / pub fn to_string(&self) -> String { [INFO] [stdout] 65 | | let mut context = ExpressionContext::new("vu"); [INFO] [stdout] 66 | | self.to_string_with_context(&mut context) [INFO] [stdout] 67 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: implement trait `Display` for type `dynamodb_context::expression::update::UpdateExpression` instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inherent_to_string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dynamodb_context/expression/update/mod.rs:140:9 [INFO] [stdout] | [INFO] [stdout] 140 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 140 - return result; [INFO] [stdout] 140 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dynamodb_context/expression/update/mod.rs:166:9 [INFO] [stdout] | [INFO] [stdout] 166 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 166 - return result; [INFO] [stdout] 166 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking example v0.1.0 (/opt/rustwide/workdir/examples/signup) [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/dynamodb_context/expression/update/mod.rs:291:83 [INFO] [stdout] | [INFO] [stdout] 291 | UpdateExpression::new_add("other_count".into(), AttributeValue::N(format!("-1"))), [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-1".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/dynamodb_context/expression/update/mod.rs:340:31 [INFO] [stdout] | [INFO] [stdout] 340 | AttributeValue::N(format!("-1")), [INFO] [stdout] | ^^^^^^^^^^^^^ help: consider using `.to_string()`: `"-1".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/dynamodb_sdk_extensions/with_expresssion.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 57 | if &result != SET { [INFO] [stdout] | -------^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: use the left value directly: `result` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/dynamodb_sdk_extensions/with_expresssion.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return result; [INFO] [stdout] 78 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/key.rs:108:23 [INFO] [stdout] | [INFO] [stdout] 108 | sort_key: sort_key.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `sort_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/key.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 - return false; [INFO] [stdout] 151 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/key.rs:219:9 [INFO] [stdout] | [INFO] [stdout] 219 | / return Ok(KeyValue::PartitionKey { [INFO] [stdout] 220 | | key: partition_key, [INFO] [stdout] 221 | | value: partition_key_value.clone(), [INFO] [stdout] 222 | | }); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 219 ~ Ok(KeyValue::PartitionKey { [INFO] [stdout] 220 + key: partition_key, [INFO] [stdout] 221 + value: partition_key_value.clone(), [INFO] [stdout] 222 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/key.rs:241:9 [INFO] [stdout] | [INFO] [stdout] 241 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 241 - return result; [INFO] [stdout] 241 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/key.rs:297:17 [INFO] [stdout] | [INFO] [stdout] 297 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 297 - return false; [INFO] [stdout] 297 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/key.rs:303:17 [INFO] [stdout] | [INFO] [stdout] 303 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 303 - return false; [INFO] [stdout] 303 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/key.rs:319:17 [INFO] [stdout] | [INFO] [stdout] 319 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 319 - return false; [INFO] [stdout] 319 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/key.rs:325:17 [INFO] [stdout] | [INFO] [stdout] 325 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 325 - return false; [INFO] [stdout] 325 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/key.rs:345:17 [INFO] [stdout] | [INFO] [stdout] 345 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 345 - return false; [INFO] [stdout] 345 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/key.rs:351:17 [INFO] [stdout] | [INFO] [stdout] 351 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 351 - return false; [INFO] [stdout] 351 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: local variable doesn't need to be boxed here [INFO] [stdout] --> src/traits/deletable.rs:11:28 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn into_delete_request(deletable: Box<&dyn Deletable>) -> Result { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#boxed_local [INFO] [stdout] = note: `#[warn(clippy::boxed_local)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/deletable.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | / return match key { [INFO] [stdout] 15 | | KeyValue::CompositeKey { partition_key, partition_key_value, sort_key, sort_key_value } => { [INFO] [stdout] 16 | | Ok(builder [INFO] [stdout] 17 | | .key(partition_key, partition_key_value) [INFO] [stdout] ... | [INFO] [stdout] 30 | | }, [INFO] [stdout] 31 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 14 ~ match key { [INFO] [stdout] 15 + KeyValue::CompositeKey { partition_key, partition_key_value, sort_key, sort_key_value } => { [INFO] [stdout] 16 + Ok(builder [INFO] [stdout] 17 + .key(partition_key, partition_key_value) [INFO] [stdout] 18 + .key(sort_key, sort_key_value) [INFO] [stdout] 19 + .build() [INFO] [stdout] 20 + .map_err(|e| Error::sdk_error("Error while building delete request.", e)))? [INFO] [stdout] 21 + [INFO] [stdout] 22 + }, [INFO] [stdout] 23 + KeyValue::PartitionKey { key, value } => { [INFO] [stdout] 24 + Ok( [INFO] [stdout] 25 + builder [INFO] [stdout] 26 + .key(key, value) [INFO] [stdout] 27 + .build() [INFO] [stdout] 28 + .map_err(|e| Error::sdk_error("Error while building delete request.", e))? [INFO] [stdout] 29 + ) [INFO] [stdout] 30 + }, [INFO] [stdout] 31 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/from_attribute_value.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | return Err(Error::parse_error(value, "T", String::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 19 - return Err(Error::parse_error(value, "T", String::new())); [INFO] [stdout] 19 + Err(Error::parse_error(value, "T", String::new())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/from_attribute_value.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return Ok(None); [INFO] [stdout] 29 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/from_attribute_value.rs:31:13 [INFO] [stdout] | [INFO] [stdout] 31 | return T::from_attribute_value(value).map(|x| Some(x)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 31 - return T::from_attribute_value(value).map(|x| Some(x)); [INFO] [stdout] 31 + T::from_attribute_value(value).map(|x| Some(x)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/from_attribute_value.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | return Err(Error::parse_error(value, "Vec", String::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 48 - return Err(Error::parse_error(value, "Vec", String::new())); [INFO] [stdout] 48 + Err(Error::parse_error(value, "Vec", String::new())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/from_attribute_value.rs:57:9 [INFO] [stdout] | [INFO] [stdout] 57 | return Err(Error::parse_error(value, "String", String::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return Err(Error::parse_error(value, "String", String::new())); [INFO] [stdout] 57 + Err(Error::parse_error(value, "String", String::new())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/from_attribute_value.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 68 | return Err(Error::parse_error(value, "i32", String::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 68 - return Err(Error::parse_error(value, "i32", String::new())); [INFO] [stdout] 68 + Err(Error::parse_error(value, "i32", String::new())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/traits/from_attribute_value.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | / if let Ok(number) = value.as_n() { [INFO] [stdout] 64 | | if let Ok(parsed_value) = number.parse::() { [INFO] [stdout] 65 | | return Ok(parsed_value); [INFO] [stdout] 66 | | } [INFO] [stdout] 67 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 63 ~ if let Ok(number) = value.as_n() [INFO] [stdout] 64 ~ && let Ok(parsed_value) = number.parse::() { [INFO] [stdout] 65 | return Ok(parsed_value); [INFO] [stdout] 66 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/from_attribute_value.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | return Err(Error::parse_error(value, "u32", String::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 - return Err(Error::parse_error(value, "u32", String::new())); [INFO] [stdout] 79 + Err(Error::parse_error(value, "u32", String::new())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/traits/from_attribute_value.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | / if let Ok(number) = value.as_n() { [INFO] [stdout] 75 | | if let Ok(parsed_value) = number.parse::() { [INFO] [stdout] 76 | | return Ok(parsed_value); [INFO] [stdout] 77 | | } [INFO] [stdout] 78 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 74 ~ if let Ok(number) = value.as_n() [INFO] [stdout] 75 ~ && let Ok(parsed_value) = number.parse::() { [INFO] [stdout] 76 | return Ok(parsed_value); [INFO] [stdout] 77 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/from_attribute_value.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 90 | return Err(Error::parse_error(value, "f32", String::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 90 - return Err(Error::parse_error(value, "f32", String::new())); [INFO] [stdout] 90 + Err(Error::parse_error(value, "f32", String::new())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/traits/from_attribute_value.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | / if let Ok(number) = value.as_n() { [INFO] [stdout] 86 | | if let Ok(parsed_value) = number.parse::() { [INFO] [stdout] 87 | | return Ok(parsed_value); [INFO] [stdout] 88 | | } [INFO] [stdout] 89 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 85 ~ if let Ok(number) = value.as_n() [INFO] [stdout] 86 ~ && let Ok(parsed_value) = number.parse::() { [INFO] [stdout] 87 | return Ok(parsed_value); [INFO] [stdout] 88 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/from_attribute_value.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | return Err(Error::parse_error(value, "bool", String::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 99 - return Err(Error::parse_error(value, "bool", String::new())); [INFO] [stdout] 99 + Err(Error::parse_error(value, "bool", String::new())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/from_attribute_value.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | return Err(Error::parse_error(value, "HashSet", String::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 - return Err(Error::parse_error(value, "HashSet", String::new())); [INFO] [stdout] 112 + Err(Error::parse_error(value, "HashSet", String::new())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/from_attribute_value.rs:132:9 [INFO] [stdout] | [INFO] [stdout] 132 | return Err(Error::parse_error(value, "HashSet", String::new())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 132 - return Err(Error::parse_error(value, "HashSet", String::new())); [INFO] [stdout] 132 + Err(Error::parse_error(value, "HashSet", String::new())) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/from_attribute_value.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 152 | / return Err(Error::parse_error( [INFO] [stdout] 153 | | value, [INFO] [stdout] 154 | | "Result", [INFO] [stdout] 155 | | String::new(), [INFO] [stdout] 156 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 ~ Err(Error::parse_error( [INFO] [stdout] 153 + value, [INFO] [stdout] 154 + "Result", [INFO] [stdout] 155 + String::new(), [INFO] [stdout] 156 ~ )) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `into_*` usually take `self` by value [INFO] [stdout] --> src/traits/into_attribute_value.rs:8:29 [INFO] [stdout] | [INFO] [stdout] 8 | fn into_attribute_value(&self) -> AttributeValue; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for cloning elements [INFO] [stdout] --> src/traits/into_attribute_value.rs:58:32 [INFO] [stdout] | [INFO] [stdout] 58 | AttributeValue::Ss(self.iter().map(|x| x.clone()).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `self.iter().cloned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/matches_template.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return true; [INFO] [stdout] 41 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/traits/matches_template.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | / if !begins_with_variable { [INFO] [stdout] 21 | | if !value.starts_with(parts[0]) { [INFO] [stdout] 22 | | return false; [INFO] [stdout] 23 | | } [INFO] [stdout] 24 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 20 ~ if !begins_with_variable [INFO] [stdout] 21 ~ && !value.starts_with(parts[0]) { [INFO] [stdout] 22 | return false; [INFO] [stdout] 23 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/traits/matches_template.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | / if !ends_with_variable { [INFO] [stdout] 28 | | if !value.ends_with(parts[parts.len() - 1]) { [INFO] [stdout] 29 | | return false; [INFO] [stdout] 30 | | } [INFO] [stdout] 31 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 27 ~ if !ends_with_variable [INFO] [stdout] 28 ~ && !value.ends_with(parts[parts.len() - 1]) { [INFO] [stdout] 29 | return false; [INFO] [stdout] 30 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/traits/serde_dynamo_attribute_value_into.rs:29:58 [INFO] [stdout] | [INFO] [stdout] 29 | AttributeValue::Bs(items.into_iter().map(|x| Blob::from(x)).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Blob::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/traits/serde_dynamo_attribute_value_into.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return result; [INFO] [stdout] 49 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-binding `let` on a future [INFO] [stdout] --> examples/signup/src/lib.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | let _ = context.insert_row(SignUp::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider awaiting the future or dropping explicitly with `std::mem::drop` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future [INFO] [stdout] = note: `#[warn(clippy::let_underscore_future)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-binding `let` on a future [INFO] [stdout] --> examples/signup/src/lib.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | let _ = context.insert_row(SignUp::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider awaiting the future or dropping explicitly with `std::mem::drop` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_underscore_future [INFO] [stdout] = note: `#[warn(clippy::let_underscore_future)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 12s [INFO] running `Command { std: "docker" "inspect" "debbc752403cba68e9a135634e9cf8b50a04d65c299f727fc882410d79f8a011", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "debbc752403cba68e9a135634e9cf8b50a04d65c299f727fc882410d79f8a011", kill_on_drop: false }` [INFO] [stdout] debbc752403cba68e9a135634e9cf8b50a04d65c299f727fc882410d79f8a011